* chore: Remove unused "rendertest" stuff (#6015) * fix: restore ability to create status change documents (#5963) * fix: restore ability to create status change documents Fixes #5962 * chore: address review comment * fix: Provide human-friendly status in submission status API response (#6011) Co-authored-by: nectostr <bastinda96@gmail.com> * fix: Make name/email lookups case-insensitive (#5972) (#6007) * fix: Make name/email lookups case-insensitive (#5972) Use icontains so that looking up name or email is case insensitive Added a test Fixes: 5972 * fix: Use __iexact not __icontains * fix: Clarify no-action-needed (#5918) (#6020) When a draft is submitted for manual processing, clarify that no action is needed; the Secretariat has the next steps. Fixes: #5918 * fix: Fix menu hover issue (#6019) * fix: Fix menu hover issue Fixes #5702 * Fix leftmenu hover issue * fix: Server error from api_get_session_materials() (#6025) Fixes #5877 * fix: Clarify Questionnaire label (#4688) (#6017) When filtering nominees, `Questionnaire` implies `Accepted == yes` so fix the dropdown test tosay that. Fixes: #4688 * chore: Merge from @martinthomson's rfc-txt-html (#6023) * fix:no history entry when changing RFC Editor note for doc (#6021) * fix:no history entry when changing RFC Editor note for doc * fix:no history entry when changing RFC Editor note for doc --------- Co-authored-by: Priyanka Narkar <priyankanarkar@dhcp-91f8.meeting.ietf.org> * fix: avoid deprecation warning on view_list() for objs without CommunityList Fixes #5942 * fix: return 404 for non-existing revisions (#6014) * fix: return 404 for non-existing revisions Links to non-existing revisions to docs should return 404 * fix: change rfc/rev and search behaviour * refactor: fix tab level * fix: return 404 for rfc revision for bibtex * fix: provide date for revisions in bibtex output (#6029) * fix: provide date for revisions in bibtex output * refactor: change walrus to if's * fix: specify particular revision for events * fix: review refactoring issue fixes #5447 * fix: Remove automatically suggested document for document that is already has review request (fixes #3211) (#5425) * Added check that if there is already review request for the document in question, ignore the automatic suggestion for that document. Fixes #3211. * fix: dont block on open requests for a previous version. Add tests --------- Co-authored-by: Nicolas Giard <github@ngpixel.com> Co-authored-by: Robert Sparks <rjsparks@nostrum.com> * feat: IAB statements (#5940) * feat: support iab and iesg statements. Import iab statements. (#5895) * feat: infrastructure for statements doctype * chore: basic test framework * feat: basic statement document view * feat: show replaced statements * chore: black * fix: state help for statements * fix: cleanout non-relevant email expansions * feat: import iab statements, provide group statements tab * fix: guard against running import twice * feat: build redirect csv for iab statements * fix: set document state on import * feat: show published date on main doc view * feat: handle pdf statements * feat: create new and update statements * chore: copyright block updates * chore: remove flakes * chore: black * feat: add edit/new buttons for the secretariat * fix: address PR #5895 review comments * fix: pin pydantic until inflect catches up (#5901) (#5902) * chore: re-un-pin pydantic * feat: include submitter in email about submitted slides (#6033) * feat: include submitter in email about submitted slides fixes #6031 * chore: remove unintended whitespace change * chore(dev): update .vscode/settings.json with new taskExplorer settings * fix: Add editorial stream to proceedings (#6027) * fix: Add editorial stream to proceedings Fixes #5717 * fix: Move editorial stream after the irtf in proceedings * fix: Add editorial stream to meeting materials (#6047) Fixes #6042 * fix: Shows requested reviews for doc fixes (#6022) * Fix: Shows requested reviews for doc * Changed template includes to only give required variables to them. * feat: allow openId to choose an unactive email if there are none active (#6041) * feat: allow openId to choose an unactive email if there are no active ones * chore: correct typo * chore: rename unactive to inactive * fix: Make review table more responsive (#6053) * fix: Improve layout of review table * Progress * Progress * Final changes * Fix tests * Remove fluff * Undo commits * ci: add --validate-html-harder to tests * ci: add --validate-html-harder to build.yml workflow * fix: Set colspan to actual number of columns (#6069) * fix: Clean up view_feedback_pending (#6070) - Remove "Unclassified" column header, which caused misalignment in the table body. - Show the message author - previously displayed as `(None)`. * docs: Update LICENSE year * fix: Remove IESG state edit button when state is 'dead' (#6051) (#6065) * fix: Correctly order "last call requested" column in the IESG dashboard (#6079) * ci: update dev sandbox init script to start memcached * feat: Reclassify nomcom feedback (#6002) * fix: Clean up view_feedback_pending - Remove "Unclassified" column header, which caused misalignment in the table body. - Show the message author - previously displayed as `(None)`. * feat: Reclassify nomcom feedback (#4669) - There's a new `Chair/Advisor Tasks` menu item `Reclassify feedback`. - I overloaded `view_feedback*` URLs with a `?reclassify` parameter. - This adds a checkbox to each feedback message, and a `Reclassify` button at the bottom of each feedback page. - "Reclassifying" basically de-classifies the feedback, and punts it back to the "Pending emails" view for reclassification. - If a feedback has been applied to multiple nominees, declassifying it from one nominee removes it from all. * fix: Remove unused local variables * fix: Fix some missing and mis-nested html * test: Add tests for reclassifying feedback * refactor: Substantial redesign of feedback reclassification - Break out reclassify_feedback* as their own URLs and views, and revert changes to view_feedback*.html. - Replace checkboxes with a Reclassify button on each message. * fix: Remember to clear the feedback associations when reclassifying * feat: Add an 'Overcome by events' feedback type * refactor: When invoking reclassification from a view-feedback page, load the corresponding reclassify-feedback page * fix: De-conflict migration with 0004_statements Also change the coding style to match, and add a reverse migration. * fix: Fix a test case to account for new feedback type * fix: 842e730 broke the Back button * refactor: Reclassify feedback directly instead of putting it back in the work queue * fix: Adjust tests to new workflow * refactor: Further refine reclassification to avoid redirects * refactor: Impose a FeedbackTypeName ordering Also add FeedbackTypeName.legend field, rather than synthesizing it every time we classify or reclassify feedback. In the reclassification forms, only show the relevant feedback types. * refactor: Merge reclassify_feedback_* back into view_feedback_* This means the "Reclassify" button is always present, but eliminates some complexity. * refactor: Add filter(used=True) on FeedbackTypeName querysets * refactor: Add the new FeedbackTypeName to the reclassification success message * fix: Secure reclassification against rogue nomcom members * fix: Print decoded key and fully clean up test nomcom (#6094) * fix: Delete Person records when deleting a test nomcom * fix: Decode test nomcom private key before printing * test: Use correct time zone for test_statement_doc_view (#6064) * chore(deps): update all npm dependencies for playwright (#6061) Co-authored-by: depfu[bot] <23717796+depfu[bot]@users.noreply.github.com> * chore(deps): update all npm dependencies for dev/diff (#6062) Co-authored-by: depfu[bot] <23717796+depfu[bot]@users.noreply.github.com> * chore(deps): update all npm dependencies for dev/coverage-action (#6063) Co-authored-by: depfu[bot] <23717796+depfu[bot]@users.noreply.github.com> * fix: Hash cache key for default memcached cache (#6089) * feat: Show docs that an AD hasn't balloted on that need ballots to progress (#6075) * fix(doc): Unify help texts for document states (#6060) * Fix IESG State help text link (only) * Intermediate checkpoint * Correct URL filtering of state descriptions * Unify help texts for document states * Remove redundant load static from template --------- Co-authored-by: Robert Sparks <rjsparks@nostrum.com> * ci: fix sandbox start.sh memcached user * fix: refactor how settings handles cache definitions (#6099) * fix: refactor how settings handles cache definitions * chore: more english-speaker readable expression * fix: Cast cache key to str before calling encode (#6100) --------- Co-authored-by: Robert Sparks <rjsparks@nostrum.com> Co-authored-by: Liubov Kurafeeva <liubov.kurafeeva@gmail.com> Co-authored-by: nectostr <bastinda96@gmail.com> Co-authored-by: Rich Salz <rsalz@akamai.com> Co-authored-by: PriyankaN <priyanka@amsl.com> Co-authored-by: Priyanka Narkar <priyankanarkar@dhcp-91f8.meeting.ietf.org> Co-authored-by: Ali <alireza83@gmail.com> Co-authored-by: Roman Beltiukov <maybe.hello.world@gmail.com> Co-authored-by: Tero Kivinen <kivinen@iki.fi> Co-authored-by: Nicolas Giard <github@ngpixel.com> Co-authored-by: Kesara Rathnayake <kesara@fq.nz> Co-authored-by: Jennifer Richards <jennifer@staff.ietf.org> Co-authored-by: Paul Selkirk <paul@painless-security.com> Co-authored-by: depfu[bot] <23717796+depfu[bot]@users.noreply.github.com> Co-authored-by: Jim Fenton <fenton@bluepopcorn.net>
283 lines
11 KiB
HTML
283 lines
11 KiB
HTML
{% extends "base.html" %}
|
|
{# Copyright The IETF Trust 2015-2019, All Rights Reserved #}
|
|
{% load origin %}
|
|
{% load django_bootstrap5 static ietf_filters %}
|
|
{% block pagehead %}
|
|
<link rel="stylesheet" href="{% static "ietf/css/list.css" %}">
|
|
{{ review_wish_form.media.css }}
|
|
{% endblock %}
|
|
{% block title %}Review overview for {{ request.user }}{% endblock %}
|
|
{% block content %}
|
|
{% origin %}
|
|
<h1>
|
|
Review overview
|
|
<br>
|
|
<small class="text-body-secondary">{{ request.user }}</small>
|
|
</h1>
|
|
<h2 class="mt-4">Assigned reviews</h2>
|
|
{% if open_review_assignments %}
|
|
<table class="table table-sm table-striped tablesorter">
|
|
<thead>
|
|
<tr>
|
|
<th scope="col" data-sort="document">Document</th>
|
|
<th scope="col" data-sort="version">Version Requested</th>
|
|
<th scope="col" data-sort="num">Current Version</th>
|
|
<th scope="col" data-sort="team">Team</th>
|
|
<th scope="col" data-sort="type">Type</th>
|
|
<th scope="col" data-sort="date">Deadline</th>
|
|
</tr>
|
|
</thead>
|
|
<tbody>
|
|
{% for r in open_review_assignments %}
|
|
<tr>
|
|
<td>
|
|
<a {% if r.pk != None %}href="{% url "ietf.doc.views_review.review_request" name=r.review_request.doc.name request_id=r.review_request.pk %}"{% endif %}>
|
|
{{ r.review_request.doc.name }}
|
|
</a>
|
|
</td>
|
|
<td>
|
|
{% if r.review_request.requested_rev %}
|
|
{{ r.review_request.requested_rev }}
|
|
{% else %}
|
|
Current
|
|
{% endif %}
|
|
</td>
|
|
<td>{{ r.review_request.doc.rev }}</td>
|
|
<td>
|
|
<a href="{% url 'ietf.group.views.review_requests' acronym=r.review_request.team.acronym %}">
|
|
{{ r.review_request.team.acronym }}
|
|
</a>
|
|
</td>
|
|
<td>{{ r.review_request.type.name }}</td>
|
|
<td>
|
|
{{ r.review_request.deadline|date:"Y-m-d" }}
|
|
{% if r.due %}<span class="badge rounded-pill text-bg-warning">{{ r.due }} day{{ r.due|pluralize }}</span>{% endif %}
|
|
</td>
|
|
</tr>
|
|
{% endfor %}
|
|
</tbody>
|
|
</table>
|
|
{% else %}
|
|
<p>
|
|
You do not have any open review requests assigned.
|
|
</p>
|
|
{% endif %}
|
|
<h2 class="mt-4">Latest closed review assignments</h2>
|
|
{% if closed_review_assignments %}
|
|
<table class="table table-sm table-striped tablesorter">
|
|
<thead>
|
|
<tr>
|
|
<th scope="col" data-sort="document">Document</th>
|
|
<th scope="col" data-sort="num">Version Reviewed</th>
|
|
<th scope="col" data-sort="team">Team</th>
|
|
<th scope="col" data-sort="type">Type</th>
|
|
<th scope="col" data-sort="date">Deadline</th>
|
|
<th scope="col" data-sort="state">State</th>
|
|
<th scope="col" data-sort="result">Result</th>
|
|
</tr>
|
|
</thead>
|
|
<tbody>
|
|
{% for r in closed_review_assignments %}
|
|
<tr>
|
|
<td>
|
|
<a {% if r.pk != None %}href="{% url "ietf.doc.views_review.review_request" name=r.review_request.doc.name request_id=r.review_request.pk %}"{% endif %}>
|
|
{{ r.review_request.doc.name }}
|
|
</a>
|
|
</td>
|
|
<td>
|
|
{{ r.reviewed_rev|default:"See review" }}
|
|
{% if r.review_request.requested_rev %}
|
|
{% if r.review_request.requested_rev != r.reviewed_rev %}({{ r.review_request.requested_rev }} requested){% endif %}
|
|
{% endif %}
|
|
</td>
|
|
<td>
|
|
<a href="{% url 'ietf.group.views.review_requests' acronym=r.review_request.team.acronym %}">
|
|
{{ r.review_request.team.acronym }}
|
|
</a>
|
|
</td>
|
|
<td>{{ r.review_request.type.name }}</td>
|
|
<td>
|
|
{{ r.review_request.deadline|date:"Y-m-d" }}
|
|
{% if r.due %}<span class="badge rounded-pill text-bg-warning">{{ r.due }} day{{ r.due|pluralize }}</span>{% endif %}
|
|
</td>
|
|
<td>
|
|
{{ r.state.name|badgeify }}
|
|
</td>
|
|
<td>
|
|
{% if r.result %}{{ r.result.name }}{% endif %}
|
|
</td>
|
|
</tr>
|
|
{% endfor %}
|
|
</tbody>
|
|
</table>
|
|
{% else %}
|
|
<p>
|
|
Did not find any closed review requests assigned to you.
|
|
</p>
|
|
{% endif %}
|
|
<h2 class="mt-4">
|
|
Review wishes
|
|
</h2>
|
|
{% if review_wishes %}
|
|
<p>
|
|
You have indicated that you would like to review:
|
|
</p>
|
|
<table class="table table-sm table-striped tablesorter">
|
|
<thead>
|
|
<tr>
|
|
<th scope="col">
|
|
Document
|
|
</th>
|
|
<th scope="col">
|
|
Team
|
|
</th>
|
|
<th scope="col">
|
|
</th>
|
|
</tr>
|
|
</thead>
|
|
<tbody>
|
|
{% for w in review_wishes %}
|
|
<tr>
|
|
<td>
|
|
<a href="{% url "ietf.doc.views_doc.document_main" w.doc.name %}">
|
|
{{ w.doc.name }}
|
|
</a>
|
|
</td>
|
|
<td>
|
|
{{ w.team.acronym }}
|
|
</td>
|
|
<td>
|
|
<form method="post">
|
|
{% csrf_token %}
|
|
<input name="wish_id" value="{{ w.pk }}" type="hidden">
|
|
<button class="btn btn-sm btn-danger float-end"
|
|
type="submit"
|
|
name="action"
|
|
value="delete_wish">
|
|
Delete
|
|
</button>
|
|
</form>
|
|
</td>
|
|
</tr>
|
|
{% endfor %}
|
|
</tbody>
|
|
</table>
|
|
{% else %}
|
|
<p>
|
|
You do not have any review wishes.
|
|
</p>
|
|
{% endif %}
|
|
{% if teams %}
|
|
<p>
|
|
Add an Internet-Draft that you would like to review when it becomes available for review:
|
|
</p>
|
|
<form method="post" class="form-inline">
|
|
{% csrf_token %}
|
|
{% bootstrap_form review_wish_form %}
|
|
<button class="btn btn-primary" type="submit" name="action" value="add_wish">
|
|
Add I-D
|
|
</button>
|
|
</form>
|
|
{% endif %}
|
|
{% for t in teams %}
|
|
<h2 class="mt-4">
|
|
Settings for {{ t }}
|
|
</h2>
|
|
<table class="table table-sm table-striped tablesorter">
|
|
<thead>
|
|
<tr>
|
|
<th scope="col" data-sort="setting">
|
|
Setting
|
|
</th>
|
|
<th scope="col" data-sort="value">
|
|
Value
|
|
</th>
|
|
</tr>
|
|
</thead>
|
|
<tbody>
|
|
<tr>
|
|
<th scope="row">
|
|
Can review
|
|
</th>
|
|
<td>
|
|
{{ t.reviewer_settings.get_min_interval_display|default:"No max frequency set" }}
|
|
</td>
|
|
</tr>
|
|
<tr>
|
|
<th scope="row">
|
|
Skip next assignments
|
|
</th>
|
|
<td>
|
|
{{ t.reviewer_settings.skip_next|yesno }}
|
|
</td>
|
|
</tr>
|
|
<tr>
|
|
<th scope="row">
|
|
Filter regexp
|
|
</th>
|
|
<td>
|
|
{% if t.reviewer_settings.filter_re %}
|
|
<code>{{ t.reviewer_settings.filter_re }}</code>
|
|
{% else %}
|
|
(None)
|
|
{% endif %}
|
|
</td>
|
|
</tr>
|
|
<tr>
|
|
<th scope="row">
|
|
Remind days before deadline
|
|
</th>
|
|
<td>
|
|
{{ t.reviewer_settings.remind_days_before_deadline|default:"(Do not remind)" }}
|
|
</td>
|
|
</tr>
|
|
<tr>
|
|
<th scope="row">
|
|
Periodic reminder of open reviews every X days
|
|
</th>
|
|
<td>
|
|
{{ t.reviewer_settings.remind_days_open_reviews|default:"(Do not remind)" }}
|
|
</td>
|
|
</tr>
|
|
<tr>
|
|
<th scope="row">
|
|
Select me next for an assignment
|
|
</th>
|
|
<td>
|
|
{{ t.reviewer_settings.request_assignment_next|yesno }}
|
|
</td>
|
|
</tr>
|
|
<tr>
|
|
<th scope="row">
|
|
Unavailable periods
|
|
</th>
|
|
<td>
|
|
{% if t.unavailable_periods %}
|
|
{% include "review/unavailable_table.html" with unavailable_periods=t.unavailable_periods %}
|
|
{% else %}
|
|
(No periods)
|
|
{% endif %}
|
|
</td>
|
|
</tr>
|
|
</tbody>
|
|
</table>
|
|
<div>
|
|
<a class="btn btn-primary"
|
|
href="{% url "ietf.group.views.change_reviewer_settings" group_type=t.type_id acronym=t.acronym reviewer_email=t.role.email.address %}?next={{ request.get_full_path|urlencode }}">
|
|
Change settings
|
|
</a>
|
|
</div>
|
|
{% empty %}
|
|
<h2 class="mt-4">
|
|
Settings
|
|
</h2>
|
|
<p>
|
|
It looks like you are not a reviewer in any active review team.
|
|
</p>
|
|
{% endfor %}
|
|
{% endblock %}
|
|
{% block js %}
|
|
{{ review_wish_form.media.js }}
|
|
<script src="{% static "ietf/js/list.js" %}">
|
|
</script>
|
|
{% endblock %} |