* chore: Remove unused "rendertest" stuff (#6015) * fix: restore ability to create status change documents (#5963) * fix: restore ability to create status change documents Fixes #5962 * chore: address review comment * fix: Provide human-friendly status in submission status API response (#6011) Co-authored-by: nectostr <bastinda96@gmail.com> * fix: Make name/email lookups case-insensitive (#5972) (#6007) * fix: Make name/email lookups case-insensitive (#5972) Use icontains so that looking up name or email is case insensitive Added a test Fixes: 5972 * fix: Use __iexact not __icontains * fix: Clarify no-action-needed (#5918) (#6020) When a draft is submitted for manual processing, clarify that no action is needed; the Secretariat has the next steps. Fixes: #5918 * fix: Fix menu hover issue (#6019) * fix: Fix menu hover issue Fixes #5702 * Fix leftmenu hover issue * fix: Server error from api_get_session_materials() (#6025) Fixes #5877 * fix: Clarify Questionnaire label (#4688) (#6017) When filtering nominees, `Questionnaire` implies `Accepted == yes` so fix the dropdown test tosay that. Fixes: #4688 * chore: Merge from @martinthomson's rfc-txt-html (#6023) * fix:no history entry when changing RFC Editor note for doc (#6021) * fix:no history entry when changing RFC Editor note for doc * fix:no history entry when changing RFC Editor note for doc --------- Co-authored-by: Priyanka Narkar <priyankanarkar@dhcp-91f8.meeting.ietf.org> * fix: avoid deprecation warning on view_list() for objs without CommunityList Fixes #5942 * fix: return 404 for non-existing revisions (#6014) * fix: return 404 for non-existing revisions Links to non-existing revisions to docs should return 404 * fix: change rfc/rev and search behaviour * refactor: fix tab level * fix: return 404 for rfc revision for bibtex * fix: provide date for revisions in bibtex output (#6029) * fix: provide date for revisions in bibtex output * refactor: change walrus to if's * fix: specify particular revision for events * fix: review refactoring issue fixes #5447 * fix: Remove automatically suggested document for document that is already has review request (fixes #3211) (#5425) * Added check that if there is already review request for the document in question, ignore the automatic suggestion for that document. Fixes #3211. * fix: dont block on open requests for a previous version. Add tests --------- Co-authored-by: Nicolas Giard <github@ngpixel.com> Co-authored-by: Robert Sparks <rjsparks@nostrum.com> * feat: IAB statements (#5940) * feat: support iab and iesg statements. Import iab statements. (#5895) * feat: infrastructure for statements doctype * chore: basic test framework * feat: basic statement document view * feat: show replaced statements * chore: black * fix: state help for statements * fix: cleanout non-relevant email expansions * feat: import iab statements, provide group statements tab * fix: guard against running import twice * feat: build redirect csv for iab statements * fix: set document state on import * feat: show published date on main doc view * feat: handle pdf statements * feat: create new and update statements * chore: copyright block updates * chore: remove flakes * chore: black * feat: add edit/new buttons for the secretariat * fix: address PR #5895 review comments * fix: pin pydantic until inflect catches up (#5901) (#5902) * chore: re-un-pin pydantic * feat: include submitter in email about submitted slides (#6033) * feat: include submitter in email about submitted slides fixes #6031 * chore: remove unintended whitespace change * chore(dev): update .vscode/settings.json with new taskExplorer settings * fix: Add editorial stream to proceedings (#6027) * fix: Add editorial stream to proceedings Fixes #5717 * fix: Move editorial stream after the irtf in proceedings * fix: Add editorial stream to meeting materials (#6047) Fixes #6042 * fix: Shows requested reviews for doc fixes (#6022) * Fix: Shows requested reviews for doc * Changed template includes to only give required variables to them. * feat: allow openId to choose an unactive email if there are none active (#6041) * feat: allow openId to choose an unactive email if there are no active ones * chore: correct typo * chore: rename unactive to inactive * fix: Make review table more responsive (#6053) * fix: Improve layout of review table * Progress * Progress * Final changes * Fix tests * Remove fluff * Undo commits * ci: add --validate-html-harder to tests * ci: add --validate-html-harder to build.yml workflow * fix: Set colspan to actual number of columns (#6069) * fix: Clean up view_feedback_pending (#6070) - Remove "Unclassified" column header, which caused misalignment in the table body. - Show the message author - previously displayed as `(None)`. * docs: Update LICENSE year * fix: Remove IESG state edit button when state is 'dead' (#6051) (#6065) * fix: Correctly order "last call requested" column in the IESG dashboard (#6079) * ci: update dev sandbox init script to start memcached * feat: Reclassify nomcom feedback (#6002) * fix: Clean up view_feedback_pending - Remove "Unclassified" column header, which caused misalignment in the table body. - Show the message author - previously displayed as `(None)`. * feat: Reclassify nomcom feedback (#4669) - There's a new `Chair/Advisor Tasks` menu item `Reclassify feedback`. - I overloaded `view_feedback*` URLs with a `?reclassify` parameter. - This adds a checkbox to each feedback message, and a `Reclassify` button at the bottom of each feedback page. - "Reclassifying" basically de-classifies the feedback, and punts it back to the "Pending emails" view for reclassification. - If a feedback has been applied to multiple nominees, declassifying it from one nominee removes it from all. * fix: Remove unused local variables * fix: Fix some missing and mis-nested html * test: Add tests for reclassifying feedback * refactor: Substantial redesign of feedback reclassification - Break out reclassify_feedback* as their own URLs and views, and revert changes to view_feedback*.html. - Replace checkboxes with a Reclassify button on each message. * fix: Remember to clear the feedback associations when reclassifying * feat: Add an 'Overcome by events' feedback type * refactor: When invoking reclassification from a view-feedback page, load the corresponding reclassify-feedback page * fix: De-conflict migration with 0004_statements Also change the coding style to match, and add a reverse migration. * fix: Fix a test case to account for new feedback type * fix: 842e730 broke the Back button * refactor: Reclassify feedback directly instead of putting it back in the work queue * fix: Adjust tests to new workflow * refactor: Further refine reclassification to avoid redirects * refactor: Impose a FeedbackTypeName ordering Also add FeedbackTypeName.legend field, rather than synthesizing it every time we classify or reclassify feedback. In the reclassification forms, only show the relevant feedback types. * refactor: Merge reclassify_feedback_* back into view_feedback_* This means the "Reclassify" button is always present, but eliminates some complexity. * refactor: Add filter(used=True) on FeedbackTypeName querysets * refactor: Add the new FeedbackTypeName to the reclassification success message * fix: Secure reclassification against rogue nomcom members * fix: Print decoded key and fully clean up test nomcom (#6094) * fix: Delete Person records when deleting a test nomcom * fix: Decode test nomcom private key before printing * test: Use correct time zone for test_statement_doc_view (#6064) * chore(deps): update all npm dependencies for playwright (#6061) Co-authored-by: depfu[bot] <23717796+depfu[bot]@users.noreply.github.com> * chore(deps): update all npm dependencies for dev/diff (#6062) Co-authored-by: depfu[bot] <23717796+depfu[bot]@users.noreply.github.com> * chore(deps): update all npm dependencies for dev/coverage-action (#6063) Co-authored-by: depfu[bot] <23717796+depfu[bot]@users.noreply.github.com> * fix: Hash cache key for default memcached cache (#6089) * feat: Show docs that an AD hasn't balloted on that need ballots to progress (#6075) * fix(doc): Unify help texts for document states (#6060) * Fix IESG State help text link (only) * Intermediate checkpoint * Correct URL filtering of state descriptions * Unify help texts for document states * Remove redundant load static from template --------- Co-authored-by: Robert Sparks <rjsparks@nostrum.com> * ci: fix sandbox start.sh memcached user * fix: refactor how settings handles cache definitions (#6099) * fix: refactor how settings handles cache definitions * chore: more english-speaker readable expression * fix: Cast cache key to str before calling encode (#6100) --------- Co-authored-by: Robert Sparks <rjsparks@nostrum.com> Co-authored-by: Liubov Kurafeeva <liubov.kurafeeva@gmail.com> Co-authored-by: nectostr <bastinda96@gmail.com> Co-authored-by: Rich Salz <rsalz@akamai.com> Co-authored-by: PriyankaN <priyanka@amsl.com> Co-authored-by: Priyanka Narkar <priyankanarkar@dhcp-91f8.meeting.ietf.org> Co-authored-by: Ali <alireza83@gmail.com> Co-authored-by: Roman Beltiukov <maybe.hello.world@gmail.com> Co-authored-by: Tero Kivinen <kivinen@iki.fi> Co-authored-by: Nicolas Giard <github@ngpixel.com> Co-authored-by: Kesara Rathnayake <kesara@fq.nz> Co-authored-by: Jennifer Richards <jennifer@staff.ietf.org> Co-authored-by: Paul Selkirk <paul@painless-security.com> Co-authored-by: depfu[bot] <23717796+depfu[bot]@users.noreply.github.com> Co-authored-by: Jim Fenton <fenton@bluepopcorn.net>
127 lines
4.4 KiB
Python
127 lines
4.4 KiB
Python
# Copyright The IETF Trust 2015-2023, All Rights Reserved
|
|
|
|
from collections import namedtuple
|
|
|
|
import debug # pyflakes:ignore
|
|
|
|
from ietf.mailtrigger.models import MailTrigger, Recipient
|
|
from ietf.submit.models import Submission
|
|
from ietf.utils.mail import excludeaddrs
|
|
|
|
class AddrLists(namedtuple('AddrLists',['to','cc'])):
|
|
|
|
__slots__ = ()
|
|
|
|
def as_strings(self,compact=True):
|
|
|
|
separator = ", " if compact else ",\n "
|
|
to_string = separator.join(self.to)
|
|
cc_string = separator.join(self.cc)
|
|
|
|
return namedtuple('AddrListsAsStrings',['to','cc'])(to=to_string,cc=cc_string)
|
|
|
|
|
|
def gather_address_lists(slug, skipped_recipients=None, create_from_slug_if_not_exists=None,
|
|
desc_if_not_exists=None, **kwargs):
|
|
mailtrigger = get_mailtrigger(slug, create_from_slug_if_not_exists, desc_if_not_exists)
|
|
|
|
to = set()
|
|
for recipient in mailtrigger.to.all():
|
|
to.update(recipient.gather(**kwargs))
|
|
to.discard('')
|
|
if skipped_recipients:
|
|
to = excludeaddrs(to, skipped_recipients)
|
|
|
|
cc = set()
|
|
for recipient in mailtrigger.cc.all():
|
|
cc.update(recipient.gather(**kwargs))
|
|
cc.discard('')
|
|
if skipped_recipients:
|
|
cc = excludeaddrs(cc, skipped_recipients)
|
|
|
|
return AddrLists(to=sorted(list(to)),cc=sorted(list(cc)))
|
|
|
|
def get_mailtrigger(slug, create_from_slug_if_not_exists, desc_if_not_exists):
|
|
try:
|
|
mailtrigger = MailTrigger.objects.get(slug=slug)
|
|
except MailTrigger.DoesNotExist:
|
|
if create_from_slug_if_not_exists and desc_if_not_exists:
|
|
template = MailTrigger.objects.get(slug=create_from_slug_if_not_exists)
|
|
mailtrigger = MailTrigger.objects.create(slug=slug, desc=desc_if_not_exists)
|
|
mailtrigger.to.set(template.to.all())
|
|
mailtrigger.cc.set(template.cc.all())
|
|
if slug.startswith('review_completed') and slug.endswith('early'):
|
|
mailtrigger.cc.remove('ietf_last_call')
|
|
else:
|
|
raise
|
|
return mailtrigger
|
|
|
|
|
|
def gather_relevant_expansions(**kwargs):
|
|
|
|
def starts_with(prefix):
|
|
return MailTrigger.objects.filter(slug__startswith=prefix).values_list('slug',flat=True)
|
|
|
|
relevant = set()
|
|
|
|
if 'doc' in kwargs:
|
|
|
|
doc = kwargs['doc']
|
|
|
|
relevant.add('doc_state_edited')
|
|
|
|
if not doc.type_id in ['bofreq', 'statement']:
|
|
relevant.update(['doc_telechat_details_changed','ballot_deferred','iesg_ballot_saved'])
|
|
|
|
if doc.type_id in ['draft','statchg']:
|
|
relevant.update(starts_with('last_call_'))
|
|
|
|
if doc.type_id == 'draft':
|
|
relevant.update(starts_with('doc_'))
|
|
relevant.update(starts_with('resurrection_'))
|
|
relevant.update(['ipr_posted_on_doc',])
|
|
if doc.stream_id == 'ietf':
|
|
relevant.update(['ballot_approved_ietf_stream','pubreq_iesg'])
|
|
else:
|
|
relevant.update(['pubreq_rfced'])
|
|
last_submission = Submission.objects.filter(name=doc.name,state='posted').order_by('-rev').first()
|
|
if last_submission and 'submission' not in kwargs:
|
|
kwargs['submission'] = last_submission
|
|
|
|
if doc.type_id == 'conflrev':
|
|
relevant.update(['conflrev_requested','ballot_approved_conflrev'])
|
|
if doc.type_id == 'charter':
|
|
relevant.update(['charter_external_review','ballot_approved_charter'])
|
|
|
|
if doc.type_id == 'bofreq':
|
|
relevant.update(starts_with('bofreq'))
|
|
|
|
if 'group' in kwargs:
|
|
|
|
relevant.update(starts_with('group_'))
|
|
relevant.update(starts_with('milestones_'))
|
|
group = kwargs['group']
|
|
if group.features.acts_like_wg:
|
|
relevant.update(starts_with('session_'))
|
|
if group.features.has_chartering_process:
|
|
relevant.update(['charter_external_review',])
|
|
|
|
if 'submission' in kwargs:
|
|
|
|
relevant.update(starts_with('sub_'))
|
|
|
|
rule_list = []
|
|
for mailtrigger in MailTrigger.objects.filter(slug__in=relevant):
|
|
addrs = gather_address_lists(mailtrigger.slug,**kwargs)
|
|
if addrs.to or addrs.cc:
|
|
rule_list.append((mailtrigger.slug,mailtrigger.desc,addrs.to,addrs.cc))
|
|
return sorted(rule_list)
|
|
|
|
def get_base_submission_message_address():
|
|
return Recipient.objects.get(slug='submission_manualpost_handling').gather()[0]
|
|
|
|
def get_base_ipr_request_address():
|
|
return Recipient.objects.get(slug='ipr_requests').gather()[0]
|
|
|
|
|