* chore: Remove unused "rendertest" stuff (#6015) * fix: restore ability to create status change documents (#5963) * fix: restore ability to create status change documents Fixes #5962 * chore: address review comment * fix: Provide human-friendly status in submission status API response (#6011) Co-authored-by: nectostr <bastinda96@gmail.com> * fix: Make name/email lookups case-insensitive (#5972) (#6007) * fix: Make name/email lookups case-insensitive (#5972) Use icontains so that looking up name or email is case insensitive Added a test Fixes: 5972 * fix: Use __iexact not __icontains * fix: Clarify no-action-needed (#5918) (#6020) When a draft is submitted for manual processing, clarify that no action is needed; the Secretariat has the next steps. Fixes: #5918 * fix: Fix menu hover issue (#6019) * fix: Fix menu hover issue Fixes #5702 * Fix leftmenu hover issue * fix: Server error from api_get_session_materials() (#6025) Fixes #5877 * fix: Clarify Questionnaire label (#4688) (#6017) When filtering nominees, `Questionnaire` implies `Accepted == yes` so fix the dropdown test tosay that. Fixes: #4688 * chore: Merge from @martinthomson's rfc-txt-html (#6023) * fix:no history entry when changing RFC Editor note for doc (#6021) * fix:no history entry when changing RFC Editor note for doc * fix:no history entry when changing RFC Editor note for doc --------- Co-authored-by: Priyanka Narkar <priyankanarkar@dhcp-91f8.meeting.ietf.org> * fix: avoid deprecation warning on view_list() for objs without CommunityList Fixes #5942 * fix: return 404 for non-existing revisions (#6014) * fix: return 404 for non-existing revisions Links to non-existing revisions to docs should return 404 * fix: change rfc/rev and search behaviour * refactor: fix tab level * fix: return 404 for rfc revision for bibtex * fix: provide date for revisions in bibtex output (#6029) * fix: provide date for revisions in bibtex output * refactor: change walrus to if's * fix: specify particular revision for events * fix: review refactoring issue fixes #5447 * fix: Remove automatically suggested document for document that is already has review request (fixes #3211) (#5425) * Added check that if there is already review request for the document in question, ignore the automatic suggestion for that document. Fixes #3211. * fix: dont block on open requests for a previous version. Add tests --------- Co-authored-by: Nicolas Giard <github@ngpixel.com> Co-authored-by: Robert Sparks <rjsparks@nostrum.com> * feat: IAB statements (#5940) * feat: support iab and iesg statements. Import iab statements. (#5895) * feat: infrastructure for statements doctype * chore: basic test framework * feat: basic statement document view * feat: show replaced statements * chore: black * fix: state help for statements * fix: cleanout non-relevant email expansions * feat: import iab statements, provide group statements tab * fix: guard against running import twice * feat: build redirect csv for iab statements * fix: set document state on import * feat: show published date on main doc view * feat: handle pdf statements * feat: create new and update statements * chore: copyright block updates * chore: remove flakes * chore: black * feat: add edit/new buttons for the secretariat * fix: address PR #5895 review comments * fix: pin pydantic until inflect catches up (#5901) (#5902) * chore: re-un-pin pydantic * feat: include submitter in email about submitted slides (#6033) * feat: include submitter in email about submitted slides fixes #6031 * chore: remove unintended whitespace change * chore(dev): update .vscode/settings.json with new taskExplorer settings * fix: Add editorial stream to proceedings (#6027) * fix: Add editorial stream to proceedings Fixes #5717 * fix: Move editorial stream after the irtf in proceedings * fix: Add editorial stream to meeting materials (#6047) Fixes #6042 * fix: Shows requested reviews for doc fixes (#6022) * Fix: Shows requested reviews for doc * Changed template includes to only give required variables to them. * feat: allow openId to choose an unactive email if there are none active (#6041) * feat: allow openId to choose an unactive email if there are no active ones * chore: correct typo * chore: rename unactive to inactive * fix: Make review table more responsive (#6053) * fix: Improve layout of review table * Progress * Progress * Final changes * Fix tests * Remove fluff * Undo commits * ci: add --validate-html-harder to tests * ci: add --validate-html-harder to build.yml workflow * fix: Set colspan to actual number of columns (#6069) * fix: Clean up view_feedback_pending (#6070) - Remove "Unclassified" column header, which caused misalignment in the table body. - Show the message author - previously displayed as `(None)`. * docs: Update LICENSE year * fix: Remove IESG state edit button when state is 'dead' (#6051) (#6065) * fix: Correctly order "last call requested" column in the IESG dashboard (#6079) * ci: update dev sandbox init script to start memcached * feat: Reclassify nomcom feedback (#6002) * fix: Clean up view_feedback_pending - Remove "Unclassified" column header, which caused misalignment in the table body. - Show the message author - previously displayed as `(None)`. * feat: Reclassify nomcom feedback (#4669) - There's a new `Chair/Advisor Tasks` menu item `Reclassify feedback`. - I overloaded `view_feedback*` URLs with a `?reclassify` parameter. - This adds a checkbox to each feedback message, and a `Reclassify` button at the bottom of each feedback page. - "Reclassifying" basically de-classifies the feedback, and punts it back to the "Pending emails" view for reclassification. - If a feedback has been applied to multiple nominees, declassifying it from one nominee removes it from all. * fix: Remove unused local variables * fix: Fix some missing and mis-nested html * test: Add tests for reclassifying feedback * refactor: Substantial redesign of feedback reclassification - Break out reclassify_feedback* as their own URLs and views, and revert changes to view_feedback*.html. - Replace checkboxes with a Reclassify button on each message. * fix: Remember to clear the feedback associations when reclassifying * feat: Add an 'Overcome by events' feedback type * refactor: When invoking reclassification from a view-feedback page, load the corresponding reclassify-feedback page * fix: De-conflict migration with 0004_statements Also change the coding style to match, and add a reverse migration. * fix: Fix a test case to account for new feedback type * fix: 842e730 broke the Back button * refactor: Reclassify feedback directly instead of putting it back in the work queue * fix: Adjust tests to new workflow * refactor: Further refine reclassification to avoid redirects * refactor: Impose a FeedbackTypeName ordering Also add FeedbackTypeName.legend field, rather than synthesizing it every time we classify or reclassify feedback. In the reclassification forms, only show the relevant feedback types. * refactor: Merge reclassify_feedback_* back into view_feedback_* This means the "Reclassify" button is always present, but eliminates some complexity. * refactor: Add filter(used=True) on FeedbackTypeName querysets * refactor: Add the new FeedbackTypeName to the reclassification success message * fix: Secure reclassification against rogue nomcom members * fix: Print decoded key and fully clean up test nomcom (#6094) * fix: Delete Person records when deleting a test nomcom * fix: Decode test nomcom private key before printing * test: Use correct time zone for test_statement_doc_view (#6064) * chore(deps): update all npm dependencies for playwright (#6061) Co-authored-by: depfu[bot] <23717796+depfu[bot]@users.noreply.github.com> * chore(deps): update all npm dependencies for dev/diff (#6062) Co-authored-by: depfu[bot] <23717796+depfu[bot]@users.noreply.github.com> * chore(deps): update all npm dependencies for dev/coverage-action (#6063) Co-authored-by: depfu[bot] <23717796+depfu[bot]@users.noreply.github.com> * fix: Hash cache key for default memcached cache (#6089) * feat: Show docs that an AD hasn't balloted on that need ballots to progress (#6075) * fix(doc): Unify help texts for document states (#6060) * Fix IESG State help text link (only) * Intermediate checkpoint * Correct URL filtering of state descriptions * Unify help texts for document states * Remove redundant load static from template --------- Co-authored-by: Robert Sparks <rjsparks@nostrum.com> * ci: fix sandbox start.sh memcached user * fix: refactor how settings handles cache definitions (#6099) * fix: refactor how settings handles cache definitions * chore: more english-speaker readable expression * fix: Cast cache key to str before calling encode (#6100) --------- Co-authored-by: Robert Sparks <rjsparks@nostrum.com> Co-authored-by: Liubov Kurafeeva <liubov.kurafeeva@gmail.com> Co-authored-by: nectostr <bastinda96@gmail.com> Co-authored-by: Rich Salz <rsalz@akamai.com> Co-authored-by: PriyankaN <priyanka@amsl.com> Co-authored-by: Priyanka Narkar <priyankanarkar@dhcp-91f8.meeting.ietf.org> Co-authored-by: Ali <alireza83@gmail.com> Co-authored-by: Roman Beltiukov <maybe.hello.world@gmail.com> Co-authored-by: Tero Kivinen <kivinen@iki.fi> Co-authored-by: Nicolas Giard <github@ngpixel.com> Co-authored-by: Kesara Rathnayake <kesara@fq.nz> Co-authored-by: Jennifer Richards <jennifer@staff.ietf.org> Co-authored-by: Paul Selkirk <paul@painless-security.com> Co-authored-by: depfu[bot] <23717796+depfu[bot]@users.noreply.github.com> Co-authored-by: Jim Fenton <fenton@bluepopcorn.net>
360 lines
13 KiB
Python
360 lines
13 KiB
Python
# Copyright The IETF Trust 2023, All Rights Reserved
|
|
|
|
import debug # pyflakes:ignore
|
|
|
|
from pyquery import PyQuery
|
|
|
|
from pathlib import Path
|
|
from zoneinfo import ZoneInfo
|
|
|
|
from django.conf import settings
|
|
from django.core.files.uploadedfile import SimpleUploadedFile
|
|
from django.template.loader import render_to_string
|
|
from django.urls import reverse as urlreverse
|
|
|
|
from ietf.doc.factories import StatementFactory, DocEventFactory
|
|
from ietf.doc.models import Document, DocAlias, State, NewRevisionDocEvent
|
|
from ietf.group.models import Group
|
|
from ietf.person.factories import PersonFactory
|
|
from ietf.utils.mail import outbox, empty_outbox
|
|
from ietf.utils.test_utils import (
|
|
TestCase,
|
|
reload_db_objects,
|
|
login_testing_unauthorized,
|
|
)
|
|
|
|
|
|
class StatementsTestCase(TestCase):
|
|
settings_temp_path_overrides = TestCase.settings_temp_path_overrides + [
|
|
"DOCUMENT_PATH_PATTERN"
|
|
]
|
|
|
|
def extract_content(self, response):
|
|
if not hasattr(response, "_cached_extraction"):
|
|
response._cached_extraction = list(response.streaming_content)[0].decode(
|
|
"utf-8"
|
|
)
|
|
return response._cached_extraction
|
|
|
|
def write_statement_markdown_file(self, statement):
|
|
(
|
|
Path(settings.DOCUMENT_PATH_PATTERN.format(doc=statement))
|
|
/ ("%s-%s.md" % (statement.name, statement.rev))
|
|
).write_text(
|
|
"""# This is a test statement.
|
|
Version: {statement.rev}
|
|
|
|
## A section
|
|
|
|
This test section has some text.
|
|
"""
|
|
)
|
|
|
|
def write_statement_pdf_file(self, statement):
|
|
(
|
|
Path(settings.DOCUMENT_PATH_PATTERN.format(doc=statement))
|
|
/ ("%s-%s.pdf" % (statement.name, statement.rev))
|
|
).write_text(
|
|
f"{statement.rev} This is not valid PDF, but the test does not need it to be"
|
|
)
|
|
|
|
def test_statement_doc_view(self):
|
|
doc = StatementFactory()
|
|
self.write_statement_markdown_file(doc)
|
|
url = urlreverse("ietf.doc.views_doc.document_main", kwargs=dict(name=doc.name))
|
|
response = self.client.get(url)
|
|
self.assertEqual(response.status_code, 200)
|
|
q = PyQuery(response.content)
|
|
self.assertEqual(q("#statement-state").text(), "Active")
|
|
self.assertEqual(q("#statement-type").text(), "IAB Statement")
|
|
self.assertIn("has some text", q(".card-body").text())
|
|
published = doc.docevent_set.filter(type="published_statement").last().time
|
|
self.assertIn(
|
|
published.astimezone(ZoneInfo(settings.TIME_ZONE)).date().isoformat(),
|
|
q("#published").text(),
|
|
)
|
|
|
|
doc.set_state(State.objects.get(type_id="statement", slug="replaced"))
|
|
doc2 = StatementFactory()
|
|
doc2.relateddocument_set.create(
|
|
relationship_id="replaces", target=doc.docalias.first()
|
|
)
|
|
response = self.client.get(url)
|
|
self.assertEqual(response.status_code, 200)
|
|
q = PyQuery(response.content)
|
|
self.assertEqual(q("#statement-state").text(), "Replaced")
|
|
self.assertEqual(q("#statement-type").text(), "Replaced IAB Statement")
|
|
self.assertEqual(q("#statement-type").next().text(), f"Replaced by {doc2.name}")
|
|
|
|
url = urlreverse(
|
|
"ietf.doc.views_doc.document_main", kwargs=dict(name=doc2.name)
|
|
)
|
|
response = self.client.get(url)
|
|
self.assertEqual(response.status_code, 200)
|
|
q = PyQuery(response.content)
|
|
self.assertEqual(q("#statement-type").text(), "IAB Statement")
|
|
self.assertEqual(q("#statement-type").next().text(), f"Replaces {doc.name}")
|
|
|
|
def test_serve_pdf(self):
|
|
url = urlreverse(
|
|
"ietf.doc.views_statement.serve_pdf",
|
|
kwargs=dict(name="statement-does-not-exist"),
|
|
)
|
|
r = self.client.get(url)
|
|
self.assertEqual(r.status_code, 404)
|
|
|
|
doc = StatementFactory()
|
|
url = urlreverse(
|
|
"ietf.doc.views_statement.serve_pdf", kwargs=dict(name=doc.name)
|
|
)
|
|
r = self.client.get(url)
|
|
self.assertEqual(r.status_code, 404) # File not found
|
|
|
|
self.write_statement_pdf_file(doc)
|
|
doc.rev = "01"
|
|
e = DocEventFactory(type="published_statement", doc=doc, rev=doc.rev)
|
|
doc.save_with_history([e])
|
|
self.write_statement_pdf_file(doc)
|
|
|
|
r = self.client.get(url)
|
|
self.assertEqual(r.status_code, 200)
|
|
self.assertEqual(r.get("Content-Type"), "application/pdf")
|
|
self.assertTrue(
|
|
self.extract_content(r).startswith(doc.rev)
|
|
) # relies on test doc not actually being pdf
|
|
|
|
url = urlreverse(
|
|
"ietf.doc.views_statement.serve_pdf", kwargs=dict(name=doc.name, rev="00")
|
|
)
|
|
r = self.client.get(url)
|
|
self.assertEqual(r.status_code, 200)
|
|
self.assertTrue(self.extract_content(r).startswith("00 "))
|
|
url = urlreverse(
|
|
"ietf.doc.views_statement.serve_pdf", kwargs=dict(name=doc.name, rev="01")
|
|
)
|
|
r = self.client.get(url)
|
|
self.assertEqual(r.status_code, 200)
|
|
self.assertTrue(self.extract_content(r).startswith("01 "))
|
|
|
|
def test_submit(self):
|
|
doc = StatementFactory()
|
|
url = urlreverse("ietf.doc.views_statement.submit", kwargs=dict(name=doc.name))
|
|
|
|
rev = doc.rev
|
|
r = self.client.post(
|
|
url, {"statement_submission": "enter", "statement_content": "# oiwefrase"}
|
|
)
|
|
self.assertEqual(r.status_code, 302)
|
|
doc = reload_db_objects(doc)
|
|
self.assertEqual(rev, doc.rev)
|
|
|
|
nobody = PersonFactory()
|
|
self.client.login(
|
|
username=nobody.user.username, password=nobody.user.username + "+password"
|
|
)
|
|
r = self.client.post(
|
|
url, {"statement_submission": "enter", "statement_content": "# oiwefrase"}
|
|
)
|
|
self.assertEqual(r.status_code, 403)
|
|
doc = reload_db_objects(doc)
|
|
self.assertEqual(rev, doc.rev)
|
|
self.client.logout()
|
|
|
|
for username in ["secretary"]: # There is potential for expanding this list
|
|
self.client.login(username=username, password=username + "+password")
|
|
r = self.client.get(url)
|
|
self.assertEqual(r.status_code, 200)
|
|
file = SimpleUploadedFile(
|
|
"random.pdf",
|
|
b"not valid pdf",
|
|
content_type="application/pdf",
|
|
)
|
|
for postdict in [
|
|
{
|
|
"statement_submission": "enter",
|
|
"statement_content": f"# {username}",
|
|
},
|
|
{
|
|
"statement_submission": "upload",
|
|
"statement_file": file,
|
|
},
|
|
]:
|
|
docevent_count = doc.docevent_set.count()
|
|
empty_outbox()
|
|
r = self.client.post(url, postdict)
|
|
self.assertEqual(r.status_code, 302)
|
|
doc = reload_db_objects(doc)
|
|
self.assertEqual("%02d" % (int(rev) + 1), doc.rev)
|
|
if postdict["statement_submission"] == "enter":
|
|
self.assertEqual(f"# {username}", doc.text())
|
|
else:
|
|
self.assertEqual("not valid pdf", doc.text())
|
|
self.assertEqual(docevent_count + 1, doc.docevent_set.count())
|
|
self.assertEqual(0, len(outbox))
|
|
rev = doc.rev
|
|
self.client.logout()
|
|
|
|
def test_start_new_statement(self):
|
|
url = urlreverse("ietf.doc.views_statement.new_statement")
|
|
login_testing_unauthorized(self, "secretary", url)
|
|
r = self.client.get(url)
|
|
self.assertContains(
|
|
r,
|
|
"Replace this with the content of the statement in markdown source",
|
|
status_code=200,
|
|
)
|
|
group = Group.objects.get(acronym="iab")
|
|
r = self.client.post(
|
|
url,
|
|
dict(
|
|
group=group.pk,
|
|
title="default",
|
|
statement_submission="enter",
|
|
statement_content=render_to_string(
|
|
"doc/statement/statement_template.md", {"settings": settings}
|
|
),
|
|
),
|
|
)
|
|
self.assertContains(r, "The example content may not be saved.", status_code=200)
|
|
|
|
file = SimpleUploadedFile(
|
|
"random.pdf",
|
|
b"not valid pdf",
|
|
content_type="application/pdf",
|
|
)
|
|
group = Group.objects.get(acronym="iab")
|
|
for postdict in [
|
|
dict(
|
|
group=group.pk,
|
|
title="title one",
|
|
statement_submission="enter",
|
|
statement_content="some stuff",
|
|
),
|
|
dict(
|
|
group=group.pk,
|
|
title="title two",
|
|
statement_submission="upload",
|
|
statement_file=file,
|
|
),
|
|
]:
|
|
empty_outbox()
|
|
r = self.client.post(url, postdict)
|
|
self.assertEqual(r.status_code, 302)
|
|
name = f"statement-{group.acronym}-{postdict['title']}".replace(
|
|
" ", "-"
|
|
) # cheap slugification
|
|
statement = Document.objects.filter(
|
|
name=name, type_id="statement"
|
|
).first()
|
|
self.assertIsNotNone(statement)
|
|
self.assertIsNotNone(DocAlias.objects.filter(name=name).first())
|
|
self.assertEqual(statement.title, postdict["title"])
|
|
self.assertEqual(statement.rev, "00")
|
|
self.assertEqual(statement.get_state_slug(), "active")
|
|
self.assertEqual(
|
|
statement.latest_event(NewRevisionDocEvent).rev, "00"
|
|
)
|
|
self.assertIsNotNone(statement.latest_event(type="published_statement"))
|
|
if postdict["statement_submission"] == "enter":
|
|
self.assertEqual(statement.text_or_error(), "some stuff")
|
|
else:
|
|
self.assertTrue(statement.uploaded_filename.endswith("pdf"))
|
|
self.assertEqual(len(outbox), 0)
|
|
|
|
existing_statement = StatementFactory()
|
|
for postdict in [
|
|
dict(
|
|
group=group.pk,
|
|
title="",
|
|
statement_submission="enter",
|
|
statement_content="some stuff",
|
|
),
|
|
dict(
|
|
group=group.pk,
|
|
title="a title",
|
|
statement_submission="enter",
|
|
statement_content="",
|
|
),
|
|
dict(
|
|
group=group.pk,
|
|
title=existing_statement.title,
|
|
statement_submission="enter",
|
|
statement_content="some stuff",
|
|
),
|
|
dict(
|
|
group=group.pk,
|
|
title="森川",
|
|
statement_submission="enter",
|
|
statement_content="some stuff",
|
|
),
|
|
dict(
|
|
group=group.pk,
|
|
title="a title",
|
|
statement_submission="",
|
|
statement_content="some stuff",
|
|
),
|
|
dict(
|
|
group="",
|
|
title="a title",
|
|
statement_submission="enter",
|
|
statement_content="some stuff",
|
|
),
|
|
dict(
|
|
group=0,
|
|
title="a title",
|
|
statement_submission="enter",
|
|
statement_content="some stuff",
|
|
),
|
|
]:
|
|
r = self.client.post(url, postdict)
|
|
self.assertEqual(r.status_code, 200, f"Wrong status_code for {postdict}")
|
|
q = PyQuery(r.content)
|
|
self.assertTrue(
|
|
q("form div.is-invalid"), f"Expected an error for {postdict}"
|
|
)
|
|
|
|
def test_submit_non_markdown_formats(self):
|
|
doc = StatementFactory()
|
|
|
|
file = SimpleUploadedFile(
|
|
"random.pdf",
|
|
b"01 This is not valid PDF, but the test does not need it to be",
|
|
content_type="application/pdf",
|
|
)
|
|
|
|
url = urlreverse("ietf.doc.views_statement.submit", kwargs=dict(name=doc.name))
|
|
login_testing_unauthorized(self, "secretary", url)
|
|
|
|
r = self.client.post(
|
|
url,
|
|
{
|
|
"statement_submission": "upload",
|
|
"statement_file": file,
|
|
},
|
|
)
|
|
self.assertEqual(r.status_code, 302)
|
|
self.assertEqual(
|
|
r["Location"],
|
|
urlreverse("ietf.doc.views_doc.document_main", kwargs=dict(name=doc.name)),
|
|
)
|
|
|
|
doc = reload_db_objects(doc)
|
|
self.assertEqual(doc.rev, "01")
|
|
r = self.client.get(url)
|
|
self.assertEqual(r.status_code, 200)
|
|
q = PyQuery(r.content)
|
|
self.assertEqual(
|
|
q("#id_statement_content").text().strip(),
|
|
"The current revision of this statement is in pdf format",
|
|
)
|
|
|
|
file = SimpleUploadedFile(
|
|
"random.mp4", b"29ucdvn2o09hano5", content_type="video/mp4"
|
|
)
|
|
r = self.client.post(
|
|
url, {"statement_submission": "upload", "statement_file": file}
|
|
)
|
|
self.assertEqual(r.status_code, 200)
|
|
q = PyQuery(r.content)
|
|
self.assertTrue("Unexpected content" in q("#id_statement_file").next().text())
|