d98054c103
addition to the existing 'pyang' checker. Added modal overlay displays showing the yang check results every place the yin/yang symbol is shown (red or green) to indicate the presencee and result of yang checks. Added a Yang Validation: line in the document meta-information section on the document's page in the datatracker. Added the result of the xym extaction to the yang check results, to make extration failures visible. Added the version of the used xym, pyang, and yanglint commands to the check results. Added an action to move successfully extracted and validated modules to the module library directories immediately on submission. Added the xym and pyang repositories as svn:external components, rather than listing them in requirements.txt, as there has been delays of many months between essential features in the repositories, and an actual release. We may get occasional buildbot failures if broken code is pulled in from the repository, but better that than the functionality failure of severely outdated componets. Added a new management command to re-run yang validation for active drafts for which yang modules were found at submission time, in order to pick up imported models which may have arrived in the model libraries after the draft's submission. Run daily from bin/daily. Added a table to hold version information for external commands. The yang checker output should include the version information of the used checkers, but seems unnecessary to run each command with its --version switch every time we check a module... Added a new management command to collect version information for external commands on demand. To be run daily from bin/daily. Added tests to verify that xym, pyang and yanglint information is available on the submission confirmation page, and updated the yang module contained in the test document to validate under both pyang and yanglint. Updated admin.py and resource.py files as needed. - Legacy-Id: 13630
83 lines
3.3 KiB
Python
83 lines
3.3 KiB
Python
from __future__ import print_function, unicode_literals
|
|
|
|
import sys
|
|
import json
|
|
|
|
from textwrap import dedent
|
|
|
|
from django.core.management.base import BaseCommand
|
|
|
|
import debug # pyflakes:ignore
|
|
|
|
from ietf.doc.models import Document, State
|
|
from ietf.submit.models import Submission, SubmissionCheck
|
|
from ietf.submit.checkers import DraftYangChecker
|
|
|
|
|
|
class Command(BaseCommand):
|
|
"""
|
|
Run yang model checks on active drafts.
|
|
|
|
Repeats the yang checks in ietf/submit/checkers.py for active drafts, in
|
|
order to catch changes in status due to new modules becoming available in
|
|
the module directories.
|
|
|
|
"""
|
|
|
|
help = dedent(__doc__).strip()
|
|
|
|
def add_arguments(self, parser):
|
|
parser.add_argument('filenames', nargs="*")
|
|
parser.add_argument('--clean',
|
|
action='store_true', dest='clean', default=False,
|
|
help='Remove the current directory content before writing new models.')
|
|
|
|
|
|
def check_yang(self, checker, draft, force=False):
|
|
if self.verbosity > 1:
|
|
self.stdout.write("Checking %s-%s" % (draft.name, draft.rev))
|
|
else:
|
|
sys.stderr.write('.')
|
|
submission = Submission.objects.filter(name=draft.name, rev=draft.rev).order_by('-id').first()
|
|
if submission or force:
|
|
check = submission.checks.filter(checker=checker.name).order_by('-id').first()
|
|
if check or force:
|
|
result = checker.check_file_txt(draft.get_file_name())
|
|
passed, message, errors, warnings, items = result
|
|
if self.verbosity > 2:
|
|
self.stdout.write(" Errors: %s\n"
|
|
" Warnings: %s\n"
|
|
" Message:\n%s\n" % (errors, warnings, message))
|
|
items = json.loads(json.dumps(items))
|
|
new_res = (passed, errors, warnings, message)
|
|
old_res = (check.passed, check.errors, check.warnings, check.message) if check else ()
|
|
if new_res != old_res:
|
|
if self.verbosity > 1:
|
|
self.stdout.write(" Saving new yang checker results for %s-%s" % (draft.name, draft.rev))
|
|
SubmissionCheck.objects.create(submission=submission, checker=checker.name, passed=passed,
|
|
message=message, errors=errors, warnings=warnings, items=items,
|
|
symbol=checker.symbol)
|
|
else:
|
|
self.stderr.write("Error: did not find any submission object for %s-%s\n" % (draft.name, draft.rev))
|
|
|
|
def handle(self, *filenames, **options):
|
|
"""
|
|
"""
|
|
|
|
self.verbosity = int(options.get('verbosity'))
|
|
filenames = options.get('filenames')
|
|
|
|
active_state = State.objects.get(type="draft", slug="active")
|
|
|
|
checker = DraftYangChecker()
|
|
if filenames:
|
|
for name in filenames:
|
|
parts = name.rsplit('-',1)
|
|
if len(parts)==2 and len(parts[1])==2 and parts[1].isdigit():
|
|
name = parts[0]
|
|
draft = Document.objects.get(name=name)
|
|
self.check_yang(checker, draft, force=True)
|
|
else:
|
|
for draft in Document.objects.filter(states=active_state, type_id='draft'):
|
|
self.check_yang(checker, draft)
|