Commit graph

49 commits

Author SHA1 Message Date
Henrik Levkowetz b9c38d3c06 Merged pyflakes fixes forward to new copy of trunk.
- Legacy-Id: 7463
2014-03-15 16:27:05 +00:00
Henrik Levkowetz 5bef5d11ae Made doc/ pyflakes-clean.
- Legacy-Id: 7462
2014-03-15 16:09:47 +00:00
Henrik Levkowetz 8ff8056581 Merged [7383] from jmh@joelhalpern.com: fixes ticket #924
Changes counting logic in ballots to use actual number of ADs.
Causes ballot email to use utility to generate requirements text
 - Legacy-Id: 7404
Note: SVN reference [7383] has been migrated to Git commit 271c48c9c47bf63bee2289fad9224b624c388fba
2014-03-04 18:22:29 +00:00
Ole Laursen 87ca10d122 Remove usage of log_state_changed (and duplicate in
doc/utils_charter.py) in favour of add_state_change_event which has
slightly better API but otherwise does basically the same except it
sets an event type we can later search for. Also expand tests slightly
to exercise three more templates.
 - Legacy-Id: 7129
2014-01-15 17:52:00 +00:00
Ole Laursen 9457669310 Merge in changes from the old shimfree branch
- Legacy-Id: 6764
2013-11-27 12:55:50 +00:00
Robert Sparks e309ff92b3 Don't insert references to self.
Move the data filler from a migration to a standalone script
 - Legacy-Id: 6620
2013-11-02 20:59:43 +00:00
Robert Sparks b18249222b Refines Bill Fenner's regex based search through documents for references.
Populates RelatedDocument with relations for references for each type draft Document.
Replaces these reference relationships with updated copies on draft submission.
Note to deployer: This migration takes around 10 minutes to complete on a fast development laptop.
 - Legacy-Id: 6572
2013-10-30 20:51:11 +00:00
Henrik Levkowetz c78be852a5 Added a new WG (ietf stream) tag slug.
- Legacy-Id: 6349
2013-10-03 11:48:56 +00:00
Ole Laursen c508a5672d Reimplement WG/RG adoption of drafts with the new schema, move it to
doc/ together with test and utilities, rewrite the UI to be more in
line with the rest of the edit pages (including the revamped stream
state change UI)
 - Legacy-Id: 6269
2013-09-26 13:14:07 +00:00
Henrik Levkowetz 2a2389d17f Merged in branch/iola/shimfree@6083. This cleans up and moves relevant code from idrfc/ to doc/. There should now only be a bit of old wrapper code left in idrfc; that will go away when the remaining models which use it are cleaned up.
- Legacy-Id: 6117
2013-09-09 17:45:36 +00:00
Henrik Levkowetz 37e69a02c6 Changed the order of the files diffed in the draft diff links on the history page. Fixes issue #1114.
- Legacy-Id: 6077
2013-08-28 10:36:32 +00:00
Ole Laursen 2cf79bb04c Move update_telechat from idrfc.utils to doc.utils, port remaining
code to using log_state_changed from doc.utils, remove idrfc/utils.py
 - Legacy-Id: 6050
2013-08-13 16:44:07 +00:00
Ole Laursen de7ae60985 Move markup_txt.py from idrfc/ to utils/
- Legacy-Id: 6046
2013-08-13 14:33:22 +00:00
Henrik Levkowetz e678659b56 Merged in a lot of shim-layer removals from olau@iola.dk
(-r5194:5465 from branch/iola/shimfree).  Copying relevant
commit messages here:

  - Removed .related many to many relationship, it's not really useful
    since we always have to restrict on the relationship type anyway,
    instead add two helpers for doing the necessary queries (in both
    directions)

  - Added migration for transforming the .desc on the new_revision events
    into something more akin to what is actually shown in the history page

  - Added migration for blanking IESG notes that just consist of "RFC
    XXXX", these have been superfluous for some time

  - Grant stream chairs access to changing the stream on a draft

  - Hacked the format_history_text filter to be less weird, using the same
    formatting for snippets and full text, also link up legacy ballot set
    events

  - Moved the decoraters + utilities to new ietfauth/utils.py file

  - Added simple helper to Email to identify invalid email addresses (from
    legacy author entries)

  - Used new new_revision .desc format for when drafts are submitted

  - Improved the looks of the button class by adding extra contrast and a
    linear gradient. Currently the gradient is only visible in fairly
    recent browsers.

  - Rewrote draft and RFC tabs in terms of the new schema, porting
    write-up and history tabs as well

  - Fixed two bugs in RFC Editor syncing: make sure documents we don't know
    beforehand get a "draft" type and make sure individually submitted
    drafts get the type="individ" group instead of NULL

  - Made the CSS-styled button feel a bit nicer to use by flattening the
    active state, also introduce some temporary styles until browsers
    catch up with the standard syntax

  - Added migrations for fixing 1) a dummy RFC entry, 2) three stand-alone
    RFCs that didn't get their doc.type set, 3) a big bunch of historic
    stand-alone RFCs that have doc.group=None - set these to the
    individual submission "none" group for the time being so the view code
    doesn't have to deal with a special case.

    In some cases this is wrong since there actually was a WG associated
    but unfortunately fixing them properly requires detective work
    (probably parsing the RFCs) and in at least some cases recreating
    historic WGs. In case someone ends up doing this, the documents to
    check can still be found with

    Document.objects.filter(name__startswith="rfc", group__type="individ")
    since there are almost no new RFCs that didn't went through the I-D
    process.

  - Merged the I-D and RFC views by showing I-D information on RFCs too.
    I-Ds that have been published as RFCs redirect to the RFC URL. Also
    support alias URLs so e.g. /doc/bcpXXXX redirects to /doc/rfcXXXX.

  - Fixed revision augmentation so events after RFC publication gets a "RFC"
    designation

  - Fixed a bug with tabs not using provided name but rather doc.name

  - Displaying draft-iesg state rather than doc.friendly_state as IESG state,
    also show a notice that the IESG state refers to post-RFC processing
    if it does, like the old separate RFC page did

  - Fixed the RFC number doc.note migration to catch combined "RFC XXX; BCP
    XXX" notes too, use the opportunity to remove inserted HTML tags from
    notes and rely on linebreaksbr filter instead (the other thing was a
    left-over from the Perl days), update the various uses of the note to
    reflect that

  - Refactored slightly to make views_doc.py independent of other idrfc code

  - Moveed idrfc/views_doc.py to doc/ with associated templates, replace the
    somewhat fragile simple URL tests for views_doc.py with ordinary unit
    tests. The new tests are still fairly basic but at least test more
    than the URL tests did.

  - Made sure RFC's (and BCP/STD/FYI) are stored as RFC123 instead of
    RFC0123 in the alias table with a new migration and a change to the
    RFC Editor sync, this in turn makes /doc/std1/ do the right thing

  - Now /doc/std1/ works, we can actually do a local link in
    urlize_ietf_docs rather than linking to the tools.ietf.org server

  - Fixed history text formatter: sanitize HTML before adding linebreaks and
    non-breaking spaces, this cuts the time to render a history page with
    long comments in half

  - Added a test crawler that walks through the crawlable part of the site,
    reporting errors and slow pages

  - Got rid of initial "No record" positions when showing old positions,
    it's just noise

  - Added a .select_related() to the document main tab to reduce the number
    of DB queries, unfortunately it seems it doesn't really help with
    Django 1.2.x due to a bug (Document inherits from DocumentInfo which
    makes things a bit more complicated)

  - Introduced a simple cache in doc.get_state so repeated reads don't
    cause a DB query

  - Cleaned up the search code in preparation for removal of the shim-layer;
    use a static button and don't send extraneous GET parameters

  - Removed dead code in several places
 - Legacy-Id: 5830
2013-07-15 20:55:24 +00:00
Henrik Levkowetz 0a76a26ed7 Fixed the additional nit mentioned in issue #974 better. Together with earlier commits, this fixes #974.
- Legacy-Id: 5632
2013-04-08 20:21:09 +00:00
Henrik Levkowetz 7ac4113751 Import math as needed. Related to [5626] and issue #974.
- Legacy-Id: 5628
Note: SVN reference [5626] has been migrated to Git commit fb1df9e2eb
2013-04-07 17:10:19 +00:00
Henrik Levkowetz f3833e1d17 Fixed another issue with the ballot counts (unreachable code). See issue #974.
- Legacy-Id: 5627
2013-04-05 14:07:59 +00:00
Henrik Levkowetz fb1df9e2eb Fixed the ballots needed count error in two more places. See issue #974.
- Legacy-Id: 5626
2013-04-05 14:06:13 +00:00
Henrik Levkowetz b183273c72 Add new tag 'rev-wg' to the list of valid annotation tags for the ietf stream. Note: This list and those on nearby lines needs to be refactored into a table, instead of sitting in the code.
- Legacy-Id: 5623
2013-04-05 11:19:35 +00:00
Joel M. Halpern fe13ee8dfa Repair the ballot requirements string
- Legacy-Id: 5516
2013-03-09 18:30:29 +00:00
Ole Laursen 7998371ace Make sure RFC's (and BCP/STD/FYI) are stored as RFC123 instead of
RFC0123 in the alias table with a new migration and a change to the
RFC Editor sync, this in turn makes /doc/std1/ do the right thing
 - Legacy-Id: 5296
2013-01-18 13:47:31 +00:00
Ole Laursen 1a3aa3b443 Refactor slightly to make views_doc.py independent of other idrfc code
- Legacy-Id: 5294
2013-01-18 10:32:05 +00:00
Ole Laursen 5efcc5fbef Fix revision augmentation so events after RFC publication gets a "RFC"
designation
 - Legacy-Id: 5286
2013-01-17 15:39:57 +00:00
Ole Laursen c0ecb78761 Merge the I-D and RFC views by showing I-D information on RFCs too.
I-Ds that have been published as RFCs redirect to the RFC URL. Also
support alias URLs so e.g. /doc/bcpXXXX redirects to /doc/rfcXXXX.
 - Legacy-Id: 5285
2013-01-17 13:28:42 +00:00
Ole Laursen aa70cffe73 Rewrite draft and RFC tabs in terms of the new schema, porting
write-up and history tabs as well
 - Legacy-Id: 5214
2013-01-16 14:57:01 +00:00
Henrik Levkowetz 1fbcd783f3 Merged branch/iola/statesync up to @5118 to trunk.
- Legacy-Id: 5147
2012-12-20 20:32:03 +00:00
Ole Laursen a8671798fd Return None explicitly rather than implicitly
- Legacy-Id: 4886
2012-09-28 14:49:37 +00:00
Robert Sparks b3bdbc9506 refactored close_open_ballots, creating a way to close one abllot at a time. rewrote the clear ballot code to close each open ballot and open a new one
- Legacy-Id: 4885
2012-09-27 21:41:11 +00:00
Ole Laursen 07490fcb83 Add new IANA states, add consensus event, add a state change event,
add migrations for these that also clean up the RFC Editor states a
little given the recent changes
 - Legacy-Id: 4846
2012-09-17 10:00:56 +00:00
Robert Sparks fb2b9c9e6c Removed some duplication between doc/util and doc/models by moving things into doc/models. Fixes bug #857
- Legacy-Id: 4750
2012-08-02 21:36:36 +00:00
Robert Sparks 51ab8123d9 merged in from 4.20-ise
- Legacy-Id: 4502
2012-06-22 20:25:17 +00:00
Henrik Levkowetz 839df60480 Merged in charter branch fixes from olau@iola.dk, from r4354 through r4381.
- Legacy-Id: 4382
2012-05-04 11:47:30 +00:00
Ole Laursen 5215527de2 Treat BoF as proposed WG.
- Legacy-Id: 4374
2012-05-03 18:50:51 +00:00
Henrik Levkowetz 462aff53ad Merged in fixes to the charter branch (r4345 - r4353) from olau@iola.dk.
- Legacy-Id: 4354
2012-05-02 19:37:46 +00:00
Henrik Levkowetz bcd28cc45f Merged in fixes to the migration from olau@iola.dk. Merged in charter branch from olau@iola.dk. Added various fixes and correction of merge errors.
- Legacy-Id: 4353
2012-05-02 19:35:32 +00:00
Ole Laursen 891ac2585d Use revision numbers to identify ballots and put a warning on closed ballots.
- Legacy-Id: 4352
2012-05-02 17:47:40 +00:00
Ole Laursen 85708073f0 Fix "yes" calculation in needed_ballot_position (bug found by Robert Sparks).
- Legacy-Id: 4347
2012-05-02 11:32:42 +00:00
Ole Laursen b9a90f35e1 Clean up and polish charter branch code, fix some subtle bugs with
revision and approved charter lookup.
 - Legacy-Id: 4290
2012-04-19 15:15:43 +00:00
Ole Laursen 1ce4444732 Fix missing parentheses in needed position calculations.
- Legacy-Id: 4279
2012-04-16 17:24:57 +00:00
Ole Laursen 1ff4bc0121 Port idrfc code to use new ballot setup with an explicit ballot on
positions, port and clean up ballot icon renderer, add preliminary migration
script for inserting extra events in drafts
 - Legacy-Id: 4274
2012-04-16 13:19:47 +00:00
Ole Laursen 6d0d014b0d Close charter ballots when the charter is approved or abandoned.
- Legacy-Id: 4262
2012-04-05 16:20:25 +00:00
Ole Laursen e4a9d8c7aa Finish ballot support for charters (apart from non-generic ballot
deferral), remove a bunch of now obsolete charter code.
 - Legacy-Id: 4255
2012-04-04 18:09:03 +00:00
Ole Laursen a9817e555a Some fixes to generic doc ballot view, fix edit position and send
ballot comment email views, moving them to
/doc/foo-bar/ballot/[id]/position/ and ../emailposition/.
 - Legacy-Id: 4249
2012-04-03 14:53:38 +00:00
Ole Laursen ed15193bcf Introduce more generic ballot models, start porting doc ballot page to the
new database schema.
 - Legacy-Id: 4240
2012-03-30 17:16:50 +00:00
Ole Laursen 618e308ac0 Add WG chartering/rechartering overview page, missing ballot icon
pending on getting ballot situation cleared up, but otherwise done.
 - Legacy-Id: 4087
2012-03-15 16:01:59 +00:00
Ole Laursen ed4a38918d Add augment_with_start_time where start time is currently defined as
time of first revision
 - Legacy-Id: 3958
2012-02-24 14:29:51 +00:00
Ole Laursen d8c546ec21 Cap ballots at latest ballot initation in active_ballot_positions
- Legacy-Id: 3896
2012-02-02 19:58:19 +00:00
Ole Laursen 65e5298630 Be more careful in handling Document.stream now that it can be null
- Legacy-Id: 3865
2012-01-26 13:28:02 +00:00
Ole Laursen 980d4e6444 Move new schema models from redesign/ to ietf/
- Legacy-Id: 3855
2012-01-24 17:17:24 +00:00
Renamed from redesign/doc/utils.py (Browse further)