Commit graph

137 commits

Author SHA1 Message Date
Ryan Cross fca04d97e5 Fixes issue where authorized individual unable to add incoming liaison. Fixes problem with incoming liaison form requiring deadline date for information only statements. Commit ready for merge.
- Legacy-Id: 9595
2015-05-01 18:11:00 +00:00
Henrik Levkowetz 2b1faeb39c Removed bootstrap-provided files in preparation for calling them in as externals from /bootstrap/dist/.
- Legacy-Id: 9376
2015-04-03 21:09:02 +00:00
Ole Laursen a23d80ea40 Commit patch from Lars Eggert to update the JS/CSS libraries
- Legacy-Id: 9116
2015-02-24 10:25:20 +00:00
Ole Laursen a589115ff4 Summary: Reindent all HTML files to follow the previous convention (no
tabs) and kill the scripts block in favour of just using a js block with
a script tag (which is easier to understand for context-sensitive
modes such as web-mode in Emacs). Also fix a couple of details, e.g.
missing semicolons in JS snippets.
 - Legacy-Id: 9096
2015-02-17 18:01:04 +00:00
Ole Laursen 9760cd9c8e Summary: Load the groups in the group menu with AJAX and delete the
jump to group modal. This cuts page rendering speed in more than half
for simple pages and similarly shrinks them by a factor 3-4, while
keeping the user experience the same. Fallbacks are in place for
non-JS clients.

There's still some overhead in the menu generation compared to just
rendering the page content, but the group menu was definitely a major
culprit.
 - Legacy-Id: 9077
2015-02-12 16:01:05 +00:00
Ole Laursen ab74e5c090 Somehow the recent merge with trunk ended up with the CSS directory from trunk rather than the facelift one (Subversion was acting weird) - reestablish the facelift one, and also recover the qunit CSS/JS files which accidentally was left
- Legacy-Id: 9071
2015-02-12 08:28:19 +00:00
Ole Laursen c757998f24 Summary: Delete dead code
- Legacy-Id: 8997
2015-02-05 15:55:51 +00:00
Ole Laursen 9d71ef3179 Summary: Move select2 field handling to a separate .js file, currently
we only include the select2 things on pages with forms that need it
anyway, and this makes it easier to use it in the Secretariat code
 - Legacy-Id: 8986
2015-02-05 13:48:27 +00:00
Ole Laursen e78637b9fc Remove non-facelift static assets, and move the facelift assets one step up
- Legacy-Id: 8971
2015-02-04 17:03:43 +00:00
Ole Laursen c53f4f348e Move a couple of still live CSS files/images (due to agenda) to facelift, and move the rest to non-facelift in preparation for cleaning up the static assets
- Legacy-Id: 8960
2015-02-03 16:19:32 +00:00
Ole Laursen 756a972113 Move meeting agenda editing over to new facelifted base template, although without actually facelifting the contents
- Legacy-Id: 8946
2015-01-29 17:53:56 +00:00
Henrik Levkowetz 5183042d58 Merged in branch/amsl/iprtool/5.7.4@8734 from rcross@amsl.com, providing new IPR models, refactored code, and improved list, search, and management interfaces.
- Legacy-Id: 8808
2014-12-21 19:26:33 +00:00
Robert Sparks c436607039 merged forward. Adjusted new proceedings code to new models. Found bug in earlier work on proceedings code exposing places that tests are not covering.
- Legacy-Id: 8589
2014-11-05 21:19:09 +00:00
Henrik Levkowetz 704589b4c7 Merged in branch/iola/people-cleanup @ [8471] from olau@iola.dk, which
enhances a number of pages in the datatracker where forms contain fields
  where a person should be chosen, such as for instance when choosing the
  shepherd of a document, so that they uniformly display choices which show
  both email address and name.

  Furthermore, changes have been made so as to make the email address
  uniformly act as reference to the person record.  

  Autocompletion is now consistently provided when looking for the email
  address or name of the person to choose.  

  This solves a number of issues where it has been difficult to choose the
  correct Person/Email combination, and where the correct email address to use
  for an association has been unavailable previously.
 - Legacy-Id: 8472
Note: SVN reference [8471] has been migrated to Git commit d62f2343e8
2014-10-25 21:05:50 +00:00
Robert Sparks e889177a32 merged forward
- Legacy-Id: 8432
2014-10-16 15:07:33 +00:00
Robert Sparks a12be8aeb5 Removes a modify-while-iterating error, and removes a bug where two different bits of code thought they were responsible for deleting things from a global list. Fixes bug #1498. Commit ready for merge.
- Legacy-Id: 8377
2014-10-06 21:40:54 +00:00
Robert Sparks 67782ade34 merge forward complete
- Legacy-Id: 8354
2014-09-23 15:48:27 +00:00
Robert Sparks c3f460cbe9 Refactored history snippets for general use
Moved from VersionedMaterials to SessionPresentation for the through table name
Added the abstract and most recent presentation to the documents on the group materials page
Working snapshot before building historic edu-team documents
 - Legacy-Id: 8349
2014-09-19 21:33:30 +00:00
Ole Laursen a1a13323d2 Use hint text instead of Django help text for providing the help for
EmailsField and clarify the text displayed when the input is invalid
so it's hopefully more clear what happens
 - Legacy-Id: 8272
2014-08-17 09:02:21 +00:00
Ole Laursen 8b63dd982f Add support for customizing max number of entries in EmailsField,
update to version 1.6 of jquery.tokeninput.js and fix problem with
reloading EmailsField pages by adding a data-pre attribute instead of
hacking the value attribute
 - Legacy-Id: 8264
2014-08-13 08:58:10 +00:00
Robert Sparks fc512680d8 From mcr@sandelman.ca:
Refactor to remove dajaxice.
  Modified the URLs that address schedules:
    - urls now always start with /agenda, removing the mix of /agenda and /schedule prefixes
    - urls to a given schedule include the schedule owner (by email address)
  Corrected issue that prevented deleting sessions.
  Changed comment mechanism in timeslot_edit.js
  Migration to change the email address for (System)

  Fixes bug #1426

Commit ready to merge
 - Legacy-Id: 8229
2014-07-31 22:13:01 +00:00
Shane Kerr c8c3b04643 Javascript and image file for "untrack document" feature.
- Legacy-Id: 8131
2014-07-19 19:45:37 +00:00
Robert Sparks 7b9e6b5609 Addresses issue with dragging and dropping unscheduled items back into the unscheduled bin (primary fix provided by Matt Miller). Fixes bug 1386. Commit ready for merge.
- Legacy-Id: 7865
2014-06-06 20:14:25 +00:00
Robert Sparks 6f202065e7 Fixed coloring rows: The js IETF object needs to exist for the code to work. Fixes bug #1303. Commit ready to merge.
- Legacy-Id: 7735
2014-05-12 21:45:55 +00:00
Robert Sparks f92221a746 Revert a debug setting that should not have made it into the last commit. Commit ready for merge.
- Legacy-Id: 7733
2014-05-12 19:40:01 +00:00
Robert Sparks 947f174e78 Extended ScheduledSession objects were not initialized correctly, so un-extending did not work. Fixes bug #1401. Commit ready for merge.
- Legacy-Id: 7732
2014-05-12 19:37:44 +00:00
Robert Sparks b8cfbf18e5 From rjsparks@nostrum.com:
-  Fixed layout issue on schedule editing page in Chrome
  -  Fixed errant display of text in unscheduled group bar
     on the schedule editing page
  -  Changed the instruction text on the special requests
     field of the session request form

From rcross@amsl.com:
  - Improved scheduling of non-session items
  - Fixed issue with layout of the new notifications page
  - Fixed crash on notifications page
 - Legacy-Id: 7644
2014-04-25 14:44:40 +00:00
Robert Sparks 53feb01d67 Have group conflicts showing now - not sure find-free is working yet
- Legacy-Id: 7551
2014-03-27 19:47:31 +00:00
Robert Sparks e953538543 checkpoint before refactoring the conflict array
- Legacy-Id: 7548
2014-03-27 15:00:14 +00:00
Robert Sparks 5cdfe6adbf reasonably complete merge, but some of the newer-style tests are failing because the js API changed
- Legacy-Id: 7188
2014-01-31 01:13:53 +00:00
Ole Laursen 1dd422e013 Remove the unused old versions of jQuery, some Secretariat pages are still on jquery-1.5.1 but they are using a separate copy and can be dealt with separately
- Legacy-Id: 7102
2014-01-10 15:01:38 +00:00
Ole Laursen 1f41a07499 Remove unused base.js, it contained search result list utilities that have been migrated to jQuery in doc-search.js
- Legacy-Id: 7101
2014-01-10 14:59:36 +00:00
Ole Laursen 8442eb37a2 Fix a bunch of missing semicolons and var declarations in community.js
- Legacy-Id: 7098
2014-01-10 14:15:15 +00:00
Ole Laursen ab382a726f While cleaning up the Javascript includes in the nomcom app, it turns
out nomcom.js is included in the wrong pages, and on the pages it is
actually useful in, it's obsolete, so delete it together with the
obsoleted AJAX view and the other JS left-over cruft in nomcom/, this
fixes an include 404 and removes the remaining dependency on
jquery-1.5.1 apart from the Secretariat tools
 - Legacy-Id: 7097
2014-01-10 14:06:36 +00:00
Ole Laursen f8b1568c87 Rewrite meeting PUTs to POSTs. For no apparent reason, parts of the
meeting AJAX code is using PUT instead of POST (even if it's not
PUT'ing in the literal sense but POST'ing). Theoretical discussions
aside, Django has poor support for PUTs turned POSTs so rewriting them
removes the need for a couple of hacks, and makes it easier to test.
 - Legacy-Id: 7067
2013-12-24 15:13:33 +00:00
Ole Laursen 66f3832f25 Fix syntax error in agenda JS
- Legacy-Id: 7019
2013-12-19 16:50:13 +00:00
Ole Laursen 97bf521ebb Fix some bugs in the liaisons Javascript, reformulate it slightly to
not create jQuery plugins
 - Legacy-Id: 6793
2013-12-05 12:59:25 +00:00
Ole Laursen 9457669310 Merge in changes from the old shimfree branch
- Legacy-Id: 6764
2013-11-27 12:55:50 +00:00
Ole Laursen ecf68dbb05 Revamp and clean up submit models:
- Rename IdSubmissionDetail to Submission
- Rename various submission fields to correspond to the conventions in
  the new schema
- Use a name model for the states instead of IdSubmissionStatus
- Drop the TempIdAuthor model which is based on splitting up author
  names
- Add a simple textual SubmissionEvent for tracking events in the
  lifetime of a submission
- Delete a bunch of obsolete fields
- Make sure all submission have an access key so we can depend on it
- Add state for when approval is needed from previous authors

A couple of migrations take care of transforming the
IdSubmissionDetail and moving data over/cleaning it up.

Also revamp the submit view code:

- Make form code do validation/cleaning only so there's a clear
  separation of concerns
- Reduce uses of inheritance that made the code hard to follow -
  forms now don't inherit from each other, views don't call each other
  but instead reuse common utilities, templates share CSS/utilities
  instead of relying on inheritance
- Move email rendering/sending to separate file
- Drop the in-grown terminology use (auto post vs. manual posts)
- Make the status page explain who is emailed for what purpose
- Add history table with recorded events
- Make the status page handle its post actions by itself instead of
  duplicating most of the setup logic in a number of simple views
- Fix a couple of minor bugs and handle some edge cases better
- Expand tests with a couple of more cases

Possibly the submit tool could still use more help text added to
explain the process, ideally what's explained in the tool instructions
page should be inlined or self-evident.
 - Legacy-Id: 6714
2013-11-15 13:30:32 +00:00
Henrik Levkowetz a7838d8765 Cleanup action: replaced screaming html id with non-screaming version;
replaced the noTable block construct with start/end table_content blocks
in order to not have to open and close tables in different blocks, and
not have empty tables lying about.
 - Legacy-Id: 6439
2013-10-13 21:09:32 +00:00
Ole Laursen 1975ff27d0 Port IESG discusses to new schema
- Legacy-Id: 6418
2013-10-11 13:03:40 +00:00
Henrik Levkowetz a3c8adfdf6 Merged in the contents of commit [6337] from mcr@sandelman.ca, with some changes to take out dead code that inadvertently came back in.
- Legacy-Id: 6344
Note: SVN reference [6337] has been migrated to Git commit d0d1d949a9328da6c4e30d8f5e0d14ffb204e678
2013-10-02 21:53:28 +00:00
Henrik Levkowetz 08e90fd63f Enabling jquery again in template base.html. Moving library pack jquery-1.8.2 from /static/js/ to /static/js/lib/. Replacing jquery-1.5.1 with 1.8.2 in some places; the incompatibilities listed on the jquery pages seem to be small, and on a cursory inspection not present in the current usage.
- Legacy-Id: 6342
2013-10-02 15:44:50 +00:00
Henrik Levkowetz 95f9436507 Undid gratuitous whitespace changes.
- Legacy-Id: 6287
2013-09-26 22:00:45 +00:00
Henrik Levkowetz ad7ba6e494 Undid gratuitous whitespace changes.
- Legacy-Id: 6286
2013-09-26 21:58:09 +00:00
Henrik Levkowetz 6154b9922d This commit isn't tested. It captures the state after merging in branch/ssw/agenda/v4.70.
- Legacy-Id: 6273
2013-09-26 19:56:17 +00:00
Henrik Levkowetz 6baea429aa Merged in the nomcom app from ejimenez@yaco.es and esanchez@yaco.es, and accompanying dbtemplate app and the (standard) docutils module. Added some tweaks to get all tests to pass and migrations to run.
- Legacy-Id: 5948
2013-08-06 10:09:29 +00:00
Henrik Levkowetz 6794113320 Merged [5898] from adam@nostrum.com, with
additional tweaks from henrik: Added the capability to search for all kinds
 of documents in the main datatracker search page.  Fixes bug #838.
 - Legacy-Id: 5926
Note: SVN reference [5898] has been migrated to Git commit b14a8d0cee
2013-07-31 12:45:32 +00:00
Henrik Levkowetz cbfe489ff5 Merged in more shim-layer removals from olau@iola.dk
(-r5465:HEAD from branch/iola/shimfree).  Copying relevant
commit messages here:

 - Deleted dead code in many places.

 - Renamed id-something to draft-something, make the "is
   this eligible for expiration" logic clearer

 - Added a name for IPR search URL

 - Revamped the ballot popup view

 - URL reversed the IPR search link instead of hardcoding it

 - Cleaned up search views and remove dead code, port them to the new DB
   schema, hack related views in iesg/ and wginfo/ to use the new search
   interfaces, avoid camelCase in search GET parameters (with
   backwards-compat fallback), add some simple search unit tests, remove
   caching from views_search.py index pages as they're now pretty fast to
   generate, rewrite ballot popup JS, regularize some CSS classes to use
   hyphen-notation rather than camelCase, move some of the search
   templates to doc/.

   idrfc/ now mostly contains some wrapper code still in use by other
   subdirs, some ported code not yet moved, and dead code.

 - Fixed output bug in test crawler and print referrer upon errors so it's
   easier to figure out where a link came from

 - Added /doc/in-last-call/ to crawler, report original page as referrer in
   a redirect chain rather than intermediate URL

 - Ported idindex to new schema, speed them up, add tests, refactor index
   page in views_search to share code with the text index file, get rid
   of some special-case idindex filters from ietf_filters, move
   "/drafts/" redirects to a file in /doc/

 - Ported /idtracker/status/ and /idtracker/status/last-call/ overview of
   drafts in IESG process to new schema in /doc/iesg/ and
   /doc/iesg/last-call/

 - Added redirects for all of /idtracker/*, removed all view code and other
   dead code from idtracker/

 - Removed the idtracker sitemap indexing drafts - in its current form,
   it adds nothing of value to the HTML-based /doc/all/ view, and it's
   pretty slow

 - Ported idtracker feeds to new schema, move them to doc/, cleaned up
   idtracker/ - only templatetags/ietf_filters and proxy code is left
 - Legacy-Id: 5836
2013-07-17 20:52:39 +00:00
Henrik Levkowetz e678659b56 Merged in a lot of shim-layer removals from olau@iola.dk
(-r5194:5465 from branch/iola/shimfree).  Copying relevant
commit messages here:

  - Removed .related many to many relationship, it's not really useful
    since we always have to restrict on the relationship type anyway,
    instead add two helpers for doing the necessary queries (in both
    directions)

  - Added migration for transforming the .desc on the new_revision events
    into something more akin to what is actually shown in the history page

  - Added migration for blanking IESG notes that just consist of "RFC
    XXXX", these have been superfluous for some time

  - Grant stream chairs access to changing the stream on a draft

  - Hacked the format_history_text filter to be less weird, using the same
    formatting for snippets and full text, also link up legacy ballot set
    events

  - Moved the decoraters + utilities to new ietfauth/utils.py file

  - Added simple helper to Email to identify invalid email addresses (from
    legacy author entries)

  - Used new new_revision .desc format for when drafts are submitted

  - Improved the looks of the button class by adding extra contrast and a
    linear gradient. Currently the gradient is only visible in fairly
    recent browsers.

  - Rewrote draft and RFC tabs in terms of the new schema, porting
    write-up and history tabs as well

  - Fixed two bugs in RFC Editor syncing: make sure documents we don't know
    beforehand get a "draft" type and make sure individually submitted
    drafts get the type="individ" group instead of NULL

  - Made the CSS-styled button feel a bit nicer to use by flattening the
    active state, also introduce some temporary styles until browsers
    catch up with the standard syntax

  - Added migrations for fixing 1) a dummy RFC entry, 2) three stand-alone
    RFCs that didn't get their doc.type set, 3) a big bunch of historic
    stand-alone RFCs that have doc.group=None - set these to the
    individual submission "none" group for the time being so the view code
    doesn't have to deal with a special case.

    In some cases this is wrong since there actually was a WG associated
    but unfortunately fixing them properly requires detective work
    (probably parsing the RFCs) and in at least some cases recreating
    historic WGs. In case someone ends up doing this, the documents to
    check can still be found with

    Document.objects.filter(name__startswith="rfc", group__type="individ")
    since there are almost no new RFCs that didn't went through the I-D
    process.

  - Merged the I-D and RFC views by showing I-D information on RFCs too.
    I-Ds that have been published as RFCs redirect to the RFC URL. Also
    support alias URLs so e.g. /doc/bcpXXXX redirects to /doc/rfcXXXX.

  - Fixed revision augmentation so events after RFC publication gets a "RFC"
    designation

  - Fixed a bug with tabs not using provided name but rather doc.name

  - Displaying draft-iesg state rather than doc.friendly_state as IESG state,
    also show a notice that the IESG state refers to post-RFC processing
    if it does, like the old separate RFC page did

  - Fixed the RFC number doc.note migration to catch combined "RFC XXX; BCP
    XXX" notes too, use the opportunity to remove inserted HTML tags from
    notes and rely on linebreaksbr filter instead (the other thing was a
    left-over from the Perl days), update the various uses of the note to
    reflect that

  - Refactored slightly to make views_doc.py independent of other idrfc code

  - Moveed idrfc/views_doc.py to doc/ with associated templates, replace the
    somewhat fragile simple URL tests for views_doc.py with ordinary unit
    tests. The new tests are still fairly basic but at least test more
    than the URL tests did.

  - Made sure RFC's (and BCP/STD/FYI) are stored as RFC123 instead of
    RFC0123 in the alias table with a new migration and a change to the
    RFC Editor sync, this in turn makes /doc/std1/ do the right thing

  - Now /doc/std1/ works, we can actually do a local link in
    urlize_ietf_docs rather than linking to the tools.ietf.org server

  - Fixed history text formatter: sanitize HTML before adding linebreaks and
    non-breaking spaces, this cuts the time to render a history page with
    long comments in half

  - Added a test crawler that walks through the crawlable part of the site,
    reporting errors and slow pages

  - Got rid of initial "No record" positions when showing old positions,
    it's just noise

  - Added a .select_related() to the document main tab to reduce the number
    of DB queries, unfortunately it seems it doesn't really help with
    Django 1.2.x due to a bug (Document inherits from DocumentInfo which
    makes things a bit more complicated)

  - Introduced a simple cache in doc.get_state so repeated reads don't
    cause a DB query

  - Cleaned up the search code in preparation for removal of the shim-layer;
    use a static button and don't send extraneous GET parameters

  - Removed dead code in several places
 - Legacy-Id: 5830
2013-07-15 20:55:24 +00:00