Commit graph

51 commits

Author SHA1 Message Date
Henrik Levkowetz 8c6eb3a30a Python2/3 compatibility: Changed the use of open() and StringIO to io.open() etc.
- Legacy-Id: 16458
2019-07-15 19:14:04 +00:00
Henrik Levkowetz 0679eaa8d4 Removed unused imports.
- Legacy-Id: 16402
2019-07-04 21:06:57 +00:00
Henrik Levkowetz f480799af9 Undid unintentional bulk commit
- Legacy-Id: 16401
2019-07-04 21:04:46 +00:00
Henrik Levkowetz fc09a59950 Added decode() of command pipe output.
- Legacy-Id: 16400
2019-07-04 21:01:39 +00:00
Henrik Levkowetz 36cac48063 Fixed a bunch of str/bytes issues.
- Legacy-Id: 16341
2019-06-30 20:54:09 +00:00
Henrik Levkowetz 15e74e89cb Converted instances of assertTrue(text in response.content) to the recommended assertContains(response, text), and similar for assertFalse(... in ...)
- Legacy-Id: 16336
2019-06-29 13:43:31 +00:00
Henrik Levkowetz d7f5c84182 Initial 2to3 patch with added copyright statement updates.
- Legacy-Id: 16309
2019-06-27 14:40:54 +00:00
Henrik Levkowetz 55bd2e5e42 Fixed some unintentional wg list address changes, and added some other test mail address changes.
- Legacy-Id: 15994
2019-03-04 20:54:38 +00:00
Henrik Levkowetz 2b811b3d3d Updated the tests to always use @ietf.org addresses where appropriate, and not do so when not appropriate. All test user login addresses have been changed away from @ietf.org.
- Legacy-Id: 15988
2019-03-04 20:08:48 +00:00
Robert Sparks b86bd84278 Improvements to tests after converting to factories suggested by studying coverage_changes. Commit ready to merge.
- Legacy-Id: 15248
2018-06-13 22:09:01 +00:00
Robert Sparks 880dafdb24 Use factories for ietf.doc.tests_charter. Commit ready for merge.
- Legacy-Id: 15226
2018-06-07 23:50:27 +00:00
Robert Sparks 84d3c92298 more factoryization of ietf.doc.tests. Commit ready for merge.
- Legacy-Id: 15205
2018-06-02 13:39:39 +00:00
Henrik Levkowetz 67a17bb227 Fixed a number of tests to deal correctly with model method caching.
- Legacy-Id: 15009
2018-04-05 10:55:27 +00:00
Robert Sparks 8026f86cd3 Cleaner charter factory simplifies test code. Commit ready for merge.
- Legacy-Id: 14899
2018-03-22 14:01:24 +00:00
Robert Sparks f11907b6a0 Improved test coverage for ietf/doc/views_charter.py. Commit ready for merge.
- Legacy-Id: 14896
2018-03-21 21:59:45 +00:00
Robert Sparks 975522af35 Make a more appropriate review message when a BoF has an initial charter under consideration. Fixes #2458. Commit ready for merge.
- Legacy-Id: 14715
2018-02-28 20:54:56 +00:00
Henrik Levkowetz 4488fd82a4 Merged in [14467] from housley@vigilsec.com:
Close any previous ballots when a charter goes to Internal Review or Extrernal Review.  Fixes #2421.
 - Legacy-Id: 14470
Note: SVN reference [14467] has been migrated to Git commit de6121c6c1
2017-12-29 13:40:10 +00:00
Russ Housley de6121c6c1 Close any previous ballots when a charter goes to Internal Review or Extrernal Review. Fixes #2421.
- Legacy-Id: 14467
2017-12-28 20:09:56 +00:00
Henrik Levkowetz 14c748df98 Changed the creation of temporary test dirs to use names which include the test class name, in order to make it possible to run test cases in parallel. Disabled coverage testing when running in parallel (those classes cannot be pickled and distributed to the test runner threads, and also won't pass coverage data back). Tweaked the TestCase.tempdir() method.
- Legacy-Id: 13157
2017-03-27 21:41:18 +00:00
Lars Eggert 8a70e9773d Fix various "RemovedInDjango20Warning" warnings. Commit ready for merge.
- Legacy-Id: 13112
2017-03-25 19:16:45 +00:00
Lars Eggert afdf154e0a Change "ID Tracker" to "Datatracker" in various places. Fixes some of #2100.
Commit ready for merge.
 - Legacy-Id: 13108
2017-03-25 18:23:38 +00:00
Henrik Levkowetz 4daf66d11c Added DocEvent rev= parameter througout the code.
- Legacy-Id: 12978
2017-03-06 15:08:21 +00:00
Henrik Levkowetz 5f053ad21a Cleaned up the remaining explicit url names, using dotted-paths to view
functions instead.  In all almost 700 changes.
 - Legacy-Id: 12923
2017-02-26 23:21:49 +00:00
Henrik Levkowetz aa5e61d958 Updated all urlpatterns to use ietf.utils.urls.url() instead of django's,
in order to autogenerate dotted path url pattern names.  Updated a number
of url reverses to use dotted path, and removed explicit url pattern names
as needed.

Changed some imports to prevent import of ietf.urls before django
initialization was complete.


Changed 3 cases of form classes being curried to functions; django 1.10
didn't accept that.

Started converting old-style middleware classes to new-style middleware
functions (incomplete).

Tweaked a nomcom decorator to preserve function names and attributes, like
a good decorator should.

Replaced the removed django templatetag 'removetags' with our own version
which uses bleach, and does sanitizing in addition to removing explicitly
mentionied html tags.

Rewrote the filename argument handling in a management command which had
broken with the upgrade.
 - Legacy-Id: 12818
2017-02-11 14:43:01 +00:00
Henrik Levkowetz 4b0a9360f0 Merged in ^/branch/iola/event-saving-refactor-r10291, which refactors document saving to always use doc.save_with_history(events), and requires accompanying events. This branch also provides refactoring of recurring regexes in url patterns into a dictionary. As part of the merge, also refactored new code which didn't use the save_with_history() method.
- Legacy-Id: 11840
2016-08-23 10:52:08 +00:00
Henrik Levkowetz e6a005dba6 Added a score of setting save/restores to test setup/teardown actions.
- Legacy-Id: 11436
2016-06-21 07:51:02 +00:00
Robert Sparks b1f229cf9d Create the approval ballot for charters when the charter enters external review (or iesg review if external review is skipped). Fixes #1792. Commit ready for merge.
- Legacy-Id: 10803
2016-02-08 19:59:47 +00:00
Robert Sparks dc2593ebe5 Tweak the rendering of Area Directors in the charter text used in new-work, internal review, external review, and group action messages to display. Fixes #1889. Commit ready to merge.
- Legacy-Id: 10723
2016-01-22 20:47:45 +00:00
Henrik Levkowetz 139cda9543 Added listing of Area Directors, and TBD indications, that was inadvertently dropped from some chartering related emails during refactoring. Also added testing code to verify the email body content of some chartering emails a bit more thoroughly.
- Legacy-Id: 10683
2016-01-13 18:32:02 +00:00
Lars Eggert bcea97323f Fix the internal review email template and related code to handle IRTF RGs
better. Commit ready for merge.
 - Legacy-Id: 10673
2016-01-13 13:50:16 +00:00
Henrik Levkowetz db7aa73eb4 Merged in [10418] from henrik@levkowetz.com:
Modified the test data to use some AD and WG chair names that contain non-ascii characters, and fixed test issues found.
 - Legacy-Id: 10420
Note: SVN reference [10418] has been migrated to Git commit cf7d794b09
2015-11-04 08:46:35 +00:00
Henrik Levkowetz cf7d794b09 Modified the test data to use some AD and WG chair names that contain non-ascii characters, and fixed test issues found.
- Legacy-Id: 10418
2015-11-04 07:34:56 +00:00
Robert Sparks ff93fe3599 Make the internal review message reflect whether this is a new chartering effort or a recharter. Fixes #1814. Commit ready to merge.
- Legacy-Id: 10378
2015-11-03 05:28:06 +00:00
Ole Laursen 86c3a430d1 Merge in ^/branch/iola/event-saving-refactor-r10076, fixing a few problems
- Legacy-Id: 10298
2015-10-27 10:37:06 +00:00
Ole Laursen 43445307b1 Summary: Be more careful with generating announcements for charters so
they are not saved unless we're in a POST
 - Legacy-Id: 10141
2015-10-07 10:42:31 +00:00
Ole Laursen 63d96e0354 Summary: Get rid of submit_initial_charter hack, only create a charter
when a first revision has actually been submitted.
 - Legacy-Id: 10136
2015-10-06 15:14:31 +00:00
Ole Laursen e1f0917659 Summary: Add new document saving API, Document.save_with_history(events).
The new API requires at least one event and will automatically save a
snapshot of the document and related state. Document.save() will now
throw an exception if called directly, as the new API is intended to
ensure that documents are saved with both an appropriate snapsnot and
relevant history log, both of which are easily defeated by just
calling .save() directly.

To simplify things, the snapshot is generated after the changes to a
document have been made (in anticipation of coming changes), instead
of before as was usual.

While revising the existing code to work with this API, a couple of
missing events was discovered:

- In draft expiry, a "Document has expired" event was only generated
  in case an IESG process had started on the document - now it's
  always generated, as the document changes its state in any case

- Synchronization updates like title and abstract amendmends from the
  RFC Editor were silently (except for RFC publication) applied and
  not accompanied by a descriptive event - they now are

- do_replace in the Secretariat tools now adds an event

- Proceedings post_process in the Secretariat tools now adds an event

- do_withdraw in the Secretariat tools now adds an event

A migration is needed for snapshotting all documents, takes a while to
run. It turns out that a single document had a bad foreign key so the
migration fixes that too.
 - Legacy-Id: 10101
2015-09-28 14:01:03 +00:00
Robert Sparks 150106619b Handle the new-work message
- Legacy-Id: 10066
2015-08-27 21:27:10 +00:00
Robert Sparks 12a03d299b Automatically send the Internal Review message that the secretary currently has to send manually
- Legacy-Id: 10063
2015-08-26 21:31:11 +00:00
Robert Sparks 8a74604a1b Done with the second pass focusing on test coverage. Lots of test tweaks, some new tests, a couple of bugs fixed. The session request code views need to be redone to allow testing.
- Legacy-Id: 10035
2015-08-21 16:39:00 +00:00
Robert Sparks f30f5c39f1 checkpoint
- Legacy-Id: 10017
2015-08-13 21:16:21 +00:00
Robert Sparks 6c85bc558c checkpoint. Sets initial notify to empty
- Legacy-Id: 10009
2015-08-11 02:27:59 +00:00
Ole Laursen 7d0e817e5d Fix a bunch of failing tests, mostly due to changes in markup
- Legacy-Id: 8529
2014-10-31 17:20:14 +00:00
Henrik Levkowetz d4e5f070af Merged in [8293] from rjsparks@nostrum.com:\n XXX: Should what is now captured in the list of STATUSCHANGE_RELATIONS instead be captured in the database in name_docrelationshipname?
Refactored editing the notify field to remove redundant code.
Changed the default notification list to include .all for documents, and the wg list for wg documents.
Allowed recalculating the notification list for all document types.
Improved the calculated notification list value for charters, conflict-reviews, and status-changes.
Adds shepherds to the notification list when they are assigned to a document.
Adds the working group email list to the notification list when a document is adopted.
Fixes #1438
 - Legacy-Id: 8385
Note: SVN reference [8293] has been migrated to Git commit 640c5eb52ace8bb6d2c1b3ca6c14ef10ad0f324f
2014-10-12 17:32:11 +00:00
Henrik Levkowetz ec3e247732 Merged in [8262] and [8263] from rjsparks@nostrum.com:
Changes when returning_item is automatically set to match the
    current IESGs preferences.  Removes several chunks of dead code
    related to editing telechat dates.  Improves returning item tests.

    Refactored multiple edit_telechat functions into one function in
    doc_views.  Added a helper function for determining if ballots have
    changed to isolate the implementation.  Fixed the issue with
    update_agenda setting the returning item bit even when the user
    explicitly said not to.  Added prompting to encourage proper setting
    of the returning item bit to the edit_telechat view.

    Fixes #1209
 - Legacy-Id: 8369
Note: SVN reference [8262] has been migrated to Git commit 9d8d0d63e2338d6fa81a82c553b8c6a1c3a105c1

Note: SVN reference [8263] has been migrated to Git commit 35a7436b782fc45e224ac9ea29bfb535fd3ce959
2014-09-28 19:57:01 +00:00
Henrik Levkowetz c19268f6a1 A second pass of pyflakes cleanup, removing additional bulk imports, fixing a bug in get_initial_notify(), and removing some dead (and buggy) code.
- Legacy-Id: 7509
2014-03-16 22:15:46 +00:00
Henrik Levkowetz 02031a01b9 Cleaned out some (arbitrary) submodule name imports into ietf.utils, and made the corresponding import statements import the names directly from the correct submodules.
- Legacy-Id: 7495
2014-03-16 07:09:38 +00:00
Henrik Levkowetz 5bef5d11ae Made doc/ pyflakes-clean.
- Legacy-Id: 7462
2014-03-15 16:09:47 +00:00
Ole Laursen 87ca10d122 Remove usage of log_state_changed (and duplicate in
doc/utils_charter.py) in favour of add_state_change_event which has
slightly better API but otherwise does basically the same except it
sets an event type we can later search for. Also expand tests slightly
to exercise three more templates.
 - Legacy-Id: 7129
2014-01-15 17:52:00 +00:00
Ole Laursen 6b2d50db93 Implement missing charter tests as found by the coverage check
- Legacy-Id: 7127
2014-01-14 15:50:03 +00:00