Commit graph

68 commits

Author SHA1 Message Date
Henrik Levkowetz 2cfb81fc83 Changed instances of email body extaction to use a custom get_payload() function.
- Legacy-Id: 16454
2019-07-15 17:15:16 +00:00
Henrik Levkowetz 0679eaa8d4 Removed unused imports.
- Legacy-Id: 16402
2019-07-04 21:06:57 +00:00
Henrik Levkowetz f480799af9 Undid unintentional bulk commit
- Legacy-Id: 16401
2019-07-04 21:04:46 +00:00
Henrik Levkowetz fc09a59950 Added decode() of command pipe output.
- Legacy-Id: 16400
2019-07-04 21:01:39 +00:00
Henrik Levkowetz 97a555936d Changed a large number of test assertions to use assertContains() and removed separate, now unnecessary,status_code checks. Also changed many assertTrue(... in ...) to use assertIn().
- Legacy-Id: 16346
2019-06-30 21:03:34 +00:00
Henrik Levkowetz 15e74e89cb Converted instances of assertTrue(text in response.content) to the recommended assertContains(response, text), and similar for assertFalse(... in ...)
- Legacy-Id: 16336
2019-06-29 13:43:31 +00:00
Henrik Levkowetz d7f5c84182 Initial 2to3 patch with added copyright statement updates.
- Legacy-Id: 16309
2019-06-27 14:40:54 +00:00
Henrik Levkowetz 426870b766 Merged in the Document and DocAlias primary key change and m2m work in ^/personal/henrik/6.96.1-docalias.
- Legacy-Id: 16261
2019-06-15 12:00:48 +00:00
Henrik Levkowetz a2cafded25 Changed DocAlias to be many-to-many, in order to be able to handle STD aliases referring to multiple RFCs.
- Legacy-Id: 16249
2019-06-14 20:38:14 +00:00
Henrik Levkowetz 33e0f8c35d Merged in [16126] from housley@vigilsec.com:
Allow Secretariat to handle downrefs when they approve a document
 - Legacy-Id: 16134
Note: SVN reference [16126] has been migrated to Git commit 8c7e75101d
2019-04-08 17:02:02 +00:00
Russ Housley 8c7e75101d Allow Secretariat to handle downrefs when they approve a document
- Legacy-Id: 16126
2019-04-01 19:46:14 +00:00
Robert Sparks fbfd204eb9 Include the note itself in email sent when the RFC editor note changes after document approval. Also changed the flow to redirect back to the writeups pages after editing the RFC editor note. Fixes #2672. Commit ready for merge.
- Legacy-Id: 16110
2019-03-28 10:07:11 +00:00
Henrik Levkowetz e4af908a74 Merged in [15698] from rjsparks@nostrum.com:
Notify the RFC Editor when an RFC Editor note is changed after a draft has been approved. Fixes #2440.
 - Legacy-Id: 15729
Note: SVN reference [15698] has been migrated to Git commit 43374969f6
2018-11-06 07:13:56 +00:00
Robert Sparks 43374969f6 Notify the RFC Editor when an RFC Editor note is changed after a draft has been approved. Fixes #2440. Commit ready for merge.
- Legacy-Id: 15698
2018-11-03 08:13:10 +00:00
Jean Mahoney 194d8c89d1 Verb tense used in Ballot Issued emails now matches whether the LC end date is in the past or future. Fixes issue #2482. Commit ready for merge.
- Legacy-Id: 15679
2018-11-03 03:38:52 +00:00
Henrik Levkowetz 85aa1ecc25 Tweaked a test to prevent failures when looking for a specific string in line-wrapped text.
- Legacy-Id: 15397
2018-07-19 15:54:18 +00:00
Robert Sparks b86bd84278 Improvements to tests after converting to factories suggested by studying coverage_changes. Commit ready to merge.
- Legacy-Id: 15248
2018-06-13 22:09:01 +00:00
Robert Sparks dcf9e6b40f Use factories for ietf.doc.tests_ballots. Fixed a long-hidden bug in test_edit_verify_permissions where non-existing usernames were used and passed the tests accidently. Added list_email to the GroupFactory. Commit ready for merge.
- Legacy-Id: 15219
2018-06-06 17:59:40 +00:00
Robert Sparks ee346edaba Corrected the implementation of clear_ballot. Added a test for it. Restored functionality to ballot popups that was missing because a template variable was not passed in. Commit ready for merge.
- Legacy-Id: 15084
2018-04-25 19:52:44 +00:00
Henrik Levkowetz 12d999a384 Modified the IESG position setting API to send email messages about positions set.
- Legacy-Id: 15050
2018-04-17 11:57:16 +00:00
Henrik Levkowetz 67a17bb227 Fixed a number of tests to deal correctly with model method caching.
- Legacy-Id: 15009
2018-04-05 10:55:27 +00:00
Henrik Levkowetz 6567e707ce Merged in ^/personal/henrik/6.64.2-ballotapi@14426. This provides personal API keys and a ballot position API at /api/iesg/position. Also added an endpoint description at /api/.
- Legacy-Id: 14430
2017-12-17 23:43:44 +00:00
Henrik Levkowetz a08c8dc76f Added an API endpoint to support automation of IESG ballot position posting, at /api/iesg/position. Added tests for the API endpoint, and updated the apikey validation decorator tests. Tweaked the decorator to handle a weakness found during testing.
- Legacy-Id: 14429
2017-12-17 21:55:27 +00:00
Henrik Levkowetz 98d234cd86 Refactored the handling of BallotDocEvent in tests, only creating them as needed, in preparation for stricter checks on state transitions to avoid mismatches between state and ballot.
- Legacy-Id: 14380
2017-11-30 16:02:31 +00:00
Henrik Levkowetz a942bffbc6 Merged in [14355] from suresh@kaloom.com:
Fixes #2109
 - Legacy-Id: 14360
Note: SVN reference [14355] has been migrated to Git commit 51fa1deef2
2017-11-11 08:18:13 +00:00
Henrik Levkowetz b4fd2b63a8 Merged in [13205] from housley@vigilsec.com:
Check downref registry when producing Last Call text.  Fixes #2069.
 - Legacy-Id: 13210
Note: SVN reference [13205] has been migrated to Git commit aa7ed23cda
2017-04-12 21:24:33 +00:00
Russ Housley aa7ed23cda Check downref registry when producing Last Call text. Fixes #2069.
- Legacy-Id: 13205
2017-04-12 18:27:05 +00:00
Lars Eggert 8a70e9773d Fix various "RemovedInDjango20Warning" warnings. Commit ready for merge.
- Legacy-Id: 13112
2017-03-25 19:16:45 +00:00
Henrik Levkowetz 4daf66d11c Added DocEvent rev= parameter througout the code.
- Legacy-Id: 12978
2017-03-06 15:08:21 +00:00
Henrik Levkowetz 5f053ad21a Cleaned up the remaining explicit url names, using dotted-paths to view
functions instead.  In all almost 700 changes.
 - Legacy-Id: 12923
2017-02-26 23:21:49 +00:00
Henrik Levkowetz 4b0a9360f0 Merged in ^/branch/iola/event-saving-refactor-r10291, which refactors document saving to always use doc.save_with_history(events), and requires accompanying events. This branch also provides refactoring of recurring regexes in url patterns into a dictionary. As part of the merge, also refactored new code which didn't use the save_with_history() method.
- Legacy-Id: 11840
2016-08-23 10:52:08 +00:00
Robert Sparks 030ea1c939 Enhanced factories to simplify test writing. Commit ready for merge.
- Legacy-Id: 11656
2016-07-15 12:30:08 +00:00
Robert Sparks 992aba1aec Call out downreferences in autogenerated last call text. Fixes #1982. Commit ready for merge.
- Legacy-Id: 11654
2016-07-14 18:09:22 +00:00
Russ Housley b4b14112b8 Added test for proper eneration of the approval message with and without an RFC Editor Note.
- Legacy-Id: 10839
2016-02-12 22:09:13 +00:00
Russ Housley 6cf8680a16 Allow IAB, IRTF, and Independent streams to use new capability for RFC Editor Notes. Do not display of document shepherd and shepherd writeup for non-IETF stream documents. Do not display IESG information for IAB stream documents.
- Legacy-Id: 10834
2016-02-11 22:12:52 +00:00
Henrik Levkowetz 174cfeafa3 Merged in [10770], [10771], [10772], and [10773] from housley@vigilsec.com:
The IESG Telechat Agenda now shows "(Has RFC Editor Note)" after the I-D
filename if there is an RFC Editor Note associated with the document.  This
was added to the html and txt versions of the agenda.  It was not added to the
Secretariat view or the Scribe view of the agenda.

For transition, when an AD edits the RFC Editor Note, they need to move the
text from the current writeup into the new field.  Returning documents on the
telechat agenda seems to be the biggest opportunity for something to fall
between the cracks.  If an event of type "changed_rfc_editor_note' exists, and
the string "RFC Editor Note" appears in the text of the most recent
'changed_ballot_writeup_text' event, then a message is shown that tells the AD
to remove the RFC Editor Note from the writeup.
 - Legacy-Id: 10783
Note: SVN reference [10770] has been migrated to Git commit 4b5ac9e09e

Note: SVN reference [10771] has been migrated to Git commit 46589ee421

Note: SVN reference [10772] has been migrated to Git commit c73659e95c

Note: SVN reference [10773] has been migrated to Git commit 2e6633c016
2016-02-05 22:18:14 +00:00
Russ Housley 4b5ac9e09e Indicate on the IESG Telechat Agenda if a document has an RFC Editor Note. To accomplish this, the RFC Editor Note needed to be separated from the rest of the ballot write up. Fixes #1230.
- Legacy-Id: 10770
2016-02-04 13:32:24 +00:00
Henrik Levkowetz cf7d794b09 Modified the test data to use some AD and WG chair names that contain non-ascii characters, and fixed test issues found.
- Legacy-Id: 10418
2015-11-04 07:34:56 +00:00
Ole Laursen 86c3a430d1 Merge in ^/branch/iola/event-saving-refactor-r10076, fixing a few problems
- Legacy-Id: 10298
2015-10-27 10:37:06 +00:00
Ole Laursen ec54a59cc6 Summary: Be more careful when generating writeups so that we wait with
saving newly generated writeups until we see a POST (problem found by
the test crawler)
 - Legacy-Id: 10137
2015-10-06 16:20:12 +00:00
Ole Laursen e1f0917659 Summary: Add new document saving API, Document.save_with_history(events).
The new API requires at least one event and will automatically save a
snapshot of the document and related state. Document.save() will now
throw an exception if called directly, as the new API is intended to
ensure that documents are saved with both an appropriate snapsnot and
relevant history log, both of which are easily defeated by just
calling .save() directly.

To simplify things, the snapshot is generated after the changes to a
document have been made (in anticipation of coming changes), instead
of before as was usual.

While revising the existing code to work with this API, a couple of
missing events was discovered:

- In draft expiry, a "Document has expired" event was only generated
  in case an IESG process had started on the document - now it's
  always generated, as the document changes its state in any case

- Synchronization updates like title and abstract amendmends from the
  RFC Editor were silently (except for RFC publication) applied and
  not accompanied by a descriptive event - they now are

- do_replace in the Secretariat tools now adds an event

- Proceedings post_process in the Secretariat tools now adds an event

- do_withdraw in the Secretariat tools now adds an event

A migration is needed for snapshotting all documents, takes a while to
run. It turns out that a single document had a bad foreign key so the
migration fixes that too.
 - Legacy-Id: 10101
2015-09-28 14:01:03 +00:00
Robert Sparks f5b6465e81 mailtoken becomes mailtrigger
- Legacy-Id: 10090
2015-09-17 20:03:45 +00:00
Robert Sparks e5306eda00 Instrumented issuing ballots. Simplified the ballot-issued email significantly. Deferred adding ballot_saved mail for the automatic yes positions.
- Legacy-Id: 10068
2015-08-28 17:33:49 +00:00
Robert Sparks 4e61776c89 Smarter send_ballot_comment form
- Legacy-Id: 10054
2015-08-24 18:25:39 +00:00
Robert Sparks 90c3426e2f updated mailtoken utilities to match the model refactor. Morphed all the code using the utilities to match. Added paths to get Cc through as needed. Next up: Recipient selection form for the iesg save-and-send-email workflow
- Legacy-Id: 10040
2015-08-23 18:15:06 +00:00
Robert Sparks 8a74604a1b Done with the second pass focusing on test coverage. Lots of test tweaks, some new tests, a couple of bugs fixed. The session request code views need to be redone to allow testing.
- Legacy-Id: 10035
2015-08-21 16:39:00 +00:00
Robert Sparks f30f5c39f1 checkpoint
- Legacy-Id: 10017
2015-08-13 21:16:21 +00:00
Robert Sparks 839d0f89ad checkpoint
- Legacy-Id: 10016
2015-08-13 19:41:02 +00:00
Robert Sparks 79d373fa71 checkpoint.
- Legacy-Id: 10011
2015-08-11 21:52:28 +00:00
Robert Sparks 7649397f5b Better app and model names. Some model hygiene. Added admin.
- Legacy-Id: 9993
2015-08-09 20:11:26 +00:00