Commit graph

89 commits

Author SHA1 Message Date
Henrik Levkowetz bdc73e771a Python2/3 compatibility: replaced six.ensure_text() with either six.text_type or django's force_text(), depending on the case, and fixed a variable scope issue.
- Legacy-Id: 16461
2019-07-16 13:20:05 +00:00
Henrik Levkowetz 8c6eb3a30a Python2/3 compatibility: Changed the use of open() and StringIO to io.open() etc.
- Legacy-Id: 16458
2019-07-15 19:14:04 +00:00
Henrik Levkowetz 36cac48063 Fixed a bunch of str/bytes issues.
- Legacy-Id: 16341
2019-06-30 20:54:09 +00:00
Henrik Levkowetz 3ec7e864be Converted leading tabs to spaces in ietf/**/*.py
- Legacy-Id: 16310
2019-06-27 14:51:02 +00:00
Henrik Levkowetz d7f5c84182 Initial 2to3 patch with added copyright statement updates.
- Legacy-Id: 16309
2019-06-27 14:40:54 +00:00
Henrik Levkowetz 682ddee8e4 Reverted earlier application of on_behalf_of() at mail sending call points, and instead did all on_behalf_of processing in condition_message(). Added insertion of Reply-To header fields in this case. Changed all use of the mail-sending 'extra' parameters to use value lists. Updated a bunch of tests accordingly.
- Legacy-Id: 16020
2019-03-11 17:01:33 +00:00
Henrik Levkowetz 435a0da12d Added on_behalf_of() calls for from addresses needing it throughout the code.
- Legacy-Id: 15992
2019-03-04 20:14:19 +00:00
Henrik Levkowetz 57a4c9f41f Added 9 new group features, and changed list-like char fields to json fields, to get better support for using the values as lists. Modified code to use the group features instead of explicit lists of group types in many places in the code.
- Legacy-Id: 15908
2019-01-22 18:11:46 +00:00
Jean Mahoney 194d8c89d1 Verb tense used in Ballot Issued emails now matches whether the LC end date is in the past or future. Fixes issue #2482. Commit ready for merge.
- Legacy-Id: 15679
2018-11-03 03:38:52 +00:00
Henrik Levkowetz cdc295bab8 Merged in [14655] from housley@vigilsec.com:
Strip the HTML tags around the new values in the mail produced by email_iesg_processing_document. Also, provide the previously missing URL at the end of the message. Fixes 2455.
 - Legacy-Id: 14657
Note: SVN reference [14655] has been migrated to Git commit 6ea0881a89
2018-02-19 17:36:09 +00:00
Russ Housley 6ea0881a89 Strip the HTML tags around the new values in the mail produced by email_iesg_processing_document. Also, provide the previously missing URL at the end of the message. Fixes 2455.
- Legacy-Id: 14655
2018-02-18 20:40:49 +00:00
Henrik Levkowetz 1f976da5c1 Third part of document read refactoring, after [14406] and [14410]. This replaces all usage of the non-unicode-aware get_document_content() function with unicode-aware Document.text() or Document.text_or_error() methods. This was triggered by yet another report of unicode content not being shown properly, and should fix all instances of document (drafts, agendas, minutes, etc.) display in the datatracker not handling unicode characters properly.
- Legacy-Id: 14411
Note: SVN reference [14406] has been migrated to Git commit 967ece7e7d

Note: SVN reference [14410] has been migrated to Git commit 660c81c272
2017-12-11 16:23:51 +00:00
Henrik Levkowetz 660c81c272 Tweaked the file content read refactoring in [14406] to try latin-1 conversion if unicode doesn't work.
- Legacy-Id: 14410
Note: SVN reference [14406] has been migrated to Git commit 967ece7e7d
2017-12-10 17:48:09 +00:00
Henrik Levkowetz 967ece7e7d Started refactoring of reading text from document files (drafts, charters, etc.) in order to normalise on one way of doing this, and making that return unicode rather than undecoded bytes. This is the first step of two, in order to gauge the possible issues and report on discrepancies.
- Legacy-Id: 14406
2017-12-08 21:51:11 +00:00
Henrik Levkowetz b4fd2b63a8 Merged in [13205] from housley@vigilsec.com:
Check downref registry when producing Last Call text.  Fixes #2069.
 - Legacy-Id: 13210
Note: SVN reference [13205] has been migrated to Git commit aa7ed23cda
2017-04-12 21:24:33 +00:00
Russ Housley aa7ed23cda Check downref registry when producing Last Call text. Fixes #2069.
- Legacy-Id: 13205
2017-04-12 18:27:05 +00:00
Lars Eggert 8a70e9773d Fix various "RemovedInDjango20Warning" warnings. Commit ready for merge.
- Legacy-Id: 13112
2017-03-25 19:16:45 +00:00
Lars Eggert afdf154e0a Change "ID Tracker" to "Datatracker" in various places. Fixes some of #2100.
Commit ready for merge.
 - Legacy-Id: 13108
2017-03-25 18:23:38 +00:00
Henrik Levkowetz 4daf66d11c Added DocEvent rev= parameter througout the code.
- Legacy-Id: 12978
2017-03-06 15:08:21 +00:00
Henrik Levkowetz 5f053ad21a Cleaned up the remaining explicit url names, using dotted-paths to view
functions instead.  In all almost 700 changes.
 - Legacy-Id: 12923
2017-02-26 23:21:49 +00:00
Henrik Levkowetz 988a2b808f Added explicit charset setting and consistent encoding to several email paths through the datatracker. After introducing support for non-ascii names in email addresses, using role.formatted_email() to insert names into email content doesn't work any more, since uncode names will now be rfc2047-encoded in formatted_email(). Added another method role.name_and_email() for this case. Replaced another case of '%s <%s>' name-and-email formatting with formataddr(). Fixed some tests which did not send unicode email bodies to the email functions. Fixes issue #2017.
- Legacy-Id: 12896
2017-02-21 19:17:10 +00:00
Henrik Levkowetz 4b0a9360f0 Merged in ^/branch/iola/event-saving-refactor-r10291, which refactors document saving to always use doc.save_with_history(events), and requires accompanying events. This branch also provides refactoring of recurring regexes in url patterns into a dictionary. As part of the merge, also refactored new code which didn't use the save_with_history() method.
- Legacy-Id: 11840
2016-08-23 10:52:08 +00:00
Henrik Levkowetz f2150df76a Merged in [11687], [11710] from presnick@qti.qualcomm.com:
Generate a message to Secretary and IESG when AD changes a draft state
to 'Approved'.  Fixes issue #796.
 - Legacy-Id: 11714
Note: SVN reference [11687] has been migrated to Git commit ae87e84610

Note: SVN reference [11710] has been migrated to Git commit 65bb1f2738
2016-07-19 10:48:13 +00:00
Pete Resnick ae87e84610 Generate message to Secretary and IESG when AD changes a draft state to "Approved".
Fixes issue #796. Commit ready for merge.
 - Legacy-Id: 11687
2016-07-16 17:09:21 +00:00
Robert Sparks 992aba1aec Call out downreferences in autogenerated last call text. Fixes #1982. Commit ready for merge.
- Legacy-Id: 11654
2016-07-14 18:09:22 +00:00
Russ Housley 6cf8680a16 Allow IAB, IRTF, and Independent streams to use new capability for RFC Editor Notes. Do not display of document shepherd and shepherd writeup for non-IETF stream documents. Do not display IESG information for IAB stream documents.
- Legacy-Id: 10834
2016-02-11 22:12:52 +00:00
Robert Sparks e7f90214c5 Handle expiring the last call of status change documents. Be more robust about errors when expiring last calls. Fixes #1911. Commit ready for merge.
- Legacy-Id: 10811
2016-02-10 15:37:58 +00:00
Henrik Levkowetz 174cfeafa3 Merged in [10770], [10771], [10772], and [10773] from housley@vigilsec.com:
The IESG Telechat Agenda now shows "(Has RFC Editor Note)" after the I-D
filename if there is an RFC Editor Note associated with the document.  This
was added to the html and txt versions of the agenda.  It was not added to the
Secretariat view or the Scribe view of the agenda.

For transition, when an AD edits the RFC Editor Note, they need to move the
text from the current writeup into the new field.  Returning documents on the
telechat agenda seems to be the biggest opportunity for something to fall
between the cracks.  If an event of type "changed_rfc_editor_note' exists, and
the string "RFC Editor Note" appears in the text of the most recent
'changed_ballot_writeup_text' event, then a message is shown that tells the AD
to remove the RFC Editor Note from the writeup.
 - Legacy-Id: 10783
Note: SVN reference [10770] has been migrated to Git commit 4b5ac9e09e

Note: SVN reference [10771] has been migrated to Git commit 46589ee421

Note: SVN reference [10772] has been migrated to Git commit c73659e95c

Note: SVN reference [10773] has been migrated to Git commit 2e6633c016
2016-02-05 22:18:14 +00:00
Russ Housley 4b5ac9e09e Indicate on the IESG Telechat Agenda if a document has an RFC Editor Note. To accomplish this, the RFC Editor Note needed to be separated from the rest of the ballot write up. Fixes #1230.
- Legacy-Id: 10770
2016-02-04 13:32:24 +00:00
Robert Sparks 87e2653f56 Added listing all the area directors back. Related to #1889. Commit ready for merge.
- Legacy-Id: 10726
2016-01-22 21:17:44 +00:00
Robert Sparks dc2593ebe5 Tweak the rendering of Area Directors in the charter text used in new-work, internal review, external review, and group action messages to display. Fixes #1889. Commit ready to merge.
- Legacy-Id: 10723
2016-01-22 20:47:45 +00:00
Henrik Levkowetz 139cda9543 Added listing of Area Directors, and TBD indications, that was inadvertently dropped from some chartering related emails during refactoring. Also added testing code to verify the email body content of some chartering emails a bit more thoroughly.
- Legacy-Id: 10683
2016-01-13 18:32:02 +00:00
Lars Eggert 7997b99f02 More fixes to charter-related emails and some related web templates. Mostly
focused on supporting the IRTF better, but also removing some redundancies
(i.e., including group_info.txt instead of duplicating something similar.)
Commit ready for merge.
 - Legacy-Id: 10674
2016-01-13 14:53:47 +00:00
Lars Eggert bcea97323f Fix the internal review email template and related code to handle IRTF RGs
better. Commit ready for merge.
 - Legacy-Id: 10673
2016-01-13 13:50:16 +00:00
Henrik Levkowetz 408d51c11f Merged in [10425] from bartosz.balazinski@interdigital.com:
Provide information about who has suggested document replaced-by information in the notification email.

    This commit fixes bug 1817,
 - Legacy-Id: 10440
Note: SVN reference [10425] has been migrated to Git commit ba39077180
2015-11-07 21:43:27 +00:00
Bartosz Balazinski ba39077180 This commit fixes bug 1817, commit ready to merge
- Legacy-Id: 10425
2015-11-04 23:25:51 +00:00
Robert Sparks be377e5ac5 When a group gives a document a new group state (particularly for the first time), send a message that says what happened instead of simply "Adopted". Fixes #1830. Commit ready for merge.
- Legacy-Id: 10384
2015-11-03 09:22:15 +00:00
Robert Sparks ff93fe3599 Make the internal review message reflect whether this is a new chartering effort or a recharter. Fixes #1814. Commit ready to merge.
- Legacy-Id: 10378
2015-11-03 05:28:06 +00:00
Robert Sparks 262ad86dba email_iana needs to leave address generation to mailtrigger and not try to rewrap the address. Commit ready for merge. This should be patched into production.
- Legacy-Id: 10363
2015-11-02 03:35:40 +00:00
Ole Laursen 86c3a430d1 Merge in ^/branch/iola/event-saving-refactor-r10076, fixing a few problems
- Legacy-Id: 10298
2015-10-27 10:37:06 +00:00
Ole Laursen ec54a59cc6 Summary: Be more careful when generating writeups so that we wait with
saving newly generated writeups until we see a POST (problem found by
the test crawler)
 - Legacy-Id: 10137
2015-10-06 16:20:12 +00:00
Ole Laursen e1f0917659 Summary: Add new document saving API, Document.save_with_history(events).
The new API requires at least one event and will automatically save a
snapshot of the document and related state. Document.save() will now
throw an exception if called directly, as the new API is intended to
ensure that documents are saved with both an appropriate snapsnot and
relevant history log, both of which are easily defeated by just
calling .save() directly.

To simplify things, the snapshot is generated after the changes to a
document have been made (in anticipation of coming changes), instead
of before as was usual.

While revising the existing code to work with this API, a couple of
missing events was discovered:

- In draft expiry, a "Document has expired" event was only generated
  in case an IESG process had started on the document - now it's
  always generated, as the document changes its state in any case

- Synchronization updates like title and abstract amendmends from the
  RFC Editor were silently (except for RFC publication) applied and
  not accompanied by a descriptive event - they now are

- do_replace in the Secretariat tools now adds an event

- Proceedings post_process in the Secretariat tools now adds an event

- do_withdraw in the Secretariat tools now adds an event

A migration is needed for snapshotting all documents, takes a while to
run. It turns out that a single document had a bad foreign key so the
migration fixes that too.
 - Legacy-Id: 10101
2015-09-28 14:01:03 +00:00
Robert Sparks f5b6465e81 mailtoken becomes mailtrigger
- Legacy-Id: 10090
2015-09-17 20:03:45 +00:00
Robert Sparks e5306eda00 Instrumented issuing ballots. Simplified the ballot-issued email significantly. Deferred adding ballot_saved mail for the automatic yes positions.
- Legacy-Id: 10068
2015-08-28 17:33:49 +00:00
Robert Sparks f68b46972e purged email_ad
- Legacy-Id: 10067
2015-08-27 22:23:38 +00:00
Robert Sparks 12a03d299b Automatically send the Internal Review message that the secretary currently has to send manually
- Legacy-Id: 10063
2015-08-26 21:31:11 +00:00
Robert Sparks ef2260ea63 New exlicit "Intended status changed" message
- Legacy-Id: 10061
2015-08-25 20:28:01 +00:00
Robert Sparks 5c13bddd77 New explicit "Comment has been added to document history" message
- Legacy-Id: 10060
2015-08-25 20:05:11 +00:00
Robert Sparks 9d239843e6 New explicit "Document has been adopted by group" message
- Legacy-Id: 10059
2015-08-25 18:41:04 +00:00
Robert Sparks 90c3426e2f updated mailtoken utilities to match the model refactor. Morphed all the code using the utilities to match. Added paths to get Cc through as needed. Next up: Recipient selection form for the iesg save-and-send-email workflow
- Legacy-Id: 10040
2015-08-23 18:15:06 +00:00