Commit graph

12101 commits

Author SHA1 Message Date
Lars Eggert fa00abf9de
fix: Add remote instructions and date/time to interim agenda page (#6442)
* fix: Add remote instructions to interim agenda page

Fixes #6433
Fixes #6249

* Also add date and time

* Fix HTML

* Fix CI fail

* Address code review comments

* More suggestions from @rjsparks

* Fix HTML

* Add suffix
2023-10-12 06:29:03 -05:00
Lars Eggert 0f6b403904
fix: Fix "Is Accepting Feedback: yes" action for NomCom (#6467)
Fixes #6466

While I'm here, apply list styling more consistently across NomCom pages.
2023-10-12 06:15:14 -05:00
Paul Selkirk 16f9e0e974
fix: Adjust IRTF charter approval email headers (#5917) (#6460) 2023-10-11 11:09:10 -05:00
Lars Eggert a02812bf7c
fix: Use String.prototype.localeCompare() when sorting table rows (#6441)
Fixes #6437
2023-10-10 10:10:30 -05:00
Paul Selkirk 72fef7bc69
fix: Don't allow ADs to set docs to -sent states (#6445) 2023-10-10 10:09:04 -05:00
Paul Selkirk f19d1047c4
feat: Update IRTF state when entering/exiting IETF conflict review (#6424)
* feat: Update IRTF state when entering/exiting IETF conflict review (#3469)

* fix: Update IRTF state in approve_conflict_review() as well

* chore: Add "new_state != prev_state" guard
2023-10-09 15:01:35 -05:00
David Schinazi 5e0d1bef0f
fix: Remove incorrect line from submission API info web page (#6432)
* Submit can replace

* Empty commit for CI

* revert change to api_submit_info
2023-10-09 12:15:47 -05:00
Lars Eggert 7dbfc0208a
feat: Remove document notes from the datatracker (#6387)
* Remove doc.note

* Address comments from @rjsparks

* Consistently display doc notes
2023-10-09 12:15:18 -05:00
Lars Eggert 0f16012c73
fix: Add html-validate suppression that should have been part of #6356 (#6440) 2023-10-09 11:30:45 -05:00
Robert Sparks a97f306555
fix: improve handling malformed new specific ipr submissions (#6420) 2023-10-04 16:41:24 -05:00
Robert Sparks 9a09bf1f7b
fix: make statement published time match statement doc time (#6419)
* fix: make statement published time match statement doc time

* test: improve testing of creating statements
2023-10-02 09:51:33 -05:00
Lars Eggert 250e045ec3
Simpler fix 2023-10-02 11:43:11 +03:00
Lars Eggert 510570521d
fix: Limit group names to 80 characters
Fixes #6416
2023-10-02 10:40:43 +03:00
Robert Sparks d6f5564a82
ci: merge release to main 2023-09-29 14:02:18 -05:00
Robert Sparks c5a955d798
fix: restore interim announce ability (#6410) 2023-09-29 11:33:14 -05:00
Robert Sparks 486a4f5370
Merge pull request #6345 from larseggert/fix-6343
fix: Add link to public pages to private NomCom pages
2023-09-29 10:13:58 -05:00
Robert Sparks e48eb84f44
Merge pull request #6397 from larseggert/feat-rerun-tests
feat: Add the ability to rerun a test suite until a failure occurs
2023-09-29 10:12:58 -05:00
Robert Sparks 18c6c12f24
Merge pull request #6406 from pselkirk/fix-5943
fix: The NomCom chair is not eligible for NomCom
2023-09-29 10:12:35 -05:00
Robert Sparks 40dc24e44b
chore: tweak comments 2023-09-29 07:52:32 -05:00
Paul Selkirk cbd49a737f fix: Disqualify the nomcom chair from volunteering for the nomcom 2023-09-28 14:55:06 -04:00
Paul Selkirk 658f7edeef test: Add test for RFC8713 section 4.15 disqualified roles 2023-09-28 14:53:38 -04:00
Lars Eggert 8abbaae0c0
Update ietf/utils/test_runner.py 2023-09-28 11:34:03 +03:00
Lars Eggert abe93a42b2
feat: Add the ability to rerun a test suite until a failure occurs
More quickly than looping in the shell around a non-zero error code.
This only incurs all the setup and scaffolding overheads once.
2023-09-28 11:31:16 +03:00
Lars Eggert 7398ea0523
Merge branch 'main' into fix-6393 2023-09-28 11:29:59 +03:00
Lars Eggert 37e98d3b5c
Fix the actual issue 2023-09-28 11:28:41 +03:00
Paul Selkirk c718fedb6c
feat: Allow review rejections to be undone (#6312)
* feat: Allow reviewer to accept a review they're previously rejected

* feat: Add a reviewer who has previously rejected a review to the list of suggested reviewers.

This largely un-does d105f8b, at the request of at least one team secretary.

* fix: Went a little overboard on the previous commit

one_assignment still has to exclude reviewers who rejected the assignment,
or they could end up being the suggested reviewer.

* fix: Actually do the assignment

* fix: If there's an existing assignment, don't create a new one

* style: Restructure conditional for clarity

* test: Add test cases for accepting or assigning a review assignment after rejecting it
2023-09-27 08:57:34 -05:00
Lars Eggert d282cd3a37
Merge branch 'main' into fix-6393 2023-09-27 16:27:41 +03:00
Lars Eggert c2c02273c3
fix: Allow filtering for nominees who have not declined (#6382)
* fix: Allow filtering for nominees who have not declined

Fixes #6380

* Update views.py

Co-authored-by: Robert Sparks <rjsparks@nostrum.com>

---------

Co-authored-by: Robert Sparks <rjsparks@nostrum.com>
2023-09-27 08:21:36 -05:00
Lars Eggert a469f08d63
Remove debug prints 2023-09-27 16:01:21 +03:00
Lars Eggert 4f6caa89b2
fix: Make sure groups in test have different acronyms
Fixes #6393
2023-09-27 15:59:59 +03:00
Lars Eggert a8f50f50b0
fix: Only enable city/country entry for in-person interims (#6383)
Was probably broken during the bs5 transition.

Fixes #6346
2023-09-26 12:00:05 -05:00
Lars Eggert 7e18a0fad2
fix: Allow editing of interim meeting subject lines (#6385)
Also change "readonly" to "disabled" to give a visual hint about which
fields are not changeable.

Fixes #6310
2023-09-26 08:10:46 -05:00
Lars Eggert 5db70b2787
fix: State descriptions can have HTML in them, mark them safe (#6384) 2023-09-26 08:09:39 -05:00
Lars Eggert 6acc7aa848
fix: Restore the ability to search in tables (#6386)
This was broken by 57030e4303
2023-09-26 08:03:29 -05:00
Lars Eggert 73008596ee
fix: Enable editing of related liaison statement information (#6371)
Fixes #6264
2023-09-25 10:17:35 -05:00
Jennifer Richards 8f0a0da5a3
fix: Typo 2023-09-25 12:01:27 -03:00
Lars Eggert a42ef589f3
Unsplit conditionals 2023-09-25 17:41:30 +03:00
Lars Eggert 9efcce227d
Be less clever 2023-09-25 13:42:15 +03:00
Lars Eggert d0de2294a3
Merge remote-tracking branch 'origin/main' into fix-6343 2023-09-25 13:05:31 +03:00
Lars Eggert 910a266126
fix: Prevent duplicate HTML IDs on photo page (#6356)
* fix: Prevent duplicate HTML IDs on photo page

Fixes #6355

* Just don't slugify the ID.

See https://mathiasbynens.be/notes/html5-id-class
2023-09-22 12:50:43 -05:00
Lars Eggert 26f34f4aef
Merge branch 'main' into fix-6343 2023-09-22 08:32:17 +03:00
Jennifer Richards b08d26d36e
feat: Scout monitoring for celery workers (#6342)
* feat: Scout APM instrumentation for celery

* fix: Remove guard that caused problem on production
2023-09-21 14:43:19 -05:00
Lars Eggert e76201103f
Fix pyflake 2023-09-21 18:15:12 +03:00
Lars Eggert 9391985cbb
fix: Add link to public pages to private NomCom pages
Fixes #6343

Also fix highlighting of the active tab in the nav tab bar while I'm here.
2023-09-21 17:20:38 +03:00
Lars Eggert 303ff70e64
fix: Linkify email address lists one-by-one (#6315)
* fix: Linkify email address lists one-by-one

Seems to work around a bug in mozilla/bleach.

Fixes #6307

* Cosmetic change

* Fix test
2023-09-15 10:45:58 -05:00
Robert Sparks 20f427e013
chore: remove unused view (#6304)
* chore: remove unused view

* chore: deflake

* chore: deflake
2023-09-14 17:10:26 -05:00
Tero Kivinen a3fb6a49a3
fix: add review team setting allowing reviewers to reject assignments past the deadline (#5418)
* Added a new review team setting
allow_reviewer_to_reject_after_deadline that will allow rejecting
review requests, even after the deadline is past. Also modified that
the secretary, or whoever manages the reviews is always allowed to
reject the review regardless of the deadline as he/she could change
the deadline anyways.

* Fixed but in view_reviews (wrong variable name), added more test
cases to the test_reviews.py for different reject cases.

* test: More thoroughly exercise assignment rejection

* chore: Renumber migration

* test: Unrelated user cannot reject assignments

---------

Co-authored-by: Jennifer Richards <jennifer@staff.ietf.org>
2023-09-14 11:48:28 -05:00
Lars Eggert d3d2f0d35f
fix: Enable js functionality on sortable tables (#6301)
Fixes #6263

Also fix the non-js "untrack_document" page while I'm here.
2023-09-13 15:31:01 -05:00
Jennifer Richards 69fd3a059e
fix: Validate string before calling int() (#6268) 2023-09-13 15:29:16 -05:00
Jennifer Richards 8bc4507def
feat: Give AD the action in ad-f-up doc state (#6272)
* refactor: Add helper class to compare tag changes

* feat: Give AD the action in ad-f-up state

* refactor: Remove unnecessary check

* refactor: Reorganize update_action_holders()

* refactor: Remove unnecessary guard

* test: Update test for new AD handling

* test: Update another test

* test: Test ad-f-up effect on action holders

---------

Co-authored-by: Robert Sparks <rjsparks@nostrum.com>
2023-09-12 09:44:33 -05:00