Commit graph

11809 commits

Author SHA1 Message Date
Robert Sparks 3bbd5149de
feat: Easy extraction of qualified volunteer list for nomcom chair (#5578)
* feat: Easy extraction of qualified volunteer list for nomcom chair

* fix: tune test setup to years where eligibility calculations can return nonempty

* chore: revert unintended change

* feat: default string when no affiliation is provided
2023-05-05 15:33:47 -05:00
Eliot Lear 8af8a91c20
fix: allow ISE to initiate conflict review (#5570)
* ISE may initiate conflict review

Add ISE to list of those roles who can initiate a conflict review.

* fix: improve conditional for conflict review action. Add tests.

* chore: fix comment typo

---------

Co-authored-by: Robert Sparks <rjsparks@nostrum.com>
2023-05-03 14:04:09 -05:00
Jennifer Richards 6986cae1bf
fix: Listen for show.bs.modal on document (#5565)
Avoids losing the listener when DOM is changed dynamically.
2023-05-02 13:50:38 -05:00
Jennifer Richards db2f7362c5
feat: Include support address in error message 2023-04-27 17:51:19 +00:00
Jennifer Richards b691cb4a9f
fix: Avoid 500 error creating account when User.person is None 2023-04-26 18:34:49 +00:00
Lars Eggert 732cecf0e9
fix: Re-enable interim series "add session" button (#5485)
Fixes #5478

Co-authored-by: Nicolas Giard <github@ngpixel.com>
2023-04-25 16:30:06 -05:00
Robert Sparks 5f36905515
fix: reorder new nomcom migration (#5534) 2023-04-25 11:59:41 -05:00
Jennifer Richards 09ff9c6ced
refactor: Tie Meetecho resources to Session pk (#5281)
* feat: Use session.id to specify session for api_set_session_video_url

* feat: Use session.id to specify session for api_upload_bluesheet

* refactor: Add audio/video stream and onsite tool URLs to Session model

* refactor: Get onsite tool/stream URLs for agenda from Session

* refactor: Use Session methods for onsite tool/stream a few more places

* refactor: Move hard-coded meetecho URLs into settings.py

* feat: Add has_onsite_flag to Session

* chore: Set has_onsite_tool for sessions that had meetecho UrlResources

* fix: Only show onsite tool URLs when Session.has_onsite_tool is True

* test: Update test_api_upload_bluesheet to test deprecated version

* fix: Fix test failure in api_upload_bluesheet view

* test: Add test of new api_upload_bluesheet view

* style: Apply Black style to test_api_upload_bluesheet

* fix: Fix test failures in api_upload_bluesheet()

* test: Update test_api_set_session_video_url to test deprecated version

* fix: Fix test failure in api_set_session_video_url view

* test: Add test of new api_set_session_video_url view

* style: Apply Black styling to new test

* fix: Fix test failures in api_set_session_video_url view

* test: Fix test_meeting_agenda; set has_onsite_tool in SessionFactory

* feat: Add has_onsite_tool to Session list in admin

* feat: Add has_onsite_tool flag to SessionDetailsForm

* feat: Add has_onsite_tool flag to sreq

* feat: Show has_onsite_tool flag on secr view for a submitted request

* feat: Only prompt for has_onsite_tool in sreq for non-wg type groups

* fix: Clean up styling of sreq view a bit

* chore: Renumber migrations
2023-04-23 18:15:01 -05:00
Rich Salz 8c98abb537
fix: Edit "You've been nominated" text (#4641) (#5357)
Mention that the schedule is posted to ietf-announce and give a link
to subscribe to that.  Use vague wording to handle all cases.

Also add reminder when to not uncheck the "send automatically" box.
2023-04-23 18:07:27 -05:00
Jennifer Richards 372891194e
feat: Move IESG agenda items from filesystem to DB (#5366)
* feat: Add TelechatAgendaContent model and related support

* feat: Add UI for managing TelechatAgendaContents

* refactor: Rename _view view to _manage

* feat: Add a view to dump the TelechatAgendaContent as text/plain

* refactor: Point agenda_data() helpers at content in the DB

* refactor: Replace references to settings URLs/paths with new plumbing

* chore: Remove now-obsolete settings from settings.py

* feat: Link to telechat_agenda_content_manage view from iesg agenda

* fix: Use correct view name

* feat: Link from agenda content management page to IESG agenda view

* chore: Create resources

* chore: Add new names to names.json

* chore: Renumber migration after rebase

* chore: Remove unused import

* fix: Clean up partially removed code

* chore: Add admin model for TelechatAgendaContent

* chore: Simplify __str__ method for TelechatAgendaContent

* test: Add TelechatAgendaContentFactory

* test: Test the fill_in_agenda_administrivia() function

* test: Test that agenda contains action_items content

* test: Test that sensitive agenda links are restricted by role

* test: Test the telechat_agenda_content_view view

* test: Add test of telechat_agenda_content_edit view

* fix: Add type attribute to button to satisfy html validator

* test: Filter TelechatAgendaSectionName to used=True for tests

* test: More thoroughly test for likely(ish) permission errors

* fix: Fix typo in "tablist" role

* test: Test telechat_agenda_content_manage view

* style: Put back newlines at EOF

* chore: Add admin for TelechatAgendaSectionName

* chore: Renumber migrations

* fix: Depend on the correct migration

Forgot to update the number, but was also depending on the wrong
migration.
2023-04-23 18:05:58 -05:00
Rich Salz 24277f6ff2
fix: Add "empty-list" indicator (#5504) (#5505) 2023-04-23 17:58:40 -05:00
Jennifer Richards c6fbdef6df
fix: Handle integrity violations when confirming email address (#5506)
* fix: Handle integrity violations when confirming email address

* test: Add tests of confirm_new_email view
2023-04-23 17:58:05 -05:00
Robert Sparks a2f1c1f705
chore: update version in primary init (#5495) 2023-04-14 17:43:46 -05:00
Martin Thomson d3f3e1e40a
fix: Remove useless directives for Updates/Obsoletes (#5484)
These only unnecessarily narrow the space available.
See RFC 8996 for an example of where that might matter.
2023-04-14 17:43:25 -05:00
Nicolas Giard 48beabe606
chore: add release 10.0 info in about.html (#5492) 2023-04-13 11:47:46 -05:00
Lars Eggert 0f1a774b79
fix: Unbreak HTMLized table of contents (#5486)
Fixes #5483
2023-04-12 17:34:30 -05:00
Jennifer Richards 716a77a848
fix: Do not try to match None keyword when redirecting to agenda view (#5489) 2023-04-12 17:34:00 -05:00
Robert Sparks 84c1fa195b
feat!: Use postgresql instead of mysqldb (#5482)
BREAKING CHANGE: The underlying database is now postgresql.
2023-04-10 12:47:43 -05:00
Robert Sparks f556d1f6da
Merge remote-tracking branch 'ietf-tools/main' into feat/postgres 2023-04-10 12:20:24 -05:00
Lars Eggert 34482cd100
fix: Long session titles were overlapping the materials buttons (#5454) 2023-04-10 08:58:22 -05:00
Robert Sparks 0f1a09f635
Merge remote-tracking branch 'ietf-tools/main' into feat/postgres 2023-03-31 10:52:45 +09:00
Lars Eggert 50e716e440
fix: Only presort tables if sort order is specified (#5408)
Thanks to @kivinen
2023-03-31 10:38:02 +09:00
Lars Eggert 8b815fc76d
feat: Add list of sub-groups to group's "about" page (#5450)
* feat: Add list of sub-groups to group's "about" page

Fixes #5441

* Address review comments
2023-03-31 10:29:07 +09:00
Jennifer Richards 7f5c3a3699
refactor: Remove length limit on Message header fields (#5455) 2023-03-31 09:37:46 +09:00
Tero Kivinen d5bae45799
fix: Do not add user to the top of queue after reject (fixes #4505) (#5427)
* fix: Do not add user to the top of queue after reject (fixes #4505)
Added a checkbox in the reject review dialog to ask whether user
wants to be added to the top of the queue or not. Default is off.

* Do not change request_assignment_next if wants_to_be_next is not True.
Set the request_assignment_next also in LeastRecentlyUsedReviewerQueuePolicy
so it can be used to override the assignment policy rules (i.e., if
someone has once per month, but he rejects review with wants_to_be_next set
to true, he will get new assignment immediately, not after one month).

* Added wants_to_be_next to test cases too.

* Fixed test function prototypes, they can't have any parameters, only
self. Added test cases for test_return_reviewer_to_rotation_top both
for RotateAlphabeticallyReviewerQueuePolicyTest and
LeastRecentlyUsedReviewerQueuePolicyTest.
2023-03-30 08:34:08 +09:00
Ryan Cross 1bd5c5e2f1
feat: Add requests summary (#5439)
* feat: Add summary data to meeting/requests

* feat: Add Group Type and Purpose tables to requests summary

* fix: use self.assertXX instead of raw assert

---------

Co-authored-by: Robert Sparks <rjsparks@nostrum.com>
2023-03-30 08:07:59 +09:00
Jim Fenton 0f1a6c960f
chore: Update test docs to postgresql; remove extraneous sqlite stuff (#5400)
* chore: Update test docs to postgresql; remove extraneous sqlite stuff

* Reverted addition of settings_postgrestest.py to .gitignore
2023-03-29 10:45:03 +09:00
Robert Sparks 01b4a91bfe
Merge remote-tracking branch 'ietf-tools/main' into feat/postgres 2023-03-29 10:41:47 +09:00
Jennifer Richards 72954c24fc
chore: Add type annotations to satisfy linter (#5435) 2023-03-29 09:06:14 +09:00
Jennifer Richards 6b826fd985
refactor: Purge old migrations and update ci to build on a clean schema (#5431)
* refactor: Remove all existing migrations

* refactor: Create clean set of migrations

* chore: Skip check_statetype_slugs when DB is not yet populated

* fix: Do not cache active_groups_menu on module import

* fix: Do not patch timezone awareness out of oidc-provider

* refactor: Migrate to create postgres schema, only use pgloader for data

* ci: Use migration scripts from feat/pg-migrations branch

* Revert "ci: Use migration scripts from feat/pg-migrations branch"

This reverts commit c82f64c614241ccede4865a50d494725c8a47c15.

* ci: Run check before migrate

* fix: Remove redundant migration caused by merge error

* chore: Add casts/ALTER TABLEs to eliminate pgloader errors/warnings

* chore: Change schema name to match docker image assumptions

* chore: Clear out schema so we get a clean start in case of a retry
2023-03-28 18:06:07 +09:00
Lars Eggert 53a90a38ce
fix: Don't disable mouse hover UI functionality on touch screens (#5433)
Because devices can have both touch and mouse input.
2023-03-28 12:16:04 +09:00
Kesara Rathnayake b0c76416cd
feat: Allow password reset with non username email address (#5419)
This change allows password reset with any email address associated with the
account.
The password reset will only be sent to the active email addresses associated
with the account.

Fixes #5057
2023-03-28 11:07:31 +09:00
Robert Sparks 52a1069901
fix: reapply styling fix for pdfization (#5428) 2023-03-27 15:08:43 +09:00
Ian Williams a778377bb8
fix(doc): Replace iconography for position's email status with text label (#5421)
* fix(doc): Use text badges for email status

BI's envelope icons with status icons are difficult to read.
Use text labels instead (keeping the same tooltip).

Fixes #3855.

* test(doc): Fix failing ballot message tests

Some ballot message changes have been modified to correctly identify
what type of document this ballot is for.

Works on #3855

* test(doc): Remove debugging statement

Accidental inclusion of debug statement.

Works on #3855
2023-03-27 13:58:51 +09:00
Lars Eggert 7c890ea69e
chore: Remove unused agenda-personalize.js (#5387)
Co-authored-by: Robert Sparks <rjsparks@nostrum.com>
2023-03-26 14:53:31 +09:00
Rich Salz e1283cec6d
fix: Make "nomcom paths" field CSV-friendly (#4892) (#5401)
When generating the NomCom volunteer paths, use a plus sign rather
than a comma, so that the output is more CSV-friendly.

Co-authored-by: Robert Sparks <rjsparks@nostrum.com>
2023-03-26 14:19:49 +09:00
Lars Eggert 99cd5a39f4
chore: Remove unused arrow-ani.webp (#5386) 2023-03-26 14:15:39 +09:00
Jennifer Richards bc9c74ef50
fix: Render complete iCalendar event when show_location is False (#5394)
* test: More carefully test event syntax in ical file

* test: Test agenda.ics view with all meeting sessions

* fix: Render complete iCalendar event when show_location is False

* chore: Fix confusing comment
2023-03-26 14:13:58 +09:00
Lars Eggert b11f0fc50f
fix: Lengthen IESG dashboard trend period to 120 days (#5409)
Fixes #4450
2023-03-25 17:38:57 +09:00
Lars Eggert c3bb142c98
Rebase (#5416) 2023-03-25 17:37:33 +09:00
Jim Fenton 2c9a7fcb1c
fix(ipr): Clarify IPR update confirmation email (#5420)
Fixes #4133
2023-03-25 17:30:51 +09:00
Jim Fenton d25eca930d
fix(doc): remove revision from shepherd writeup title (#5413)
Fixes #4200
2023-03-25 16:15:34 +09:00
Lars Eggert 0bc0469df2
chore: Remove unused jquery-ui (#5385)
* chore: Remove unused jquery-ui

Two templates under `secr` included it, but didn't seem to use it
for anything.

* Run `yarn` after removal
2023-03-25 15:57:44 +09:00
Lars Eggert 58b3155eda
chore: Remove unused week-view.js file (#5383) 2023-03-21 08:48:40 -05:00
Lars Eggert 5ed1d69f52
chore: Remove unused room-params.js (#5384) 2023-03-21 08:48:22 -05:00
Lars Eggert 3865d5232b
chore: Remove unused agenda_timezone.js (#5388) 2023-03-21 08:42:34 -05:00
Lars Eggert 81573a29c9
fix: Use more subtle colors for "Request full access URL" alert (#5390)
Fixes #1765
2023-03-21 08:41:51 -05:00
Robert Sparks 88a78cf1ab
Merge remote-tracking branch 'ietf-tools/main' into feat/postgres 2023-03-20 13:46:32 -05:00
Lars Eggert 8f8a3489ea
fix: Add reviewer name to review assignment summary (#5363)
* fix: Add reviewer name to review assignment summary

Fixes #5360

* Address code review

* Fix test harder
2023-03-20 10:23:45 -05:00
Lars Eggert 0097778239
chore: Remove empty file (#5374) 2023-03-20 10:11:50 -05:00