Commit graph

352 commits

Author SHA1 Message Date
Lars Eggert f8c06fa5cf
fix: Use unique data-sort attributes (#3836)
* fix: Use unique `data-sort` attributes

So list.js properly sorts columns.

* Address @rjsparks' comments
2022-04-19 10:16:32 -05:00
Jennifer Richards 310e828262
fix: offset scrollspy so righthand-nav highlights the correct entry (#3820)
Also rewrites scroll_to_element() using javascript. This seems to be less flaky
than the ActionChains implementation. Slight change in behavior - now scrolls
the requested element to the middle of the window instead of barely into view.
2022-04-14 15:35:07 -03:00
Robert Sparks 0944312c20
feat: remove room-view. Fixes #3810. (#3815)
Also changes .editorconfig to not strip trailing whitespace
2022-04-12 17:35:07 -03:00
Lars Eggert 09a898e88e
fix: Improve the layout of the photo pages (#3807) 2022-04-12 12:02:16 -03:00
Lars Eggert 3245678e10
fix: Hide tooltips after review wish icon is clicked (#3799)
Similar how it's done with the track/untrack icon.

Also remove duplicate javascript for this functionality.
2022-04-08 14:55:41 -03:00
Lars Eggert 19e639f779
fix: .visually-hidden -> .d-none (#3800)
In bs5, `.visually-hidden` is the equivalent of bs3's `.sr-only`, i.e., it's
still shown on screen readers, which is not what we want. Use `.d-none` instead,
which is the equivalent of bs3's `.hidden`.
2022-04-08 14:53:56 -03:00
Jennifer Richards 2247a368dc
fix: improve RH panel behavior at small viewport sizes (#3801)
* fix: align nav links to top of RH panel
* fix: allow timezone picker to wrap
* fix: improve RH panel behavior at small viewport sizes
  * drop card styling
  * use `btn-group-sm` for compact timezone picker
  * limit overall height of #righthand-panel
  * remove redundant CSS merge artifact
2022-04-08 14:52:55 -03:00
Jennifer Richards eab4705dc1
fix: debug time zone widget and add to agenda RH nav panel (#3792) 2022-04-07 22:57:21 -03:00
Jennifer Richards 45df4f6dfd
fix: restore current session indicator/link on the agenda page (#3790) 2022-04-07 15:13:43 -03:00
Lars Eggert 3234f1a121
test: Validate HTML rendered during tests (#3782) 2022-04-07 13:30:38 -03:00
Jennifer Richards db254f7a48
fix: tweak review assignment tooltips and control row height (#3788) 2022-04-07 09:48:23 -03:00
Jennifer Richards 7738319c2a
fix: render meeting schedule editor icons using bootstrap-icons (#3777)
Uses template tags to render `ConstraintName` instances as HTML. Fixes #3557.
2022-04-05 18:57:08 -03:00
Jennifer Richards 016ee71855
feat: persist timeslot types made visible in the schedule editor (#3778)
This adds a POST action to the edit_meeting_schedule view that sets a list
of currently visible timeslot types in the user's session. On display of
the schedule editor, this is consulted before defaulting to show only 'regular'
timeslots. An ajax request is made to update the session when changing the
settings in the editor.
2022-04-05 16:00:59 -03:00
Jennifer Richards 3865c4bc9c
fix: restore function of unassigned review management page (#3774)
* style: reformat manage-review-requests.js as StandardJS style

* refactor: use switch statement instead of if/else-if/else

* style: remove needless line break

* fix: fix jquery selectors to be less fragile and easier to read

* fix: clean up bs5 HTML/CSS for review request buttons
2022-04-01 17:42:12 -03:00
Robert Sparks ef4ad545b9
fix: left-align date columns in all tablesorter-classed tables. (#3772) 2022-03-30 18:45:39 -03:00
Lars Eggert 870fed030f
fix: More fixes for narrow screens (#3662)
* fix: More fixes for narrow screens

Need to keep checking for issues, there are more.

* Make columns more narrow on narrow screens

* More fixes

* More fixes

* Test fixes

* Fix more tests

* Close tbody
2022-03-24 12:40:48 -03:00
Lars Eggert d47692546e
fix: Re-add agenda day navigation targets to right-hand nav (#3723)
Fixes #3698
2022-03-22 07:22:25 -05:00
Lars Eggert eb5423d084
ci: Also check generated HTML with the "vnu" validator (#3682)
* ci: Also check generated HTML with the "vnu" validator

Because HTML Tidy apparently misses a bunch of errors.

* thead -> tbody

* More fixes

* More fixes

* Start checker in test runner
2022-03-21 12:50:23 -05:00
Lars Eggert 52969aefca
feat: Mobile agenda improvements (#3655)
* fix: Improve agenda page for mobile (narrow) screens

* Remove unrelated change

* Remove FIXME
2022-03-16 09:30:21 -05:00
Lars Eggert fd8d9762f2
fix: Use fixed lengths for the first three columns of "meta" tables (#3637)
Fixes #3615.
2022-03-14 11:32:28 -05:00
Jennifer Richards 93d3daa324 fix: handle remote_instructions field correctly on interim request form 2022-03-08 12:15:22 -04:00
Jennifer Richards 3d7b267a64 fix: only add page navigation panel to compatible templates
Only add right-hand page navigation panel to #content elements that have
the ietf-auto-nav class and test that the base template's DOM is compatible
with the panel.
2022-03-08 12:01:24 -04:00
Jennifer Richards 686a9150b3 Merge remote-tracking branch 'origin/main' into personal/jennifer/7.45.1.dev0.bootstrap-merge
# Conflicts:
#	ietf/templates/meeting/session_buttons_include.html
2022-03-04 15:14:52 -04:00
Jennifer Richards 5be277484c Reformat and clean up JS to eliminate warnings
- Legacy-Id: 19989
2022-02-24 20:17:12 +00:00
Jennifer Richards 077e7e2262 Merged from 7.40.1.dev0
Properly URL-encode and -decode a bunch of query parameters. [from revision 19,981]
 - Legacy-Id: 19986
2022-02-24 17:52:28 +00:00
Jennifer Richards 1d301f73f9 Merged in [19980] from personal/lars/7.40.1.dev0
Fix # 3555.
 - Legacy-Id: 19985
Note: SVN reference [19980] has been migrated to Git commit 686f835d4e
2022-02-24 17:40:24 +00:00
Jennifer Richards c5f86b3834 Merged in [19979] from 7.40.1.dev0
Make the js a bit less noisy and adjust the tests accordingly.
 - Legacy-Id: 19984
Note: SVN reference [19979] has been migrated to Git commit f61ddb4b60
2022-02-24 17:26:46 +00:00
Jennifer Richards 2610c7c736 Merged in [19978] from personal/lars/7.40.1.dev0
Hopefully fix #3556.
 - Legacy-Id: 19983
Note: SVN reference [19978] has been migrated to Git commit ca167c0172
2022-02-24 16:55:16 +00:00
Lars Eggert 07e0eb84d9 Properly URL-encode and -decode a bunch of query parameters.
- Legacy-Id: 19981
2022-02-24 14:23:46 +00:00
Lars Eggert 686f835d4e Fix # 3555.
- Legacy-Id: 19980
2022-02-24 10:25:54 +00:00
Lars Eggert f61ddb4b60 Make the js a bit less noisy and adjust the tests accordingly.
- Legacy-Id: 19979
2022-02-24 09:34:17 +00:00
Lars Eggert ca167c0172 Hopefully fix #3556.
- Legacy-Id: 19978
2022-02-24 09:11:32 +00:00
Jennifer Richards f0d40680fe Refactor session overlap computation to treat overlapping sessions correctly. Commit ready for merge.
- Legacy-Id: 19954
2022-02-21 21:20:30 +00:00
Jennifer Richards 6c260a5b7e Merge 7.45.1.dev0 into Bootstrap 5 update branch. Made a first pass at reconciling differences.
- Legacy-Id: 19945
2022-02-17 20:09:49 +00:00
Robert Sparks f8c7be6df9 Merged in [19917] and [19930] from jennifer@painless-security.com:
Create/delete Meetecho conferences when requesting/canceling interim sessions. Fixes #3507. Fixes #3508.
 - Legacy-Id: 19934
Note: SVN reference [19917] has been migrated to Git commit 81cd64da2bc0122f733df02f7db634665c9b309a

Note: SVN reference [19930] has been migrated to Git commit c64297e495010f3c147726ad61c24ca436c324da
2022-02-14 19:08:10 +00:00
Lars Eggert 37cb737987 Check the selenium console log for any issues as part of the test suite,
and fix/suppress errors found by that.
 - Legacy-Id: 19916
2022-02-10 21:20:20 +00:00
Lars Eggert bbf088e18b Hopefully the final check-ins.
- Legacy-Id: 19909
2022-02-08 17:29:15 +00:00
Lars Eggert ed30521e14 Many more HTML fixes.
- Legacy-Id: 19908
2022-02-03 07:49:34 +00:00
Lars Eggert 64d2ba2558 Run tidy as part of tests, and fix HTML issues it finds.
- Legacy-Id: 19904
2022-02-01 16:11:34 +00:00
Robert Sparks 75634e6ba6 Merged in [19900] from jennifer@painless-security.com:
Fix hiding of name/purpose/type fields when not needed in secr/sreq. Fixes #3531.
 - Legacy-Id: 19901
Note: SVN reference [19900] has been migrated to Git commit 5f9868e8478a0d455b8f5c0b1fb5f8cd442cf718
2022-01-31 21:42:31 +00:00
Lars Eggert cc723ce449 More fixes.
- Legacy-Id: 19899
2022-01-31 19:17:50 +00:00
Lars Eggert 335a39d4fc More fixes.
- Legacy-Id: 19884
2022-01-28 13:00:47 +00:00
Jennifer Richards 795d861d96 Hide timeslots type is disabled plus other schedule editor debugging/improvements. Fixes #3510. Fixes #3430. Commit ready for merge.
- Legacy-Id: 19878
2022-01-27 00:41:27 +00:00
Lars Eggert cf629a42ad And more fixes.
- Legacy-Id: 19877
2022-01-25 10:14:25 +00:00
Lars Eggert 9c05373699 More fixes.
- Legacy-Id: 19856
2022-01-18 20:04:55 +00:00
Lars Eggert 0bfaa63722 More fixes.
- Legacy-Id: 19855
2022-01-17 15:05:22 +00:00
Lars Eggert edf3242665 More fixes.
- Legacy-Id: 19836
2022-01-12 18:37:18 +00:00
Lars Eggert a5cbf5307e More fixes
- Legacy-Id: 19835
2022-01-12 11:54:00 +00:00
Lars Eggert 6ca6c35186 More fixes.
- Legacy-Id: 19829
2022-01-11 15:02:27 +00:00
Lars Eggert 8bc7fde027 More fixes.
- Legacy-Id: 19828
2022-01-11 07:02:39 +00:00