Commit graph

71 commits

Author SHA1 Message Date
Henrik Levkowetz f46f893de9 Don't try to output draft metadata (in standalone mode) for a file if the extraction failed.
- Legacy-Id: 3505
2011-10-25 13:58:55 +00:00
Henrik Levkowetz 43f1d5da93 Improved extraction of draft title during submission. Fixed a problem where the scan for an author's email address was prematurely terminated because another author's affiliation also was part of this author's address information.
- Legacy-Id: 3445
2011-10-13 14:36:26 +00:00
Henrik Levkowetz 7f8eea3b9d * Speeded up things and increased reliability by looking for a
recognizable author's address section, and not searching for
    author names earlier in the document if found.  Fixes a known
    bad case where the author name occurred in the middle of a draft.

  * Added handling for the case where an author name is followed by 
    parentheses which are not closed on the same line.

  * Some refactoring.
 - Legacy-Id: 3417
2011-09-14 12:31:48 +00:00
Henrik Levkowetz 804e7cb795 Add some debug output utility functions.
- Legacy-Id: 3262
2011-07-27 16:33:50 +00:00
Henrik Levkowetz 494b3c77fd Fix a problem with author extraction when a given name is the same as the surname.
- Legacy-Id: 3135
2011-05-23 21:42:34 +00:00
Henrik Levkowetz e904041ea9 Don't try to do string join on None, in case any address in an address list given to the mail sending routines is missing and represented by None.
- Legacy-Id: 3111
2011-05-10 12:13:40 +00:00
Henrik Levkowetz 101fe5f3dd When extracting meta-information from drafts, it is required that some data reside on the first page. Split unpaginated drafts into chunks so we can adhere better to this.
- Legacy-Id: 3083
2011-05-03 14:10:43 +00:00
Henrik Levkowetz 0ccff982bb Merged [2948] from bmheight@gmail.com:
Addresses issue #628, using reverse() and the newly created helper function 
reverse_lazy()  (found in ietf/utils/lazy.py) to DRY out the code a bit by 
decoupling the urls from being hardcoded.

With this commit idrfc, and ipr modules have been modified to take advantage 
of the reverse() and reverse_lazy() functions.
 - Legacy-Id: 2956
Note: SVN reference [2948] has been migrated to Git commit 9399a2e0e8bbfe5c5a16781fd784776cfa31fbac
2011-03-26 14:36:10 +00:00
Henrik Levkowetz fa16a7b0c1 Change ietf/utils/draft.py to provide an alternative method to get author
information: draft.get_author_info().  This method returns a list of
(full_name, first_name, middle_part, surname, suffix, email), with
middle_part, suffix and email set to None if none was found.
 - Legacy-Id: 2921
2011-03-24 13:25:14 +00:00
Henrik Levkowetz 79a283c3f6 Add the fix for email addresses from [2892].
- Legacy-Id: 2920
Note: SVN reference [2892] has been migrated to Git commit db905d3903
2011-03-24 13:09:01 +00:00
Henrik Levkowetz 0b8bcfa81d Fix a series of issues found during testing. This is the patch provide
to Yaco on 2011-03-19, and committed on branch/yaco/idsubmit as [2896].

   * Extraction of Title which don't have the draft name on a separate
     page fails.  See for instance this example:
     http://www.ietf.org/staging/draft-ma-cdni-publisher-use-cases-00.txt
     The regex should maybe be updated to permit but not require a newline
     before the draft filename:
     '(?:\n\s*\n\s*)((.+\n){1,2}(.+\n?))(\s+<?draft-\S+\s*\n)\s*\n'

   * If there are blank lines before the start of the author list on the
     first page, the author extraction will fail.  This sometimes happens
     when there's junk at the start of a draft, see for instance
     http://www.ietf.org/id/draft-ietf-mpls-tp-process-00.txt .

   * Sometimes the Authors' Addresses section lists authors with the same
     workplace address on the same line: "Sam Spade and Joe Smith".  This
     needs a fix in the author extraction code.

   * Sometimes the order of first name, surname is different on the first
     page and in the author list, and sometimes the surname is uppercase
     in one place, but not in the other.  This also needs a fix in the
     author extraction code.

   * The header stripping code had a bug, where multiple blank lines could
     be replaced by a single blank line in the stripped text, which could
     mess up title extraction.

   * Title space normalization should be done also for titles from the
     'unusual title format' code branch of the title extraction code.

   * Company names on the first page are sometimes rendered with different
     case than in the Authors' Addresses section.

   * Some drafts list the draft filename _before_ the title, rather than
     after the title.  Permit this too. Covered in the patch.

   * Spanish names can be shown as either
	<given_name> <fathers_first_surname> <mothers_first_surname>
     or less formally as
	<given_name> <fathers_first_surname>
     If the first form is used in the Authors' Addresses section, but the
     second form (with the given name possibly abbreviated to its first
     letter) the author extraction will fail.

   * Drafts containing tabs will be caught by idnits during I-D submission,
     but in case the drafts.py module is used independently from idnits,
     convert tabs to spaces in order for the author extraction and other
     methods to work as expected.  Example: recently submitted draft
     draft-bergeron-payload-rtpfec-rs-00.txt.

   * Found a draft with a previously unhandled header/footer format:
     draft-fang-mpls-tp-oam-toolset-01.txt.  Tweak needed for header/footer
      stripping.
 - Legacy-Id: 2919
Note: SVN reference [2896] has been migrated to Git commit 5a34b70e52
2011-03-24 13:05:48 +00:00
Henrik Levkowetz 61300a9354 Fix title extraction. Patch provided to yaco 2011-03-14, committed to yaco/idsubmit branch as [2887].
- Legacy-Id: 2918
Note: SVN reference [2887] has been migrated to Git commit fb7219c6ce
2011-03-24 12:58:33 +00:00
Henrik Levkowetz 9ae7b90b59 Merged in changes from Yaco @2880.
- Legacy-Id: 2917
2011-03-24 12:54:31 +00:00
Henrik Levkowetz 265b94c4ca Bugfix for faulty header/footer stripping, sent to Yaco 2011-03-02.
- Legacy-Id: 2916
2011-03-24 12:53:19 +00:00
Henrik Levkowetz 5ab9f020ec Merged in changes from Yaco @2855.
- Legacy-Id: 2915
2011-03-24 12:51:34 +00:00
Henrik Levkowetz 2f1426ed18 Copy ietf/utils/draft.py from the old idsubmit branch.
- Legacy-Id: 2914
2011-03-24 12:38:27 +00:00
Henrik Levkowetz 7e6134496b Remove the To/From/Subject headers from extra headers to prevent duplicate headers.
- Legacy-Id: 2812
2011-02-04 12:13:46 +00:00
Henrik Levkowetz 985dd2138f Provide a utility function admin_link() for use in admin list pages.
- Legacy-Id: 2795
2011-02-02 15:21:32 +00:00
Henrik Levkowetz ef26a18076 Don't try to send out mail which has no recipients.
- Legacy-Id: 2779
2011-02-01 10:24:54 +00:00
Henrik Levkowetz 9720c03038 Propagate all extra fields on to the final email sending function, not only the Cc and Bcc fields.
- Legacy-Id: 2765
2011-01-27 15:06:53 +00:00
Henrik Levkowetz e8de267a1d Merged [2644] from fenner@fenron.net:
Fill in the X-IETF-IDTracker header with the
I-D Tracker version number.  This fixes #513
 - Legacy-Id: 2647
Note: SVN reference [2644] has been migrated to Git commit 77a401f7eb3f06427d3cfae81ec71e4277d828cc
2010-11-08 09:11:37 +00:00
Henrik Levkowetz 5833428881 Merged [2639] from fenner@fenron.net:
Add regression tests (and accompanying test mode) for utils.mail.
Fixes #538
 - Legacy-Id: 2645
Note: SVN reference [2639] has been migrated to Git commit 14de6870df426f18afaf90af2c74a5009cca3c1f
2010-11-08 08:47:36 +00:00
Henrik Levkowetz 6d6d3aac51 Merged [2604] from rjsparks@nostrum.com: Added filename to the subject of Protocol Action and Document Action email messages.
Fixed a bug that was preventing CC/BCC from being honored. Fixes issue #528.
 - Legacy-Id: 2623
Note: SVN reference [2604] has been migrated to Git commit 4d27ae4d7a535fb7c9cb44dd0d486a0f5850b1b1
2010-11-06 08:44:42 +00:00
Henrik Levkowetz b652330f2a Utility function to execute external functions.
- Legacy-Id: 2606
2010-11-06 05:24:02 +00:00
Henrik Levkowetz eafcdccd3d Merged from log:branch/iesg-tracker@2571: IOLA's port of cron-scripts.
- Legacy-Id: 2578
2010-10-26 14:49:12 +00:00
Henrik Levkowetz 266b7820d0 Merged from log:branch/2.00@2363: Current release branch head to trunk.
- Legacy-Id: 2365
2010-07-21 12:48:05 +00:00
Henrik Levkowetz fa77ac30d5 Merged r840 from branch/2.00 to trunk, and updated version information in ietf/__init__.py
- Legacy-Id: 841
2007-07-04 21:17:57 +00:00
Henrik Levkowetz cd030d3b43 Adding copyright notices to all python files
- Legacy-Id: 716
2007-06-27 21:16:34 +00:00
Henrik Levkowetz 1a43ca5ebd Show number of review pages on overview page.
- Legacy-Id: 645
2007-06-25 23:20:56 +00:00
Henrik Levkowetz 410a69b914 Removing unused import from ietf/utils/views.py
- Legacy-Id: 620
2007-06-22 23:21:05 +00:00
Henrik Levkowetz 71429f59aa Alternative review pages which shouldn't shift when new test-URLs are added. Old review URLs still work, but withouth guarantee against shifting when new test-URLs are added.
- Legacy-Id: 600
2007-06-21 20:07:24 +00:00
Henrik Levkowetz 96b1f822ab Added an overview page for the review pages
- Legacy-Id: 529
2007-06-19 14:54:19 +00:00
Henrik Levkowetz 53f3be5ca0 It's better to test for retrieval of review pages than to just skip them.
- Legacy-Id: 527
2007-06-19 08:25:15 +00:00
Henrik Levkowetz bcc361359d Test urls for /review/
- Legacy-Id: 503
2007-06-18 19:30:58 +00:00
Henrik Levkowetz c03019afbe Adding a page review facility under the URL /review/. This is based on frames and takes the URLs in question from the testurl.list files.
- Legacy-Id: 487
2007-06-18 14:34:00 +00:00
Henrik Levkowetz de9a7ddbc4 Added the ability to give fill and pre(formatted) switches to the soup2text command
- Legacy-Id: 403
2007-06-15 13:28:12 +00:00
Henrik Levkowetz 754ba193ca A small script to run a diff against the master for one single django URL specified in any of the testurl.list files. Uses environment variable DJANGO_SERVER if set, or http://merlot.tools.ietf.org:31415/ otherwise.
- Legacy-Id: 375
2007-06-13 17:26:04 +00:00
Henrik Levkowetz e2db0d869d Compact spaces after \n conversion in soup2html.
- Legacy-Id: 351
2007-06-12 22:46:30 +00:00
Henrik Levkowetz aa68d30e85 Tweaking the paragraph filling code some more
- Legacy-Id: 346
2007-06-12 20:31:28 +00:00
Henrik Levkowetz 712cd8aa17 Tweak to again avoid space at the beginning of a paragraph.
- Legacy-Id: 345
2007-06-12 20:23:09 +00:00
Henrik Levkowetz 890b8a1ada Fix potential exception in soup2html again.
- Legacy-Id: 341
2007-06-12 18:34:26 +00:00
Henrik Levkowetz 6b7137994a Fix potential exception in soup2html.
- Legacy-Id: 340
2007-06-12 18:12:19 +00:00
Henrik Levkowetz dd37257c0c Only print the first 100 lines of a long diff. New soup2html code for spacing associated with certain tags.
- Legacy-Id: 337
2007-06-12 17:52:07 +00:00
Henrik Levkowetz aba06af322 Another soup2html() tweak to better avoid indentation at paragraph start.
- Legacy-Id: 330
2007-06-12 01:32:05 +00:00
Henrik Levkowetz 541b041cdc soup2html() tweak to better avoid indentation at paragraph start.
- Legacy-Id: 329
2007-06-12 00:55:41 +00:00
Henrik Levkowetz 67eb998901 soup2html() tweak to handle html comments.
- Legacy-Id: 328
2007-06-12 00:37:16 +00:00
Henrik Levkowetz b15c02c830 soup2html() tweak to handle table cells.
- Legacy-Id: 326
2007-06-12 00:25:45 +00:00
Henrik Levkowetz bfcb0e6c78 Two soup2text tweaks.
- Legacy-Id: 324
2007-06-11 23:52:51 +00:00
Henrik Levkowetz 1cafcf3e9d Changed approach to space normalization in soup2text(). Plain whitespace stripping followed by reassembly caused too large information loss. Accompanying changes in generic diff files.
- Legacy-Id: 321
2007-06-11 20:28:19 +00:00
Henrik Levkowetz 8e8c3ff5e2 * ietf/tests.py: Remove filetime() again -- not using it.
* ietf/utils/soup2text.py: Do line ending normalization.
 - Legacy-Id: 315
2007-06-11 17:26:59 +00:00