Commit graph

3617 commits

Author SHA1 Message Date
Lars Eggert f39e70a0a0
fix: Don't add newlines at EOF, it cause visible whitespace for HTML includes (#3989) 2022-05-19 08:21:12 -05:00
Lars Eggert de6d8b2b2a
fix: Prevent righthand-nav from overlapping the footer on short screens (#3980)
Co-authored-by: Robert Sparks <rjsparks@nostrum.com>
2022-05-18 13:19:23 -05:00
Lars Eggert de7ff7e84e
test: fix more validation issues (#3975)
* fix: Avoid numeric IDs on NomCom pages

* fix: Correctly group last names with lowercase/i18n parts

* Remove some unneeded CSS

* fix: Remove extra div closing tag
2022-05-18 10:58:39 -05:00
Jennifer Richards 4a5583845e
fix(ui): import moment.js library with moment-timezone support in wrapper (#3977)
* fix: import moment.js library with moment-timezone support in wrapper

Packaging changes broke the mechanism used to make moment.tz available
to javascript code. This eliminates the separate moment.js and
moment-timezone-with-data-10-year-range.js wrappers and instead
imports the timezone-augmented version directly. This provides both
the timezone support and the regular moment features.

* refactor: put moment on window instead of global for consistency
2022-05-18 09:23:07 -05:00
Lars Eggert f4ce041dcc
fix: Add whitespace before "for" (#3951) 2022-05-13 14:13:14 -05:00
Lars Eggert 75a32d2210
fix: Link to reviews from search status column (#3955)
* fix: Link to reviews from search status column

Fixes #3953

* fix: Make the notices about exceeded state times less obtrusive

* Fix tests
2022-05-13 14:05:42 -05:00
Lars Eggert 39525a1cd0
fix: escape the ballot comments (#3952)
I wonder if other fields that have class `pasted` would need to be escaped, too?
2022-05-12 12:17:48 -05:00
Lars Eggert 5f8d4ed718
More HTML nitfixing (#3934)
* Unicode messages are triggered by both db content and tests

* Make ids unique

* Avoid "No value found" message on page

* Strip HTML from history entries, it's often broken

* Check HTML sources for occurrences of "** No value found for" and fix them

* Fix another occurrence of "** No value found for"

* Fix more occurrences of "** No value found for"

* Fix document revision stripping

* Force breaks of long (garbage) words

* Check URL validity before urlizing them

* Handle some additional corner cases

* Linkify action items

* Don't create profile/email links for System

* Handle headings with HTML elements in them better

* Fix comment

* Fix another occurrence of "** No value found for"

* Better I-D URLization that handles more edge cases. Also, test for them.

* Remove print

* Handle charters better

* Cache for one day
2022-05-10 12:37:14 -05:00
Lars Eggert 5598762608
fix: add more HTML validation & fixes (#3891)
* Update vnu.jar

* Fix py2 -> py3 issue

* Run pyupgrade

* test: Add default-jdk to images

* test: Add option to also validate HTML with vnu.jar

Since it's already installed in bin. Don't do this by default, since it
increases the time needed for tests by ~50%.

* fix: Stop the urlizer from urlizing in linkified mailto: text

* More HTML fixes

* More HTML validation fixes

* And more HTML fixes

* Fix floating badge

* Ignore unicode errors

* Only URLize docs that are existing

* Final fixes

* Don't URLize everything during test-crawl

* Feed HTML into vnu using python rather than Java to speed things up

* Allow test-crawl to start vnu on a different port

* Increase retry count to vnu. Restore batch size to 30.

* More HTML validation fixes

* Use urllib3 to make requests to vnu, since overriding requests_mock is tricky

* Undo commit of unmodified file

* Also urlize ftp links

* Fix matching of file name

* More HTML fixes

* Add `is_valid_url` filter

* weekday -> data-weekday

* urlencode URLs

* Add and use vnu_fmt_message. Bump vnu max buffer.

* Simplify doc_exists

* Don't add tab link to mail archive if the URL is invalid

* Run urlize_ietf_docs before linkify

Reduces the possibility of generating incorrect HTML

* Undo superfluous change

* Runner fixes

* Consolidate vnu message filtering into vnu_filter_message

* Correctly handle multiple persons with same name

* Minimze diff

* Fix HTML nits

* Print source snippet in vnu_fmt_message

* Only escape if there is something to escape

* Fix snippet

* Skip crufty old IPR declarations

* Only include modal when needed. Add handles.

* Fix wordwrap+linkification

* Update ietf/doc/templatetags/ietf_filters.py

* Update ietf/doc/templatetags/tests_ietf_filters.py

* Don't right-align second column
2022-05-03 13:55:48 -05:00
Lars Eggert 19796c56c9
fix: Stretch righthand-nav to viewport edge (#3921)
* fix: Stretch righthand-nav to viewport edge

Fixes #3848

* Also improve tz-select display, while we're here

* Change func name
2022-05-03 09:35:10 -05:00
Lars Eggert f4b8fc1d0d
fix: 2023 -> 2023 in document shepherd template (#3923) 2022-05-03 09:30:17 -05:00
Robert Sparks 8fc8e9af4f
fix: guard against reviews without reviewassignments. Fixes #3906. (#3915) 2022-04-29 18:43:35 -05:00
Robert Sparks d7362609b8
fix: re-align html and view for submit-to-iesg. Fixes #3913 (#3914) 2022-04-29 14:55:21 -05:00
Lars Eggert 53a2b61bbc
feat: Make the "report a bug" links more visible (#3883)
* feat: Make the "report a bug" links more visible

Also rework the page footer somewhat, while we're here.

* Revert empty change

Co-authored-by: Nicolas Giard <github@ngpixel.com>
2022-04-26 12:30:21 -05:00
Lars Eggert 955d9ac489
fix: Spacing issues and colorization in conflict review display (#3882)
Co-authored-by: Nicolas Giard <github@ngpixel.com>
2022-04-26 12:24:33 -05:00
Lars Eggert cd9a2ee229
fix: Color the background of table rows for an AD based on their ballot (#3867)
Instead of just adding a colored bar on the right-hand side.
2022-04-22 11:05:37 -05:00
Robert Sparks f4b0b459cb
feat: add analytics infrastructure (#3862) 2022-04-21 18:06:14 -05:00
Lars Eggert ec13e071ba
fix: Whitespace issue ballot popup (#3860) 2022-04-21 11:55:48 -05:00
Lars Eggert 92e67aca8f
fix: Make the author button work on doc submit (#3850) 2022-04-20 10:52:54 -05:00
Lars Eggert cef7b05981
fix: Don't change text color on hover for badge links (#3845) 2022-04-20 10:50:24 -05:00
Kesara Rathnayake 6b06542fab
fix: fix OIDC authorization bug (#3842) 2022-04-20 10:47:47 -05:00
Lars Eggert f8c06fa5cf
fix: Use unique data-sort attributes (#3836)
* fix: Use unique `data-sort` attributes

So list.js properly sorts columns.

* Address @rjsparks' comments
2022-04-19 10:16:32 -05:00
Lars Eggert ea22b0fd3b
fix: Update the document shepherd template (#3797)
* fix: Update the document shepherd template

Along the lines of https://github.com/ietf-chairs/chairs.ietf.org/pull/5

* Rewrap manually

* Use relative Markdown links to improve readability
2022-04-19 09:32:39 -05:00
Jennifer Richards 43952a8c69
fix: do not prematurely dereference status change RelatedDocuments (#3835)
* test: add tests of the person_link tag

* fix: do not prematurely dereference status change RelatedDocuments

The urlize_related_source_list template tag expects the RelatedDocument
instances, not the source Document.

* test: add test cases for status changes on document_main view
2022-04-19 07:04:38 -05:00
Nicolas Giard 23fdf61ed4
fix: point to github releases in about page (#3827) 2022-04-14 16:21:51 -05:00
Robert Sparks 7c4205d49b
feat: reflect breaking change in internal release description (#3826)
BREAKING CHANGE: the datatracker now uses bootstrap 5 and html 5
see also 6eeae80207
2022-04-14 15:04:09 -05:00
Lars Eggert 81fe7a15cf
fix: add flex-wrap to pagination elements (#3822)
They seem to be one of the only bs5 elements that do not by default wrap, which
causes display issues on narrow screens when there are lots of page elements,
e.g., on http://127.0.0.1:8000/doc/draft-ietf-ipwave-vehicular-networking/

Adding `flex-wrap` (per https://github.com/twbs/bootstrap/issues/23504) makes
this better, but unfortunately doesn't fix it completely, because the layout
still jumps when the window is narrowed by the used. It does fix the issue on
first load and after a reload though.
2022-04-14 15:36:24 -03:00
Jennifer Richards a29965f37d
fix: remove potentially duplicate html entity id (#3818) 2022-04-13 11:42:14 -03:00
Robert Sparks 0944312c20
feat: remove room-view. Fixes #3810. (#3815)
Also changes .editorconfig to not strip trailing whitespace
2022-04-12 17:35:07 -03:00
Lars Eggert d2edc5bda3
fix: Misc template fixes (#3813)
* fix: Remove extra whitespace around parentheses

* fix: Make heading capitalization consistent, colorize a "No"

* fix: Pagination element, spacing, replace text with icon
2022-04-12 12:07:22 -03:00
Lars Eggert 4f1dcd6f41
fix: Don't make a <tbody> for each row (#3808)
Fixes #3805.
2022-04-12 12:04:57 -03:00
Jennifer Richards c14a30392c
fix: clean up agenda personalization links (#3803) 2022-04-12 12:03:13 -03:00
Lars Eggert 09a898e88e
fix: Improve the layout of the photo pages (#3807) 2022-04-12 12:02:16 -03:00
Robert Sparks 0b1388c39f
fix: report seven character prefix of release hash (#3804) 2022-04-11 15:57:25 -03:00
Lars Eggert 19e639f779
fix: .visually-hidden -> .d-none (#3800)
In bs5, `.visually-hidden` is the equivalent of bs3's `.sr-only`, i.e., it's
still shown on screen readers, which is not what we want. Use `.d-none` instead,
which is the equivalent of bs3's `.hidden`.
2022-04-08 14:53:56 -03:00
Jennifer Richards 2247a368dc
fix: improve RH panel behavior at small viewport sizes (#3801)
* fix: align nav links to top of RH panel
* fix: allow timezone picker to wrap
* fix: improve RH panel behavior at small viewport sizes
  * drop card styling
  * use `btn-group-sm` for compact timezone picker
  * limit overall height of #righthand-panel
  * remove redundant CSS merge artifact
2022-04-08 14:52:55 -03:00
Jennifer Richards eab4705dc1
fix: debug time zone widget and add to agenda RH nav panel (#3792) 2022-04-07 22:57:21 -03:00
Eric Vyncke fd588d61b4
fix: add more explanations in BoF requests (#3706)
* Add more explanations in BoF requests

* Move IAB/IESG information to the template

Co-authored-by: Robert Sparks <rjsparks@nostrum.com>
2022-04-07 17:34:53 -05:00
Jennifer Richards 45df4f6dfd
fix: restore current session indicator/link on the agenda page (#3790) 2022-04-07 15:13:43 -03:00
Lars Eggert 3234f1a121
test: Validate HTML rendered during tests (#3782) 2022-04-07 13:30:38 -03:00
Jennifer Richards db254f7a48
fix: tweak review assignment tooltips and control row height (#3788) 2022-04-07 09:48:23 -03:00
Robert Sparks 6867b1b667
fix: put unassigned review assignment contols on one small line (#3780) 2022-04-06 14:05:37 -03:00
Jennifer Richards 7738319c2a
fix: render meeting schedule editor icons using bootstrap-icons (#3777)
Uses template tags to render `ConstraintName` instances as HTML. Fixes #3557.
2022-04-05 18:57:08 -03:00
Jennifer Richards 016ee71855
feat: persist timeslot types made visible in the schedule editor (#3778)
This adds a POST action to the edit_meeting_schedule view that sets a list
of currently visible timeslot types in the user's session. On display of
the schedule editor, this is consulted before defaulting to show only 'regular'
timeslots. An ajax request is made to update the session when changing the
settings in the editor.
2022-04-05 16:00:59 -03:00
Jennifer Richards 3865c4bc9c
fix: restore function of unassigned review management page (#3774)
* style: reformat manage-review-requests.js as StandardJS style

* refactor: use switch statement instead of if/else-if/else

* style: remove needless line break

* fix: fix jquery selectors to be less fragile and easier to read

* fix: clean up bs5 HTML/CSS for review request buttons
2022-04-01 17:42:12 -03:00
Jennifer Richards 2859c43677
fix: allow import of rev00 minutes and let secretariat edit materials (#3776)
* fix: show "Edit materials" button for all groups for a secretariat user

Fixes ietf-tools#3763

* fix: show "import minutes" button to import initial revision

* test: validate that import session minutes buttons are shown

* test: validate that "Edit materials" links are shown
2022-04-01 12:49:20 -03:00
Robert Sparks cb4a288ab6
fix: separate tables on team review page. Fixes #3679. (#3770) 2022-03-30 18:42:29 -03:00
Robert Sparks 1d8746cd63
fix: add tooltips to calendar icons on group meeting pages. Fixes #3695. (#3767) 2022-03-30 18:37:29 -03:00
Robert Sparks 2e373adcd2
feat: improve release information in footer. (#3738) 2022-03-30 11:53:07 -03:00
Kesara Rathnayake 65439960fe
fix: Use an input field for draft submit status search (#3758) 2022-03-29 12:35:46 -05:00