Commit graph

1739 commits

Author SHA1 Message Date
Lars Eggert 75a32d2210
fix: Link to reviews from search status column (#3955)
* fix: Link to reviews from search status column

Fixes #3953

* fix: Make the notices about exceeded state times less obtrusive

* Fix tests
2022-05-13 14:05:42 -05:00
Lars Eggert 5f8d4ed718
More HTML nitfixing (#3934)
* Unicode messages are triggered by both db content and tests

* Make ids unique

* Avoid "No value found" message on page

* Strip HTML from history entries, it's often broken

* Check HTML sources for occurrences of "** No value found for" and fix them

* Fix another occurrence of "** No value found for"

* Fix more occurrences of "** No value found for"

* Fix document revision stripping

* Force breaks of long (garbage) words

* Check URL validity before urlizing them

* Handle some additional corner cases

* Linkify action items

* Don't create profile/email links for System

* Handle headings with HTML elements in them better

* Fix comment

* Fix another occurrence of "** No value found for"

* Better I-D URLization that handles more edge cases. Also, test for them.

* Remove print

* Handle charters better

* Cache for one day
2022-05-10 12:37:14 -05:00
Lars Eggert 5598762608
fix: add more HTML validation & fixes (#3891)
* Update vnu.jar

* Fix py2 -> py3 issue

* Run pyupgrade

* test: Add default-jdk to images

* test: Add option to also validate HTML with vnu.jar

Since it's already installed in bin. Don't do this by default, since it
increases the time needed for tests by ~50%.

* fix: Stop the urlizer from urlizing in linkified mailto: text

* More HTML fixes

* More HTML validation fixes

* And more HTML fixes

* Fix floating badge

* Ignore unicode errors

* Only URLize docs that are existing

* Final fixes

* Don't URLize everything during test-crawl

* Feed HTML into vnu using python rather than Java to speed things up

* Allow test-crawl to start vnu on a different port

* Increase retry count to vnu. Restore batch size to 30.

* More HTML validation fixes

* Use urllib3 to make requests to vnu, since overriding requests_mock is tricky

* Undo commit of unmodified file

* Also urlize ftp links

* Fix matching of file name

* More HTML fixes

* Add `is_valid_url` filter

* weekday -> data-weekday

* urlencode URLs

* Add and use vnu_fmt_message. Bump vnu max buffer.

* Simplify doc_exists

* Don't add tab link to mail archive if the URL is invalid

* Run urlize_ietf_docs before linkify

Reduces the possibility of generating incorrect HTML

* Undo superfluous change

* Runner fixes

* Consolidate vnu message filtering into vnu_filter_message

* Correctly handle multiple persons with same name

* Minimze diff

* Fix HTML nits

* Print source snippet in vnu_fmt_message

* Only escape if there is something to escape

* Fix snippet

* Skip crufty old IPR declarations

* Only include modal when needed. Add handles.

* Fix wordwrap+linkification

* Update ietf/doc/templatetags/ietf_filters.py

* Update ietf/doc/templatetags/tests_ietf_filters.py

* Don't right-align second column
2022-05-03 13:55:48 -05:00
Lars Eggert 169ab1c10f
fix: Adopt -> Manage adoption (#3922)
Fixes #3877
2022-05-03 09:32:24 -05:00
Lars Eggert 9db1d48258
fix: Correctly linkify all current TLDs (#3868)
* fix: Correctly linkify all current TLDs

* Pass a list to the build_*_re functions, not a string

* Need to sort TLDs by length to force longer ones to match first

* chore: silence incorrect mypy complaint.

Co-authored-by: Robert Sparks <rjsparks@nostrum.com>
Co-authored-by: Nicolas Giard <github@ngpixel.com>
2022-04-26 12:25:18 -05:00
Robert Sparks 87fac4e12a
test: align tests with new shepherd writeup template. (#3838) 2022-04-19 11:44:59 -05:00
Jennifer Richards 43952a8c69
fix: do not prematurely dereference status change RelatedDocuments (#3835)
* test: add tests of the person_link tag

* fix: do not prematurely dereference status change RelatedDocuments

The urlize_related_source_list template tag expects the RelatedDocument
instances, not the source Document.

* test: add test cases for status changes on document_main view
2022-04-19 07:04:38 -05:00
Robert Sparks eef29cf35d
fix: improve ietf doc string urlization. Fixes #3828. (#3831)
* fix: improve ietf doc string urlization. Fixes #3828.

* fix: dont urlize names immediately after - or /. Avoids urizing in the middle of urls.

* fix: cover some additional corners when urlifying document names.

* chore: remove unnecessary code complication
2022-04-15 15:43:32 -05:00
Lars Eggert 79c7081181
* fix: Correctly urlize bis documents
The old code would first substitute the "rfx<nnnn>" part, and then again
on the full draft name. This now only ever applies one substitute,
and does longer ones first.
2022-04-14 15:33:47 -03:00
Lars Eggert 19e639f779
fix: .visually-hidden -> .d-none (#3800)
In bs5, `.visually-hidden` is the equivalent of bs3's `.sr-only`, i.e., it's
still shown on screen readers, which is not what we want. Use `.d-none` instead,
which is the equivalent of bs3's `.hidden`.
2022-04-08 14:53:56 -03:00
Lars Eggert 3234f1a121
test: Validate HTML rendered during tests (#3782) 2022-04-07 13:30:38 -03:00
Lars Eggert 870fed030f
fix: More fixes for narrow screens (#3662)
* fix: More fixes for narrow screens

Need to keep checking for issues, there are more.

* Make columns more narrow on narrow screens

* More fixes

* More fixes

* Test fixes

* Fix more tests

* Close tbody
2022-03-24 12:40:48 -03:00
Eric Vyncke 65d4c99707
feat: use related docs pages count when no page count (#3686) 2022-03-22 13:41:37 -05:00
Lars Eggert eb5423d084
ci: Also check generated HTML with the "vnu" validator (#3682)
* ci: Also check generated HTML with the "vnu" validator

Because HTML Tidy apparently misses a bunch of errors.

* thead -> tbody

* More fixes

* More fixes

* Start checker in test runner
2022-03-21 12:50:23 -05:00
Russ Housley 71b1f13a79
fix: improfe draft name syntax checks (#3703)
* fix: Include blocked charters in AD dashboard that are ub external review

* fix: Improve draft name syntax checks. Fixes #3677
2022-03-20 06:59:29 -05:00
Robert Sparks 5c5d052603
fix: remove unintended debug code (#3704) 2022-03-19 16:02:46 -03:00
Russ Housley 74d30529b6
fix: Include blocked charters in AD dashboard that are in external review (#3689) 2022-03-19 11:59:04 -05:00
Jennifer Richards 686a9150b3 Merge remote-tracking branch 'origin/main' into personal/jennifer/7.45.1.dev0.bootstrap-merge
# Conflicts:
#	ietf/templates/meeting/session_buttons_include.html
2022-03-04 15:14:52 -04:00
Robert Sparks 6968252afb Merged in [19987] from rjsparks@nostrum.com:
Change generated draft/group alias/virtual file permissions.
 - Legacy-Id: 19988
Note: SVN reference [19987] has been migrated to Git commit 8deca64b31d95dc1f9c77eea6e7fe66f4c0e0f06
2022-02-24 19:59:09 +00:00
Jennifer Richards 9d8f4ea207 Fix failing tests
- Legacy-Id: 19982
2022-02-24 16:47:55 +00:00
Robert Sparks 7e17801b57 Use shutil.move when building draft and group aliases. Commit ready for merge.
- Legacy-Id: 19950
2022-02-18 17:25:17 +00:00
Robert Sparks d6298adacb Use tempfiles while rebuilding group and doc alias files. Fixes #3521. Commit ready for merge.
- Legacy-Id: 19949
2022-02-18 16:27:00 +00:00
Jennifer Richards 6c260a5b7e Merge 7.45.1.dev0 into Bootstrap 5 update branch. Made a first pass at reconciling differences.
- Legacy-Id: 19945
2022-02-17 20:09:49 +00:00
Robert Sparks e88aa3c7f3 Merged in [19921] from rjsparks@nostrum.com:
add search to the doc states admin form.
 - Legacy-Id: 19929
Note: SVN reference [19921] has been migrated to Git commit ff05978d24f7a9c607d1dd32212e3e3f377b7e6d
2022-02-14 18:16:40 +00:00
Lars Eggert 67ebadeadd A bunch more cosmetic fixes.
- Legacy-Id: 19913
2022-02-09 10:11:03 +00:00
Lars Eggert bbf088e18b Hopefully the final check-ins.
- Legacy-Id: 19909
2022-02-08 17:29:15 +00:00
Lars Eggert ed30521e14 Many more HTML fixes.
- Legacy-Id: 19908
2022-02-03 07:49:34 +00:00
Lars Eggert 64d2ba2558 Run tidy as part of tests, and fix HTML issues it finds.
- Legacy-Id: 19904
2022-02-01 16:11:34 +00:00
Lars Eggert a507b31669 More nits fixed.
- Legacy-Id: 19903
2022-02-01 08:29:55 +00:00
Lars Eggert cc723ce449 More fixes.
- Legacy-Id: 19899
2022-01-31 19:17:50 +00:00
Lars Eggert 335a39d4fc More fixes.
- Legacy-Id: 19884
2022-01-28 13:00:47 +00:00
Lars Eggert cf629a42ad And more fixes.
- Legacy-Id: 19877
2022-01-25 10:14:25 +00:00
Jennifer Richards c4bf508cd8 Do not redirect user to the logout page when logging in. Fixes #3478. Commit ready for merge.
- Legacy-Id: 19876
2022-01-24 17:34:29 +00:00
Lars Eggert 9c05373699 More fixes.
- Legacy-Id: 19856
2022-01-18 20:04:55 +00:00
Lars Eggert 0bfaa63722 More fixes.
- Legacy-Id: 19855
2022-01-17 15:05:22 +00:00
Jennifer Richards 6f3fb6930f Add timeouts to requests library calls. Fixes #3498. Commit ready for merge.
- Legacy-Id: 19839
2022-01-13 15:06:28 +00:00
Jennifer Richards 66687a5a37 Update any_email_sent() to use balloters instead of old ad field. Add tests to catch the otherwise quiet failure. Fixes #3438. Commit ready for merge.
- Legacy-Id: 19837
2022-01-12 20:21:41 +00:00
Lars Eggert edf3242665 More fixes.
- Legacy-Id: 19836
2022-01-12 18:37:18 +00:00
Lars Eggert a5cbf5307e More fixes
- Legacy-Id: 19835
2022-01-12 11:54:00 +00:00
Jennifer Richards efa42e1558 Point to RFC editor info page in document_bibtex view. Fixes #3484. Commit ready for merge.
- Legacy-Id: 19833
2022-01-11 18:39:47 +00:00
Jennifer Richards f7162b690e Include RFC title in doc/html view title element. Fixes #3488. Commit ready for merge.
- Legacy-Id: 19830
2022-01-11 15:37:33 +00:00
Lars Eggert 6ca6c35186 More fixes.
- Legacy-Id: 19829
2022-01-11 15:02:27 +00:00
Lars Eggert 8bc7fde027 More fixes.
- Legacy-Id: 19828
2022-01-11 07:02:39 +00:00
Lars Eggert 373b5dbbf4 More fixes.
- Legacy-Id: 19827
2022-01-10 08:41:20 +00:00
Jennifer Richards cf62b46093 Find references from submitted XML instead of rendering to text and parsing. Fixes #3342. Commit ready for merge.
- Legacy-Id: 19825
2022-01-07 17:53:23 +00:00
Robert Sparks ba1064a721 Merged in [19813] from rjsparks@nostrum.com:
Improve robustness of pdfization. Tune the test crawler.
 - Legacy-Id: 19815
Note: SVN reference [19813] has been migrated to Git commit b1585124d6
2022-01-06 20:55:48 +00:00
Robert Sparks b1585124d6 Improve robustness of pdfization. Tune the test crawler. Commit ready for merge.
- Legacy-Id: 19813
2022-01-06 20:17:55 +00:00
Lars Eggert 6fa5fa073e More fixes.
- Legacy-Id: 19812
2022-01-06 12:26:10 +00:00
Robert Sparks 6e7f834447 Merged in [19806] from rjsparks@nostrum.com:
Correct the url for the bibtex button. Provide a pdfized button. Fixes #3501.
 - Legacy-Id: 19808
Note: SVN reference [19806] has been migrated to Git commit 7d4ea4e37a
2022-01-05 21:09:56 +00:00
Robert Sparks 7d4ea4e37a Correct the url for the bibtex button. Provide a pdfized button. Fixes #3501. Commit ready for merge.
- Legacy-Id: 19806
2022-01-05 21:05:36 +00:00