Commit graph

25 commits

Author SHA1 Message Date
Robert Sparks b99eecc1ae Bring the factory-boy and Faker dependencies forward through some minor breaking changes. Stop using the deprecated fr_QC locale in Faker. Commit ready for merge.
- Legacy-Id: 19270
2021-08-03 22:22:35 +00:00
Robert Sparks 76a8a29756 Bring the nomcom factories and tests into agreement around what a valid year for a nomcom can be. Fixes #3315. Commit ready for merge.
- Legacy-Id: 19148
2021-06-23 16:17:09 +00:00
Henrik Levkowetz f10ddadc0e Merged in changes from trunk up to r17584.
- Legacy-Id: 17593
2020-04-07 16:02:52 +00:00
Henrik Levkowetz dc4c05ec5b Changed the object factory instances of nomcom private key and cert to be byte objects (matching the production settings), and fixed the issue with nomcom key handling under Py3 found by fenton@bluepopcorn.net. Did some renaming in nomcom/tests.py to better match setup/teardown function names to functionality.
- Legacy-Id: 17536
2020-03-25 13:36:29 +00:00
Henrik Levkowetz a91e7aa4c8 Merged in [17493] from mahoney@nostrum.com:
Changed awkward IESG/IAB Nominating Committee names to just NomCom, updated a ref. Fixes #2860.
 - Legacy-Id: 17515
Note: SVN reference [17493] has been migrated to Git commit cf98a644e3da5d2a4303156048ef6aed039f908e
2020-03-22 23:19:55 +00:00
Henrik Levkowetz 726fcbf27d Removed all __future__ imports.
- Legacy-Id: 17391
2020-03-05 23:53:42 +00:00
Henrik Levkowetz 2749759216 Fixed a backwards compatibiltiy issue for the factoryboy lib and updated a dependency requirement.
- Legacy-Id: 17115
2019-11-30 13:15:44 +00:00
Henrik Levkowetz 2d7c9629aa Added 'from __future__' imports all over the place, to bring code behaviour into closer alignment between python2 and python3
- Legacy-Id: 16446
2019-07-15 15:40:51 +00:00
Henrik Levkowetz 1e115539c4 The previous nomcom.fields.EncryptedTextField relied on initial cleartext content having the same type as ciphertext. Under Python3, that's not the case (ciphertext has type bytes). Rewrote the nomcom app and tests to handle capture of comments and encryption to the Feedback.comments ciphertext differently.
- Legacy-Id: 16350
2019-07-01 11:59:59 +00:00
Henrik Levkowetz c4954e13b1 Added more test objects in test_merge_users(), and fixed an issue with merge_users() uncovered by the added testing.
- Legacy-Id: 13730
2017-06-29 14:53:00 +00:00
Robert Sparks 4813177086 Allow the nomcom to collect feedback on arbitrary topics. Fixes #2256 and #1846. Commit ready for merge.
- Legacy-Id: 13474
2017-05-30 19:54:31 +00:00
Robert Sparks ac8e5f5402 Make it possible to close nominations without closing feedback. Fixes #2255. Commit ready for merge.
- Legacy-Id: 13399
2017-05-22 18:40:05 +00:00
Robert Sparks 0088273f5a Adds scripts to create/delete a dummy nomcom to use in development environments. Commit ready for merge. Fixes #2283.
- Legacy-Id: 13230
2017-04-18 16:13:14 +00:00
Henrik Levkowetz e5f889764c Fixed a problem with stability of test_accept_reject_nomination_edges(), and made some changes to make debugging this easier.
- Legacy-Id: 12829
2017-02-13 15:55:55 +00:00
Henrik Levkowetz ec684e1b4e Added a pylint rc-file, and fixed or silenced a number of issues found by pylint using the settings .pylintrc (which enable only error checking).
- Legacy-Id: 11941
2016-09-08 14:48:59 +00:00
Robert Sparks a9abd3c2cd Tweak factories to not randomly create keys that violate constraints. Commit ready for merge
- Legacy-Id: 10756
2016-01-28 20:12:00 +00:00
Robert Sparks 6bf4227974 Checkpoint: main nomination forms use SearchableEmailField
- Legacy-Id: 10609
2015-12-18 20:38:17 +00:00
Robert Sparks df571c2fcc Improved test coverage (from 66 to 87%) - checkpointing before removing move_to_default
- Legacy-Id: 10602
2015-12-16 11:51:32 +00:00
Robert Sparks d2f1d1ff12 corrected an improper import and removed some flakes
- Legacy-Id: 10582
2015-12-11 19:49:33 +00:00
Robert Sparks ea6d82846f Avoiding an initialization problem by setting NOMCOM_PUBLIC_KEYS_DIR in settings_sqlitetest. This is not the best long term fix
- Legacy-Id: 10581
2015-12-11 17:30:13 +00:00
Robert Sparks 6574618cdf a stab in the dark at initializing the public_key in a test friendly way
- Legacy-Id: 10575
2015-12-11 05:06:58 +00:00
Robert Sparks b653e8fe8a Removed the description field from Position. Simplified the Position list and the Position edit form. Tweaked several places to make the pages more self documenting. Added a page to help nomcom chairs through setting up a new nomcom. Fixes #1867 and #1768.
- Legacy-Id: 10565
2015-12-09 23:24:46 +00:00
Robert Sparks f566a83d1d Captured when nomcom members reviewed feedback for a given nominee last. Added badges when new feedback is available. Improved layout of feedback index page. Fixes #1850.
- Legacy-Id: 10535
2015-12-02 23:25:42 +00:00
Robert Sparks 5bafd3d8fe Conditioned behavior of views for concluded nomcoms. Fixes #1856.
- Legacy-Id: 10521
2015-11-28 21:51:37 +00:00
Robert Sparks e81b473282 Expose views for concluded nomcoms. Close feedback and nomination. Initial work on factory-boy based testing. Partially addresses #1856
- Legacy-Id: 10520
2015-11-25 22:17:41 +00:00