Lars Eggert
220be21998
chore: Use codespell to fix typos in code. ( #4797 )
...
* chore: Use codespell to fix typos in code.
Second part of replacement of #4651
@rjsparks, I probably need to revert some things here, and I also
still need to add that new migration - how do I do that?
* Revert migrations
* Migrate "Whitelisted" to "Allowlisted"
* TEST_COVERAGE_MASTER_FILE -> TEST_COVERAGE_MAIN_FILE
* Fix permissions
* Add suggestions from @jennifer-richards
2022-12-07 15:10:35 -06:00
Jennifer Richards
611d732869
test: fix a couple tz problems in tests run soon after midnight UTC ( #4757 )
...
* test: fix tz problem in test_document_ballot() test
* test: fix tz problem in IprTests.test_notify() test
Co-authored-by: Robert Sparks <rjsparks@nostrum.com>
2022-11-15 07:46:42 -06:00
Jennifer Richards
5a55ec0959
test: fix date-related timezone errors in tests ( #4717 )
...
* test: compare UTC dates in test_search_mail_archive()
* test: compare datetimes, not dates, in action holders test
* test: adjust test to match TZ used for IPR notification message
* test: fix timezone in date_today() calls for liaisons tests
* test: use settings.TIME_ZONE for date in nomination tests
* test: correctly use settings.TIME_ZONE instead of system time zone
2022-11-07 09:54:35 +00:00
Jennifer Richards
da70acfdff
Merge branch 'feat/tzaware' into jennifer/yet-more-tz-fixes
...
# Conflicts:
# ietf/ietfauth/utils.py
# ietf/meeting/tests_views.py
# ietf/stats/tests.py
2022-10-17 16:39:45 -03:00
Jennifer Richards
7b1b7f5273
Merge branch 'feat/tzaware' into dev/tzaware-main-merge
2022-10-11 14:57:34 -03:00
Jennifer Richards
cb9e576fb4
fix: return False from has_role() when role_names is the empty list ( #4541 )
...
* fix: return False from has_role() when role_names is the empty list
* chore: add comments clarifying the effect of Q()
2022-10-07 16:05:37 -05:00
Jennifer Richards
2eb5723574
fix: more timezone fixes
2022-09-23 17:12:06 -03:00
Jennifer Richards
1366b6de38
Merge branch 'feat/tzaware' into jennifer/main-to-tzaware-conflicts
2022-09-14 12:36:33 -03:00
Jennifer Richards
32054111df
fix: fix failing tests and eliminate naive datetime warnings ( #4402 )
...
* test: fix timestamp construction in several doc tests
* refactor: rename date2datetime to datetime_from_date and clarify code
* chore: helper to get tzinfo for PRODUCTION_TIMEZONE
* fix: fix timezone handling in make_last_call()
* test: fix datetime generation in doc.tests_charter
* refactor: remove PRODUCTION_TIMEZONE setting
Replaces the PRODUCTION_TIMEZONE setting with a constant,
DEADLINE_TZINFO, in ietf.utils.timezone.
* test: be more careful about timezone in tests_charter.py
* test: be more careful about timezone in doc/tests.py
* fix: fix timezone handling affecting doc.tests_draft
* fix: fix timezone handling affecting tests_irsg_ballot.py
* fix: fix timezone handling affecting tests_review.py
* fix: fix timezone handling affecting last ietf.doc tests
* fix: fix timezone handling affecting last ietf.group tests
* fix: fix timezone handling affecting ietf.iesg tests
* fix: handle timezones in get_8989_eligibility_querysets
* fix: handle timezones affecting ietfauth tests
* fix: return tz-aware datetime from utc_from_string
* fix: specify timezone for constants in ipr_rfc_number()
* fix: specify tz for ipr deadlines
* fix: handle timezones affecting liaisons tests
* fix: treat leap day in get_8989_eligibility_querysets()
Manual cherry-pick of 248d6474
* test: treat leap day properly in nomcom tests
* fix: fix timezone handling affecting nomcom tests
* test: fix timezone handling in review tests
* fix: fix timezone handling affecting secr.meetings tests
* fix: handle both pytz and zoneinfo timezones in ietf.utils.timezone
* fix: fix timezone handling affecting secr.proceedings tests
* refactor: use make_aware() helper in secr.meetings tests
* test: fix timezone handling in secr.telechat tests
* fix: fix timezone handling affecting stats tests
* fix: eliminate tz-naive helpers affecting sync email parsing
* fix: include timezone data when serializing DeletedEvent data
* fix: fix timezone handling affecting sync tests
* style: remove unused import
2022-09-01 13:07:28 -03:00
Lars Eggert
088d953e7e
fix: provide settings to render_to_string for IPR notification emails ( #4357 )
...
* Pass settings into the context
Fixes #4340
* fix: test changes to the ipr notification message content
Co-authored-by: Robert Sparks <rjsparks@nostrum.com>
2022-08-26 14:27:37 -05:00
Jennifer Richards
ebebdbed3e
refactor: replace datetime.now and datetime.today with timezone.now ( #4211 )
...
* refactor: replace datetime.now with timezone.now
* refactor: migrate model fields to use timezone.now as default
* refactor: replace datetime.today with timezone.now
datetime.datetime.today() is equivalent to datetime.datetime.now(); both
return a naive datetime with the current local time.
* refactor: rephrase datetime.now(tz) as timezone.now().astimezone(tz)
This is effectively the same, but is less likely to encourage accidental
use of naive datetimes.
* refactor: revert datetime.today() change to old migrations
* refactor: change a missed datetime.now to timezone.now
* chore: renumber timezone_now migration
* chore: renumber migrations
2022-08-25 13:45:16 -03:00
Robert Sparks
10396d6f01
chore: remove more tools.ietf.org server only related things. ( #4103 )
...
* chore: remove more tools.ietf.org server only related things.
* chore: remove use of tools.ietf.org floorplans\n\nThe data will move into the FloorPlan models instead.
2022-06-22 14:11:46 -05:00
Jennifer Richards
681fae2af5
test: decode email payloads before validating ( #3926 )
2022-05-03 09:29:42 -05:00
Lars Eggert
eb5423d084
ci: Also check generated HTML with the "vnu" validator ( #3682 )
...
* ci: Also check generated HTML with the "vnu" validator
Because HTML Tidy apparently misses a bunch of errors.
* thead -> tbody
* More fixes
* More fixes
* Start checker in test runner
2022-03-21 12:50:23 -05:00
Jennifer Richards
6c260a5b7e
Merge 7.45.1.dev0 into Bootstrap 5 update branch. Made a first pass at reconciling differences.
...
- Legacy-Id: 19945
2022-02-17 20:09:49 +00:00
Lars Eggert
a5cbf5307e
More fixes
...
- Legacy-Id: 19835
2022-01-12 11:54:00 +00:00
Lars Eggert
5132661b06
More test fixes
...
- Legacy-Id: 19803
2022-01-05 11:25:25 +00:00
Lars Eggert
c68446ae93
More select2 and test fixes.
...
- Legacy-Id: 19781
2021-12-14 18:19:12 +00:00
Jennifer Richards
310ea57bc5
Accept/replace invalid Unicode bytes when processing ipr response emails. Fixes #3489 . Commit ready for merge.
...
- Legacy-Id: 19766
2021-12-09 19:29:20 +00:00
Lars Eggert
e9fd78128c
Interim commit
...
- Legacy-Id: 19765
2021-12-09 18:26:53 +00:00
Lars Eggert
f974fd3c04
Fix more things
...
- Legacy-Id: 19762
2021-12-09 06:41:00 +00:00
Jennifer Richards
dcf4251363
Better handle invalid character encodings in process_email and feedback_email commands. Add tests of this using stdin. Commit ready for merge.
...
- Legacy-Id: 19694
2021-11-19 00:41:05 +00:00
Robert Sparks
5c28a85cf1
Merged in [19555] from jennifer@painless-security.com:
...
Use temporary directories instead of 'real' filesystem for tests. Fixes #3414 .
- Legacy-Id: 19561
Note: SVN reference [19555] has been migrated to Git commit 81d9234d54
2021-11-08 18:16:56 +00:00
Jennifer Richards
81d9234d54
Use temporary directories instead of "real" filesystem for tests. Fixes #3414 . Commit ready for merge.
...
- Legacy-Id: 19555
2021-11-05 19:45:57 +00:00
Robert Sparks
d9dc4f55e2
Merged in [19493] from jennifer@painless-security.com:
...
Create management command base class that sends emails on exceptions. Fixes #3356 and #3357 .
- Legacy-Id: 19527
Note: SVN reference [19493] has been migrated to Git commit 968b775315
2021-11-02 17:40:28 +00:00
Robert Sparks
2eb2ced685
Merged in [19488] from rcross@amsl.com:
...
Change view /ipr/by-draft-recursive to use static content
- Legacy-Id: 19524
Note: SVN reference [19488] has been migrated to Git commit 93d5d193e5
2021-11-02 15:55:20 +00:00
Jennifer Richards
968b775315
Create management command base class that sends emails on exceptions. Fixes #3356 and #3357 . Commit ready for merge.
...
- Legacy-Id: 19493
2021-10-29 01:58:21 +00:00
Ryan Cross
93d5d193e5
Change view /ipr/by-draft-recursive to use static content
...
- Legacy-Id: 19488
2021-10-28 18:45:07 +00:00
Jennifer Richards
0782ee0843
Handle missing 'to' field in process_response_email. Relates to #3357 . Commit ready for merge.
...
- Legacy-Id: 19312
2021-09-01 14:53:35 +00:00
Robert Sparks
b99eecc1ae
Bring the factory-boy and Faker dependencies forward through some minor breaking changes. Stop using the deprecated fr_QC locale in Faker. Commit ready for merge.
...
- Legacy-Id: 19270
2021-08-03 22:22:35 +00:00
Robert Sparks
bbdf15eabd
Removed unintended debug statement. Commit ready for merge.
...
- Legacy-Id: 19217
2021-07-14 19:08:33 +00:00
Robert Sparks
993299faf6
quote a test parameter that should have been quoted all along. Commit ready for merge.
...
- Legacy-Id: 19215
2021-07-14 19:03:36 +00:00
Jennifer Richards
17d37723f7
Consolidate repeated searchable field code into SearchableField class. Fix single-valued searchable fields. Make javascript test config reusable. Use Django Form.media for JS/CSS inclusion. Fixes #3196 , #3204 . Commit ready for merge.
...
- Legacy-Id: 18939
2021-04-09 15:18:11 +00:00
Robert Sparks
b16703160d
Merged in [18886] from rjsparks@nostrum.com:
...
Change ipr pages to say General rather than Generic, and to change the text to note email submissions are not accepted. Fixes #3209 .
- Legacy-Id: 18888
Note: SVN reference [18886] has been migrated to Git commit 550c1233fe
2021-03-03 20:49:11 +00:00
Robert Sparks
550c1233fe
Change ipr pages to say General rather than Generic, and to change the text to note email submissions are not accepted. Fixes #3209 . Commit ready for merge.
...
- Legacy-Id: 18886
2021-03-03 20:15:57 +00:00
Robert Sparks
8bf32fc890
Adjust several searchable fields to match a changed interface in select2-field.js
...
- Legacy-Id: 18867
2021-02-26 16:23:04 +00:00
Robert Sparks
3697180cc1
Reverted merge of timezone-aware migration efforts.
...
- Legacy-Id: 18792
2021-01-12 16:54:20 +00:00
Henrik Levkowetz
774e752a54
Snapshot of timezone-aware datatracker code. Tests pass, and the test-crawler shows only expected differences. Trunk changes merged in up to r18768.
...
- Legacy-Id: 18770
2020-12-16 23:53:37 +00:00
Henrik Levkowetz
088033d843
Added matching indexes to a number of models with ordering by multiple keys.
...
- Legacy-Id: 18664
2020-11-09 19:41:12 +00:00
Robert Sparks
a6e614d8ad
Increase length-limit on the notes field of the Generic IPR disclosure form. Additional fix for #3104 . Commit ready for merge.
...
- Legacy-Id: 18622
2020-10-19 17:56:26 +00:00
Robert Sparks
02718dc447
Increase length-limit on the notes field of the base IPR disclosure form. Fixes #3104 . Commit ready for merge.
...
- Legacy-Id: 18620
2020-10-19 14:55:43 +00:00
Henrik Levkowetz
02bb72d585
Merged in [18425] from olau@iola.dk:
...
Make the IPR search form initialize the state field upon form
initialization instead of evaluating the queryset upon importing the
module. This is probably never a problem in practice in this case in
the live environment, but it's a confusing practice, and when running
the tests sometimes a bug seems to throw Django off and the error is
then shadowed by Django crashing when trying to access the
(non-existing) database.
- Legacy-Id: 18454
Note: SVN reference [18425] has been migrated to Git commit 0aa0f7d4e2
2020-09-01 10:30:55 +00:00
Henrik Levkowetz
465063d0ec
Made a template filter more robust when given unexpected input.
...
- Legacy-Id: 18417
2020-08-26 14:55:28 +00:00
Henrik Levkowetz
0c4d58a9f7
Based on feedback from the Secretariat, changed the 404 for IPR declarations in other states than 'posted' to a 403 with a login link.
...
- Legacy-Id: 18333
2020-07-31 12:36:50 +00:00
Henrik Levkowetz
bc05e7a8d0
Refactored many instances of msg.get_payload(decode=True).decode('utf-8') and similar to get_payload_text(msg), which uses msg.get_charset() to get the actual charset to do the decoding, in a consistent manner. Also removed some instances of force_str, but more remain.
...
- Legacy-Id: 17807
2020-05-16 20:20:05 +00:00
Henrik Levkowetz
9aeda11a29
Removed some Py2 compatibility decorators.
...
- Legacy-Id: 17673
2020-04-21 13:54:31 +00:00
Henrik Levkowetz
f10ddadc0e
Merged in changes from trunk up to r17584.
...
- Legacy-Id: 17593
2020-04-07 16:02:52 +00:00
Henrik Levkowetz
5ec243e14f
Changed the IPR patent number regex to permit space between country code and serial number, and expanded on the help text for the IPR patent number field.
...
- Legacy-Id: 17573
2020-04-01 16:50:01 +00:00
Henrik Levkowetz
726fcbf27d
Removed all __future__ imports.
...
- Legacy-Id: 17391
2020-03-05 23:53:42 +00:00
Henrik Levkowetz
ab173cb2eb
Removed further six usage: six.string_types, six.integer_types, six.moves.urllib instances.
...
- Legacy-Id: 17390
2020-03-05 20:46:58 +00:00