Commit graph

47 commits

Author SHA1 Message Date
Henrik Levkowetz 8e313e4ed5 Adjusted migrations for Python2/3 compatibility.
- Legacy-Id: 16633
2019-08-08 17:11:14 +00:00
Henrik Levkowetz 2d7c9629aa Added 'from __future__' imports all over the place, to bring code behaviour into closer alignment between python2 and python3
- Legacy-Id: 16446
2019-07-15 15:40:51 +00:00
Henrik Levkowetz d7f5c84182 Initial 2to3 patch with added copyright statement updates.
- Legacy-Id: 16309
2019-06-27 14:40:54 +00:00
Henrik Levkowetz 426870b766 Merged in the Document and DocAlias primary key change and m2m work in ^/personal/henrik/6.96.1-docalias.
- Legacy-Id: 16261
2019-06-15 12:00:48 +00:00
Henrik Levkowetz 815602351f This is a series of 50 migrations that changes the Document and DocAlias
primary keys from character strings to integers, and makes corresponding code
changes.

This was prompted by database limitations discovered when trying to make
DocAlias use a m2m document field; with 255 long strings as primary keys for
Document and DocAlias this violated the MySQL database limitations.

Changing the primary keys to integers should also improve efficiency.  

Due to the data migrations which create the new integer primary keys and adds
corresponding integer foreign keys matching the previous string foreign keys
in all tables having foreign keys to Document and DocAlias, some of these
migrations take a long time.  The total set of migrations are expected to have
a runtime on the order of 2 hours.
 - Legacy-Id: 16237
2019-06-10 11:32:46 +00:00
Henrik Levkowetz 9282195d6c Fixed some migrations issues that prevented the review assignment refactoring migrations from being reversed and re-applied.
- Legacy-Id: 16182
2019-05-02 13:49:14 +00:00
Henrik Levkowetz 8726e74709 Merged in a refactoring of document review code from rjsparks@nostrum.com. This introduces ReviewAssignments, letting us do multiple assingments for a given RevieRequest, without conflating the assignments and their results with the request itself.
- Legacy-Id: 16177
2019-04-30 16:54:06 +00:00
Henrik Levkowetz bb4fe3fbbf Undid previous commit
- Legacy-Id: 16153
2019-04-22 19:22:42 +00:00
Robert Sparks b85052fe63 Checkpoint. Lots of tests will still fail. Reordered some migrations. Brought about half of the ietf.doc.views_review views into line with the new models. Next step is the other half.
- Legacy-Id: 16012
2019-03-07 23:08:14 +00:00
Robert Sparks 82025f9dca Continuing to checkpoint.
- Legacy-Id: 15986
2019-03-01 23:23:39 +00:00
Robert Sparks 87dd249415 Cleanup: removed the infrastructure for importing reviews from the old review tool. Commit ready for merge.
- Legacy-Id: 15865
2019-01-03 21:04:13 +00:00
Robert Sparks 6d14714f19 Allow notify_ad_when to be blank. Commit ready for merge.
- Legacy-Id: 15808
2018-12-06 21:18:26 +00:00
Robert Sparks cb707248e2 Add history to ReviewerSettings. Fixes #2147. Commit ready for merge.
- Legacy-Id: 15804
2018-12-03 22:23:01 +00:00
Henrik Levkowetz 3b811ecb41 Merged in [15708] and [15730] from housley@vigilsec.com:
Added a mail alias for all review team secretaries. Fixes #2139.  Use
the alias if there is one for email about review request changes.  Added
a test for the review team secretary alias functionality.
 - Legacy-Id: 15746
Note: SVN reference [15708] has been migrated to Git commit 6067dcbfef

Note: SVN reference [15730] has been migrated to Git commit d525ade0b0
2018-11-10 19:30:32 +00:00
Russ Housley 6067dcbfef Allow a mail alias for all review team secretaries. Fixes #2139. Commit ready for merge.
- Legacy-Id: 15708
2018-11-03 11:55:07 +00:00
Robert Sparks c7bf147b1d Let review teams opt in to poking a responsible AD when unhappy reviews are submitted. Fixes #2544. Commit ready for merge.
- Legacy-Id: 15675
2018-11-02 20:18:06 +00:00
Henrik Levkowetz 0ade20b1b8 Added a missing migration (for review unavailable-period reason)
- Legacy-Id: 15402
2018-07-23 22:32:41 +00:00
Henrik Levkowetz 06362ec046 Got rid of old migrations and created new initial migrations.
- Legacy-Id: 14662
2018-02-21 23:46:22 +00:00
Henrik Levkowetz e19290e98d Merged in [13532] from rjsparks@nostrum.com:
Add an expertise field to reviewer settings. Fixes #2308. ,
 - Legacy-Id: 13539
Note: SVN reference [13532] has been migrated to Git commit d845fba8bec765f2f81ae1a4bbca52c9bceb6e02
2017-06-06 07:54:03 +00:00
Henrik Levkowetz fd9a0d12b5 Renamed a couple of migrations.
- Legacy-Id: 12973
2017-03-05 12:03:15 +00:00
Henrik Levkowetz 119f48699c Added a data migration to add author information to existing reviews.
- Legacy-Id: 12960
2017-03-03 21:14:45 +00:00
Henrik Levkowetz d401e6ba67 Fixed an error in migration dependency.
- Legacy-Id: 12592
2016-12-19 21:42:21 +00:00
Henrik Levkowetz 80c0e65428 Merged in [12540] from rjsparks@nostrum.com:
Missed adding a migration to svn for r12521.  Should only be applied after r12521.
 - Legacy-Id: 12591
Note: SVN reference [12540] has been migrated to Git commit 68bdff6fd5
2016-12-19 21:39:54 +00:00
Henrik Levkowetz 45d4ce67c7 Adjusted the ReviewRequest.comment AddField migration to match the change in model.
- Legacy-Id: 12553
2016-12-16 12:55:37 +00:00
Henrik Levkowetz ff3638e365 Merged in [12549] from rjsparks@nostrum.com:
allow ads and secretaries to edit the review request comment. Fixes #2096. (Again).
 - Legacy-Id: 12550
Note: SVN reference [12549] has been migrated to Git commit 32b431cf24
2016-12-15 23:10:28 +00:00
Henrik Levkowetz 8dcc1d20a2 Merged in [12545] from rjsparks@nostrum.com:
Allow a review request to include a comment to show to the review team secretary at assignment time and the reviewer at review time. Fixes #2096.
 - Legacy-Id: 12548
Note: SVN reference [12545] has been migrated to Git commit 6fcd8b8a16
2016-12-15 22:45:25 +00:00
Robert Sparks 6fcd8b8a16 Allow a review request to include a comment to show to the review team secretary at assignment time and the reviewer at review time. Fixes #2096. Commit ready for merge.
- Legacy-Id: 12545
2016-12-15 21:52:12 +00:00
Robert Sparks 68bdff6fd5 Missed adding a migration to svn for r12521. Commit ready to merge. Should only be applied after r12521.
- Legacy-Id: 12540
2016-12-15 19:30:36 +00:00
Robert Sparks b24bdb5bc3 Slight refactor of the review models to capture review team settings. Allows configuring review teams to get automatic suggestions for reviews or not. Provides a better admin for creating/managing review teams. Fixes #2048 and #2072. Commit ready for merge.
- Legacy-Id: 12520
2016-12-14 23:26:32 +00:00
Henrik Levkowetz 3c956c9896 Added migrations for new timezone data, validation on ReviewerSettings.filter_re, and new docevent types.
- Legacy-Id: 12493
2016-12-09 12:41:38 +00:00
Henrik Levkowetz ca4ab7b402 Added a migration for updated help text on some review fields.
- Legacy-Id: 12422
2016-11-30 14:31:52 +00:00
Ole Laursen ceec1254f2 Add review team secretary reminders, like those for reviewers
- Legacy-Id: 12283
2016-11-08 16:24:28 +00:00
Ole Laursen 2ce2f8d067 Change default of ReviewerSettings.min_interval to null - if it's not
specified for a reviewer, we don't take it into account
 - Legacy-Id: 12169
2016-10-18 10:37:03 +00:00
Ole Laursen 399bb3bf4d Make UnavailablePeriod.start_date nullable and import the unavailable
periods from the Perl tool with start date null as we don't know when
they started.
 - Legacy-Id: 12161
2016-10-17 19:37:56 +00:00
Ole Laursen 9de2d49823 Fixup some of the migrations a bit upon the merge with trunk.
- Legacy-Id: 12135
2016-10-13 19:20:26 +00:00
Ole Laursen 59180240af Add a simple reminder system for reviewers so that they can opt in to
being reminded X days before deadline of an assignment
 - Legacy-Id: 12101
2016-10-07 16:43:29 +00:00
Ole Laursen 227fdd7953 Add reviews to search results and IESG agenda. Support restricting
review types so that teams will only have those review types
listed and suggested that they are configured to have.

Fix a couple of things in the importer after having tested it on all
the databases. Set unavailable end date >= 2020 to indefinite.

Fix a couple of bugs.
 - Legacy-Id: 12095
2016-10-06 14:47:41 +00:00
Ole Laursen 4c7b2847ba Add a utility function for extracting information about review
requests for a given set of teams/reviewers (making it trivial to
compute statistics), revamp the related doc event code to support this
by referencing the review request directly, add a reviewer overview
page with recent performance for each reviewer as well as
settings/unavailable periods. Fix some bugs and shuffle some of the
review code a bit around.

Finish the importer from the previous Perl-based review tool,
importing log entries, figuring out whether a given review is
early/telechat/last call and fixing corner cases.
 - Legacy-Id: 12080
2016-10-03 15:52:32 +00:00
Ole Laursen 99beb58291 Implement a round-robin rotation scheme for reviewers instead of
relying on when they last reviewed. In-order assignments automatically
move the rotation forwards while out-of-order assignments increment
the skip next of the assigned reviewer. Include rotation in open
review assignments email. Fix a couple of issues in the importer.
 - Legacy-Id: 12015
2016-09-21 16:52:50 +00:00
Ole Laursen 6da25e6bd9 Add personal review overview page for reviewers, add page for editing
reviewer availability settings, emailing the reviewer/secretary as
necessary, add tests for these pages. Fix a bunch of bugs.
 - Legacy-Id: 11998
2016-09-19 16:05:32 +00:00
Ole Laursen 74a02be9bf Create new branch from trunk@r11921, and merge review-tracker-r11360 into it
- Legacy-Id: 11923
2016-09-06 10:17:12 +00:00
Ole Laursen 426542771a Turn ReviewRequest.deadline into a date field with no time
- Legacy-Id: 11801
2016-08-17 15:10:39 +00:00
Ole Laursen 19fff81a4f Rework closing a review request so the logic is reusable, add the more
specific close reasons to the database migration, add
ReviewRequest.requested_by so it's possible to notify the requester of
a review that it has been dropped.
 - Legacy-Id: 11520
2016-07-05 16:05:00 +00:00
Ole Laursen e2e66522c7 Add review request page for review teams and first draft of manage
review requests page.

Add importer for importing review data from the existing Perl tool
(WIP, gets most but not all of the interesting information out).

Fix various bugs.
 - Legacy-Id: 11508
2016-07-01 16:06:16 +00:00
Ole Laursen 5dd079e2f8 Add support for assigning a reviewer to a review request, still some
corners missing. Fix a couple of other issues.
 - Legacy-Id: 11227
2016-05-23 16:42:49 +00:00
Ole Laursen 44e135345c Add a page for displaying a review request, add support for
withdrawing requests, add tests for these two pages
 - Legacy-Id: 11217
2016-05-20 14:14:31 +00:00
Ole Laursen 64a65340a2 Add review tracking models, add a request review page (with test), show
review requests on doc page
 - Legacy-Id: 11206
2016-05-19 15:35:30 +00:00