Commit graph

14040 commits

Author SHA1 Message Date
Nicolas Giard f1472ffcac
chore: run devcontainer as user vscode instead of root (#3948) 2022-05-13 14:13:50 -05:00
Lars Eggert f4ce041dcc
fix: Add whitespace before "for" (#3951) 2022-05-13 14:13:14 -05:00
Lars Eggert f6c95be1fc
chore: Update deps (#3954) 2022-05-13 14:08:26 -05:00
Lars Eggert 75a32d2210
fix: Link to reviews from search status column (#3955)
* fix: Link to reviews from search status column

Fixes #3953

* fix: Make the notices about exceeded state times less obtrusive

* Fix tests
2022-05-13 14:05:42 -05:00
Lars Eggert b265bac1fe
fix: Fix action holder form buttons (#3956)
Fixes #3943
2022-05-13 14:01:14 -05:00
Lars Eggert 39525a1cd0
fix: escape the ballot comments (#3952)
I wonder if other fields that have class `pasted` would need to be escaped, too?
2022-05-12 12:17:48 -05:00
Jennifer Richards cb996c5c0b
fix: refactor/correct calculation of week-view event start/end times (#3947)
* fix: use DST-friendly tz calculation for TimeSlot end times

Around DST changes, localize(time + duration).astimezone() is not
the same as localize(time).astimezone() + duration. The latter allows
tz-aware times to do their magic and give correct clock times.

* fix: refactor/correct calculation of week-view event start/end times

There were bugs in the timestamp calculations around DST switchover.
This corrects those and tries to clarify and improve documentation in
the relevant code.
2022-05-11 16:08:47 -05:00
Nicolas Giard 636ebd7c81
chore: remove browser dropdown from report bug issue template 2022-05-10 18:51:35 -04:00
Nicolas Giard ed80308225
chore: update issue config links 2022-05-10 18:33:31 -04:00
Nicolas Giard 98108e020b
chore: fix new request issue template filename 2022-05-10 18:31:49 -04:00
Nicolas Giard 58ad3db836
chore: add new feature issue template 2022-05-10 18:30:36 -04:00
Nicolas Giard 7f8c58355f
chore: fix issue template 2022-05-10 18:25:31 -04:00
Nicolas Giard 25390ab896
chore: update issue template wording 2022-05-10 18:24:58 -04:00
Lars Eggert 5f8d4ed718
More HTML nitfixing (#3934)
* Unicode messages are triggered by both db content and tests

* Make ids unique

* Avoid "No value found" message on page

* Strip HTML from history entries, it's often broken

* Check HTML sources for occurrences of "** No value found for" and fix them

* Fix another occurrence of "** No value found for"

* Fix more occurrences of "** No value found for"

* Fix document revision stripping

* Force breaks of long (garbage) words

* Check URL validity before urlizing them

* Handle some additional corner cases

* Linkify action items

* Don't create profile/email links for System

* Handle headings with HTML elements in them better

* Fix comment

* Fix another occurrence of "** No value found for"

* Better I-D URLization that handles more edge cases. Also, test for them.

* Remove print

* Handle charters better

* Cache for one day
2022-05-10 12:37:14 -05:00
Robert Sparks 47b89c1112
chore: alter CSP to enable analytics (#3941) 2022-05-09 13:38:50 -05:00
Robert Sparks cdd86b9d5e
ci: show makemigrations output (#3932)
* ci: show makemigrations output

* chore: remove unused releasetest settings
2022-05-03 20:54:25 -05:00
Robert Sparks def13a872a
chore: catchup with pytz country (#3933) 2022-05-03 20:54:02 -05:00
Robert Sparks d4ebbe41e8
feat: improve notes imports by using de-gfm -4. Related to #3851. (#3930) 2022-05-03 18:04:48 -05:00
Nicolas Giard 3606dbef38
ci: fix makemigrations echo during pr checks + build 2022-05-03 18:31:50 -04:00
Lars Eggert 5598762608
fix: add more HTML validation & fixes (#3891)
* Update vnu.jar

* Fix py2 -> py3 issue

* Run pyupgrade

* test: Add default-jdk to images

* test: Add option to also validate HTML with vnu.jar

Since it's already installed in bin. Don't do this by default, since it
increases the time needed for tests by ~50%.

* fix: Stop the urlizer from urlizing in linkified mailto: text

* More HTML fixes

* More HTML validation fixes

* And more HTML fixes

* Fix floating badge

* Ignore unicode errors

* Only URLize docs that are existing

* Final fixes

* Don't URLize everything during test-crawl

* Feed HTML into vnu using python rather than Java to speed things up

* Allow test-crawl to start vnu on a different port

* Increase retry count to vnu. Restore batch size to 30.

* More HTML validation fixes

* Use urllib3 to make requests to vnu, since overriding requests_mock is tricky

* Undo commit of unmodified file

* Also urlize ftp links

* Fix matching of file name

* More HTML fixes

* Add `is_valid_url` filter

* weekday -> data-weekday

* urlencode URLs

* Add and use vnu_fmt_message. Bump vnu max buffer.

* Simplify doc_exists

* Don't add tab link to mail archive if the URL is invalid

* Run urlize_ietf_docs before linkify

Reduces the possibility of generating incorrect HTML

* Undo superfluous change

* Runner fixes

* Consolidate vnu message filtering into vnu_filter_message

* Correctly handle multiple persons with same name

* Minimze diff

* Fix HTML nits

* Print source snippet in vnu_fmt_message

* Only escape if there is something to escape

* Fix snippet

* Skip crufty old IPR declarations

* Only include modal when needed. Add handles.

* Fix wordwrap+linkification

* Update ietf/doc/templatetags/ietf_filters.py

* Update ietf/doc/templatetags/tests_ietf_filters.py

* Don't right-align second column
2022-05-03 13:55:48 -05:00
Nicolas Giard f778058005
ci: add db migrations checks to tests and build workflows (#3920)
* ci: add db migrations checks to tests and build workflows

* ci: refactor migrations check expression

* chore: rework conditional and exit

Co-authored-by: Robert Sparks <rjsparks@nostrum.com>
2022-05-03 12:06:41 -05:00
Lars Eggert 19796c56c9
fix: Stretch righthand-nav to viewport edge (#3921)
* fix: Stretch righthand-nav to viewport edge

Fixes #3848

* Also improve tz-select display, while we're here

* Change func name
2022-05-03 09:35:10 -05:00
Lars Eggert 169ab1c10f
fix: Adopt -> Manage adoption (#3922)
Fixes #3877
2022-05-03 09:32:24 -05:00
Lars Eggert f4b8fc1d0d
fix: 2023 -> 2023 in document shepherd template (#3923) 2022-05-03 09:30:17 -05:00
Jennifer Richards 681fae2af5
test: decode email payloads before validating (#3926) 2022-05-03 09:29:42 -05:00
Robert Sparks 8fc8e9af4f
fix: guard against reviews without reviewassignments. Fixes #3906. (#3915) 2022-04-29 18:43:35 -05:00
Robert Sparks d7362609b8
fix: re-align html and view for submit-to-iesg. Fixes #3913 (#3914) 2022-04-29 14:55:21 -05:00
Robert Sparks 3862d4a77c
doc: update manual deploy instructions (#3907)
* doc: update manual deploy instructions

* chore: correct installation unroll step
2022-04-29 09:46:30 -05:00
Robert Sparks 55d7629e4d
chore: use and expect python39 (#3908) 2022-04-29 09:45:41 -05:00
Lars Eggert 84d6118d9f
test: Also rsync bofreq (#3902) 2022-04-28 11:09:11 -05:00
Robert Sparks 86923dfe96
chore: update dependency requirements (#3904)
* chore: cleanup requirements.txt. Unpin factory-boy, ignoring resulting mypy complaints.

* chore: remove the upper limit as many dependencies as possible

* chore: remove unintended bookmark

* chore: normalize spaces before comments

* chore: improve comment explaining pinned Tastypie

* chore: shift dependencies minimum version requirements forward
2022-04-28 11:06:17 -05:00
Jennifer Richards 4e4569acc1
fix: use ModelMultipleChoiceField for 'bethere' when hidden (#3894)
The select2-based fields do not behave well on the SubmissionForm when
hidden=True. The ModelMultipleChoiceField is enough for this case.
2022-04-26 16:53:45 -05:00
Nicolas Giard 8e48230115
ci: add missing yarn rebuild step to deploy build.sh 2022-04-26 14:57:12 -04:00
Lars Eggert 53a2b61bbc
feat: Make the "report a bug" links more visible (#3883)
* feat: Make the "report a bug" links more visible

Also rework the page footer somewhat, while we're here.

* Revert empty change

Co-authored-by: Nicolas Giard <github@ngpixel.com>
2022-04-26 12:30:21 -05:00
Lars Eggert 9db1d48258
fix: Correctly linkify all current TLDs (#3868)
* fix: Correctly linkify all current TLDs

* Pass a list to the build_*_re functions, not a string

* Need to sort TLDs by length to force longer ones to match first

* chore: silence incorrect mypy complaint.

Co-authored-by: Robert Sparks <rjsparks@nostrum.com>
Co-authored-by: Nicolas Giard <github@ngpixel.com>
2022-04-26 12:25:18 -05:00
Lars Eggert 955d9ac489
fix: Spacing issues and colorization in conflict review display (#3882)
Co-authored-by: Nicolas Giard <github@ngpixel.com>
2022-04-26 12:24:33 -05:00
Nicolas Giard 0dec52f129
ci: enable yarn in test image 2022-04-26 11:34:16 -04:00
Nicolas Giard 003b6d62f5
docs: add yarn module installation example 2022-04-25 17:29:23 -04:00
Nicolas Giard 8cf43a546f
docs: reformat README 2022-04-25 17:23:08 -04:00
Nicolas Giard abfdd2d82d
docs: update frontend docs 2022-04-25 17:19:56 -04:00
Nicolas Giard 8ea883cb7e
chore: switch to Yarn 3 (#3819)
* refactor: switch to yarn 3

* chore: add other os+cpu to yarn supported architectures

* chore: add gitattributes

* chore: add missing yarn native modules rebuild step

* chore: replace npx with yarn in test_runner + update readme

* chore: remove bootstrap-datepicker github dependency, use local instead
2022-04-25 15:54:05 -05:00
Lars Eggert cd9a2ee229
fix: Color the background of table rows for an AD based on their ballot (#3867)
Instead of just adding a colored bar on the right-hand side.
2022-04-22 11:05:37 -05:00
Robert Sparks f4b0b459cb
feat: add analytics infrastructure (#3862) 2022-04-21 18:06:14 -05:00
Nicolas Giard 7c6917562f
ci: use strict semver for builds + always run pip install on tests 2022-04-21 16:57:29 -04:00
Lars Eggert ec13e071ba
fix: Whitespace issue ballot popup (#3860) 2022-04-21 11:55:48 -05:00
Lars Eggert 92e67aca8f
fix: Make the author button work on doc submit (#3850) 2022-04-20 10:52:54 -05:00
Lars Eggert 3fdfa3a6ef
fix: Show all liaison groups by default (#3852)
Requiring two characters to be entered before any options are shown makes no
sense here.
2022-04-20 10:51:50 -05:00
Lars Eggert cef7b05981
fix: Don't change text color on hover for badge links (#3845) 2022-04-20 10:50:24 -05:00
Nicolas Giard aba2aa2b59
chore: add vscode extensions volume to reduce ext reinstalls (#3833) 2022-04-20 10:49:04 -05:00
Kesara Rathnayake 6b06542fab
fix: fix OIDC authorization bug (#3842) 2022-04-20 10:47:47 -05:00