Fix#2050 - Allow adding review wishes from document and search pages.
On the main page of a document and in document search results, a new
button allows review team members to add a review wish for that document.
For reviewers that are only on one team, this essentially works
identical to tracking a document. Reviewers that are on multiple teams
are lead through an intermediate step to select a review team, and then
returned to their search or document page.
- Legacy-Id: 16985
Note: SVN reference [16939] has been migrated to Git commit 6e55f26dbd
On the main page of a document and in document search results, a new
button allows review team members to add a review wish for that document.
For reviewers that are only on one team, this essentially works
identical to tracking a document. Reviewers that are on multiple teams
are lead through an intermediate step to select a review team, and then
returned to their search or document page.
Commit ready for merge.
- Legacy-Id: 16939
Fix#2217 - Allow submission of unsolicited reviews by secretaries.
- For team secretaries, a button 'Submit unsolicited review' will now
appear next to 'Request review' on the document's main page.
- If the secretary is a secretary for multiple teams, they are taken
through an intermediate page to select for which team they are
submitting their review.
- The form is similar (and using the same code) as the usual review
completion, with a few extra fields for the review type and reviewer,
which would usually already be known.
- When submitting the review, a ReviewRequest and ReviewAssignment are
automatically created. The assignment is then immediately closed in
the usual way.
- Other workflows are unchanged.
The issues with the review form in #2061 are slightly worse for the
unsolicited review scenario, but that will be improved when #2061 is
fixed.
- Legacy-Id: 16932
Note: SVN reference [16924] has been migrated to Git commit 871a4b653b
- For team secretaries, a button "Submit unsolicited review" will now
appear next to "Request review" on the document's main page.
- If the secretary is a secretary for multiple teams, they are taken
through an intermediate page to select for which team they are
submitting their review.
- The form is similar (and using the same code) as the usual review
completion, with a few extra fields for the review type and reviewer,
which would usually already be known.
- When submitting the review, a ReviewRequest and ReviewAssignment are
automatically created. The assignment is then immediately closed in
the usual way.
- Other workflows are unchanged.
The issues with the review form in #2061 are slightly worse for the
unsolicited review scenario, but that will be improved when #2061 is
fixed.
Commit ready for merge.
- Legacy-Id: 16924
Add quotes around document name in the mailarchive search link on a document's main page. Fixes#2659.
- Legacy-Id: 16606
Note: SVN reference [16569] has been migrated to Git commit b4a40313c95511693ae8a361aabb355878555fb7
This could be used to point to a document source repository, to extracted
yang module files, document wikis, and other relevant resources.
- Legacy-Id: 14166
addition to the existing 'pyang' checker.
Added modal overlay displays showing the yang check results every place the
yin/yang symbol is shown (red or green) to indicate the presencee and result
of yang checks. Added a Yang Validation: line in the document
meta-information section on the document's page in the datatracker.
Added the result of the xym extaction to the yang check results, to make
extration failures visible.
Added the version of the used xym, pyang, and yanglint commands to the check
results.
Added an action to move successfully extracted and validated modules to the
module library directories immediately on submission.
Added the xym and pyang repositories as svn:external components, rather than
listing them in requirements.txt, as there has been delays of many months
between essential features in the repositories, and an actual release. We may
get occasional buildbot failures if broken code is pulled in from the
repository, but better that than the functionality failure of severely
outdated componets.
Added a new management command to re-run yang validation for active drafts for
which yang modules were found at submission time, in order to pick up imported
models which may have arrived in the model libraries after the draft's
submission. Run daily from bin/daily.
Added a table to hold version information for external commands. The yang
checker output should include the version information of the used checkers,
but seems unnecessary to run each command with its --version switch every
time we check a module...
Added a new management command to collect version information for external
commands on demand. To be run daily from bin/daily.
Added tests to verify that xym, pyang and yanglint information is available
on the submission confirmation page, and updated the yang module contained in
the test document to validate under both pyang and yanglint.
Updated admin.py and resource.py files as needed.
- Legacy-Id: 13630
using the htmlization code previously developed for tools.ietf.org. As the
generation of the htmlized page is a bit too costly to do on the fly for
often-referenced drafts and RFCs, the part of each page which contains the
htmlized document is cached on file with a cache time of 2 weeks.
Changed all links which pointed to the htmlized version on tools to instead
point at the datatracker htmlized document.
Tweaked some URLs which didn't permit retrieval of intermediate-rev-charters.
Narrowed the pattern for document names to disallow dots in names, and
instead explicitly enumerated the few historical draftw with dots in the
name.
Added a file-system cache for the htmlized documents, and specified a
max_entries value for caches, overriding the default 300 entries.
Tweaked the code for new author email entries to provide a time if missing
in an updated entry.
Changed links in various email templates which pointed at tools.ietf.org
pages to instead point at datatracker pages, where appropriate.
Changed the search result rows to provide links to both the current meta-
information document pages (with a (i) info symbol) and to the new htmlized
document pages.
- Legacy-Id: 13040
in order to autogenerate dotted path url pattern names. Updated a number
of url reverses to use dotted path, and removed explicit url pattern names
as needed.
Changed some imports to prevent import of ietf.urls before django
initialization was complete.
Changed 3 cases of form classes being curried to functions; django 1.10
didn't accept that.
Started converting old-style middleware classes to new-style middleware
functions (incomplete).
Tweaked a nomcom decorator to preserve function names and attributes, like
a good decorator should.
Replaced the removed django templatetag 'removetags' with our own version
which uses bleach, and does sanitizing in addition to removing explicitly
mentionied html tags.
Rewrote the filename argument handling in a management command which had
broken with the upgrade.
- Legacy-Id: 12818
DocumentAuthor, rename author field to email and make it optional (for
modeling old email-less submissions), remove the authors many to many
referencing field from Document as it is not really pointing the right
place.
Update the Secretariat tools to show affiliation and country.
Add migration for getting rid of the fake email addresses that the
migration script created some years ago (just set the author email
field to null).
- Legacy-Id: 12739
document associated - that shouldn't really happen, but the importer
doesn't import reviews yet and we don't have content for all the old
reviews.
- Legacy-Id: 11509
review requests page.
Add importer for importing review data from the existing Perl tool
(WIP, gets most but not all of the interesting information out).
Fix various bugs.
- Legacy-Id: 11508
enter/upload content or retrieve it from an IETF mailarch archive
through integrated searching support. Support for partial completion.
- Legacy-Id: 11360
Added in support for displaying results from selected submission checks as symbols on draft pages and in draft lists. For now, that means that drafts with yang modules will show either a green or orange yang symbol, depending on the result of the submission yang validation check.
- Legacy-Id: 10996
Turn the shepherd management buttons back on for the ISE. Fixes#1925.
- Legacy-Id: 10977
Note: SVN reference [10974] has been migrated to Git commit 02af06c935
