Commit graph

2117 commits

Author SHA1 Message Date
Robert Sparks 90ca856afa
chore: repair damage from bulk changes 2023-08-18 13:44:05 -05:00
Lars Eggert aa955f0e9b
fix: Replace deprecated bootstrap CSS classes with 5.3 ones (#6166)
* fix: Replace deprecated bootstrap CSS classes with 5.3 ones

* Fix test

* Remove debug print
2023-08-18 13:41:02 -05:00
Robert Sparks 823281ba6c
chore: first pass at clearing out canonical_name 2023-08-18 10:59:55 -05:00
Robert Sparks 3b067a468a
fix: name corrections, flake removal 2023-08-17 16:34:26 -05:00
Robert Sparks 22dc5b6dc7
chore: cleanup typos 2023-08-17 16:24:22 -05:00
Robert Sparks 383899c5c4
chore: checkpoint: docalias mostly removed 2023-08-15 16:49:17 -05:00
Robert Sparks 4946430159
chore: checkpoint: halfway through removing docalias 2023-08-15 09:11:53 -05:00
Lars Eggert 57f23f5198
chore: feat/dark-mode <- main (#6103)
* chore: Remove unused "rendertest" stuff (#6015)

* fix: restore ability to create status change documents (#5963)

* fix: restore ability to create status change documents

Fixes #5962

* chore: address review comment

* fix: Provide human-friendly status in submission status API response (#6011)

Co-authored-by: nectostr <bastinda96@gmail.com>

* fix: Make name/email lookups case-insensitive (#5972) (#6007)

* fix: Make name/email lookups case-insensitive (#5972)

Use icontains so that looking up name or email is case insensitive
Added a test

Fixes: 5972

* fix: Use __iexact not __icontains

* fix: Clarify no-action-needed (#5918) (#6020)

When a draft is submitted for manual processing, clarify that
no action is needed; the Secretariat has the next steps.

Fixes: #5918

* fix: Fix menu hover issue (#6019)

* fix: Fix menu hover issue

Fixes #5702

* Fix leftmenu hover issue

* fix: Server error from api_get_session_materials() (#6025)

Fixes #5877

* fix: Clarify Questionnaire label (#4688) (#6017)

When filtering nominees, `Questionnaire` implies `Accepted == yes`
so fix the dropdown test tosay that.

Fixes: #4688

* chore: Merge from @martinthomson's rfc-txt-html (#6023)

* fix:no history entry when changing RFC Editor note for doc (#6021)

* fix:no history entry when changing RFC Editor note for doc

* fix:no history entry when changing RFC Editor note for doc

---------

Co-authored-by: Priyanka Narkar <priyankanarkar@dhcp-91f8.meeting.ietf.org>

* fix: avoid deprecation warning on view_list() for objs without CommunityList

Fixes #5942

* fix: return 404 for non-existing revisions (#6014)

* fix: return 404 for non-existing revisions
Links to non-existing revisions to docs should return 404

* fix: change rfc/rev and search behaviour

* refactor: fix tab level

* fix: return 404 for rfc revision for bibtex

* fix: provide date for revisions in bibtex output (#6029)

* fix: provide date for revisions in bibtex output

* refactor: change walrus to if's

* fix: specify particular revision for events

* fix: review refactoring issue

fixes #5447

* fix:  Remove automatically suggested document for document that is already has review request (fixes #3211) (#5425)

* Added check that if there is already review request for the document
in question, ignore the automatic suggestion for that document.
Fixes #3211.

* fix: dont block on open requests for a previous version. Add tests

---------

Co-authored-by: Nicolas Giard <github@ngpixel.com>
Co-authored-by: Robert Sparks <rjsparks@nostrum.com>

* feat: IAB statements (#5940)

* feat: support iab and iesg statements. Import iab statements. (#5895)

* feat: infrastructure for statements doctype

* chore: basic test framework

* feat: basic statement document view

* feat: show replaced statements

* chore: black

* fix: state help for statements

* fix: cleanout non-relevant email expansions

* feat: import iab statements, provide group statements tab

* fix: guard against running import twice

* feat: build redirect csv for iab statements

* fix: set document state on import

* feat: show published date on main doc view

* feat: handle pdf statements

* feat: create new and update statements

* chore: copyright block updates

* chore: remove flakes

* chore: black

* feat: add edit/new buttons for the secretariat

* fix: address PR #5895 review comments

* fix: pin pydantic until inflect catches up (#5901) (#5902)

* chore: re-un-pin pydantic

* feat: include submitter in email about submitted slides (#6033)

* feat: include submitter in email about submitted slides

fixes #6031

* chore: remove unintended whitespace change

* chore(dev): update .vscode/settings.json with new taskExplorer settings

* fix: Add editorial stream to proceedings (#6027)

* fix: Add editorial stream to proceedings

Fixes #5717

* fix: Move editorial stream after the irtf in proceedings

* fix: Add editorial stream to meeting materials (#6047)

Fixes #6042

* fix: Shows requested reviews for doc fixes (#6022)

* Fix: Shows requested reviews for doc

* Changed template includes to only give required variables to them.

* feat: allow openId to choose an unactive email if there are none active (#6041)

* feat: allow openId to choose an unactive email if there are no active ones

* chore: correct typo

* chore: rename unactive to inactive

* fix: Make review table more responsive (#6053)

* fix: Improve layout of review table

* Progress

* Progress

* Final changes

* Fix tests

* Remove fluff

* Undo commits

* ci: add --validate-html-harder to tests

* ci: add  --validate-html-harder to build.yml workflow

* fix: Set colspan to actual number of columns (#6069)

* fix: Clean up view_feedback_pending (#6070)

- Remove "Unclassified" column header, which caused misalignment in the table body.

- Show the message author - previously displayed as `(None)`.

* docs: Update LICENSE year

* fix: Remove IESG state edit button when state is 'dead' (#6051) (#6065)

* fix: Correctly order "last call requested" column in the IESG dashboard (#6079)

* ci: update dev sandbox init script to start memcached

* feat: Reclassify nomcom feedback (#6002)

* fix: Clean up view_feedback_pending

- Remove "Unclassified" column header, which caused misalignment in the table body.

- Show the message author - previously displayed as `(None)`.

* feat: Reclassify nomcom feedback (#4669)

- There's a new `Chair/Advisor Tasks` menu item `Reclassify feedback`.

- I overloaded `view_feedback*` URLs with a `?reclassify` parameter.

- This adds a checkbox to each feedback message, and a `Reclassify` button
at the bottom of each feedback page.

- "Reclassifying" basically de-classifies the feedback, and punts it back
to the "Pending emails" view for reclassification.

- If a feedback has been applied to multiple nominees, declassifying it
from one nominee removes it from all.

* fix: Remove unused local variables

* fix: Fix some missing and mis-nested html

* test: Add tests for reclassifying feedback

* refactor: Substantial redesign of feedback reclassification

- Break out reclassify_feedback* as their own URLs and views,
  and revert changes to view_feedback*.html.

- Replace checkboxes with a Reclassify button on each message.

* fix: Remember to clear the feedback associations when reclassifying

* feat: Add an 'Overcome by events' feedback type

* refactor: When invoking reclassification from a view-feedback page, load the corresponding reclassify-feedback page

* fix: De-conflict migration with 0004_statements

Also change the coding style to match, and add a reverse migration.

* fix: Fix a test case to account for new feedback type

* fix: 842e730 broke the Back button

* refactor: Reclassify feedback directly instead of putting it back in the work queue

* fix: Adjust tests to new workflow

* refactor: Further refine reclassification to avoid redirects

* refactor: Impose a FeedbackTypeName ordering

Also add FeedbackTypeName.legend field, rather than synthesizing it every
time we classify or reclassify feedback.

In the reclassification forms, only show the relevant feedback types.

* refactor: Merge reclassify_feedback_* back into view_feedback_*

This means the "Reclassify" button is always present, but eliminates some
complexity.

* refactor: Add filter(used=True) on FeedbackTypeName querysets

* refactor: Add the new FeedbackTypeName to the reclassification success message

* fix: Secure reclassification against rogue nomcom members

* fix: Print decoded key and fully clean up test nomcom (#6094)

* fix: Delete Person records when deleting a test nomcom

* fix: Decode test nomcom private key before printing

* test: Use correct time zone for test_statement_doc_view (#6064)

* chore(deps): update all npm dependencies for playwright (#6061)

Co-authored-by: depfu[bot] <23717796+depfu[bot]@users.noreply.github.com>

* chore(deps): update all npm dependencies for dev/diff (#6062)

Co-authored-by: depfu[bot] <23717796+depfu[bot]@users.noreply.github.com>

* chore(deps): update all npm dependencies for dev/coverage-action (#6063)

Co-authored-by: depfu[bot] <23717796+depfu[bot]@users.noreply.github.com>

* fix: Hash cache key for default memcached cache (#6089)

* feat: Show docs that an AD hasn't balloted on that need ballots to progress (#6075)

* fix(doc): Unify help texts for document states (#6060)

* Fix IESG State help text link (only)

* Intermediate checkpoint

* Correct URL filtering of state descriptions

* Unify help texts for document states

* Remove redundant load static from template

---------

Co-authored-by: Robert Sparks <rjsparks@nostrum.com>

* ci: fix sandbox start.sh memcached user

* fix: refactor how settings handles cache definitions (#6099)

* fix: refactor how settings handles cache definitions

* chore: more english-speaker readable expression

* fix: Cast cache key to str before calling encode (#6100)

---------

Co-authored-by: Robert Sparks <rjsparks@nostrum.com>
Co-authored-by: Liubov Kurafeeva <liubov.kurafeeva@gmail.com>
Co-authored-by: nectostr <bastinda96@gmail.com>
Co-authored-by: Rich Salz <rsalz@akamai.com>
Co-authored-by: PriyankaN <priyanka@amsl.com>
Co-authored-by: Priyanka Narkar <priyankanarkar@dhcp-91f8.meeting.ietf.org>
Co-authored-by: Ali <alireza83@gmail.com>
Co-authored-by: Roman Beltiukov <maybe.hello.world@gmail.com>
Co-authored-by: Tero Kivinen <kivinen@iki.fi>
Co-authored-by: Nicolas Giard <github@ngpixel.com>
Co-authored-by: Kesara Rathnayake <kesara@fq.nz>
Co-authored-by: Jennifer Richards <jennifer@staff.ietf.org>
Co-authored-by: Paul Selkirk <paul@painless-security.com>
Co-authored-by: depfu[bot] <23717796+depfu[bot]@users.noreply.github.com>
Co-authored-by: Jim Fenton <fenton@bluepopcorn.net>
2023-08-10 09:49:15 -05:00
Jennifer Richards a867de25b0
test: Remove setup that does not apply to rfc docs (#6082)
* test: Remove setup that does not apply to rfc docs

* style: Run black on test_document_bibtex()
2023-08-08 13:34:11 -03:00
Jennifer Richards 015d64bef3
test: RelatedDocument target is now Document 2023-08-04 20:55:40 -03:00
Jennifer Richards 2d46a978e0
chore: Renumber migrations 2023-08-04 00:42:16 -03:00
Jennifer Richards 48d4072eeb
Merge branch 'feat/rfc' into main-merge
# Conflicts:
#	ietf/doc/factories.py
#	ietf/doc/tests_status_change.py
#	ietf/name/fixtures/names.json
#	ietf/templates/doc/document_info.html
2023-08-03 18:34:06 -03:00
Jennifer Richards 34378b9c74
chore: Remove duplicate entry in admin search_fields 2023-07-28 10:57:55 -07:00
Tero Kivinen b24dd4427b
fix: Shows requested reviews for doc fixes (#6022)
* Fix: Shows requested reviews for doc

* Changed template includes to only give required variables to them.
2023-07-25 07:59:45 -07:00
Robert Sparks 19141d51e0
chore: reorder migrations 2023-07-23 16:37:21 -07:00
Robert Sparks dbe1749438
feat: IAB statements (#5940)
* feat: support iab and iesg statements. Import iab statements. (#5895)

* feat: infrastructure for statements doctype

* chore: basic test framework

* feat: basic statement document view

* feat: show replaced statements

* chore: black

* fix: state help for statements

* fix: cleanout non-relevant email expansions

* feat: import iab statements, provide group statements tab

* fix: guard against running import twice

* feat: build redirect csv for iab statements

* fix: set document state on import

* feat: show published date on main doc view

* feat: handle pdf statements

* feat: create new and update statements

* chore: copyright block updates

* chore: remove flakes

* chore: black

* feat: add edit/new buttons for the secretariat

* fix: address PR #5895 review comments

* fix: pin pydantic until inflect catches up (#5901) (#5902)

* chore: re-un-pin pydantic
2023-07-23 11:00:24 -07:00
Lars Eggert 1d22e39a52
fix: Use icons in addition to colors for review-related badges (#6012)
* fix: Use icons in addition to colors for review-related badges

* Remove comment

* Remove debug print
2023-07-23 10:09:16 -07:00
Tero Kivinen 14b4f82239
fix: review refactoring issue
fixes #5447
2023-07-23 09:58:01 -07:00
Roman Beltiukov 001719b3b5
fix: provide date for revisions in bibtex output (#6029)
* fix: provide date for revisions in bibtex output

* refactor: change walrus to if's

* fix: specify particular revision for events
2023-07-23 09:21:16 -07:00
Roman Beltiukov 4d611706d4
fix: return 404 for non-existing revisions (#6014)
* fix: return 404 for non-existing revisions
Links to non-existing revisions to docs should return 404

* fix: change rfc/rev and search behaviour

* refactor: fix tab level

* fix: return 404 for rfc revision for bibtex
2023-07-23 09:16:12 -07:00
PriyankaN 00c0389c1f
fix:no history entry when changing RFC Editor note for doc (#6021)
* fix:no history entry when changing RFC Editor note for doc

* fix:no history entry when changing RFC Editor note for doc

---------

Co-authored-by: Priyanka Narkar <priyankanarkar@dhcp-91f8.meeting.ietf.org>
2023-07-22 17:33:11 -07:00
Robert Sparks f82988d8b7
fix: restore ability to create status change documents (#5963)
* fix: restore ability to create status change documents

Fixes #5962

* chore: address review comment
2023-07-22 12:40:38 -07:00
Robert Sparks 4ec22dae19
Merge branch 'main' into feat/dark-mode 2023-07-22 13:49:24 -05:00
Lars Eggert 3a47871f5e
fix: More dark mode fixes (#6001)
* fix: More small dark mode fixes

* "badge rounded-pill bg-" -> "badge rounded-pill text-bg-"

This sets the text color correctly for more readable badges.

* Same for cards

* Fix tests
2023-07-20 13:48:52 -05:00
Robert Sparks 2593c0396b
chore: style fixes 2023-07-20 13:40:09 -05:00
Robert Sparks c8684f727a
Merge branch 'main' into related_no_alias 2023-07-20 09:31:52 -05:00
Robert Sparks 81734443a5
fix: continued repair of code/tests re: RelatedDocument model change 2023-07-20 09:25:14 -05:00
Robert Sparks f52d0ddcf8
test: verify newsubmissiondocevent count by day is correct (#6000) 2023-07-20 08:53:23 -05:00
Jennifer Richards ba356397c0
fix: Specify UTC for TruncDate (#5996) 2023-07-20 08:29:30 -05:00
Robert Sparks 59c0a1f7f9
chore: repair merge damage 2023-07-19 18:09:23 -05:00
Robert Sparks cf3a270cd2
Merge branch 'feat/rfc' into related_no_alias 2023-07-19 17:48:22 -05:00
Robert Sparks a20d1f4d9b
Merge remote-tracking branch 'ietf-tools/main' into feat/dark-mode 2023-07-19 12:18:07 -05:00
Jennifer Richards 9bf0063f11
fix: Preserve Document.time when migrating rfcs (#5954) 2023-07-12 11:02:12 -05:00
Robert Sparks 6305555480
chore: address pyflake issues 2023-07-10 14:41:45 -05:00
Robert Sparks b8febcb7a3
test: adjusted fuzzy_find_document_rfc test 2023-07-08 09:42:52 -05:00
Robert Sparks 0b9d450a3e
test: adjust status change test to reflect rfc target 2023-07-07 17:55:50 -05:00
Robert Sparks d4f5bc6707
fix: make factory name derivation better. Adjust status_change test 2023-07-07 17:48:00 -05:00
Robert Sparks 2c6fe0383c
fix: adjust gating of review requests 2023-07-07 17:31:24 -05:00
Robert Sparks ffb11fd0c1
fix: downref form validation 2023-07-07 17:15:39 -05:00
Robert Sparks 09f0710e77
test: correct use of factories for downref tests 2023-07-07 17:02:16 -05:00
Robert Sparks 632293d369
fix: repaired RelatedDocument is_downref and is_approved_downref methods 2023-07-07 16:14:18 -05:00
Robert Sparks ff058e3c63
test: repair draft_group_link test 2023-07-07 14:03:16 -05:00
Robert Sparks d3f1794fd4
chore: apply black to GenerateDraftAliasesTests 2023-07-07 13:53:37 -05:00
Robert Sparks 78b6f06519
fix: repair generate_draft_aliases 2023-07-07 13:47:50 -05:00
Robert Sparks 11ec3685c4
fix: repaired idnits2_state 2023-07-07 13:10:52 -05:00
Robert Sparks e6a1a17973
fix: typo/logic error in get_base_name 2023-07-07 12:56:23 -05:00
Robert Sparks f30613973c
test: repair pdfized tests 2023-07-07 12:32:48 -05:00
Robert Sparks 06e711288a
test: adjusted RawIdTests 2023-07-07 11:31:11 -05:00
Robert Sparks 8b1fcfdbdd
fix: repair views_search.index_all_drafts 2023-07-07 11:22:44 -05:00
Robert Sparks 6eeffb116f
fix: become agnostic about RFC states until we care 2023-07-07 10:33:29 -05:00
Robert Sparks f7d9e49731
test: pass a correct type 2023-07-07 10:30:57 -05:00
Jennifer Richards 117e07e5ff
Merge pull request #5935 from rjsparks/fixups3
fix: repair various doc view and tests
2023-07-07 11:47:13 -03:00
Robert Sparks 285b11a053
fix: better use of factory 2023-07-07 09:32:29 -05:00
Paul Selkirk bae204862d
feat: Add bibxml button to document info page (#5921)
* feat: Add bibxml button to document info page (#5908)

* fix: No bibxml for RFCs
2023-07-07 08:23:15 -05:00
Robert Sparks a3c87a1945
fix: repaired rfc_feed 2023-07-06 17:43:40 -05:00
Robert Sparks 3486f38421
fix: adjust (useless) assertion in status_change test to reflect that the relevant relation points to an RFC 2023-07-06 17:31:11 -05:00
Robert Sparks 799d3a1a3e
fix: adjusted bibtex view and tests 2023-07-06 17:24:05 -05:00
Robert Sparks 400280e50c
fix: repair test_history_bis_00 2023-07-06 16:05:10 -05:00
Jennifer Richards fc284be6d8
fix: Deal with rfc doc types for references/referenced_by views 2023-07-06 17:44:32 -03:00
Jennifer Richards 9f1b05a518
chore: Move/copy RelatedDocuments to rfcs 2023-07-06 17:44:28 -03:00
Jennifer Richards 563b5a9fe2
chore: Migrate RelatedDocuments for RFCs 2023-07-06 17:44:24 -03:00
Robert Sparks f53a849660
fix: various corrections to rfc main document view and tests (#5931) 2023-07-06 17:24:35 -03:00
Robert Sparks 63a9920685
fix: restored where an rfc came from to the main rfc view (#5930) 2023-07-06 15:11:26 -03:00
Jennifer Richards 8f0b459050
refactor: Replace is_rfc() tests (#5925)
* refactor: Remove is_rfc() - test type_id instead

* fix: Guard against unknown pub_date

This should not ever come up - we have a published_rfc event for
every rfc. Should investigate fixing pub_date() to always return a val.
2023-07-06 12:07:53 -03:00
Jennifer Richards 5d9d87897d
fix: Show rfc documents via document_main view (#5919)
* fix: Fix friendly_state() for drafts in rfc state

* refactor: Change became-rfc to became_rfc for consistency

* refactor: Begin handling RFCs separatly in document_main

WIP

* chore: Hide reviews and conflict reviews for RFCs

* chore: Remove irrelevant fields from rfc doc view

* chore: Remove unused variables

* chore: Remove "Versions" field from document_rfc.html

* chore: Hide "Nits" button for RFC documents
2023-07-05 17:30:20 -03:00
Jennifer Richards d87ffb6912
Merge pull request #5912 from ietf-tools/main
chore: Merge main into feat/rfc
2023-07-04 12:09:46 -03:00
Jennifer Richards 771296bbe6
feat: Link rfc/draft document history pages (#5894)
* fix: Do not show "rev" column for rfc document history

* style: Reformat document_history() using Black

* refactor: Use "is not None" instead of "!= None"

* refactor: Convert dict() to dict literal

* fix: Migrate group, stream, and ad from draft to rfc Document

* feat: Link rfc/draft history pages
2023-06-28 17:51:31 -03:00
Jennifer Richards bff145f975
fix: Create relationships between draft and rfc Documents (#5890)
* fix: Create RelatedDocument between draft and rfc Documents

* chore: Improve comment

* refactor: Clarify migration
2023-06-28 11:41:08 -03:00
Jennifer Richards 877bc02d77
refactor: Refactor build_file_urls() (#5886) 2023-06-27 11:14:19 -03:00
Robert Sparks e910836ad4
fix: teach build_file_urls about rfc type documents. (#5880) 2023-06-26 21:33:02 -03:00
Robert Sparks 75d199fe31
chore: correct merge errors 2023-06-26 13:14:31 -05:00
Robert Sparks ad0071fd7d
chore: merge feat/rfc 2023-06-26 13:12:15 -05:00
Robert Sparks 69f882d833
chore: tweaks for rebuild_reference_relations 2023-06-26 13:03:59 -05:00
Jennifer Richards 106c67ec95
feat: Migrate docevents onto rfc documents (#5872)
* refactor: Separately migrate DocAliases to rfc Documents

The gap in numbering is intentional, another migration will be along
shortly.

* feat: Migrate docevents onto rfc documents

* chore: Refining DocEvent migration (WIP)

* chore: Move IANA Action state change docevents to rfc docs

* chore: Fix typo

* refactor: Eliminate "created" rfc state

* chore: Leave "ballot set" comments on drafts
2023-06-23 17:16:04 -03:00
Lars Eggert f250a653a2
fix: Remove IESG-related about tabs from non-IETF-stream docs (#5515)
* fix: Remove IESG-related about tabs from non-IETF-stream docs

Fixes #5514

* Fix code review comments

* Address review comments

* Address code review comments
2023-06-22 10:35:59 -05:00
Jennifer Richards f2c2957925
refactor: Represent RFCs as their own DocType (#5835)
* feat: Add RFC DocTypeName, StateType, and States

* refactor: Rename rfc_number() to deprecated_rfc_number()

* feat: Add rfc_number field to DocInfo

* feat: Add DocRelationshipName "became-rfc"

* chore: First-pass migration to create rfc Documents

* chore: create_rfc_documents migration depends on new names

* refactor: Rename variable

* fix: Fix revname / downcase name for "became-rfc" DocRelationshipName

* chore: Remove debugging print statements

* feat: Point rfc aliases at rfc Documents

* test: Refactor RFC factories

* refactor: Rewrite is_rfc() in terms of type_id

* test: Use RfcFactory as base for IndividualRfcFactory

* refactor: Replace calls to deprecated_rfc_number()

* refactor: Remove deprecated_rfc_number() method

* test: Import WgRfcFactory
2023-06-20 15:28:16 -03:00
Lars Eggert a6cc12c14b
fix: Don't (re)sort obsoleted/updated info (#5391)
* fix: Don't (re)sort obsoleted/updated info

Rebased against feat/postgres

* Update ietf/doc/utils_search.py

Co-authored-by: Robert Sparks <rjsparks@nostrum.com>

* Update ietf/doc/utils_search.py

Co-authored-by: Robert Sparks <rjsparks@nostrum.com>

* Update ietf/doc/utils_search.py

Co-authored-by: Robert Sparks <rjsparks@nostrum.com>

* Fix review comments

---------

Co-authored-by: Robert Sparks <rjsparks@nostrum.com>
2023-06-20 12:07:45 -05:00
Robert Sparks 8ff14419c2
chore: continued refactoring 2023-06-16 16:59:20 -05:00
Robert Sparks 3c016cc5c8
feat: v3-era aware feed for rfcs (#5828)
* feat: v3-era aware feed for rfcs

* chore: remove obviated comment

* test: improve rfc feed tests
2023-06-16 15:52:42 -05:00
Robert Sparks d6f58b3e67
chore: use more expressive related_name 2023-06-16 15:26:52 -05:00
Robert Sparks f3566c2743
chore: include (nontrivial) migrations 2023-06-16 15:07:51 -05:00
Robert Sparks 769d85a6c4
chore: explore architecture change in RelatedDocument 2023-06-16 14:58:42 -05:00
Jennifer Richards c8dcda0fae
refactor: Do not use canonical_name() for charters (#5818)
* fix: Enforce naming of charter docs in submit()

* style: Reformat submit() with Black

* refactor: Remove redundant check of charter name

* style: Reformat charter_with_milestones_txt with Black

* refactor: Drop canonical_name, use Path in charter_with_milestones_txt

* style: Reformat review_announcement_text() with Black

* style: Reformat action_announcement_text() with Black

* refactor: Change uses of charter.canonical_name() to charter.name

* refactor: Skip docialias when retrieving charter

* refactor: Change canonical_name() to name in utils_charter.py

* refactor: Use Path in read_charter_text()

* refactor: Drop canonical_name, minor refactor of tests_charter.py

* refactor: charter.name instead of canonical_name in milestones.py

* refactor: charter.name instead of canonical_name in tests_info.py

* refactor: Remove unused functions in ietf/secr/utils/groups.py

* refactor: charter.canonical_name -> charter.name in templates

* refactor: Remove charter handling from canonical_name

Temporarily raise an exception for testing

* refactor: Refactor get_charter_text() without canonical_name

* refactor: Remove raise when canonical_name called on a charter

* fix: Add back missing ".txt" extension

* test: Test rejection of invalid charter names
2023-06-14 08:32:21 -05:00
Robert Sparks 772b6e8c3c
Merge branch 'main' into feat/dark-mode 2023-06-13 13:37:04 -05:00
Guillaume Ayoub 2e5c9ed160
fix: use v59.0 options for WeasyPrint (#5713) 2023-06-09 12:54:35 -05:00
Robert Sparks 88a878fd61
Merge pull request #5774 from rjsparks/dont_come_around_here_no_more
chore: remove unused mgmt commands
2023-06-08 13:35:50 -05:00
Robert Sparks d6da25a448
fix: better caching of search results (#5782) 2023-06-07 16:25:19 -05:00
Robert Sparks 0864b73aab
fix: use slowpages to cache doc/active (#5781) 2023-06-07 15:35:17 -05:00
Robert Sparks 18941434c3
chore: remove unused mgmt commands 2023-06-06 16:12:35 -05:00
Nicolas Giard cfaf966492
fix: add internal static.ietf.org var for pdfized render (#5765) 2023-06-05 20:18:35 -05:00
Lars Eggert f850061dff
Fix switching in HTMLized view 2023-06-02 11:43:53 +03:00
Jennifer Richards 3015359323
test: Use QuerySetAny alias for QuerySet type checks 2023-05-31 11:09:08 -03:00
Jennifer Richards 1922a6066e
Merge pull request #5700 from ietf-tools/main
chore: main -> django4
2023-05-31 10:59:09 -03:00
Nicolas Giard 0a11892414
chore: use variable for static.ietf.org references (#5692) 2023-05-25 17:23:18 -05:00
Lars Eggert 5f4dfb87b6
fix: Use new fonts for PDFization (#5688) 2023-05-25 09:43:15 -05:00
Robert Sparks 6178519d43
fix: optimize queries for DocumentChangesFeed (#5675) 2023-05-23 10:14:13 -05:00
Jennifer Richards 58182fd7f6
test: Fix selectors in selenium tests 2023-05-19 17:54:24 -03:00
Jennifer Richards 93e9f8e850
fix: Do not set update_fields when saving new instance 2023-05-19 14:36:08 -03:00
Jennifer Richards 39a854fa1a
fix: Use arbitrary date in the past instead of datetime.min 2023-05-18 18:36:38 -03:00
Jennifer Richards cdec6cc0aa
Merge pull request #5655 from ietf-tools/main
chore: Merge main into feat/django4
2023-05-18 15:15:42 -03:00
Robert Sparks f9322391dd
fix: change trac.ietf.org links to what they redirect to now (#5651) 2023-05-18 08:31:54 -05:00
Robert Sparks 38bab2575e
fix: better htmlized access to uncurrent revisions (#5639) 2023-05-16 17:08:18 -05:00
Jennifer Richards 223c679942
chore: Add no-op migration to satisfy Django bookkeeping changes 2023-05-16 17:48:44 -03:00
Jennifer Richards 7475aa01b6
Merge pull request #5634 from ietf-tools/main
chore: Merge main into feat/django4
2023-05-16 13:06:49 -03:00
Robert Sparks c16a9d6cb5
fix: better area links from the menus (#5620)
* fix: better area links from the menus

* chore: remove debugging line
2023-05-15 16:41:42 -05:00
Robert Sparks 962af9feb3
fix: tweak removal of document info order (#5624)
* fix: tweak removal of document info order

* chore: add copyright line

* chore: correct dependencies
2023-05-15 13:20:59 -05:00
Jennifer Richards 0319f35e0f
test: Use Django 3.2 HttpResponse.headers API 2023-05-15 13:01:59 -03:00
Peter Yee 369fe0dfe5
fix: remove order from DocumentInfo as apparently unneeded (fixes #5245) (#5417)
* fix: remove order from DocumentInfo as apparently unneeded (fixes #5245)

Fixes #5245. Includes migration, however I did not test the reverse.

* Merge branch 'main' into pr/Spectre17/5417

* chore: Renumber migrations

* Revert "Merge branch 'main' into pr/Spectre17/5417"

This reverts commit 77b4a46f84e9ece6778dec6e8127aedad71c2625.

---------

Co-authored-by: Jennifer Richards <jennifer@staff.ietf.org>
Co-authored-by: Robert Sparks <rjsparks@nostrum.com>
2023-05-15 10:35:54 -05:00
Jennifer Richards cbb946455f
test: Remove unused assignment that caused a mypy error 2023-05-15 11:25:38 -03:00
Jennifer Richards 7ad74c99e4
refactor: import from django.urls instead of django.conf.urls 2023-05-12 20:29:11 -03:00
Jennifer Richards 79b749fcdf
style: Restyle method using Black 2023-05-12 18:36:05 -03:00
Jennifer Richards 21004864b0
refactor: Replace deprecated is_safe_url with new name 2023-05-12 18:35:12 -03:00
Jennifer Richards 075aed7e9a
refactor: Replace deprecated request.is_ajax() 2023-05-12 18:26:56 -03:00
Jennifer Richards d0cb46d320
fix: Use TruncDate instead of QuerySet.extra() 2023-05-12 15:47:37 -03:00
Jennifer Richards 96396b833c
Merge pull request #5611 from ietf-tools/main
chore: merge main into feat/django4
2023-05-12 11:05:57 -03:00
Robert Sparks 1afdb0b7cc
fix: show htmlized views of draft revisions without DocHistory (#5599)
* fix: show htmlized views of draft revisions without DocHistory

* fix: handle htmlized views of rfcs corectly
2023-05-11 17:15:01 -05:00
Jennifer Richards 264ff60cd2
Merge pull request #5601 from jennifer-richards/django4
chore: Upgrade to Django 3.0
2023-05-11 11:04:36 -04:00
Jennifer Richards 4f443cc445
refactor: Explicitly allow name=None for a couple of views 2023-05-10 17:16:20 -03:00
Robert Sparks f8113cb862
fix: close open things (#5593)
* fix: close open things

* fix: clean up test created files

* fix: remove one close too many
2023-05-10 11:19:34 -05:00
Jennifer Richards da168395fc
refactor: Replace deprecated smart_text with smart_str 2023-05-09 15:23:33 -03:00
Jennifer Richards 07e26dd52e
refactor: Replace deprecated force_text with force_str 2023-05-09 15:21:50 -03:00
Eliot Lear 8af8a91c20
fix: allow ISE to initiate conflict review (#5570)
* ISE may initiate conflict review

Add ISE to list of those roles who can initiate a conflict review.

* fix: improve conditional for conflict review action. Add tests.

* chore: fix comment typo

---------

Co-authored-by: Robert Sparks <rjsparks@nostrum.com>
2023-05-03 14:04:09 -05:00
Tero Kivinen d5bae45799
fix: Do not add user to the top of queue after reject (fixes #4505) (#5427)
* fix: Do not add user to the top of queue after reject (fixes #4505)
Added a checkbox in the reject review dialog to ask whether user
wants to be added to the top of the queue or not. Default is off.

* Do not change request_assignment_next if wants_to_be_next is not True.
Set the request_assignment_next also in LeastRecentlyUsedReviewerQueuePolicy
so it can be used to override the assignment policy rules (i.e., if
someone has once per month, but he rejects review with wants_to_be_next set
to true, he will get new assignment immediately, not after one month).

* Added wants_to_be_next to test cases too.

* Fixed test function prototypes, they can't have any parameters, only
self. Added test cases for test_return_reviewer_to_rotation_top both
for RotateAlphabeticallyReviewerQueuePolicyTest and
LeastRecentlyUsedReviewerQueuePolicyTest.
2023-03-30 08:34:08 +09:00
Robert Sparks 01b4a91bfe
Merge remote-tracking branch 'ietf-tools/main' into feat/postgres 2023-03-29 10:41:47 +09:00
Jennifer Richards 6b826fd985
refactor: Purge old migrations and update ci to build on a clean schema (#5431)
* refactor: Remove all existing migrations

* refactor: Create clean set of migrations

* chore: Skip check_statetype_slugs when DB is not yet populated

* fix: Do not cache active_groups_menu on module import

* fix: Do not patch timezone awareness out of oidc-provider

* refactor: Migrate to create postgres schema, only use pgloader for data

* ci: Use migration scripts from feat/pg-migrations branch

* Revert "ci: Use migration scripts from feat/pg-migrations branch"

This reverts commit c82f64c614241ccede4865a50d494725c8a47c15.

* ci: Run check before migrate

* fix: Remove redundant migration caused by merge error

* chore: Add casts/ALTER TABLEs to eliminate pgloader errors/warnings

* chore: Change schema name to match docker image assumptions

* chore: Clear out schema so we get a clean start in case of a retry
2023-03-28 18:06:07 +09:00
Ian Williams a778377bb8
fix(doc): Replace iconography for position's email status with text label (#5421)
* fix(doc): Use text badges for email status

BI's envelope icons with status icons are difficult to read.
Use text labels instead (keeping the same tooltip).

Fixes #3855.

* test(doc): Fix failing ballot message tests

Some ballot message changes have been modified to correctly identify
what type of document this ballot is for.

Works on #3855

* test(doc): Remove debugging statement

Accidental inclusion of debug statement.

Works on #3855
2023-03-27 13:58:51 +09:00
Lars Eggert b11f0fc50f
fix: Lengthen IESG dashboard trend period to 120 days (#5409)
Fixes #4450
2023-03-25 17:38:57 +09:00
Robert Sparks 88a78cf1ab
Merge remote-tracking branch 'ietf-tools/main' into feat/postgres 2023-03-20 13:46:32 -05:00
Ryan Cross b654b49d6b
refactor: Remove secr proceedings (#5256)
* refactor: remove import_audio_files() and related code

* refactor: move functions from proc_utils to meeting/utils

* refactor: remove secr/proceedings
2023-03-10 15:33:01 -06:00
Robert Sparks 4b4e876305
Merge branch 'main' into feat/postgres 2023-03-09 11:43:38 -06:00
Lars Eggert 4f9be6e8a0
fix: Restore correct operation of column sort headers. (#5253)
Fixes #5234. Was broken in c061caa.
2023-03-01 10:45:25 -06:00
Robert Sparks f010766654
Merge remote-tracking branch 'ietf-tools/main' into feat/postgres 2023-02-27 12:55:47 -06:00
Lars Eggert caf80efd84
feat: Prefill the abstract, shepherd and AD info into a ballot writeup (#5218)
* feat: Prefill the abstract, shepherd and AD info into a ballot writeup

* Suggestions from @rjsparks

* Remove instructions to add IANA Expert template.

* Make "notes" fields for various bodies conditioned on the doc stream
2023-02-27 12:19:39 -06:00
Lars Eggert 90b6cf4ba5
fix: Don't show replaced, expired or otherwise abandoned docs for AD (#5162)
* fix: Don't show replaced, expired or otherwise abandoned docs for AD

Fixes #5153 and #2889.

* Fix filter conditions

* Update ietf/doc/views_search.py

Co-authored-by: Robert Sparks <rjsparks@nostrum.com>

---------

Co-authored-by: Robert Sparks <rjsparks@nostrum.com>
2023-02-21 17:18:52 -06:00
Jennifer Richards dcdc4af3e0
feat: Use case-insensitive matching for document searches (#5166)
* fix: Use case insensitive match for group acronym in doc search

* fix: Use case insensitive match for doc.search_by_name view

* fix: Use case insensitive match for doc names in ipr.search view

* test: Test case insensitivity in doc search/search_for_name
2023-02-21 10:21:29 -06:00
Kesara Rathnayake f70ce3eaab
fix: Move rfcdiff-latest-json API call from /doc to /api (#5155)
Old /doc/rfcdiff-latest-json/ URL is changed to a permanent redirect to
/api/doc/rfcdiff-latest-json/
2023-02-17 10:39:47 -06:00
Robert Sparks 9ea8523e85
feat: add target to bibxml-ids (#5148) 2023-02-15 11:37:56 -06:00
Lars Eggert 182158b5c0
fix: Also extract document names from XML seriesInfo attributes and XInclude URLs (#5037)
* fix: Also extract document names from XML seriesInfo attributes

The old code only looked in the anchor string for the document names of
references, which doesn't work if the anchor uses a mnemonic. This caused lots
of missed references for many documents.

* No need to import lxml anymore

* Add tests

* Handle xinclude to bibxml URLs

* Wrap line

* Apply suggestion from @rjsparks

* Undo erroneous additions

* Address suggestion from @rjsparks
2023-02-14 17:07:54 -06:00
Robert Sparks e1206fa91e
Merge remote-tracking branch 'upstream/main' into feat/postgres 2023-02-13 09:17:05 -06:00
Lars Eggert 1ffe661f6c
fix: add_links_in_new_revision_events wasn't doing anything, remove (#5103)
* fix: `add_links_in_new_revision_events` wasn't doing anything, remove

Whatever `add_links_in_new_revision_events` was supposed to do, it didn't do it.
The linkification of things has been happening via the `format_history_text`
template tag.

* Remove import
2023-02-11 10:31:05 -06:00
Lars Eggert f8b48f4c43
fix: use Internet-Draft more consistently across the UI (#5104)
* s/Internet Draft/Internet-Draft/i

* s/draft/Internet-Draft/i or s/draft/I-D/i

* s/ID/I-D/

* Fix tests

* a -> an

* Undo case-change to ASCII

* Address code review comments

* Add migrations

* Add merged migration

* fix: straighten out migrations

* fix: finish straightening out migrations

---------

Co-authored-by: Robert Sparks <rjsparks@nostrum.com>
2023-02-11 10:09:28 -06:00
Lars Eggert 6a6a3db3b9
fix: Don't try to further linkify rfc2html output (#5112)
* fix: Don't try to further linkify rfc2html output

Fixes #5111

* Fix test
2023-02-10 14:33:54 -06:00
Robert Sparks 6bbad15b3d
fix: restore generation of rswg/rsab chair aliases (#5121) 2023-02-09 16:57:42 -06:00
Robert Sparks 2a1602d9bb
Merge remote-tracking branch 'origin/main' into feat/postgres 2023-01-31 16:57:03 -06:00
Robert Sparks afac1f8f19
feat: enable editorial stream adoption and balloting (#5011)
* feat: enable editorial stream adoption and balloting

* fix: bring tests into line with refactor

* feat: force intended_std_level to Informational when adopting into a non-ietf stream.

* fix: improve blocking position labels and email content

* fix: simplify pointer to group on doc main page for rswg docs

* fix: recover from merge typos

* fix: correct defer and clear ballot behavior

* fix: improve publication request access logic

* fix: clean up broken editorial state

* fix: adjust test to match migrations
2023-01-31 13:50:51 -06:00
Robert Sparks c04feb5765
Merge remote-tracking branch 'origin/main' into feat/postgres 2023-01-26 10:37:50 -06:00
Robert Sparks 5560c28c82
fix: only show irtf stream ballot and publication buttons to the IRTF chair (#5036) 2023-01-25 15:10:31 -06:00
Jennifer Richards c35afca507
test: Use DEADLINE_TZINFO to validate reminder due date calculation (#5019) 2023-01-23 18:05:53 -06:00
Robert Sparks 2351629fcc
Merge remote-tracking branch 'origin/main' into feat/postgres 2023-01-23 10:28:14 -06:00
Robert Sparks 3fb521eb53
fix: test on postgres. POST and check intended pks. (#4949)
* fix: test on postgres. post and check intended pks.

* fix: pass and check intended pks

* fix: pass intended pk

* fix: get an actually usable group type for test

* fix: use a review assignment pk instead of the review request pk

* fix: Use pks of sessions, not schedtimesessassignments

* fix: test for actual pk and do not rely on case-insensitive LIKE

* fix: test for actual pk

* chore: spelling correction: nomine -> nominee
2023-01-10 10:28:43 -06:00
Robert Sparks 0cc907f957
fix: restore display of additional resources (#4956) 2023-01-10 10:19:43 -06:00
Robert Sparks 0f35f5df3a
fix: handle names with endings that might parse as versions better (#4897)
* fix: Use the doc name matched by fuzzy_find_documents when rendering

Fixes #4855

* Follow suggestion by @rjsparks

* fix: handle names with endings that might parse as versions better

Co-authored-by: Lars Eggert <lars@eggert.org>
2022-12-20 08:16:08 -06:00
Jennifer Richards a8780dc439
test: fix (and simplify) changed email address generation (#4919) 2022-12-19 13:33:51 -06:00
Jennifer Richards 30f852179c
test: ensure author fields are actually changed by test (#4918) 2022-12-19 11:07:15 -06:00
Lars Eggert bc2b5f72ef
More fixes for HTMLization and PDFization (#4899)
* More fixes for HTMLization and PDFization

* Remove print

* More fixed from @martinthomson

* Hopefully fix #4885

* Apply suggestion from @rjsparks
2022-12-19 09:04:44 -06:00
Jennifer Richards 27469c1264
fix: do not create ReviewRequestDocEvent when assigning a review req (#4913)
* fix: do not create ReviewRequestDocEvent when assigning a review req

* test: test docevent creation
2022-12-16 15:17:10 -06:00
Lars Eggert ad5cf0bb01
fix: Fix layout issue in ballot modals on narrow screens (#4911)
* fix: Fix layout issue in ballot modals on narrow screens

Fixes #4902

* Also apply change to old positions

* Fix tests

* Use badge to indicate former ADs
2022-12-16 13:09:55 -06:00
Lars Eggert e6e0d8fc1a
feat: Diff arbitrary versions from new HTMLization page (#4863)
* feat: Diff arbitrary versions from new HTMLization page

Fixes #4859

* Rework this based on @rjsparks' suggestion. Not quite done yet.

* Progress

* Fix HTML

* Don't show compare buttons if there aren't at least two versions

* Remove spurious title attribute

* Use and style select2 for the version diff dropdowns

* Roll in code review suggestions

* Some tests!
2022-12-16 10:46:05 -06:00
Jennifer Richards 38748cb10b
refactor: add guards/type hints to build_file_urls() (#4896)
* refactor: add guards/type hints to build_file_urls()

* fix: compare doc.type_id, not doc.type, with string value

* test: add cursory test of build_file_urls()
2022-12-14 17:22:26 -06:00
Jennifer Richards 3d47a9069c
fix: eliminate race condition when creating a review Document (#4876) 2022-12-13 14:45:42 -06:00
Jennifer Richards 73fcf51709
fix: handle both rev is None and '' in document_main (#4887) 2022-12-13 12:22:43 -06:00
Lars Eggert 017b5f54d1
fix: Force font-size and line-height for plaintext PDFization (#4879)
Fixes #4343
2022-12-13 10:10:14 -06:00
Robert Sparks 572733d3f1
feat: validate the document notify field (#4856)
* feat: validate the document notify field

* chore: fix spelling in comment

* feat: be more explicit in notify validation, preserving input order.

* fix: restrict notify duplicate check to nameaddrs. Add tests.
2022-12-12 13:16:41 -06:00
Lars Eggert f870715a80
fix: Allow more email addresses in notification lists (#4792)
* fix: Allow more email addresses in notification lists

Fixes #4736

* Do what @rjsparks suggested

* Number migration

* Number migration

* Fix tests and apply for all doc types
2022-12-08 15:46:35 -06:00
Robert Sparks 44c38abbbb
fix: in htmlization ignore html files that do not parse as html (#4850) 2022-12-08 13:55:15 -06:00
Lars Eggert 220be21998
chore: Use codespell to fix typos in code. (#4797)
* chore: Use codespell to fix typos in code.

Second part of replacement of #4651

@rjsparks, I probably need to revert some things here, and I also
still need to add that new migration - how do I do that?

* Revert migrations

* Migrate "Whitelisted" to "Allowlisted"

* TEST_COVERAGE_MASTER_FILE -> TEST_COVERAGE_MAIN_FILE

* Fix permissions

* Add suggestions from @jennifer-richards
2022-12-07 15:10:35 -06:00
Robert Sparks a7c0cc0464
fix: ignore badly coded user-provided html of older documents (#4845) 2022-12-07 11:11:25 -06:00
Robert Sparks ded650286d
fix: don't use rfc names in bibxml-id elements (#4823) 2022-12-06 08:49:14 -06:00
Robert Sparks 9457e2b1e1
feat: better htmlization views (#4825)
* feat: Use bs5 for htmlized doc (#4082)

Co-authored-by: Martin Thomson <mt@lowentropy.net>

* fix: Various fixes to HTMLized document view (#4501)

* fix: Pref labels were switched

* fix: Fix ToC for htmlized docs

* Replace datatracker button with document name link to datatracker

* ui: Make fonts even larger on larger window widths

* fix: Document format buttons open new tabs

* fix: Various suggestions from Jay

* fix: Don't show "htmlized" self-link under formats

* ui: Font size fix for iOS

* ui: More little tweaks

* feat/htmlize fixes and improvements (#4506)

* fix: Don't open htmlized view in new tab

* fix: Tests were failing

* feat: Add pref settings to cap max font size

* feat: Add ability to hide side panel

* fix: And more `feat/htmlize` fixes (#4511)

* fix: Remove superfluous scrollbars

* fix: Show email links for authors

* fix: Only show "email authors" button for latest reversion

* fix: Remove duplicate code, fix nav scrolling

* feat: Add RFCs to revision lists

* feat: Add pref option to control dependency inlining

* fix: Add analytical tags

* feat: Notify user of rendering inconsistencies

* feat: Split out bootstrap-icons when not inlining dependencies

* fix: Revision list and minor other fixes

* feat: Show stream logo when possible (#4516)

* fix: Remove superfluous scrollbars

* fix: Show email links for authors

* fix: Only show "email authors" button for latest reversion

* fix: Remove duplicate code, fix nav scrolling

* feat: Add RFCs to revision lists

* feat: Add pref option to control dependency inlining

* fix: Add analytical tags

* feat: Notify user of rendering inconsistencies

* feat: Split out bootstrap-icons when not inlining dependencies

* fix: Revision list and minor other fixes

* feat: Show stream logos when possible

* fix: Pick up CSS changes from https://github.com/martinthomson/rfc-txt-html (#4520)

* fix: Remove superfluous scrollbars

* fix: Show email links for authors

* fix: Only show "email authors" button for latest reversion

* fix: Remove duplicate code, fix nav scrolling

* feat: Add RFCs to revision lists

* feat: Add pref option to control dependency inlining

* fix: Add analytical tags

* feat: Notify user of rendering inconsistencies

* feat: Split out bootstrap-icons when not inlining dependencies

* fix: Revision list and minor other fixes

* feat: Show stream logos when possible

* fix: Pick up CSS changes from https://github.com/martinthomson/rfc-txt-html

* chore: add debug script to replicate GitHub Actions test environment

* chore: cleanup from merge of main

* fix: Fix PDFixation crash due to referencing renamed CSS asset (#4665)

* fix: Rename some CSS classes to handle recent xml2rfc changes (#4791)

* Merge main

* fix: Rename some CSS classes to handle recent xml2rfc changes

Fixes #4784.

* chore: repair merge damage

* chore: more merge corrections

* chore: one more merge correction

* fix: npm dependencies

* fix: Change default font size (#4817)

* Fix dependency issues

* Cap fontsize at 12pt by default

Co-authored-by: Nicolas Giard <github@ngpixel.com>

Co-authored-by: Lars Eggert <lars@eggert.org>
Co-authored-by: Martin Thomson <mt@lowentropy.net>
Co-authored-by: Nicolas Giard <github@ngpixel.com>
2022-12-02 15:17:14 -06:00
Lars Eggert 6eabd4a3a1
chore: Use codespell to fix typos in comments. (#4794)
First part of replacement of #4651
2022-11-28 10:36:36 -06:00
Jennifer Richards 3c2e004ab8
fix: use UTC for model_to_timeline_data() (#4763)
This changes the method to operate in UTC instead of server time.
The existing code was mixing UTC and server time, though, giving
timestamps purporting to be UTC but computed from the date in the
server timezone. To the extent that it matters, I think this change
is preferable to restoring the original behavior.
2022-11-15 13:02:09 -06:00
Jennifer Richards 0c458ef048
fix: make a few datetime manipulations timezone-aware (#4755)
* fix: set tz when passing a date to timesince_days filter

* fix: fill in tz for a constructed datetime in idindex/index.py

* test: simplify double-negatives in test assertions

* test: fix I-D expiration test cases to be tz aware

* fix: use tz-aware comparisons for in_draft_expire_freeze method

* test: fix tz used for timesince_days filter test case
2022-11-15 07:55:13 -06:00
Jennifer Richards 611d732869
test: fix a couple tz problems in tests run soon after midnight UTC (#4757)
* test: fix tz problem in test_document_ballot() test

* test: fix tz problem in IprTests.test_notify() test

Co-authored-by: Robert Sparks <rjsparks@nostrum.com>
2022-11-15 07:46:42 -06:00
Russ Housley 612f33e014
fix: Don't send I-D expiration warning if it will happen within 12 hours. (#4700)
* fix: 4635

* fix: use timezone.now rather than datetime.datetime.now

* chore: fix merge error

Co-authored-by: Robert Sparks <rjsparks@nostrum.com>
2022-11-08 16:06:42 +00:00
Jennifer Richards 5a55ec0959
test: fix date-related timezone errors in tests (#4717)
* test: compare UTC dates in test_search_mail_archive()

* test: compare datetimes, not dates, in action holders test

* test: adjust test to match TZ used for IPR notification message

* test: fix timezone in date_today() calls for liaisons tests

* test: use settings.TIME_ZONE for date in nomination tests

* test: correctly use settings.TIME_ZONE instead of system time zone
2022-11-07 09:54:35 +00:00
Robert Sparks eb4b523e66
chore: merge main (#4714) 2022-11-06 12:36:14 -06:00
Lars Eggert d16a9e77a7
fix: Fix transient test failures due to i18n names (#4695)
* Search for escaped name in HTML output

* Need to check for `plain_name()` in sent emails

* Normalize i18n Unicode names in the same way the database does
2022-11-06 12:29:49 +00:00
Lars Eggert b6b48ec8f9
fix: Only allow a single newline in when URLizing RFC tags (#4710)
Fixes #4705
2022-11-05 17:22:56 +00:00
Jennifer Richards cbc6d159a5
fix: convert LastCallDocEvent.expires to DEADLINE_TZINFO to get date 2022-10-25 10:03:18 -03:00
Jennifer Richards d55280d0b1
Merge pull request #4638 from ietf-tools/main
chore: merge main into feat/tzaware
2022-10-24 12:57:11 -03:00
Jennifer Richards a331fb6d2a
fix: fix tz handling in ics files (#4630)
* fix: render upcoming.ics timestamps correctly

Both correctly display timestamps in the claimed time zones and format
the date-times in correct iCalendar format.

* refactor: also render DTSTAMP using ics_date_time tag

* fix: render valid date-times in agenda.ics

* fix: render valid date-time in important_dates_for_meeting.ics

Only touching the DTSTAMP here. The DTSTART has VALUE=DATE so the tag
does not handle it.

* test: test ics_date_time tag
2022-10-24 12:54:52 -03:00
Lars Eggert 160ca9286a
fix: Don't say that IESG processing has started (#4609)
* fix: Don't say that IESG processing has started

Fixes #4286

* Update ietf/doc/views_draft.py

Co-authored-by: Robert Sparks <rjsparks@nostrum.com>

* Update ietf/doc/views_draft.py

Co-authored-by: Robert Sparks <rjsparks@nostrum.com>

Co-authored-by: Robert Sparks <rjsparks@nostrum.com>
2022-10-20 09:02:09 -05:00
Jennifer Richards 69447d0ba0
Merge branch 'feat/tzaware' into jennifer/main-for-tzaware-merge
# Conflicts:
#	ietf/name/fixtures/names.json
#	ietf/utils/management/commands/send_gdpr_consent_request.py
2022-10-18 16:57:42 -03:00
Jennifer Richards 3220bf3c40
chore: replace last few datetime.date.today() calls with date_today() 2022-10-18 12:45:47 -03:00
Jennifer Richards dfe1147e7c
chore: switch a few datetime_today() calls to date_today() 2022-10-18 12:25:25 -03:00
Jennifer Richards 1804727432
test: use date_today() instead of datetime_today() 2022-10-18 11:54:09 -03:00
Robert Sparks cbb8da73c8
fix: regenerate correct shepherd template. Fixes #4558 (#4595)
* fix: regenerate correct shepherd template

* chore: remove unnecessary extra whitespace

* fix: improve readability of code per review comments
2022-10-18 07:57:08 -05:00
Jennifer Richards da70acfdff
Merge branch 'feat/tzaware' into jennifer/yet-more-tz-fixes
# Conflicts:
#	ietf/ietfauth/utils.py
#	ietf/meeting/tests_views.py
#	ietf/stats/tests.py
2022-10-17 16:39:45 -03:00
Jennifer Richards bef7492eda
chore: renumber migrations 2022-10-14 16:51:43 -03:00
Jennifer Richards f3bdbf0ed4
Merge branch 'feat/tzaware' into jennifer/main-for-tzaware-merge
# Conflicts:
#	ietf/meeting/tests_js.py
#	ietf/meeting/tests_models.py
#	ietf/meeting/tests_views.py
#	ietf/meeting/views.py
#	ietf/name/fixtures/names.json
#	ietf/templates/meeting/agenda.html
#	ietf/templates/meeting/session_buttons_include.html
#	ietf/templates/meeting/timeslot_start_end.html
2022-10-14 16:35:57 -03:00
Robert Sparks 50668c97cd
feat: apis for attaching chatlogs and polls to session materials (#4488)
* feat: apis for attaching chatlogs and polls to session materials

* fix: anticipate becoming tzaware, and improve guard against attempts to provide docs for sessions that have no official timeslot assignment.

* fix: get chatlog upload to actually work

Modifications to several initial implementation decisions.
Updates to the fixtures.

* fix: test polls upload

Refactored test to reduce duplicate code

* fix: allow api keys to be created for the new endpoints

* feat: add ability to view chatlog and polls documents. Show links in session materials.

* fix: commit new template

* fix: typo in migration signatures

* feat: add main doc page handling for polls. Improve tests.

* feat: chat log vue component + embedded vue loader

* feat: render polls using Vue

* fix: address pug syntax review comments from Nick.

* fix: repair remaining mention of chat log from copymunging

* fix: use double-quotes in html attributes

* fix: provide missing choices update migration

* test: silence html validator empty attr warnings

* test: fix test_runner config

* fix: locate session when looking at a dochistory object for polls or chatlog

Co-authored-by: Nicolas Giard <github@ngpixel.com>
2022-10-13 09:20:36 -05:00
Jennifer Richards 7b1b7f5273
Merge branch 'feat/tzaware' into dev/tzaware-main-merge 2022-10-11 14:57:34 -03:00
Lars Eggert eed58c9753
ui: Add rounded-pill to a few more badges (#4539) 2022-10-10 08:37:58 -05:00
Lars Eggert feab9fb385
fix: Fix state order in AD dashboard and colorize some more trends (#4518) 2022-09-29 15:10:51 -05:00
Jennifer Richards 31d55f1d37
fix: remove unused imports 2022-09-28 17:45:11 -03:00
Robert Sparks 9162302941
fix: don't include liaison attachments in main page searches. Fixes #4373. (#4502) 2022-09-27 10:27:50 -05:00
Jennifer Richards 56505147e0
fix: handle timezones in a bunch of places 2022-09-23 16:11:49 -03:00
Jennifer Richards c5e5a00ff3
fix: fill in tzinfo for datetime.fromtimestamp() calls
Unix timestamp is defined to be UTC and fromtimetamp correctly turns
it into whatever timezone you request. In most cases, just need to
specify *something* to avoid creating naive datetimes.
2022-09-22 12:36:35 -03:00
Jennifer Richards 00cf7cf8ca
fix: use settings.TIME_ZONE for draft date in bibxml_for_draft() (#4487) 2022-09-21 11:49:35 -03:00
Jennifer Richards cbb639cd58
Merge branch 'feat/tzaware' into dev/jennifer/main-merge 2022-09-20 10:19:31 -03:00