Commit graph

1164 commits

Author SHA1 Message Date
Henrik Levkowetz 2daef52bea This commit replaces the code defined group features with features held
in a database table:

- Added a GroupFeatures model to the group models, and removed the old 
  features.py
- Added a agenda type for future use in showing different group types on
  different agendas.
- Renamed the group feature has_materials to has_nonsession_materials.
- Added API resources and admin support for the new tables.
- Added a Directorate (with reviews) group type as complement to
  Directorate, to distinguish between directorates with and without reviews.
- Adjusted tests as needed.
- Updated the fixtures, and fixed the generate_fixtures script to include
  the new AgendaTypeName objects.

There still exists about 70 instances of code comparing the group type
with a list of types; most of these should probably be replaced with new
features, instead, to make it possible to add new group types through the
database table, rather than having to edit the code.  That was the purpose
of this refactoring from the start, but the presence of this large number
of comparisons of group type against lists of types defeats the goal until
we add appropriate features and replace the group type list comparisons.
 - Legacy-Id: 15316
2018-07-12 10:51:48 +00:00
Henrik Levkowetz 9fe1820640 Tweaked the 'Related documents' part of the Document admin page to more intuitively show the relationships.
- Legacy-Id: 15259
2018-06-14 19:22:55 +00:00
Henrik Levkowetz 41a5f5dca4 Merged in [15248] from rjsparks@nostrum.com:
Improvements to tests after converting to factories suggested by studying coverage_changes.
 - Legacy-Id: 15255
Note: SVN reference [15248] has been migrated to Git commit b86bd84278
2018-06-14 13:11:29 +00:00
Henrik Levkowetz b3301de22e Fixed a pyflakes nit.
- Legacy-Id: 15253
2018-06-14 12:35:16 +00:00
Henrik Levkowetz a3c12d937f Removed two instances of log.assertion(); we have enough data on these now.
- Legacy-Id: 15252
2018-06-14 12:03:02 +00:00
Robert Sparks b86bd84278 Improvements to tests after converting to factories suggested by studying coverage_changes. Commit ready to merge.
- Legacy-Id: 15248
2018-06-13 22:09:01 +00:00
Robert Sparks 340b6591b2 Use factories for ietf.doc.tests_status_change. Repair previous commit errors in ietf.doc.tests_material. Commit ready for merge.
- Legacy-Id: 15238
2018-06-09 22:16:26 +00:00
Robert Sparks a2fa0d6400 Use factories for ietf.doc.tests_material and ietf.doc.tests_review. Commit ready for merge.
- Legacy-Id: 15237
2018-06-09 21:20:37 +00:00
Robert Sparks 3eeece797a Use factories for ietf.doc.tests_downref. Commit ready for merge.
- Legacy-Id: 15228
2018-06-08 14:42:45 +00:00
Robert Sparks 67df7bd8cf Use factories for ietf.doc.tests_conflict_review. Commit ready for merge.
- Legacy-Id: 15227
2018-06-08 00:13:00 +00:00
Robert Sparks 880dafdb24 Use factories for ietf.doc.tests_charter. Commit ready for merge.
- Legacy-Id: 15226
2018-06-07 23:50:27 +00:00
Robert Sparks 6f011a3e56 Use factories for ietf.doc.tests_draft. Commit ready for merge.
- Legacy-Id: 15225
2018-06-07 22:03:09 +00:00
Robert Sparks dcf9e6b40f Use factories for ietf.doc.tests_ballots. Fixed a long-hidden bug in test_edit_verify_permissions where non-existing usernames were used and passed the tests accidently. Added list_email to the GroupFactory. Commit ready for merge.
- Legacy-Id: 15219
2018-06-06 17:59:40 +00:00
Robert Sparks a064e28926 Factoryalized the rest of ietf.doc.tests. Created draft type specific factories. Commit ready for merge.
- Legacy-Id: 15217
2018-06-05 21:17:28 +00:00
Robert Sparks 984806de2d Trivial commit removing some recently commented out code. Commit ready for merge.
- Legacy-Id: 15209
2018-06-04 15:16:47 +00:00
Robert Sparks 84d3c92298 more factoryization of ietf.doc.tests. Commit ready for merge.
- Legacy-Id: 15205
2018-06-02 13:39:39 +00:00
Robert Sparks 4e7743c009 More factorization of ietf.doc.tests. Commit ready for merge.
- Legacy-Id: 15204
2018-06-01 21:39:22 +00:00
Robert Sparks 4a4a152c9a Use factories for the rest of the tests in ietf.doc.tests.SearchTests. Commit ready for merge.
- Legacy-Id: 15203
2018-06-01 18:54:26 +00:00
Robert Sparks 0a1d9ecd2a Converted test_search_for_name to use factories. Commit ready for merge.
- Legacy-Id: 15202
2018-06-01 15:52:57 +00:00
Robert Sparks 54afc41f8e Converted test_search to use factories. Commit ready for merge.
- Legacy-Id: 15201
2018-06-01 15:16:32 +00:00
Henrik Levkowetz 4db4dd16b0 Merged in ^/personal/henrik/6.79.1-gdpr@15180 containing GDPR-adaptations.
- Legacy-Id: 15181
2018-05-28 11:26:24 +00:00
Henrik Levkowetz 81e78c70a0 Added guards against asking for properties on None in a couple of places.
- Legacy-Id: 15173
2018-05-26 08:34:27 +00:00
Henrik Levkowetz 2522082979 Changed the email origin field during test to hold user.username in order to exercise more of the code. Changed the EmailFactory to also use user.username as origin.
- Legacy-Id: 15172
2018-05-26 08:32:20 +00:00
Robert Sparks 6b779e9d4c Send email when the responsible AD for a conflict review is changed. Include the stream manager and stream steering group when the responsible AD changes or when the telechat date changes. Fixes #2497. Commit ready for merge.
- Legacy-Id: 15152
2018-05-21 22:02:34 +00:00
Henrik Levkowetz 6c3ec5b18e Added Email origin to Email record creation throughout the codebase.
- Legacy-Id: 15149
2018-05-17 16:56:26 +00:00
Henrik Levkowetz a66639299d Removed all references to the removed Person.affiliation field.
- Legacy-Id: 15129
2018-05-05 12:47:55 +00:00
Henrik Levkowetz 5f37a71889 Added origin information to all places where we create email address entries.
- Legacy-Id: 15127
2018-05-05 12:40:30 +00:00
Robert Sparks 1c16926ee6 Missed adding the migrations. Related to #1963. Commit ready for merge.
- Legacy-Id: 15120
2018-05-03 21:23:07 +00:00
Robert Sparks 1295f1f1d2 Change stream state to replaced when an ISE, IAB, or IRTF document is replaced. Fixes #1963. Commit ready for merge.
- Legacy-Id: 15119
2018-05-03 21:21:38 +00:00
Robert Sparks 8436078af6 Made settings.URL_REGEXPS.name non-greedy. Added a test to exercise the bug at #2429. Fixes #2429. Commit ready for merge.
- Legacy-Id: 15110
2018-05-03 15:39:00 +00:00
Henrik Levkowetz d076a1728c Added a 'recent drafts' page, showing drafs submitted the last 7 days.
- Legacy-Id: 15099
2018-05-01 17:55:22 +00:00
Henrik Levkowetz 53c4ac36db Removed the Person.address field, which is not being used. This was a legacy from the 2001 perl-based datatracker tables. Fixes issue #2504.
- Legacy-Id: 15095
2018-04-27 14:00:33 +00:00
Henrik Levkowetz 198c003b6a Merged in [15084] from rjsparks@nostrum.com:
Corrected the implementation of clear_ballot. Added a test for it. Restored functionality to ballot popups that was missing because a template variable was not passed in.
 - Legacy-Id: 15092
Note: SVN reference [15084] has been migrated to Git commit ee346edaba
2018-04-26 13:41:22 +00:00
Henrik Levkowetz d994a58474 Merged in [15083] from rjsparks@nostrum.com:
Removed memoize from latest_event.
 - Legacy-Id: 15091
Note: SVN reference [15083] has been migrated to Git commit 1735f86db0
2018-04-26 12:51:45 +00:00
Henrik Levkowetz c02f8fe331 Merged in [15080] from rjsparks@nostrum.com:
Marked a couple of functions as unreachable.
 - Legacy-Id: 15089
Note: SVN reference [15080] has been migrated to Git commit 7df28d8bac
2018-04-26 12:08:07 +00:00
Henrik Levkowetz c7350be50f Reverted a change to UserFactory to avoid nepalese names. The issue is bigger, and needs a different resulution. Changed the url pattern that used \w to match names to instead use a more inclusive regex.
- Legacy-Id: 15088
2018-04-26 11:53:51 +00:00
Robert Sparks ee346edaba Corrected the implementation of clear_ballot. Added a test for it. Restored functionality to ballot popups that was missing because a template variable was not passed in. Commit ready for merge.
- Legacy-Id: 15084
2018-04-25 19:52:44 +00:00
Robert Sparks 1735f86db0 Removed memoize from latest_event. Commit ready for merge.
- Legacy-Id: 15083
2018-04-25 18:15:23 +00:00
Henrik Levkowetz 8e43e7aed0 Merged in [15075] from rjsparks@nostrum.com:
Improved testing for docs_for_ad.
 - Legacy-Id: 15082
Note: SVN reference [15075] has been migrated to Git commit b7375412ab
2018-04-25 17:21:33 +00:00
Robert Sparks 7df28d8bac Marked a couple of functions as unreachable. Commit ready for merge.
- Legacy-Id: 15080
2018-04-25 15:10:55 +00:00
Henrik Levkowetz e1eb39b478 Merged in [15074] from rjsparks@nostrum.com:
Simplified docs_in_iesg_process. Added a test for it.
 - Legacy-Id: 15079
Note: SVN reference [15074] has been migrated to Git commit 57f548ecbd
2018-04-25 13:17:59 +00:00
Henrik Levkowetz 227cb0db4d Merged in [15073] from rjsparks@nostrum.com:
Rearranged ietf/doc/urls.py to allow matching some special pages under /doc without a trailing slash. Adjusted several of those special URLs to work without the trailing slash.
 - Legacy-Id: 15078
Note: SVN reference [15073] has been migrated to Git commit da25919f08
2018-04-24 21:27:04 +00:00
Robert Sparks b7375412ab Improved testing for docs_for_ad.
- Legacy-Id: 15075
2018-04-24 19:22:09 +00:00
Robert Sparks 57f548ecbd Simplified docs_in_iesg_process. Added a test for it.
- Legacy-Id: 15074
2018-04-24 18:27:19 +00:00
Robert Sparks da25919f08 Rearranged ietf/doc/urls.py to allow matching some special pages under /doc without a trailing slash. Adjusted several of those special URLs to work without the trailing slash.
- Legacy-Id: 15073
2018-04-24 18:00:59 +00:00
Henrik Levkowetz 28f4c52c20 Added permission for a document shepherd to request publication. Fixes issue #2509.
- Legacy-Id: 15071
2018-04-23 20:41:04 +00:00
Henrik Levkowetz c124a018e8 Fixed a typo. Fixes issue #2500.
- Legacy-Id: 15061
2018-04-20 13:06:21 +00:00
Henrik Levkowetz 12d999a384 Modified the IESG position setting API to send email messages about positions set.
- Legacy-Id: 15050
2018-04-17 11:57:16 +00:00
Henrik Levkowetz 2ed9face25 Modified the IESG position setting API to send email messages about positions set.
- Legacy-Id: 15049
2018-04-17 11:38:40 +00:00
Henrik Levkowetz 1591b3ebd2 Fixed an issue where simplified sorting of DocEvents resulted in some ballot icons not being shown on the IESG agenda documents page.
- Legacy-Id: 15046
2018-04-16 10:38:08 +00:00