Commit graph

46 commits

Author SHA1 Message Date
Henrik Levkowetz ec684e1b4e Added a pylint rc-file, and fixed or silenced a number of issues found by pylint using the settings .pylintrc (which enable only error checking).
- Legacy-Id: 11941
2016-09-08 14:48:59 +00:00
Robert Sparks aadcf2d056 Added selecting existing people to the workflow for chair classification of nominations. Renamed some utility functions to be slightly more self-documenting.
- Legacy-Id: 10620
2015-12-22 04:32:48 +00:00
Robert Sparks 8261507e80 Added forms for the exceptional "create a new person for this nomination" workflow. Checkpointing before a round of simplification refactors.
- Legacy-Id: 10610
2015-12-18 23:11:24 +00:00
Robert Sparks 6bf4227974 Checkpoint: main nomination forms use SearchableEmailField
- Legacy-Id: 10609
2015-12-18 20:38:17 +00:00
Robert Sparks 7d120da9ef Removed the type from the template pathname for the requirements templates. Made the requiremetns view work for both template types plain and rst. Changed the default for the requirements template for new nomcoms to rst. Migrated 2015 requirements to rst (except for the IAB position, which would require a significant edit)
- Legacy-Id: 10587
2015-12-12 03:49:23 +00:00
Robert Sparks e81b473282 Expose views for concluded nomcoms. Close feedback and nomination. Initial work on factory-boy based testing. Partially addresses #1856
- Legacy-Id: 10520
2015-11-25 22:17:41 +00:00
Robert Sparks f5b6465e81 mailtoken becomes mailtrigger
- Legacy-Id: 10090
2015-09-17 20:03:45 +00:00
Robert Sparks 90c3426e2f updated mailtoken utilities to match the model refactor. Morphed all the code using the utilities to match. Added paths to get Cc through as needed. Next up: Recipient selection form for the iesg save-and-send-email workflow
- Legacy-Id: 10040
2015-08-23 18:15:06 +00:00
Robert Sparks 65be4190a7 Done with the first pass instrumenting all mail points. There is one spot in the ipr code that's complicated and will require some refactor before instrumenting. There are a few places to add explicit messages (templates and all) to replace the simple use of email_ad. The next pass will be to make sure every spot that sends mail is covered by a test, and that the tests look at the headers sensibly. That will be followed by a moderately heavy refactor of MailToken and the gather_address utilities. Then pages showing the expansions of a token for a given document/group. Long way to go, but this is working well, and I think it will make things much easier later.
- Legacy-Id: 10030
2015-08-19 21:53:02 +00:00
Henrik Levkowetz 8905ac1789 If the author of a nomcom nomination is unknown, use 'Anonymous' and no email address in outgoing messages, instead of ''.
- Legacy-Id: 9627
2015-05-13 16:55:53 +00:00
Henrik Levkowetz 0db48f3db0 Merged in [8840] from rjsparks@nostrum.com:\n Automatically ensure Alias records exists when Person records are changed, relieving multiple code locations of that responsibility. Fixes bug #1550.
- Legacy-Id: 8873
Note: SVN reference [8840] has been migrated to Git commit b0b3a31b10bb35eb00d29f27d75d21c3cc4edc4e
2015-01-20 22:32:01 +00:00
Ryan Cross c71d1d1ef6 fix get_or_create_nominee() to create Alias for new Person. commit ready for merge.
- Legacy-Id: 8359
2014-09-26 22:19:22 +00:00
Henrik Levkowetz 563f584a9e Made ietf/nomcom pyflakes-clean. Removed some dead code.
- Legacy-Id: 7476
2014-03-15 19:26:01 +00:00
Henrik Levkowetz 5bef5d11ae Made doc/ pyflakes-clean.
- Legacy-Id: 7462
2014-03-15 16:09:47 +00:00
Ole Laursen 2c930d0f97 Get rid of remaining use of email_re, use validate_email instead
- Legacy-Id: 6882
2013-12-11 16:47:47 +00:00
Ole Laursen 9457669310 Merge in changes from the old shimfree branch
- Legacy-Id: 6764
2013-11-27 12:55:50 +00:00
Henrik Levkowetz c7c4afc6dd It turns out that the get_user_email is called for every nominee listed on a feedback page, which is insane. But until the template can be rewritten to do this in a more sane way, we cache the lookup result.
- Legacy-Id: 6651
2013-11-04 20:47:54 +00:00
Henrik Levkowetz 801283f814 By preference, show the same email for a logged-in user as his login, if it
exists; otherwise show the newest active email address.
 - Legacy-Id: 6644
2013-11-03 19:11:45 +00:00
Henrik Levkowetz 5f2da7ba9e Merged [6486] from rjsparks@nostrum.com:
Slightly more than minimal changes to have questionnaire reminders go only to those nominees who have accepted but have not yet sent in a questionnaire for a given position
 - Legacy-Id: 6573
Note: SVN reference [6486] has been migrated to Git commit 2a1b4c7775
2013-10-30 21:17:46 +00:00
Henrik Levkowetz d649fd5e10 Merged [6465] and [6466] from rjsparks@nostrum.com:
Added the ability to send reminders to complete questionnaires to nominees in
the accepted state.  Changed the send_reminders management command to not take
any arguments and run against all active nomcoms.  Removed bugs from the
send_reminders management command and added tests for it.  Adjusted several
dbtemplate titles and content.

Fixes bug 1157
 - Legacy-Id: 6471
Note: SVN reference [6465] has been migrated to Git commit 22f356434a

Note: SVN reference [6466] has been migrated to Git commit a461e6c4a4
2013-10-21 20:12:00 +00:00
Ole Laursen 0eed4ad9e5 Add has_role(role_name, user) utility to group, used like
group.has_role("chair", request.user). Remove the NomCom specific
group utilities, apparently they're not actually used.
 - Legacy-Id: 6217
2013-09-20 11:23:17 +00:00
Henrik Levkowetz 8b6f122314 Fixed nomcom email pipe command to read from stdin if no file given, and give better error messages.
- Legacy-Id: 5992
2013-08-08 12:25:03 +00:00
Henrik Levkowetz 6baea429aa Merged in the nomcom app from ejimenez@yaco.es and esanchez@yaco.es, and accompanying dbtemplate app and the (standard) docutils module. Added some tweaks to get all tests to pass and migrations to run.
- Legacy-Id: 5948
2013-08-06 10:09:29 +00:00
Emilio A. Sánchez López 49117c1622 Nominations are processed first and then the rest of feedback.
Select multiple resizable when selecting a nominee.
Fixed command that gets the feedback from email to retrieve the full address on the from header.
Added a "feedback pending" link in the top bar.
Fixed escaped html tags when displaying comments from feedback.
See #975
 - Legacy-Id: 5781
2013-06-10 10:42:11 +00:00
Emilio Jiménez 8e2a8f2daa Fixed coding error.
See #1042
 - Legacy-Id: 5755
2013-05-22 22:46:43 +00:00
Emilio Jiménez 7c481a6c81 convert to str
See #1042
 - Legacy-Id: 5751
2013-05-22 19:30:40 +00:00
Emilio Jiménez a8c81570ca Add better functions to decode emails.
See #1042
 - Legacy-Id: 5750
2013-05-22 19:23:20 +00:00
Emilio Jiménez a41abe3054 Convert unicode to str.
See #1042
 - Legacy-Id: 5749
2013-05-22 18:34:18 +00:00
Emilio Jiménez 66c4a32c57 Add subject field to feedback model
New form to fill feedback mail via web.
Fixes #1042 #1043
 - Legacy-Id: 5748
2013-05-21 12:31:24 +00:00
Emilio A. Sánchez López ee1eec7de8 Refactored the feedback pending list. Now you can classify feedback as any type of feedback.
The feedback of a type that is not related to a nominee is classified inmediatly.
The feedback of a type that is related to a nominee must be completed with the nominee information.
Created a view to list feedback that is not related to nominees (e.g. offtopic)
Changed the command that retrieves feedback from email to add the subject inside the comment and to set the author using the from field of the email.
Fixes #1036. Fixes #1035
 - Legacy-Id: 5738
2013-05-15 16:33:01 +00:00
Emilio Jiménez a6fdc52397 Refactor code to send reminders in a unique function
Refactor reminder command.
Fixes #1040
 - Legacy-Id: 5736
2013-05-15 09:08:49 +00:00
Emilio A. Sánchez López 454128b165 Check valid public key. Fixes #1004
- Legacy-Id: 5711
2013-05-08 12:39:50 +00:00
Emilio A. Sánchez López 38480747b4 Add an example of the format in the private key form.
Check if the private key is valid.
Fixes #1004
 - Legacy-Id: 5697
2013-05-06 12:21:31 +00:00
Emilio Jiménez be95a83dca Add command to create feedbacks from emails.
See #975
 - Legacy-Id: 5596
2013-03-26 11:57:45 +00:00
Emilio Jiménez bd335e3a7b now nominee has a nomcom field, it's necessary to separate nominees for distinct nomcom when two nomcom are active
when a nomcom is deleted, templates and files of nomcom are deleted too
change publick key file path in settings
See #976
 - Legacy-Id: 5580
2013-03-21 12:16:23 +00:00
Emilio Jiménez a9c33ed9f1 Add view to edit nomcom
Merge public key edit view whith nomcom edit view
Add view to delete nomcom
Add hash url to accept o decline nominations
Change new nominee template to include hash urls
See #976 #977
 - Legacy-Id: 5578
2013-03-19 17:51:09 +00:00
Emilio Jiménez b1f1ceb826 Add public and private complete views to do comments
Add new manager for position model
Add templatetag to see the total number of nominations by user on a position
Add feedback receipt template 
See #970
 - Legacy-Id: 5554
2013-03-12 15:47:49 +00:00
Emilio Jiménez 7cd0f0b49a Add checkbox to send receipt to nominator.
See #913 #929
 - Legacy-Id: 5547
2013-03-10 18:41:23 +00:00
Emilio Jiménez ea4b6389d6 * Add new view and mail template to reminder to the nominees to accept (or decline) the nominations
* Create model managers to return nominee by nomcom, so nominees list by position belongs to a specific nomcom
 * Refactor forms with new managers
See #965 #969
 - Legacy-Id: 5487
2013-03-06 16:08:21 +00:00
Emilio A. Sánchez López 9b00517449 View to enter a private key that will be encrypted and saved into the user session.
Util functions to encrypt/decrypt the private key.
Decorator to redirect to the private key input view if there is no key defined in the user session.
Templatetag 'decrypt' that decrypts text using the private key provided to the templatetag.
Fixes #947
 - Legacy-Id: 5335
2013-01-30 16:48:19 +00:00
Emilio A. Sánchez López 49ee366367 Split questionnaire template into questionnaire and introductori mail header. See #908. See #906
- Legacy-Id: 5204
2013-01-16 13:01:37 +00:00
Emilio Jiménez 0a62744875 Fixed error in public nomination process
Refactor view permissions.
See #913 #919
 - Legacy-Id: 5181
2013-01-14 10:53:59 +00:00
Emilio Jiménez de7bab7de4 Add nomination private process
See #929
 - Legacy-Id: 5180
2013-01-13 20:34:27 +00:00
Emilio Jiménez cca4924597 Create views skel for private area.
Create new decorators to test if user is nocom member
News function in Group model to get the group members
Move util functions to utils.py module
Improve passes_test_decorator function so test_func accept more params.
See #919
 - Legacy-Id: 5161
2012-12-29 00:52:52 +00:00
Emilio Jiménez e42b5015e7 Add navigation bar for nomcom pages.
Add views and template skel for nomcom pages.
Modify nomcom templates fixtures
Modify initialize functions for nomcom templates
Add view tests for nomcom pages.
Add navset styles for horizontal items
See #919
 - Legacy-Id: 5152
2012-12-25 11:39:36 +00:00
Emilio A. Sánchez López e6a49e03b9 Modified public_key field in the NomCom model to be not required. The chair will set the public_key after the NomCom object creation.
Added default templates for nomcom application.
Duplicate default templates when creating a new NomCom object or a new Position object.
Fixes #906
 - Legacy-Id: 5099
2012-12-05 13:25:02 +00:00