Commit graph

51 commits

Author SHA1 Message Date
Henrik Levkowetz ec684e1b4e Added a pylint rc-file, and fixed or silenced a number of issues found by pylint using the settings .pylintrc (which enable only error checking).
- Legacy-Id: 11941
2016-09-08 14:48:59 +00:00
Henrik Levkowetz 14a4ea177c Merged in ^/personal/rjs/6.21.1.dev0@11257
- Legacy-Id: 11259
2016-06-01 16:37:01 +00:00
Robert Sparks ebb6884b70 Beginning to rework Nominee and Nomination
- Legacy-Id: 10607
2015-12-17 21:53:39 +00:00
Robert Sparks 7d120da9ef Removed the type from the template pathname for the requirements templates. Made the requiremetns view work for both template types plain and rst. Changed the default for the requirements template for new nomcoms to rst. Migrated 2015 requirements to rst (except for the IAB position, which would require a significant edit)
- Legacy-Id: 10587
2015-12-12 03:49:23 +00:00
Robert Sparks b653e8fe8a Removed the description field from Position. Simplified the Position list and the Position edit form. Tweaked several places to make the pages more self documenting. Added a page to help nomcom chairs through setting up a new nomcom. Fixes #1867 and #1768.
- Legacy-Id: 10565
2015-12-09 23:24:46 +00:00
Robert Sparks f566a83d1d Captured when nomcom members reviewed feedback for a given nominee last. Added badges when new feedback is available. Improved layout of feedback index page. Fixes #1850.
- Legacy-Id: 10535
2015-12-02 23:25:42 +00:00
Robert Sparks 121c4d2b2d Improve the list of nominees on the feedback page. Fixes #1786 and #1809.
- Legacy-Id: 10524
2015-11-29 21:12:19 +00:00
Robert Sparks a2b03420b7 Removed the notion of an incumbent. Fixes #1771.
- Legacy-Id: 10522
2015-11-29 04:00:02 +00:00
Robert Sparks e81b473282 Expose views for concluded nomcoms. Close feedback and nomination. Initial work on factory-boy based testing. Partially addresses #1856
- Legacy-Id: 10520
2015-11-25 22:17:41 +00:00
Henrik Levkowetz 4eaadddf9e Changed nomcom.models.Nomcom() to use a FileSystemStorage which doesn't record the file system location in the migration, in order to avoid having model changes detected when switching from one development path to another.
- Legacy-Id: 10280
2015-10-24 20:13:18 +00:00
Robert Sparks bcc14cb0d1 Add a checkbox to the nomination form to indicate permission to nomcom to share the nominator's name with the nominee. Commit ready for merge.
- Legacy-Id: 10002
2015-08-10 17:57:38 +00:00
Henrik Levkowetz 4966e17158 Added 5 migrations for changes in model field help-text strings which changed in the facelift. Also fixed the expression of the help text for NomCom.reminder_interval so the text itself doesn't contain quite as much whitespace.
- Legacy-Id: 9589
2015-04-30 16:18:25 +00:00
Henrik Levkowetz 625347cd2f Merged trunk@9354 to facelift copy
- Legacy-Id: 9357
2015-04-02 06:51:34 +00:00
Henrik Levkowetz 071dfc6f8e Cleanup after Django 1.7 migration
- Legacy-Id: 9082
2015-02-12 16:38:01 +00:00
Ole Laursen 4087a9837f End help_texts with period consistently - the default error rendering in the bootstrap3 library depends on it
- Legacy-Id: 8940
2015-01-28 13:25:21 +00:00
Ole Laursen 41cb195f52 Rebase /personal/lars/5.6.4-facelift/ on trunk
- Legacy-Id: 8520
2014-10-30 14:31:07 +00:00
Henrik Levkowetz 0d61e270d6 Normalized a couple of NameModels subclasses.
- Legacy-Id: 8460
2014-10-23 21:14:41 +00:00
Henrik Levkowetz 28b31061b4 Normalized the naming of a couple of NameModel subclasses.
- Legacy-Id: 8458
2014-10-23 19:54:24 +00:00
Lars Eggert a4daf2630c Merge branch 'lars/5.6.3-facelift' into lars/5.6.4-facelift
Conflicts:
	ietf/doc/templatetags/ietf_filters.py
	ietf/doc/views_charter.py
	ietf/templates/doc/charter/edit_notify.html
	ietf/templates/doc/charter/edit_telechat_date.html
	ietf/templates/doc/document_ballot_content.html
	ietf/templates/doc/document_history.html
	ietf/templates/doc/edit_notify.html
	ietf/templates/doc/edit_telechat_date.html
	ietf/templates/doc/notify.html
	ietf/templates/group/concluded_groups.html
 - Legacy-Id: 8429
2014-10-14 11:48:57 +00:00
Ole Laursen a2c13b70d1 Make sure all BooleanFields have an explicit default value (with
Django < 1.6 it used to be False implicitly)
 - Legacy-Id: 6908
2013-12-13 13:30:07 +00:00
Ole Laursen 9457669310 Merge in changes from the old shimfree branch
- Legacy-Id: 6764
2013-11-27 12:55:50 +00:00
Henrik Levkowetz 47071ecade Merged [6468] and [6469] from ejimenez@yaco.es:
Now incumbent can be None in positions.
Fixes #1156.
 - Legacy-Id: 6470
Note: SVN reference [6468] has been migrated to Git commit d4e37ac7a0d7fddc0317b0d95670a8de8cd32c2d

Note: SVN reference [6469] has been migrated to Git commit 0a315723ad6dd610d0c17e78edce2027b6868d4e
2013-10-21 17:07:09 +00:00
Ole Laursen 0eed4ad9e5 Add has_role(role_name, user) utility to group, used like
group.has_role("chair", request.user). Remove the NomCom specific
group utilities, apparently they're not actually used.
 - Legacy-Id: 6217
2013-09-20 11:23:17 +00:00
Henrik Levkowetz da4177e1cd Rename the nomcom public keys path setting.
- Legacy-Id: 6166
2013-09-18 18:10:27 +00:00
Emilio Jiménez 66c4a32c57 Add subject field to feedback model
New form to fill feedback mail via web.
Fixes #1042 #1043
 - Legacy-Id: 5748
2013-05-21 12:31:24 +00:00
Emilio Jiménez 7042e8896a now you can see new feedback types
See #973
 - Legacy-Id: 5726
2013-05-12 18:46:53 +00:00
Emilio Jiménez 34ec539ff2 Show in all views the email of nominee
show the candidate phone in nomination feedback
Fixes #1011
 - Legacy-Id: 5703
2013-05-07 20:25:30 +00:00
Emilio Jiménez 424a454fbb Chage initial_text to show above of input in nominate form
Fixes #1010
 - Legacy-Id: 5702
2013-05-07 19:11:55 +00:00
Emilio Jiménez 4796e973ee Do legible questionnaires and requirements
See #1008
 - Legacy-Id: 5690
2013-05-02 10:38:52 +00:00
Emilio Jiménez 519d628cde Add command to send reminders
Add fields date an interval in nomcom models to send reminders
Refactor some managers
Add help_text to pending feedback form
Limit types in pending feedback form
See #969 #975
 - Legacy-Id: 5683
2013-04-23 08:24:21 +00:00
Emilio A. Sánchez López 7122fafd2f Refactor questionnaire form te select position and nominee in one widget. See #970
- Legacy-Id: 5666
2013-04-19 06:59:45 +00:00
Emilio Jiménez 85ab39f1ab Refactor feedback, now feedback belong many to many nominees
See #913 #929 #930 #965 #970 #975
 - Legacy-Id: 5598
2013-03-26 13:35:58 +00:00
Emilio Jiménez c5c33c29bc Refactor nominee merge and more test
See #930
 - Legacy-Id: 5588
2013-03-22 12:34:19 +00:00
Emilio Jiménez bd335e3a7b now nominee has a nomcom field, it's necessary to separate nominees for distinct nomcom when two nomcom are active
when a nomcom is deleted, templates and files of nomcom are deleted too
change publick key file path in settings
See #976
 - Legacy-Id: 5580
2013-03-21 12:16:23 +00:00
Emilio Jiménez 40fd14da25 * Add skek view to manage feedback generated from email.
* Now, nominee, type and user fields in feedback model can be null
See #975
 - Legacy-Id: 5576
2013-03-17 21:34:25 +00:00
Emilio Jiménez 29064193a3 * Add feedback view by nominee
* Refactor EncryptedTextField
 * Add feedback model managers 
 * Add templatetag to get person from author email
See #973
 - Legacy-Id: 5574
2013-03-16 15:43:32 +00:00
Emilio Jiménez 4fec10183d Feedback refactor:
* Now Feedback have manytomany to posotions, so a feedback email can be associated to few positions.
 * Add user and time field to nomination model
 * Delete feedbacks and questionnaires field from nomineeposition model, now feedback model has all information about nominations, feedback and quiestionnaires
 * Add user field to Feedback model to know the nomcom meber who made the nomination, regardless of the real author
 * Add nomcom field to Feedback and refactor EncryptedTextField, it's necessary to encrypt the comments with the nomcom public key.
 * Template tag to decrypt feedback has been improved, now It isn't necessary the view context has the private key variable.
 * Add skel view to view feedback
 * Delete hidden fields from private and public feedback form
 * Refactor private index view to show total number of questionnaires and to show if the nomienee has questionnaires or not
See #970
 - Legacy-Id: 5571
2013-03-15 10:05:28 +00:00
Emilio Jiménez b1f1ceb826 Add public and private complete views to do comments
Add new manager for position model
Add templatetag to see the total number of nominations by user on a position
Add feedback receipt template 
See #970
 - Legacy-Id: 5554
2013-03-12 15:47:49 +00:00
Emilio Jiménez fb772fc7aa Refactor managers to improve queries.
See #969
 - Legacy-Id: 5548
2013-03-11 07:48:52 +00:00
Emilio Jiménez ea4b6389d6 * Add new view and mail template to reminder to the nominees to accept (or decline) the nominations
* Create model managers to return nominee by nomcom, so nominees list by position belongs to a specific nomcom
 * Refactor forms with new managers
See #965 #969
 - Legacy-Id: 5487
2013-03-06 16:08:21 +00:00
Emilio A. Sánchez López 20320ea9ff Views for manage nomcom positions
Views for edit templates related to nomcom group and nomcom positions
Refactored some strings in html templates
Allow the secretariat to access the same views and view the same links as the chair
Fixes #914
 - Legacy-Id: 5334
2013-01-30 08:26:15 +00:00
Emilio A. Sánchez López 49ee366367 Split questionnaire template into questionnaire and introductori mail header. See #908. See #906
- Legacy-Id: 5204
2013-01-16 13:01:37 +00:00
Emilio Jiménez bf0747a8e9 Add duplicated field for nominees, it is necesary when chair marks duplicate nominations
Change questionnaires field in NomineePosition model to manytomany, becouse it is necessary whe chair marks duplicate nominations.
Add timestamp in NomineePosition objects to see wich nomineeposition object is the last one.
Better merge nominations, update questionnaires and state of primary nomineposition object
See #930
 - Legacy-Id: 5187
2013-01-15 16:14:00 +00:00
Emilio Jiménez 79001600b9 Fix typo error.
See #913
 - Legacy-Id: 5156
2012-12-26 17:34:34 +00:00
Emilio Jiménez eb8b6af4ed * Add news fixtures of name for testing
* Add test data fuction for testing
* Add test case to check the default state and the unique constraint in NomineePosition class
* Override the save fuction of the NomineePosition class to set the state to pending by default
See #909
 - Legacy-Id: 5127
2012-12-14 18:53:10 +00:00
Emilio Jiménez 1f05730851 better migration steps with dependencies to avoid errors.
Delete get_state_default of NomineePosition class because the migrate command fails.
See #908 #909
 - Legacy-Id: 5124
2012-12-13 23:53:42 +00:00
Emilio Jiménez d9df44e2b1 Add initial view for nominations
Chage migrate step with another state: Pending
Improve admin views of nomcom app.
See #913
 - Legacy-Id: 5117
2012-12-11 15:13:06 +00:00
Emilio A. Sánchez López e6a49e03b9 Modified public_key field in the NomCom model to be not required. The chair will set the public_key after the NomCom object creation.
Added default templates for nomcom application.
Duplicate default templates when creating a new NomCom object or a new Position object.
Fixes #906
 - Legacy-Id: 5099
2012-12-05 13:25:02 +00:00
Emilio Jiménez ddb10c4b0e Add complete models of app nomcom
Add migration step to create nomcom models
Add admin interface to nomcom models. Maybe in a future we delete some model admin but now it's good to test
Add PUBLIC_KEYS_URL settings variable to define path where public keys are saved
Add new models in name app to use feedback type and nominee position state
Add admin interface for new name models
Add migration steps to create feedback type and nominee-position states
Comment urls.py until we refactor #904 #905 tickets with the new model
See #909
 - Legacy-Id: 5090
2012-12-03 13:41:10 +00:00
Emilio Jiménez 65afd10d4a Refactor mange group views:
* Create a new models NomComGroup with public_key field. Default type is nomcom
 * News urls and views to separate members and chair forms
 * Add rolodex url when person not found.
 * Views access is only for secretariat and chair roles
See #904
 - Legacy-Id: 5069
2012-11-22 10:46:39 +00:00