Commit graph

264 commits

Author SHA1 Message Date
Henrik Levkowetz ec684e1b4e Added a pylint rc-file, and fixed or silenced a number of issues found by pylint using the settings .pylintrc (which enable only error checking).
- Legacy-Id: 11941
2016-09-08 14:48:59 +00:00
Henrik Levkowetz 4b0a9360f0 Merged in ^/branch/iola/event-saving-refactor-r10291, which refactors document saving to always use doc.save_with_history(events), and requires accompanying events. This branch also provides refactoring of recurring regexes in url patterns into a dictionary. As part of the merge, also refactored new code which didn't use the save_with_history() method.
- Legacy-Id: 11840
2016-08-23 10:52:08 +00:00
Henrik Levkowetz e6a005dba6 Added a score of setting save/restores to test setup/teardown actions.
- Legacy-Id: 11436
2016-06-21 07:51:02 +00:00
Henrik Levkowetz 14a4ea177c Merged in ^/personal/rjs/6.21.1.dev0@11257
- Legacy-Id: 11259
2016-06-01 16:37:01 +00:00
Henrik Levkowetz 6e6a8baa13 Fixed a typo.
- Legacy-Id: 10931
2016-03-15 23:15:44 +00:00
Henrik Levkowetz adb8625635 Introduced caching for the api resources.
- Legacy-Id: 10929
2016-03-15 23:12:04 +00:00
Henrik Levkowetz 846a02c3f9 Fixed pyflakes complaints introduced with pyflakes 1.1.0
- Legacy-Id: 10896
2016-03-04 21:24:26 +00:00
Robert Sparks a9abd3c2cd Tweak factories to not randomly create keys that violate constraints. Commit ready for merge
- Legacy-Id: 10756
2016-01-28 20:12:00 +00:00
Henrik Levkowetz e552ff85b7 Tentatively comment out use of tempdir() in nomcom.tests.
- Legacy-Id: 10704
2016-01-16 22:30:05 +00:00
Henrik Levkowetz 6c8629c4a9 Merged in [10629] from rjsparks@nostrum.com:
This set of changes focuses on improvements to the nomcom portion of
    the datatracker. 

    These changes:

    - Simplify the nomcom form for comments. Make it more obvious who
      receives mail when a comment is supplied. Fixes #1849.

    - Simplify the nomcom form for nominations. Provide a primary workflow
      where nominations choose an existing Person, and a secondary
      workflow for nominating new people. 

    - Allow nominees to add a comment when accepting or declining a
      nomination. Fixes #1845.

    - Organize the list of nominees on the feedback page. Fixes #1786 and
      #1809.

    - Simplify the mechanisms used to display feedback message counts.

    - Regroup the feedback view to make it easier to see where to spend
      review effort. Fixes #1866.

    - Capture when nomcom members last reviewed feedback for a given
      nominee. Add badges when new feedback is avaliable. Improve the
      layout of the feedback index page. Fixes #1850.

    - Reorganize the tab navigation on the nomcom private pages. Made it
      more obvious when the chair is doing something that only the chair
      gets to see. Fixes #1788 and #1795.

    - Regroup multiselect options to make classifying pending feedback
      simpler. Make the control larger and resizable. Fixes #1495.

    - Simplify the chair's views for editing nominee records. Replace the
      merge nominee form with a request to the secretariat to merge Person
      records. Fixes #1847. 

    - Added merging nominees to the secretariat's persson merging script. 

    - Show information for concluded nomcoms. Close feedback and
      nomination for concluded nomcoms. Fixes #1856.

    - Improve the questionnaire templates, reminding the nominee that
      receiving the questionnaire does not imply they have accepted a
      nomination. Fixes #1807.

    - Remove the description field from Postion. Simplify the Position
      list and the Position edit form. Make the nomcom pages more self
      documenting. Add a page to help nomcom chiars through setting up a
      new nomcom. Fixes #1867 and #1768.

    - Remove the type from the template pathname for the requirements
      templates. Make the requirements views work for both types plain and
      rst. Changed the default type for new nomcom requirement templates
      to rst.

    - Remove 'incumbent' from the models. Fixes #1771.

    - Adjust the models for Nominee and Nomination to better associate
      Nominee objects with Person objects.

    - Remove BaseNomcomForm and the implementation of custom fieldsets.

    - Replace the custom message framework with the django provided
      messages framework.

    - Improve SearchablePersonField to show the primary email address for
      any search result where a name appears more than once.

    - Add the use of factory-boy for generating test data. Normalize
      management of a test directory for test nomcom public keys.
      Significantly improve test coverage of the nomcom related code.
 - Legacy-Id: 10703
Note: SVN reference [10629] has been migrated to Git commit c8bbfbad78
2016-01-15 21:59:49 +00:00
Robert Sparks dc5ae398f2 Improved SearchablePersonField to show the primary email address for any search results where a name appears more than once.
Simplified the edit nominee form.
Replaced the merge nominee form with a request to the secretariat to merge Person records. Fixes #1847.
Added merging nominees to the secretariat's person merging script.
Restructured the person merging script to make it testable.
Updated some tests to match changes to the mailtriggers that hadn't made it to the fixtures.
 - Legacy-Id: 10625
2015-12-22 21:42:55 +00:00
Robert Sparks aadcf2d056 Added selecting existing people to the workflow for chair classification of nominations. Renamed some utility functions to be slightly more self-documenting.
- Legacy-Id: 10620
2015-12-22 04:32:48 +00:00
Robert Sparks fa53de03e3 Guide the workflow back to normal nominations after nominating a new person.
- Legacy-Id: 10619
2015-12-21 21:01:23 +00:00
Robert Sparks 85c13d65b4 Replaced the custom message infrastructure in the nomcom app with django.contrib.messages
- Legacy-Id: 10618
2015-12-21 20:46:56 +00:00
Robert Sparks 2120b79d6b collapse some duplicated code
- Legacy-Id: 10617
2015-12-21 16:50:46 +00:00
Robert Sparks 8261507e80 Added forms for the exceptional "create a new person for this nomination" workflow. Checkpointing before a round of simplification refactors.
- Legacy-Id: 10610
2015-12-18 23:11:24 +00:00
Robert Sparks 6bf4227974 Checkpoint: main nomination forms use SearchableEmailField
- Legacy-Id: 10609
2015-12-18 20:38:17 +00:00
Robert Sparks a2af7cfa25 Removed BaseNomcomForm and the notion of custom fieldsets
- Legacy-Id: 10608
2015-12-17 22:31:29 +00:00
Robert Sparks ebb6884b70 Beginning to rework Nominee and Nomination
- Legacy-Id: 10607
2015-12-17 21:53:39 +00:00
Robert Sparks de0b7c9a37 Checkpoint: views tests at 96%
- Legacy-Id: 10606
2015-12-16 23:12:40 +00:00
Robert Sparks f68d546233 removed move_to_default
- Legacy-Id: 10603
2015-12-16 12:07:32 +00:00
Robert Sparks df571c2fcc Improved test coverage (from 66 to 87%) - checkpointing before removing move_to_default
- Legacy-Id: 10602
2015-12-16 11:51:32 +00:00
Robert Sparks bf54e2b3f5 Regroup multiselect options to make classifying pending feedback simpler. Make the control larger and resizable. Fixes #1854.
- Legacy-Id: 10593
2015-12-14 23:14:44 +00:00
Robert Sparks 5e0632e8eb Regroup the view-feedback view to make it easier to see where to spend review effort. Fixes #1866.
- Legacy-Id: 10592
2015-12-14 21:05:52 +00:00
Robert Sparks 9ddcd62c44 Allow nominees to add a comment when accepting or declining. Fixes #1845.
- Legacy-Id: 10589
2015-12-14 03:26:43 +00:00
Robert Sparks 7d120da9ef Removed the type from the template pathname for the requirements templates. Made the requiremetns view work for both template types plain and rst. Changed the default for the requirements template for new nomcoms to rst. Migrated 2015 requirements to rst (except for the IAB position, which would require a significant edit)
- Legacy-Id: 10587
2015-12-12 03:49:23 +00:00
Robert Sparks d2f1d1ff12 corrected an improper import and removed some flakes
- Legacy-Id: 10582
2015-12-11 19:49:33 +00:00
Robert Sparks ea6d82846f Avoiding an initialization problem by setting NOMCOM_PUBLIC_KEYS_DIR in settings_sqlitetest. This is not the best long term fix
- Legacy-Id: 10581
2015-12-11 17:30:13 +00:00
Robert Sparks 6574618cdf a stab in the dark at initializing the public_key in a test friendly way
- Legacy-Id: 10575
2015-12-11 05:06:58 +00:00
Robert Sparks 3bc615883d normalizes management of a test directory for test nomcom public keys
- Legacy-Id: 10574
2015-12-11 04:01:11 +00:00
Robert Sparks 66e89e7d29 improved creation of FeedbackLastSeen
- Legacy-Id: 10572
2015-12-10 23:07:57 +00:00
Robert Sparks b653e8fe8a Removed the description field from Position. Simplified the Position list and the Position edit form. Tweaked several places to make the pages more self documenting. Added a page to help nomcom chairs through setting up a new nomcom. Fixes #1867 and #1768.
- Legacy-Id: 10565
2015-12-09 23:24:46 +00:00
Robert Sparks f566a83d1d Captured when nomcom members reviewed feedback for a given nominee last. Added badges when new feedback is available. Improved layout of feedback index page. Fixes #1850.
- Legacy-Id: 10535
2015-12-02 23:25:42 +00:00
Robert Sparks d65987b935 Improve the questionnaire templates, reminding the nominee that receiving the questionnaire does not imply they have accepted the nomination. Fixes #1807.
- Legacy-Id: 10534
2015-12-02 17:01:10 +00:00
Robert Sparks 5de9343359 Removes the generation of the count badge from a templatetag into the template
- Legacy-Id: 10531
2015-12-02 15:45:40 +00:00
Robert Sparks 2a63f91d31 Simplify pass of counts
- Legacy-Id: 10527
2015-12-02 04:44:42 +00:00
Robert Sparks a4561f55f2 improvement that makes only one counting query
- Legacy-Id: 10526
2015-12-02 04:31:35 +00:00
Robert Sparks f4f67425bf fixes a type error in the feedback form. Starts to simplify construction of the feedback badges.
- Legacy-Id: 10525
2015-12-02 03:32:06 +00:00
Robert Sparks 121c4d2b2d Improve the list of nominees on the feedback page. Fixes #1786 and #1809.
- Legacy-Id: 10524
2015-11-29 21:12:19 +00:00
Robert Sparks 473970a767 Missed an svn add
- Legacy-Id: 10523
2015-11-29 04:16:07 +00:00
Robert Sparks a2b03420b7 Removed the notion of an incumbent. Fixes #1771.
- Legacy-Id: 10522
2015-11-29 04:00:02 +00:00
Robert Sparks 5bafd3d8fe Conditioned behavior of views for concluded nomcoms. Fixes #1856.
- Legacy-Id: 10521
2015-11-28 21:51:37 +00:00
Robert Sparks e81b473282 Expose views for concluded nomcoms. Close feedback and nomination. Initial work on factory-boy based testing. Partially addresses #1856
- Legacy-Id: 10520
2015-11-25 22:17:41 +00:00
Robert Sparks 2197259102 Reorganized the tab navigation on the nomcom private pages. Made it more obvious when the chair is doing something that only the chair gets to see. Fixes #1788 and #1795.
- Legacy-Id: 10505
2015-11-17 22:50:35 +00:00
Robert Sparks 00e5762e20 Simplify the nomcom feedback comment form. Make that more obvious who receives mail when that form is used. Fixes #1849.
- Legacy-Id: 10501
2015-11-16 21:46:29 +00:00
Henrik Levkowetz cf7d794b09 Modified the test data to use some AD and WG chair names that contain non-ascii characters, and fixed test issues found.
- Legacy-Id: 10418
2015-11-04 07:34:56 +00:00
Henrik Levkowetz 97f7159a48 Migration for the nomcom 'public_key' field change to a settings-agnostic FileStorage.
- Legacy-Id: 10301
2015-10-27 15:34:43 +00:00
Ole Laursen 86c3a430d1 Merge in ^/branch/iola/event-saving-refactor-r10076, fixing a few problems
- Legacy-Id: 10298
2015-10-27 10:37:06 +00:00
Henrik Levkowetz 4eaadddf9e Changed nomcom.models.Nomcom() to use a FileSystemStorage which doesn't record the file system location in the migration, in order to avoid having model changes detected when switching from one development path to another.
- Legacy-Id: 10280
2015-10-24 20:13:18 +00:00
Henrik Levkowetz 4a80395a63 Removed support for perma_fixtures, using the blobal test fixtures instead.
- Legacy-Id: 10228
2015-10-18 11:49:15 +00:00