Commit graph

202 commits

Author SHA1 Message Date
Henrik Levkowetz 02031a01b9 Cleaned out some (arbitrary) submodule name imports into ietf.utils, and made the corresponding import statements import the names directly from the correct submodules.
- Legacy-Id: 7495
2014-03-16 07:09:38 +00:00
Henrik Levkowetz 865f221225 Finished up making ietf/secrpyflakes-clean. Removed some dead code.
- Legacy-Id: 7493
2014-03-15 23:32:21 +00:00
Henrik Levkowetz f9b76bff13 Made ietf/secr/proceedings pyflakes-clean.
- Legacy-Id: 7492
2014-03-15 23:31:09 +00:00
Henrik Levkowetz c4c8effcde Made ietf/secr/sreq pyflakes-clean.
- Legacy-Id: 7491
2014-03-15 23:30:48 +00:00
Henrik Levkowetz 0b65b383f8 Made ietf/secr/rolodex pyflakes-clean.
- Legacy-Id: 7490
2014-03-15 23:30:31 +00:00
Henrik Levkowetz b20382729c Corrected an import bug.
- Legacy-Id: 7489
2014-03-15 23:29:45 +00:00
Henrik Levkowetz ef0c4206f5 Made ietf/secr/middleware pyflakes-clean.
- Legacy-Id: 7488
2014-03-15 23:27:10 +00:00
Henrik Levkowetz 4dd7b6963f Made ietf/secr/meetings pyflakes-clean and fixed a bug in the signature of is_combined()
- Legacy-Id: 7487
2014-03-15 23:25:59 +00:00
Henrik Levkowetz aeaf0413a6 Made ietf/secr/telechat pyflakes-clean.
- Legacy-Id: 7486
2014-03-15 23:24:19 +00:00
Henrik Levkowetz 6e9469da01 Made ietf/secr/areas pyflakes-clean.
- Legacy-Id: 7485
2014-03-15 23:22:48 +00:00
Henrik Levkowetz 3893061219 Fixed the use of a non-existing model in AddAreaForm. It does however look like this form isn't used anywhere, so I've also commented the code out for now.
- Legacy-Id: 7484
2014-03-15 23:22:03 +00:00
Henrik Levkowetz b9d6d0295e Made ietf/secr/ipradmin pyflakes-clean.
- Legacy-Id: 7483
2014-03-15 22:10:11 +00:00
Henrik Levkowetz 498777ad24 Made ietf/secr/{drafts,roles,ipradmin} pyflakes-clean.
- Legacy-Id: 7482
2014-03-15 22:06:48 +00:00
Henrik Levkowetz 5bbbe24e91 Made ietf/secr/announcement pyflakes-clean.
- Legacy-Id: 7481
2014-03-15 21:37:19 +00:00
Henrik Levkowetz 8a6c121073 Made ietf/secr/groups pyflakes-clean.
- Legacy-Id: 7480
2014-03-15 21:13:21 +00:00
Henrik Levkowetz b9c38d3c06 Merged pyflakes fixes forward to new copy of trunk.
- Legacy-Id: 7463
2014-03-15 16:27:05 +00:00
Henrik Levkowetz 5bef5d11ae Made doc/ pyflakes-clean.
- Legacy-Id: 7462
2014-03-15 16:09:47 +00:00
Robert Sparks 1ef73b5a76 Reworked the worst of the conflicting permissions policies
- Legacy-Id: 7458
2014-03-13 20:45:06 +00:00
Robert Sparks f4a72ffe2a cleaned up permissions on dajaxice calls, ported and expanded more tests, refactored sendEmail, made a secr filter more robust
- Legacy-Id: 7457
2014-03-13 18:47:31 +00:00
Ryan Cross 37b758b04e changes to support django authentication
- Legacy-Id: 7454
2014-03-13 00:06:16 +00:00
Robert Sparks ad2784962f ported forward from personal/rjs/trunk-7174. Still one existing test failing
- Legacy-Id: 7449
2014-03-08 10:37:24 +00:00
Henrik Levkowetz bb029db147 Merged [7400] from rcross@amsl.com: fix bugs with decorators.check_permissions() to allow upload to top level group and fix plenary check.
- Legacy-Id: 7408
Note: SVN reference [7400] has been migrated to Git commit 03643cb0344f9a04e0f0041f9c1ace6a82375da2
2014-03-04 21:44:37 +00:00
Henrik Levkowetz e1efe561da Merged [7397] from rcross@amsl.com: fix bug where build_nonsession() not creating ScheduledSession objects.
- Legacy-Id: 7406
Note: SVN reference [7397] has been migrated to Git commit 0f0bcd0da3ccf98b5449e6dd1d98a431726986eb
2014-03-04 21:21:01 +00:00
Henrik Levkowetz dfd9b98de8 Reapplied merge of [7209], which although listed in svn:mergeinfo on . actually doesn't seem to have made it into the repository.
- Legacy-Id: 7265
Note: SVN reference [7209] has been migrated to Git commit 8d56e458d9
2014-02-19 14:53:45 +00:00
Henrik Levkowetz 08c0b601c3 Merged [7214] from rcross@amsl.com: change old references to pub.ietf.org, to datatracker.ietf.org/secr/.
- Legacy-Id: 7242
Note: SVN reference [7214] has been migrated to Git commit b9552a9331
2014-02-16 16:28:47 +00:00
Henrik Levkowetz 1b3bbad040 Merged [7213] from rcross@amsl.com: add missing template unauthorized.html.
- Legacy-Id: 7241
Note: SVN reference [7213] has been migrated to Git commit 913d90b90a
2014-02-16 16:26:35 +00:00
Ryan Cross b9552a9331 change old references to pub.ietf.org, to datatracker.ietf.org/secr/. ready for merge
- Legacy-Id: 7214
2014-02-06 21:10:08 +00:00
Ryan Cross 913d90b90a add missing template unauthorized.html. ready for merge
- Legacy-Id: 7213
2014-02-06 20:42:44 +00:00
Ryan Cross 8d56e458d9 fix typo in drafts add(). ready for merge
- Legacy-Id: 7209
2014-02-05 21:24:59 +00:00
Henrik Levkowetz 78b09b0c4e Merged [7174] from rcross@amsl.com:
fix build_nonsession for new db schema, and path to roles ajax call
 - Legacy-Id: 7179
Note: SVN reference [7174] has been migrated to Git commit 7e38c4becd
2014-01-28 21:17:07 +00:00
Henrik Levkowetz a07e2cfbc3 Merged [7151] from rcross@amsl.com:
Ticket #1248: catch DoesNotExist errors with user.get_profile() when user does not have a corresponding Person record.
 - Legacy-Id: 7178
Note: SVN reference [7151] has been migrated to Git commit d119b33a1a
2014-01-28 21:15:41 +00:00
Henrik Levkowetz 5dd0aa075d Merged [7073] from rcross@amsl.com:
changes to official proceedings generation code to support new agenda schema
 - Legacy-Id: 7177
Note: SVN reference [7073] has been migrated to Git commit 35a94362a1
2014-01-28 21:12:49 +00:00
Ryan Cross 7e38c4becd fix build_nonsession for new db schema, and path to roles ajax call
- Legacy-Id: 7174
2014-01-28 14:11:13 +00:00
Henrik Levkowetz 2d420fac34 Merged additional django-port and shim-removal tweaks from olau@iola.dk: branch/iola/djangoport@7167.
- Legacy-Id: 7168
2014-01-26 16:30:52 +00:00
Henrik Levkowetz 6e97c2c8da Merged in the port from Django 1.2 to Django 1.6 from olau@iola.dk: branch/iola/djangoport@7121, and fixed some merge issues.
- Legacy-Id: 7152
2014-01-18 21:02:40 +00:00
Ryan Cross d119b33a1a Ticket #1248: catch DoesNotExist errors with user.get_profile() when user does not have a corresponding Person record.
- Legacy-Id: 7151
2014-01-17 23:04:17 +00:00
Ole Laursen 87ca10d122 Remove usage of log_state_changed (and duplicate in
doc/utils_charter.py) in favour of add_state_change_event which has
slightly better API but otherwise does basically the same except it
sets an event type we can later search for. Also expand tests slightly
to exercise three more templates.
 - Legacy-Id: 7129
2014-01-15 17:52:00 +00:00
Ryan Cross 35a94362a1 changes to official proceedings generation code to support new agenda schema
- Legacy-Id: 7073
2014-01-04 00:38:44 +00:00
Henrik Levkowetz b68bedce30 Merged in [7009] from rcross@amsl.com: removed references to old models for shim removal release.
- Legacy-Id: 7020
Note: SVN reference [7009] has been migrated to Git commit cf81cce650
2013-12-19 17:17:58 +00:00
Ryan Cross cf81cce650 remove references to old models for shim removal release. ready for merge
- Legacy-Id: 7009
2013-12-19 04:52:33 +00:00
Ole Laursen 23725f781c Port secr/drafts/report_id_activity.py away from setup_environ too
- Legacy-Id: 6988
2013-12-18 16:02:04 +00:00
Ole Laursen e54bd17499 Port from django.core.management.setup_environ to DJANGO_SETTINGS_MODULE
- Legacy-Id: 6985
2013-12-18 15:51:11 +00:00
Ole Laursen cf61f2b59b Remove a bunch of unnecessary |escape filter calls, auto-escaping is enabled by default so manual escape is only necessary in few cases
- Legacy-Id: 6981
2013-12-18 13:38:13 +00:00
Ole Laursen 7f277a8fbb Replace user.get_profile() with user.person, the profile stuff is deprecated since Django 1.5
- Legacy-Id: 6968
2013-12-18 10:13:40 +00:00
Ole Laursen ea24f5c3bd Import slugify from django.utils.text (introduced in Django 1.5)
- Legacy-Id: 6967
2013-12-18 10:00:58 +00:00
Henrik Levkowetz ecb5cd6526 Merged in branch/iola/shimfree@6856. This pretty much completes the shim removal. Next step is upgrading Django to 1.6, and then doing some final polishing.
- Legacy-Id: 6966
2013-12-17 21:29:05 +00:00
Ole Laursen d1782297ab assertEquals -> assertEqual in tests, the former is deprecated
- Legacy-Id: 6964
2013-12-17 12:52:24 +00:00
Ole Laursen 42ade6273c Turn on CSRF protection - all forms must from now on have a {% csrf_token %}
- Legacy-Id: 6963
2013-12-17 12:50:24 +00:00
Ole Laursen 36dd439027 Rewrite ifequal/endifequal template tags to if tags with ==/!=
- Legacy-Id: 6961
2013-12-17 10:42:34 +00:00
Ole Laursen d66ac15fc2 Rewrite a bunch of HttpResponseRedirect + url reverse calls to instead
take advantage of the redirect shortcut (introduced in Django 1.1)
 - Legacy-Id: 6960
2013-12-17 10:23:42 +00:00
Ole Laursen 84a9f49053 mimetype -> content_type (mimetype is deprecated)
- Legacy-Id: 6945
2013-12-16 16:53:47 +00:00
Ole Laursen d86789608a Remove use of "groupgroup" fixture from Secretariat apps, it looks
like they don't actually depend on it, and the fixture itself is
unfortunately not complete so Django refuses to load it
 - Legacy-Id: 6938
2013-12-16 13:16:29 +00:00
Ole Laursen 0c2c5a7573 Rewrite url tags in Secretariat templates to new syntax
- Legacy-Id: 6936
2013-12-16 13:05:38 +00:00
Ole Laursen e1025e67ae Fix some oddities in secauth.py
- Legacy-Id: 6934
2013-12-16 12:48:43 +00:00
Ole Laursen 2eb8566d2f Remove : after label_tag in templates, the colon is now included in the label_tag itself
- Legacy-Id: 6930
2013-12-13 17:34:05 +00:00
Ole Laursen 0006b9ddcc Make sure all model forms have a Meta.fields attribute
- Legacy-Id: 6927
2013-12-13 17:20:02 +00:00
Ole Laursen e324f5551e Fix some {% url %} tags with commas between arguments, which is not valid with the new url syntax
- Legacy-Id: 6925
2013-12-13 17:00:12 +00:00
Ole Laursen 9b720d2a70 Fix bug in Secretariat MeetingModelForm, exclude was missing a , to be a tuple
- Legacy-Id: 6896
2013-12-12 12:12:03 +00:00
Ole Laursen 12960d9204 Fix bug in Secretariat GroupMilestoneForm, exclude was missing a , to be a tuple
- Legacy-Id: 6895
2013-12-12 12:11:09 +00:00
Ole Laursen fcb2dad155 Fix bug in Secretariat EditPersonForm, exclude was missing a , to be a tuple
- Legacy-Id: 6894
2013-12-12 12:10:05 +00:00
Ole Laursen fdd03eee8c Use validate_email instead of email_re to validate email
- Legacy-Id: 6893
2013-12-12 12:09:17 +00:00
Ole Laursen d1e60e533c Fix a couple of problems in previous URL conversion commit
- Legacy-Id: 6887
2013-12-11 17:13:49 +00:00
Ole Laursen 6a98fec2c3 Use built-in json module in Python instead of simplejson bundled with Django
- Legacy-Id: 6883
2013-12-11 16:59:19 +00:00
Ole Laursen 883853f09c Fix bug, TemplateView takes template_name, not template as parameter
- Legacy-Id: 6880
2013-12-11 16:43:34 +00:00
Ole Laursen cfa0d47ca0 Port to new class-based generic redirect and simple template views, remove utils.lazy.reverse_lazy, it's now included in Django
- Legacy-Id: 6878
2013-12-11 16:36:09 +00:00
Ole Laursen f5b2cfbc42 Make MEDIA_URL end in slash
- Legacy-Id: 6874
2013-12-11 15:29:38 +00:00
Ryan Cross 9b06fb9958 fixed calls to reverse() to match new url names since code merge
- Legacy-Id: 6859
2013-12-09 20:41:32 +00:00
Ole Laursen 56f36018a2 Fix bug in secr test
- Legacy-Id: 6843
2013-12-07 19:29:32 +00:00
Ole Laursen f935577f77 Remove some unused references to SimpleUrlTestCase
- Legacy-Id: 6838
2013-12-07 13:30:41 +00:00
Ole Laursen 77fc3ec134 Rewrite simple URL test in secr/sreq/tests.py to use fake data
- Legacy-Id: 6836
2013-12-07 13:10:36 +00:00
Ole Laursen 947c973724 Remove reference to redesign
- Legacy-Id: 6832
2013-12-07 12:30:58 +00:00
Ole Laursen da91b15e16 Remove some references to shim layer
- Legacy-Id: 6822
2013-12-06 18:08:37 +00:00
Ole Laursen ad9503f1ed Removing remaining traces of shim layer usage in meeting
- Legacy-Id: 6817
2013-12-06 16:10:10 +00:00
Ole Laursen e63ac36b8f Remove shim layer from ietfauth, delete some dead code and migrate
remaining importers of ietfauth.decorators to ietfauth.utils
 - Legacy-Id: 6797
2013-12-05 16:24:03 +00:00
Ole Laursen 28abe3dc0d Remove unused idtracker.models import
- Legacy-Id: 6780
2013-12-03 18:35:29 +00:00
Ole Laursen bb2d070679 Redo tests for IPR to cover all views, fix some bugs and add some
finishing touches
 - Legacy-Id: 6779
2013-12-03 18:33:07 +00:00
Ole Laursen e9638cb1c2 Port IPR module to new schema, remove some cruft
- Legacy-Id: 6774
2013-12-02 16:34:00 +00:00
Ole Laursen 78d9bfff24 Move send_scheduled_announcement functionality to messages/utils.py
- Legacy-Id: 6768
2013-11-28 13:05:51 +00:00
Ole Laursen 35939cc20c Remove references to old announcement models and remove the model definitions
- Legacy-Id: 6767
2013-11-27 16:45:05 +00:00
Ole Laursen 9457669310 Merge in changes from the old shimfree branch
- Legacy-Id: 6764
2013-11-27 12:55:50 +00:00
Ole Laursen ecf68dbb05 Revamp and clean up submit models:
- Rename IdSubmissionDetail to Submission
- Rename various submission fields to correspond to the conventions in
  the new schema
- Use a name model for the states instead of IdSubmissionStatus
- Drop the TempIdAuthor model which is based on splitting up author
  names
- Add a simple textual SubmissionEvent for tracking events in the
  lifetime of a submission
- Delete a bunch of obsolete fields
- Make sure all submission have an access key so we can depend on it
- Add state for when approval is needed from previous authors

A couple of migrations take care of transforming the
IdSubmissionDetail and moving data over/cleaning it up.

Also revamp the submit view code:

- Make form code do validation/cleaning only so there's a clear
  separation of concerns
- Reduce uses of inheritance that made the code hard to follow -
  forms now don't inherit from each other, views don't call each other
  but instead reuse common utilities, templates share CSS/utilities
  instead of relying on inheritance
- Move email rendering/sending to separate file
- Drop the in-grown terminology use (auto post vs. manual posts)
- Make the status page explain who is emailed for what purpose
- Add history table with recorded events
- Make the status page handle its post actions by itself instead of
  duplicating most of the setup logic in a number of simple views
- Fix a couple of minor bugs and handle some edge cases better
- Expand tests with a couple of more cases

Possibly the submit tool could still use more help text added to
explain the process, ideally what's explained in the tool instructions
page should be inlined or self-evident.
 - Legacy-Id: 6714
2013-11-15 13:30:32 +00:00
Ole Laursen e0be9bcb95 Remove unused and bitrotten get_authors_email
- Legacy-Id: 6711
2013-11-15 12:50:24 +00:00
Ole Laursen e6b0ef4323 Fix spelling error in validation
- Legacy-Id: 6709
2013-11-15 11:04:12 +00:00
Ryan Cross dbff28dbb2 change draft replace action: move document to archive directory
- Legacy-Id: 6643
2013-11-03 01:38:23 +00:00
Ole Laursen 9842eef405 For no good reason, agenda_data took request as first parameter, remove this as it makes testing harder
- Legacy-Id: 6487
2013-10-25 12:53:54 +00:00
Henrik Levkowetz edcc97aded Merged in branch/amsl/1.50@6388 from rcross@amsl.com, with secretariat tool
announcement fixes, permission fixes, and agenda database schema fixes.
 - Legacy-Id: 6473
2013-10-21 20:29:15 +00:00
Ole Laursen 10dceef26d Refactor IESG agenda pages, put the agenda structure in a helper function in agenda.py, build the agenda up around this structure, and reuse this everywhere instead of duplicating the structure in various templates and the JSON view - this also fixes a couple of minor bugs where the copy-pasted copies were not entirely in sync
- Legacy-Id: 6454
2013-10-16 13:07:09 +00:00
Ole Laursen de2ed527b4 Fix indentation problem with ballot writeup in Secretariat telechat tool and fix problem with unescaped << and >>
- Legacy-Id: 6453
2013-10-16 12:04:27 +00:00
Ole Laursen f6ff2a8082 Delete all old WGAction stuff, it's superceded by the WG charter
support, clean up iesg/models.py a bit
 - Legacy-Id: 6411
2013-10-10 16:12:34 +00:00
Ole Laursen 55c7c69679 Remove unused secr/ copy of agenda outline template (from iesg/)
- Legacy-Id: 6396
2013-10-09 12:41:59 +00:00
Ole Laursen bd34270cbc Port IESG agenda pages to new schema, add tests for them, move agenda
utilities to agenda.py, fix a couple of things, remove obsolete test
versions of agenda view, add support for viewing future IESG agendas
through /agenda/YYYY-MM-DD/* (useful when testing)
 - Legacy-Id: 6395
2013-10-09 12:40:42 +00:00
Ole Laursen 53ec62a5c9 Fix a bug in the Secretariat telechat menu, "232" -> "s232"
- Legacy-Id: 6394
2013-10-09 12:16:14 +00:00
Henrik Levkowetz e4f4467725 Changed tests to use our own subclassed TestCase, and changed almost all fixtures to be perma_fixtures.
- Legacy-Id: 6320
2013-09-30 20:36:20 +00:00
Ole Laursen c191a691e0 Remove "names" fixture from all tests, since it's now loaded once just
after creating the test database through the global test fixture
mechanism - this speeds up multiple tests considerably
 - Legacy-Id: 6305
2013-09-29 17:35:59 +00:00
Henrik Levkowetz 7bb999e09e Undid gratuitous changes.
- Legacy-Id: 6284
2013-09-26 21:35:18 +00:00
Henrik Levkowetz 6154b9922d This commit isn't tested. It captures the state after merging in branch/ssw/agenda/v4.70.
- Legacy-Id: 6273
2013-09-26 19:56:17 +00:00
Henrik Levkowetz 08ea8c1b30 Fixed a wrong secretariat template extension name.
- Legacy-Id: 6260
2013-09-24 17:51:50 +00:00
Ole Laursen 019ca2ae03 Merge changes from attic/shimfree into new branch to complete rebasing shimfree on trunk
- Legacy-Id: 6215
2013-09-20 09:48:58 +00:00
Ole Laursen 3562c5ef06 Rewrite slightly to avoid using wgchairs.accounts.get_person_for_user
- Legacy-Id: 6194
2013-09-19 11:02:24 +00:00
Henrik Levkowetz d8074d39d3 Merged the latest secretariat code from rcross@amsl.com, from branch/amsl/trunkmerge@6149.
- Legacy-Id: 6168
2013-09-18 19:33:36 +00:00