Commit graph

56 commits

Author SHA1 Message Date
Robert Sparks e6138ca126
feat: session apis (#7173)
* feat: Show bluesheets using Attended tables (#7094)

* feat: Show bluesheets using Attended tables (#6898)

* feat: Allow users to add themselves to session attendance (#6454)

* chore: Correct copyright year

* fix: Address review comments

* fix: Don't try to generate empty bluesheets

* refactor: Complete rewrite of bluesheet.html

* refactor: Fill in a few gaps, close a few holes

- Rename the live "bluesheet" to "attendance", add some explanatory text.
- Add attendance links in materials view and pre-finalized proceedings view.
- Don't allow users to add themselves after the corrections cutoff date.

* fix: Report file-save errors to caller

* fix: Address review comments

* fix: typo

* refactor: if instead of except; refactor gently

* refactor: Rearrange logic a little, add comment

* style: Black

* refactor: auto_now_add->default to allow override

* refactor: jsonschema to validate API payload

* feat: Handle new API data format

Not yet tested except that it falls back when the old
format is used.

* test: Split test into deprecated/new version

Have not yet touched the new version

* style: Black

* test: Test new add_session_attendees API

* fix: Fix bug uncovered by test

* refactor: Refactor affiliation lookup a bit

* fix: Order bluesheet by Attended.time

* refactor: Move helpers from views.py to utils.py

* test: Test that finalize calls generate_bluesheets

* test: test_bluesheet_data()

* fix: Clean up merge

* fix: Remove debug statement

* chore: comments

* refactor: Renumber migrations

---------

Co-authored-by: Paul Selkirk <paul@painless-security.com>

* chore: Remove unused import

* style: Black

* feat: Stub session update notify API

* feat: Add order & rev to slides JSON

* style: Black

* feat: Stub actual Meetecho slide deck mgmt API

* refactor: Limit reordering to type="slides"

* chore: Remove repository from meetecho API

(API changed on their end)

* feat: update Meetecho on slide reorder

* refactor: drop pytz from meetecho.py

* chore: Remove more repository refs

* refactor: Eliminate more pytz

* test: Test add_slide_deck api

* fix: Allow 202 status code / absent Content-Type

* test: Test delete_slide_deck api

* test: Test update_slide_decks api

* refactor: sessionpresentation_set -> presentations

* test: Test send_update()

* fix: Debug send_update()

* test: ajax_reorder_slides calls Meetecho API

* test: Test SldesManager.add()

* feat: Implement SlidesManager.add()

* test: Test that ajax_add_slides... calls API

* feat: Call Meetecho API when slides added to session

* test: Test SlidesManager.delete()

* feat: Implement SlidesManager.delete()

* test: ajax_remove_slides... calls Meetecho API

* feat: Call Meetecho API when slides removed

* chore: Update docstring

* feat: rudimentary debug mode for Meetecho API

* test: remove_sessionpresentation() calls Meetecho API

* feat: Call Meetecho API from remove_sessionpresentation()

* test: upload_slides() calls Meetecho API

* style: Black

* fix: Refactor/debug upload_session_slides

Avoids double-save of a SessionPresentation for the session
being updated and updates other sessions when apply_to_all
is set (previously it only created ones that did not exist,
so rev would never be updated).

* test: Fix test bug

* feat: Call Meetecho API when uploading session slides

* fix: Only replace slides actually linked to session

* fix: Delint

Removed some type checking rather than debugging it

* fix: Send get_versionless_href() as url for slides

* test: TZ-aware timestamps, please

* chore: Add comments

* feat: Call Meetecho API in edit_sessionpresentation

* feat: Call Meetecho API in remove_sessionpresentation

* feat: Call Meetecho API from add_sessionpresentation

* fix: Set order in add_sessionpresentation

* fix: Restrict API calls to "slides" docs

* feat: Call Meetecho API on title changes

* test: Check meetecho API calls in test_revise()

* fix: better Meetecho API "order" management

* fix: no PUT if there are no slides after DELETE

* feat: Catch exceptions from SlidesManager

Don't let errors in the MeetEcho slides API interfere with
the ability to modify slides for a session.

* feat: Limit which sessions we send notifications for

* fix: handle absence of request_timeout in api config

* test: always send slide notifications in tests

* fix: save slides before sending notification (#7172)

* fix: save slides before sending notification

* style: fix indentation

It's not a bug, it's a flourish!

---------

Co-authored-by: Jennifer Richards <jennifer@staff.ietf.org>
Co-authored-by: Paul Selkirk <paul@painless-security.com>
2024-03-12 10:22:24 -05:00
Robert Sparks f9c9644263
chore: merge main and fix conflicts 2023-08-30 16:35:20 -05:00
Robert Sparks 823281ba6c
chore: first pass at clearing out canonical_name 2023-08-18 10:59:55 -05:00
Lars Eggert 9d5d9d5172
fix: replace deprecated bootstrap things (#5858)
* text-muted -> text-body-secondary

* navbar-dark is deprecated

* Remove FIXME block, not an issue anymore

* Remove `navbar-light`
2023-07-18 12:22:28 -05:00
Paul Selkirk 0567b3dea2
fix: /meeting/materials splits out named sessions the same way /meeting/proceedings does (#5715)
* fix: /meeting/materials splits out named sessions the same way /meeting/proceedings does

* test: Test separation of named sessions in the materials
2023-06-09 12:41:01 -05:00
Lars Eggert f8b48f4c43
fix: use Internet-Draft more consistently across the UI (#5104)
* s/Internet Draft/Internet-Draft/i

* s/draft/Internet-Draft/i or s/draft/I-D/i

* s/ID/I-D/

* Fix tests

* a -> an

* Undo case-change to ASCII

* Address code review comments

* Add migrations

* Add merged migration

* fix: straighten out migrations

* fix: finish straightening out migrations

---------

Co-authored-by: Robert Sparks <rjsparks@nostrum.com>
2023-02-11 10:09:28 -06:00
Lars Eggert 6e97628a64
fix(ui): badge -> badge rounded-pill (#4076)
* ui: badge -> badge rounded-pill

To make badges look a little less like small buttons.

* Rip out copy&paste error
2022-06-15 13:43:49 -05:00
Lars Eggert 5598762608
fix: add more HTML validation & fixes (#3891)
* Update vnu.jar

* Fix py2 -> py3 issue

* Run pyupgrade

* test: Add default-jdk to images

* test: Add option to also validate HTML with vnu.jar

Since it's already installed in bin. Don't do this by default, since it
increases the time needed for tests by ~50%.

* fix: Stop the urlizer from urlizing in linkified mailto: text

* More HTML fixes

* More HTML validation fixes

* And more HTML fixes

* Fix floating badge

* Ignore unicode errors

* Only URLize docs that are existing

* Final fixes

* Don't URLize everything during test-crawl

* Feed HTML into vnu using python rather than Java to speed things up

* Allow test-crawl to start vnu on a different port

* Increase retry count to vnu. Restore batch size to 30.

* More HTML validation fixes

* Use urllib3 to make requests to vnu, since overriding requests_mock is tricky

* Undo commit of unmodified file

* Also urlize ftp links

* Fix matching of file name

* More HTML fixes

* Add `is_valid_url` filter

* weekday -> data-weekday

* urlencode URLs

* Add and use vnu_fmt_message. Bump vnu max buffer.

* Simplify doc_exists

* Don't add tab link to mail archive if the URL is invalid

* Run urlize_ietf_docs before linkify

Reduces the possibility of generating incorrect HTML

* Undo superfluous change

* Runner fixes

* Consolidate vnu message filtering into vnu_filter_message

* Correctly handle multiple persons with same name

* Minimze diff

* Fix HTML nits

* Print source snippet in vnu_fmt_message

* Only escape if there is something to escape

* Fix snippet

* Skip crufty old IPR declarations

* Only include modal when needed. Add handles.

* Fix wordwrap+linkification

* Update ietf/doc/templatetags/ietf_filters.py

* Update ietf/doc/templatetags/tests_ietf_filters.py

* Don't right-align second column
2022-05-03 13:55:48 -05:00
Jennifer Richards 2859c43677
fix: allow import of rev00 minutes and let secretariat edit materials (#3776)
* fix: show "Edit materials" button for all groups for a secretariat user

Fixes ietf-tools#3763

* fix: show "import minutes" button to import initial revision

* test: validate that import session minutes buttons are shown

* test: validate that "Edit materials" links are shown
2022-04-01 12:49:20 -03:00
Lars Eggert eb5423d084
ci: Also check generated HTML with the "vnu" validator (#3682)
* ci: Also check generated HTML with the "vnu" validator

Because HTML Tidy apparently misses a bunch of errors.

* thead -> tbody

* More fixes

* More fixes

* Start checker in test runner
2022-03-21 12:50:23 -05:00
Lars Eggert bbf088e18b Hopefully the final check-ins.
- Legacy-Id: 19909
2022-02-08 17:29:15 +00:00
Lars Eggert ed30521e14 Many more HTML fixes.
- Legacy-Id: 19908
2022-02-03 07:49:34 +00:00
Lars Eggert cc723ce449 More fixes.
- Legacy-Id: 19899
2022-01-31 19:17:50 +00:00
Lars Eggert cf629a42ad And more fixes.
- Legacy-Id: 19877
2022-01-25 10:14:25 +00:00
Lars Eggert 8bc7fde027 More fixes.
- Legacy-Id: 19828
2022-01-11 07:02:39 +00:00
Lars Eggert 448c6dbe9e And more bs5 stuff
- Legacy-Id: 19717
2021-12-01 13:52:50 +00:00
Lars Eggert bb5810a934 Labels are badges in bs5.
- Legacy-Id: 19616
2021-11-10 11:15:46 +00:00
Lars Eggert f17a7eddd4 pull-right -> float-end
- Legacy-Id: 19613
2021-11-10 09:57:57 +00:00
Lars Eggert 021ba39712 Reindent all templates with djhtml
- Legacy-Id: 19610
2021-11-10 09:41:11 +00:00
Lars Eggert 726b29bf74 fontawesome -> bootstrap-icons
- Legacy-Id: 19608
2021-11-10 09:28:38 +00:00
Robert Sparks 3697180cc1 Reverted merge of timezone-aware migration efforts.
- Legacy-Id: 18792
2021-01-12 16:54:20 +00:00
Henrik Levkowetz 774e752a54 Snapshot of timezone-aware datatracker code. Tests pass, and the test-crawler shows only expected differences. Trunk changes merged in up to r18768.
- Legacy-Id: 18770
2020-12-16 23:53:37 +00:00
Henrik Levkowetz 2e6efce714 Fixed some instances of invalid HTML.
- Legacy-Id: 18741
2020-12-08 14:13:26 +00:00
Henrik Levkowetz b14cba5f15 Refactored some document methods to align better with Django's get_absolute_url(), and added Person.get_absolute_uri()
- Legacy-Id: 17189
2020-01-07 13:33:02 +00:00
Ole Laursen 568670c060 Turn sessions into regular sessions and non-sessions into misc.
sessions in the UI and code to avoid ambiguity.

This doesn't change the data in the DB except for uses of
TimeSlotTypeName where 'session' is now 'regular'.
 - Legacy-Id: 17128
2019-12-06 20:02:26 +00:00
Henrik Levkowetz 506dcb3472 Merged in [16604] from rjsparks@nostrum.com:
Look at all scheduled sessions for a group when deciding to display a cancelled banner. Fixes #2764.
 - Legacy-Id: 16691
Note: SVN reference [16604] has been migrated to Git commit aea3c1a55b1b14f9da90d0cfb03891e7129f8632
2019-09-03 11:08:59 +00:00
Henrik Levkowetz 4f34d6aa58 Combined [16154] from rjsparks@nostrum.com with previous work on ticket #2633 in [16124]. Fixes issue #2633.
- Legacy-Id: 16163
Note: SVN reference [16124] has been migrated to Git commit e101d94065

Note: SVN reference [16154] has been migrated to Git commit 758757038a
2019-04-25 14:39:15 +00:00
Henrik Levkowetz b92d8ab30d Merged in [16124] from rcross@amsl.com:
Add No Bluesheets indicator to materials page.
 - Legacy-Id: 16133
Note: SVN reference [16124] has been migrated to Git commit e101d94065
2019-04-04 15:37:25 +00:00
Henrik Levkowetz e52d1e68ec Refactored some templates to reduce materials page permission lookups from ~2*#sessions to just a few.
- Legacy-Id: 16014
2019-03-07 23:25:02 +00:00
Henrik Levkowetz b57ad67041 Updated code and templates to use the new docman and groupman group features.
- Legacy-Id: 15922
2019-01-30 15:59:00 +00:00
Robert Sparks 8a4d5aa8ba Fixed typo in the meeting materials template that was causing minutes for groups that met more than once to not show. Commit ready for merge.
- Legacy-Id: 14053
2017-08-13 20:42:45 +00:00
Henrik Levkowetz 8e942f44a6 Changed the display of individual item update time on the materials overview page. In practice, having a tooltip on every agenda, minutes, and slides link became intrusive and annoying. Changed to display a bell if the update is within one day of now, and to display the time tooltip when hovering over the bell. Also corrected the colspan numbers for cancelled sessions, for consistency.
- Legacy-Id: 13965
2017-07-22 11:39:11 +00:00
Alireza Mohammadi 5b0555581f Ticket# 1644 : add "last updated" timestamps on meeting materials page
Added UTC time to the tooltip of Agenda and slides and an new column of Updated. Updated column present the latest time stamp for agenda and slides.
 - Legacy-Id: 13908
2017-07-15 15:23:10 +00:00
Henrik Levkowetz 09259ae556 Merged in [12393] from rjsparks@nostrum.com:
Fixed bug where slides from multiple sessions for a group were not all showing. Improved handling of multiple minutes and agendas for groups. Fixes #2058.  Commit should be patched into production.
 - Legacy-Id: 12395
Note: SVN reference [12393] has been migrated to Git commit 2b0ec6df16
2016-11-23 18:31:10 +00:00
Robert Sparks 2b0ec6df16 Fixed bug where slides from multiple sessions for a group were not all showing. Improved handling of multiple minutes and agendas for groups. Fixes #2058. Commit ready for merge. Commit should be patched into production.
- Legacy-Id: 12393
2016-11-23 17:09:53 +00:00
Robert Sparks 4e7d077b16 Adjust when materials links on the materials page show for the secretariat. Commit ready for merge.
- Legacy-Id: 12384
2016-11-17 22:45:29 +00:00
Robert Sparks ca0980a8ea Change the edit buttons on the materials page to be links. Move where the link appears. Commit ready for merge.
- Legacy-Id: 12318
2016-11-12 03:07:46 +00:00
Henrik Levkowetz aec77c2385 Rewrote Document.href() to not do database queries when possible, as that has a big performance impact. Fixed a number of tests which relied on href() not doing the right thing for simplified test data. Added caching of canonical_name(), which can be quite heavy. Additional refactoring in a number of places, to use better test data and avoid test failures for good code :-)
- Legacy-Id: 12226
2016-10-28 16:59:42 +00:00
Henrik Levkowetz 6a905897f8 Fixed a bad link to uploaded session agendas.
- Legacy-Id: 12214
2016-10-25 21:38:46 +00:00
Henrik Levkowetz 72d9017d63 Merged in [11780] from rjsparks@nostrum.com:
Removed bluesheet upload from the secr/ bluesheets generation page. Added navigation to session details from the meeting materials view rows.
 - Legacy-Id: 11815
Note: SVN reference [11780] has been migrated to Git commit 9b295b1b5e346afafdcaf3d00b0b120a1b826e7f
2016-08-17 22:52:11 +00:00
Henrik Levkowetz 92214726fd Renamed some files under ietf/group/ which contained views but didn't have 'views' in the name.
- Legacy-Id: 11190
2016-05-13 15:59:10 +00:00
Henrik Levkowetz d2cd382292 Added links back to the group pages from the group names on the meeting materials page.
- Legacy-Id: 11090
2016-04-04 04:18:00 +00:00
Henrik Levkowetz 0bcc7f0f3f Merged in [10973] from rjsparks@nostrum.com:
Show the drafts from all of a groups sessions on the materials page. Fixes #1933.
 - Legacy-Id: 10976
Note: SVN reference [10973] has been migrated to Git commit 71166df5a2
2016-03-24 17:57:46 +00:00
Robert Sparks a1a518a4bc merged older materials work (specifically, that vetted in prague)
- Legacy-Id: 10750
2016-01-27 01:12:19 +00:00
Henrik Levkowetz ed8ece2155 Merged in [9967] from lars@netapp.com:
Fix HTML bug.
 - Legacy-Id: 10014
Note: SVN reference [9967] has been migrated to Git commit d58ecd61c91e2bddbcb6bd9dcbde436ab92b8628
2015-08-13 08:27:25 +00:00
Robert Sparks 609f368ce1 Still clunky but far enough along for sprinters to play with and comment on
- Legacy-Id: 9720
2015-07-15 02:13:48 +00:00
Henrik Levkowetz 0168083804 Added session anchors and a necessary style class to group names in the meeting materials page, to permit linking to specific WG names. Fixes issue #1743.
- Legacy-Id: 9708
2015-07-09 13:13:14 +00:00
Henrik Levkowetz 0d08fff0ac Updated a bunch of links from http: to https: based on a patch from lars@netapp.com.
- Legacy-Id: 9555
2015-04-24 21:45:04 +00:00
Henrik Levkowetz ec0321e0da Added copyright lines and template origin to the html templates. Fixed a number of instances of html that didn't validate.
- Legacy-Id: 9551
2015-04-24 20:40:01 +00:00
Ole Laursen a589115ff4 Summary: Reindent all HTML files to follow the previous convention (no
tabs) and kill the scripts block in favour of just using a js block with
a script tag (which is easier to understand for context-sensitive
modes such as web-mode in Emacs). Also fix a couple of details, e.g.
missing semicolons in JS snippets.
 - Legacy-Id: 9096
2015-02-17 18:01:04 +00:00