Flipped a sense to put the grace period on the right side of 'today' when sending review overdue reminders to team secretaries. Fixes#2816.
- Legacy-Id: 16940
Note: SVN reference [16926] has been migrated to Git commit 7560e116bf
Fix#2087 - Show doc authors and WG chairs in unassigned reviews views.
- Legacy-Id: 16931
Note: SVN reference [16923] has been migrated to Git commit 93797b3fc1
Fix#2118 - Always list all last call drafts in assignment summary.
If a draft is scheduled for a telechat, but also assigned for LC review,
it will now be listed both in the telechat section and under 'last calls'.
- Legacy-Id: 16913
Note: SVN reference [16904] has been migrated to Git commit 82c63b49f3
Ref #2526 - Fix test failure in [16895]
This also makes a small text clarification, which was also the initial
reason for the test failure.
- Legacy-Id: 16912
Note: SVN reference [16895] has been migrated to Git commit ef1e8006f0
Note: SVN reference [16902] has been migrated to Git commit 78a1464e77
Fix#2526 - List previous reviews in assignments email.
This includes a migration to update the database templates. Note that
not all templates currently included them (secdir at least), and
previous reviews are only listed in templates that included */** before.
As before, previous reviews are only included if they are done by the
same reviewer(s) as the current assignment.
This also fixes a bug in database template 182
(/group/defaults/email/open_assignments.txt) which referred to
r.review_request..doc.rev and r.review_request..requested_rev
in the template, and updates the test to use the current version of
template 182.
- Legacy-Id: 16911
Note: SVN reference [16895] has been migrated to Git commit ef1e8006f0
Fix#2198 - Set default start date for UnavailabilityPeriod to today.
- Legacy-Id: 16910
Note: SVN reference [16891] has been migrated to Git commit a7a2ee4a39
If a draft is scheduled for a telechat, but also assigned for LC review,
it will now be listed both in the telechat section and under "last calls".
Commit ready for merge.
- Legacy-Id: 16904
This also makes a small text clarification, which was also the initial
reason for the test failure.
Commit ready for merge.
- Legacy-Id: 16902
Note: SVN reference [16895] has been migrated to Git commit ef1e8006f0
Remove some pre-ReviewAssignment refactor logic, and simplify what remains while still allowing a group secretary to not assign a row on the unassigned requests form after touching the control to assign a reviewer. Fixes#2812.
- Legacy-Id: 16900
Note: SVN reference [16854] has been migrated to Git commit b158807134e2d26b3e013b6414b6fcbaa0e39f77
Fix#2185 - Close review assignments when reviewer is removed from team.
If a reviewer is removed from a team, any accepted or assigned review
assignments are set to rejected if the request deadline has not passed,
or set to no-response when the request deadline has passed.
Per [16819], if this scenario happens, and there are no other active or
completed review assignments, the request is shown as an
unassigned review.
- Legacy-Id: 16897
Note: SVN reference [16819] has been migrated to Git commit fdb4c2a055
Note: SVN reference [16850] has been migrated to Git commit e145832808
This includes a migration to update the database templates. Note that
not all templates currently included them (secdir at least), and
previous reviews are only listed in templates that included */** before.
As before, previous reviews are only included if they are done by the
same reviewer(s) as the current assignment.
This also fixes a bug in database template 182
(/group/defaults/email/open_assignments.txt) which referred to
r.review_request..doc.rev and r.review_request..requested_rev
in the template, and updates the test to use the current version of
template 182.
Commit ready for merge.
- Legacy-Id: 16895
Fix#2186 - Return review req to 'requested' status if no review assignments are open.
If a review assignment is rejected, withdrawn, marked no response, etc.,
and this leaves a review request without any assigned/accepted/completed
review assignments, return the request state to 'requested', which means
it will be shown as an unassigned review in all interfaces.
- Legacy-Id: 16881
Note: SVN reference [16819] has been migrated to Git commit fdb4c2a055
If a reviewer is removed from a team, any accepted or assigned review
assignments are set to rejected if the request deadline has not passed,
or set to no-response when the request deadline has passed.
Per [16819], if this scenario happens, and there are no other active or
completed review assignments, the request is shown as an
unassigned review.
Commit ready for merge.
- Legacy-Id: 16850
Note: SVN reference [16819] has been migrated to Git commit fdb4c2a055
Link to the about pages for groups even if they don't have a charter (some have other forms of descriptive text, and all have more information on the group pages than they did a few years ago). Fixes#2744.
- Legacy-Id: 16848
Note: SVN reference [16815] has been migrated to Git commit 26e3e62c567d8146a27a976f1da0710eeda46ba2
Fix#2475 - Send opt-in reminders for unconfirmed review assignments.
If enabled for a team, reminders will be sent every X days to reviewers
for review assignments they have not accepted or rejected.
- Legacy-Id: 16846
Note: SVN reference [16792] has been migrated to Git commit 486b6daa29
Refs #2277 - Send daily reminders of overdue reviews to secretaries
- Legacy-Id: 16839
Note: SVN reference [16765] has been migrated to Git commit cc64992204
Fix#2337 - Send periodic reminders of open reviews every X days (opt-in)
The interleaved_migrations_test currently fails due to the various
migrations that have been added for individual tickets/commits (unless
--permit-mixed-migrations is set). I think this is better fixed in a
later cleanup, as doing it now could cause confusion when merging
individual commits, and more migrations are likely to be added soon.
- Legacy-Id: 16823
Note: SVN reference [16705] has been migrated to Git commit ec56a03ec6
Fix#2231 - Send reminders before long UnavailabilityPeriods expire
A notification is sent to the team secretary and reviewer, if an
unavailability period lasting 30 days or more will end in 3 days.
- Legacy-Id: 16822
Note: SVN reference [16704] has been migrated to Git commit 179c151f9e
If a review assignment is rejected, withdrawn, marked no response, etc.,
and this leaves a review request without any assigned/accepted/completed
review assignments, return the request state to "requested", which means
it will be shown as an unassigned review in all interfaces.
Commit ready for merge.
- Legacy-Id: 16819
If enabled for a team, reminders will be sent every X days to reviewers
for review assignments they have not accepted or rejected.
Commit ready for merge.
- Legacy-Id: 16792
Fix#2560 - Sort names in history when changing list of members.
- Legacy-Id: 16789
Note: SVN reference [16668] has been migrated to Git commit de9cde9e43
Corrected a view that was looking at review assignment ids when it should have been looking at request review ids. Fixes#2776.
- Legacy-Id: 16708
Note: SVN reference [16647] has been migrated to Git commit 87de06c97c
The interleaved_migrations_test currently fails due to the various
migrations that have been added for individual tickets/commits (unless
--permit-mixed-migrations is set). I think this is better fixed in a
later cleanup, as doing it now could cause confusion when merging
individual commits, and more migrations are likely to be added soon.
Commit ready for merge.
- Legacy-Id: 16705
A notification is sent to the team secretary and reviewer, if an
unavailability period lasting 30 days or more will end in 3 days.
Commit ready for merge.
- Legacy-Id: 16704
Added Closing Notes to history and about pages for groups. Fixes issue #2725.
- Legacy-Id: 16586
Note: SVN reference [16559] has been migrated to Git commit 93b4d6fcc4
