Commit graph

11275 commits

Author SHA1 Message Date
Henrik Levkowetz 3160f55597 Added code to catch a form error regularly caused by form spam and return a failure instead of triggering a server 500.
- Legacy-Id: 16728
2019-09-10 16:10:11 +00:00
Henrik Levkowetz 81bc17533a Set version info and settings back to development mode
- Legacy-Id: 16723
2019-09-08 15:29:06 +00:00
Henrik Levkowetz b1e8e4a1d1 Set version info to release version 6.101.0 before branching.
- Legacy-Id: 16721
2019-09-08 15:28:40 +00:00
Henrik Levkowetz 2e24d4a315 Changelog entry for 6.101.0
- Legacy-Id: 16720
2019-09-08 15:28:30 +00:00
Henrik Levkowetz a2af3bdcfe Code coverage data for release 6.101.0
- Legacy-Id: 16719
2019-09-08 15:28:15 +00:00
Henrik Levkowetz 28bd819f91 Updated bower-managed static web assets
- Legacy-Id: 16718
2019-09-08 15:02:28 +00:00
Henrik Levkowetz eafaa0d742 Added an --ignore-resources switch to bin/mkrelease, as a stopgap measure before moving to yarn.
- Legacy-Id: 16717
2019-09-08 14:58:17 +00:00
Henrik Levkowetz 3336f4a11b Merged in [16656] from rjsparks@nostrum.com:
Add IANA expert review tracking.
 - Legacy-Id: 16716
Note: SVN reference [16656] has been migrated to Git commit e45a32e49f
2019-09-08 14:34:29 +00:00
Henrik Levkowetz 1d74b1408f Merged in [16655] from rjsparks@nostrum.com:
Sigh. This is the last part of removing the todo page (along with r16650 and part of r16649. Apologies this got smeared out.
 - Legacy-Id: 16715
Note: SVN reference [16655] has been migrated to Git commit 38244111e4
2019-09-08 13:36:41 +00:00
Henrik Levkowetz 9e435a328f Merged in [16650] from rjsparks@nostrum.com:
Remove the bootstrap project todo page. #2778 points to the old content so we can make new tickets for anything that is still relevant. r16649 unintentionally had part of what should have been in this commit (the changes to /ietf/release/urls.py).
 - Legacy-Id: 16714
Note: SVN reference [16650] has been migrated to Git commit 4d77769345
2019-09-07 22:13:38 +00:00
Henrik Levkowetz 100aa3f35d Removed OBE page 'todo' under 'release'.
- Legacy-Id: 16711
2019-09-05 23:02:23 +00:00
Henrik Levkowetz 1c38387279 Merged in [16649] from rjsparks@nostrum.com:
Guard against attempts to use the review request view with a ReviewRequest id that does not match the document for the ReviewRequest. This would have exposed #2776 much earlier.
 - Legacy-Id: 16710
Note: SVN reference [16649] has been migrated to Git commit 01ceeba131
2019-09-05 22:59:59 +00:00
Henrik Levkowetz 3349d64479 Merged in [16647] from rjsparks@nostrum.com:
Corrected a view that was looking at review assignment ids when it should have been looking at request review ids. Fixes #2776.
 - Legacy-Id: 16708
Note: SVN reference [16647] has been migrated to Git commit 87de06c97c
2019-09-05 21:26:54 +00:00
Henrik Levkowetz 513e60432b Added a 'domain' variable to context supplied to the agenda_package.txt template. Fixes issue #2793.
- Legacy-Id: 16707
2019-09-05 18:49:18 +00:00
Henrik Levkowetz aafc66c490 Merged in [16646] from rjsparks@nostrum.com:
Don't manually linewrap when looking at feedback - let the pasted styling do that. Fixes #2761.
 - Legacy-Id: 16706
Note: SVN reference [16646] has been migrated to Git commit 33838840d1
2019-09-05 18:46:24 +00:00
Sasha Romijn ec56a03ec6 Fix #2337 - Send periodic reminders of open reviews every X days (opt-in)
The interleaved_migrations_test currently fails due to the various 
migrations that have been added for individual tickets/commits (unless
--permit-mixed-migrations is set). I think this is better fixed in a
later cleanup, as doing it now could cause confusion when merging
individual commits, and more migrations are likely to be added soon.

Commit ready for merge.
 - Legacy-Id: 16705
2019-09-05 15:02:56 +00:00
Sasha Romijn 179c151f9e Fix #2231 - Send reminders before long UnavailabilityPeriods expire
A notification is sent to the team secretary and reviewer, if an
unavailability period lasting 30 days or more will end in 3 days.
Commit ready for merge.
 - Legacy-Id: 16704
2019-09-05 11:59:40 +00:00
Sasha Romijn 296b126c70 Ref #2231 - Fix send-review-reminders and add it to daily cron
This fixes a syntax error and a Python 3 incompatibility, and adds
send-review-reminders to the daily cron script.

Important notes:
- I have not tested to what degree the existing reminders work as they
  should, as that's out of scope. It does have tests.
- I can't assess whether the virtualenv activation works in the
  production setup, and it may be obsolete as bin/daily also
  activates the virtualenv.
- The same Python 3 incompatibility (execfile() no longer exists) seems
  to exist in various other scripts.
  
Commit ready for merge.
 - Legacy-Id: 16703
2019-09-05 10:50:39 +00:00
Ryan Cross f950f1b8ea Remove temporary print statements. Commit ready for merge.
- Legacy-Id: 16702
2019-09-03 21:16:10 +00:00
Ryan Cross 0bbdbca8ac Add migration to remove any break / registration sessions that have already been created for future meetings. Goes with changes for #2713. Commit ready for merge.
- Legacy-Id: 16701
2019-09-03 21:03:19 +00:00
Henrik Levkowetz 46fbcfbc01 Merged in [16631] from rjsparks@nostrum.com:
Converted tabs to spaces. Whitespace changes only.
 - Legacy-Id: 16700
Note: SVN reference [16631] has been migrated to Git commit 19a9ce9a95
2019-09-03 19:42:01 +00:00
Henrik Levkowetz 8472cf2226 Merged in [16630] from rjsparks@nostrum.com:
Rework how we are labeling constraints to provide a quick-fix for session requests at IETF106. Turned off several javascript functions that added/enforced old (possibly no longer correct) semantics for the session request forms. Fixes #2754.
 - Legacy-Id: 16699
Note: SVN reference [16630] has been migrated to Git commit 10422f87d2
2019-09-03 16:43:12 +00:00
Henrik Levkowetz e021eb8924 Merged in [16629] from rjsparks@nostrum.com:
Removing unused template. I think it was an artifact of the Django 1.2 to 1.6 conversion from 6 years ago.
 - Legacy-Id: 16698
Note: SVN reference [16629] has been migrated to Git commit 798a57c9ab
2019-09-03 14:46:14 +00:00
Henrik Levkowetz e49ff19255 Merged in [16615] from peter@akayla.com:
Spelling correction in a comment.  No open issue.
 - Legacy-Id: 16697
Note: SVN reference [16615] has been migrated to Git commit 7f6edfcabc
2019-09-03 12:52:26 +00:00
Henrik Levkowetz f26020631e Merged in [16614] from peter@akayla.com:
Improved so that new draft diffs (from the working group drafts page) work correctly for both -00 drafts and later revisions.  Fixes issue #2697.
 - Legacy-Id: 16693
Note: SVN reference [16614] has been migrated to Git commit 390ff04722
2019-09-03 12:28:45 +00:00
Henrik Levkowetz f6db442fc4 - Legacy-Id: 16692 2019-09-03 11:30:45 +00:00
Henrik Levkowetz 506dcb3472 Merged in [16604] from rjsparks@nostrum.com:
Look at all scheduled sessions for a group when deciding to display a cancelled banner. Fixes #2764.
 - Legacy-Id: 16691
Note: SVN reference [16604] has been migrated to Git commit aea3c1a55b1b14f9da90d0cfb03891e7129f8632
2019-09-03 11:08:59 +00:00
Sasha Romijn 68ea11a916 Fix #2478 - When completing review, show which addresses it is posted to.
Commit ready for merge.
 - Legacy-Id: 16688
2019-09-02 15:52:26 +00:00
Sasha Romijn 1390ae073c Fix #2354 - Make review_completed configurable per team and review type
This includes a migration to change mailtrigger slugs to be up to 64
characters instead of 32, as some slugs would not fit and require clunky
abbreviations.
A data migration creates triggers for existing teams, and they are also
created on the fly if a trigger does not exist yet, providing a safe
fallback for new review teams. The review_completed mailtrigger serves
as the template for new triggers.
This commit also includes tests for gather_address_lists(), as none
existed.

Commit ready for merge.
 - Legacy-Id: 16680
2019-08-30 17:40:55 +00:00
Henrik Levkowetz 7ad34ba69e The logic for displaying 'Email requested to be sent for earlier discuss' on IESG positions was wrong; it would count later discusses and discusses from other ADs as an 'earlier discuss'. Moved any_email_sent() from ballot to position, and refined the criteria.
- Legacy-Id: 16675
2019-08-28 20:56:34 +00:00
Henrik Levkowetz 22e22c2273 Updated ready-for-merge
- Legacy-Id: 16674
2019-08-28 20:49:50 +00:00
Sasha Romijn 88b7b45b0e Fix #2328 - Use mailtriggers to find destinations in review app
As the review app has several conditionals that don't fit
entirely well within mailtriggers, the templates use a bit
of extra context to figure out who exactly to include. This also
extends the tests for review, to check for correct recipients.
It also adds a tiny feature to mailtrigger to entirely exclude
certain addresses, as required by the review-generated mails.

Commit ready for merge.
 - Legacy-Id: 16672
2019-08-27 15:15:13 +00:00
Sasha Romijn 3942f9acc7 Fix #2590 - Allow secretary to adjust date when completing a review.
This also fixes other issues identified in #2590, around the
modification of historical document events. The behaviour is now:
- When the assigned reviewer posts a review, a single event is
  created, set to current date/time.
- When the secretary records a review in the datatracker, they may
  set a different completion date, which is autofilled if an email
  is selected. One event is generated for the original completion
  date, and one for the secretary's action.
- Each revision generates a new event, rather than updating previous
  existing events.
 - Legacy-Id: 16670
2019-08-26 12:58:31 +00:00
Sasha Romijn de9cde9e43 Fix #2560 - Sort names in history when changing list of members. Commit ready for merge.
- Legacy-Id: 16668
2019-08-23 11:57:40 +00:00
Sasha Romijn 4669b0934b Fix #2071 - Add optional comment field for close request. Commit ready for merge.
- Legacy-Id: 16667
2019-08-23 11:37:41 +00:00
Henrik Levkowetz dc6201eeeb Made sure Person.active_drafts() and .expired_drafts() don't return duplicate entries. Fixes issue #2784.
- Legacy-Id: 16665
2019-08-20 22:43:51 +00:00
Henrik Levkowetz 50d2160afe Removed a BOM
- Legacy-Id: 16664
2019-08-20 19:53:10 +00:00
Henrik Levkowetz 97973959ba Changed requirements to permit pyang 2.0 and greater.
- Legacy-Id: 16663
2019-08-20 19:52:04 +00:00
Henrik Levkowetz 69ee4948fe Fixed a typo in the changelog.
- Legacy-Id: 16662
2019-08-20 14:39:46 +00:00
Henrik Levkowetz 9a9c9fb426 Merged in [16603] from rjsparks@nostrum.com:
Remove a debug statement from the command
 - Legacy-Id: 16661
Note: SVN reference [16603] has been migrated to Git commit d27096f39022e9bee1ffa84631d5ae847af9be3e
2019-08-20 10:35:06 +00:00
Henrik Levkowetz 80db16632e Added a migration to fix some m2m table columns incorrectly left as varchar(8) when we changed the size of name slugs to varchar(32).
- Legacy-Id: 16660
2019-08-19 19:21:18 +00:00
Henrik Levkowetz 509e0da7ab Merged in [16601] from rjsparks@nostrum.com:
A management command to correct the state of several slide presentations uploaded during IETF105, and perform some missed powerpoint to pdf conversions.
 - Legacy-Id: 16659
Note: SVN reference [16601] has been migrated to Git commit a14188d95cf200dfbdd93485b89808f3336b0649
2019-08-19 17:50:56 +00:00
Robert Sparks e45a32e49f Add IANA expert review tracking. Commit ready for merge.
- Legacy-Id: 16656
2019-08-15 20:36:07 +00:00
Robert Sparks 38244111e4 Sigh. This is the last part of removing the todo page (along with r16650 and part of r16649. Apologies this got smeared out. Commit ready for merge.
- Legacy-Id: 16655
2019-08-15 20:35:20 +00:00
Robert Sparks 4d77769345 Remove the bootstrap project todo page. #2778 points to the old content so we can make new tickets for anything that is still relevant. r16649 unintentionally had part of what should have been in this commit (the changes to /ietf/release/urls.py). Commit ready for merge.
- Legacy-Id: 16650
2019-08-14 16:09:39 +00:00
Robert Sparks 01ceeba131 Guard against attempts to use the review request view with a ReviewRequest id that does not match the document for the ReviewRequest. This would have exposed #2776 much earlier. Commit ready for merge.
- Legacy-Id: 16649
2019-08-14 16:06:13 +00:00
Robert Sparks 87de06c97c Corrected a view that was looking at review assignment ids when it should have been looking at request review ids. Fixes #2776. Commit ready for merge.
- Legacy-Id: 16647
2019-08-13 18:13:50 +00:00
Robert Sparks 33838840d1 Don't manually linewrap when looking at feedback - let the pasted styling do that. Fixes #2761. Commit ready for merge.
- Legacy-Id: 16646
2019-08-12 19:22:39 +00:00
Henrik Levkowetz b2be7975c9 Merged in [16600] from rjsparks@nostrum.com:
Fixed a subtle bug in the code that converts slides to PDF that was writing back into settings.
 - Legacy-Id: 16645
Note: SVN reference [16600] has been migrated to Git commit b4714f95579efcb5051438239a5df002036c9975
2019-08-10 18:06:40 +00:00
Henrik Levkowetz 7e34b3cd60 Merged in [16599] from rjsparks@nostrum.com:
Correct the uploaded_filename for slides that go through the approve-proposed-slides workflow.
 - Legacy-Id: 16644
Note: SVN reference [16599] has been migrated to Git commit f6b05ae963b9933dc8522f5db86eb33086d8f040
2019-08-10 17:29:51 +00:00