Commit graph

11458 commits

Author SHA1 Message Date
Jennifer Richards e290d9e499
test: avoid local times near midnight for test_past_swap_days_buttons() (#4642)
* test: avoid local times near midnight for test_past_swap_days_buttons()

* test: use timezone_options variable consistently

* test: add test of timezone_not_near_midnight() method

* fix: ensure that timezone_not_near_midnight() always exits
2022-10-26 09:42:50 -05:00
Lars Eggert d34e88dfd9
fix: Set an aria-label on freetext pronouns field (#4633) 2022-10-22 15:26:11 -05:00
Robert Sparks d08815d8da
fix: find raw chatlog and polls for interims (#4628) 2022-10-21 15:58:54 -05:00
Jennifer Richards aba9c2ae12
fix: include outbound constraints in sreq update notification email (#4620)
* fix: include outbound constraints in sreq update notification email

* style: clean up whitespace
2022-10-21 11:18:19 -05:00
Lars Eggert 565707f804
feat: Add "IESG dashboard" to menu (#4624)
Fixes #4570
2022-10-21 11:05:33 -05:00
Robert Sparks 3c191909ca
fix: stable and correct ordering of agenda items (#4621)
* fix: align session sorting across functions

* fix: sessions of a group can have different types
2022-10-21 11:04:27 -05:00
Lars Eggert 5ac3874ce9
fix: Format NomCom feedback table per suggestion of @richsalz (#4625)
Also makes table header alignment the same as for columns, site-wide.

Fixes #4529
2022-10-21 11:04:10 -05:00
Robert Sparks 26e2e23418
fix: reduce agenda data calculation time (#4622)
* fix: reduce agenda data calculation time

* doc: improve docstring for preprocess_assingments_for_agenda
2022-10-21 11:03:11 -05:00
Lars Eggert b1bafff2fb
fix: Add value attributes back to buttons to make the logic work (#4617) 2022-10-20 11:57:36 -05:00
Lars Eggert 160ca9286a
fix: Don't say that IESG processing has started (#4609)
* fix: Don't say that IESG processing has started

Fixes #4286

* Update ietf/doc/views_draft.py

Co-authored-by: Robert Sparks <rjsparks@nostrum.com>

* Update ietf/doc/views_draft.py

Co-authored-by: Robert Sparks <rjsparks@nostrum.com>

Co-authored-by: Robert Sparks <rjsparks@nostrum.com>
2022-10-20 09:02:09 -05:00
Lars Eggert 76b88b1658
fix: Replace some deprecated jQuery with recommended replacements (#4607) 2022-10-19 14:36:15 -05:00
Lars Eggert cf033352b4
fix: Tweak text as suggested by @richsalz (#4606)
Fixes #4531
2022-10-19 13:01:39 -05:00
Lars Eggert 0cc0281fe8
fix: Fix table sort functionality for tables with colspan attributes (#4605)
Fixes #4555
2022-10-19 11:59:09 -05:00
Robert Sparks 9b4903e2e6
fix: Fix incorrect "GDPR" features/terminology. Fixes #4521. (#4587)
* fix: remove help/personal-information and the prompt-for-consent email management command.

* fix: remove gdpr treatment except for consent checkbox. Rename Submit.

* fix: drom the consent column from Person and Person.History

* fix: remove the consent boolean. Reorganize the account info form.

* chore: reorder migrations
2022-10-18 13:27:19 -05:00
Lars Eggert 66533827e1
fix: Fix status change form (#4598)
* fix: Fix status change form

Also make it so that select2 search fields get focus when they open.

* Remove feat
2022-10-18 09:59:04 -05:00
Lars Eggert 5f7c585252
feat: Auto-focus select2 search fields when they open (#4599) 2022-10-18 09:42:00 -05:00
Robert Sparks cbb8da73c8
fix: regenerate correct shepherd template. Fixes #4558 (#4595)
* fix: regenerate correct shepherd template

* chore: remove unnecessary extra whitespace

* fix: improve readability of code per review comments
2022-10-18 07:57:08 -05:00
Jennifer Richards fffe0c1991
feat: disallow '/' from Person.name (#4594)
* feat: disallow '/' from Person.name

* chore: migrate Person/HistoricalPerson to include new name validator

* test: test name validation
2022-10-17 15:41:39 -05:00
Robert Sparks 57b30fb967
chore: bring the names test fixture into alignment with the current database (#4583) 2022-10-14 17:53:04 -05:00
Jennifer Richards 83db95c4b3
test: extend simulateDragDrop to support dataTransfer.types interface (#4571) 2022-10-13 10:58:20 -05:00
Robert Sparks 6dd6165444
fix: correct meeting attendance calculations (#4536)
* fix: correct meeting attendance calculations

* test: change meetingregistration factory defaults

* test: Setup stats tests to verify counts honor meeting.Attended

But the tests aren't actually looking to see what numbers get generated yet.

* test: add test for attendance cross-talk between meetings

* fix: limit attendance count query to single meeting

* refactor: rename attendance.online to .remote

* fix: only count a given person as onsite or remote, but never both

* test: align tests with cleanup

Co-authored-by: Jennifer Richards <jennifer@painless-security.com>
2022-10-13 10:55:57 -05:00
Robert Sparks 50668c97cd
feat: apis for attaching chatlogs and polls to session materials (#4488)
* feat: apis for attaching chatlogs and polls to session materials

* fix: anticipate becoming tzaware, and improve guard against attempts to provide docs for sessions that have no official timeslot assignment.

* fix: get chatlog upload to actually work

Modifications to several initial implementation decisions.
Updates to the fixtures.

* fix: test polls upload

Refactored test to reduce duplicate code

* fix: allow api keys to be created for the new endpoints

* feat: add ability to view chatlog and polls documents. Show links in session materials.

* fix: commit new template

* fix: typo in migration signatures

* feat: add main doc page handling for polls. Improve tests.

* feat: chat log vue component + embedded vue loader

* feat: render polls using Vue

* fix: address pug syntax review comments from Nick.

* fix: repair remaining mention of chat log from copymunging

* fix: use double-quotes in html attributes

* fix: provide missing choices update migration

* test: silence html validator empty attr warnings

* test: fix test_runner config

* fix: locate session when looking at a dochistory object for polls or chatlog

Co-authored-by: Nicolas Giard <github@ngpixel.com>
2022-10-13 09:20:36 -05:00
Jennifer Richards 0ad293d6e9
feat: add slides / session materials links to session details modal (#4535)
* feat: add propose/upload slides button to session details modal

* refactor: remove unneeded chaining operator

* test: fix quotes around template string

* feat: link to meeting materials page from AgendaDetailsModal

* refactor: compute session details URL in JS instead of view

* chore: restyle materials page link

* test: fix test case to match changes to session modal
2022-10-12 16:07:23 -05:00
Nicolas Giard 6f2114fb0c
feat: replace old agenda with agenda-neue (#4406)
* feat: remove old agenda (django-side)

* fix: bring in latest commits

* test: remove -neue from playwright tests

* test: remove agenda selenium js tests

* test: remove agenda views tests

* fix: remove deprecated agenda views (week-view, agenda-by, floor-plan)

* test: fix failing python tests

* test: remove more deprecated tests

* chore: remove deprecated templates

* test: remove unused import

* feat: handle agenda personalize with filter + move agenda specific stuff out of root component

* fix: redirect deprecated urls to agenda / floorplan

* feat: agenda - open picker mode when from personalize path

* fix: safari doesn't support device-pixel-content-box property on ResizeObserver

* test: move floor plan test into main agenda test

Co-authored-by: Robert Sparks <rjsparks@nostrum.com>
2022-10-12 15:46:28 -05:00
Jennifer Richards 8560bec09c
fix: remove spurious year after nominee name (#4565) 2022-10-12 13:29:08 -05:00
Robert Sparks c1556a3bc5
fix: revert photo-on-menubar enhancement (#4564)
* fix: revert photo-on-menubar enhancement

* fix: revert styling added for menubar photo.
2022-10-12 13:25:47 -05:00
Jennifer Richards 9709dbdf1c
fix: work around dataTransfer.getData limitation in agenda editor (#4553)
* fix: work around dataTransfer.getData limitation in agenda editor

* refactor: be slightly more careful checking dataTransfer type

* chore: remove debug statement
2022-10-10 08:48:23 -05:00
Lars Eggert eed58c9753
ui: Add rounded-pill to a few more badges (#4539) 2022-10-10 08:37:58 -05:00
Robert Sparks 97d21800d0
feat: include checkins at the registration desk in nomcom eligibility calculations (#4519)
* chore: rename utility functions to reflect rfc guiding them

* feat: include new checkedin flag in nomcom calculations

* fix: reflect history a bit more accurately.

* fix: address review comment on readability

* fix: finish what c44000d started
2022-10-07 16:17:28 -05:00
Jennifer Richards cb9e576fb4
fix: return False from has_role() when role_names is the empty list (#4541)
* fix: return False from has_role() when role_names is the empty list

* chore: add comments clarifying the effect of Q()
2022-10-07 16:05:37 -05:00
Lars Eggert 15a1d3e379
chore: Update deps (bs to 5.2.2, various others) (#4537)
Also fix html-validate, which now wants a `.json` suffix on config files.
2022-10-07 16:05:04 -05:00
Lars Eggert 43e4a26ca0
fix: Don't show ADs as part of "bethere" contraints. (#4540)
Also tweak some minor UI stuff while I'm here.
2022-10-07 16:02:29 -05:00
Jennifer Richards 0bdfb25c47
feat: include proposed WGs on meeting requests page (#4551) 2022-10-07 15:56:43 -05:00
Jennifer Richards 6cc2fb94a3
fix: update DraftYangChecker for xym 0.6 changes (#4546)
* fix: update DraftYangChecker for xym 0.6 changes

* chore: update xym requirements to >=0.6
2022-10-06 18:03:18 -05:00
Lars Eggert 8a6ff176af
fix: Add reminder to not include ADs in "people who must be present" (#4527)
* fix: Add reminder to not include ADs in "people who must be present"

* Fix typo.
2022-09-30 12:55:36 -05:00
Robert Sparks 2058522a0c
feat: stop setting MeetingRegistration.attended on MeetEcho login. (#4526)
* feat: stop setting MeetingRegistration.attended on MeetEcho login.

We capture attendence through MeetEcho using meeting.Attended now.

* chore: remove unused import

* chore: remove unused import
2022-09-30 10:46:49 -05:00
Jennifer Richards f043797742
fix: include IRTF and BoF groups on meeting requests page (#4528)
* fix: include IRTF and BoF groups on meeting requests page

* test: test bof/irtf groups on the meeting requests page

* chore: remove some accidentally committed changes

* style: improve formatting of requests.html template
2022-09-30 10:08:11 -05:00
Lars Eggert 3e2b1fc92e
feat: Add a bug report link to the menu bar (#4525)
This required making some horizontal room for it, mostly by showing a
user photo or shorter tag when they are logged in.
2022-09-30 09:20:43 -05:00
Robert Sparks 9b896e5869
fix: avoid emptying nomcom session key when openssl complains about derivation (#4524) 2022-09-30 08:05:01 -05:00
Lars Eggert feab9fb385
fix: Fix state order in AD dashboard and colorize some more trends (#4518) 2022-09-29 15:10:51 -05:00
Robert Sparks 9162302941
fix: don't include liaison attachments in main page searches. Fixes #4373. (#4502) 2022-09-27 10:27:50 -05:00
Lars Eggert 2b5a7c0447
ui: Improve the display of information on /meeting/requests (#4493) 2022-09-26 16:54:41 -05:00
Jennifer Richards d7bdffc89d
chore: import jquery so dynamic_inlines.js source map works (#4482) 2022-09-21 12:04:39 -05:00
Robert Sparks 5c8545eecb
feat: use hmac, sha256, and a better secret for published nomcom hashes. (#4475)
* feat: use hmac, sha256, and a better secret for published nomcom hashes.

* fix: avoid using django secret key for a different secret context

* fix: Only strip the newline

* fix: improve readability by using rstrip
2022-09-20 12:09:11 -05:00
Robert Sparks 7bc6f2b6b2
fix: return same bibxml for versioned and versionless references (#4470)
* fix: return same bibxml for versioned and versionless references

Fixes #4384.

Refactors bibxml production to remove repeated logic.

Abandons the half-implemented idea that returning information
from the Submission object might be better than the Document or
DocHistory objects.

* fix: test for None with `is not` and simplify choice from multiple qs objects

Addresses review comments.
2022-09-19 10:38:57 -05:00
Jennifer Richards 4dd220b980
fix: restore "add another" button on secr rooms and rolodex edit pages (#4467)
* fix: replace inline JS for "Add another" on secr rooms page

* fix: update rolodex edit page to re-enable "Add another" button

* refactor: use new class instead of reusing inline-related

The "inline-related" class has styling rules, etc. To avoid accidental
styling changes, use "dynamic-inline" as a class to indicate which tr
elements should be managed.
2022-09-16 12:35:32 -05:00
Lars Eggert 4a68b92c03
fix: Add <pre> to restore mailtrigger indentation (#4454)
* fix: Add <pre> to restore mailtrigger indentation

Fixes #4452

* Switch tag order
2022-09-15 12:28:08 -05:00
Ryan Cross 5b6695a04c
fix: save MeetingRegistration.checkedin as boolean value (#4446) 2022-09-14 09:55:08 -05:00
Lars Eggert 79bf320acc
fix: Only show ADs when assigning ADs for groups (#4440)
* fix: Only show ADs when assigning ADs for groups

Fixes #4302

* Fix test failure
2022-09-13 09:54:12 -05:00
Lars Eggert 5fcf2aa44a
ui: Hyphenate table headers, and optionally force-wrap them (#4441) 2022-09-13 09:07:21 -05:00