Jennifer Richards
da70acfdff
Merge branch 'feat/tzaware' into jennifer/yet-more-tz-fixes
...
# Conflicts:
# ietf/ietfauth/utils.py
# ietf/meeting/tests_views.py
# ietf/stats/tests.py
2022-10-17 16:39:45 -03:00
Jennifer Richards
f3bdbf0ed4
Merge branch 'feat/tzaware' into jennifer/main-for-tzaware-merge
...
# Conflicts:
# ietf/meeting/tests_js.py
# ietf/meeting/tests_models.py
# ietf/meeting/tests_views.py
# ietf/meeting/views.py
# ietf/name/fixtures/names.json
# ietf/templates/meeting/agenda.html
# ietf/templates/meeting/session_buttons_include.html
# ietf/templates/meeting/timeslot_start_end.html
2022-10-14 16:35:57 -03:00
Robert Sparks
6dd6165444
fix: correct meeting attendance calculations ( #4536 )
...
* fix: correct meeting attendance calculations
* test: change meetingregistration factory defaults
* test: Setup stats tests to verify counts honor meeting.Attended
But the tests aren't actually looking to see what numbers get generated yet.
* test: add test for attendance cross-talk between meetings
* fix: limit attendance count query to single meeting
* refactor: rename attendance.online to .remote
* fix: only count a given person as onsite or remote, but never both
* test: align tests with cleanup
Co-authored-by: Jennifer Richards <jennifer@painless-security.com>
2022-10-13 10:55:57 -05:00
Jennifer Richards
7b1b7f5273
Merge branch 'feat/tzaware' into dev/tzaware-main-merge
2022-10-11 14:57:34 -03:00
Robert Sparks
97d21800d0
feat: include checkins at the registration desk in nomcom eligibility calculations ( #4519 )
...
* chore: rename utility functions to reflect rfc guiding them
* feat: include new checkedin flag in nomcom calculations
* fix: reflect history a bit more accurately.
* fix: address review comment on readability
* fix: finish what c44000d started
2022-10-07 16:17:28 -05:00
Robert Sparks
9b896e5869
fix: avoid emptying nomcom session key when openssl complains about derivation ( #4524 )
2022-09-30 08:05:01 -05:00
Jennifer Richards
a653582cf7
fix: timezone fixes from last few comparisons with tzaware-obe
2022-09-28 13:21:50 -03:00
Jennifer Richards
ca1320f303
chore: merge main into feat/tzaware
...
chore: merge main into feat/tzaware
2022-09-22 12:21:38 -03:00
Robert Sparks
5c8545eecb
feat: use hmac, sha256, and a better secret for published nomcom hashes. ( #4475 )
...
* feat: use hmac, sha256, and a better secret for published nomcom hashes.
* fix: avoid using django secret key for a different secret context
* fix: Only strip the newline
* fix: improve readability by using rstrip
2022-09-20 12:09:11 -05:00
Jennifer Richards
32054111df
fix: fix failing tests and eliminate naive datetime warnings ( #4402 )
...
* test: fix timestamp construction in several doc tests
* refactor: rename date2datetime to datetime_from_date and clarify code
* chore: helper to get tzinfo for PRODUCTION_TIMEZONE
* fix: fix timezone handling in make_last_call()
* test: fix datetime generation in doc.tests_charter
* refactor: remove PRODUCTION_TIMEZONE setting
Replaces the PRODUCTION_TIMEZONE setting with a constant,
DEADLINE_TZINFO, in ietf.utils.timezone.
* test: be more careful about timezone in tests_charter.py
* test: be more careful about timezone in doc/tests.py
* fix: fix timezone handling affecting doc.tests_draft
* fix: fix timezone handling affecting tests_irsg_ballot.py
* fix: fix timezone handling affecting tests_review.py
* fix: fix timezone handling affecting last ietf.doc tests
* fix: fix timezone handling affecting last ietf.group tests
* fix: fix timezone handling affecting ietf.iesg tests
* fix: handle timezones in get_8989_eligibility_querysets
* fix: handle timezones affecting ietfauth tests
* fix: return tz-aware datetime from utc_from_string
* fix: specify timezone for constants in ipr_rfc_number()
* fix: specify tz for ipr deadlines
* fix: handle timezones affecting liaisons tests
* fix: treat leap day in get_8989_eligibility_querysets()
Manual cherry-pick of 248d6474
* test: treat leap day properly in nomcom tests
* fix: fix timezone handling affecting nomcom tests
* test: fix timezone handling in review tests
* fix: fix timezone handling affecting secr.meetings tests
* fix: handle both pytz and zoneinfo timezones in ietf.utils.timezone
* fix: fix timezone handling affecting secr.proceedings tests
* refactor: use make_aware() helper in secr.meetings tests
* test: fix timezone handling in secr.telechat tests
* fix: fix timezone handling affecting stats tests
* fix: eliminate tz-naive helpers affecting sync email parsing
* fix: include timezone data when serializing DeletedEvent data
* fix: fix timezone handling affecting sync tests
* style: remove unused import
2022-09-01 13:07:28 -03:00
Jennifer Richards
b85ecce89f
fix: treat leap day properly in nomcom eligibility calc ( #4393 )
...
* fix: treat leap day in get_8989_eligibility_querysets()
* test: treat leap day properly in nomcom tests
2022-08-31 16:03:38 -05:00
Jennifer Richards
ebebdbed3e
refactor: replace datetime.now and datetime.today with timezone.now ( #4211 )
...
* refactor: replace datetime.now with timezone.now
* refactor: migrate model fields to use timezone.now as default
* refactor: replace datetime.today with timezone.now
datetime.datetime.today() is equivalent to datetime.datetime.now(); both
return a naive datetime with the current local time.
* refactor: rephrase datetime.now(tz) as timezone.now().astimezone(tz)
This is effectively the same, but is less likely to encourage accidental
use of naive datetimes.
* refactor: revert datetime.today() change to old migrations
* refactor: change a missed datetime.now to timezone.now
* chore: renumber timezone_now migration
* chore: renumber migrations
2022-08-25 13:45:16 -03:00
Jim Fenton
3aab73d862
feat(nomcom): Allow nomcom chair to turn volunteer acceptance on and off ( #4251 )
...
* feat(nomcom): Allow nomcom chair to turn volunteer acceptance on and off
Fixes #4105
Also allows chair to set date of first call for volunteers. If this should be read-only and set by the code, let me know.
* fix(nomcom): Correct helptext for accepting volunteers
2022-07-24 08:51:57 -05:00
Robert Sparks
fe1f51aede
fix: Compute 8989 eligibility using actual attendance data. ( #4236 )
2022-07-21 12:58:32 -05:00
Robert Sparks
18bf87ea5e
feat: improve the admin for the nomcom volunteer model ( #4223 )
...
* feat: improve the admin for the nomcom volunteer model
* fix: restore raw-id for person on nomcom volunteer admin.
2022-07-18 08:36:34 -05:00
Robert Sparks
b988850985
fix: avoid mutables as defaults. Compute date default arguments at runtime rather than loadtime. ( #4144 )
2022-07-06 14:39:36 -05:00
Robert Sparks
087265118d
feat: csv export of nomcom volunteers. Fixes #4127 . ( #4146 )
2022-07-06 14:13:41 -05:00
Robert Sparks
07bfa68a75
feat: explicitly model session attendance ( #4025 )
...
* feat: add model to track session attendance
* feat: add model to track session attendance
* feat: add api to set session attendees
* fix: use user pk instead off person pk in the attended api.
* feat: calculate three of five from attended
* feat: management utility to populate Attended model history
* docs: document why nomcom calculations don't use Attended yet.
* fix: add migration to add new personalapikey endpoint to choices
* test: verify very old last login prevents api key use,
* chore: address review nits
* chore: comment on some idiosyncracies of the expected input to populate_attended
* fix: add unique_together constraint for the Attended model
* fix: correctly handle empty querysets passed to three_of_five_eligible functions.
2022-06-20 10:46:36 -05:00
Lars Eggert
de7ff7e84e
test: fix more validation issues ( #3975 )
...
* fix: Avoid numeric IDs on NomCom pages
* fix: Correctly group last names with lowercase/i18n parts
* Remove some unneeded CSS
* fix: Remove extra div closing tag
2022-05-18 10:58:39 -05:00
Jennifer Richards
681fae2af5
test: decode email payloads before validating ( #3926 )
2022-05-03 09:29:42 -05:00
Robert Sparks
66feccbc67
test: avoid edge case in test factory. Fixes #3513 . ( #3736 )
2022-03-24 09:13:33 -03:00
Jennifer Richards
6c260a5b7e
Merge 7.45.1.dev0 into Bootstrap 5 update branch. Made a first pass at reconciling differences.
...
- Legacy-Id: 19945
2022-02-17 20:09:49 +00:00
Lars Eggert
335a39d4fc
More fixes.
...
- Legacy-Id: 19884
2022-01-28 13:00:47 +00:00
Lars Eggert
5132661b06
More test fixes
...
- Legacy-Id: 19803
2022-01-05 11:25:25 +00:00
Lars Eggert
c68446ae93
More select2 and test fixes.
...
- Legacy-Id: 19781
2021-12-14 18:19:12 +00:00
Lars Eggert
f974fd3c04
Fix more things
...
- Legacy-Id: 19762
2021-12-09 06:41:00 +00:00
Jennifer Richards
8759955597
Allow nomcom chair to edit liaisons as well as members and generate GroupEvents when changed. Share code between group and nomcom for this purpose. Fixes #3376 . Commit ready for merge.
...
- Legacy-Id: 19710
2021-11-24 16:40:05 +00:00
Jennifer Richards
dcf4251363
Better handle invalid character encodings in process_email and feedback_email commands. Add tests of this using stdin. Commit ready for merge.
...
- Legacy-Id: 19694
2021-11-19 00:41:05 +00:00
Lars Eggert
333d1c40ac
Merge ^/personal/lars/7.39.1.dev3
...
- Legacy-Id: 19649
2021-11-12 11:55:55 +00:00
Robert Sparks
181da11a5c
Use rfc8989 for 2022 nomcom eligibility. Fixes #3442 . Commit ready for merge.
...
- Legacy-Id: 19621
2021-11-10 14:59:33 +00:00
Lars Eggert
bb5810a934
Labels are badges in bs5.
...
- Legacy-Id: 19616
2021-11-10 11:15:46 +00:00
Jennifer Richards
81d9234d54
Use temporary directories instead of "real" filesystem for tests. Fixes #3414 . Commit ready for merge.
...
- Legacy-Id: 19555
2021-11-05 19:45:57 +00:00
Jennifer Richards
968b775315
Create management command base class that sends emails on exceptions. Fixes #3356 and #3357 . Commit ready for merge.
...
- Legacy-Id: 19493
2021-10-29 01:58:21 +00:00
Robert Sparks
b99eecc1ae
Bring the factory-boy and Faker dependencies forward through some minor breaking changes. Stop using the deprecated fr_QC locale in Faker. Commit ready for merge.
...
- Legacy-Id: 19270
2021-08-03 22:22:35 +00:00
Robert Sparks
d5ad189a10
Merged in [19148] from rjsparks@nostrum.com:
...
Bring the nomcom factories and tests into agreement around what a valid year for a nomcom can be. Fixes #3315 .
- Legacy-Id: 19149
Note: SVN reference [19148] has been migrated to Git commit 76a8a29756
2021-06-23 17:17:34 +00:00
Robert Sparks
76a8a29756
Bring the nomcom factories and tests into agreement around what a valid year for a nomcom can be. Fixes #3315 . Commit ready for merge.
...
- Legacy-Id: 19148
2021-06-23 16:17:09 +00:00
Robert Sparks
2689670546
Merged in [19139] from rjsparks@nostrum.com:
...
Refine volunteer list view. Show rfc8989 paths.
- Legacy-Id: 19147
Note: SVN reference [19139] has been migrated to Git commit 06f6b12b18
2021-06-23 15:54:45 +00:00
Robert Sparks
06f6b12b18
Refine volunteer list view. Show rfc8989 paths. Commit ready for merge.
...
- Legacy-Id: 19139
2021-06-22 20:09:40 +00:00
Jennifer Richards
d4271e0525
Skip populate_volunteers forward migration if nomcom2021 is not in the database. Fixes #3306 . Commit ready for merge.
...
- Legacy-Id: 19132
2021-06-15 12:37:23 +00:00
Robert Sparks
4dcd2cbaa6
Merged in [19104] from rjsparks@nostrum.com:
...
Allow people to volunteer for NomCom via the datatracker.
- Legacy-Id: 19109
Note: SVN reference [19104] has been migrated to Git commit 86102b9980
2021-06-10 23:12:01 +00:00
Robert Sparks
86102b9980
Allow people to volunteer for NomCom via the datatracker. Commit ready for merge.
...
- Legacy-Id: 19104
2021-06-10 20:35:50 +00:00
Robert Sparks
b8771006b3
Merged in [18999] from rjsparks@nostrum.com:
...
Correct invalid date assumption in rfc8989 eligibility tests.
- Legacy-Id: 19001
Note: SVN reference [18999] has been migrated to Git commit 53fa35c148e2d9a3a01987601de5d20edb0c401f
2021-05-18 18:00:40 +00:00
Robert Sparks
fd38a9bf96
Add RFC 8989 nomcom eligibility calculations. Commit ready for merge.
...
- Legacy-Id: 18975
2021-05-06 19:42:09 +00:00
Robert Sparks
fe82f4d696
connect the new calculations to the UI. Clean flakes.
...
- Legacy-Id: 18974
2021-05-06 19:00:58 +00:00
Robert Sparks
bcc280fe9b
tightened edge for group office rule
...
- Legacy-Id: 18972
2021-05-06 13:51:29 +00:00
Robert Sparks
216ec499df
Checkpointing. Remaining work: convert meetingregistation fixup to a migration and a mgmt comment. Flesh out testing of 8989 rule 2 and fix the known edge case bug. Remove old implementation and connect UI to the new implementation.
...
- Legacy-Id: 18971
2021-05-01 19:57:04 +00:00
Robert Sparks
3697180cc1
Reverted merge of timezone-aware migration efforts.
...
- Legacy-Id: 18792
2021-01-12 16:54:20 +00:00
Henrik Levkowetz
774e752a54
Snapshot of timezone-aware datatracker code. Tests pass, and the test-crawler shows only expected differences. Trunk changes merged in up to r18768.
...
- Legacy-Id: 18770
2020-12-16 23:53:37 +00:00
Henrik Levkowetz
088033d843
Added matching indexes to a number of models with ordering by multiple keys.
...
- Legacy-Id: 18664
2020-11-09 19:41:12 +00:00
Henrik Levkowetz
f4b90c0dc8
Nomcom topic responses didn't save respondent because of a missing form creation parameter. Fixed.
...
- Legacy-Id: 18652
2020-10-31 19:49:56 +00:00