Commit graph

117 commits

Author SHA1 Message Date
Robert Sparks da3e916f72 Moves the prefix for the URI to use for rfcdiff into settings.py.
Fixes bug #808
 - Legacy-Id: 4701
2012-07-28 20:19:36 +00:00
Henrik Levkowetz 798f7697af Merged [4600] from rjsparks@nostrum.com:
* Adds a new document type for conflict reviews, with a ballot for the IESG 5742 response to a review request
* Integrated the new document type into the iESG agenda views (including RSS feeds)* Removed the Edit and Add buttons from the document main view.
* Replaced Add with actions appropriate for the document type, such as "Begin IESG Processing" or "Begin IETF Conflict Review", and made most data directly editable on the document's main page, depending on access permissions.
* Removed a manual editing step that the secretariat had to perform when sending conflict review messages. The view now composes the message correctly given the stream.
* Added a pencil icon motif to differentiate fields that are editable.
* Generalized several views and helper functions to use Document instead of (e.g.) IdWrapper
* Generalized reading documents from the repository
* Added a way to get from IdWrapper  to the underlying Document to facilitate migrating way from the Wrapper classes* Added many helpers to Document to assist with migrating off IdWrapper
* Minor fixes and other changes
  * Fixes to document main view to avoid (silent) template failures. 
  * Began removing some of the code that is no longer reachable post-migration  * Corrected the behavior of the undefer code and added test cases for it
  * Improved initial population of notification lists and added the ability to regenerate the initial list
* Made the test code that scans for template coverage more robust
* Deployment notes:
  * new setting: CONFLICT_REVIEW_PATH. The associated directory will need to be created

This branch fixes bugs #805, #744 and #812
 - Legacy-Id: 4652
Note: SVN reference [4600] has been migrated to Git commit 798e7a50e7
2012-07-28 16:29:28 +00:00
Henrik Levkowetz a554288faf Tweaked the I-D submission confirmation email some more, to be able to update the test suite to find the confirmation URL in the message.
- Legacy-Id: 4645
2012-07-27 22:48:56 +00:00
Henrik Levkowetz 0c49999fc9 Updated utils/draft.py and modified the submit app code accordingly.
New features (keep in mind that utils/draft.py can be run standalone
to do extraction of draft author data, too):

  * The handling of author info formatted in columns causes problems
    in the face of an author named for instance A. Author with the
    company 'Al Author and Associates', causing breakage of email
    addresses longer than 'Al Author and'.  Tweaked the recognition
    of column data to require multiple (not only one) space around
    'and'.

  * Added support for extraction of author affiliation.

  * Tweaked the meaning of -t, --timestamp and added --notimestamp; and
    made the default be to emit leading timestamps based ont the draft
    file time.

  * Added support for running author extraction on RFCs, by not bailing
    out on not finding a draft name when RFC information is available.

  * Added support for additional date formats and author name formats.

  * Improved creation date extraction -- previously, the first supported
    date format which was recognized on the first page of the draft would
    be used, rather than the first date in a supported format.  This could
    cause errors if the Status of Memo section or Abstract contained a
    date occurring at the start of a line.

  * Tweaked the honorific regex to make things work better for the case
    when the full name in the author's address section includes a first
    name which isn't part of the first-page abbreviated name.  Fixes
    problems with draft-chiappa-lisp-introduction and similar.

  * Added a special case for people who provide their email address as
    'foo&cisco.com' instead of 'foo@cisco.com'.  Bah.

  * Added an alternative, more human-readable key-value-pair attribute
    output mode with a '-a' switch.

  * Tweaded the first-name regex to capture cases where the first name
    is indicated with an alternate first letter: 'Y(J) Stein'.  Fixes
    problems with draft-anavi-tdmoip and similar.
 - Legacy-Id: 4612
2012-07-11 12:51:33 +00:00
Henrik Levkowetz 6bc68a9a51 Behave slightly more gracefully if a submission has already been moved into place, and we're asked to do it again.
- Legacy-Id: 4548
2012-06-28 19:22:59 +00:00
Henrik Levkowetz 7474b27348 Merged in branch/iola/approval from olau@iola.dk, which provides a pre-approval page for new WG drafts.
- Legacy-Id: 4486
2012-06-21 00:24:48 +00:00
Henrik Levkowetz afe3ee71b8 Merged in fixes from Ole, from branch/charter:r4382-4407, and some changes from Henrik (removing the use of pos.blocked in views_ballot.py, and setting a ballot id in idrfc/testsREDESIGN.py) to make idrfc.EditPositionTestCase succeed.
- Legacy-Id: 4444
2012-06-10 16:22:16 +00:00
Ole Laursen ed96cee2e4 Add listing of recently approved drafts to approval page by request
from Barry Leiba.
 - Legacy-Id: 4420
2012-05-14 18:21:34 +00:00
Ole Laursen c2b8c653fd Fix bug in submit, had forgotten I had replaced filename with name in
Preapproval model.
 - Legacy-Id: 4413
2012-05-10 18:22:03 +00:00
Ole Laursen 188c0846d0 Add approval/pre-approval page for Secretariat and WG Chairs, with
subpages for adding and canceling pre-approvals and a set of
migrations for replacing the old IdApprovedDetail with a slightly less
confusing Preapproval model.
 - Legacy-Id: 4411
2012-05-10 18:07:59 +00:00
Ole Laursen da3c40de49 Fix test error introduced by ballot refactor (test didn't set up
ballot position properly).
 - Legacy-Id: 4405
2012-05-07 19:21:26 +00:00
Henrik Levkowetz 29b4090bac Add an assertion in the test code to explicitly check that we have an OK idnits result.
- Legacy-Id: 4298
2012-04-22 14:17:27 +00:00
Henrik Levkowetz 896c1272c8 Indicate UTC on passed cut-off time and reopening time.
- Legacy-Id: 4155
2012-03-21 14:24:37 +00:00
Ole Laursen 0bc71c7146 Fix problem with concurrent posts as reported in #813 by preventing
accidentally submitting a post twice (with Javascript) and modifying the
move-old-files-to-archive code to not move the files away if they
belong to the same submission as the one we're accepting (this
mitigates a concurrent post to at least not end up with a non-existing
draft).
 - Legacy-Id: 4112
2012-03-16 17:22:33 +00:00
Ole Laursen e7cf907c94 Only set state "WG Document" on revision 00 documents, fixes problem
with overwriting manually set WG states when a new version is
submitted. Fixes #797.
 - Legacy-Id: 4074
2012-03-12 12:08:48 +00:00
Ole Laursen 117eac031a Be a bit more careful with handling the submitter info as well as it
turns out there are some (although apparently all old) entries with
author_order = 0
 - Legacy-Id: 4015
2012-03-01 18:06:38 +00:00
Ole Laursen 3ebee25c2a Handle users without a profile gracefully
- Legacy-Id: 4014
2012-03-01 17:47:02 +00:00
Ole Laursen 08a3ec7687 Work around problems if a document has two authors connected who's the
same person (fix the data issue rather than throwing an exception)
 - Legacy-Id: 4013
2012-03-01 17:18:37 +00:00
Ole Laursen 124b398729 Guard against None coming out of the draft parser, we need to convert
that into an empty string, fixes #775.
 - Legacy-Id: 3997
2012-02-28 18:37:22 +00:00
Ole Laursen 0144bcd05b Only set wg-doc on WG documents
- Legacy-Id: 3980
2012-02-26 21:32:24 +00:00
Ole Laursen cb1b56d912 Fix bug if we weren't able to deduce a stream
- Legacy-Id: 3979
2012-02-26 14:22:44 +00:00
Ole Laursen f05bc8cf1f Add "Assigned to area" select box to individually submitted documents
in the AD edit form, change search to define area = doc.group or
doc.group.parent (so don't take AD into account), plus a bunch of
small tweaks to make a document with an area set as group behave like
an individually submitted document, at least for the time being (they
are presented as "Individual in xyz area" on their document page)
 - Legacy-Id: 3968
2012-02-25 01:48:33 +00:00
Ole Laursen 480cb04cd6 Save announcements generated by the system as Messages, adding an
extra relation to be able to associate a draft with the message
 - Legacy-Id: 3917
2012-02-08 21:05:28 +00:00
Ole Laursen fd0b52df49 Add db_index to IdApprovedDetail.filename too
- Legacy-Id: 3871
2012-01-26 22:18:53 +00:00
Ole Laursen 172f209112 Add db_index to IdSubmissionDetail.filename
- Legacy-Id: 3870
2012-01-26 22:16:48 +00:00
Ole Laursen 980d4e6444 Move new schema models from redesign/ to ietf/
- Legacy-Id: 3855
2012-01-24 17:17:24 +00:00
Ole Laursen 819395928e Be more conservative in estimating the stream, for individual
submissions we should not set a stream but let it be decided later on
 - Legacy-Id: 3853
2012-01-24 13:19:25 +00:00
Ole Laursen 252513679d Don't assign independent IETF submission to the ISE stream
- Legacy-Id: 3845
2012-01-20 18:45:30 +00:00
Ole Laursen 923239a5dc Clean up old draft files when submitting a new draft
- Legacy-Id: 3811
2012-01-13 16:38:00 +00:00
Ole Laursen dceedbf53d Remove tombstone support from the code, importing drafts with their
version number unhacked
 - Legacy-Id: 3803
2012-01-12 16:50:26 +00:00
Ole Laursen f3685e7af1 Turn expiration into an explicit expires attribute on document, set
that on submission of new revision and resurrection
 - Legacy-Id: 3801
2012-01-12 12:03:45 +00:00
Ole Laursen 0dabaf96fb Split database into current and legacy, adding importer to copy reused
tables from legacy to new through Django (with minimal cleaning to
have the import go through) and removing migrations from submit and
liaisons as they interfere with the clean slate of the new database,
adjusting IPR model to add null=True on fields with nulls in the
database
 - Legacy-Id: 3778
2011-12-22 18:34:19 +00:00
Ole Laursen 498dc38507 Port to Django 1.2, replacing built-in patched Django with Django 1.2.7 (with patches applied on top) and replacing South with South 0.7.3
- Legacy-Id: 3773
2011-12-15 14:13:54 +00:00
Ole Laursen f74890aec4 Adjust to handle the slightly revamped email_address() on person
- Legacy-Id: 3750
2011-12-07 19:26:53 +00:00
Ole Laursen 3ed02196d7 Fix some instances where we use a non-role email for ADs in spite of them acting as ADs
- Legacy-Id: 3741
2011-12-06 14:01:44 +00:00
Ole Laursen 8153a1c130 Patch up to pass request object to send mail in the instances where
it's possible (i.e. when not run in cron) in preparation for better
mail test handling
 - Legacy-Id: 3711
2011-11-25 18:24:14 +00:00
Ole Laursen a8e219e16a Rename DocStreamName to StreamName, they're not really doc-specific
- Legacy-Id: 3707
2011-11-25 12:25:35 +00:00
Ole Laursen 5a4c23ea92 Merge with trunk
- Legacy-Id: 3676
2011-11-21 16:41:21 +00:00
Ole Laursen 5d291f222c Remove .state and .*_state on Document in favour of generic states
mapping, port the codebase to use these states
 - Legacy-Id: 3660
2011-11-16 18:18:06 +00:00
Henrik Levkowetz 945ef49db6 Be more specific about the submission startup time on meeting Monday. Indicate time and timezone for more cases on the submission form.
- Legacy-Id: 3628
2011-11-16 04:48:12 +00:00
Ole Laursen ce74be89ef Use the test mode in the mail code when running automated tests instead of
reinventing the wheel in test_runner
 - Legacy-Id: 3620
2011-11-15 11:24:33 +00:00
Ole Laursen ea7f45d56e Port ietfworkflows and wgchairs to new schema, fix missing state
setting in I-D submission, add tests
 - Legacy-Id: 3617
2011-11-14 19:40:20 +00:00
Henrik Levkowetz 35f89e0288 Improved handling of a particular IO Error that sometimes occur during draft submission.
- Legacy-Id: 3552
2011-10-28 08:47:28 +00:00
Henrik Levkowetz eae680f3ac Revert part of the change to this view -- there was a reason for catching the IOException, but it caught much more than was good...
- Legacy-Id: 3517
2011-10-25 16:12:48 +00:00
Henrik Levkowetz 750f5e4ff0 Tweaked various message strings. Also made the cut-off messages use the actual hour defined in settings, rather than a hardcoded string saying '5 PM (PT)' ...
- Legacy-Id: 3515
2011-10-25 15:00:08 +00:00
Henrik Levkowetz f3d31f0e97 Don't hide exceptions by returning a blank form when something goes wrong -- there's been temporary upload failures for some time, which have been difficult to trace and debug because the error condition has been hidden.
- Legacy-Id: 3514
2011-10-25 14:57:35 +00:00
Ole Laursen 76dd5aa53b Set the stream when submitting a document
- Legacy-Id: 3512
2011-10-25 14:32:03 +00:00
Henrik Levkowetz c89f9207b9 Fix a wrong settings variable (introduced when merging code from the yaco idsubmit branch for v3.61). Refine the error report for failures to move files from staging to repository.
- Legacy-Id: 3511
2011-10-25 14:22:51 +00:00
Henrik Levkowetz ed49393773 Refine the admin list page for submission details a bit.
- Legacy-Id: 3510
2011-10-25 14:20:26 +00:00
Henrik Levkowetz 34dfae8d23 Merged [3380] from esanchez@yaco.es:
Check for missed files on staging area. Fixes #707
 - Legacy-Id: 3447
Note: SVN reference [3380] has been migrated to Git commit 0d241bd7c0abf8942d5c121aa9dda5ee34cf75ae
2011-10-13 15:38:50 +00:00