Commit graph

224 commits

Author SHA1 Message Date
Robert Sparks da3e916f72 Moves the prefix for the URI to use for rfcdiff into settings.py.
Fixes bug #808
 - Legacy-Id: 4701
2012-07-28 20:19:36 +00:00
Henrik Levkowetz 798f7697af Merged [4600] from rjsparks@nostrum.com:
* Adds a new document type for conflict reviews, with a ballot for the IESG 5742 response to a review request
* Integrated the new document type into the iESG agenda views (including RSS feeds)* Removed the Edit and Add buttons from the document main view.
* Replaced Add with actions appropriate for the document type, such as "Begin IESG Processing" or "Begin IETF Conflict Review", and made most data directly editable on the document's main page, depending on access permissions.
* Removed a manual editing step that the secretariat had to perform when sending conflict review messages. The view now composes the message correctly given the stream.
* Added a pencil icon motif to differentiate fields that are editable.
* Generalized several views and helper functions to use Document instead of (e.g.) IdWrapper
* Generalized reading documents from the repository
* Added a way to get from IdWrapper  to the underlying Document to facilitate migrating way from the Wrapper classes* Added many helpers to Document to assist with migrating off IdWrapper
* Minor fixes and other changes
  * Fixes to document main view to avoid (silent) template failures. 
  * Began removing some of the code that is no longer reachable post-migration  * Corrected the behavior of the undefer code and added test cases for it
  * Improved initial population of notification lists and added the ability to regenerate the initial list
* Made the test code that scans for template coverage more robust
* Deployment notes:
  * new setting: CONFLICT_REVIEW_PATH. The associated directory will need to be created

This branch fixes bugs #805, #744 and #812
 - Legacy-Id: 4652
Note: SVN reference [4600] has been migrated to Git commit 798e7a50e7
2012-07-28 16:29:28 +00:00
Henrik Levkowetz fe185af8eb Added new RFC-Editor state tag 'AUTH48-DONE' to the rfc-ed-queue mirror script.
- Legacy-Id: 4636
2012-07-27 21:20:23 +00:00
Henrik Levkowetz 225e1a8e3a Reverting previous commit, going back to rev 4633. (Commit all made in error, only one file intended).
- Legacy-Id: 4635
2012-07-27 21:16:12 +00:00
Henrik Levkowetz 3176bea4a1 Added new RFC-Editor state tag 'AUTH48-DONE' to the rfc-ed-queue mirror script.
- Legacy-Id: 4634
2012-07-27 21:08:01 +00:00
Henrik Levkowetz 7a96c77284 Updated the EditPositionTestCase to match the removed view alias for edit_position.
- Legacy-Id: 4633
2012-07-27 20:41:01 +00:00
Henrik Levkowetz 5d97058c8b Applied ballot popup patch from olau@iola.dk.
- Legacy-Id: 4629
2012-07-27 20:09:23 +00:00
Henrik Levkowetz a1ea63c16a Ballot ids are limited to integers, rather than being descriptive as intended at one point. Adjusted the url regexes accordingly. Patch from olau@iola.dk.
- Legacy-Id: 4610
2012-07-10 09:52:56 +00:00
Robert Sparks e76136ff3b Fixed reverse urls in tests, removed a commented out block from a template, fixed a typo in a directory setting
- Legacy-Id: 4599
2012-07-05 20:40:41 +00:00
Robert Sparks c93e6a764a Made the popup position editing dialog work correctly for non-draft document types
- Legacy-Id: 4597
2012-07-05 19:28:40 +00:00
Robert Sparks f3fd4db35c Merge forward complete - checkpointing before fixing popup position dialogs
- Legacy-Id: 4595
2012-07-04 19:35:46 +00:00
Henrik Levkowetz 26705dee99 When logged in as secretariat, at /iesg/agenda/ or /iesg/agenda/documents/, and clicking on the position matrix for a document, the overlay window would give a code 500 error, because of a missing ballot id in the templates' url lookup. Fix this by providing the ballot id.
- Legacy-Id: 4576
2012-07-03 21:35:51 +00:00
Henrik Levkowetz 6a58f8ec20 Start getting rid of the name= parameter of the urlconf. At first they look helpful, but it's a great bother to have to search for where every damn name is, instead of just reading it out of the code in the template or urlreverse.
- Legacy-Id: 4575
2012-07-03 20:27:56 +00:00
Henrik Levkowetz c8af089ab1 Fix a bug which made the community tracking code crash when search results would show an old RFC without an associated draft.
- Legacy-Id: 4569
2012-07-03 13:46:23 +00:00
Robert Sparks 1a5a7b998a Show the ballot question on the position entry form.
- Legacy-Id: 4550
2012-06-28 21:56:51 +00:00
Robert Sparks 8b5d95e71b Added the ability to reset the conflict review response text to the template at Sean's request
- Legacy-Id: 4549
2012-06-28 19:51:39 +00:00
Henrik Levkowetz 99a7786990 Remove old non-functional Billo address.
- Legacy-Id: 4547
2012-06-28 19:21:51 +00:00
Henrik Levkowetz 8a57be6b80 There are old drafts which contain '+' in the name. Accept that in the urlpatterns so url reverses work.
- Legacy-Id: 4523
2012-06-27 08:40:25 +00:00
Robert Sparks 51ab8123d9 merged in from 4.20-ise
- Legacy-Id: 4502
2012-06-22 20:25:17 +00:00
Henrik Levkowetz 3683a6af26 Backporting patches from production system.
- Legacy-Id: 4487
2012-06-21 00:35:33 +00:00
Henrik Levkowetz b1b21e5529 Merged in branch/iola/charter-fixes from olau@iola.dk with a series of fixes to the charter management code.
- Legacy-Id: 4483
2012-06-20 23:01:28 +00:00
Henrik Levkowetz 2b78e1573e Merged in personal/rjs/v4.02_via_rfc containing [4356] which replaces code using the old via-rfc tag with code looking at the document stream (and more), and [4364] which adds document page counts on the future telechats page.
- Legacy-Id: 4482
Note: SVN reference [4356] has been migrated to Git commit 4eabc033c1

Note: SVN reference [4364] has been migrated to Git commit b3c665287d
2012-06-20 22:17:48 +00:00
Ole Laursen 822fd6daac Replace get_profile() hack with a test on the user instead, this
also makes the ballot icon more robust against users without profiles
(which shouldn't happen, but apparently we sometimes get one which
results in a crash rather than something more graceful)
 - Legacy-Id: 4480
2012-06-20 12:26:06 +00:00
Ole Laursen 35eb4f013a Give the incoming name to the top renderer so the links are internally
consistent, this is needed because we still have different views for
/doc/rfcXXXX/ and /doc/draft-foo-bar/
 - Legacy-Id: 4479
2012-06-20 11:16:55 +00:00
Ole Laursen 278776f597 Fix regexp fix - [.-_] does not mean "dot or dash or underscore", it
means all characters between dot and underscore
 - Legacy-Id: 4478
2012-06-20 11:13:46 +00:00
Ole Laursen 95c2b07691 Include _ in allowed document name regexp, we currently have 7 drafts
with _ in the database despite it not being valid - they can be found
with:
select name from doc_document where name like '%\_%' and type_id = "draft";
 - Legacy-Id: 4477
2012-06-20 11:00:35 +00:00
Henrik Levkowetz 77977bf32f Remove print statements.
- Legacy-Id: 4464
2012-06-17 14:07:18 +00:00
Henrik Levkowetz a4220324e0 Don't try to call get_profile() if it's not available.
- Legacy-Id: 4445
2012-06-10 18:28:28 +00:00
Henrik Levkowetz afe3ee71b8 Merged in fixes from Ole, from branch/charter:r4382-4407, and some changes from Henrik (removing the use of pos.blocked in views_ballot.py, and setting a ballot id in idrfc/testsREDESIGN.py) to make idrfc.EditPositionTestCase succeed.
- Legacy-Id: 4444
2012-06-10 16:22:16 +00:00
Ole Laursen bb30e1d681 Remove accidentally committed debug print.
- Legacy-Id: 4406
2012-05-07 19:21:54 +00:00
Henrik Levkowetz c7e75522ad Fix bug in picking up blocking text (patch provided by olau@iola.dk).
- Legacy-Id: 4387
2012-05-04 12:57:06 +00:00
Henrik Levkowetz 839df60480 Merged in charter branch fixes from olau@iola.dk, from r4354 through r4381.
- Legacy-Id: 4382
2012-05-04 11:47:30 +00:00
Ole Laursen eaf09d9dc5 Move charter state help to /doc/help/state/charter/.
- Legacy-Id: 4379
2012-05-03 19:23:24 +00:00
Ole Laursen b6a057673a Fix wording of send ballot comment, the actual text was still specific
to drafts.
 - Legacy-Id: 4360
2012-05-03 16:15:20 +00:00
Robert Sparks 4eabc033c1 Replaced the concept of a tag (via-rfc) identifying ise or irtf document (previously the idinternal.via_rfc_editor boolean) with looking at the document's stream.
Removed the stream editing form - that functionality is on the edit info form.
Put the old-ADs back into the list of choices when editing a document's info.

This (re) fixes bug #749
 - Legacy-Id: 4356
2012-05-03 04:26:09 +00:00
Henrik Levkowetz 462aff53ad Merged in fixes to the charter branch (r4345 - r4353) from olau@iola.dk.
- Legacy-Id: 4354
2012-05-02 19:37:46 +00:00
Henrik Levkowetz bcd28cc45f Merged in fixes to the migration from olau@iola.dk. Merged in charter branch from olau@iola.dk. Added various fixes and correction of merge errors.
- Legacy-Id: 4353
2012-05-02 19:35:32 +00:00
Ole Laursen 891ac2585d Use revision numbers to identify ballots and put a warning on closed ballots.
- Legacy-Id: 4352
2012-05-02 17:47:40 +00:00
Ole Laursen 5fcd0297ed Reverse direction of revisions on charter /doc/ page to match tools.ietf.org/html/draft-*.
- Legacy-Id: 4349
2012-05-02 12:16:25 +00:00
Henrik Levkowetz fddaf58f41 Merged [4288] from rjsparks@nostrum.com:
Made several changes to correctly use the new (RFC6410)  "Internet Standard" level
in email that gets sent at various stages in the handling of documents.

Fixes bug 821.
 - Legacy-Id: 4332
Note: SVN reference [4288] has been migrated to Git commit 0e2dd258c7
2012-04-26 20:00:48 +00:00
Ole Laursen 6ef8b8227c Fix bug in diff'ing charter revisions.
- Legacy-Id: 4293
2012-04-20 12:51:24 +00:00
Ole Laursen b9a90f35e1 Clean up and polish charter branch code, fix some subtle bugs with
revision and approved charter lookup.
 - Legacy-Id: 4290
2012-04-19 15:15:43 +00:00
Robert Sparks 0e2dd258c7 Made several changes to correctly use the new (RFC6410) "Internet Standard" level
in email that gets sent at various stages in the handling of documents.

Fixes bug 821
 - Legacy-Id: 4288
2012-04-17 21:00:26 +00:00
Ole Laursen 7932a75363 Fix ballot_icon templatetag bugs so it can handle other document types
too.
 - Legacy-Id: 4284
2012-04-17 16:22:30 +00:00
Ole Laursen 9fe98c88e5 Don't show ballot writeup unless we've got a ballot
- Legacy-Id: 4283
2012-04-17 16:01:45 +00:00
Ole Laursen f3013a18ca Back out automatic closing of ballot if state is changed to dead for
the time being; based on experience with the migration script it looks
like drafts are sometimes killed to later resurface with reused ballot
positions
 - Legacy-Id: 4282
2012-04-17 15:54:51 +00:00
Ole Laursen 24dd2ed521 Close draft ballot if the draft is moved into state "Dead"
- Legacy-Id: 4278
2012-04-16 13:59:48 +00:00
Ole Laursen 0fc1561260 Close draft ballot on Secretariat approval/disapproval action
- Legacy-Id: 4277
2012-04-16 13:59:16 +00:00
Ole Laursen 1ff4bc0121 Port idrfc code to use new ballot setup with an explicit ballot on
positions, port and clean up ballot icon renderer, add preliminary migration
script for inserting extra events in drafts
 - Legacy-Id: 4274
2012-04-16 13:19:47 +00:00
Ole Laursen 47b466eaae Move charter urls from /wgcharter/<group-acronym> to
/doc/<doc-name>/charter/ since they now all concern the actual charter
documents rather than the WG (this removes some redundant code).
 - Legacy-Id: 4271
2012-04-10 18:11:03 +00:00