Commit graph

160 commits

Author SHA1 Message Date
Henrik Levkowetz 563f584a9e Made ietf/nomcom pyflakes-clean. Removed some dead code.
- Legacy-Id: 7476
2014-03-15 19:26:01 +00:00
Henrik Levkowetz 5bef5d11ae Made doc/ pyflakes-clean.
- Legacy-Id: 7462
2014-03-15 16:09:47 +00:00
Ole Laursen ab382a726f While cleaning up the Javascript includes in the nomcom app, it turns
out nomcom.js is included in the wrong pages, and on the pages it is
actually useful in, it's obsolete, so delete it together with the
obsoleted AJAX view and the other JS left-over cruft in nomcom/, this
fixes an include 404 and removes the remaining dependency on
jquery-1.5.1 apart from the Secretariat tools
 - Legacy-Id: 7097
2014-01-10 14:06:36 +00:00
Ole Laursen f685e45ca5 Add select_related to PositionNomineeField in nomcom app to save a
bunch of database queries
 - Legacy-Id: 7095
2014-01-10 13:13:03 +00:00
Ole Laursen fdb6baf4e6 Use collections.OrderedDict instead of the SortedDict bundled with Django
- Legacy-Id: 7026
2013-12-20 11:00:07 +00:00
Ole Laursen 1dc860236f Delete ADMIN_MEDIA_PREFIX which is now gone in Django, add a pattern to the static serving so a debug/test server serves the admin static files
- Legacy-Id: 6975
2013-12-18 11:45:36 +00:00
Ole Laursen d66ac15fc2 Rewrite a bunch of HttpResponseRedirect + url reverse calls to instead
take advantage of the redirect shortcut (introduced in Django 1.1)
 - Legacy-Id: 6960
2013-12-17 10:23:42 +00:00
Ole Laursen 84a9f49053 mimetype -> content_type (mimetype is deprecated)
- Legacy-Id: 6945
2013-12-16 16:53:47 +00:00
Ole Laursen 3febf7d216 Fix odd boolean calculation in nomcom view
- Legacy-Id: 6923
2013-12-13 16:48:37 +00:00
Ole Laursen 892c7d43ce Reuse already fetched page instead of refetching it in nomcom test
- Legacy-Id: 6922
2013-12-13 16:47:57 +00:00
Ole Laursen b302ffa814 Fix bug in nomcom test, it was sending a formset without the
corresponding management form values
 - Legacy-Id: 6921
2013-12-13 16:45:04 +00:00
Ole Laursen aea222edbc Speed up nomcom tests a bit more by also only generating one certificate for the client per run
- Legacy-Id: 6920
2013-12-13 16:28:55 +00:00
Ole Laursen 466928edc2 Only generate the test NomCom certificate once instead to speed up the
Nomcom tests a bit
 - Legacy-Id: 6919
2013-12-13 16:10:49 +00:00
Ole Laursen 652a5ca17a Rewrite NomCom test data generation slightly based on the rewritten
base test data, fix problem with form previews
 - Legacy-Id: 6918
2013-12-13 15:59:52 +00:00
Ole Laursen 81e5ced4ee Remove "nominee" from FeedbackForm.Meta.fields, it doesn't exist in Feedback
- Legacy-Id: 6916
2013-12-13 15:48:13 +00:00
Ole Laursen a2c13b70d1 Make sure all BooleanFields have an explicit default value (with
Django < 1.6 it used to be False implicitly)
 - Legacy-Id: 6908
2013-12-13 13:30:07 +00:00
Ole Laursen e32d346bc5 Fix security_hash problem in nomcom tests, it's no longer a separate function
- Legacy-Id: 6905
2013-12-13 13:10:52 +00:00
Ole Laursen 771591f0db Remove use of obsolete generic delete view
- Legacy-Id: 6891
2013-12-12 12:06:09 +00:00
Ole Laursen 6a98fec2c3 Use built-in json module in Python instead of simplejson bundled with Django
- Legacy-Id: 6883
2013-12-11 16:59:19 +00:00
Ole Laursen 2c930d0f97 Get rid of remaining use of email_re, use validate_email instead
- Legacy-Id: 6882
2013-12-11 16:47:47 +00:00
Ole Laursen 883853f09c Fix bug, TemplateView takes template_name, not template as parameter
- Legacy-Id: 6880
2013-12-11 16:43:34 +00:00
Ole Laursen cfa0d47ca0 Port to new class-based generic redirect and simple template views, remove utils.lazy.reverse_lazy, it's now included in Django
- Legacy-Id: 6878
2013-12-11 16:36:09 +00:00
Ole Laursen e63ac36b8f Remove shim layer from ietfauth, delete some dead code and migrate
remaining importers of ietfauth.decorators to ietfauth.utils
 - Legacy-Id: 6797
2013-12-05 16:24:03 +00:00
Ole Laursen d0f2859631 Move NomCom announcements view to nomcom/, move message view to
message/, add tests, add redirects, fix a couple of small bugs in the
announcements view
 - Legacy-Id: 6769
2013-11-28 17:55:10 +00:00
Ole Laursen 9457669310 Merge in changes from the old shimfree branch
- Legacy-Id: 6764
2013-11-27 12:55:50 +00:00
Henrik Levkowetz afb09a0c71 Added code to the EditMembersFormPreview form class' post_post() method. This code was present in preview_post() but missing in post_post(). Fixes issue #1203.
- Legacy-Id: 6723
2013-11-20 14:06:07 +00:00
Henrik Levkowetz 9c20739493 Fix typo and style detail.
- Legacy-Id: 6698
2013-11-08 18:53:22 +00:00
Henrik Levkowetz c7c4afc6dd It turns out that the get_user_email is called for every nominee listed on a feedback page, which is insane. But until the template can be rewritten to do this in a more sane way, we cache the lookup result.
- Legacy-Id: 6651
2013-11-04 20:47:54 +00:00
Henrik Levkowetz 801283f814 By preference, show the same email for a logged-in user as his login, if it
exists; otherwise show the newest active email address.
 - Legacy-Id: 6644
2013-11-03 19:11:45 +00:00
Henrik Levkowetz 5f2da7ba9e Merged [6486] from rjsparks@nostrum.com:
Slightly more than minimal changes to have questionnaire reminders go only to those nominees who have accepted but have not yet sent in a questionnaire for a given position
 - Legacy-Id: 6573
Note: SVN reference [6486] has been migrated to Git commit 2a1b4c7775
2013-10-30 21:17:46 +00:00
Henrik Levkowetz 6928ff2927 Correct sequence typo.
- Legacy-Id: 6491
2013-10-26 15:32:04 +00:00
Henrik Levkowetz 56953d8027 Tweaked the email line lengths in the data migration.
- Legacy-Id: 6476
2013-10-21 22:09:59 +00:00
Henrik Levkowetz d649fd5e10 Merged [6465] and [6466] from rjsparks@nostrum.com:
Added the ability to send reminders to complete questionnaires to nominees in
the accepted state.  Changed the send_reminders management command to not take
any arguments and run against all active nomcoms.  Removed bugs from the
send_reminders management command and added tests for it.  Adjusted several
dbtemplate titles and content.

Fixes bug 1157
 - Legacy-Id: 6471
Note: SVN reference [6465] has been migrated to Git commit 22f356434a

Note: SVN reference [6466] has been migrated to Git commit a461e6c4a4
2013-10-21 20:12:00 +00:00
Henrik Levkowetz 47071ecade Merged [6468] and [6469] from ejimenez@yaco.es:
Now incumbent can be None in positions.
Fixes #1156.
 - Legacy-Id: 6470
Note: SVN reference [6468] has been migrated to Git commit d4e37ac7a0d7fddc0317b0d95670a8de8cd32c2d

Note: SVN reference [6469] has been migrated to Git commit 0a315723ad6dd610d0c17e78edce2027b6868d4e
2013-10-21 17:07:09 +00:00
Henrik Levkowetz 5b003d3842 Missing import in nomcom file.
- Legacy-Id: 6393
2013-10-09 08:37:09 +00:00
Henrik Levkowetz 6c13e8027b Fixed the language in some UI strings in the nomcom tool.
- Legacy-Id: 6358
2013-10-03 20:56:59 +00:00
Henrik Levkowetz 342bc5bf96 Merged in the merge work branch personal/henrik/r6270 which provides the agenda scheduling tool step 3, from a merge of branch/ssw/agenda/v4.70 from mcr@sandelman.ca; and also substantial fixes to the test framework, and more.
- Legacy-Id: 6328
2013-10-01 13:53:05 +00:00
Henrik Levkowetz d2df8cac78 Fixed the manyfold duplicated position names in the position selection drop-down list in the nomcom private index page. Fixes issue #1137.
- Legacy-Id: 6327
2013-10-01 13:42:30 +00:00
Henrik Levkowetz e4f4467725 Changed tests to use our own subclassed TestCase, and changed almost all fixtures to be perma_fixtures.
- Legacy-Id: 6320
2013-09-30 20:36:20 +00:00
Ole Laursen c191a691e0 Remove "names" fixture from all tests, since it's now loaded once just
after creating the test database through the global test fixture
mechanism - this speeds up multiple tests considerably
 - Legacy-Id: 6305
2013-09-29 17:35:59 +00:00
Henrik Levkowetz 254d6f70dd Removed some debug statements.
- Legacy-Id: 6290
2013-09-27 17:32:35 +00:00
Henrik Levkowetz 8d9c1e9177 Changed 'requirement' to 'desired expertise' in user-visible places in the nomcom app.
- Legacy-Id: 6259
2013-09-24 17:50:02 +00:00
Henrik Levkowetz 5d9e6c0b6a Fixed the language of the nomination confirmation message.
- Legacy-Id: 6250
2013-09-23 19:27:17 +00:00
Henrik Levkowetz 86cf15cd9f Fixed some bugs in the EncryptedTextField class.
- Legacy-Id: 6246
2013-09-22 19:26:48 +00:00
Henrik Levkowetz 0016c69b61 Added an index page for nomcoms, at /nomcom/, with links to nomcom pages and announcements, where they exist.
- Legacy-Id: 6245
2013-09-22 18:59:24 +00:00
Ole Laursen 5924024513 Swap the arguments to group.has_role so they match the arguments to
the existing has_role
 - Legacy-Id: 6218
2013-09-20 13:46:47 +00:00
Ole Laursen 0eed4ad9e5 Add has_role(role_name, user) utility to group, used like
group.has_role("chair", request.user). Remove the NomCom specific
group utilities, apparently they're not actually used.
 - Legacy-Id: 6217
2013-09-20 11:23:17 +00:00
Henrik Levkowetz da4177e1cd Rename the nomcom public keys path setting.
- Legacy-Id: 6166
2013-09-18 18:10:27 +00:00
Henrik Levkowetz 641bcccfba Replaced the ad_hoc nomcom_member_required() decorator with our generic role_required() decorator. Changed access permission for nomcom-chair only pages to also permit nomcom advisor access (this lets the previous nomcom chair explain and assist as needed). Also tweaked some text strings in the email feedback pipe script.
- Legacy-Id: 6160
2013-09-16 21:05:25 +00:00
Henrik Levkowetz 2a2389d17f Merged in branch/iola/shimfree@6083. This cleans up and moves relevant code from idrfc/ to doc/. There should now only be a bit of old wrapper code left in idrfc; that will go away when the remaining models which use it are cleaned up.
- Legacy-Id: 6117
2013-09-09 17:45:36 +00:00