Commit graph

288 commits

Author SHA1 Message Date
Henrik Levkowetz 8c42989d5d Pyflakes cleanup compliant with pyflakes 0.8.1, which seems to find things 0.8.0 didn't fin.
- Legacy-Id: 7558
2014-04-01 16:25:18 +00:00
Henrik Levkowetz 5a424fe2da Merged in [7153] from rjsparks@nostrum.com:
Fixed a typo in code that looks for the IRTF chair email address while adding replaces relationships.
Made that code slightly more robust.
Fixes ticket #1253
 - Legacy-Id: 7531
Note: SVN reference [7153] has been migrated to Git commit 99c01fa54a
2014-03-21 11:55:51 +00:00
Henrik Levkowetz c19268f6a1 A second pass of pyflakes cleanup, removing additional bulk imports, fixing a bug in get_initial_notify(), and removing some dead (and buggy) code.
- Legacy-Id: 7509
2014-03-16 22:15:46 +00:00
Henrik Levkowetz 02031a01b9 Cleaned out some (arbitrary) submodule name imports into ietf.utils, and made the corresponding import statements import the names directly from the correct submodules.
- Legacy-Id: 7495
2014-03-16 07:09:38 +00:00
Henrik Levkowetz 8a6c121073 Made ietf/secr/groups pyflakes-clean.
- Legacy-Id: 7480
2014-03-15 21:13:21 +00:00
Henrik Levkowetz 108fe6b03f Fixed some pyflakes issues in the merged code.
- Legacy-Id: 7464
2014-03-15 16:32:11 +00:00
Henrik Levkowetz b9c38d3c06 Merged pyflakes fixes forward to new copy of trunk.
- Legacy-Id: 7463
2014-03-15 16:27:05 +00:00
Henrik Levkowetz 5bef5d11ae Made doc/ pyflakes-clean.
- Legacy-Id: 7462
2014-03-15 16:09:47 +00:00
Henrik Levkowetz b945275478 Merged [7386] from tterriberry@mozilla.com: Describe needed positions in document ballot mail.
This uses doc.utils.needed_ballot_positions() to calculate what is
 needed.
Fixes #924.
 - Legacy-Id: 7405
Note: SVN reference [7386] has been migrated to Git commit d42ccbe741
2014-03-04 20:52:15 +00:00
Henrik Levkowetz 8ff8056581 Merged [7383] from jmh@joelhalpern.com: fixes ticket #924
Changes counting logic in ballots to use actual number of ADs.
Causes ballot email to use utility to generate requirements text
 - Legacy-Id: 7404
Note: SVN reference [7383] has been migrated to Git commit 271c48c9c47bf63bee2289fad9224b624c388fba
2014-03-04 18:22:29 +00:00
Henrik Levkowetz ebc6608387 Merged in part of [7375] from jmh@joelhalpern.com.
Now sending draft update notices to IRSG for IRTF stream drafts.  Fixes issue #1227.
 - Legacy-Id: 7402
Note: SVN reference [7375] has been migrated to Git commit 5f89d9ab996c4b0519ec23accb288e02961c62bf
2014-03-04 18:12:38 +00:00
Henrik Levkowetz b297c67765 Merged [7396] from rcross@amsl.com: updated test for clean_up_draft_files.
- Legacy-Id: 7401
Note: SVN reference [7396] has been migrated to Git commit 852509c96d983e595fa082e13b771a7f89771803
2014-03-04 17:47:26 +00:00
Timothy B. Terriberry d42ccbe741 Describe needed positions in document ballot mail.
This uses doc.utils.needed_ballot_positions() to calculate what is
 needed.
Fixes #924.
Commit ready to merge.
 - Legacy-Id: 7386
2014-03-01 19:08:09 +00:00
Henrik Levkowetz dbc82f2b22 Merged [7365] from rjsparks@nostrum.com: Improve handling of status-change relation form submission when conditions (such as not running javascript) lead to the POST missing required fields.
- Legacy-Id: 7381
Note: SVN reference [7365] has been migrated to Git commit 9a7b186616823029fbe6bac5907bad50c5203e97
2014-03-01 18:08:43 +00:00
Robert Sparks ff48d32c08 Migration to repair missing StateDocEvents from wg chairs using
the datatracker to request publication of ietf stream documents.

Incremental improvement to the request publication view to create
those StateDocEvents going forward.

This is related to bug #1312
Commit ready to merge
 - Legacy-Id: 7371
2014-02-28 17:14:18 +00:00
Robert Sparks 31808eccb2 Allow 1-3 digit RFCs in status change documents.
Fixes bug #1321
Commit ready for merge
 - Legacy-Id: 7292
2014-02-24 15:43:32 +00:00
Henrik Levkowetz c52d7c00fe Removed a debug statement.
- Legacy-Id: 7243
2014-02-16 16:29:29 +00:00
Henrik Levkowetz 057dd43c73 Fixed a probem with wrong URLs in atom feeds, caused by caching. Fixes issue #1307.
- Legacy-Id: 7239
2014-02-16 15:45:06 +00:00
Henrik Levkowetz 295b484bea Merged [7210] from rjsparks@nostrum.com: Allow the IRTF Chair and the ISE to request a conflict review directly through the tracker.
Notify the Secretariat when someone other than the secretariat initiates a conflict review.
Notify IANA when anyone initiates a conflict review.
Fixes tickets #1287 and #1289
 - Legacy-Id: 7225
Note: SVN reference [7210] has been migrated to Git commit a0fd974c92
2014-02-09 21:01:29 +00:00
Henrik Levkowetz c83ef0c30b Merged [7077] from rjsparks@nostrum.com: Returns "there are no ballots to view yet" rather than 404ing when the ballot link is followed for a document that exists.
It is typical for last call to be issued (which includes a link to the ballot page) well in advance of creating any ballot for a document.
Fixes bug 1233
 - Legacy-Id: 7223
Note: SVN reference [7077] has been migrated to Git commit e93b5ec296
2014-02-09 20:36:36 +00:00
Henrik Levkowetz 3abaab1d98 Merged [7076] from rjsparks@nostrum.com:
Sets the State(type=draft) to Replaced when a document is replaced using views_draft.replaces.
Sets the state back to Active or Expired when a document is no longer replaced by another document.
Adds tests for the above functionality.
Provides a patch to repair the state of documents pointed to by RelatedDocument(relationship__slug='replaces') objects created by views_draft.replaces before this fix.
Fixes bug 1234
 - Legacy-Id: 7222
Note: SVN reference [7076] has been migrated to Git commit a3da5bbd87
2014-02-09 20:33:15 +00:00
Henrik Levkowetz 086c4290b7 Merged [6361] from rjsparks@nostrum.com:
Allow the secretariat and ads to change the title of a status change
document.  Fixes bug 1141.

Applied changes to adapt the code from Django 1.2 to 1.6: Provide a
quoted string to {% url %} and use request.user.person instead of
request.user.get_profile().
 - Legacy-Id: 7221
Note: SVN reference [6361] has been migrated to Git commit 7c4cf7002f
2014-02-09 18:46:19 +00:00
Henrik Levkowetz 690c36cd8a Merged [6359] from rjsparks@nostrum.com:
Send email to the secretariat when a status change document is put directly into the last-call-requested state.
Fixes bug 1139.
 - Legacy-Id: 7208
Note: SVN reference [6359] has been migrated to Git commit faabcb8328
2014-02-04 23:28:48 +00:00
Henrik Levkowetz 62e7b515a8 Added stream change and state change emails in adopt_draft() -- otherwise we wouldn't have the state change emails assumed in the previous commit. See issue #1246.
- Legacy-Id: 7207
2014-02-04 23:27:40 +00:00
Henrik Levkowetz 41c1c1a5fe Removing the extra (misleading) draft about WG adoption which is sent out in addition to the state change emails when a call for addoption (WG) or adoption (RG) is done using the 'Adopt Draft in Group' form. The state change messages should be sufficient, and are not misleading. Fixes issue #1246 (and 1290).
- Legacy-Id: 7206
2014-02-04 22:00:07 +00:00
Henrik Levkowetz 908aacceff Handle the case in is_downref() where the src file doesn't have a std_level or intended_std_level set.
- Legacy-Id: 7198
2014-01-31 19:08:49 +00:00
Henrik Levkowetz 2d420fac34 Merged additional django-port and shim-removal tweaks from olau@iola.dk: branch/iola/djangoport@7167.
- Legacy-Id: 7168
2014-01-26 16:30:52 +00:00
Robert Sparks 99c01fa54a Fixed a typo in code that looks for the IRTF chair email address while adding replaces relationships.
Made that code slightly more robust.
Fixes ticket #1253
Commit ready for merge
 - Legacy-Id: 7153
2014-01-21 20:53:07 +00:00
Henrik Levkowetz 6e97c2c8da Merged in the port from Django 1.2 to Django 1.6 from olau@iola.dk: branch/iola/djangoport@7121, and fixed some merge issues.
- Legacy-Id: 7152
2014-01-18 21:02:40 +00:00
Ole Laursen 1ab82bdbed Replace the somewhat fragile query for specific state descriptions
with a query for the appropriate event types, this should work now
that new events set the correct type and old events have been migrated
 - Legacy-Id: 7140
2014-01-15 23:32:17 +00:00
Ole Laursen 697f76bf84 Add migration to convert old state change events to StateDocEvents
with type changed_state from changed_document, this allows us to
easily query for them
 - Legacy-Id: 7139
2014-01-15 23:30:12 +00:00
Ole Laursen 886b6df981 Add match for "IESG state changed"
- Legacy-Id: 7130
2014-01-15 18:19:02 +00:00
Ole Laursen 87ca10d122 Remove usage of log_state_changed (and duplicate in
doc/utils_charter.py) in favour of add_state_change_event which has
slightly better API but otherwise does basically the same except it
sets an event type we can later search for. Also expand tests slightly
to exercise three more templates.
 - Legacy-Id: 7129
2014-01-15 17:52:00 +00:00
Ole Laursen 6b2d50db93 Implement missing charter tests as found by the coverage check
- Legacy-Id: 7127
2014-01-14 15:50:03 +00:00
Ole Laursen 7e00fa1424 Move the Secretariat group email utility to wginfo and the rest of the wgcharter stuff to doc/(views|urls|utils)_charter.py alongside the other document types
- Legacy-Id: 7121
2014-01-13 16:08:58 +00:00
Ole Laursen b4dfae121b Integrate old patch for warning on the request for publication page if
intended std level and consensus is not filled in for the draft before
sending it (as per discussion with Alice Russo) - the consensus check
is skipped for ISE drafts
 - Legacy-Id: 7103
2014-01-10 17:16:12 +00:00
Ole Laursen f591735b7d Fix subtle search bug found by stream pages tests, the query was
checking a StreamName against the slug, which happened to work with
MySQL because the stream name is the same as the slug, just uppercase
- but MySQL is case insensitive
 - Legacy-Id: 7091
2014-01-09 17:52:42 +00:00
Ole Laursen 84136cb5ae Add missing doc page tests, found by the coverage check
- Legacy-Id: 7087
2014-01-09 17:03:59 +00:00
Robert Sparks e93b5ec296 Returns "there are no ballots to view yet" rather than 404ing when the ballot link is followed for a document that exists.
It is typical for last call to be issued (which includes a link to the ballot page) well in advance of creating any ballot for a document.
Fixes bug 1233
Commit ready for merge
 - Legacy-Id: 7077
2014-01-07 23:16:44 +00:00
Robert Sparks a3da5bbd87 Sets the State(type=draft) to Replaced when a document is replaced using views_draft.replaces.
Sets the state back to Active or Expired when a document is no longer replaced by another document.
Adds tests for the above functionality.
Provides a patch to repair the state of documents pointed to by RelatedDocument(relationship__slug='replaces') objects created by views_draft.replaces before this fix.

Fixes bug 1234
Commit ready for merge
 - Legacy-Id: 7076
2014-01-07 22:58:52 +00:00
Ole Laursen a5f5eb84d3 With the new test discovery mechanism in Django 1.6 (inherited from
unittest2 in Python 2.7), manually importing tests from files starting
with test* will run them twice, so don't do that
 - Legacy-Id: 7030
2013-12-20 13:08:38 +00:00
Ole Laursen defb116721 Use prefetch_related to reduce the number of queries on the search page and in idindex generation, adjust a couple of members on Document slightly to not filter on relations (filtering doesn't work with prefetch_related)
- Legacy-Id: 6992
2013-12-18 16:58:34 +00:00
Ole Laursen cb4d5b7c2b Simplify make_test_data a bit by using the create_person helper for the chair and WG delegate, regularize the naming of those
- Legacy-Id: 6990
2013-12-18 16:27:02 +00:00
Ole Laursen 8afd3fa5b7 Rewrite wg_menu tag to use simple_tag instead of a full template Node,
also fix a bug in the cache apparently not being filled in correctly
 - Legacy-Id: 6971
2013-12-18 10:25:59 +00:00
Ole Laursen e2e6c243a1 Remove the complicated tag processing from ballot_icon, instead just
decorate the function with @simple_tag(takes_context=True)
 - Legacy-Id: 6970
2013-12-18 10:22:30 +00:00
Ole Laursen 7f277a8fbb Replace user.get_profile() with user.person, the profile stuff is deprecated since Django 1.5
- Legacy-Id: 6968
2013-12-18 10:13:40 +00:00
Ole Laursen ea24f5c3bd Import slugify from django.utils.text (introduced in Django 1.5)
- Legacy-Id: 6967
2013-12-18 10:00:58 +00:00
Henrik Levkowetz ecb5cd6526 Merged in branch/iola/shimfree@6856. This pretty much completes the shim removal. Next step is upgrading Django to 1.6, and then doing some final polishing.
- Legacy-Id: 6966
2013-12-17 21:29:05 +00:00
Ole Laursen d1782297ab assertEquals -> assertEqual in tests, the former is deprecated
- Legacy-Id: 6964
2013-12-17 12:52:24 +00:00
Ole Laursen d66ac15fc2 Rewrite a bunch of HttpResponseRedirect + url reverse calls to instead
take advantage of the redirect shortcut (introduced in Django 1.1)
 - Legacy-Id: 6960
2013-12-17 10:23:42 +00:00