Commit graph

7009 commits

Author SHA1 Message Date
Henrik Levkowetz 55ff15952d Merged in [13018] from rcross@amsl.com:
Fix issue with interim meeting timezone getting reset on edit.  Fixes #2204.
 - Legacy-Id: 13020
Note: SVN reference [13018] has been migrated to Git commit adee827726
2017-03-17 17:02:14 +00:00
Henrik Levkowetz 1abb631c61 Merged in [13017] from rcross@amsl.com:
Add placeholders and validations to secretariat non-session time input fields.  Fixes #2208.
 - Legacy-Id: 13019
Note: SVN reference [13017] has been migrated to Git commit 4f5933ae20
2017-03-17 16:32:42 +00:00
Ryan Cross adee827726 Fix issue with interim meeting timezone getting reset on edit. Fixes #2204. Commit ready for merge.
- Legacy-Id: 13018
2017-03-17 00:25:21 +00:00
Ryan Cross 4f5933ae20 Add placeholders and validations to secretariat non-session time input fields. Fixes #2208. Commit ready for merge.
- Legacy-Id: 13017
2017-03-16 23:10:14 +00:00
Henrik Levkowetz d6d6fd65db Applied a patch rjsparks@nostrum.com to make ballot grids show for statchg documents in ietf last call.
- Legacy-Id: 13015
2017-03-15 14:57:20 +00:00
Henrik Levkowetz bb5096da8a Added more email validation for draft submission author emails, and blocked some baths that could lead to bad email addresses ('none') being set as document author email addresses.
- Legacy-Id: 13010
2017-03-14 14:07:21 +00:00
Henrik Levkowetz 888aa75a2f Set version info and settings back to development mode
- Legacy-Id: 13008
2017-03-13 17:09:54 +00:00
Henrik Levkowetz 986a2ea881 Set version info to release version 6.47.1 before branching.
- Legacy-Id: 13006
2017-03-13 17:09:46 +00:00
Henrik Levkowetz 7b3ce6e795 Improved the log.assertion() and unreachable() functions to send a deeper traceback when reporting by email, rather than just the last stack frame.
- Legacy-Id: 12999
2017-03-13 05:37:02 +00:00
Henrik Levkowetz 0af1223b3c Merged in [12990] and [12991] from rcross@amsl.com:
Refactor session audio file import.  Add informative email.  Fixes #2164.
 - Legacy-Id: 12998
Note: SVN reference [12990] has been migrated to Git commit 084f8a7495

Note: SVN reference [12991] has been migrated to Git commit 6a5f180fb0
2017-03-12 12:15:37 +00:00
Henrik Levkowetz fe8cd06a76 Back out the htmlization code for the moment.
- Legacy-Id: 12997
2017-03-12 12:12:44 +00:00
Henrik Levkowetz e724ed9cdd Make the default navbar colour match the production navbar, rather than the dev navbar. Gives 500 errors in production a regular navbar, rather than a dev navbar.
- Legacy-Id: 12996
2017-03-12 12:11:06 +00:00
Henrik Levkowetz 319a4850d6 Added rfcmarkup code. Will probably be migrated to a separate lib in time.
- Legacy-Id: 12994
2017-03-11 14:02:16 +00:00
Henrik Levkowetz 58dae78a43 Modified the REST API to provide group descriptions taken from the group charters if group.description is blank.
- Legacy-Id: 12993
2017-03-11 13:46:19 +00:00
Henrik Levkowetz 2ba55b1b5b Added text() and htmlized() methods on Document, to help with display of htmlized text.
- Legacy-Id: 12992
2017-03-11 13:44:03 +00:00
Ryan Cross 6a5f180fb0 Rename and update shared audio file migration. Commit ready for merge
- Legacy-Id: 12991
2017-03-10 23:12:49 +00:00
Ryan Cross 084f8a7495 Refactor session audio file import. Add informative email. Fixes #2164. Commit ready for merge
- Legacy-Id: 12990
2017-03-10 23:04:06 +00:00
Henrik Levkowetz 8eb447e77f Added an improved guard against trying to fetch milestones for a group value of None.
- Legacy-Id: 12989
2017-03-08 15:19:08 +00:00
Henrik Levkowetz 707b006d17 Added a guard against trying to fetch milestones for a group value of None.
- Legacy-Id: 12988
2017-03-08 15:14:58 +00:00
Henrik Levkowetz e48b5c99c3 Added a link to report bugs by email to the page footer.
- Legacy-Id: 12987
2017-03-08 15:04:37 +00:00
Henrik Levkowetz 27ca7b52ce Fixed a reverse url lookup issue in a template.
- Legacy-Id: 12986
2017-03-08 11:13:38 +00:00
Henrik Levkowetz 1b3b8da0d0 Set version info and settings back to development mode
- Legacy-Id: 12984
2017-03-07 10:38:21 +00:00
Henrik Levkowetz 9580b797c3 Set version info to release version 6.47.0 before branching.
- Legacy-Id: 12982
2017-03-07 10:38:13 +00:00
Henrik Levkowetz de2356d693 Added a migration for the tweaked DocEvent.rev field.
- Legacy-Id: 12979
2017-03-07 09:48:22 +00:00
Henrik Levkowetz 4daf66d11c Added DocEvent rev= parameter througout the code.
- Legacy-Id: 12978
2017-03-06 15:08:21 +00:00
Henrik Levkowetz ff31644ccf Tweaked assertion() and unreachable() to raise an exception instead of sending email (to the test mailbox ...) when running the test suite.
- Legacy-Id: 12977
2017-03-06 14:31:45 +00:00
Henrik Levkowetz 0bcb4ae30c Fixed a problem with assertion() and unreachable(), which could break if certain names (like 'args') were set in the calling frame.
- Legacy-Id: 12975
2017-03-06 13:51:08 +00:00
Henrik Levkowetz 05d57f6577 Added a 'rev' field to DocEvent, and removed the corresponding field from NewRevisionDocEvent and SubmissionDocEvent. Added a migration for an initial schema change, one data migration to copy and infer revision information, another schema migration to remove extraneous revision field, and another data migration to fix up bad timestamps and bad revision info from the period 2016-09-10 to 2016-10-04.
- Legacy-Id: 12974
2017-03-05 19:59:27 +00:00
Henrik Levkowetz fd9a0d12b5 Renamed a couple of migrations.
- Legacy-Id: 12973
2017-03-05 12:03:15 +00:00
Henrik Levkowetz dd305e0d87 Fixed a bug in the StateAdmin list_filter setting.
- Legacy-Id: 12972
2017-03-04 16:19:29 +00:00
Henrik Levkowetz 0bebccd1cb Added a data migration which adds 2 new WG states: 'Waiting for Implementation' and 'Held by WG'.
- Legacy-Id: 12969
2017-03-04 13:46:17 +00:00
Henrik Levkowetz 9bbd50119f Added a filter bar for state-type to the admin page for doc.models.State.
- Legacy-Id: 12968
2017-03-04 13:45:08 +00:00
Henrik Levkowetz 387068f67d Updated unreachable markings.
- Legacy-Id: 12967
2017-03-04 05:38:23 +00:00
Henrik Levkowetz f2c1ca1565 Added unreachable markings.
- Legacy-Id: 12966
2017-03-04 05:31:18 +00:00
Henrik Levkowetz 3c6f00869f Dead code removal: meeting models and test_utils.
- Legacy-Id: 12965
2017-03-04 05:19:39 +00:00
Henrik Levkowetz 73a2d86f12 Added an unreachable mark
- Legacy-Id: 12964
2017-03-04 05:19:01 +00:00
Henrik Levkowetz 0745fac189 Undo commit
- Legacy-Id: 12963
2017-03-04 05:17:41 +00:00
Henrik Levkowetz 49ba774ae3 Updated unreachable() marking.
- Legacy-Id: 12962
2017-03-04 05:14:51 +00:00
Henrik Levkowetz 60ddd61727 Tweaked Message.msgid and added needed migrations for the field. The first migration creates the new column with NULL values for existing rows, the second adds creation of msgid values by default for new rows.
- Legacy-Id: 12961
2017-03-03 21:17:12 +00:00
Henrik Levkowetz 119f48699c Added a data migration to add author information to existing reviews.
- Legacy-Id: 12960
2017-03-03 21:14:45 +00:00
Henrik Levkowetz ce9f879500 Create all appropriate aliases when a Person record is created, both in ietfauth and in PersonFactory.
- Legacy-Id: 12958
2017-03-03 19:42:16 +00:00
Henrik Levkowetz c006c44423 Added setting of document author for review document objects.
- Legacy-Id: 12957
2017-03-03 19:40:09 +00:00
Henrik Levkowetz 920d05bbd5 Improved handling of a case where a meeting floor have been defined, but no floor image uploaded yet.
- Legacy-Id: 12956
2017-03-03 18:00:16 +00:00
Henrik Levkowetz 541085b1a8 Changed email notifications for reviews done to save the message as a Message instance before sending it. Added test code to check that a Message instance is created and matches what goes out.
- Legacy-Id: 12955
2017-03-03 15:45:29 +00:00
Henrik Levkowetz 3a21e03f8d Marked a function as unrachable. Added support in send_mail_message for the Message.msgid field.
- Legacy-Id: 12954
2017-03-03 15:43:43 +00:00
Henrik Levkowetz 4159586994 Added a msgid field to the Message model.
- Legacy-Id: 12953
2017-03-03 15:41:19 +00:00
Henrik Levkowetz 3117d0fdd8 Merged in [12917] from rcross@amsl.com:
Fixes #2207. bin/merge-person-records remove _meta.get_all_related_objects() deprecated in Django 1.10.
 - Legacy-Id: 12952
Note: SVN reference [12917] has been migrated to Git commit aa76ea4040
2017-03-02 21:43:52 +00:00
Henrik Levkowetz ea70381f29 Merged in [12950] from rcross@amsl.com:
Fixes #2219.  Area Group chairs are denied material management access.
 - Legacy-Id: 12951
Note: SVN reference [12950] has been migrated to Git commit c6d1a59aa4
2017-03-02 21:21:07 +00:00
Ryan Cross c6d1a59aa4 Fixes #2219. Area Group chairs are denied material management access. Commit ready for merge.
- Legacy-Id: 12950
2017-03-02 20:14:39 +00:00
Henrik Levkowetz 225c1d9afe Changed the state choices in the document adoption form to exclude the few that should not be available, rather than explicitly list all others. Makes adding WG/RG states simpler.
- Legacy-Id: 12949
2017-03-02 20:07:50 +00:00
Henrik Levkowetz 348591a4bb Set version info and settings back to development mode
- Legacy-Id: 12944
2017-03-01 12:27:39 +00:00
Henrik Levkowetz bc8e66d741 Set version info to release version 6.46.1 before branching.
- Legacy-Id: 12942
2017-03-01 12:27:29 +00:00
Henrik Levkowetz cbc0e72fee Added a migration which captures the ordering on Role.
- Legacy-Id: 12938
2017-03-01 11:33:42 +00:00
Henrik Levkowetz ae8e07ef22 Merged in [12932] from rjsparks@nostrum.com:
Move primary but inactive email to the most recently touched active email for a Person. If a person has more than one primary email, make all but the first be not primary. Fixes #2214.
 - Legacy-Id: 12937
Note: SVN reference [12932] has been migrated to Git commit 572e373f95
2017-02-28 23:28:30 +00:00
Henrik Levkowetz 695bf37bc6 Merged in [12930] from rjsparks@nostrum.com:
Use the Role email associated with a reviewer as the From when emailing a review. Fixes #2201.
 - Legacy-Id: 12936
Note: SVN reference [12930] has been migrated to Git commit 8577a5e84a
2017-02-28 21:50:12 +00:00
Henrik Levkowetz 363764f872 Fixed a header display issue
- Legacy-Id: 12935
2017-02-28 20:42:46 +00:00
Henrik Levkowetz 6af4ce62aa Removed debugging code.
- Legacy-Id: 12934
2017-02-28 20:42:19 +00:00
Henrik Levkowetz 5bb5ca727b Created a special function log.unreachable() to mark code unreachable, and changed a function name from log.affirm() to log.assertion().
- Legacy-Id: 12933
2017-02-28 20:16:52 +00:00
Robert Sparks 572e373f95 Move primary but inactive email to the most recently touched active email for a Person. If a person has more than one primary email, make all but the first be not primary. Fixes #2214. Commit ready for merge.
- Legacy-Id: 12932
2017-02-28 19:39:01 +00:00
Henrik Levkowetz 089f23f011 Added ordering to Role, and a roles section at the top of the personal profile page.
- Legacy-Id: 12931
2017-02-28 19:33:28 +00:00
Robert Sparks 8577a5e84a Use the Role email associated with a reviewer as the From when emailing a review. Fixes #2201. Commit ready for merge.
- Legacy-Id: 12930
2017-02-28 18:40:09 +00:00
Henrik Levkowetz 5928bd9faa Added svn symlink check and creation to test setup. Forced test settings to use an empty INTERNAL_IPS list for consistency in code coverage figures.
- Legacy-Id: 12929
2017-02-28 18:02:30 +00:00
Henrik Levkowetz 171a7be029 Removed an incorrect Unreachable Code mark.
- Legacy-Id: 12928
2017-02-28 05:08:03 +00:00
Henrik Levkowetz 10cac86165 Preparation for dead code removal: Marked probable dead code with affirm() statements which will signal if we ever reach that point in the code. If no signals seen, the marked functions/methods will be removed after one release cycle.
- Legacy-Id: 12926
2017-02-27 16:45:21 +00:00
Henrik Levkowetz 4f12513b1f Tweaked the affirm() failure message.
- Legacy-Id: 12925
2017-02-27 16:42:23 +00:00
Henrik Levkowetz ac9aa326ef Dead code removal: placement.py and related.
- Legacy-Id: 12924
2017-02-27 13:22:04 +00:00
Henrik Levkowetz 5f053ad21a Cleaned up the remaining explicit url names, using dotted-paths to view
functions instead.  In all almost 700 changes.
 - Legacy-Id: 12923
2017-02-26 23:21:49 +00:00
Henrik Levkowetz 9fb1a8e05f Tweaked an import to make Python 2to3 able to handle it.
- Legacy-Id: 12922
2017-02-26 10:54:33 +00:00
Henrik Levkowetz 84527c9df6 Added some code to utils.urls.url() to output remaining explicit url names together with the matching dotted-path to the view function.
- Legacy-Id: 12921
2017-02-25 20:32:20 +00:00
Henrik Levkowetz cd9cb4ad29 Fixed an issue which left html meta-characters unescaped in release-notes shown under /release/
- Legacy-Id: 12919
2017-02-25 16:37:15 +00:00
Henrik Levkowetz a94c33fd6e Added an alert on the login form, to be shown if a user's password has been cleared. Adjusted url reverse strings to match the changed view function.
- Legacy-Id: 12918
2017-02-25 15:50:47 +00:00
Ryan Cross aa76ea4040 Fixes #2207. bin/merge-person-records remove _meta.get_all_related_objects() deprecated in Django 1.10. Commit ready for merge.
- Legacy-Id: 12917
2017-02-24 21:25:33 +00:00
Henrik Levkowetz 9f74aca342 Tweaked the wording on the account creation whitelisting page to emphasise the wording to be asked then emailing a querent.
- Legacy-Id: 12916
2017-02-24 20:09:49 +00:00
Henrik Levkowetz 2f44e9a97b Personal profile pages already show the primary (unicode) name of a person. Added the asciified name in parentheses, if different from the primary name, in the page header.
- Legacy-Id: 12915
2017-02-24 20:06:19 +00:00
Henrik Levkowetz 11497e5f1f Set version info and settings back to development mode
- Legacy-Id: 12912
2017-02-24 10:38:29 +00:00
Henrik Levkowetz 288073487f Set version info to release version 6.46.0 before branching.
- Legacy-Id: 12910
2017-02-24 10:38:22 +00:00
Henrik Levkowetz c58c51f919 Added a migration which captures the added validator for title fields.
- Legacy-Id: 12907
2017-02-24 10:24:34 +00:00
Henrik Levkowetz ffc6bebe1b Fixed a html error.
- Legacy-Id: 12905
2017-02-23 21:03:07 +00:00
Henrik Levkowetz 23ebe5d35d This addresses ease of editing various group attributes, and in particular is
intended to make it easier to see that you can edit things like the
external/additional URLs:

 - Added the ability to edit individual fields in a group's about page, and
   added edit buttons for editable fields on the about page, just as for
   documents (the ability to edit all editable fields already was available
   from the 'Edit group' button on the /group//about/ page).

 - Made the tab label for the group-about tab consistently say 'About',
   instead of 'Charter' for some groups.

 = Shifted the position of the about tab to the start of the tab line.

 - Removed the datatracker account requirement information at the top of the
   group edit page for users logged in to their account.

 - Tweaked the 'Show update' link on the 'Status Update' line.

 - Changed the label for the external URLs from 'More Info' to 'Additional
   URLs', which was already in use on the edit form.
 - Legacy-Id: 12904
2017-02-23 20:55:38 +00:00
Henrik Levkowetz ffa19c9847 Added a log.affirm() call at the point where we may discover new flawed document author records. Fixed a place where the generation of Person.ascii from Person.name wasn't done well.
- Legacy-Id: 12903
2017-02-23 11:57:29 +00:00
Henrik Levkowetz c4cdb82a39 Made the logging settings explicit in ietf/settings.py (instead of copying default then modifying), and added enough surrounding information to make it possible to read also for people not very familiar with Python's intricate logging infrastructure. To a large extent to understand myself how the logging is set up in Django, and where to hook in the affirm() function.
- Legacy-Id: 12902
2017-02-23 11:53:31 +00:00
Henrik Levkowetz 49af9b4e1a Added an affirm(statement_string) function, which acts like an assert, and lets us trigger an email message with traceback when the statement to affirm is False. Use instead of assert if we still want the server to produce a response, even if something is seriously wrong.
- Legacy-Id: 12901
2017-02-23 11:48:55 +00:00
Henrik Levkowetz fb6e24b6dd Changed the AD email list results from get_group_ad_emails() to make more sense when the group is an area, not a wg.
- Legacy-Id: 12900
2017-02-22 17:33:42 +00:00
Henrik Levkowetz a5290e143a Made some changes to the missing-email submission handling. This may have fixed the creation of author records containing 'none' email entries, but as I've not been able to reproduce the issue, this is uncertain. Next is to build an email notification assert statement to help capture information if this happens.
- Legacy-Id: 12898
2017-02-22 15:36:28 +00:00
Henrik Levkowetz 27351c4349 Fixed url lookups for doc.views_doc.document_main() to only use dotted-path, and removed the doc_view explicit url name. Fixes a 500 error in /submit/status/NNNN/.
- Legacy-Id: 12897
2017-02-22 11:40:55 +00:00
Henrik Levkowetz 988a2b808f Added explicit charset setting and consistent encoding to several email paths through the datatracker. After introducing support for non-ascii names in email addresses, using role.formatted_email() to insert names into email content doesn't work any more, since uncode names will now be rfc2047-encoded in formatted_email(). Added another method role.name_and_email() for this case. Replaced another case of '%s <%s>' name-and-email formatting with formataddr(). Fixed some tests which did not send unicode email bodies to the email functions. Fixes issue #2017.
- Legacy-Id: 12896
2017-02-21 19:17:10 +00:00
Henrik Levkowetz c889856dfa Added a validator to Document.title to prevent control chars in the title (complementing a recent cleanup of more than 120 instances of document titles containing vertical tabs)
- Legacy-Id: 12893
2017-02-20 20:47:37 +00:00
Henrik Levkowetz 858d855eff Changed the new account creation to require a proper name at the same time as the account password is set, before actually creating the account. Also tweaked the password strength and confirmation code.
- Legacy-Id: 12892
2017-02-20 16:50:39 +00:00
Henrik Levkowetz 8a8cf5b811 Set version info and settings back to development mode
- Legacy-Id: 12890
2017-02-20 11:45:43 +00:00
Henrik Levkowetz 73ad26c57d Set version info to release version 6.45.0 before branching.
- Legacy-Id: 12888
2017-02-20 11:45:35 +00:00
Henrik Levkowetz 876d4c93a4 Removed another explicit url() name which blocked a dotted-path reverse, causing 500 for ipr// urls.
- Legacy-Id: 12882
2017-02-19 19:52:56 +00:00
Henrik Levkowetz 8930d29a8e Merged in Django-1.10 upgrade work from ^/personal/henrik/6.43.1-django-1.10
- Legacy-Id: 12881
2017-02-19 18:18:00 +00:00
Henrik Levkowetz 95570d10d4 Set version info and settings back to development mode
- Legacy-Id: 12879
2017-02-19 11:42:41 +00:00
Henrik Levkowetz 11ef465998 Set version info to release version 6.44.1 before branching.
- Legacy-Id: 12877
2017-02-19 11:42:33 +00:00
Henrik Levkowetz cf4a4b02a7 Reworked the email address handling in order to be able to support non-ascii names as part of email address fields. Reworked the generation of user names in the test suite to generate names from multiple non-ascii locales. Fixes issue #2080.
- Legacy-Id: 12872
2017-02-18 21:50:18 +00:00
Henrik Levkowetz b8815b00c5 Don't use person.plain_name() when constructing email addresses, as it can contain unicode characters which the current email pipeline can't handle correctly. Use person.plain_ascii() instead (or person.formatted_email()).
- Legacy-Id: 12865
2017-02-16 22:59:53 +00:00
Henrik Levkowetz 3d56952d56 Set version info and settings back to development mode
- Legacy-Id: 12856
2017-02-16 10:14:14 +00:00
Henrik Levkowetz d81fcb904c Set version info to release version 6.44.0 before branching.
- Legacy-Id: 12854
2017-02-16 10:14:05 +00:00
Henrik Levkowetz c344a18bdf Fixed an issue with the test-crawler which could cause false positives for urls containing apostrophe.
- Legacy-Id: 12851
2017-02-16 09:58:34 +00:00
Henrik Levkowetz 7b7a220df4 Fixed a html entity issue.
- Legacy-Id: 12850
2017-02-16 09:57:24 +00:00