Commit graph

36 commits

Author SHA1 Message Date
Lars Eggert 8a70e9773d Fix various "RemovedInDjango20Warning" warnings. Commit ready for merge.
- Legacy-Id: 13112
2017-03-25 19:16:45 +00:00
Henrik Levkowetz 40e8380751 Merged django 1.9 work forward to copy of trunk @6.41.0
- Legacy-Id: 12756
2017-01-30 23:13:02 +00:00
Henrik Levkowetz 6de7be6953 Specified strip=False for another bunch of CharField form fields with Textarea widgets.
- Legacy-Id: 12711
2017-01-23 17:38:56 +00:00
Robert Sparks 518f7a1d65 Restrict editing ReviewSettings.skip_next to team secretaries and the secretariat. Improve validation of skip_next value. Fixes #2149. Commit ready for merge.
- Legacy-Id: 12706
2017-01-19 19:17:29 +00:00
Robert Sparks 8e007ce50b Make changing skip_next on a review assignment an explicit decision of the assigner. Commit ready for merge. Fixes #2148.
- Legacy-Id: 12670
2017-01-19 14:23:09 +00:00
Robert Sparks 49dcf67fd5 Make it easier to see who's really next in reviewer rotation. Commit ready for merge.
- Legacy-Id: 12665
2017-01-17 22:04:16 +00:00
Henrik Levkowetz fa684cf6d2 Merged in [12541] from rjsparks@nostrum.com:
Provide default filters for reviewer settings. Fixes #2093.
 - Legacy-Id: 12546
Note: SVN reference [12541] has been migrated to Git commit df86798cf3
2016-12-15 21:57:46 +00:00
Henrik Levkowetz 83a260c6c0 Merged in [12482] from rjsparks@nostrum.com:
Improves control of email headers for review summary messages. Provides team-specific templates for review summary messages. Fixes #2092 and #2082.
 - Legacy-Id: 12483
Note: SVN reference [12482] has been migrated to Git commit 06179c7485dac6c69b2aa30e66095a23a4460209
2016-12-08 17:55:37 +00:00
Ole Laursen 7d8baf0015 Add reviewer name and completion date to previous reviews in manage
review page
 - Legacy-Id: 12397
2016-11-25 10:53:37 +00:00
Ole Laursen 39d674b4ca Add missing resource and missing test review secretary settings
- Legacy-Id: 12313
2016-11-09 10:07:49 +00:00
Ole Laursen ceec1254f2 Add review team secretary reminders, like those for reviewers
- Legacy-Id: 12283
2016-11-08 16:24:28 +00:00
Ole Laursen cde7cfacd5 Modify the reviewer overview page to display up to 10 historic reviews
per person from the past year instead of only 5.

Add basic reviewer stats to the assignment select box.
 - Legacy-Id: 12279
2016-11-07 22:32:53 +00:00
Ole Laursen c3e8cabafb Revamp the layout in the manage review requests page. Drop the table
and instead provide more information about each document to be
reviewed, to help the secretaries determine locally on that page what
action to take. The new layout should also make it easier to fit in
more info, in case it is still found lacking.

The public review request page still provides the previous information
in the summarized tabular form, so the overview can be found there.
 - Legacy-Id: 12278
2016-11-07 21:20:15 +00:00
Ole Laursen 58dd25ff79 Split up open review requests on the review team page in assigned and
unassigned requests to make it easier to just work with the unassigned
ones. Use same split on the manage reviews page which is now two
pages.
 - Legacy-Id: 12266
2016-11-04 17:19:33 +00:00
Ole Laursen b9d5352afd Display the reviewed revision in reviewer overview page
- Legacy-Id: 12245
2016-11-02 11:33:25 +00:00
Ole Laursen 3835532d71 Insert iconic link to review statistics from the team pages
- Legacy-Id: 12215
2016-10-26 13:35:32 +00:00
Ole Laursen d0877a0aa9 Change default of ReviewerSettings.min_interval to null - if it's not
specified for a reviewer, we don't take it into account
 - Legacy-Id: 12168
2016-10-18 10:36:42 +00:00
Ole Laursen 399bb3bf4d Make UnavailablePeriod.start_date nullable and import the unavailable
periods from the Perl tool with start date null as we don't know when
they started.
 - Legacy-Id: 12161
2016-10-17 19:37:56 +00:00
Ole Laursen 505b4fcea3 Fix redirection problem when group_type is not given.
- Legacy-Id: 12136
2016-10-13 19:34:39 +00:00
Ole Laursen bf55237112 Add statistics section with review statistics. Fix a couple of missing tests.
- Legacy-Id: 12124
2016-10-13 15:20:04 +00:00
Ole Laursen 59180240af Add a simple reminder system for reviewers so that they can opt in to
being reminded X days before deadline of an assignment
 - Legacy-Id: 12101
2016-10-07 16:43:29 +00:00
Ole Laursen 227fdd7953 Add reviews to search results and IESG agenda. Support restricting
review types so that teams will only have those review types
listed and suggested that they are configured to have.

Fix a couple of things in the importer after having tested it on all
the databases. Set unavailable end date >= 2020 to indefinite.

Fix a couple of bugs.
 - Legacy-Id: 12095
2016-10-06 14:47:41 +00:00
Ole Laursen a177dc616b Fix a couple of bugs, add test for reviewer overview page
- Legacy-Id: 12081
2016-10-04 20:22:11 +00:00
Ole Laursen 4c7b2847ba Add a utility function for extracting information about review
requests for a given set of teams/reviewers (making it trivial to
compute statistics), revamp the related doc event code to support this
by referencing the review request directly, add a reviewer overview
page with recent performance for each reviewer as well as
settings/unavailable periods. Fix some bugs and shuffle some of the
review code a bit around.

Finish the importer from the previous Perl-based review tool,
importing log entries, figuring out whether a given review is
early/telechat/last call and fixing corner cases.
 - Legacy-Id: 12080
2016-10-03 15:52:32 +00:00
Ole Laursen 99beb58291 Implement a round-robin rotation scheme for reviewers instead of
relying on when they last reviewed. In-order assignments automatically
move the rotation forwards while out-of-order assignments increment
the skip next of the assigned reviewer. Include rotation in open
review assignments email. Fix a couple of issues in the importer.
 - Legacy-Id: 12015
2016-09-21 16:52:50 +00:00
Ole Laursen 6da25e6bd9 Add personal review overview page for reviewers, add page for editing
reviewer availability settings, emailing the reviewer/secretary as
necessary, add tests for these pages. Fix a bunch of bugs.
 - Legacy-Id: 11998
2016-09-19 16:05:32 +00:00
Ole Laursen dd190b87fe Follow replacements when displaying reviews for a draft on the
document page, too. Add a test to check that recursive replacements
are handled correctly. Polish the display a bit.
 - Legacy-Id: 11847
2016-08-23 14:55:42 +00:00
Ole Laursen 16e28481f6 Add page for emailing open review assignments summary to the review team list
- Legacy-Id: 11846
2016-08-23 14:06:47 +00:00
Ole Laursen 1f71268da1 More polish on manage review requests page: Add save and continue
editing button, reverse sort order so latest (and probably most
interesting) is at the top, disable save buttons when there are no
changes to save
 - Legacy-Id: 11843
2016-08-23 12:12:24 +00:00
Ole Laursen 507baade01 Add refresh button to manage reviews page, make save detect changes in
the requests and pop the page back up for confirmation if so
 - Legacy-Id: 11827
2016-08-19 16:40:09 +00:00
Ole Laursen f7eeb1f0f1 Add missing constraint on team in manage review request page
- Legacy-Id: 11636
2016-07-12 16:12:04 +00:00
Ole Laursen db4ea01e20 Take a bunch of factors into account when sorting reviewers for
assignment to a review request
 - Legacy-Id: 11626
2016-07-12 13:04:14 +00:00
Ole Laursen 5c8be91b08 Improve review assignment slightly by sorting reviewers by latest
review - still missing a bunch of factors, and unassignment is now
temporarily gone
 - Legacy-Id: 11531
2016-07-07 12:17:55 +00:00
Ole Laursen d54459b28a Add tests of suggested review requests, make suggestions take more
things into account
 - Legacy-Id: 11528
2016-07-06 13:14:11 +00:00
Ole Laursen 19fff81a4f Rework closing a review request so the logic is reusable, add the more
specific close reasons to the database migration, add
ReviewRequest.requested_by so it's possible to notify the requester of
a review that it has been dropped.
 - Legacy-Id: 11520
2016-07-05 16:05:00 +00:00
Ole Laursen e2e66522c7 Add review request page for review teams and first draft of manage
review requests page.

Add importer for importing review data from the existing Perl tool
(WIP, gets most but not all of the interesting information out).

Fix various bugs.
 - Legacy-Id: 11508
2016-07-01 16:06:16 +00:00