Jennifer Richards
93e9f8e850
fix: Do not set update_fields when saving new instance
2023-05-19 14:36:08 -03:00
Jennifer Richards
be25fb954b
test: Ignore menu bar when counting "submit" buttons
...
(the "Sign out" link is now a submit button)
2023-05-19 14:18:02 -03:00
Jennifer Richards
102a612857
test: POST instead of GET for logout tests
2023-05-19 14:12:12 -03:00
Jennifer Richards
37a6521879
test: Form is r.context["form"], not r["form"]
2023-05-19 13:37:39 -03:00
Jennifer Richards
1eafdca65c
chore: Replace django.utils.timezone.utc with dateutil.timezone.utc
2023-05-19 13:23:38 -03:00
Jennifer Richards
fdc074b313
test: Use new signature for assertFormError
2023-05-19 13:23:07 -03:00
Jennifer Richards
da8717f0e9
chore: Set chunk_size on QuerySet.iterator()
2023-05-19 13:10:06 -03:00
Jennifer Richards
7ae0576a44
style: Apply Black style to methods in review.utils
2023-05-19 13:08:47 -03:00
Jennifer Richards
b6a791511f
chore: Use DjangoDivFormRenderer to opt in to new default
2023-05-19 12:52:26 -03:00
Jennifer Richards
2d6681d78c
refactor: logout via GET is deprecated, use POST
2023-05-19 11:42:43 -03:00
Jennifer Richards
b06fc7acc4
chore: Suppress warning about CryptPasswordHasher
2023-05-19 11:28:58 -03:00
Jennifer Richards
19abdfe5e7
refactor: Inject tests without using deprecated extra_tests
2023-05-19 11:09:05 -03:00
Jennifer Richards
25b9976460
chore: Switch to JSONSerializer
...
PickleSerializer is deprecated
2023-05-18 18:37:25 -03:00
Jennifer Richards
39a854fa1a
fix: Use arbitrary date in the past instead of datetime.min
2023-05-18 18:36:38 -03:00
Robert Sparks
d0f8e1148a
chore: keep csp config in sync with production configuration ( #5656 )
2023-05-18 16:29:30 -05:00
Robert Sparks
34d714c4ec
chore: remove gather from CRSF_TRUSTED_ORIGINS ( #5657 )
2023-05-18 16:29:18 -05:00
Jennifer Richards
c71f44fdb2
chore: Suppress deprecation warning for oidc_provider
2023-05-18 18:00:46 -03:00
Jennifer Richards
6df5d4c67f
chore: Suppress CICharField deprecation warning
2023-05-18 18:00:46 -03:00
Jennifer Richards
65ea426793
fix: Add changed fields to update_fields in Model.save() methods
2023-05-18 18:00:45 -03:00
Jennifer Richards
171a5bec73
chore: Update setuptools version and suppress warnings
...
pkg_resources warning is caused by a few packages
(django-simple-history. django-widget-tweaks, etc). The datetime_safe
warning is in tastypie, as indicated. The others are deprecated
settings we already have tickets for.
2023-05-18 18:00:45 -03:00
Jennifer Richards
55fb502179
test: Iterate over template.nodelist in apply_template_test
2023-05-18 15:18:02 -03:00
Jennifer Richards
47e2b0b027
fix: Prevent use of FK relation before review request is saved
2023-05-18 15:18:02 -03:00
Jennifer Richards
c26c9c71e4
chore: Switch to PyMemcacheCache backend
2023-05-18 15:18:01 -03:00
Jennifer Richards
cdec6cc0aa
Merge pull request #5655 from ietf-tools/main
...
chore: Merge main into feat/django4
2023-05-18 15:15:42 -03:00
Robert Sparks
f9322391dd
fix: change trac.ietf.org links to what they redirect to now ( #5651 )
2023-05-18 08:31:54 -05:00
Jennifer Richards
cbabb864c2
test: Use issubclass, not isinstance, to ID view_class
2023-05-17 16:09:56 -03:00
Jennifer Richards
d519bca12c
test: Fix ignore_pattern so Redirect/TemplateViews are ignored again
2023-05-17 15:59:28 -03:00
Eric Vyncke
2a27a2bffc
feat: Can we provide a better review assignment email subject. #3760 ( #5415 )
...
* Specific email subject + requester/secretary in cc
* Send the deadline in the subject
* Use unicode rather than ASCII for reviewer's name
* More log info in the test
* Fix the closing parenthesis
* Fix the email test when review is assigned
* chore: address review comment
---------
Co-authored-by: Robert Sparks <rjsparks@nostrum.com>
2023-05-17 12:23:20 -05:00
Jennifer Richards
f85978fe24
chore: Disable L10N localization
2023-05-17 12:52:34 -03:00
Robert Sparks
ab01e72ada
fix: tweak submit instructions to match very recent changes to the UI ( #5646 )
2023-05-17 09:25:17 -05:00
Russ Housley
ef598a6dae
fix: Update I-D submission instructions. Fix #5264 ( #5407 )
...
* Fix: Update I-D submission instructions. Fix #5264
* Resolve comments in PR 5407
2023-05-17 09:17:30 -05:00
Jennifer Richards
8cf609bfa9
refactor: Implement require_api_key with functools.wraps
...
The @decorator mechanism does not seem to work with @method_decorator
in Django 4.0, have not tracked down why.
2023-05-17 09:45:07 -03:00
Robert Sparks
38bab2575e
fix: better htmlized access to uncurrent revisions ( #5639 )
2023-05-16 17:08:18 -05:00
Jennifer Richards
223c679942
chore: Add no-op migration to satisfy Django bookkeeping changes
2023-05-16 17:48:44 -03:00
Nicolas Giard
12f1cb200a
feat: set fonts for htmlized doc template ( #5636 )
2023-05-16 14:56:36 -05:00
Jennifer Richards
88452a2db1
chore: Add USE_DEPRECATED_PYTZ to settings.py
2023-05-16 16:20:51 -03:00
Jennifer Richards
76fa01b817
chore: Suppress deprecation warning for oidc_provider AppConfig
2023-05-16 13:21:12 -03:00
Jennifer Richards
374c1a40be
chore: Use new format for CSRF_TRUSTED_ORIGINS setting
2023-05-16 13:14:48 -03:00
Jennifer Richards
7475aa01b6
Merge pull request #5634 from ietf-tools/main
...
chore: Merge main into feat/django4
2023-05-16 13:06:49 -03:00
Paul Selkirk
37118a623a
fix: change api_submission blackout message to match web ui ( #5623 )
...
* test: api_submission returns an error in the blackout period
* fix: change api_submission blackout message to match web ui (#5350 )
2023-05-16 09:43:20 -05:00
Robert Sparks
c16a9d6cb5
fix: better area links from the menus ( #5620 )
...
* fix: better area links from the menus
* chore: remove debugging line
2023-05-15 16:41:42 -05:00
Robert Sparks
6fd9a39df8
chore: update test name fixuture ( #5627 )
2023-05-15 16:38:11 -05:00
Nicolas Giard
3d6ca172ce
feat: change fonts to Inter and Noto Sans Mono ( #5628 )
2023-05-15 16:37:00 -05:00
Jennifer Richards
b714bfb083
chore: Put widgets from django-password-strength into ietfauth
2023-05-15 17:55:11 -03:00
Robert Sparks
b4a692fac1
fix: show session times in meeting timezone when announcing scheduling ( #5622 )
2023-05-15 14:55:37 -05:00
Robert Sparks
7dbac2067f
fix: show meeting timezone when editing sessions ( #5619 )
...
* fix: show meeting timezone when editing sessions
* chore: run black on session_filters
2023-05-15 14:50:10 -05:00
Jennifer Richards
329fa26ee0
chore: Remove abandoned django-password-strength package
2023-05-15 15:29:00 -03:00
Robert Sparks
962af9feb3
fix: tweak removal of document info order ( #5624 )
...
* fix: tweak removal of document info order
* chore: add copyright line
* chore: correct dependencies
2023-05-15 13:20:59 -05:00
Jennifer Richards
0319f35e0f
test: Use Django 3.2 HttpResponse.headers API
2023-05-15 13:01:59 -03:00
Peter Yee
369fe0dfe5
fix: remove order from DocumentInfo as apparently unneeded ( fixes #5245 ) ( #5417 )
...
* fix: remove order from DocumentInfo as apparently unneeded (fixes #5245 )
Fixes #5245 . Includes migration, however I did not test the reverse.
* Merge branch 'main' into pr/Spectre17/5417
* chore: Renumber migrations
* Revert "Merge branch 'main' into pr/Spectre17/5417"
This reverts commit 77b4a46f84e9ece6778dec6e8127aedad71c2625.
---------
Co-authored-by: Jennifer Richards <jennifer@staff.ietf.org>
Co-authored-by: Robert Sparks <rjsparks@nostrum.com>
2023-05-15 10:35:54 -05:00
Jennifer Richards
22bf508922
test: Suppress notices from mypy involving factory types
2023-05-15 12:20:02 -03:00
Jennifer Richards
cbb946455f
test: Remove unused assignment that caused a mypy error
2023-05-15 11:25:38 -03:00
Jennifer Richards
c840d53cb2
test: Suppress mypy error on import of _lazy_re_compile()
2023-05-15 11:04:29 -03:00
Jennifer Richards
68eb685382
test: Use django_stubs_ext.QuerySetAny for isinstance() checks
...
mypy complains if QuerySet is used because it uses a parameterized
generic type.
2023-05-13 10:05:33 -03:00
Jennifer Richards
7ad74c99e4
refactor: import from django.urls instead of django.conf.urls
2023-05-12 20:29:11 -03:00
Jennifer Richards
00f3f01e7e
fix: {% endif %}, not {% end %}
2023-05-12 18:52:35 -03:00
Jennifer Richards
872bdef06b
refactor: Use gettext instead of deprecated ugettext
2023-05-12 18:37:01 -03:00
Jennifer Richards
79b749fcdf
style: Restyle method using Black
2023-05-12 18:36:05 -03:00
Jennifer Richards
21004864b0
refactor: Replace deprecated is_safe_url with new name
2023-05-12 18:35:12 -03:00
Jennifer Richards
32ed1b7c4a
refactor: Replace deprecated {% ifequal %} with {% if %}
2023-05-12 18:33:15 -03:00
Jennifer Richards
bee7e11360
chore: Remove accidental import from settings.py
2023-05-12 18:29:39 -03:00
Jennifer Richards
b5d9e9b14c
refactor: Replace deprecated django.utils.http.urlquote
2023-05-12 18:27:51 -03:00
Jennifer Richards
075aed7e9a
refactor: Replace deprecated request.is_ajax()
2023-05-12 18:26:56 -03:00
Jennifer Richards
9d21196adc
chore: Add DEFAULT_AUTO_FIELD to settings.py
2023-05-12 18:03:28 -03:00
Jennifer Richards
aa4c04126c
chore: Use re_path() instead of url(), its deprecated synonym,
2023-05-12 17:09:32 -03:00
Jennifer Richards
d0cb46d320
fix: Use TruncDate instead of QuerySet.extra()
2023-05-12 15:47:37 -03:00
Jennifer Richards
ccb7d666ce
chore: Remove add-django-http-cookie-value-none.patch
...
Fixed upstream
2023-05-12 15:47:37 -03:00
Jennifer Richards
1419a0e7c8
test: Remove ScheduleEditTests.testUnschedule ( #5607 )
...
* test: Remove ScheduleEditTests.testUnschedule
Has been disabled under Django 2. Simple refactoring does not make it
functional under Django 3. Probably because we know that Selenium does
not handle HTML5 drag-and-drop well. Discarding until we move to a
better JS testing framework.
* test: Remove unused imports
2023-05-12 13:18:15 -03:00
Jennifer Richards
96396b833c
Merge pull request #5611 from ietf-tools/main
...
chore: merge main into feat/django4
2023-05-12 11:05:57 -03:00
Robert Sparks
6b4115a52b
test: ignore irrelevant difference in list element order ( #5609 )
2023-05-12 09:03:13 -05:00
Robert Sparks
1afdb0b7cc
fix: show htmlized views of draft revisions without DocHistory ( #5599 )
...
* fix: show htmlized views of draft revisions without DocHistory
* fix: handle htmlized views of rfcs corectly
2023-05-11 17:15:01 -05:00
Jennifer Richards
264ff60cd2
Merge pull request #5601 from jennifer-richards/django4
...
chore: Upgrade to Django 3.0
2023-05-11 11:04:36 -04:00
Robert Sparks
6089d4726c
chore: remove debugging file write from test ( #5598 )
2023-05-11 09:37:02 -05:00
Jennifer Richards
0d070597b4
style: Double backslashes in strings
...
Not sure why, but if I change the DeprecationWarning filter to
"error", I get a SyntaxError from the \[ because it is an invalid
escape sequence. Not sure why that change triggers it, but
"\[" and "\\[" are the same, so this is a no-op.
2023-05-10 19:21:47 -03:00
Jennifer Richards
eee145ee67
fix: Explicitly order GroupTypeNames in active_group_types
...
Relying on Meta.ordering to order querysets involving GROUP BY queries
is deprecated and will be dropped in Django 3.1.
2023-05-10 19:19:39 -03:00
Jennifer Richards
406ba7bf0b
style: Apply Black style to active_group_types() view
2023-05-10 19:18:30 -03:00
Jennifer Richards
e6259a5218
chore: Remove filter on staticfiles DeprecationWarning
2023-05-10 18:52:52 -03:00
Jennifer Richards
1015cf83f8
fix: Finish refactoring LiaisonModelForm subclasses without BetterModelForm
2023-05-10 18:47:36 -03:00
Jennifer Richards
4f443cc445
refactor: Explicitly allow name=None for a couple of views
2023-05-10 17:16:20 -03:00
Jennifer Richards
163479bc06
refactor: Replace obsolete staticfiles
template lib with static
2023-05-10 17:12:34 -03:00
Jennifer Richards
85d0934ba0
refactor: Refactor LiaisonForm without BetterModelForm
2023-05-10 17:03:31 -03:00
Jennifer Richards
a75dbd4f40
chore: Remove accidentally reverted removal of form_utils app
2023-05-10 16:50:42 -03:00
Jennifer Richards
57026bbb5f
Revert "chore: Remove django-cookie-delete-with-all-settings.patch"
...
This reverts commit 2cf2a3dee6
.
2023-05-10 15:55:25 -03:00
Jennifer Richards
69eb6340fd
test: Do not misuse django.conf.settings for HTML validation params
2023-05-10 15:41:36 -03:00
Robert Sparks
f8113cb862
fix: close open things ( #5593 )
...
* fix: close open things
* fix: clean up test created files
* fix: remove one close too many
2023-05-10 11:19:34 -05:00
Jennifer Richards
ed571ae50b
chore: Rename DB engine to drop the deprecated "_psycopg2" suffix
2023-05-10 12:40:37 -03:00
Jennifer Richards
a0f6cdb661
feat: Process uploaded submissions asynchronously ( #5580 )
...
* fix: Use relative URL for submission status link
* refactor: Refactor/rename process_uploaded_submission async task
* feat: Add async task to process but not accept a submission
* feat: Replace upload_submission() with an async implementation (WIP)
* fix: Do not put Submission in "uploaded" state if an error occured
* refactor: Improve text/XML draft processing flow
* feat: Extract authors from text in async processing
* fix: Fix call signatures and abort submission on failed validation
* feat: Validate submission name format
* fix: Correctly validate emails from text submission
* fix: Clean up submission validation
* fix: Better display errors on upload_submission page
* feat: Reload submission status page when awaiting validation
* test: Fix call signatures; remove unused imports
* chore: Add type hint
* test: Update tests to match renamed task
* fix: Fix typo in error message
* test: Fix failing Api- and AsyncSubmissionTests
* Rename process_uploaded_submission to process_and_accept_...
* Remove outdated tests
Does not yet test new behavior.
* refactor: Break up submission_file() helper
* test: Refactor tests to run the async processing (wip)
* test: Drop test of bad PDF submission
The PDF submission field was removed, so no need to test it.
* test: Update more tests
* test: Bring back create_and_post_submission() and fix more tests
* fix: Drop to manual, don't cancel, on revision inconsistency
Fixes remaining failing SubmitTest tests
* style: Restyle upload_submission() with black
* test: Verify that async submission processing is invoked on upload
* test: Bring back old do_submission and fix tests
Properly separating the upload and async processing stages of submission
is a bigger refactoring than will fit right now. This better exercises
the submission pipeline.
* fix: Accept only XML for API submissions
* test: Test submission processing utilities
* feat: Improve status display for "validating" submissions
* chore: Remove obsolete code
* test: Update test to match amended text
---------
Co-authored-by: Robert Sparks <rjsparks@nostrum.com>
2023-05-09 15:21:46 -05:00
Jennifer Richards
da168395fc
refactor: Replace deprecated smart_text with smart_str
2023-05-09 15:23:33 -03:00
Jennifer Richards
07e26dd52e
refactor: Replace deprecated force_text with force_str
2023-05-09 15:21:50 -03:00
Jennifer Richards
dcb211fbb3
Merge remote-tracking branch 'origin/main' into django4
2023-05-09 14:26:47 -03:00
Jennifer Richards
2cf2a3dee6
chore: Remove django-cookie-delete-with-all-settings.patch
...
Patch no longer applies. Needed until Django 4.2.1, so bring it back
if we deploy something earlier than that to production.
2023-05-09 11:09:41 -03:00
Jennifer Richards
6d4d09542f
fix: Replace obsolete curry()
with functools.partialmethod()
2023-05-08 22:55:15 -03:00
Robert Sparks
400a830661
chore: add bibxml-ids dir to container build. ( #5590 )
2023-05-08 15:16:31 -05:00
Jennifer Richards
9fda268853
fix: Replace available_attrs
helper (dropped by Django 3.0)
2023-05-08 15:19:33 -03:00
Robert Sparks
2b1f248e36
fix: add a link to the simplified volunteer view ( #5583 )
2023-05-08 10:29:18 -05:00
Robert Sparks
3bbd5149de
feat: Easy extraction of qualified volunteer list for nomcom chair ( #5578 )
...
* feat: Easy extraction of qualified volunteer list for nomcom chair
* fix: tune test setup to years where eligibility calculations can return nonempty
* chore: revert unintended change
* feat: default string when no affiliation is provided
2023-05-05 15:33:47 -05:00
Eliot Lear
8af8a91c20
fix: allow ISE to initiate conflict review ( #5570 )
...
* ISE may initiate conflict review
Add ISE to list of those roles who can initiate a conflict review.
* fix: improve conditional for conflict review action. Add tests.
* chore: fix comment typo
---------
Co-authored-by: Robert Sparks <rjsparks@nostrum.com>
2023-05-03 14:04:09 -05:00
Jennifer Richards
6986cae1bf
fix: Listen for show.bs.modal on document ( #5565 )
...
Avoids losing the listener when DOM is changed dynamically.
2023-05-02 13:50:38 -05:00
Jennifer Richards
db2f7362c5
feat: Include support address in error message
2023-04-27 17:51:19 +00:00
Jennifer Richards
b691cb4a9f
fix: Avoid 500 error creating account when User.person is None
2023-04-26 18:34:49 +00:00