altf4arnold/datatracker
1
0
Fork 0
Code Issues Pull requests Actions 2 Packages Projects Releases Wiki Activity
16467 commits 1 branch 0 tags 2.6 GiB
Commit graph

682 commits

Author SHA1 Message Date
Henrik Levkowetz 22e0d39e4b Fixed an issue where text file charset information would be overwritten on upload of multiple files for a draft. Fixes issue #2768. 
- Legacy-Id: 16626
 2019-08-06 15:41:13 +00:00
Henrik Levkowetz 915d8e3c2a Added LookupError to the exceptions caught during text upload decoding, leading to upload form validation error. 
- Legacy-Id: 16573
 2019-07-22 15:47:40 +00:00
Henrik Levkowetz e03784132d Merged changes from current trunk to Py3 branch. 
- Legacy-Id: 16468
 2019-07-16 15:36:16 +00:00
Henrik Levkowetz bdc73e771a Python2/3 compatibility: replaced six.ensure_text() with either six.text_type or django's force_text(), depending on the case, and fixed a variable scope issue. 
- Legacy-Id: 16461
 2019-07-16 13:20:05 +00:00
Henrik Levkowetz 8c6eb3a30a Python2/3 compatibility: Changed the use of open() and StringIO to io.open() etc. 
- Legacy-Id: 16458
 2019-07-15 19:14:04 +00:00
Henrik Levkowetz ea8c84d2f6 Python2/3 compatibility: used @python_2_unicode_compatible to provide __unicode__() versions of __str__() methods. 
- Legacy-Id: 16455
 2019-07-15 18:01:26 +00:00
Henrik Levkowetz 99a7f9c263 Python2/3 compatibility: Added force_str or force_bytes in some places, to ensure the argument right type 
- Legacy-Id: 16453
 2019-07-15 17:13:46 +00:00
Henrik Levkowetz 855716e1d5 Py2/3 compatibility: Added __future__ import 
- Legacy-Id: 16448
 2019-07-15 15:46:06 +00:00
Henrik Levkowetz 2d7c9629aa Added 'from __future__' imports all over the place, to bring code behaviour into closer alignment between python2 and python3 
- Legacy-Id: 16446
 2019-07-15 15:40:51 +00:00
Henrik Levkowetz f481f5c3e6 Replaced use of six with the equivalent pure python3 constructs. 
- Legacy-Id: 16428
 2019-07-08 10:43:47 +00:00
Henrik Levkowetz 48bab56be9 Removed a print() call 
- Legacy-Id: 16420
 2019-07-07 13:04:20 +00:00
Henrik Levkowetz 1225f8af6b Refactored submission code to be clearer and only do mimetype extraction in one place, made the point where files are saved less obscure, fixed bytes/str issues for file read and write, fixed regex strings, fixed variable name visibility due to scope changes in py3. 
- Legacy-Id: 16375
 2019-07-04 15:49:42 +00:00
Henrik Levkowetz 2e92652eaa Changed a regex to use an r string. Added decoding of command pipe output. 
- Legacy-Id: 16374
 2019-07-04 15:45:18 +00:00
Henrik Levkowetz b54e033474 Fixed an error in the handling of long draft names extracted from xml source. 
- Legacy-Id: 16363
 2019-07-03 19:56:04 +00:00
Henrik Levkowetz 97a555936d Changed a large number of test assertions to use assertContains() and removed separate, now unnecessary,status_code checks. Also changed many assertTrue(... in ...) to use assertIn(). 
- Legacy-Id: 16346
 2019-06-30 21:03:34 +00:00
Henrik Levkowetz 15e74e89cb Converted instances of assertTrue(text in response.content) to the recommended assertContains(response, text), and similar for assertFalse(... in ...) 
- Legacy-Id: 16336
 2019-06-29 13:43:31 +00:00
Henrik Levkowetz 484dcece5f Changed all model __unicode__() methods to __str__() 
- Legacy-Id: 16330
 2019-06-28 21:07:08 +00:00
Henrik Levkowetz 3ec7e864be Converted leading tabs to spaces in ietf/**/*.py 
- Legacy-Id: 16310
 2019-06-27 14:51:02 +00:00
Henrik Levkowetz d7f5c84182 Initial 2to3 patch with added copyright statement updates. 
- Legacy-Id: 16309
 2019-06-27 14:40:54 +00:00
Henrik Levkowetz 13705976e2 Merged in [16287] from rjsparks@nostrum.com: 
Send mail to a list when a new IETF WG -00 is submitted. Fixes #2730.
 - Legacy-Id: 16289
Note: SVN reference [16287] has been migrated to Git commit 9ace7db719
 2019-06-19 14:32:25 +00:00
Henrik Levkowetz db12f2b948 Fixed some name versus pk issues lingering after the Document/DocAlias primary key refactoring. Fixes issue #2729. 
- Legacy-Id: 16288
 2019-06-19 12:57:52 +00:00
Robert Sparks 9ace7db719 Send mail to a list when a new IETF WG -00 is submitted. Fixes #2730. Commit ready for merge. 
- Legacy-Id: 16287
 2019-06-18 21:24:49 +00:00
Henrik Levkowetz 7270d5f67a Added the option to order API resource lists by primary key, for stable ordering when paging through a list. 
- Legacy-Id: 16284
 2019-06-18 12:40:19 +00:00
Henrik Levkowetz a5cf8b6a3b Added a better error message for too long draft names during submission. 
- Legacy-Id: 16281
 2019-06-17 18:25:05 +00:00
Henrik Levkowetz 426870b766 Merged in the Document and DocAlias primary key change and m2m work in ^/personal/henrik/6.96.1-docalias. 
- Legacy-Id: 16261
 2019-06-15 12:00:48 +00:00
Henrik Levkowetz a2cafded25 Changed DocAlias to be many-to-many, in order to be able to handle STD aliases referring to multiple RFCs. 
- Legacy-Id: 16249
 2019-06-14 20:38:14 +00:00
Henrik Levkowetz d300a82845 Added validation of draft names extracted from XML submission files. 
- Legacy-Id: 16239
 2019-06-12 22:06:53 +00:00
Henrik Levkowetz 5e796292ff Added class inheritance from 'object'. 
- Legacy-Id: 16238
 2019-06-12 21:31:42 +00:00
Henrik Levkowetz 815602351f This is a series of 50 migrations that changes the Document and DocAlias 
primary keys from character strings to integers, and makes corresponding code
changes.

This was prompted by database limitations discovered when trying to make
DocAlias use a m2m document field; with 255 long strings as primary keys for
Document and DocAlias this violated the MySQL database limitations.

Changing the primary keys to integers should also improve efficiency.  

Due to the data migrations which create the new integer primary keys and adds
corresponding integer foreign keys matching the previous string foreign keys
in all tables having foreign keys to Document and DocAlias, some of these
migrations take a long time.  The total set of migrations are expected to have
a runtime on the order of 2 hours.
 - Legacy-Id: 16237
 2019-06-10 11:32:46 +00:00
Henrik Levkowetz 94de3e0f7e Refined the handling of draft xml version 3 versus version 2. 
- Legacy-Id: 16229
 2019-06-03 14:51:34 +00:00
Henrik Levkowetz 175c75cfaf Removed a debug print statement 
- Legacy-Id: 16111
 2019-03-28 10:11:33 +00:00
Henrik Levkowetz 2f31f7fb88 Temorary workaround to upload xml validation. The tree.validate() of xml2rfc should be updated to check vocabulary version and validate against the appropriate schema, to fix this properly. 
- Legacy-Id: 16101
 2019-03-25 10:56:30 +00:00
Henrik Levkowetz 07fa09b6dc Removed a debug print statement 
- Legacy-Id: 15963
 2019-02-25 12:30:52 +00:00
Henrik Levkowetz e8a59ce1e5 Rewrote the submission deduce_group() to consider all groups with acronyms that are also GroupTypeNames. Added GroupTypeName for iesg,ise,adhoc groups, and appropriate GroupFeatures for each. Updated the names.json fixture. 
- Legacy-Id: 15960
 2019-02-21 15:27:58 +00:00
Henrik Levkowetz fc5dd02c27 Fixed a submission failure for xml files missing abstract sections. 
- Legacy-Id: 15933
 2019-02-07 15:26:26 +00:00
Henrik Levkowetz b57ad67041 Updated code and templates to use the new docman and groupman group features. 
- Legacy-Id: 15922
 2019-01-30 15:59:00 +00:00
Henrik Levkowetz c87d3741f3 Added 2 utility functions to help create group features query filters, and applied them in 3 places in order to move group feature role list code back into DB queries. 
- Legacy-Id: 15911
 2019-01-23 18:40:39 +00:00
Henrik Levkowetz 57a4c9f41f Added 9 new group features, and changed list-like char fields to json fields, to get better support for using the values as lists. Modified code to use the group features instead of explicit lists of group types in many places in the code. 
- Legacy-Id: 15908
 2019-01-22 18:11:46 +00:00
Henrik Levkowetz 47aaf48cd5 Merged in [15833] from rjsparks@nostrum.com: 
Incremental improvements to the submit_existing tests.
 - Legacy-Id: 15873
Note: SVN reference [15833] has been migrated to Git commit 21a673490b
 2019-01-07 17:56:04 +00:00
Henrik Levkowetz 879f44a2ab Merged in [15829] from rjsparks@nostrum.com: 
Make state/substate changes on new submissions sensitive to stream. Fixes #2642.
 - Legacy-Id: 15872
Note: SVN reference [15829] has been migrated to Git commit 3d6c1f991b
 2019-01-07 15:51:07 +00:00
Henrik Levkowetz 0cc7f73d58 Additional tweaks to submission yang testing and the test runner 
- Legacy-Id: 15870
 2019-01-07 13:38:44 +00:00
Henrik Levkowetz 2634e2143a Added a bit of additional checking to test_submit_invalid_yang. 
- Legacy-Id: 15869
 2019-01-07 11:43:28 +00:00
Robert Sparks 21a673490b Incremental improvements to the submit_existing tests. Commit ready for merge. 
- Legacy-Id: 15833
 2018-12-18 23:22:40 +00:00
Robert Sparks 3d6c1f991b Make state/substate changes on new submissions sensitive to stream. Fixes #2642. Commit ready for merge. 
- Legacy-Id: 15829
 2018-12-17 22:38:22 +00:00
Robert Sparks 6118975620 Added an explicit ID-Exists state for the IESG state machine. Reworked code so that the IESG state machine always has a state. Added the ability to release a document from a working group, research group, or the independent stream. Releasing a document removes all stream state, and sets the document to have no stream. 
- Legacy-Id: 15809
 2018-12-11 22:38:05 +00:00
Henrik Levkowetz 8180716efa Added a couple of assertion to help understand test coverage percentage variations 
- Legacy-Id: 15751
 2018-11-11 12:19:29 +00:00
Henrik Levkowetz ef3cbf4684 Merged in [15595] from rjsparks@nostrum.com: 
Converted stats, submit, sync. and utils/test to use factories. Excluded utils/test_data from coverage checks.
 - Legacy-Id: 15599
Note: SVN reference [15595] has been migrated to Git commit 39e76a836996ec9ed8ea449c92bdfae91c3dbaae
 2018-10-19 12:54:58 +00:00
Henrik Levkowetz 232774a5cc Adjusted the test_submit_nonascii_name() to match the output from idnits 2.16.0, which emits warnings rather than errors for nonascii content. 
- Legacy-Id: 15525
 2018-10-07 14:18:00 +00:00
Henrik Levkowetz c14b02cfa4 Fixed a problem where an exception could be raised when reporting an exception during draft XML processing to the user. 
- Legacy-Id: 15491
 2018-09-27 13:36:25 +00:00
Henrik Levkowetz b2bfc7858a Generalized the log.assertion() function a bit to be able to provide more information on assertion failure. 
- Legacy-Id: 15426
 2018-08-10 15:31:12 +00:00
Henrik Levkowetz dab5b81ae2 Fixed display of xml2rfc exceptions when processing draft submission in xml form. 
- Legacy-Id: 15371
 2018-07-17 14:23:18 +00:00
Henrik Levkowetz e87442f33a Merged in [15282] from housley@vigilsec.com: 
Set reply-to for I-D Announcements that include a CC to a mail list.  Fixes #2530.
 - Legacy-Id: 15289
Note: SVN reference [15282] has been migrated to Git commit 733c304e3d
 2018-07-10 17:16:47 +00:00
Russ Housley 733c304e3d Set reply-to for I-D Announcements that include a CC to a mail list. Fixes #2530. 
- Legacy-Id: 15282
 2018-06-29 18:15:42 +00:00
Henrik Levkowetz 4db4dd16b0 Merged in ^/personal/henrik/6.79.1-gdpr@15180 containing GDPR-adaptations. 
- Legacy-Id: 15181
 2018-05-28 11:26:24 +00:00
Henrik Levkowetz b1440e818b Added assingment of the person.name_from_draft field on draft submission. To be used to replace the content of person.name if someone requires removal of consent-based name info. 
- Legacy-Id: 15178
 2018-05-26 08:40:58 +00:00
Henrik Levkowetz 6c3ec5b18e Added Email origin to Email record creation throughout the codebase. 
- Legacy-Id: 15149
 2018-05-17 16:56:26 +00:00
Henrik Levkowetz dda9c0136c Overwrite earlier email origin when we've picked up the address from a submission. 
- Legacy-Id: 15141
 2018-05-08 16:23:27 +00:00
Henrik Levkowetz f0c0753e28 Added email origin information to some function calls that needed it. 
- Legacy-Id: 15130
 2018-05-05 12:49:10 +00:00
Henrik Levkowetz 5f37a71889 Added origin information to all places where we create email address entries. 
- Legacy-Id: 15127
 2018-05-05 12:40:30 +00:00
Henrik Levkowetz d076a1728c Added a 'recent drafts' page, showing drafs submitted the last 7 days. 
- Legacy-Id: 15099
 2018-05-01 17:55:22 +00:00
Henrik Levkowetz fec59ad937 Fixed a PyQuery property access that should have been a method call. 
- Legacy-Id: 15087
 2018-04-26 11:51:39 +00:00
Henrik Levkowetz a9fbea113b Changed incorrect use of 404 status code in api to 400. Fixes issue #2498. 
- Legacy-Id: 15044
 2018-04-13 11:11:48 +00:00
Henrik Levkowetz 9bd18df83b Use .assertIn(...) in tests instead of .assertTrue(x in y) as the failure messages are much more informative 
- Legacy-Id: 15026
 2018-04-07 10:09:07 +00:00
Henrik Levkowetz 327ffb6559 Test data template tweak. 
- Legacy-Id: 14873
 2018-03-20 13:17:29 +00:00
Henrik Levkowetz 04495217bc Merged in [14863] from rjsparks@nostrum.com: 
Improved test coverage for ietf.utils.draft.
 - Legacy-Id: 14872
Note: SVN reference [14863] has been migrated to Git commit 1d021770a8
 2018-03-20 12:58:44 +00:00
Henrik Levkowetz b75ee89865 Added a test case for reference extraction. 
- Legacy-Id: 14869
 2018-03-20 11:04:12 +00:00
Robert Sparks 1d021770a8 Improved test coverage for ietf.utils.draft. Commit ready for merge. 
- Legacy-Id: 14863
 2018-03-18 18:52:43 +00:00
Henrik Levkowetz 6e5e50c78c Added an error message for missing email in extracted author information during automated draft submission. 
- Legacy-Id: 14743
 2018-03-07 16:42:57 +00:00
Henrik Levkowetz 5573dc00d0 Find person by email during draft submission also if email case doesn't match. 
- Legacy-Id: 14723
 2018-03-02 21:27:13 +00:00
Henrik Levkowetz 1ed8e967e7 Merged in ^/personal/henrik/6.72.1-django-1.11@14676: Upgrade to Django 1.11 
- Legacy-Id: 14695
 2018-02-25 19:55:16 +00:00
Henrik Levkowetz 00a97a47fe Changed an exception handling to not depend on exceptions having a .msg element 
- Legacy-Id: 14687
 2018-02-23 14:48:18 +00:00
Henrik Levkowetz 8a9dcfc856 Call the xml2rfc parser with normalize=True, in alignment with xml2rfc internal use. 
- Legacy-Id: 14686
 2018-02-23 13:46:28 +00:00
Henrik Levkowetz 26bf387356 Replaced direct assignment to m2m fields with .clear() and .set() 
- Legacy-Id: 14666
 2018-02-21 23:58:25 +00:00
Henrik Levkowetz a4768bb514 Removed unused imports. Added some explicit orderings to avoid pagination issues. 
- Legacy-Id: 14664
 2018-02-21 23:54:31 +00:00
Henrik Levkowetz 06362ec046 Got rid of old migrations and created new initial migrations. 
- Legacy-Id: 14662
 2018-02-21 23:46:22 +00:00
Henrik Levkowetz 5638cf3da3 Changed all usage of ForeignKey and OneToOneFiled in model.py files to the compatibility versions from ietf.utils.models. 
- Legacy-Id: 14661
 2018-02-20 15:36:05 +00:00
Henrik Levkowetz fcc22da623 Removed a chunk of code that won't be executed in all test environments from the test coverage measurements 
- Legacy-Id: 14550
 2018-01-23 17:29:41 +00:00
Henrik Levkowetz 4695ec5383 Restricted automatic IANA state change into 'Version Changed - Review Needed' on new draft revisions to events before document approval, based on conversation with Michelle. 
- Legacy-Id: 14486
 2018-01-04 12:31:05 +00:00
Henrik Levkowetz 8ff59cd41c Fixed some issues with a migration. The migration has been re-run on production. 
- Legacy-Id: 14484
 2017-12-31 15:37:18 +00:00
Henrik Levkowetz 29a0c8a47f Added a data migration to create yang catalog links for yang documents published before the yang catalog link feature was introduced in the datatracker. 
- Legacy-Id: 14447
 2017-12-19 15:08:33 +00:00
Henrik Levkowetz 47a0b9d3ce Changed handling of yang modeules from drafts with errors, to not place them in separate directories, due to possible follow-on effects. Added use of IANA-held modules when validating, and regular rsyncing from IANA. 
- Legacy-Id: 14389
 2017-12-04 14:37:15 +00:00
Henrik Levkowetz 98d234cd86 Refactored the handling of BallotDocEvent in tests, only creating them as needed, in preparation for stricter checks on state transitions to avoid mismatches between state and ballot. 
- Legacy-Id: 14380
 2017-11-30 16:02:31 +00:00
Henrik Levkowetz b6f0fbd52d Added new checker runs for all active drafts with yang modules to the yang link data migration, in order to make sure to have module information available. 
- Legacy-Id: 14277
 2017-11-02 14:49:51 +00:00
Henrik Levkowetz 370a0e3d94 Added a progress bar to the submission checker json field upgrade migration. 
- Legacy-Id: 14276
 2017-11-02 14:48:28 +00:00
Henrik Levkowetz 6edcd1b407 Capture messages from xym's get_extracted_models() 
- Legacy-Id: 14275
 2017-11-02 14:45:58 +00:00
Henrik Levkowetz a25ee4e50d Fixed an initialization error. 
- Legacy-Id: 14271
 2017-11-01 20:58:21 +00:00
Henrik Levkowetz 48a81862b8 Added a data migration to upgrade the submission checker json details to a consistent format. 
- Legacy-Id: 14269
 2017-11-01 14:45:25 +00:00
Henrik Levkowetz 1e98a58386 Added missing in-loop variable initializations in the yang checker code. Fixes issue #2397. 
- Legacy-Id: 14268
 2017-11-01 14:40:56 +00:00
Henrik Levkowetz 02ec2aa7e3 Included the path for draft moduled found invalid in the module paths when running yanglint, in order to avoid some unhelpful model not found messages. Fixes issue #2398. 
- Legacy-Id: 14266
 2017-11-01 14:00:24 +00:00
Henrik Levkowetz ec02ed5cdd Removed case sensitivity in the submission API when comparing the submitter email address with the email addresses found in the draft. Fixes issue #2396. 
- Legacy-Id: 14265
 2017-11-01 13:47:12 +00:00
Henrik Levkowetz 130261e781 Removed some debug statements. 
- Legacy-Id: 14242
 2017-10-30 12:28:51 +00:00
Henrik Levkowetz 7edb4da711 Added draft URLs pointing to Yang resources (impact analysis and model metadata) for submissions containing Yang modules. 
- Legacy-Id: 14237
 2017-10-30 11:30:01 +00:00
Henrik Levkowetz 54088de325 Changed the submission checkers to return more information in the checker details json blob; in particular added information about individual extracted code modules associated with a draft. This is used by the yang valididty checker to return a list of extracted yang modules. 
- Legacy-Id: 14236
 2017-10-30 11:28:19 +00:00
Henrik Levkowetz 8f2247ad1d Changed the SubmissionCheck.time field to use a default now value, instead of auto_now, to permit migrations without changing the timestamps. 
- Legacy-Id: 14235
 2017-10-30 11:25:40 +00:00
Henrik Levkowetz f795fa56b9 Changed the SubmissionCheck.time field to use a default now value, instead of auto_now, to permit migrations without changing the timestamps. 
- Legacy-Id: 14234
 2017-10-30 11:24:47 +00:00
Henrik Levkowetz 7c9364b61f Added some more debugging output for occasional author extraction failures during test. See also [14226]. 
- Legacy-Id: 14233
Note: SVN reference [14226] has been migrated to Git commit 215008211a
 2017-10-30 11:22:45 +00:00
Henrik Levkowetz 215008211a Added some debugging code to help identify random test failures 
- Legacy-Id: 14226
 2017-10-27 05:53:23 +00:00
Henrik Levkowetz ac69d9889d Added a guard against feeding int() a non-numeric string during submission confirmation and a log assertion to report same. 
- Legacy-Id: 14202
 2017-10-10 15:02:00 +00:00
Henrik Levkowetz 437a622141 Set a temporary state 'confirmed' when handling submission confirmations in order to avoid running the confirmation code multiple times on multiple form submits. 
- Legacy-Id: 14191
 2017-10-07 13:34:14 +00:00
Henrik Levkowetz 7b2d921a5a Tweaked the submission search form to accept draft names which include revision numbers. Fixes issue #2380. 
- Legacy-Id: 14171
 2017-09-27 15:08:40 +00:00
Henrik Levkowetz 2d817427fc Added a cancel button to the submission confirmation page. Fixes issue #2379. 
- Legacy-Id: 14170
 2017-09-27 14:18:12 +00:00
Henrik Levkowetz 328c6c6ab8 Added a submission state filter to the submission admin page. 
- Legacy-Id: 14169
 2017-09-27 14:15:31 +00:00
Henrik Levkowetz d0583f4f02 Removed the repeat of the error message in the HTTP reason string. Fixes issue #2378. 
- Legacy-Id: 14168
 2017-09-27 11:03:25 +00:00
Henrik Levkowetz 2c1438c240 Moved unidecode_name from utils.text to person.name. 
Modified UserFactory to use a new locale for each new user, instead of the
same locale for a whole test run.  This (almost) ensures the exercise of
code to deal with non-ascii names, something which would not happen if a
locale with ascii names was chosen at the start of a run.

Modified name.initials() to not use non-word characters as initials.

Modified unidecode_name() to do more normalization, to conform to the
conventions used in internet-drafts.

Added saving of the factory-boy random state in order to be able to re-run
a test suite with the same pseudo-random sequence as in a previous failed
run.

Fixed an issue with email formatting in test_api_submit_ok().

Modified the draft author extraction code to deal better with names with
embedded apostrophes.
 - Legacy-Id: 14141
 2017-09-20 15:36:30 +00:00
Henrik Levkowetz 33b275b04f Added ietf.utils.text.unidecode_name() and replaced various uses of unidecode() with it, in order to normalize the generation of ascii versions of names, to avoid different practices in space stripping and space normalization in different parts of the code. 
- Legacy-Id: 14128
 2017-09-17 15:12:18 +00:00
Henrik Levkowetz 6aa2cfca89 Updated tests to match the submission API info page. 
- Legacy-Id: 14127
 2017-09-17 14:02:52 +00:00
Henrik Levkowetz 8d3c540edd Added submit API instructions and fixed a bug in error handling for the submission validity checkers. 
- Legacy-Id: 14126
 2017-09-17 13:04:41 +00:00
Henrik Levkowetz 3af2554b2f Added an API for draft submission, at /api/submit. Added an urls.py file under api/ to hold api urls, and moved those from ietf/urls.py. Refactored out many parts of the regular submission forms and functions in submit/forms.py and submit/views.py in order to re-use the appropriate parts for the submission API. Moved support functions to submit/utils.py. Added a new validation errors for missing docName in xml-based submissions. Updated the submission test document templates to use insert additional values. Added failure and success test cases for automated API submissions, and refactored some test utility functions. 
- Legacy-Id: 14125
 2017-09-16 09:35:42 +00:00
Henrik Levkowetz 135d5d946b Tweaked the submission checker shell invocation code to deal with command lines starting with environment variable settings. 
- Legacy-Id: 14107
 2017-09-08 12:09:22 +00:00
Henrik Levkowetz a9b259ef26 Changed the message shown when xml file parsing fails during draft submission to include the actual error message from the xml parser. Fixes issue #2353. 
- Legacy-Id: 14102
 2017-09-06 17:41:29 +00:00
Henrik Levkowetz 95a5400dea Changed the handling of yang validation otput to capture errors messages also when command the exit code is zero. 
- Legacy-Id: 14100
 2017-09-03 14:40:02 +00:00
Henrik Levkowetz d481019803 Added reverse relationships from drafts to submissions to submission checks to the Json API, to make it easier to find the yang checks for a given document. 
- Legacy-Id: 13785
 2017-07-07 12:55:30 +00:00
Henrik Levkowetz 25e833444c Added a check for duplicate Yang model names after xym extraction. This prevents running pyang and yanglint on one module, moving it to the module libs, and then failing to run the checks on a second module with the same name, because the file has been moved after the first check. 
- Legacy-Id: 13770
 2017-07-03 21:24:19 +00:00
Henrik Levkowetz 08f0338555 Tweaked the wording of the unexpected-encoding warning. 
- Legacy-Id: 13760
 2017-07-03 11:38:03 +00:00
Henrik Levkowetz 274548f1b1 Check the whole draft submission text when checking mime type, and catch decoding errors and raise ValidationError when converting submission form txt file to unicode for Draft(). 
- Legacy-Id: 13759
 2017-07-02 21:32:44 +00:00
Henrik Levkowetz 7e1b09410c Upgraded xym to 0.4.2, with related changes in method calls. 
- Legacy-Id: 13741
 2017-06-30 15:59:40 +00:00
Henrik Levkowetz 60e9b7451c Included the temporary yang model extraction directory in the list of model librarires given to yanglint, in order to support drafts with models referencing models in the same draft. Fixes issue #2324. 
- Legacy-Id: 13736
 2017-06-29 21:03:26 +00:00
Henrik Levkowetz 3b7f320c29 Removed the copy of xym copied directly from repository -- the method call we use is too unstable at the moment. Now requiring xym=='0.4'. 
- Legacy-Id: 13723
 2017-06-28 11:53:09 +00:00
Henrik Levkowetz 13905a2a84 Modified the yang checker to work with both versions 0.3.x and 0.4.x of xym (different signatures for get_extracted_models()). 
- Legacy-Id: 13719
 2017-06-27 11:37:56 +00:00
Henrik Levkowetz 8eded1d8d2 Return a checker None result with exception message on xym exceptions. 
- Legacy-Id: 13707
 2017-06-22 15:08:01 +00:00
Henrik Levkowetz 70de94fc48 Variable naming tweak 
- Legacy-Id: 13701
 2017-06-21 13:12:19 +00:00
Henrik Levkowetz 768ca0b45e Catch bad module names in the Yang checker (they are not currently flagged by xym). 
- Legacy-Id: 13700
 2017-06-21 13:10:05 +00:00
Henrik Levkowetz 95f966c98b Changed the implementation of Submission.latest_checks() to also return None checks, so it's possible to update a Passed due to no yang modules to a None (no modules to check). 
- Legacy-Id: 13698
 2017-06-20 21:05:48 +00:00
Henrik Levkowetz 508bf15c6c Work around an issue in xml2rfc 
- Legacy-Id: 13682
 2017-06-19 19:02:42 +00:00
Henrik Levkowetz b42f1cbeb5 Replaced the use of unaccent.asciify(), which has similar functionality to unidecode.unidecode(). Changed the draft parser to work exclusively with unicode text, which both makes the removal of unaccent easier, and takes us closer to Py35 compatibility. Adjusted callers of the draft parser to send in unicode. 
- Legacy-Id: 13673
 2017-06-18 18:23:18 +00:00
Henrik Levkowetz 228a68348f Don't deliver spurious yang extraction errors for drafts where no yang modules were found. 
- Legacy-Id: 13668
 2017-06-17 20:54:52 +00:00
Henrik Levkowetz 98dc0d0092 Only run yanglint and yanglint tests if we have it configured. 
- Legacy-Id: 13636
 2017-06-15 22:13:43 +00:00
Henrik Levkowetz 4fc2c6f960 Merged in ^/personal/henrik/6.54.2-yang@13630: 
Added a new yang checker, 'yanglint', to the existing Yang checker class, in
addition to the existing 'pyang' checker.

Added modal overlay displays showing the yang check results every place the
yin/yang symbol is shown (red or green) to indicate the presencee and result
of yang checks.  Added a Yang Validation: line in the document
meta-information section on the document's page in the datatracker.

Added the result of the xym extaction to the yang check results, to make
extration failures visible.

Added the version of the used xym, pyang, and yanglint commands to the check
results.

Added an action to move successfully extracted and validated modules to the
module library directories immediately on submission.

Added the xym and pyang repositories as svn:external components, rather than
listing them in requirements.txt, as there has been delays of many months
between essential features in the repositories, and an actual release.  We may
get occasional buildbot failures if broken code is pulled in from the
repository, but better that than the functionality failure of severely
outdated componets.

Added a new management command to re-run yang validation for active drafts for
which yang modules were found at submission time, in order to pick up imported
models which may have arrived in the model libraries after the draft's
submission.  Run daily from bin/daily.

Added a table to hold version information for external commands.  The yang
checker output should include the version information of the used checkers,
but seems unnecessary to run each command with its --version switch every
time we check a module...

Added a new management command to collect version information for external
commands on demand.  To be run daily from bin/daily.

Added tests to verify that xym, pyang and yanglint information is available
on the submission confirmation page, and updated the yang module contained in
the test document to validate under both pyang and yanglint.

Updated admin.py and resource.py files as needed.
 - Legacy-Id: 13634
 2017-06-15 20:16:48 +00:00
Henrik Levkowetz 207ea51723 Added a test case for invalid yang in a draft submission. 
- Legacy-Id: 13633
 2017-06-15 19:22:36 +00:00
Henrik Levkowetz d98054c103 Added a new yang checker, 'yanglint', to the existing Yang checker class, in 
addition to the existing 'pyang' checker.

Added modal overlay displays showing the yang check results every place the
yin/yang symbol is shown (red or green) to indicate the presencee and result
of yang checks.  Added a Yang Validation: line in the document
meta-information section on the document's page in the datatracker.

Added the result of the xym extaction to the yang check results, to make
extration failures visible.

Added the version of the used xym, pyang, and yanglint commands to the check
results.

Added an action to move successfully extracted and validated modules to the
module library directories immediately on submission.

Added the xym and pyang repositories as svn:external components, rather than
listing them in requirements.txt, as there has been delays of many months
between essential features in the repositories, and an actual release.  We may
get occasional buildbot failures if broken code is pulled in from the
repository, but better that than the functionality failure of severely
outdated componets.

Added a new management command to re-run yang validation for active drafts for
which yang modules were found at submission time, in order to pick up imported
models which may have arrived in the model libraries after the draft's
submission.  Run daily from bin/daily.

Added a table to hold version information for external commands.  The yang
checker output should include the version information of the used checkers,
but seems unnecessary to run each command with its --version switch every
time we check a module...

Added a new management command to collect version information for external
commands on demand.  To be run daily from bin/daily.

Added tests to verify that xym, pyang and yanglint information is available
on the submission confirmation page, and updated the yang module contained in
the test document to validate under both pyang and yanglint.

Updated admin.py and resource.py files as needed.
 - Legacy-Id: 13630
 2017-06-15 16:09:28 +00:00
Henrik Levkowetz df2d0571c4 Narrowed a too wide try/except region in order to give more correct error messages. Changed the the strip() application to happen only on extracted author elements that actually have content. Fixes an inability to upload xml-only drafts with missing author country information. 
- Legacy-Id: 13574
 2017-06-09 20:12:44 +00:00
Henrik Levkowetz fb66f38afd Undid an unintentional adaptation to the xml2rfc 2.6.0 call interface change. 
- Legacy-Id: 13556
 2017-06-07 00:07:39 +00:00
Henrik Levkowetz a28940fc1e Name/email formatting tweaks, to complement [13536]. 
- Legacy-Id: 13540
Note: SVN reference [13536] has been migrated to Git commit 55d36e284d
 2017-06-06 08:11:31 +00:00
Henrik Levkowetz 55d36e284d Changed the '%s <%s>'%(name,email) idiom in several places to use email.utils.formataddr() instead, to avoid future problems with names that would need quotes. Added comments in 2 places where this change would not be appropriate. 
- Legacy-Id: 13536
 2017-06-05 22:40:11 +00:00
Henrik Levkowetz a92c2b4ad5 Updated migration numbering to avoid collisions. 
- Legacy-Id: 13480
 2017-05-31 21:36:08 +00:00
Henrik Levkowetz 76628be3fd Merged in ^/branch/iola/author-stats-r13145 from olau@iola.dk, and fixed some tests in code which moved after the latest merge with trunk. The test suite passes, but the migrations are _not_ ready to run, because of numbering conflicts (again due to code changes on trunk since the latest sync). 
- Legacy-Id: 13479
 2017-05-31 20:59:26 +00:00
Henrik Levkowetz 4afe0b8830 Added stripping of leading and trailing whitespace from submission data (including email addresses) gleaned from submitted xml. Changed email line parsing to use email.utils.parseaddr() instead of a regex which only would handle unwuoted names (and possibly not utf-8 names) correctly. 
- Legacy-Id: 13423
 2017-05-25 14:10:42 +00:00
Ole Laursen 5b677dc6ba Merge author stats branch into new branch from trunk 
- Legacy-Id: 13159
 2017-03-28 14:36:40 +00:00
Henrik Levkowetz 14c748df98 Changed the creation of temporary test dirs to use names which include the test class name, in order to make it possible to run test cases in parallel. Disabled coverage testing when running in parallel (those classes cannot be pickled and distributed to the test runner threads, and also won't pass coverage data back). Tweaked the TestCase.tempdir() method. 
- Legacy-Id: 13157
 2017-03-27 21:41:18 +00:00
Lars Eggert 8a70e9773d Fix various "RemovedInDjango20Warning" warnings. Commit ready for merge. 
- Legacy-Id: 13112
 2017-03-25 19:16:45 +00:00
Henrik Levkowetz 814e1315b5 Added a new document tab for some documents, showing htmlized drafts and RFCs 
using the htmlization code previously developed for tools.ietf.org.  As the
generation of the htmlized page is a bit too costly to do on the fly for
often-referenced drafts and RFCs, the part of each page which contains the
htmlized document is cached on file with a cache time of 2 weeks.

Changed all links which pointed to the htmlized version on tools to instead
point at the datatracker htmlized document.

Tweaked some URLs which didn't permit retrieval of intermediate-rev-charters.

Narrowed the pattern for document names to disallow dots in names, and
instead explicitly enumerated the few historical draftw with dots in the
name.

Added a file-system cache for the htmlized documents, and specified a
max_entries value for caches, overriding the default 300 entries.

Tweaked the code for new author email entries to provide a time if missing
in an updated entry.

Changed links in various email templates which pointed at tools.ietf.org
pages to instead point at datatracker pages, where appropriate.

Changed the search result rows to provide links to both the current meta-
information document pages (with a (i) info symbol) and to the new htmlized
document pages.
 - Legacy-Id: 13040
 2017-03-20 14:08:52 +00:00
Henrik Levkowetz bb5096da8a Added more email validation for draft submission author emails, and blocked some baths that could lead to bad email addresses ('none') being set as document author email addresses. 
- Legacy-Id: 13010
 2017-03-14 14:07:21 +00:00
Henrik Levkowetz 4daf66d11c Added DocEvent rev= parameter througout the code. 
- Legacy-Id: 12978
 2017-03-06 15:08:21 +00:00
Henrik Levkowetz 5bb5ca727b Created a special function log.unreachable() to mark code unreachable, and changed a function name from log.affirm() to log.assertion(). 
- Legacy-Id: 12933
 2017-02-28 20:16:52 +00:00
Henrik Levkowetz ffa19c9847 Added a log.affirm() call at the point where we may discover new flawed document author records. Fixed a place where the generation of Person.ascii from Person.name wasn't done well. 
- Legacy-Id: 12903
 2017-02-23 11:57:29 +00:00
Henrik Levkowetz a5290e143a Made some changes to the missing-email submission handling. This may have fixed the creation of author records containing 'none' email entries, but as I've not been able to reproduce the issue, this is uncertain. Next is to build an email notification assert statement to help capture information if this happens. 
- Legacy-Id: 12898
 2017-02-22 15:36:28 +00:00
Henrik Levkowetz 27351c4349 Fixed url lookups for doc.views_doc.document_main() to only use dotted-path, and removed the doc_view explicit url name. Fixes a 500 error in /submit/status/NNNN/. 
- Legacy-Id: 12897
 2017-02-22 11:40:55 +00:00
Henrik Levkowetz 8930d29a8e Merged in Django-1.10 upgrade work from ^/personal/henrik/6.43.1-django-1.10 
- Legacy-Id: 12881
 2017-02-19 18:18:00 +00:00
Henrik Levkowetz cf4a4b02a7 Reworked the email address handling in order to be able to support non-ascii names as part of email address fields. Reworked the generation of user names in the test suite to generate names from multiple non-ascii locales. Fixes issue #2080. 
- Legacy-Id: 12872
 2017-02-18 21:50:18 +00:00
Ole Laursen 9d8874d8b1 Add a suggestion to fix the country name when submitting a draft in 
case we can't parse it and it's not empty, add page with list of
countries (to be able to refer people to it), add ISO codes as country
aliases - the country alias code is now more intelligent with respect
to case so it's easier to keep these aliases explicitly
 - Legacy-Id: 12862
 2017-02-16 17:56:23 +00:00
Ole Laursen b2ff10b0f2 Add support for extracting the country line from the author addresses 
to the draft parser (incorporating patch from trunk), store the
extracted country instead of trying to turn it into an ISO country
code, add country and continent name models and add initial data for
those, add helper function for cleaning the countries, add author
country and continent charts, move the affiliation models to
stats/models.py, fix a bunch of bugs.
 - Legacy-Id: 12846
 2017-02-15 18:43:57 +00:00
Henrik Levkowetz f6a1fcdaf8 Added more information about submission errors and a full idnits run to the manual post email sent to the secretariat. 
- Legacy-Id: 12831
 2017-02-13 20:37:47 +00:00
Henrik Levkowetz aa5e61d958 Updated all urlpatterns to use ietf.utils.urls.url() instead of django's, 
in order to autogenerate dotted path url pattern names.  Updated a number
of url reverses to use dotted path, and removed explicit url pattern names
as needed.

Changed some imports to prevent import of ietf.urls before django
initialization was complete.


Changed 3 cases of form classes being curried to functions; django 1.10
didn't accept that.

Started converting old-style middleware classes to new-style middleware
functions (incomplete).

Tweaked a nomcom decorator to preserve function names and attributes, like
a good decorator should.

Replaced the removed django templatetag 'removetags' with our own version
which uses bleach, and does sanitizing in addition to removing explicitly
mentionied html tags.

Rewrote the filename argument handling in a management command which had
broken with the upgrade.
 - Legacy-Id: 12818
 2017-02-11 14:43:01 +00:00
Ole Laursen 8fdb0047e1 Add migration for converting existing Submission.authors to JSON 
- Legacy-Id: 12746
 2017-01-27 16:12:10 +00:00
Ole Laursen 90051a1575 Add support for displaying and editing author affiliation and country 
when submitting a draft, replace the Submission.authors line-based
text field with a JSON field
 - Legacy-Id: 12745
 2017-01-27 16:10:31 +00:00
Ole Laursen 9308948195 Add person, affiliation and country (through django-countries) to 
DocumentAuthor, rename author field to email and make it optional (for
modeling old email-less submissions), remove the authors many to many
referencing field from Document as it is not really pointing the right
place.

Update the Secretariat tools to show affiliation and country.

Add migration for getting rid of the fake email addresses that the
migration script created some years ago (just set the author email
field to null).
 - Legacy-Id: 12739
 2017-01-26 17:10:08 +00:00
Henrik Levkowetz 6de7be6953 Specified strip=False for another bunch of CharField form fields with Textarea widgets. 
- Legacy-Id: 12711
 2017-01-23 17:38:56 +00:00
Ole Laursen 76bcab6efc Show formal languages used on new submissions and make the field 
editable, also add it to the test with a simple JSON example
 - Legacy-Id: 12662
 2017-01-17 13:52:16 +00:00
Ole Laursen 1850a26b23 Add words and formal languages to Submission, set them in the submit 
view, clean up submit view a bit to avoid duplicated attribute setting
code
 - Legacy-Id: 12660
 2017-01-16 17:37:23 +00:00
Henrik Levkowetz 6eec4c2648 Converted all management commands which set up additional command-line switches to use the argparse approach instead of the deprecated optparse approach. 
- Legacy-Id: 12645
 2017-01-11 18:42:38 +00:00
Henrik Levkowetz c2541ec04b Django 1.9: Removed deprecated use of django.conf.urls.patterns() from all urls*.py files. 
- Legacy-Id: 12618
 2016-12-22 17:21:57 +00:00
Henrik Levkowetz 19ec458668 Added migrations for the model changes done for the Django 1.8 upgrade. 
- Legacy-Id: 12478
 2016-12-07 19:41:48 +00:00
Henrik Levkowetz 14776bae70 Merged django18 work forward to r12447 
- Legacy-Id: 12455
 2016-12-05 15:03:40 +00:00
Henrik Levkowetz 0bb7854591 Merged django18 work forward to 6.39 
- Legacy-Id: 12449
 2016-12-05 14:01:25 +00:00
Henrik Levkowetz 9c9b15bec8 Added guards against picking up non-ascii title and abstract from drafts submitted in xml form. 
- Legacy-Id: 12429
 2016-11-30 15:56:22 +00:00
Henrik Levkowetz b914f46313 Merged in ^/branch/iola/review-tracker-r12128@12397, bringing in the review tool functionality described in RFC7735. This adds the ability to set up review management pages for review teams such as genart, secdir, opsdir, etc.; letting the review team secretaries manage requested and completed reviews; letting the reviewers keep track of and document their reviews, and more. See the RFC for full specification, and the branch commit log for a full commit history. 
- Legacy-Id: 12419
 2016-11-29 14:54:19 +00:00
Henrik Levkowetz 7f1c1e43f2 Replaced the use of plain DocEvent for submission doc events with a SubmissionDocEvent that carries rev and a FK to submission. 
- Legacy-Id: 12275
 2016-11-07 18:21:34 +00:00
Henrik Levkowetz 87e1339924 Fixed all the warnings emitted by the check command; mostly use of null=True on ManyToManyFields, which doesn't make sense. 
- Legacy-Id: 12256
 2016-11-03 20:13:44 +00:00
Henrik Levkowetz ca570ae355 Reverted an inadvertent commit of all changes. 
- Legacy-Id: 12253
 2016-11-03 20:10:09 +00:00
Henrik Levkowetz 276c9c1030 Removed use of the fix_ampersands() function. 
- Legacy-Id: 12252
 2016-11-03 20:08:44 +00:00
Ole Laursen e864abdcdb Fix some pyquery compatibility issues 
- Legacy-Id: 12145
 2016-10-14 09:40:12 +00:00
Henrik Levkowetz e06ac44060 Added a migration to remove most duplicate 'Upload' doc events. 
- Legacy-Id: 12098
 2016-10-06 18:40:04 +00:00
Henrik Levkowetz 8a5593e714 When converting submission events to doc events, post them in chronological order. Don't add upload doc events until we're past the possibility of submission cancellation. 
- Legacy-Id: 12097
 2016-10-06 17:03:23 +00:00
Henrik Levkowetz 88a9c30600 Added a data migration to fix up incorrect submission doc events. 
- Legacy-Id: 12073
 2016-10-02 16:04:26 +00:00
Henrik Levkowetz 72cfe4cf68 Removed the creation of duplicate new revision doc events. Corrected the timestamp on approval docevents. Changed where the submission upload docevent is created, to avoid spurious events for cancelled uploads. Adjusted the person associated with some events from submitter to (System). Added tests for the sequence of events associated with a submission. 
- Legacy-Id: 12072
 2016-10-01 21:16:04 +00:00
Henrik Levkowetz a9f879cd0e Tweaked admin models. 
- Legacy-Id: 12071
 2016-10-01 13:36:31 +00:00
Henrik Levkowetz ff5866367b Tweaked the nonascii draft test template. 
- Legacy-Id: 12067
 2016-09-30 20:31:24 +00:00
Henrik Levkowetz 68655b569b Fixed 2 testing bugs. Added tests for handling of submitters without email and drafts with non-ascii names in the author section. 
- Legacy-Id: 12064
 2016-09-30 17:35:35 +00:00
Henrik Levkowetz da2c25182f Code changes to handle draft submission authors without email addresses better. 
- Legacy-Id: 12063
 2016-09-30 10:48:46 +00:00
Henrik Levkowetz 613363cccc Try various ways of handling non-ascii names/emails in draft submissions, in order to get past the early processing to the point where we run idnits and can flag non-ascii content, instead of failing with a server 500 error. 
- Legacy-Id: 12053
 2016-09-27 20:27:05 +00:00
Henrik Levkowetz 0378f4a2f6 Merged in [12014] from rjsparks@nostrum.com: 
Improves who to copy when sending submission confirmation mail when authors change.
 - Legacy-Id: 12044
Note: SVN reference [12014] has been migrated to Git commit 4f01de1b94
 2016-09-26 18:47:23 +00:00
Henrik Levkowetz 7f772641d4 Change the cache key construction to deal with query arguments containing spaces. Fixes 500 errors which would otherwise occur. 
- Legacy-Id: 12035
 2016-09-25 13:53:22 +00:00
Robert Sparks 4f01de1b94 Improves who to copy when sending submission confirmation mail when authors change. Commit ready for merge. 
- Legacy-Id: 12014
 2016-09-21 15:55:17 +00:00
Henrik Levkowetz 586eec7f2b Made a reverse migration more robust. 
- Legacy-Id: 11974
 2016-09-11 11:59:05 +00:00
Henrik Levkowetz 9cb627f1cc Made some migrations work backwards, too. 
- Legacy-Id: 11964
 2016-09-10 20:06:15 +00:00
Henrik Levkowetz 22b2953b18 Merged in ^/branch/scow/track-manual-id-posts-6.31.1.dev0, which provides secretariat support for managing draft submissions outside of the automated datatracker draft submission tool. In addition to making the secreatiat handling of draft submissions that come in by email or other paths easier, it also improves the datatracker submission and document history for these documents. 
- Legacy-Id: 11959
 2016-09-09 17:00:23 +00:00
Henrik Levkowetz c1ce79f14d Style tweak 
- Legacy-Id: 11945
 2016-09-08 18:30:03 +00:00
Henrik Levkowetz 254c3db807 Style changes. 
- Legacy-Id: 11944
 2016-09-08 17:37:36 +00:00
Henrik Levkowetz 47d6bbbea3 Renamed the SubmissionEmail event class to SubmissionEmailEvent, and added an admin class for it. 
- Legacy-Id: 11942
 2016-09-08 15:04:53 +00:00
Henrik Levkowetz ec684e1b4e Added a pylint rc-file, and fixed or silenced a number of issues found by pylint using the settings .pylintrc (which enable only error checking). 
- Legacy-Id: 11941
 2016-09-08 14:48:59 +00:00
Henrik Levkowetz a531b7cbc0 Removed BOM 
- Legacy-Id: 11919
 2016-09-02 09:27:44 +00:00
Henrik Levkowetz be6065e6a5 Manual post naming and string tweaks 
- Legacy-Id: 11918
 2016-09-01 12:04:43 +00:00
Henrik Levkowetz 7a8c067d83 Changed a state name, and renamed some view functions for easier code reading. Removed extra name= parameters from the submit/ urlpatterns. 
- Legacy-Id: 11917
 2016-09-01 09:14:34 +00:00
Henrik Levkowetz e2fccfb094 Merged in ^/branch/scow/track-manual-id-posts-6.31.1.dev0@11899, which provides better support for manual ID posting. 
- Legacy-Id: 11914
 2016-08-31 22:30:31 +00:00
Mike Douglass fa3a34389e Merge forward to 6.31.1.dev0 
- Legacy-Id: 11899
 2016-08-31 03:00:10 +00:00
Robert Sparks b988b86b1a Copy group chairs on confirmation email when a new group document revision is submitted that changes the author set. Fixes #1998. Commit ready for merge. 
- Legacy-Id: 11877
 2016-08-25 15:52:51 +00:00
Robert Sparks 2009afe7b8 preparing to merge forward to 6.31 
- Legacy-Id: 11875
 2016-08-25 15:21:57 +00:00
Henrik Levkowetz 4b0a9360f0 Merged in ^/branch/iola/event-saving-refactor-r10291, which refactors document saving to always use doc.save_with_history(events), and requires accompanying events. This branch also provides refactoring of recurring regexes in url patterns into a dictionary. As part of the merge, also refactored new code which didn't use the save_with_history() method. 
- Legacy-Id: 11840
 2016-08-23 10:52:08 +00:00
Henrik Levkowetz 7f5863d212 Added a FIXME comment about a test which can fail if run across the midnight date shift. 
- Legacy-Id: 11544
 2016-07-07 12:40:41 +00:00
Henrik Levkowetz 5395c85ed7 Changed the acceptable mime type for uploaded xml files to be either text/xml or application/xml. 
- Legacy-Id: 11280
 2016-06-06 07:38:02 +00:00
Henrik Levkowetz 3eaef15fd5 Fixed a bug found by rjsparks@nostrum.com in the submission test text output. 
- Legacy-Id: 11279
 2016-06-06 07:37:05 +00:00
Henrik Levkowetz 72ba673bd8 Removed debug code. 
- Legacy-Id: 11221
 2016-05-22 15:47:05 +00:00
Henrik Levkowetz a32b121efb Changed some instances of error strings from ascii to unicode in order to avoid problems with unicode error messages, such as the file size indications generated by django.template.defaultfilters.filesizeformat(). 
- Legacy-Id: 11220
 2016-05-22 14:40:37 +00:00
Henrik Levkowetz deb2f73047 Merged in ^/branch/iola/community-list-cleanup-r11172@11175. 
- Legacy-Id: 11182
 2016-05-12 19:14:28 +00:00
Henrik Levkowetz aa61123937 Modified a few tests to handle the improved handling of error messages (not conflating them with help text any more). 
- Legacy-Id: 11181
 2016-05-12 13:47:10 +00:00
Ole Laursen 9faae5e915 Merged community list branch with trunk 
- Legacy-Id: 11174
 2016-05-06 17:36:04 +00:00
Henrik Levkowetz 8769cc0207 Fixed bugs in the previous commit (in the tests). 
- Legacy-Id: 11142
 2016-05-03 17:16:17 +00:00
Henrik Levkowetz 304516f4b3 Added test directories for yang model tests. 
- Legacy-Id: 11141
 2016-05-03 16:40:09 +00:00
Henrik Levkowetz d96f0fe964 Added a django management command to populate yang model libraries from RFCs and drafts. 
- Legacy-Id: 11110
 2016-04-08 17:18:54 +00:00
Henrik Levkowetz 97658ee40b Fixed incomplete edit. 
- Legacy-Id: 11027
 2016-03-29 20:45:25 +00:00
Henrik Levkowetz db3a3c3081 Added (belatedly) progress bars to some long-running migrations. 
- Legacy-Id: 11025
 2016-03-29 19:57:24 +00:00
Henrik Levkowetz 6b7faf3926 Added migrations for the submit check display work. 
- Legacy-Id: 10998
 2016-03-28 19:32:49 +00:00
Henrik Levkowetz 4b0b7e0c58 Merged in henrik/6.16.1-pyang-work@10995: 
Added in support for displaying results from selected submission checks as symbols on draft pages and in draft lists.  For now, that means that drafts with yang modules will show either a green or orange yang symbol, depending on the result of the submission yang validation check.
 - Legacy-Id: 10996
 2016-03-28 19:23:10 +00:00
Henrik Levkowetz 3012a8ceb6 Submission check symbols should only be shown when the check returned a result, not otherwise. 
- Legacy-Id: 10995
 2016-03-28 19:08:02 +00:00
Henrik Levkowetz be2a2285bc Added small orange or green yang symbols to draft info- and list-pages, signifying fail or pass for the submission yang validation. 
- Legacy-Id: 10994
 2016-03-28 18:47:53 +00:00
Ole Laursen c061caaf04 Merge in changes from community-list-cleanup 
- Legacy-Id: 10968
 2016-03-23 13:31:24 +00:00
Henrik Levkowetz 7b65e2624f Added another guard against varying pyang output format. 
- Legacy-Id: 10966
 2016-03-22 20:58:08 +00:00
Ole Laursen c7589f9b6a Integrate community lists for groups with the existing group documents 
page. Each WG/RG now gets a list with an initial set of rules to
populate the list.

Refine the community list management interface a bit to support the
group lists better - group lists aren't connected to the usual track
icons so need to be able to add/remove individual drafts.

Change the "name contains" rule to support regular expressions to
enable each group to have a default replacement for the previously
implemented "related documents" search. Maintain a materialized view
of the regexp-matched drafts with a call in the submit code to avoid
having to scan all drafts/~1000 group rules all the time.
 - Legacy-Id: 10963
 2016-03-22 12:48:44 +00:00
Henrik Levkowetz f52e21fb17 Put a guard in the yang validator against trying to read a draft which is absent from the staging area. 
- Legacy-Id: 10958
 2016-03-21 11:42:06 +00:00
Henrik Levkowetz e0d1c0b313 Fixed a possible index error in the yang validator checker plugin. 
- Legacy-Id: 10952
 2016-03-17 13:22:16 +00:00
Henrik Levkowetz 7832427f8f Fixed a typo. 
- Legacy-Id: 10930
 2016-03-15 23:12:46 +00:00
Henrik Levkowetz adb8625635 Introduced caching for the api resources. 
- Legacy-Id: 10929
 2016-03-15 23:12:04 +00:00
Henrik Levkowetz 8c68bc63fa Removed obsolete Submission.idnits_message field. 
- Legacy-Id: 10928
 2016-03-15 23:10:56 +00:00
Henrik Levkowetz 781a552e07 Added an admin model class for SubmissionEvent. 
- Legacy-Id: 10926
 2016-03-15 23:07:04 +00:00
Henrik Levkowetz 62574cd3f8 Fixed a pyflakes issue. 
- Legacy-Id: 10925
 2016-03-15 17:45:22 +00:00
Henrik Levkowetz 78d8e2e44c Removed unused idnits_message field on Submission model. 
- Legacy-Id: 10911
 2016-03-06 17:46:55 +00:00
Henrik Levkowetz 8c07e98052 Removed an unused import 
- Legacy-Id: 10902
 2016-03-05 14:51:07 +00:00
Henrik Levkowetz 7dec6c308d Removed resource file entry left over from refactored code. Adjusted resource class filtering fields 
- Legacy-Id: 10899
 2016-03-05 13:56:11 +00:00
Henrik Levkowetz 846a02c3f9 Fixed pyflakes complaints introduced with pyflakes 1.1.0 
- Legacy-Id: 10896
 2016-03-04 21:24:26 +00:00
Henrik Levkowetz 76bb233b70 Refactored draft submission checks so that new checkers can be slotted in through a configuration in settings.py. Refactored the calling of idnits to use the new API, and added a pyang validation check. 
- Legacy-Id: 10894
 2016-03-04 20:08:29 +00:00
Henrik Levkowetz b00b0c3db9 Moved some production-path checks to the checks module, and fixed up tests which changed some settings without restoring them. 
- Legacy-Id: 10808
 2016-02-09 18:50:37 +00:00
Henrik Levkowetz 33b1cc312e Merged in [10780] from rjsparks@nostrum.com: 
Stop making active unknown-email- objects. Mark existing such objects as inactive. Tweak exception handling in submit/utils to make it obvious that the utilities will not change the person an existing Email record is pointing to.
 - Legacy-Id: 10787
Note: SVN reference [10780] has been migrated to Git commit c8c45e2213
 2016-02-06 19:44:14 +00:00
Robert Sparks c8c45e2213 Stop making active unknown-email- objects. Mark existing such objects as inactive. Tweak exception handling in submit/utils to make it obvious that the utilities will not change the person an existing Email record is pointing to. Commit ready for merge. 
- Legacy-Id: 10780
 2016-02-04 22:50:50 +00:00
Henrik Levkowetz 289d9ebef6 Moved some path checks from SubmissionUploadForm to the ietf/checks.py. 
- Legacy-Id: 10753
 2016-01-28 16:09:44 +00:00
Henrik Levkowetz 8e399de009 Don't fail submission confirmation if the login used is missing an associated person record. 
- Legacy-Id: 10751
 2016-01-27 13:40:23 +00:00
Robert Sparks cb778b9660 Exclude concluded bofs from the set of groups for which a person can pre-approve drafts. Restore AD access to preapproval. (Need to consider adding delegate and group secretary access). Fixes #1896. Commit ready for merge 
- Legacy-Id: 10734
 2016-01-26 19:42:57 +00:00
Ole Laursen 1c3ec64e03 Eliminate odd group_id assignment in submission code, probably left 
over from a previous generation of the code. It causes trouble with a
revamped community rule engine.
 - Legacy-Id: 10730
 2016-01-25 18:26:33 +00:00
Robert Sparks dc5ae398f2 Improved SearchablePersonField to show the primary email address for any search results where a name appears more than once. 
Simplified the edit nominee form.
Replaced the merge nominee form with a request to the secretariat to merge Person records. Fixes #1847.
Added merging nominees to the secretariat's person merging script.
Restructured the person merging script to make it testable.
Updated some tests to match changes to the mailtriggers that hadn't made it to the fixtures.
 - Legacy-Id: 10625
 2015-12-22 21:42:55 +00:00
Henrik Levkowetz 408d51c11f Merged in [10425] from bartosz.balazinski@interdigital.com: 
Provide information about who has suggested document replaced-by information in the notification email.

    This commit fixes bug 1817,
 - Legacy-Id: 10440
Note: SVN reference [10425] has been migrated to Git commit ba39077180
 2015-11-07 21:43:27 +00:00
Bartosz Balazinski ba39077180 This commit fixes bug 1817, commit ready to merge 
- Legacy-Id: 10425
 2015-11-04 23:25:51 +00:00
Henrik Levkowetz cf7d794b09 Modified the test data to use some AD and WG chair names that contain non-ascii characters, and fixed test issues found. 
- Legacy-Id: 10418
 2015-11-04 07:34:56 +00:00
Ole Laursen 86c3a430d1 Merge in ^/branch/iola/event-saving-refactor-r10076, fixing a few problems 
- Legacy-Id: 10298
 2015-10-27 10:37:06 +00:00
Henrik Levkowetz 7accc69144 Updated a couple of tests. 
- Legacy-Id: 10273
 2015-10-23 17:12:46 +00:00
Robert Sparks f0f5a51eb6 (Rocky) merge forward. 
- Legacy-Id: 10157
 2015-10-09 03:16:24 +00:00
Henrik Levkowetz ce18fa8f69 Merged in [10144] from rcross@amsl.com: 
Make email address formatting consistent.
 - Legacy-Id: 10145
Note: SVN reference [10144] has been migrated to Git commit 3c0908ef28
 2015-10-08 15:38:35 +00:00
Ryan Cross 3c0908ef28 Make email address formatting consistent. Commit ready for merge. 
- Legacy-Id: 10144
 2015-10-07 21:55:23 +00:00
Henrik Levkowetz 35f4aeafd8 Tweaked the error message for 2 submission form validation errors. 
- Legacy-Id: 10128
 2015-10-02 14:58:03 +00:00
Ole Laursen e1f0917659 Summary: Add new document saving API, Document.save_with_history(events). 
The new API requires at least one event and will automatically save a
snapshot of the document and related state. Document.save() will now
throw an exception if called directly, as the new API is intended to
ensure that documents are saved with both an appropriate snapsnot and
relevant history log, both of which are easily defeated by just
calling .save() directly.

To simplify things, the snapshot is generated after the changes to a
document have been made (in anticipation of coming changes), instead
of before as was usual.

While revising the existing code to work with this API, a couple of
missing events was discovered:

- In draft expiry, a "Document has expired" event was only generated
  in case an IESG process had started on the document - now it's
  always generated, as the document changes its state in any case

- Synchronization updates like title and abstract amendmends from the
  RFC Editor were silently (except for RFC publication) applied and
  not accompanied by a descriptive event - they now are

- do_replace in the Secretariat tools now adds an event

- Proceedings post_process in the Secretariat tools now adds an event

- do_withdraw in the Secretariat tools now adds an event

A migration is needed for snapshotting all documents, takes a while to
run. It turns out that a single document had a bad foreign key so the
migration fixes that too.
 - Legacy-Id: 10101
 2015-09-28 14:01:03 +00:00
Robert Sparks f5b6465e81 mailtoken becomes mailtrigger 
- Legacy-Id: 10090
 2015-09-17 20:03:45 +00:00
Henrik Levkowetz 58e116cc0a Made some submission form validation errors apply to all uploads, not only to .txt uploads. Tweaked som validation error wordings. 
- Legacy-Id: 10076
 2015-09-10 08:39:56 +00:00