Commit graph

11599 commits

Author SHA1 Message Date
Jennifer Richards 611d732869
test: fix a couple tz problems in tests run soon after midnight UTC (#4757)
* test: fix tz problem in test_document_ballot() test

* test: fix tz problem in IprTests.test_notify() test

Co-authored-by: Robert Sparks <rjsparks@nostrum.com>
2022-11-15 07:46:42 -06:00
Robert Sparks 2c304d0364
feat: UI enhancements to allow control-click etc on the search results (provided by @kivinen - see #4747)
Fixes #4711 i.e., allows using control-click or context menu to open items in the top right search list to open multiple documents in different tabs.

Authored by @kivinen
2022-11-14 17:08:28 -06:00
Jennifer Richards 5e7debb8db
fix: supply tzinfo to datetime in iana-protocols-updates script (#4753) 2022-11-14 14:51:24 -06:00
Robert Sparks cdfe7ea4cf
feat!: Timezone aware database 2022-11-14 08:02:44 -06:00
Jennifer Richards eb41424ea4
test: permit multiple <h1> tags in a document (#4741) 2022-11-10 16:17:43 +00:00
Jennifer Richards e77419029a
test: validate HTML in own test case and report all results (#4740)
* ci: move HTML validation out of teardown so all failures are caught

Failures in the last batch were suppressed by the original implementation.

* test: rename template validation "test" so it is not auto-discovered

* test: run all HTML validation in a single batch at the end

Adds ~50 MB peak RAM usage during a full test run.

* test: refactor validation to collect failures of all kinds before exit
2022-11-10 16:17:00 +00:00
Jennifer Richards 131cdf9943
fix: drop duplicate alias/email Person records from profile view (#4734)
* fix: drop duplicate alias/email Person records from profile view

* test: test de-duplication of Person records
2022-11-08 17:48:17 +00:00
Russ Housley 612f33e014
fix: Don't send I-D expiration warning if it will happen within 12 hours. (#4700)
* fix: 4635

* fix: use timezone.now rather than datetime.datetime.now

* chore: fix merge error

Co-authored-by: Robert Sparks <rjsparks@nostrum.com>
2022-11-08 16:06:42 +00:00
Jennifer Richards d7e3bddeb4
feat: include command name in output when purging api key events (#4724) 2022-11-08 15:54:00 +00:00
Nicolas Giard 100a0534cb
fix: agenda mobile dropdown links + footer padding + tz start/end date 2022-11-08 15:53:08 +00:00
Jennifer Richards 5a55ec0959
test: fix date-related timezone errors in tests (#4717)
* test: compare UTC dates in test_search_mail_archive()

* test: compare datetimes, not dates, in action holders test

* test: adjust test to match TZ used for IPR notification message

* test: fix timezone in date_today() calls for liaisons tests

* test: use settings.TIME_ZONE for date in nomination tests

* test: correctly use settings.TIME_ZONE instead of system time zone
2022-11-07 09:54:35 +00:00
Robert Sparks eb4b523e66
chore: merge main (#4714) 2022-11-06 12:36:14 -06:00
Lars Eggert d16a9e77a7
fix: Fix transient test failures due to i18n names (#4695)
* Search for escaped name in HTML output

* Need to check for `plain_name()` in sent emails

* Normalize i18n Unicode names in the same way the database does
2022-11-06 12:29:49 +00:00
Jennifer Richards 331bf8d2dc
fix: revert change from readonly to disabled on liaison from contact (#4708)
* feat: apply 'readonly' property to select2 inputs

* fix: revert change from readonly to disabled on liaison from contact
2022-11-06 12:27:36 +00:00
Kesara Rathnayake 71dcf9fc8b
fix: Use correct codec for decoding meeting materials (#4697) 2022-11-06 12:13:02 +00:00
Justin Iurman c94c28d65c
chore: Eliminate use of django.utils.datetime_safe (#4698)
Instead of replacing `datetime_safe` by the standard api, just remove
that part of the code (because it is unused).

Fixes #4513
2022-11-06 11:54:19 +00:00
Jennifer Richards 594c3f4316
fix: omit session location when timeslot.show_location is False (#4712)
* fix: omit session location when timeslot.show_location is False

* test: test that location is omitted  when show_location is False
2022-11-06 11:51:07 +00:00
Tero Kivinen 8cf309cd6a
fix: Fix upcoming to use Meeting.end_date. (#4701) 2022-11-05 17:54:13 +00:00
Kesara Rathnayake 91170430ff
fix: Check both Person and Email records in profile view (#4703) 2022-11-05 17:48:31 +00:00
Peter Yee eee6d0180c
Fix: #4320 (htmlized version of RFC has bad errata link) (#4699)
* Remove &rec_status=0 from "Errata exist" links for HTMLized RFCs

Corrects Issue #4320:

https://github.com/ietf-tools/datatracker/issues/4320

This is done by modifying the RFC_EDITOR_ERRATA_URL in ietf/settings.py
so that the errant "&rfc_status=0" is removed.

* Update ietf/settings.py

Removes commented out RFC_EDITOR_ERRATA_URL line from original submission.

Co-authored-by: Lars Eggert <lars@eggert.org>

Co-authored-by: Lars Eggert <lars@eggert.org>
2022-11-05 17:42:50 +00:00
Lars Eggert b6b48ec8f9
fix: Only allow a single newline in when URLizing RFC tags (#4710)
Fixes #4705
2022-11-05 17:22:56 +00:00
Robert Sparks fbd9509db7
chore: silence interleaved migration warning (#4687) 2022-11-02 14:33:09 -03:00
Jennifer Richards 91635de968
test: fix tests broken in recent commits (#4685)
* chore: remove unused import in timezone.py

* test: fix test_view_request, broken by recent work
2022-11-01 16:30:42 -03:00
Jennifer Richards 3008c4904e
feat: add 'cancel session' button to meeting schedule editor (#4682)
* feat: add 'cancel session' button to meeting schedule editor

* fix: only show edit/cancel session buttons for secretariat

Other users cannot access these views.

* feat: refuse to cancel a canceled session; give feedback to user

* test: test cancel_session view

* test: test that sessions have edit/cancel buttons
2022-11-01 14:41:50 -03:00
Jennifer Richards 1841d15104
feat: allow secretariat to edit/cancel sreqs when the tool is locked (#4676)
* feat: allow secretariat to edit/cancel sreqs when the tool is locked

* chore: remove unused template var
2022-10-28 18:19:38 -03:00
Jennifer Richards 9752fabf85
test: fix timezone_not_near_midnight not to use pytz (#4678) 2022-10-28 18:19:08 -03:00
Jennifer Richards 41882f2ac7
test: remove syntax error introduced in merge 2022-10-28 16:52:03 -03:00
Jennifer Richards 0caf946e48
Merge branch 'feat/tzaware' into dev/main-for-tzaware-merge 2022-10-28 14:40:04 -03:00
Jennifer Richards a124eb8073
chore: update create_dummy_meeting to specify session purposes (#4654) 2022-10-28 14:36:35 -03:00
Jennifer Richards 3bf997ba03
chore: rename management commands to avoid non-inclusive language (#4656)
* chore: rename create_dummy_meeting to create_test_meeting

* chore: reword comments to match renamed command

* chore: rename make_dummy_nomcom to create_test_nomcom

Avoids non-inclusive language and better matches other command naming.

* chore: reword comments to match renamed command
2022-10-28 11:01:00 -05:00
Robert Sparks de3dbdca04
fix(nomcom-ui): Use pre instead of relying on now-missing pasted styling (#4658) 2022-10-28 10:58:38 -05:00
Robert Sparks 8e04feb498
fix: reference correct template in dbtemplate views (#4667) 2022-10-28 10:57:46 -05:00
Robert Sparks 48aa9b04c2
fix(nomcom): restore ability to classify pending feedback (#4668) 2022-10-28 10:57:28 -05:00
Nicolas Giard 9f8fd90287
feat: agenda fallback link to plaintext version (#4663) 2022-10-28 09:03:42 -05:00
Jennifer Richards a5f0259072
fix: stabilize sorts of upcoming meetings (#4661)
* fix: stabilize upcoming meeting sort

* fix: stabilize upcoming meeting ical sort
2022-10-27 13:03:14 -05:00
Jennifer Richards a3673f25cb
fix: sort higher capacity rooms first in schedule editor (#4653)
* fix: handle rooms with capacity = None in schedule editor

* fix: sort higher capacity rooms ahead of lower

Sort was incorrect, this matches intent and comments.
2022-10-27 09:58:51 -05:00
Jennifer Richards f42016d8fb
Merge branch 'feat/tzaware' into dev/main-merge-to-tzaware 2022-10-27 11:58:32 -03:00
Jennifer Richards e290d9e499
test: avoid local times near midnight for test_past_swap_days_buttons() (#4642)
* test: avoid local times near midnight for test_past_swap_days_buttons()

* test: use timezone_options variable consistently

* test: add test of timezone_not_near_midnight() method

* fix: ensure that timezone_not_near_midnight() always exits
2022-10-26 09:42:50 -05:00
Jennifer Richards cbc6d159a5
fix: convert LastCallDocEvent.expires to DEADLINE_TZINFO to get date 2022-10-25 10:03:18 -03:00
Jennifer Richards d55280d0b1
Merge pull request #4638 from ietf-tools/main
chore: merge main into feat/tzaware
2022-10-24 12:57:11 -03:00
Jennifer Richards a331fb6d2a
fix: fix tz handling in ics files (#4630)
* fix: render upcoming.ics timestamps correctly

Both correctly display timestamps in the claimed time zones and format
the date-times in correct iCalendar format.

* refactor: also render DTSTAMP using ics_date_time tag

* fix: render valid date-times in agenda.ics

* fix: render valid date-time in important_dates_for_meeting.ics

Only touching the DTSTAMP here. The DTSTART has VALUE=DATE so the tag
does not handle it.

* test: test ics_date_time tag
2022-10-24 12:54:52 -03:00
Lars Eggert d34e88dfd9
fix: Set an aria-label on freetext pronouns field (#4633) 2022-10-22 15:26:11 -05:00
Robert Sparks d08815d8da
fix: find raw chatlog and polls for interims (#4628) 2022-10-21 15:58:54 -05:00
Jennifer Richards aba9c2ae12
fix: include outbound constraints in sreq update notification email (#4620)
* fix: include outbound constraints in sreq update notification email

* style: clean up whitespace
2022-10-21 11:18:19 -05:00
Lars Eggert 565707f804
feat: Add "IESG dashboard" to menu (#4624)
Fixes #4570
2022-10-21 11:05:33 -05:00
Robert Sparks 3c191909ca
fix: stable and correct ordering of agenda items (#4621)
* fix: align session sorting across functions

* fix: sessions of a group can have different types
2022-10-21 11:04:27 -05:00
Lars Eggert 5ac3874ce9
fix: Format NomCom feedback table per suggestion of @richsalz (#4625)
Also makes table header alignment the same as for columns, site-wide.

Fixes #4529
2022-10-21 11:04:10 -05:00
Robert Sparks 26e2e23418
fix: reduce agenda data calculation time (#4622)
* fix: reduce agenda data calculation time

* doc: improve docstring for preprocess_assingments_for_agenda
2022-10-21 11:03:11 -05:00
Lars Eggert b1bafff2fb
fix: Add value attributes back to buttons to make the logic work (#4617) 2022-10-20 11:57:36 -05:00
Jennifer Richards 000e8431c2
Merge pull request #4615 from painless-security/jennifer/materials-tz
fix: use UTC for materials/proceedings cutoff checks
2022-10-20 11:39:10 -03:00
Lars Eggert 160ca9286a
fix: Don't say that IESG processing has started (#4609)
* fix: Don't say that IESG processing has started

Fixes #4286

* Update ietf/doc/views_draft.py

Co-authored-by: Robert Sparks <rjsparks@nostrum.com>

* Update ietf/doc/views_draft.py

Co-authored-by: Robert Sparks <rjsparks@nostrum.com>

Co-authored-by: Robert Sparks <rjsparks@nostrum.com>
2022-10-20 09:02:09 -05:00
Jennifer Richards fb644d7b50
fix: use UTC for materials/proceedings cutoff checks 2022-10-20 09:32:20 -03:00
Jennifer Richards 0346271578
refactor: simplify I-D cutoff calculations and make TZ more explicit 2022-10-19 17:47:07 -03:00
Lars Eggert 76b88b1658
fix: Replace some deprecated jQuery with recommended replacements (#4607) 2022-10-19 14:36:15 -05:00
Lars Eggert cf033352b4
fix: Tweak text as suggested by @richsalz (#4606)
Fixes #4531
2022-10-19 13:01:39 -05:00
Lars Eggert 0cc0281fe8
fix: Fix table sort functionality for tables with colspan attributes (#4605)
Fixes #4555
2022-10-19 11:59:09 -05:00
Jennifer Richards 320d9c3706
chore: renumber migrations 2022-10-18 17:22:37 -03:00
Jennifer Richards 69447d0ba0
Merge branch 'feat/tzaware' into jennifer/main-for-tzaware-merge
# Conflicts:
#	ietf/name/fixtures/names.json
#	ietf/utils/management/commands/send_gdpr_consent_request.py
2022-10-18 16:57:42 -03:00
Robert Sparks 9b4903e2e6
fix: Fix incorrect "GDPR" features/terminology. Fixes #4521. (#4587)
* fix: remove help/personal-information and the prompt-for-consent email management command.

* fix: remove gdpr treatment except for consent checkbox. Rename Submit.

* fix: drom the consent column from Person and Person.History

* fix: remove the consent boolean. Reorganize the account info form.

* chore: reorder migrations
2022-10-18 13:27:19 -05:00
Jennifer Richards 8101b4f057
chore: remove unused imports 2022-10-18 12:50:07 -03:00
Jennifer Richards 2d875d534d
chore: migrate fields whose defaults changed to date_today 2022-10-18 12:46:14 -03:00
Jennifer Richards 3220bf3c40
chore: replace last few datetime.date.today() calls with date_today() 2022-10-18 12:45:47 -03:00
Jennifer Richards 5b5e2dd9f0
chore: use settings.TIME_ZONE for datetime_today() default tz 2022-10-18 12:25:55 -03:00
Jennifer Richards dfe1147e7c
chore: switch a few datetime_today() calls to date_today() 2022-10-18 12:25:25 -03:00
Lars Eggert 66533827e1
fix: Fix status change form (#4598)
* fix: Fix status change form

Also make it so that select2 search fields get focus when they open.

* Remove feat
2022-10-18 09:59:04 -05:00
Jennifer Richards 1804727432
test: use date_today() instead of datetime_today() 2022-10-18 11:54:09 -03:00
Lars Eggert 5f7c585252
feat: Auto-focus select2 search fields when they open (#4599) 2022-10-18 09:42:00 -05:00
Robert Sparks cbb8da73c8
fix: regenerate correct shepherd template. Fixes #4558 (#4595)
* fix: regenerate correct shepherd template

* chore: remove unnecessary extra whitespace

* fix: improve readability of code per review comments
2022-10-18 07:57:08 -05:00
Jennifer Richards fffe0c1991
feat: disallow '/' from Person.name (#4594)
* feat: disallow '/' from Person.name

* chore: migrate Person/HistoricalPerson to include new name validator

* test: test name validation
2022-10-17 15:41:39 -05:00
Jennifer Richards bf6e0af2c9
chore: use settings.TIME_ZONE as default for date_today() 2022-10-17 17:36:47 -03:00
Jennifer Richards da70acfdff
Merge branch 'feat/tzaware' into jennifer/yet-more-tz-fixes
# Conflicts:
#	ietf/ietfauth/utils.py
#	ietf/meeting/tests_views.py
#	ietf/stats/tests.py
2022-10-17 16:39:45 -03:00
Robert Sparks 57b30fb967
chore: bring the names test fixture into alignment with the current database (#4583) 2022-10-14 17:53:04 -05:00
Jennifer Richards 354b3ef311
chore: add '-Z' suffix to timestamps in names.json 2022-10-14 16:55:40 -03:00
Jennifer Richards bef7492eda
chore: renumber migrations 2022-10-14 16:51:43 -03:00
Jennifer Richards 44f09ca457
chore: remove files left empty by git merge process 2022-10-14 16:38:42 -03:00
Jennifer Richards f3bdbf0ed4
Merge branch 'feat/tzaware' into jennifer/main-for-tzaware-merge
# Conflicts:
#	ietf/meeting/tests_js.py
#	ietf/meeting/tests_models.py
#	ietf/meeting/tests_views.py
#	ietf/meeting/views.py
#	ietf/name/fixtures/names.json
#	ietf/templates/meeting/agenda.html
#	ietf/templates/meeting/session_buttons_include.html
#	ietf/templates/meeting/timeslot_start_end.html
2022-10-14 16:35:57 -03:00
Jennifer Richards 83db95c4b3
test: extend simulateDragDrop to support dataTransfer.types interface (#4571) 2022-10-13 10:58:20 -05:00
Robert Sparks 6dd6165444
fix: correct meeting attendance calculations (#4536)
* fix: correct meeting attendance calculations

* test: change meetingregistration factory defaults

* test: Setup stats tests to verify counts honor meeting.Attended

But the tests aren't actually looking to see what numbers get generated yet.

* test: add test for attendance cross-talk between meetings

* fix: limit attendance count query to single meeting

* refactor: rename attendance.online to .remote

* fix: only count a given person as onsite or remote, but never both

* test: align tests with cleanup

Co-authored-by: Jennifer Richards <jennifer@painless-security.com>
2022-10-13 10:55:57 -05:00
Robert Sparks 50668c97cd
feat: apis for attaching chatlogs and polls to session materials (#4488)
* feat: apis for attaching chatlogs and polls to session materials

* fix: anticipate becoming tzaware, and improve guard against attempts to provide docs for sessions that have no official timeslot assignment.

* fix: get chatlog upload to actually work

Modifications to several initial implementation decisions.
Updates to the fixtures.

* fix: test polls upload

Refactored test to reduce duplicate code

* fix: allow api keys to be created for the new endpoints

* feat: add ability to view chatlog and polls documents. Show links in session materials.

* fix: commit new template

* fix: typo in migration signatures

* feat: add main doc page handling for polls. Improve tests.

* feat: chat log vue component + embedded vue loader

* feat: render polls using Vue

* fix: address pug syntax review comments from Nick.

* fix: repair remaining mention of chat log from copymunging

* fix: use double-quotes in html attributes

* fix: provide missing choices update migration

* test: silence html validator empty attr warnings

* test: fix test_runner config

* fix: locate session when looking at a dochistory object for polls or chatlog

Co-authored-by: Nicolas Giard <github@ngpixel.com>
2022-10-13 09:20:36 -05:00
Jennifer Richards 0ad293d6e9
feat: add slides / session materials links to session details modal (#4535)
* feat: add propose/upload slides button to session details modal

* refactor: remove unneeded chaining operator

* test: fix quotes around template string

* feat: link to meeting materials page from AgendaDetailsModal

* refactor: compute session details URL in JS instead of view

* chore: restyle materials page link

* test: fix test case to match changes to session modal
2022-10-12 16:07:23 -05:00
Nicolas Giard 6f2114fb0c
feat: replace old agenda with agenda-neue (#4406)
* feat: remove old agenda (django-side)

* fix: bring in latest commits

* test: remove -neue from playwright tests

* test: remove agenda selenium js tests

* test: remove agenda views tests

* fix: remove deprecated agenda views (week-view, agenda-by, floor-plan)

* test: fix failing python tests

* test: remove more deprecated tests

* chore: remove deprecated templates

* test: remove unused import

* feat: handle agenda personalize with filter + move agenda specific stuff out of root component

* fix: redirect deprecated urls to agenda / floorplan

* feat: agenda - open picker mode when from personalize path

* fix: safari doesn't support device-pixel-content-box property on ResizeObserver

* test: move floor plan test into main agenda test

Co-authored-by: Robert Sparks <rjsparks@nostrum.com>
2022-10-12 15:46:28 -05:00
Jennifer Richards 8560bec09c
fix: remove spurious year after nominee name (#4565) 2022-10-12 13:29:08 -05:00
Robert Sparks c1556a3bc5
fix: revert photo-on-menubar enhancement (#4564)
* fix: revert photo-on-menubar enhancement

* fix: revert styling added for menubar photo.
2022-10-12 13:25:47 -05:00
Jennifer Richards 7b1b7f5273
Merge branch 'feat/tzaware' into dev/tzaware-main-merge 2022-10-11 14:57:34 -03:00
Jennifer Richards 9709dbdf1c
fix: work around dataTransfer.getData limitation in agenda editor (#4553)
* fix: work around dataTransfer.getData limitation in agenda editor

* refactor: be slightly more careful checking dataTransfer type

* chore: remove debug statement
2022-10-10 08:48:23 -05:00
Lars Eggert eed58c9753
ui: Add rounded-pill to a few more badges (#4539) 2022-10-10 08:37:58 -05:00
Robert Sparks 97d21800d0
feat: include checkins at the registration desk in nomcom eligibility calculations (#4519)
* chore: rename utility functions to reflect rfc guiding them

* feat: include new checkedin flag in nomcom calculations

* fix: reflect history a bit more accurately.

* fix: address review comment on readability

* fix: finish what c44000d started
2022-10-07 16:17:28 -05:00
Jennifer Richards cb9e576fb4
fix: return False from has_role() when role_names is the empty list (#4541)
* fix: return False from has_role() when role_names is the empty list

* chore: add comments clarifying the effect of Q()
2022-10-07 16:05:37 -05:00
Lars Eggert 15a1d3e379
chore: Update deps (bs to 5.2.2, various others) (#4537)
Also fix html-validate, which now wants a `.json` suffix on config files.
2022-10-07 16:05:04 -05:00
Lars Eggert 43e4a26ca0
fix: Don't show ADs as part of "bethere" contraints. (#4540)
Also tweak some minor UI stuff while I'm here.
2022-10-07 16:02:29 -05:00
Jennifer Richards 0bdfb25c47
feat: include proposed WGs on meeting requests page (#4551) 2022-10-07 15:56:43 -05:00
Jennifer Richards 6cc2fb94a3
fix: update DraftYangChecker for xym 0.6 changes (#4546)
* fix: update DraftYangChecker for xym 0.6 changes

* chore: update xym requirements to >=0.6
2022-10-06 18:03:18 -05:00
Lars Eggert 8a6ff176af
fix: Add reminder to not include ADs in "people who must be present" (#4527)
* fix: Add reminder to not include ADs in "people who must be present"

* Fix typo.
2022-09-30 12:55:36 -05:00
Robert Sparks 2058522a0c
feat: stop setting MeetingRegistration.attended on MeetEcho login. (#4526)
* feat: stop setting MeetingRegistration.attended on MeetEcho login.

We capture attendence through MeetEcho using meeting.Attended now.

* chore: remove unused import

* chore: remove unused import
2022-09-30 10:46:49 -05:00
Jennifer Richards f043797742
fix: include IRTF and BoF groups on meeting requests page (#4528)
* fix: include IRTF and BoF groups on meeting requests page

* test: test bof/irtf groups on the meeting requests page

* chore: remove some accidentally committed changes

* style: improve formatting of requests.html template
2022-09-30 10:08:11 -05:00
Lars Eggert 3e2b1fc92e
feat: Add a bug report link to the menu bar (#4525)
This required making some horizontal room for it, mostly by showing a
user photo or shorter tag when they are logged in.
2022-09-30 09:20:43 -05:00
Robert Sparks 9b896e5869
fix: avoid emptying nomcom session key when openssl complains about derivation (#4524) 2022-09-30 08:05:01 -05:00
Lars Eggert feab9fb385
fix: Fix state order in AD dashboard and colorize some more trends (#4518) 2022-09-29 15:10:51 -05:00
Jennifer Richards 31d55f1d37
fix: remove unused imports 2022-09-28 17:45:11 -03:00
Jennifer Richards a653582cf7
fix: timezone fixes from last few comparisons with tzaware-obe 2022-09-28 13:21:50 -03:00