Commit graph

14575 commits

Author SHA1 Message Date
Lars Eggert d00d19f512
chore: Update deps (#4904)
* chore: Update deps

* Revert to shepherd@10
2022-12-19 08:53:46 -06:00
Jennifer Richards 27469c1264
fix: do not create ReviewRequestDocEvent when assigning a review req (#4913)
* fix: do not create ReviewRequestDocEvent when assigning a review req

* test: test docevent creation
2022-12-16 15:17:10 -06:00
Lars Eggert ad5cf0bb01
fix: Fix layout issue in ballot modals on narrow screens (#4911)
* fix: Fix layout issue in ballot modals on narrow screens

Fixes #4902

* Also apply change to old positions

* Fix tests

* Use badge to indicate former ADs
2022-12-16 13:09:55 -06:00
Lars Eggert e6e0d8fc1a
feat: Diff arbitrary versions from new HTMLization page (#4863)
* feat: Diff arbitrary versions from new HTMLization page

Fixes #4859

* Rework this based on @rjsparks' suggestion. Not quite done yet.

* Progress

* Fix HTML

* Don't show compare buttons if there aren't at least two versions

* Remove spurious title attribute

* Use and style select2 for the version diff dropdowns

* Roll in code review suggestions

* Some tests!
2022-12-16 10:46:05 -06:00
Nicolas Giard 286e737d98
ci: nightly db build - pin download artifact action to v3 2022-12-15 15:52:31 -05:00
Lars Eggert 8a599b749b
fix: Set font size from cookie before DOM is ready, to avoid flickering (#4882)
* fix: Set font size from cookie before DOM is ready, to avoid flickering

* fix: Use localStorage instead of cookies where possible
2022-12-15 09:36:30 -06:00
Jennifer Richards 38748cb10b
refactor: add guards/type hints to build_file_urls() (#4896)
* refactor: add guards/type hints to build_file_urls()

* fix: compare doc.type_id, not doc.type, with string value

* test: add cursory test of build_file_urls()
2022-12-14 17:22:26 -06:00
Lars Eggert 36e6b98394
fix: Fix sidebar hiding functionality (#4891)
Broken by #4860
Fixes #4858
2022-12-14 15:11:41 -06:00
Nicolas Giard ce9afdcc90
ci: move pg build to nightly db workflow 2022-12-14 00:20:49 -05:00
Nicolas Giard eac5ec0d67
ci: add workflow permissions to pgtest 2022-12-13 23:38:51 -05:00
Nicolas Giard d9f7488dfb
ci: add missing workflow dependency 2022-12-13 19:57:47 -05:00
Nicolas Giard 5a48d6a77d
ci: add multi-platform pg image build workflow steps 2022-12-13 19:39:27 -05:00
Nicolas Giard bc1cba1cca
ci: add pgdb service to test build workflow 2022-12-13 17:48:54 -05:00
Jennifer Richards 3d47a9069c
fix: eliminate race condition when creating a review Document (#4876) 2022-12-13 14:45:42 -06:00
Nicolas Giard 0d2e264de4
ci: add test pg build workflow 2022-12-13 15:37:04 -05:00
Nicolas Giard dc023b3e17
ci: fix nightly db build workflow 2022-12-13 14:47:10 -05:00
Jennifer Richards 73fcf51709
fix: handle both rev is None and '' in document_main (#4887) 2022-12-13 12:22:43 -06:00
Lars Eggert 017b5f54d1
fix: Force font-size and line-height for plaintext PDFization (#4879)
Fixes #4343
2022-12-13 10:10:14 -06:00
Lars Eggert 49f586ed4f
fix: Apply CSS suggestion by @martinthomson (#4872)
Fixes #4869
2022-12-13 08:41:35 -06:00
Nicolas Giard 17fc283944
ci: add pg dockerfile to nightly build 2022-12-13 00:34:53 -05:00
Jennifer Richards 5a1fc4c2ab
fix: use a single Meeting instance for all assignments in agenda views (#4877) 2022-12-12 16:33:08 -06:00
Lars Eggert f0966e43f5
fix: Don't show checker validations on HTMLization page (#4873)
Modals in static sidebars don't work; fixing this needs a larger rework.

Fixes #4865
2022-12-12 13:25:21 -06:00
Robert Sparks 572733d3f1
feat: validate the document notify field (#4856)
* feat: validate the document notify field

* chore: fix spelling in comment

* feat: be more explicit in notify validation, preserving input order.

* fix: restrict notify duplicate check to nameaddrs. Add tests.
2022-12-12 13:16:41 -06:00
Jennifer Richards 6644ab48c0
fix: handle groups_at_the_time cache misses (#4853)
* fix: handle groups_at_the_time cache misses

* refactor: add comments, share meeting-start code between calls

* test: test Meeting.group_at_the_time()
2022-12-09 13:57:27 -06:00
Robert Sparks 25da1a1c2a
fix: restore session materials revision button url (#4867) 2022-12-09 13:49:11 -06:00
Lars Eggert 5af9b82927
fix: Properly hide the sidebar on medium and smaller viewports (#4860)
Fixes #4858.
2022-12-09 08:17:21 -06:00
Lars Eggert f870715a80
fix: Allow more email addresses in notification lists (#4792)
* fix: Allow more email addresses in notification lists

Fixes #4736

* Do what @rjsparks suggested

* Number migration

* Number migration

* Fix tests and apply for all doc types
2022-12-08 15:46:35 -06:00
Lars Eggert 7991dadc5e
feat: Add links to tools, so people know where to file issues. (#4851)
* feat: Add links to tools, so people know where to file issues.

* Remove spurious character
2022-12-08 13:58:04 -06:00
Robert Sparks 44c38abbbb
fix: in htmlization ignore html files that do not parse as html (#4850) 2022-12-08 13:55:15 -06:00
Lars Eggert efb9f135c3
fix: Apply various suggestions from @martinthomson (#4849)
* With bs 5.2.3, no need to rewrite dots in ids and hrefs.

* Remove leftover console.log().

* Inherit color for <code>

* Don't wrap boilerplate URLs; makes it look more like text version.
2022-12-08 08:58:28 -06:00
Nicolas Giard 83771aceb3
ci: scheduled shared assets rsync 2022-12-07 17:49:47 -05:00
Lars Eggert 220be21998
chore: Use codespell to fix typos in code. (#4797)
* chore: Use codespell to fix typos in code.

Second part of replacement of #4651

@rjsparks, I probably need to revert some things here, and I also
still need to add that new migration - how do I do that?

* Revert migrations

* Migrate "Whitelisted" to "Allowlisted"

* TEST_COVERAGE_MASTER_FILE -> TEST_COVERAGE_MAIN_FILE

* Fix permissions

* Add suggestions from @jennifer-richards
2022-12-07 15:10:35 -06:00
Jennifer Richards 015ac316fb
test: fix test broken by 40fd46a2 (#4847) 2022-12-07 15:06:43 -06:00
Jennifer Richards 40fd46a293
fix: be more sure to create interim's timeslot / update duration (#4846) 2022-12-07 14:45:00 -06:00
Robert Sparks a7c0cc0464
fix: ignore badly coded user-provided html of older documents (#4845) 2022-12-07 11:11:25 -06:00
Nicolas Giard 81b8ffc929
ci: add hostname label to sandbox container 2022-12-06 18:03:00 -05:00
Nicolas Giard 7a4c8b375f
ci: fix sandbox label app version 2022-12-06 17:34:28 -05:00
Nicolas Giard 9c78c250ed
ci: force sandbox container labels to be string 2022-12-06 17:26:03 -05:00
Nicolas Giard 0bb036ef1d
ci: add labels to sandbox container 2022-12-06 17:16:46 -05:00
Nicolas Giard 94e4a0ddd2
ci: add sandbox deploy labels to cli 2022-12-06 17:13:03 -05:00
Robert Sparks 8cdf4cea6e
fix: force lightningcss to resolve to 1.17 (#4841)
Picks up arm glibc fixes.
2022-12-06 12:48:23 -06:00
Robert Sparks ded650286d
fix: don't use rfc names in bibxml-id elements (#4823) 2022-12-06 08:49:14 -06:00
Robert Sparks ebcaa424c3
feat: Use author-tools for iddiff instead of rfcdiff at www (#4834) 2022-12-06 08:48:38 -06:00
Robert Sparks e257ddbfea
fix: restore sql_debug functionality from the container (#4835) 2022-12-06 08:48:23 -06:00
Jennifer Richards ac55b2cb6f
fix: init time inputs in correct tz when editing an interim request (#4838)
* fix: init time inputs in correct tz when editing an interim request

* test: add test

* test: fix old tests that relied on mixing dates, times, and datetimes
2022-12-06 08:46:48 -06:00
Jennifer Richards 895aff9480
test: suppress deprecation warning from selenium internals (#4836) 2022-12-06 08:42:13 -06:00
Jennifer Richards 0abebf2f10
feat: add 'IETF Meetings' filter to upcoming meetings page (#4826)
* feat: add 'IETF Meetings' filter to upcoming meetings page

* feat: apply 'ietf-meetings' filter to upcoming.ics

* fix: also filter upcoming IETF meetings in the graphical calendar

* test: update tests to match changes

Includes fixing an error in test_upcoming_view_filter_hide_type().
Due to a copy/paste error, it claimed to be testing with a type
both shown and hidden but was not actually hiding a type at all.
2022-12-05 15:19:36 -06:00
Robert Sparks 562d5cceeb
fix: include html when syncing extra assets 2022-12-02 16:28:08 -06:00
Lars Eggert d59c64943d
fix: Fix spurious author extraction errors (#4799)
* Handle single-word author names

* Some i18n names, e.g., "शिला के.सी." have a dot at the end that is
also part of the ASCII, e.g., "Shilaa Kesii." That trailing dot breaks
extract_authors(). Avoid this issue by stripping the dot from the
ASCII.

* Honorifics need to be part of the extracted ASCII name (e.g., "Lady Garcia")

* feat: stop supporting pre-tzaware migration database dumps. (#4782)

* feat: stop supporting pre-tzaware migration database dumps.

* chore: remove unnecessary env variable

* chore: Use `codespell` to fix typos in comments. (#4794)

First part of replacement of #4651

* feat: Only show IPR search form when not showing search results  (#4793)

* feat: Only show IPR search form when not showing search results

Put it into a collapsible that is only expanded by default when not
showing search results.

Fixes #4569

* Don't use example target name

* fix: Don't show reorder UI fixtures unless user can reorder (#4785)

Fixes #4773

Co-authored-by: Robert Sparks <rjsparks@nostrum.com>

* chore: Update deps and fix resulting HTML validation issues (#4790)

* ci: add missing build matrix config for test-playwright-legacy step

* Single-letter last names exist (e.g., "Carolina de la O")

* Align regex with others

* Fix extraction of very long author names

* Need to be more general

* Add comment

* Also handle i18n names with trailing semicolons

* Name suffixes need to be part of the extracted author names

* Handle i18n names with embedded commas

Co-authored-by: Robert Sparks <rjsparks@nostrum.com>
Co-authored-by: Nicolas Giard <github@ngpixel.com>
2022-12-02 15:41:21 -06:00
Jennifer Richards 3af68b6fbb
fix: avoid readonly attribute on select element (#4819)
* fix: avoid readonly attribute on select element

* chore: remove now-unused CSS for select2

* test: don't ignore `readonly` on `select`

* refactor: simplify OutgoingLiaisonForm base class overrides
2022-12-02 15:39:21 -06:00