Commit graph

183 commits

Author SHA1 Message Date
Henrik Levkowetz 536789517d Added a sort of author names for stability of some stats pages. Commit ready for merge.
- Legacy-Id: 18751
2020-12-11 16:57:29 +00:00
Henrik Levkowetz ac5e88b82b Added a context processor to make settings generally available in page templates. Split the SECRETARIAT_TICKET_EMAIL setting into SECRETARIAT_ACTION_EMAIL and SECRETARIAT_INFO_EMAIL, with different addresses. Updated places with hardcoded ietf-action@ietf.org addresses to use the settings value, and updated some places to use ietf-infor@ietf.org instead of the ietf-action address. Fixes issue #3081.
- Legacy-Id: 18501
2020-09-17 11:10:27 +00:00
Henrik Levkowetz 57938b039d Converted many cases of plain-text 403 messages to use a properly styled page instead, with a login link when appropriate. Also changed some API endpoint 400 responses to a more correct 403.
- Legacy-Id: 18339
2020-08-06 10:59:52 +00:00
Henrik Levkowetz 6a38234b0a Tweaked the MeetingRegistration admin.
- Legacy-Id: 18062
2020-06-25 16:22:41 +00:00
Henrik Levkowetz ae6b39459f Updated API resources for MeetingRegistration.
- Legacy-Id: 17961
2020-06-10 18:22:47 +00:00
Henrik Levkowetz 567449d3d2 Merged in [17908] from rjsparks@nostrum.com:
Add used_roles to Group and default_used_roles to GroupFeatures. Dynamically build the group edit form to provide a field for all used_roles. Fixes #2785 and #2572. Partially addresses #2160.
 - Legacy-Id: 17960
Note: SVN reference [17908] has been migrated to Git commit 2862727d02
2020-06-10 12:58:29 +00:00
Henrik Levkowetz 8a6026ce6e Added a MeetingRegistration.attended field, to keep apart meeting attendence and meeting registration before attendance.
- Legacy-Id: 17954
2020-06-09 20:58:35 +00:00
Henrik Levkowetz 59487f5627 Fixed an issue with multiple objects matching a registsration record fetched from the registration system (this has been caused by not correctly detecting changes in registration system details).
- Legacy-Id: 17953
2020-06-09 19:42:11 +00:00
Henrik Levkowetz 956ddaf3cf Fixed an incorrect admin site search field specification.
- Legacy-Id: 17951
2020-06-09 18:26:45 +00:00
Henrik Levkowetz ec5d159b4f Added a new API endpoint to be used by the registration system, to trigger account creation.
- Legacy-Id: 17941
2020-06-08 19:51:10 +00:00
Henrik Levkowetz 228f00287b Added migrations for model changes
- Legacy-Id: 17938
2020-06-08 19:28:15 +00:00
Henrik Levkowetz c01dcddea1 Added reg_type and ticket_type to the MeetingRegistration model.
- Legacy-Id: 17932
2020-06-08 19:14:21 +00:00
Henrik Levkowetz 9aeda11a29 Removed some Py2 compatibility decorators.
- Legacy-Id: 17673
2020-04-21 13:54:31 +00:00
Henrik Levkowetz 726fcbf27d Removed all __future__ imports.
- Legacy-Id: 17391
2020-03-05 23:53:42 +00:00
Henrik Levkowetz 566971a6ae Removed further six usage.
- Legacy-Id: 17386
2020-03-05 15:10:33 +00:00
Henrik Levkowetz e9a37d8ac8 Removed six.text_type(), changed six.moves.urllib to plain urllib, and removed now unused six imports.
- Legacy-Id: 17385
2020-03-05 14:41:41 +00:00
Henrik Levkowetz 286ee2f961 Merged in [16852] from sasha@dashcare.nl:
Fix #2331 - Show stacked bar graph for in time and late reviews.
On the stats page, a single stacked bar graph is now shown which
combines in time and late reviews, replacing the separate graphs for
these statistics.
Tests for the charts are also expanded to validate the actual
graph content for both stacked and non-stacked charts.
 - Legacy-Id: 16898
Note: SVN reference [16852] has been migrated to Git commit f651320ef3
2019-10-22 11:49:39 +00:00
Sasha Romijn f651320ef3 Fix #2331 - Show stacked bar graph for in time and late reviews.
On the stats page, a single stacked bar graph is now shown which
combines in time and late reviews, replacing the separate graphs for
these statistics.

Tests for the charts are also expanded to validate the actual
graph content for both stacked and non-stacked charts.

Commit ready for merge.
 - Legacy-Id: 16852
2019-10-09 15:46:22 +00:00
Henrik Levkowetz 33e8733b91 Fixed up mypy issues or added type:ignore comments as needed for a clean mypy run.
- Legacy-Id: 16772
2019-09-30 15:42:18 +00:00
Henrik Levkowetz 8e313e4ed5 Adjusted migrations for Python2/3 compatibility.
- Legacy-Id: 16633
2019-08-08 17:11:14 +00:00
Henrik Levkowetz e03784132d Merged changes from current trunk to Py3 branch.
- Legacy-Id: 16468
2019-07-16 15:36:16 +00:00
Henrik Levkowetz ef4a41c14b Fixed a bytes/str issue with the arguments to syslog.openlog()
- Legacy-Id: 16460
2019-07-16 13:18:37 +00:00
Henrik Levkowetz 8c6eb3a30a Python2/3 compatibility: Changed the use of open() and StringIO to io.open() etc.
- Legacy-Id: 16458
2019-07-15 19:14:04 +00:00
Henrik Levkowetz ea8c84d2f6 Python2/3 compatibility: used @python_2_unicode_compatible to provide __unicode__() versions of __str__() methods.
- Legacy-Id: 16455
2019-07-15 18:01:26 +00:00
Henrik Levkowetz a5e31c3f40 Py2/3 compatibility: Added __future__ import.
- Legacy-Id: 16452
2019-07-15 15:52:18 +00:00
Henrik Levkowetz 2d7c9629aa Added 'from __future__' imports all over the place, to bring code behaviour into closer alignment between python2 and python3
- Legacy-Id: 16446
2019-07-15 15:40:51 +00:00
Henrik Levkowetz f481f5c3e6 Replaced use of six with the equivalent pure python3 constructs.
- Legacy-Id: 16428
2019-07-08 10:43:47 +00:00
Henrik Levkowetz e55c42b20f Tweaked code to prevent sort comparison of str with None.
- Legacy-Id: 16397
2019-07-04 20:58:25 +00:00
Henrik Levkowetz 41438e5c4d Fixed some bytes/str issues and unused imports.
- Legacy-Id: 16391
2019-07-04 20:51:10 +00:00
Henrik Levkowetz b7690fbdcd Changed additional regexes to r strings.
- Legacy-Id: 16377
2019-07-04 15:54:23 +00:00
Henrik Levkowetz f13887de7c Removed superfluous iter() and fixed instances where sorted() had to compare None and int.
- Legacy-Id: 16352
2019-07-01 14:07:21 +00:00
Henrik Levkowetz 15e74e89cb Converted instances of assertTrue(text in response.content) to the recommended assertContains(response, text), and similar for assertFalse(... in ...)
- Legacy-Id: 16336
2019-06-29 13:43:31 +00:00
Henrik Levkowetz a70c6d478b A fix for an issue in get_meeting_registration_data() which could happen if we tried to create a Person record for with a user of an existing Person.
- Legacy-Id: 16331
2019-06-29 00:02:30 +00:00
Henrik Levkowetz 484dcece5f Changed all model __unicode__() methods to __str__()
- Legacy-Id: 16330
2019-06-28 21:07:08 +00:00
Henrik Levkowetz d7f5c84182 Initial 2to3 patch with added copyright statement updates.
- Legacy-Id: 16309
2019-06-27 14:40:54 +00:00
Henrik Levkowetz 7270d5f67a Added the option to order API resource lists by primary key, for stable ordering when paging through a list.
- Legacy-Id: 16284
2019-06-18 12:40:19 +00:00
Henrik Levkowetz 426870b766 Merged in the Document and DocAlias primary key change and m2m work in ^/personal/henrik/6.96.1-docalias.
- Legacy-Id: 16261
2019-06-15 12:00:48 +00:00
Henrik Levkowetz a2cafded25 Changed DocAlias to be many-to-many, in order to be able to handle STD aliases referring to multiple RFCs.
- Legacy-Id: 16249
2019-06-14 20:38:14 +00:00
Henrik Levkowetz 8726e74709 Merged in a refactoring of document review code from rjsparks@nostrum.com. This introduces ReviewAssignments, letting us do multiple assingments for a given RevieRequest, without conflating the assignments and their results with the request itself.
- Legacy-Id: 16177
2019-04-30 16:54:06 +00:00
Henrik Levkowetz bb4fe3fbbf Undid previous commit
- Legacy-Id: 16153
2019-04-22 19:22:42 +00:00
Henrik Levkowetz cfcefc2e32 Merged in [16144] from housley@vigilsec.com:
Remove some clutter from I-D upload page.  The information was mived to the Instructions tab, but a higligh to the Note Well and BCP 78 was added. Fixes #2057.
 - Legacy-Id: 16151
Note: SVN reference [16144] has been migrated to Git commit 37851b9742
2019-04-22 17:39:26 +00:00
Robert Sparks 6dc25cae1a Bring time series stats back into line with what was before. Note there was an off-by-one-day bug in the month-binning in prior releases.
- Legacy-Id: 16075
2019-03-20 20:04:06 +00:00
Henrik Levkowetz 23ad24d2aa Put a length limit to generated cache keys in stats/views.py, to avoid tickling memcached's limit of 250.
- Legacy-Id: 16037
2019-03-17 11:16:38 +00:00
Robert Sparks 4b147f2ef8 More cleanup and correction. Caught a pervasive misuse of a state-name
- Legacy-Id: 16036
2019-03-15 20:39:06 +00:00
Robert Sparks 3678d20b0b Some cleanup around stats. Things are well except for the time series graphs.
- Legacy-Id: 16035
2019-03-15 16:50:59 +00:00
Robert Sparks 0856990683 Checkpoint. Most tests do not fail. Oddness with an API resource, and with one template's coverage
- Legacy-Id: 16031
2019-03-14 18:39:40 +00:00
Henrik Levkowetz 2b811b3d3d Updated the tests to always use @ietf.org addresses where appropriate, and not do so when not appropriate. All test user login addresses have been changed away from @ietf.org.
- Legacy-Id: 15988
2019-03-04 20:08:48 +00:00
Henrik Levkowetz e4af908a74 Merged in [15698] from rjsparks@nostrum.com:
Notify the RFC Editor when an RFC Editor note is changed after a draft has been approved. Fixes #2440.
 - Legacy-Id: 15729
Note: SVN reference [15698] has been migrated to Git commit 43374969f6
2018-11-06 07:13:56 +00:00
Henrik Levkowetz 76303a9941 Fixed a pyflakes issue.
- Legacy-Id: 15725
2018-11-06 04:48:28 +00:00
Henrik Levkowetz 26535bf696 Took out some debug statements for a seldomly occurring condition (that now seem to be OBE)
- Legacy-Id: 15723
2018-11-06 04:20:39 +00:00
Henrik Levkowetz 3508f59f52 Merged in [15596] from rjsparks@nostrum.com:
improved coverage for several tests.
 - Legacy-Id: 15600
Note: SVN reference [15596] has been migrated to Git commit 6f18ae882532433ba86322b33c34f5f1b0350cb9
2018-10-19 14:27:13 +00:00
Henrik Levkowetz ef3cbf4684 Merged in [15595] from rjsparks@nostrum.com:
Converted stats, submit, sync. and utils/test to use factories. Excluded utils/test_data from coverage checks.
 - Legacy-Id: 15599
Note: SVN reference [15595] has been migrated to Git commit 39e76a836996ec9ed8ea449c92bdfae91c3dbaae
2018-10-19 12:54:58 +00:00
Henrik Levkowetz 4db62920c1 Updated PLAN
- Legacy-Id: 15445
2018-09-10 13:44:19 +00:00
Henrik Levkowetz 6c3ec5b18e Added Email origin to Email record creation throughout the codebase.
- Legacy-Id: 15149
2018-05-17 16:56:26 +00:00
Henrik Levkowetz 5f37a71889 Added origin information to all places where we create email address entries.
- Legacy-Id: 15127
2018-05-05 12:40:30 +00:00
Henrik Levkowetz 080f6b4385 Added group links to the past meetings page, and also important dates links to IETF meetings with important-date pages.
- Legacy-Id: 15053
2018-04-18 13:15:30 +00:00
Henrik Levkowetz 010910a847 Tweaked the meeting date format in the attendees per meeting bargraph tooltip.
- Legacy-Id: 14952
2018-03-28 06:37:31 +00:00
Henrik Levkowetz 176022f57b Added meeting dates to the meeting stats overview graph.
- Legacy-Id: 14947
2018-03-26 22:58:14 +00:00
Henrik Levkowetz dac30f6ff7 Changed the name of a loop variable so as not to obscure a previous local variable.
- Legacy-Id: 14946
2018-03-26 21:42:10 +00:00
Henrik Levkowetz 68f64e9ecb Don't show future meetings in the meeting stats overview.
- Legacy-Id: 14945
2018-03-26 21:39:41 +00:00
Henrik Levkowetz 4c297ba4c0 Changed settings so that cache keys used by memcached includes the release version, in order to avoid stale and incorrect cache content on new release deployment. Made it easier to pick out cache key composition by normalizing the variable name. Adjusted cache prefix and the composition of some keys to have a unique and consistent cache key prefix.
- Legacy-Id: 14943
2018-03-26 21:26:20 +00:00
Henrik Levkowetz c8ebcf1f88 Merged in [14879] from kivinen@iki.fi:
Backfilled IETF meetings starting from 1 and backfilled the attendee numbers for them. Modified the overview attendee statistics page to use different colors for different venue continents.
 - Legacy-Id: 14898
Note: SVN reference [14879] has been migrated to Git commit 75dbe017a6
2018-03-22 00:01:57 +00:00
Henrik Levkowetz ddbd244421 Tweaked the meeting registratoin import to deal more gracefully with too long names and email addresses, and to fill in the total attendees number for the meeting.
- Legacy-Id: 14897
2018-03-21 23:30:45 +00:00
Tero Kivinen 75dbe017a6 Backfilled IETF meetings starting from 1 and backfilled the attendee numbers for them. Modified the overview attendee statistics page to use different colors for different venue continents. Commit ready for merge.
- Legacy-Id: 14879
2018-03-20 17:28:48 +00:00
Henrik Levkowetz e29aa990a6 Tweaked a setting for better readability.
- Legacy-Id: 14840
2018-03-17 13:00:56 +00:00
Henrik Levkowetz a4768bb514 Removed unused imports. Added some explicit orderings to avoid pagination issues.
- Legacy-Id: 14664
2018-02-21 23:54:31 +00:00
Henrik Levkowetz 06362ec046 Got rid of old migrations and created new initial migrations.
- Legacy-Id: 14662
2018-02-21 23:46:22 +00:00
Henrik Levkowetz 5638cf3da3 Changed all usage of ForeignKey and OneToOneFiled in model.py files to the compatibility versions from ietf.utils.models.
- Legacy-Id: 14661
2018-02-20 15:36:05 +00:00
Henrik Levkowetz ee33b6026b Tweaked the query filter for 'latest' meetings in the fetch_meeting_attendance management command to deal with future meetings beyond the current meeting.
- Legacy-Id: 14458
2017-12-22 19:56:55 +00:00
Henrik Levkowetz 954d79c684 Added a guard against iterating over None in stats.views.document_stats()
- Legacy-Id: 14250
2017-10-31 18:07:08 +00:00
Henrik Levkowetz 2c1438c240 Moved unidecode_name from utils.text to person.name.
Modified UserFactory to use a new locale for each new user, instead of the
same locale for a whole test run.  This (almost) ensures the exercise of
code to deal with non-ascii names, something which would not happen if a
locale with ascii names was chosen at the start of a run.

Modified name.initials() to not use non-word characters as initials.

Modified unidecode_name() to do more normalization, to conform to the
conventions used in internet-drafts.

Added saving of the factory-boy random state in order to be able to re-run
a test suite with the same pseudo-random sequence as in a previous failed
run.

Fixed an issue with email formatting in test_api_submit_ok().

Modified the draft author extraction code to deal better with names with
embedded apostrophes.
 - Legacy-Id: 14141
2017-09-20 15:36:30 +00:00
Henrik Levkowetz 33b275b04f Added ietf.utils.text.unidecode_name() and replaced various uses of unidecode() with it, in order to normalize the generation of ascii versions of names, to avoid different practices in space stripping and space normalization in different parts of the code.
- Legacy-Id: 14128
2017-09-17 15:12:18 +00:00
Henrik Levkowetz 7b1224ebad Merged in ^/personal/sbirkholz/meeting_registration_more_fixes, which adds creation of missing person records when importing meeting registration data. Tweaked the resulting code some.
- Legacy-Id: 14092
2017-08-31 18:48:53 +00:00
Ryan Cross 044b89169a Strip whitespace from registration data during import. Includes migration for existing data. Fixes #2356. Commit ready for merge.
- Legacy-Id: 14088
2017-08-29 19:58:32 +00:00
Seth Birkholz 8b5a639b82 This should be the final fix to
resolve the meeting registration problem where a Person object
 was not being created
 - Legacy-Id: 14076
2017-08-24 19:04:40 +00:00
Henrik Levkowetz 24273da256 Backed out commit 14000; the code is not idempotent and will create duplicate Person objects.
- Legacy-Id: 14004
2017-07-29 14:02:41 +00:00
Henrik Levkowetz 70614557cc Added an admin model for the MeetingRegistration class.
- Legacy-Id: 14003
2017-07-29 14:01:19 +00:00
Henrik Levkowetz 68abf06905 Merged ^/personal/sbirkholz/meeting_registration/@13969:
Added Person objects to a MeetingRegistration objects in ietf/stats/utils.py when importing meeting registrations in get_meeting_registration_data().
 - Legacy-Id: 14000
2017-07-29 10:34:32 +00:00
Seth Birkholz 6359192cbb Commit ready for merge. This commit implements fixes suggested by Henrik to the MeetingRegistration class
- added tests
    - reverted 'obj' to 'object'
    - removed check for valid email
    - identifing person by Email.person rather than Person.user__username
    - used a simpler form of unidecode logic.  TBD: the previous code was stolen from elsewhere in the code which should also be simplified.
    - Person.name now uses firstname + lastname rather than email.
 - Legacy-Id: 13969
2017-07-25 20:20:00 +00:00
Seth Birkholz bffc7114eb Added Person object to ietf/stats/utils.py in get_meeting_registration_data
- Legacy-Id: 13949
2017-07-19 16:48:28 +00:00
Henrik Levkowetz b42f1cbeb5 Replaced the use of unaccent.asciify(), which has similar functionality to unidecode.unidecode(). Changed the draft parser to work exclusively with unicode text, which both makes the removal of unaccent easier, and takes us closer to Py35 compatibility. Adjusted callers of the draft parser to send in unicode.
- Legacy-Id: 13673
2017-06-18 18:23:18 +00:00
Henrik Levkowetz 40eae13aa6 Added a migration for the email field on MeetingRegistration.
- Legacy-Id: 13558
2017-06-07 12:30:31 +00:00
Henrik Levkowetz 8b72b6a29a Made the stats backfill script slightly more verbose, including some blank lines for readability. Changed output to go both to screen and to file. Made the unicode/latin1/ascii decoding more general.
- Legacy-Id: 13535
2017-06-05 22:37:14 +00:00
Henrik Levkowetz 20b4250ea5 Reduced the size of stats data transferred from the server by an order of magnitude for author stats pages by not sending complete lists of item names per table item (we're only displaying them when there are few to display, anyway). Added caching of the resulting stats data for 24 hours. The caching was not possible in all cases before the data reduction, due to an item size limit of 1 MByte in memcached.
- Legacy-Id: 13534
2017-06-05 22:32:15 +00:00
Henrik Levkowetz 91b4063669 Added 24 hour caching of the author and meeting stats pages. Sorted the django imports and combined 2 imports from the same module.
- Legacy-Id: 13494
2017-06-02 10:21:12 +00:00
Henrik Levkowetz 4c6ecbf303 Tweaked the authorstats backfill script's output
- Legacy-Id: 13493
2017-06-02 10:19:12 +00:00
Henrik Levkowetz 151b14ab3f Converted the meeting attendance fetcher to a management command.
- Legacy-Id: 13490
2017-06-01 20:55:40 +00:00
Henrik Levkowetz 4971c01ced Moved the fetch-meeting-registration script in order to convert it to a management command.
- Legacy-Id: 13489
2017-06-01 20:54:42 +00:00
Henrik Levkowetz d5eb59c5a6 Changed the extension filtering from using a blacklist to a whitelist, to avoid a lot of incorrect types.
- Legacy-Id: 13487
2017-06-01 20:19:38 +00:00
Henrik Levkowetz 64b9615aa7 Changed most instances of 'registrations' to 'attendees' in the meeting statistics code (as that's what the numbers show)
- Legacy-Id: 13486
2017-06-01 20:17:16 +00:00
Henrik Levkowetz b6b45166bf Added email address to the MeetingRegistration model, and also to the fields imported from ietf.org/registration/attendees/NN . Changed the bin counting code for attendee-related stats to use names plus email as unique string, rather than only names.
- Legacy-Id: 13481
2017-05-31 23:08:23 +00:00
Henrik Levkowetz a92c2b4ad5 Updated migration numbering to avoid collisions.
- Legacy-Id: 13480
2017-05-31 21:36:08 +00:00
Ole Laursen c9d7089e43 Fix tooltip on overview chart
- Legacy-Id: 13269
2017-05-05 10:49:40 +00:00
Ole Laursen 365143f615 Don't show legend on overview chart with only one unlabelled entry
- Legacy-Id: 13268
2017-05-05 10:46:49 +00:00
Ole Laursen aff12f708a Add registration country pie chart for to present at the meeting, add
meeting stats test, fix a couple of bugs
 - Legacy-Id: 13267
2017-05-05 10:33:56 +00:00
Ole Laursen a2b8819cfe Add meeting statistics - overview and country/continent across
meetings + detail pages with country and continent
 - Legacy-Id: 13264
2017-05-04 15:55:15 +00:00
Ole Laursen 8325ffa9de Add a script for keeping the meeting registration data in sync
- Legacy-Id: 13253
2017-04-28 12:33:21 +00:00
Ole Laursen f09302adb5 Merge in /branch/amsl/author-stats-r13145, with a few modifications
- Legacy-Id: 13252
2017-04-28 11:05:50 +00:00
Ryan Cross 304d04e674 Add Registration migrations
- Legacy-Id: 13184
2017-04-04 22:06:17 +00:00
Ryan Cross 7fb035c061 Add Registration models
- Legacy-Id: 13182
2017-04-03 20:36:39 +00:00