one to set how many days to include in the reviewers list, and
another one to limit the number of completed items in the list for
each person. This version replaces the one I did earlier, and includes
much more test cases to test different limits on the reviewers page.
Commit ready for merge.
- Legacy-Id: 17034
Fix#2088 - Sort unassigned review requests by doc name by default.
- Legacy-Id: 16952
Note: SVN reference [16934] has been migrated to Git commit f075eced5c
Fix#2119 - Allow specifying review type for suggested reviews in LC and telechat
If a review is suggested on the 'manage unassigned reviews' page, and
the document is in both last call and telechat, the assign form now asks
for the type of review that should be assigned.
This commit also fixes two bugs in this process:
- Comparisons in some cases between strings and integers
(group/views.py:1485/1487)
- Rejections when assigning suggested reviews, as they could be
considered a newly opened request due to not having a pk
(group/views.py:1508)
- Legacy-Id: 16951
Note: SVN reference [16933] has been migrated to Git commit ee4bc0cb07
Flipped a sense to put the grace period on the right side of 'today' when sending review overdue reminders to team secretaries. Fixes#2816.
- Legacy-Id: 16940
Note: SVN reference [16926] has been migrated to Git commit 7560e116bf
If a review is suggested on the "manage unassigned reviews" page, and
the document is in both last call and telechat, the assign form now asks
for the type of review that should be assigned.
This commit also fixes two bugs in this process:
- Comparisons in some cases between strings and integers
(group/views.py:1485/1487)
- Rejections when assigning suggested reviews, as they could be
considered a newly opened request due to not having a pk
(group/views.py:1508)
Commit ready for merge.
- Legacy-Id: 16933
Fix#2087 - Show doc authors and WG chairs in unassigned reviews views.
- Legacy-Id: 16931
Note: SVN reference [16923] has been migrated to Git commit 93797b3fc1
Fix#2118 - Always list all last call drafts in assignment summary.
If a draft is scheduled for a telechat, but also assigned for LC review,
it will now be listed both in the telechat section and under 'last calls'.
- Legacy-Id: 16913
Note: SVN reference [16904] has been migrated to Git commit 82c63b49f3
Ref #2526 - Fix test failure in [16895]
This also makes a small text clarification, which was also the initial
reason for the test failure.
- Legacy-Id: 16912
Note: SVN reference [16895] has been migrated to Git commit ef1e8006f0
Note: SVN reference [16902] has been migrated to Git commit 78a1464e77
Fix#2526 - List previous reviews in assignments email.
This includes a migration to update the database templates. Note that
not all templates currently included them (secdir at least), and
previous reviews are only listed in templates that included */** before.
As before, previous reviews are only included if they are done by the
same reviewer(s) as the current assignment.
This also fixes a bug in database template 182
(/group/defaults/email/open_assignments.txt) which referred to
r.review_request..doc.rev and r.review_request..requested_rev
in the template, and updates the test to use the current version of
template 182.
- Legacy-Id: 16911
Note: SVN reference [16895] has been migrated to Git commit ef1e8006f0
Fix#2198 - Set default start date for UnavailabilityPeriod to today.
- Legacy-Id: 16910
Note: SVN reference [16891] has been migrated to Git commit a7a2ee4a39
If a draft is scheduled for a telechat, but also assigned for LC review,
it will now be listed both in the telechat section and under "last calls".
Commit ready for merge.
- Legacy-Id: 16904
This also makes a small text clarification, which was also the initial
reason for the test failure.
Commit ready for merge.
- Legacy-Id: 16902
Note: SVN reference [16895] has been migrated to Git commit ef1e8006f0
Remove some pre-ReviewAssignment refactor logic, and simplify what remains while still allowing a group secretary to not assign a row on the unassigned requests form after touching the control to assign a reviewer. Fixes#2812.
- Legacy-Id: 16900
Note: SVN reference [16854] has been migrated to Git commit b158807134e2d26b3e013b6414b6fcbaa0e39f77
Fix#2185 - Close review assignments when reviewer is removed from team.
If a reviewer is removed from a team, any accepted or assigned review
assignments are set to rejected if the request deadline has not passed,
or set to no-response when the request deadline has passed.
Per [16819], if this scenario happens, and there are no other active or
completed review assignments, the request is shown as an
unassigned review.
- Legacy-Id: 16897
Note: SVN reference [16819] has been migrated to Git commit fdb4c2a055
Note: SVN reference [16850] has been migrated to Git commit e145832808
This includes a migration to update the database templates. Note that
not all templates currently included them (secdir at least), and
previous reviews are only listed in templates that included */** before.
As before, previous reviews are only included if they are done by the
same reviewer(s) as the current assignment.
This also fixes a bug in database template 182
(/group/defaults/email/open_assignments.txt) which referred to
r.review_request..doc.rev and r.review_request..requested_rev
in the template, and updates the test to use the current version of
template 182.
Commit ready for merge.
- Legacy-Id: 16895
Fix#2186 - Return review req to 'requested' status if no review assignments are open.
If a review assignment is rejected, withdrawn, marked no response, etc.,
and this leaves a review request without any assigned/accepted/completed
review assignments, return the request state to 'requested', which means
it will be shown as an unassigned review in all interfaces.
- Legacy-Id: 16881
Note: SVN reference [16819] has been migrated to Git commit fdb4c2a055
If a reviewer is removed from a team, any accepted or assigned review
assignments are set to rejected if the request deadline has not passed,
or set to no-response when the request deadline has passed.
Per [16819], if this scenario happens, and there are no other active or
completed review assignments, the request is shown as an
unassigned review.
Commit ready for merge.
- Legacy-Id: 16850
Note: SVN reference [16819] has been migrated to Git commit fdb4c2a055
Link to the about pages for groups even if they don't have a charter (some have other forms of descriptive text, and all have more information on the group pages than they did a few years ago). Fixes#2744.
- Legacy-Id: 16848
Note: SVN reference [16815] has been migrated to Git commit 26e3e62c567d8146a27a976f1da0710eeda46ba2
Fix#2475 - Send opt-in reminders for unconfirmed review assignments.
If enabled for a team, reminders will be sent every X days to reviewers
for review assignments they have not accepted or rejected.
- Legacy-Id: 16846
Note: SVN reference [16792] has been migrated to Git commit 486b6daa29
Refs #2277 - Send daily reminders of overdue reviews to secretaries
- Legacy-Id: 16839
Note: SVN reference [16765] has been migrated to Git commit cc64992204
Fix#2337 - Send periodic reminders of open reviews every X days (opt-in)
The interleaved_migrations_test currently fails due to the various
migrations that have been added for individual tickets/commits (unless
--permit-mixed-migrations is set). I think this is better fixed in a
later cleanup, as doing it now could cause confusion when merging
individual commits, and more migrations are likely to be added soon.
- Legacy-Id: 16823
Note: SVN reference [16705] has been migrated to Git commit ec56a03ec6
Fix#2231 - Send reminders before long UnavailabilityPeriods expire
A notification is sent to the team secretary and reviewer, if an
unavailability period lasting 30 days or more will end in 3 days.
- Legacy-Id: 16822
Note: SVN reference [16704] has been migrated to Git commit 179c151f9e
If a review assignment is rejected, withdrawn, marked no response, etc.,
and this leaves a review request without any assigned/accepted/completed
review assignments, return the request state to "requested", which means
it will be shown as an unassigned review in all interfaces.
Commit ready for merge.
- Legacy-Id: 16819
If enabled for a team, reminders will be sent every X days to reviewers
for review assignments they have not accepted or rejected.
Commit ready for merge.
- Legacy-Id: 16792
Fix#2560 - Sort names in history when changing list of members.
- Legacy-Id: 16789
Note: SVN reference [16668] has been migrated to Git commit de9cde9e43
Corrected a view that was looking at review assignment ids when it should have been looking at request review ids. Fixes#2776.
- Legacy-Id: 16708
Note: SVN reference [16647] has been migrated to Git commit 87de06c97c
The interleaved_migrations_test currently fails due to the various
migrations that have been added for individual tickets/commits (unless
--permit-mixed-migrations is set). I think this is better fixed in a
later cleanup, as doing it now could cause confusion when merging
individual commits, and more migrations are likely to be added soon.
Commit ready for merge.
- Legacy-Id: 16705
A notification is sent to the team secretary and reviewer, if an
unavailability period lasting 30 days or more will end in 3 days.
Commit ready for merge.
- Legacy-Id: 16704
Added Closing Notes to history and about pages for groups. Fixes issue #2725.
- Legacy-Id: 16586
Note: SVN reference [16559] has been migrated to Git commit 93b4d6fcc4
primary keys from character strings to integers, and makes corresponding code
changes.
This was prompted by database limitations discovered when trying to make
DocAlias use a m2m document field; with 255 long strings as primary keys for
Document and DocAlias this violated the MySQL database limitations.
Changing the primary keys to integers should also improve efficiency.
Due to the data migrations which create the new integer primary keys and adds
corresponding integer foreign keys matching the previous string foreign keys
in all tables having foreign keys to Document and DocAlias, some of these
migrations take a long time. The total set of migrations are expected to have
a runtime on the order of 2 hours.
- Legacy-Id: 16237
Remove some clutter from I-D upload page. The information was mived to the Instructions tab, but a higligh to the Note Well and BCP 78 was added. Fixes#2057.
- Legacy-Id: 16151
Note: SVN reference [16144] has been migrated to Git commit 37851b9742
Moved old nomcom announcements to database and removed references to legacy website. Fixes#2686.
- Legacy-Id: 16123
Note: SVN reference [16108] has been migrated to Git commit 26ebb022e7
Cleanup: removed the infrastructure for importing reviews from the old review tool.
- Legacy-Id: 15877
Note: SVN reference [15865] has been migrated to Git commit 87dd249415
Show more group types on the concluded groups page. Fixes#2643.
- Legacy-Id: 15871
Note: SVN reference [15828] has been migrated to Git commit ac4deed500
Make it more obvious that a group has been replaced when looking at its pages. Fixes#2661.
- Legacy-Id: 15826
Note: SVN reference [15824] has been migrated to Git commit fdf0964c40
Added an explicit ID-Exists state for the IESG state machine.
Reworked code so that the IESG state machine always has a state.
Added the ability to release a document from a working group,
research group, or the independent stream. Releasing a document
removes all stream state, and sets the document to have no stream.
- Legacy-Id: 15823
Note: SVN reference [15809] has been migrated to Git commit 6118975620
Note: SVN reference [15822] has been migrated to Git commit f6886f6105
Show counts on the active groups page and on the active wgs page. Fixes#2060.
- Legacy-Id: 15755
Note: SVN reference [15709] has been migrated to Git commit cb02df1681
Do not show reasons for review team member unavailability outside the team. Fixes#2614.
- Legacy-Id: 15732
Note: SVN reference [15683] has been migrated to Git commit 6ff552640e
Note: SVN reference [15699] has been migrated to Git commit 895aa0cfbe
in a database table:
- Added a GroupFeatures model to the group models, and removed the old
features.py
- Added a agenda type for future use in showing different group types on
different agendas.
- Renamed the group feature has_materials to has_nonsession_materials.
- Added API resources and admin support for the new tables.
- Added a Directorate (with reviews) group type as complement to
Directorate, to distinguish between directorates with and without reviews.
- Adjusted tests as needed.
- Updated the fixtures, and fixed the generate_fixtures script to include
the new AgendaTypeName objects.
There still exists about 70 instances of code comparing the group type
with a list of types; most of these should probably be replaced with new
features, instead, to make it possible to add new group types through the
database table, rather than having to edit the code. That was the purpose
of this refactoring from the start, but the presence of this large number
of comparisons of group type against lists of types defeats the goal until
we add appropriate features and replace the group type list comparisons.
- Legacy-Id: 15316
Set reply-to for I-D Announcements that include a CC to a mail list. Fixes#2530.
- Legacy-Id: 15289
Note: SVN reference [15282] has been migrated to Git commit 733c304e3d
Add the ability to add a comment to a group's history. Fixes#1483.
- Legacy-Id: 14485
Note: SVN reference [14468] has been migrated to Git commit 13e8f8982c
Treat Area Groups similar to Working Groups and Research Groups where it makes sense to do so.
- Legacy-Id: 13836
Note: SVN reference [13832] has been migrated to Git commit 2c92aa213d
Reworked how review assigments are processed in order to ensure a team's queue rotates when it should. Fixes#2305.
- Legacy-Id: 13743
Note: SVN reference [13731] has been migrated to Git commit 7f5cef056ade1641f1d815b0a5f35962077d6d01
Add an expertise field to reviewer settings. Fixes#2308. ,
- Legacy-Id: 13539
Note: SVN reference [13532] has been migrated to Git commit d845fba8bec765f2f81ae1a4bbca52c9bceb6e02
Provide assigned dates on review team reviewers page. Fixes#2304. Related to #2305.
- Legacy-Id: 13518
Note: SVN reference [13500] has been migrated to Git commit e422717f91eb26a0691347beca9380889d8ee890
intended to make it easier to see that you can edit things like the
external/additional URLs:
- Added the ability to edit individual fields in a group's about page, and
added edit buttons for editable fields on the about page, just as for
documents (the ability to edit all editable fields already was available
from the 'Edit group' button on the /group//about/ page).
- Made the tab label for the group-about tab consistently say 'About',
instead of 'Charter' for some groups.
= Shifted the position of the about tab to the start of the tab line.
- Removed the datatracker account requirement information at the top of the
group edit page for users logged in to their account.
- Tweaked the 'Show update' link on the 'Status Update' line.
- Changed the label for the external URLs from 'More Info' to 'Additional
URLs', which was already in use on the edit form.
- Legacy-Id: 12904
in order to autogenerate dotted path url pattern names. Updated a number
of url reverses to use dotted path, and removed explicit url pattern names
as needed.
Changed some imports to prevent import of ietf.urls before django
initialization was complete.
Changed 3 cases of form classes being curried to functions; django 1.10
didn't accept that.
Started converting old-style middleware classes to new-style middleware
functions (incomplete).
Tweaked a nomcom decorator to preserve function names and attributes, like
a good decorator should.
Replaced the removed django templatetag 'removetags' with our own version
which uses bleach, and does sanitizing in addition to removing explicitly
mentionied html tags.
Rewrote the filename argument handling in a management command which had
broken with the upgrade.
- Legacy-Id: 12818
Added programs to the datatracker. Added use of restructuredtext for group about pages. Generalized several places where code handles different group types. Improved testing of group about.
- Legacy-Id: 12725
Note: SVN reference [12722] has been migrated to Git commit e0ea8b0f57
Restrict editing ReviewSettings.skip_next to team secretaries and the secretariat. Improve validation of skip_next value. Fixes#2149.
- Legacy-Id: 12710
Note: SVN reference [12706] has been migrated to Git commit 518f7a1d65
Removed some unnecessary randomness in tests introduced in last commit.
- Legacy-Id: 12678
Note: SVN reference [12675] has been migrated to Git commit 4f2f691de6
Make changing skip_next on a review assignment an explicit decision of the assigner. Fixes#2148.
- Legacy-Id: 12671
Note: SVN reference [12670] has been migrated to Git commit 8e007ce50b
Make it easier to see who's really next in reviewer rotation.
- Legacy-Id: 12668
Note: SVN reference [12665] has been migrated to Git commit 49dcf67fd5
Save a new reviewrequest for each team requested in the request form. Fixes#2094.
- Legacy-Id: 12491
Note: SVN reference [12489] has been migrated to Git commit 4fff1ab101e4f7cd27dc8ded889e09905866076f
Improves control of email headers for review summary messages. Provides team-specific templates for review summary messages. Fixes#2092 and #2082.
- Legacy-Id: 12483
Note: SVN reference [12482] has been migrated to Git commit 06179c7485dac6c69b2aa30e66095a23a4460209
and instead provide more information about each document to be
reviewed, to help the secretaries determine locally on that page what
action to take. The new layout should also make it easier to fit in
more info, in case it is still found lacking.
The public review request page still provides the previous information
in the summarized tabular form, so the overview can be found there.
- Legacy-Id: 12278
unassigned requests to make it easier to just work with the unassigned
ones. Use same split on the manage reviews page which is now two
pages.
- Legacy-Id: 12266
review test code use a separate reviewer and reviewsecretary user to
avoid confounding things - also let these use Unicode in their names
to check for Unicode trouble.
- Legacy-Id: 12175
review types so that teams will only have those review types
listed and suggested that they are configured to have.
Fix a couple of things in the importer after having tested it on all
the databases. Set unavailable end date >= 2020 to indefinite.
Fix a couple of bugs.
- Legacy-Id: 12095
requests for a given set of teams/reviewers (making it trivial to
compute statistics), revamp the related doc event code to support this
by referencing the review request directly, add a reviewer overview
page with recent performance for each reviewer as well as
settings/unavailable periods. Fix some bugs and shuffle some of the
review code a bit around.
Finish the importer from the previous Perl-based review tool,
importing log entries, figuring out whether a given review is
early/telechat/last call and fixing corner cases.
- Legacy-Id: 12080
relying on when they last reviewed. In-order assignments automatically
move the rotation forwards while out-of-order assignments increment
the skip next of the assigned reviewer. Include rotation in open
review assignments email. Fix a couple of issues in the importer.
- Legacy-Id: 12015
editing button, reverse sort order so latest (and probably most
interesting) is at the top, disable save buttons when there are no
changes to save
- Legacy-Id: 11843
There were multiple different regex patterns in different urlpattern
declarations, with some of them permitting characters which should not
occur in group acronym. Changed them to consistently use [-a-z0-9]+ .
- Legacy-Id: 11651
specific close reasons to the database migration, add
ReviewRequest.requested_by so it's possible to notify the requester of
a review that it has been dropped.
- Legacy-Id: 11520
review requests page.
Add importer for importing review data from the existing Perl tool
(WIP, gets most but not all of the interesting information out).
Fix various bugs.
- Legacy-Id: 11508
Added validation for the dependency graph output type (one of 'dot', 'pdf', 'svg'). Added an area column to the directorate summary page.
Commit fixes bug #1887, fixes bug #1940.
- Legacy-Id: 11095
Note: SVN reference [11085] has been migrated to Git commit b46081f514
page. Each WG/RG now gets a list with an initial set of rules to
populate the list.
Refine the community list management interface a bit to support the
group lists better - group lists aren't connected to the usual track
icons so need to be able to add/remove individual drafts.
Change the "name contains" rule to support regular expressions to
enable each group to have a default replacement for the previously
implemented "related documents" search. Maintain a materialized view
of the regexp-matched drafts with a call in the submit code to avoid
having to scan all drafts/~1000 group rules all the time.
- Legacy-Id: 10963
Restrict related documents included in the 1wg-charter* views to those that update or obsolete WG produced RFCs.
- Legacy-Id: 10935
Note: SVN reference [10932] has been migrated to Git commit d654610393
Remove the day/seq urls from the materials tree.
Allow sessionpresentation.rev to be None, meaning "current version".
Streamlined workflows to focus on current versions of a draft as a default.
Allow adding and editing sessionpresentations when looking at a specific document.
Allow adding drafts when looking at a specific session.
Add the meeting tab to 'team' groups.
Refactored several utility classes and expanded on factories.
Fixes#1908 and #1910.
Commit ready for merge.
- Legacy-Id: 10856
Integrated the group meetings tab with the secretariat meeting request and meeting materials pages.
Made better use of bootstrap styling for the meetings tab and session details view.
Commit ready for merge.
- Legacy-Id: 10779
