Commit graph

898 commits

Author SHA1 Message Date
Jennifer Richards 56505147e0
fix: handle timezones in a bunch of places 2022-09-23 16:11:49 -03:00
Jennifer Richards 1366b6de38
Merge branch 'feat/tzaware' into jennifer/main-to-tzaware-conflicts 2022-09-14 12:36:33 -03:00
Lars Eggert 79bf320acc
fix: Only show ADs when assigning ADs for groups (#4440)
* fix: Only show ADs when assigning ADs for groups

Fixes #4302

* Fix test failure
2022-09-13 09:54:12 -05:00
Jennifer Richards 32054111df
fix: fix failing tests and eliminate naive datetime warnings (#4402)
* test: fix timestamp construction in several doc tests

* refactor: rename date2datetime to datetime_from_date and clarify code

* chore: helper to get tzinfo for PRODUCTION_TIMEZONE

* fix: fix timezone handling in make_last_call()

* test: fix datetime generation in doc.tests_charter

* refactor: remove PRODUCTION_TIMEZONE setting

Replaces the PRODUCTION_TIMEZONE setting with a constant,
DEADLINE_TZINFO, in ietf.utils.timezone.

* test: be more careful about timezone in tests_charter.py

* test: be more careful about timezone in doc/tests.py

* fix: fix timezone handling affecting doc.tests_draft

* fix: fix timezone handling affecting tests_irsg_ballot.py

* fix: fix timezone handling affecting tests_review.py

* fix: fix timezone handling affecting last ietf.doc tests

* fix: fix timezone handling affecting last ietf.group tests

* fix: fix timezone handling affecting ietf.iesg tests

* fix: handle timezones in get_8989_eligibility_querysets

* fix: handle timezones affecting ietfauth tests

* fix: return tz-aware datetime from utc_from_string

* fix: specify timezone for constants in ipr_rfc_number()

* fix: specify tz for ipr deadlines

* fix: handle timezones affecting liaisons tests

* fix: treat leap day in get_8989_eligibility_querysets()

Manual cherry-pick of 248d6474

* test: treat leap day properly in nomcom tests

* fix: fix timezone handling affecting nomcom tests

* test: fix timezone handling in review tests

* fix: fix timezone handling affecting secr.meetings tests

* fix: handle both pytz and zoneinfo timezones in ietf.utils.timezone

* fix: fix timezone handling affecting secr.proceedings tests

* refactor: use make_aware() helper in secr.meetings tests

* test: fix timezone handling in secr.telechat tests

* fix: fix timezone handling affecting stats tests

* fix: eliminate tz-naive helpers affecting sync email parsing

* fix: include timezone data when serializing DeletedEvent data

* fix: fix timezone handling affecting sync tests

* style: remove unused import
2022-09-01 13:07:28 -03:00
Robert Sparks 795415e673
fix: generate aliases for rfcedtyp groups. Fixes #4362. (#4374) 2022-08-29 17:52:59 -05:00
Jennifer Richards 8b52d27b02
refactor: refactor timestamp handling so tests in meeting app pass (#4371)
* refactor: replace datetime.now with timezone.now

* refactor: migrate model fields to use timezone.now as default

* refactor: replace datetime.today with timezone.now

datetime.datetime.today() is equivalent to datetime.datetime.now(); both
return a naive datetime with the current local time.

* refactor: rephrase datetime.now(tz) as timezone.now().astimezone(tz)

This is effectively the same, but is less likely to encourage accidental
use of naive datetimes.

* refactor: revert datetime.today() change to old migrations

* refactor: change a missed datetime.now to timezone.now

* chore: renumber timezone_now migration

* chore: add migration to change timestamps to UTC

* refactor: move tz instantiation/caching from TimeSlot to Meeting

* fix: assume utc if meeting.time_zone is blank

* chore: make datetime.combine() calls tz aware in the meeting app

* ci: correctly use meeting.tz in TimeSlotFactory

* chore: compute TimeSlot utc / local times assuming tz-aware times

* chore: use tzaware math for agenda editor timeslot layout

* chore: fill in Meeting.time_zone where it is blank

Nearly all interim meetings on or before 2016-07-01 have blank
time_zone values. This migration fills these in with PST8PDT.

* chore: disallow blank Meeting.time_zone value

* refactor: no need to handle blank time_zone case in TZ migration

* refactor: remove now-unnecessary checks that meeting has time_zone

* chore: fix timezone handling in agenda.ics and Meeting.updated()

* chore: fix tz handling in interim_request_details, exercise in tests

* chore: fix timezone handling for test_interim_send_announcement

* chore: fix timezone handling in agenda_json()

* chore: fix timezone handling in old agenda

* chore: fix timezone handling for EditTimeslotsTests

* refactor: refactor a few fixes for more consistent timezone handling

* chore: add timezone info to timestamps in fixtures

* chore: remove naive datetime warnings found in meetings.tests_views

* chore: fix a few more test failures in meetings.tests_views

All tests in meetings.tests_views now passing

* chore: remove unused import

* chore: fix timezone handling in test_schedule_generator.py

* chore: fix timezone handling affecting meeting.tests_js

* chore: fix timeslot test bug when local date != UTC date

* test: fix a few failing tests, all meetings tests now pass

(for me, anyway)

* chore: renumber migrations

* chore: update timestamp conversion migration

The django-celery-beat package introduces tables with timestamp
columns. These columns are stored in CELERY_TIMEZONE. Because we run with
this set to UTC, the migration ignores these columns.

* chore: fix pytz-related change in migration

* chore: remove duplicate migrations

* chore: remove CELERY_BEAT_TZ_AWARE setting now that USE_TZ is True

* test: avoid failure in test with bogus timezone
2022-08-26 16:53:19 -03:00
Jennifer Richards ebebdbed3e
refactor: replace datetime.now and datetime.today with timezone.now (#4211)
* refactor: replace datetime.now with timezone.now

* refactor: migrate model fields to use timezone.now as default

* refactor: replace datetime.today with timezone.now

datetime.datetime.today() is equivalent to datetime.datetime.now(); both
return a naive datetime with the current local time.

* refactor: rephrase datetime.now(tz) as timezone.now().astimezone(tz)

This is effectively the same, but is less likely to encourage accidental
use of naive datetimes.

* refactor: revert datetime.today() change to old migrations

* refactor: change a missed datetime.now to timezone.now

* chore: renumber timezone_now migration

* chore: renumber migrations
2022-08-25 13:45:16 -03:00
Valery Smyslov a5f27b0a5b
feat: show expired WG/RG drafts at WG/RG Documents page (#4252)
* Show expired WG/RG drafts.

* Update 0009_add_group_exp_rule_to_groups.py

fix dependency on migration file name

* Update forms.py

Simplify condition statements

* Update views.py

Fix - remove erroneous check (never happen)

* Added tests for expired WG drafts filtering rule
2022-07-26 12:02:09 -05:00
Lars Eggert e465f1f0f0
feat: Replace graphviz with d3 (#4067)
* feat: Use d3 for doc dependencies

* Interim commit

* Progress

* Progress

* Auto pan and zoom

* Arrows

* Remove graphviz and the code that uses it

* More graphviz-related changes

* Interim commit

* Move things into place

* Add test

* Final touches

* Make SVG work in Chrome

* Get the docs more similarly to how the group doc page does it

* Reindent

* Add ability to download the SVG, and use bs fonts.

* Follow @rjsparks' advice on how to compute the reference list

* Interim commit

* Add legend

* Speed up simulation

* Fix tooltips

* fix: escape a period in a new url regex

Co-authored-by: Robert Sparks <rjsparks@nostrum.com>
2022-07-21 12:14:45 -05:00
Robert Sparks 9d10fb7dd1
fix: correct botched file rename (#4222) 2022-07-15 16:14:44 -05:00
Robert Sparks fccee05aee
fix: add missing field alteration (#4220) 2022-07-15 14:35:37 -05:00
Robert Sparks 6ed4ea0f93
feat: point to Zulip chat rather than jabber. (#4218)
* feat: point to Zulip chat rather than jabber.

* fix: Address review comments from Jennifer and Nick
2022-07-15 13:48:54 -05:00
Jennifer Richards 4f34c0478e
fix: Authorize interim session requests using data-driven group roles (#4120)
* fix: only use non-empty Q object as interim group filter

* refactor: add with_meetings queryset to GroupManager

* test: users can only request interims for managed groups

* fix: find managed groups from groupman_roles/authroles

* feat: let chair manage directorate groups

* test: remove debug statements and unused imports

* test: remove do-nothing code from test
2022-06-22 14:00:44 -05:00
Jennifer Richards c2fb5e5b66
fix: Group.used_roles overrides default_used_roles (#4118) 2022-06-22 11:17:48 -05:00
Lars Eggert 86e548c952
chore: remove ietf/group/colors.py, which is unused (#4100)
* chore: remove ietf/group/colors.py, which is unused

* Rip out more
2022-06-20 10:31:20 -05:00
Jennifer Richards 53dde975ec
fix: validate group type/acronym properly in admin. Fixes #4028. (#4070)
* fix: validate group type/acronym properly in admin

* chore: remove unused import
2022-06-13 11:14:26 -05:00
Robert Sparks 2f4b493575
fix: Don't show To Subscribe on group about when there's no url to subscribe with. Fixes #4022. (#4023) 2022-05-25 14:52:44 -05:00
Robert Sparks c89f7c89c5
feat: begin supporting the new rfc editor model (#3960)
* feat: restructure rfcedtype groups. add rpc, rswg, rsab.

* feat: show rfc editor groups on menu

* feat: add the editorial stream

* fix: repair broken html and extent dest coverage.

* chore: address Lars review comment

* chore: update copyright notices.
2022-05-20 12:22:17 -05:00
Lars Eggert de7ff7e84e
test: fix more validation issues (#3975)
* fix: Avoid numeric IDs on NomCom pages

* fix: Correctly group last names with lowercase/i18n parts

* Remove some unneeded CSS

* fix: Remove extra div closing tag
2022-05-18 10:58:39 -05:00
Lars Eggert 5598762608
fix: add more HTML validation & fixes (#3891)
* Update vnu.jar

* Fix py2 -> py3 issue

* Run pyupgrade

* test: Add default-jdk to images

* test: Add option to also validate HTML with vnu.jar

Since it's already installed in bin. Don't do this by default, since it
increases the time needed for tests by ~50%.

* fix: Stop the urlizer from urlizing in linkified mailto: text

* More HTML fixes

* More HTML validation fixes

* And more HTML fixes

* Fix floating badge

* Ignore unicode errors

* Only URLize docs that are existing

* Final fixes

* Don't URLize everything during test-crawl

* Feed HTML into vnu using python rather than Java to speed things up

* Allow test-crawl to start vnu on a different port

* Increase retry count to vnu. Restore batch size to 30.

* More HTML validation fixes

* Use urllib3 to make requests to vnu, since overriding requests_mock is tricky

* Undo commit of unmodified file

* Also urlize ftp links

* Fix matching of file name

* More HTML fixes

* Add `is_valid_url` filter

* weekday -> data-weekday

* urlencode URLs

* Add and use vnu_fmt_message. Bump vnu max buffer.

* Simplify doc_exists

* Don't add tab link to mail archive if the URL is invalid

* Run urlize_ietf_docs before linkify

Reduces the possibility of generating incorrect HTML

* Undo superfluous change

* Runner fixes

* Consolidate vnu message filtering into vnu_filter_message

* Correctly handle multiple persons with same name

* Minimze diff

* Fix HTML nits

* Print source snippet in vnu_fmt_message

* Only escape if there is something to escape

* Fix snippet

* Skip crufty old IPR declarations

* Only include modal when needed. Add handles.

* Fix wordwrap+linkification

* Update ietf/doc/templatetags/ietf_filters.py

* Update ietf/doc/templatetags/tests_ietf_filters.py

* Don't right-align second column
2022-05-03 13:55:48 -05:00
Lars Eggert f98cb8a4cd
fix: No need to escape here (#3806) 2022-04-12 11:27:52 -03:00
Lars Eggert 3234f1a121
test: Validate HTML rendered during tests (#3782) 2022-04-07 13:30:38 -03:00
Robert Sparks 38883e506f
fix: enable delegation for many group types. (#3753)
fixes #3740
2022-03-25 13:56:49 -03:00
Lars Eggert eb5423d084
ci: Also check generated HTML with the "vnu" validator (#3682)
* ci: Also check generated HTML with the "vnu" validator

Because HTML Tidy apparently misses a bunch of errors.

* thead -> tbody

* More fixes

* More fixes

* Start checker in test runner
2022-03-21 12:50:23 -05:00
Jennifer Richards 686a9150b3 Merge remote-tracking branch 'origin/main' into personal/jennifer/7.45.1.dev0.bootstrap-merge
# Conflicts:
#	ietf/templates/meeting/session_buttons_include.html
2022-03-04 15:14:52 -04:00
Robert Sparks 6968252afb Merged in [19987] from rjsparks@nostrum.com:
Change generated draft/group alias/virtual file permissions.
 - Legacy-Id: 19988
Note: SVN reference [19987] has been migrated to Git commit 8deca64b31d95dc1f9c77eea6e7fe66f4c0e0f06
2022-02-24 19:59:09 +00:00
Robert Sparks 7e17801b57 Use shutil.move when building draft and group aliases. Commit ready for merge.
- Legacy-Id: 19950
2022-02-18 17:25:17 +00:00
Robert Sparks d6298adacb Use tempfiles while rebuilding group and doc alias files. Fixes #3521. Commit ready for merge.
- Legacy-Id: 19949
2022-02-18 16:27:00 +00:00
Jennifer Richards 6c260a5b7e Merge 7.45.1.dev0 into Bootstrap 5 update branch. Made a first pass at reconciling differences.
- Legacy-Id: 19945
2022-02-17 20:09:49 +00:00
Lars Eggert 335a39d4fc More fixes.
- Legacy-Id: 19884
2022-01-28 13:00:47 +00:00
Lars Eggert cf629a42ad And more fixes.
- Legacy-Id: 19877
2022-01-25 10:14:25 +00:00
Lars Eggert 0bfaa63722 More fixes.
- Legacy-Id: 19855
2022-01-17 15:05:22 +00:00
Jennifer Richards 6df0377fa1 Fix several review reminder problems.
Send secretary's review reminders to secretary instead of assignee. 
Send unconfirmed assignment reminders based on assignment age and CC secretaries. 
Correctly separate open review reminders by review team.

Fixes #3482. Fixes #3324. Commit ready for merge.
 - Legacy-Id: 19848
2022-01-14 19:14:06 +00:00
Jennifer Richards d4dbb1bc1f Allow editing of group non-chartered group descriptions through UI. Fixes #3388. Commit ready for merge.
- Legacy-Id: 19838
2022-01-12 21:04:13 +00:00
Lars Eggert a5cbf5307e More fixes
- Legacy-Id: 19835
2022-01-12 11:54:00 +00:00
Lars Eggert 6ca6c35186 More fixes.
- Legacy-Id: 19829
2022-01-11 15:02:27 +00:00
Lars Eggert 8bc7fde027 More fixes.
- Legacy-Id: 19828
2022-01-11 07:02:39 +00:00
Lars Eggert 5132661b06 More test fixes
- Legacy-Id: 19803
2022-01-05 11:25:25 +00:00
Lars Eggert 7f918b00da More test fixes
- Legacy-Id: 19784
2021-12-15 20:38:28 +00:00
Lars Eggert c68446ae93 More select2 and test fixes.
- Legacy-Id: 19781
2021-12-14 18:19:12 +00:00
Lars Eggert e9fd78128c Interim commit
- Legacy-Id: 19765
2021-12-09 18:26:53 +00:00
Jennifer Richards fd0df6f619 Add ability to import session minutes from notes.ietf.org. Mock out calls to the requests library in tests. Call markdown library through a util method. Fixes #3489. Commit ready for merge.
- Legacy-Id: 19763
2021-12-09 17:16:19 +00:00
Lars Eggert f974fd3c04 Fix more things
- Legacy-Id: 19762
2021-12-09 06:41:00 +00:00
Jennifer Richards 8759955597 Allow nomcom chair to edit liaisons as well as members and generate GroupEvents when changed. Share code between group and nomcom for this purpose. Fixes #3376. Commit ready for merge.
- Legacy-Id: 19710
2021-11-24 16:40:05 +00:00
Lars Eggert 333d1c40ac Merge ^/personal/lars/7.39.1.dev3
- Legacy-Id: 19649
2021-11-12 11:55:55 +00:00
Jennifer Richards 9e7cb302f7 Update groupfeatures_session_purposes field migration to match change to model. Commit ready for merge.
- Legacy-Id: 19636
2021-11-11 16:29:02 +00:00
Lars Eggert dec56ffb96 Merge my bs5 changes over.
There is definitely still quite some breakage, my main focus during
the conflict resolution was not to drop any changes made by others.
 - Legacy-Id: 19632
2021-11-11 13:09:23 +00:00
Lars Eggert bb5810a934 Labels are badges in bs5.
- Legacy-Id: 19616
2021-11-10 11:15:46 +00:00
Jennifer Richards 83f5c7e9b6 Remove "before" versions of migrations that were renumbered during merge
- Legacy-Id: 19595
2021-11-09 18:03:06 +00:00
Jennifer Richards 0706f8519f Update migrations and fix a few failing tests. Branch ready for merge.
- Legacy-Id: 19571
2021-11-09 02:40:54 +00:00
Jennifer Richards bcd37edfcd Merged from session_purpose_dev
Create dev branch for session purpose work (from revision [19414])
Snapshot of dev work to add session purpose annotation (from revision [19415])
Allow non-WG-like groups to request additional sessions/durations and bypass approval (from revision [19424])
Add 'closed' session purpose, assign purposes for nomcom groups, and update schedule editor to enforce timeslot type and allow blurring sessions by purpose (from revision [19427])
Add management command to set up timeslots/sessions for testing/demoing 'purpose' field (from revision [19430])
Update session purposes and group type -> purpose map to match notes page, change 'session' purpose to 'regular' (from revision [19433])
Redirect edit_schedule urls to edit_meeting_schedule view (from revision [19434])
Allow hiding/blurring sessions and timeslots based on TimeSlotType in the schedule editor (from revision [19438])
Disable session purpose/timeslot type hiding on schedule editor when only 0 or 1 options (from revision [19439])
Improvements to the timeslot and schedule editors (move new toggles to modals, handle overflowing session names, fix timeslot editor scrolling, add buttons to quickly create single timeslot, accept trailing slash on edit URL) (from revision [19449])
Update purpose/types after discussions, add on_agenda Session field, prevent session requests for groups with no allowed purpose, handle addition fields in session request, fix editing session requests, add session edit form/access from schedule editor, eliminate TimeSlotTypeName "private" field, add server-side timeslot type filtering to schedule editor (from revision [19549])
Eliminate the officehours timeslot type, update/renumber migrations, mark offagenda/reserved TimeSlotTypeNames as not used, add a 'none' SessionPurposeName and disallow null, update agenda filter keywords/filter helpers, fix broken tests and general debugging (from revision [19550])
Tear out old meeting schedule editor and related code (from revision [19551])
Fix merge errors in preceding commits (from revision [19556])
 - Legacy-Id: 19570
Note: SVN reference [19415] has been migrated to Git commit 1054f90873

Note: SVN reference [19424] has been migrated to Git commit 5318081608

Note: SVN reference [19427] has been migrated to Git commit 173e438aee

Note: SVN reference [19430] has been migrated to Git commit 7a2530a0a6

Note: SVN reference [19433] has been migrated to Git commit 3be50d6e39

Note: SVN reference [19434] has been migrated to Git commit 3e3d681e5f

Note: SVN reference [19438] has been migrated to Git commit b6ac3d4b1d

Note: SVN reference [19439] has been migrated to Git commit 446ac7a47e

Note: SVN reference [19449] has been migrated to Git commit 5cbe402036

Note: SVN reference [19549] has been migrated to Git commit 3dfce7b850

Note: SVN reference [19550] has been migrated to Git commit 7b35c09c40

Note: SVN reference [19551] has been migrated to Git commit d7f20342b6

Note: SVN reference [19556] has been migrated to Git commit 2b1864f5a0
2021-11-09 01:35:25 +00:00
Robert Sparks 5c28a85cf1 Merged in [19555] from jennifer@painless-security.com:
Use temporary directories instead of 'real' filesystem for tests. Fixes #3414.
 - Legacy-Id: 19561
Note: SVN reference [19555] has been migrated to Git commit 81d9234d54
2021-11-08 18:16:56 +00:00
Jennifer Richards 81d9234d54 Use temporary directories instead of "real" filesystem for tests. Fixes #3414. Commit ready for merge.
- Legacy-Id: 19555
2021-11-05 19:45:57 +00:00
Jennifer Richards d7f20342b6 Tear out old meeting schedule editor and related code
- Legacy-Id: 19551
2021-11-04 17:07:22 +00:00
Jennifer Richards 7b35c09c40 Eliminate the officehours timeslot type, update/renumber migrations, mark offagenda/reserved TimeSlotTypeNames as not used, add a 'none' SessionPurposeName and disallow null, update agenda filter keywords/filter helpers, fix broken tests and general debugging
- Legacy-Id: 19550
2021-11-04 17:06:06 +00:00
Jennifer Richards 3dfce7b850 Update purpose/types after discussions, add on_agenda Session field, prevent session requests for groups with no allowed purpose, handle addition fields in session request, fix editing session requests, add session edit form/access from schedule editor, eliminate TimeSlotTypeName "private" field, add server-side timeslot type filtering to schedule editor
- Legacy-Id: 19549
2021-11-04 17:01:32 +00:00
Robert Sparks 59597794b7 Merged in [19432] from lars@eggert.org:
Fix things that selenium deprecated in version 4.
 - Legacy-Id: 19504
Note: SVN reference [19432] has been migrated to Git commit 715b0949cc
2021-10-29 19:53:37 +00:00
Robert Sparks e32f3828d1 Merged in [19422] from rjsparks@nostrum.com:
Update internal references to trac.tools.ietf.org to point to trac.ietf.org. Remove several links into tools.ietf.org.
 - Legacy-Id: 19443
Note: SVN reference [19422] has been migrated to Git commit cd748cd760
2021-10-19 19:03:59 +00:00
Robert Sparks c5966052fd Merged in [19401] from mark@painless-security.com:
Add a new Django field, IETFJSONField
This field is needed because the plain JSONField does not permit empty arrays - [] - or empty objects - {} - when the field is marked as required.  Those values explicitly evaluate to a null value, and are rejected.
Instead, the IETFJSONField accepts two new arguments to control this:
- empty_values: An array of values that should evaluate to null/empty, and be rejected.
- accepted_empty_values: An array of values that should *not* evaluate to null/empty, and be accepted.
This allows the programmer to specify either a positive or negative statement of what values to accept.
Fixes issue #3331.
 - Legacy-Id: 19440
Note: SVN reference [19401] has been migrated to Git commit 604d6edef0
2021-10-19 18:42:09 +00:00
Jennifer Richards 3be50d6e39 Update session purposes and group type -> purpose map to match notes page, change 'session' purpose to 'regular'
- Legacy-Id: 19433
2021-10-18 14:48:36 +00:00
Jennifer Richards 173e438aee Add 'closed' session purpose, assign purposes for nomcom groups, and update schedule editor to enforce timeslot type and allow blurring sessions by purpose
- Legacy-Id: 19427
2021-10-15 19:33:33 +00:00
Robert Sparks cd748cd760 Update internal references to trac.tools.ietf.org to point to trac.ietf.org. Remove several links into tools.ietf.org. Commit ready for merge.
- Legacy-Id: 19422
2021-10-13 21:43:44 +00:00
Jennifer Richards 1054f90873 Snapshot of dev work to add session purpose annotation
- Legacy-Id: 19415
2021-10-12 17:08:58 +00:00
Mark J. Donnelly 604d6edef0 Add a new Django field, IETFJSONField
This field is needed because the plain JSONField does not permit empty arrays - [] - or empty objects - {} - when the field is marked as required.  Those values explicitly evaluate to a null value, and are rejected.

Instead, the IETFJSONField accepts two new arguments to control this:
- empty_values: An array of values that should evaluate to null/empty, and be rejected.
- accepted_empty_values: An array of values that should *not* evaluate to null/empty, and be accepted.

This allows the programmer to specify either a positive or negative statement of what values to accept.

Fixes issue #3331.  Commit ready for merge.
 - Legacy-Id: 19401
2021-10-07 19:30:51 +00:00
Robert Sparks d7841409ca Provide a page that shows how current charter text renders through markdown. Related to #2695. Commit ready for merge.
- Legacy-Id: 19357
2021-09-08 16:47:47 +00:00
Robert Sparks f3a433672a Merged in [19316] from rjsparks@nostrum.com:
Adjust groupfeatures has_session_materials to match modern usage. Adjusted proceedings and materials templates to show fewer unnecessary duplicates. Fixes #2981 and #3387.
 - Legacy-Id: 19335
Note: SVN reference [19316] has been migrated to Git commit d4899b78f9
2021-09-04 15:01:38 +00:00
Robert Sparks cecf079139 Merged in [19315] from rjsparks@nostrum.com:
Restore ADs ability to charter new groups. Fixes #3397. ,
 - Legacy-Id: 19334
Note: SVN reference [19315] has been migrated to Git commit 311b4728e1
2021-09-04 03:21:32 +00:00
Robert Sparks 333173271d Merged in [19313] from rjsparks@nostrum.com:
Show new group types on active groups page, but see #3393.
 - Legacy-Id: 19333
Note: SVN reference [19313] has been migrated to Git commit aeff343eee
2021-09-04 03:01:33 +00:00
Robert Sparks 0ebccd4583 Merged in [19311] from rjsparks@nostrum.com:
Adjust tests and forms to match changes to permissions made in through the admin. These need to use the data rather than the code. See #3393.
 - Legacy-Id: 19331
Note: SVN reference [19311] has been migrated to Git commit 4240ce088e
2021-09-03 22:08:07 +00:00
Robert Sparks c8552cbb55 Merged in [19310] from rjsparks@nostrum.com:
Add IETF Administrative LLC groups. Fixes #3302.
 - Legacy-Id: 19330
Note: SVN reference [19310] has been migrated to Git commit 847f37dbf7
2021-09-03 22:06:12 +00:00
Robert Sparks ff5707b5f0 Merged in [19307] from rjsparks@nostrum.com:
Add IAB Administrative Support Group group type. Add IAB groups to the group menu. Clearly delineate group types in the group menu. Fixes #3295 and #3296.
 - Legacy-Id: 19328
Note: SVN reference [19307] has been migrated to Git commit d42730300a
2021-09-03 21:29:12 +00:00
Robert Sparks d4899b78f9 Adjust groupfeatures has_session_materials to match modern usage. Adjusted proceedings and materials templates to show fewer unnecessary duplicates. Fixes #2981 and #3387. Commit ready for merge.
- Legacy-Id: 19316
2021-09-03 15:14:06 +00:00
Robert Sparks 311b4728e1 Restore ADs ability to charter new groups. Fixes #3397. Commit ready for merge,
- Legacy-Id: 19315
2021-09-02 23:25:36 +00:00
Robert Sparks aeff343eee Show new group types on active groups page, but see #3393. Commit ready for merge.
- Legacy-Id: 19313
2021-09-01 15:54:25 +00:00
Robert Sparks 4240ce088e Adjust tests to match changes to permissions made in through the admin. These need to use the data rather than the code. See #3393. Commit ready for merge.
- Legacy-Id: 19311
2021-09-01 14:30:09 +00:00
Robert Sparks 847f37dbf7 Add IETF Administrative LLC groups. Fixes #3302. Commit ready for merge.
- Legacy-Id: 19310
2021-08-31 22:13:38 +00:00
Robert Sparks d42730300a Add IAB Administrative Support Group group type. Add IAB groups to the group menu. Clearly delineate group types in the group menu. Fixes #3295 and #3296. Commit ready for merge.
- Legacy-Id: 19307
2021-08-30 19:39:21 +00:00
Jennifer Richards 2060173f3a Improve proceedings display with new title block, configurable host logos, and additional PDF or URL materials. Fixes #3147. Commit ready for merge.
- Legacy-Id: 19306
2021-08-30 17:02:49 +00:00
Robert Sparks 62a3a4fe41 Restrict group creation to the secretariat. Commit ready to merge.
- Legacy-Id: 19277
2021-08-05 14:56:28 +00:00
Robert Sparks f3b72e4bc1 Improve tests that look person names in responses. Commit ready for merge.
- Legacy-Id: 19271
2021-08-04 14:46:11 +00:00
Robert Sparks b99eecc1ae Bring the factory-boy and Faker dependencies forward through some minor breaking changes. Stop using the deprecated fr_QC locale in Faker. Commit ready for merge.
- Legacy-Id: 19270
2021-08-03 22:22:35 +00:00
Robert Sparks a29480703f Changed implementation of can_manage_all_groups_of_type to use GroupFeatures.groupman_authroles. Commit ready for merge.
- Legacy-Id: 19259
2021-07-22 19:29:50 +00:00
Robert Sparks 359889c1f7 Changed the signature of can_manage_all_groups_of_type to only take a type_id. Removed the logic that tried to distinguish permissions for teams by parent - that should be modeled as separate type_ids instead. Commit ready for merge.
- Legacy-Id: 19258
2021-07-22 18:34:57 +00:00
Robert Sparks 7ede0942d0 Rename ietf.group.utils.can_manage_group_type to can_manage_all_groups_of_type to improve code readability where it is used. Commit ready for merge.
- Legacy-Id: 19256
2021-07-22 18:05:06 +00:00
Robert Sparks c01fea3920 Show groupman_authroles in the GroupFeatures admin list. Commit ready for merge.
- Legacy-Id: 19254
2021-07-21 20:10:30 +00:00
Robert Sparks 84717102b0 Add BOF Requests to the datatracker. Commit ready for merge.
- Legacy-Id: 19228
2021-07-15 20:15:54 +00:00
Robert Sparks 62c364899c Guard a sort that gets a mix of integers and None. Commit ready for merge.
- Legacy-Id: 19224
2021-07-15 16:28:15 +00:00
Robert Sparks 805d1f4a7e Use BOF consistently.
- Legacy-Id: 19212
2021-07-14 17:33:14 +00:00
Robert Sparks f5a04263e5 Added the notion of responsible leadership.
- Legacy-Id: 19202
2021-07-07 17:49:35 +00:00
Robert Sparks d61e26567d Scroll to buttons before clicking on them in Selenium tests. Fixes #3314. Commit ready for merge.
- Legacy-Id: 19153
2021-06-24 16:39:36 +00:00
Robert Sparks a32d00af0a When removing reviewers from a review team, change the state of only that team's assignments. Check to make sure the person being removed doesn't have another reviewer Role (with a different Email) in the same team. Change the disposition of any assignments from that team for the removed reviewer to 'withdrawn' rather than 'rejected'. Fixes #3320. Commit ready for merge.
- Legacy-Id: 19151
2021-06-24 15:44:55 +00:00
Robert Sparks 44566f80cb reorder migrations
- Legacy-Id: 19086
2021-06-04 23:08:49 +00:00
Robert Sparks b7c3d03cba Merged in [19083] from jennifer@painless-security.com:
Fix renamed field in group migrations 0043 and 0044. Fixes error in 19075.
 - Legacy-Id: 19085
Note: SVN reference [19083] has been migrated to Git commit f5a1730257
2021-06-04 23:02:42 +00:00
Jennifer Richards f5a1730257 Fix renamed field in group migrations 0043 and 0044. Fixes error in 19075. Commit ready for merge.
- Legacy-Id: 19083
2021-06-04 21:58:53 +00:00
Robert Sparks 5bb08bc103 Merged in [19075] from jennifer@painless-security.com:
Clean up handling of non-WG groups on the group edit page; restrict parent/child group relationships by type. Fixes #3253.
 - Legacy-Id: 19079
Note: SVN reference [19075] has been migrated to Git commit 2a2e5f0c24
2021-06-04 19:59:29 +00:00
Jennifer Richards 2a2e5f0c24 Clean up handling of non-WG groups on the group edit page; restrict parent/child group relationships by type. Fixes #3253. Commit ready for merge.
- Legacy-Id: 19075
2021-06-04 17:31:53 +00:00
Robert Sparks b8b3047d99 Merged in [19022] from housley@vigilsec.com:
Add test for creation of RG Chairs in the irtg.org domain.
 - Legacy-Id: 19023
Note: SVN reference [19022] has been migrated to Git commit c42935363a
2021-05-20 22:02:02 +00:00
Russ Housley c42935363a Add test for creation of RG Chairs in the irtg.org domain. Commit ready for merge.
- Legacy-Id: 19022
2021-05-20 20:15:49 +00:00
Robert Sparks ed68a97685 Merged in [18993] from housley@vigilsec.com:
Add aliases for RGs in irtf.org and IAB programs in iab.org. Fixes #3271
 - Legacy-Id: 19021
Note: SVN reference [18993] has been migrated to Git commit 886b99c273
2021-05-20 20:14:49 +00:00
Russ Housley 886b99c273 Add aliases for RGs in irtf.org and IAB programs in iab.org. Fixes #3271
- Legacy-Id: 18993
2021-05-13 20:34:11 +00:00
Robert Sparks 216ec499df Checkpointing. Remaining work: convert meetingregistation fixup to a migration and a mgmt comment. Flesh out testing of 8989 rule 2 and fix the known edge case bug. Remove old implementation and connect UI to the new implementation.
- Legacy-Id: 18971
2021-05-01 19:57:04 +00:00
Robert Sparks 6d7a0b6d0f Merged in [18939] from jennifer@painless-security.com:
Consolidate repeated searchable field code into SearchableField class. Fix single-valued searchable fields. Make javascript test config reusable. Use Django Form.media for JS/CSS inclusion. Fixes #3196, #3204.
 - Legacy-Id: 18948
Note: SVN reference [18939] has been migrated to Git commit 17d37723f7
2021-04-12 22:07:03 +00:00
Robert Sparks 404d115934 Merged in [18936] from rjsparks@nostrum.com:
Retain strict acronym validation, specifically disallowing hyphens, for new groups of types that create documents, while allowing existing groups and new non-document-creating groups to validate when they contain hyphens. Fixes #3236. Commit
 - Legacy-Id: 18945
Note: SVN reference [18936] has been migrated to Git commit 04f5b4ae4dcbbf8a39281f0b79b1a6271439fd1a
2021-04-12 17:08:58 +00:00
Jennifer Richards 17d37723f7 Consolidate repeated searchable field code into SearchableField class. Fix single-valued searchable fields. Make javascript test config reusable. Use Django Form.media for JS/CSS inclusion. Fixes #3196, #3204. Commit ready for merge.
- Legacy-Id: 18939
2021-04-09 15:18:11 +00:00
Russ Housley 45b14c83a7 Convert generate-draft-aliaes and generate-wg-aliases into management commands: generate_draft_aliases and generate_group_aliases. Also provide tests for the new management commands.
- Legacy-Id: 18913
2021-03-13 17:30:35 +00:00
Jennifer Richards e11583a87f Allow assignment of Person as "action holder" for a Doc, plus rudimentary automation of assignment. Fixes #3146. Commit ready for merge.
- Legacy-Id: 18829
2021-02-12 20:31:00 +00:00
Jennifer Richards df37793e14 Use Roles instead of dedicated model for liaison statement group contacts. Fixes #3100. Commit ready for merge.
- Legacy-Id: 18828
2021-02-12 16:39:20 +00:00
Robert Sparks 9a9f3fa360 Merged in [18798] from jennifer@painless-security.com:
Improve handling of submissions for closed working groups. Fixes #3058.
 - Legacy-Id: 18807
Note: SVN reference [18798] has been migrated to Git commit 233bff8196
2021-01-27 23:19:42 +00:00
Jennifer Richards 233bff8196 Improve handling of submissions for closed working groups. Fixes #3058. Commit ready for merge.
- Legacy-Id: 18798
2021-01-18 14:55:25 +00:00
Robert Sparks 03e5121f72 Remove HistoricalGroupFeatures. Fixes #3152. Commit ready for merge.
- Legacy-Id: 18782
2020-12-18 18:57:26 +00:00
Robert Sparks 643749316b Allow program leads to request meetings. Fixes #3141. Commit ready for merge.
- Legacy-Id: 18718
2020-11-23 20:36:47 +00:00
Henrik Levkowetz 088033d843 Added matching indexes to a number of models with ordering by multiple keys.
- Legacy-Id: 18664
2020-11-09 19:41:12 +00:00
Henrik Levkowetz 552c0c9d70 Added a GroupHistory.ad_role() method.
- Legacy-Id: 18647
2020-10-27 11:39:55 +00:00
Henrik Levkowetz a2758d5feb Fixed a test case bug that compared a py3 string with bytes.
- Legacy-Id: 18544
2020-10-02 12:22:40 +00:00
Robert Sparks cf2a198d5f Create a yangcatalog support group and populate its initial roles. Commit ready for merge.
- Legacy-Id: 18502
2020-09-17 20:57:06 +00:00
Robert Sparks 2b70735fd2 Improved the classification of some github related external resources. Tightened validation of new resource values. Commit ready to merge.
- Legacy-Id: 18378
2020-08-17 23:50:22 +00:00
Henrik Levkowetz 57938b039d Converted many cases of plain-text 403 messages to use a properly styled page instead, with a login link when appropriate. Also changed some API endpoint 400 responses to a more correct 403.
- Legacy-Id: 18339
2020-08-06 10:59:52 +00:00
Henrik Levkowetz e4bc508abc Merged in [18298] from rjsparks@nostrum.com:
Convert IRTF area groups into their own group type rather than attempting to overload AG. Fixes #3027.
 - Legacy-Id: 18320
Note: SVN reference [18298] has been migrated to Git commit 2b10465aa7
2020-07-30 14:27:17 +00:00
Henrik Levkowetz 0ac92d3ae4 Merged in [18299] from rjsparks@nostrum.com:
Missing migrations from 18298.
 - Legacy-Id: 18309
Note: SVN reference [18299] has been migrated to Git commit e7e1cc2a8e
2020-07-29 14:37:51 +00:00
Robert Sparks e7e1cc2a8e Missing migrations from 18298. Commit ready for merge.
- Legacy-Id: 18299
2020-07-28 18:55:43 +00:00
Robert Sparks 2b10465aa7 Convert IRTF area groups into their own group type rather than attempting to overload AG. Fixes #3027. Commit ready for merge.
- Legacy-Id: 18298
2020-07-28 18:54:44 +00:00
Jim Fenton 1cacc6715b Adds programs to concluded groups page. Fixes #3023. Commit ready for merge.
- Legacy-Id: 18275
2020-07-25 19:02:26 +00:00
Jim Fenton 65c7080b1f Interim change to prevent chairs from editing milestone description. Fixes #3036. Commit ready for merge.
- Legacy-Id: 18272
2020-07-25 18:01:31 +00:00
Henrik Levkowetz 068493d8bd Merged in [18205] from rjsparks@nostrum.com:
Add rudimentary validation to the admin group form acronym field. Partially addresses #3026.
 - Legacy-Id: 18215
Note: SVN reference [18205] has been migrated to Git commit 82928b8033
2020-07-21 20:06:56 +00:00
Robert Sparks 82928b8033 Add rudimentary validation to the admin group form acronym field. Partially addresses #3026. Commit ready for merge.
- Legacy-Id: 18205
2020-07-20 20:00:05 +00:00
Henrik Levkowetz 606cedd796 Merged in the ExtResource work from rjsparks@nostrum.com, based on a feature request and contributions from rsalz@akamai.com. This provides external resource models for Person, Group, and Document models, as a generalisation of the previous related-URL concept. This provides a consistent labelling and classification of URLs and other resources related to a Group, Document, or Person. The GroupURL (and similar) classes will be removed in a later step. Some DocumentURL instances (such as auth48 URLs) remain to convert, as they have come in with other merged-in work while the ExtResource work was in transit.
- Legacy-Id: 18192
2020-07-20 01:58:26 +00:00
Robert Sparks 6227162e53 Updated mgmt command to find github repos to back up. Improved test coverage of branch changes. Branch ready for merge.
- Legacy-Id: 18163
2020-07-13 17:36:34 +00:00
Robert Sparks 99df95d542 Cleaned up created names. Improved validation during migration. Cleaned up migration output. Cleaned the last of the awp includes from secr views. Removed now unused secr templates. Build extresource urls correctly during submission and when creating group wikis.
- Legacy-Id: 18158
2020-07-13 16:03:39 +00:00
Robert Sparks 53f7bc3ce6 migrated forward
- Legacy-Id: 18144
2020-07-09 21:07:05 +00:00
Robert Sparks 066ee27505 preparing to merge forward
- Legacy-Id: 18143
2020-07-09 20:29:45 +00:00
Robert Sparks c6f55a3306 Fixed some test scaffolding that used non-existent keys (uncovered by recent improvements in sqlite3 integrity checking). Commit ready for merge.
- Legacy-Id: 18130
2020-07-02 20:05:02 +00:00
Henrik Levkowetz 12fc334279 Renamed and adjusted a migration to avoid multiple migration leaf nodes.
- Legacy-Id: 18101
2020-06-29 17:02:42 +00:00
Henrik Levkowetz 6170ebd64a Merged in the final part of the automatic scheduler from sasha@dashcare.nl.
- Legacy-Id: 18100
2020-06-29 16:54:51 +00:00
Henrik Levkowetz 8892a6b725 Removed unused imports.
- Legacy-Id: 18089
2020-06-27 17:40:28 +00:00
Henrik Levkowetz cb9006eb26 Changed skip messages from test suites to use print() instead of sys.stderr.write(), to match other output from the test runner.
- Legacy-Id: 18087
2020-06-27 17:32:02 +00:00
Henrik Levkowetz bbb5b9ce3f Merged in [18064] from rjsparks@nostrum.com:
Change group edit field url regexp to accept the field names (specifically role names) we use by allowing hyphens.
 - Legacy-Id: 18072
Note: SVN reference [18064] has been migrated to Git commit db0f902145
2020-06-27 11:55:12 +00:00
Robert Sparks db0f902145 Change group edit field url regexp to accept the field names (specifically role names) we use by allowing hyphens. Commit ready to merge.
- Legacy-Id: 18064
2020-06-25 20:41:49 +00:00
Robert Sparks bf53bf1057 Merged forward. Added some missing parts to the XMPPURLValidator.
- Legacy-Id: 18050
2020-06-24 19:01:45 +00:00
Sasha Romijn 9dd0035a19 Fix migrations after rebase.
- Legacy-Id: 17994
2020-06-15 20:51:46 +00:00
Robert Sparks c69556efe1 Improve admin form validation for used_roles. Commit ready for merge.
- Legacy-Id: 17992
2020-06-15 19:14:42 +00:00
Sasha Romijn 6e026926f0 Rebase automatic-scheduler-2 onto 7.3.2.dev0
- Legacy-Id: 17990
2020-06-15 12:29:39 +00:00
Henrik Levkowetz 567449d3d2 Merged in [17908] from rjsparks@nostrum.com:
Add used_roles to Group and default_used_roles to GroupFeatures. Dynamically build the group edit form to provide a field for all used_roles. Fixes #2785 and #2572. Partially addresses #2160.
 - Legacy-Id: 17960
Note: SVN reference [17908] has been migrated to Git commit 2862727d02
2020-06-10 12:58:29 +00:00
Henrik Levkowetz 542c165907 Added a migration to create login and person records for the mail-archive and registration-system users.
- Legacy-Id: 17934
2020-06-08 19:19:25 +00:00
Robert Sparks 2862727d02 Add used_roles to Group and default_used_roles to GroupFeatures. Dynamically build the group edit form to provide a field for all used_roles. Fixes #2785 and #2572. Partially addresses #2160. Commit ready for merge.
- Legacy-Id: 17908
2020-06-04 21:05:33 +00:00
Sasha Romijn 57d8ffb27a Re-introduce Group.meeting_seen_as_area and use it in automatic scheduler
- Legacy-Id: 17901
2020-06-01 09:25:51 +00:00
Henrik Levkowetz 65c6a878f7 Merged in [17843] from housley@vigilsec.com:
Create slowpages cache for some very stable pages
 - Legacy-Id: 17874
Note: SVN reference [17843] has been migrated to Git commit f7886df212
2020-05-21 22:03:38 +00:00
Robert Sparks 8a0578040e Added better self-descriptive __str__ functions to PersonExtResource, GroupExtResource, and DocExtResource
- Legacy-Id: 17871
2020-05-21 20:59:44 +00:00
Robert Sparks 02e1226a03 Added appropriate Admin classes
- Legacy-Id: 17870
2020-05-21 20:48:03 +00:00
Robert Sparks 38ba0f401d merged forward
- Legacy-Id: 17868
2020-05-21 18:30:48 +00:00
Robert Sparks 785f6243f1 explicit resource names for classes with the word resource in their name
- Legacy-Id: 17857
2020-05-20 18:28:05 +00:00