Commit graph

25 commits

Author SHA1 Message Date
Lars Eggert 250e045ec3
Simpler fix 2023-10-02 11:43:11 +03:00
Lars Eggert 510570521d
fix: Limit group names to 80 characters
Fixes #6416
2023-10-02 10:40:43 +03:00
Robert Sparks 3c1fc3c0f9
chore: use factory-boy 3.3 (#6269) 2023-09-05 09:54:30 -05:00
Robert Sparks 852f9d90b9
feat: move IAB appeals into the datatracker (#6229)
* feat: basic models for appeals

* fix: modify appeal model to point to group

* fix: explicit date on Appeal objects

* feat: appeals importing management command

* feat: display appeals

* feat: admin for appeals

* fix: limit admin contentype choices

* feat: tastypie resources

* feat: factories and tests

* chore: update group migration

* fix: remove charset from pdf content type

* test: unittest download_name

* fix: admin for new name
2023-08-29 14:07:30 -05:00
Jennifer Richards 0fd8df4e00
test: Set DateField to a date, not a datetime, in factory (#5075) 2023-02-02 13:06:45 -06:00
Robert Sparks 0b3f9f5dc5
refactor: clarify handling what groups looked like at past session times (#4767)
* refactor: clarify handling what groups looked like at past session times

* fix: replace missed instance of historic_parent reference

* fix: reflect that group_at_the_time always returns something

* chore: update copyright lines
2022-11-29 11:08:16 -06:00
Jennifer Richards ebebdbed3e
refactor: replace datetime.now and datetime.today with timezone.now (#4211)
* refactor: replace datetime.now with timezone.now

* refactor: migrate model fields to use timezone.now as default

* refactor: replace datetime.today with timezone.now

datetime.datetime.today() is equivalent to datetime.datetime.now(); both
return a naive datetime with the current local time.

* refactor: rephrase datetime.now(tz) as timezone.now().astimezone(tz)

This is effectively the same, but is less likely to encourage accidental
use of naive datetimes.

* refactor: revert datetime.today() change to old migrations

* refactor: change a missed datetime.now to timezone.now

* chore: renumber timezone_now migration

* chore: renumber migrations
2022-08-25 13:45:16 -03:00
Robert Sparks b99eecc1ae Bring the factory-boy and Faker dependencies forward through some minor breaking changes. Stop using the deprecated fr_QC locale in Faker. Commit ready for merge.
- Legacy-Id: 19270
2021-08-03 22:22:35 +00:00
Robert Sparks 216ec499df Checkpointing. Remaining work: convert meetingregistation fixup to a migration and a mgmt comment. Flesh out testing of 8989 rule 2 and fix the known edge case bug. Remove old implementation and connect UI to the new implementation.
- Legacy-Id: 18971
2021-05-01 19:57:04 +00:00
Robert Sparks 404d115934 Merged in [18936] from rjsparks@nostrum.com:
Retain strict acronym validation, specifically disallowing hyphens, for new groups of types that create documents, while allowing existing groups and new non-document-creating groups to validate when they contain hyphens. Fixes #3236. Commit
 - Legacy-Id: 18945
Note: SVN reference [18936] has been migrated to Git commit 04f5b4ae4dcbbf8a39281f0b79b1a6271439fd1a
2021-04-12 17:08:58 +00:00
Robert Sparks 2b10465aa7 Convert IRTF area groups into their own group type rather than attempting to overload AG. Fixes #3027. Commit ready for merge.
- Legacy-Id: 18298
2020-07-28 18:54:44 +00:00
Robert Sparks fb8e5c6842 Allow IAB programs to use normal meeting mechanics. Fixes #2970. Commit ready for merge.
- Legacy-Id: 17764
2020-05-08 21:11:25 +00:00
Robert Sparks afb818c298 Allow review team secretaries and the secretariat to reset the next reviewer in queue for review teams using the RotateAlphabetically policy. Partially addresses #2879. Commit ready for merge.
- Legacy-Id: 17325
2020-02-21 23:08:20 +00:00
Robert Sparks 42e5163b09 Adds support for dateless milestones. Fixes #2799. Commit ready for merge.
- Legacy-Id: 17185
2020-01-06 20:48:53 +00:00
Robert Sparks f71e9995a7 Dateless milestone work. Commit in preparation for merging forward.
- Legacy-Id: 17174
2019-12-24 21:38:26 +00:00
Henrik Levkowetz 2daef52bea This commit replaces the code defined group features with features held
in a database table:

- Added a GroupFeatures model to the group models, and removed the old 
  features.py
- Added a agenda type for future use in showing different group types on
  different agendas.
- Renamed the group feature has_materials to has_nonsession_materials.
- Added API resources and admin support for the new tables.
- Added a Directorate (with reviews) group type as complement to
  Directorate, to distinguish between directorates with and without reviews.
- Adjusted tests as needed.
- Updated the fixtures, and fixed the generate_fixtures script to include
  the new AgendaTypeName objects.

There still exists about 70 instances of code comparing the group type
with a list of types; most of these should probably be replaced with new
features, instead, to make it possible to add new group types through the
database table, rather than having to edit the code.  That was the purpose
of this refactoring from the start, but the presence of this large number
of comparisons of group type against lists of types defeats the goal until
we add appropriate features and replace the group type list comparisons.
 - Legacy-Id: 15316
2018-07-12 10:51:48 +00:00
Robert Sparks dcf9e6b40f Use factories for ietf.doc.tests_ballots. Fixed a long-hidden bug in test_edit_verify_permissions where non-existing usernames were used and passed the tests accidently. Added list_email to the GroupFactory. Commit ready for merge.
- Legacy-Id: 15219
2018-06-06 17:59:40 +00:00
Robert Sparks 84d3c92298 more factoryization of ietf.doc.tests. Commit ready for merge.
- Legacy-Id: 15205
2018-06-02 13:39:39 +00:00
Henrik Levkowetz 9e5db7ce5c Make sure that factory groups have a type.
- Legacy-Id: 13780
2017-07-06 13:56:59 +00:00
Henrik Levkowetz 108c00a0a3 Merged in [13731] from rjsparks@nostrum.com:
Reworked how review assigments are processed in order to ensure a team's queue rotates when it should. Fixes #2305.
 - Legacy-Id: 13743
Note: SVN reference [13731] has been migrated to Git commit 7f5cef056ade1641f1d815b0a5f35962077d6d01
2017-06-30 20:16:22 +00:00
Henrik Levkowetz 34370c6e16 Merged in [11656] from rjsparks@nostrum.com:
Enhanced factories to simplify test writing.
 - Legacy-Id: 11682
Note: SVN reference [11656] has been migrated to Git commit 030ea1c939
2016-07-16 14:15:41 +00:00
Henrik Levkowetz 211943148d Make the group factory produce groups with valid acronyms
- Legacy-Id: 11650
2016-07-13 18:48:53 +00:00
Robert Sparks ca6512e4fa Capture "Status update" summaries for groups that want to provide them. These updates show on the groups charter (or about) page, and in the group history. The most recent update provided before proceedings corrections closing date is included in the group's page in the meeting proceedings. This addresses the majority of #1773 (a ticket entered on behalf of the IESG). Commit ready for merge.
- Legacy-Id: 10969
2016-03-23 19:42:01 +00:00
Robert Sparks a9abd3c2cd Tweak factories to not randomly create keys that violate constraints. Commit ready for merge
- Legacy-Id: 10756
2016-01-28 20:12:00 +00:00
Robert Sparks e81b473282 Expose views for concluded nomcoms. Close feedback and nomination. Initial work on factory-boy based testing. Partially addresses #1856
- Legacy-Id: 10520
2015-11-25 22:17:41 +00:00