Commit graph

5419 commits

Author SHA1 Message Date
Ole Laursen cdcad43fc0 Simplify community lists further by letting email subscriptions reuse
the existing infrastructure for accounts and emails, instead of a
having a separate confirmation step
 - Legacy-Id: 10951
2016-03-17 12:02:45 +00:00
Ole Laursen 5f4082d595 Overhaul of the community list code.
From a user perspective: Use friendlier URLs for lists. Reuse the
search results table for displaying lists. Simplify the management
pages and improve the search rule UI to help fill in the values and
validating them, instead of just providing a text field. Fixes #1874.
Add an explicit button for adding individual documents. Include all
changes in the document change streams, not just some changes. Fix a
concurrency issue that allows changed documents to escape the search
rules. Don't create an empty list just be logging in.

From a code maintenance perspective: Clean up the models. Replace the
background caching scheme with direct queries. Get rid of a big chunk
of code. Speed up the code that adds track buttons to search results.
Add tests of all community views. Fixes #1422. Also fix some minor
bugs and oddities here and there.

There's still some work to do with respect to integrating the group
lists better.
 - Legacy-Id: 10921
2016-03-14 10:44:57 +00:00
Ole Laursen 1c3ec64e03 Eliminate odd group_id assignment in submission code, probably left
over from a previous generation of the code. It causes trouble with a
revamped community rule engine.
 - Legacy-Id: 10730
2016-01-25 18:26:33 +00:00
Ole Laursen 197bc07771 Refactor search-related utilities slightly to make them more
independent of the search form, to enable them to be reused in the
community lists.

Also clean up the related code a bit, use SearchForm to handle other
document types, and fix missing ids in the HTML so that one can click
the "by" labels to hit the corresponding radio button.
 - Legacy-Id: 10729
2016-01-25 18:11:49 +00:00
Ole Laursen d67a96b4f0 Set daemon = True on the thread in the SMTP test server running while
running tests. This fixes the annoying problem of the python process
staying alive after certain bugs in the test invocation or after a
plain Ctrl + c.
 - Legacy-Id: 10718
2016-01-20 14:19:06 +00:00
Ole Laursen 540ef748f7 Fix community list track/untrack on document page, also fix the
attached Javascript which had a split personality regarding how to
deal with a repeated click
 - Legacy-Id: 10714
2016-01-19 11:27:47 +00:00
Ole Laursen b7232d0ab7 Revamp tracked/not tracked icons in search results to not do one query
per document, and make them work on all search result pages, move the
utility function to community/
 - Legacy-Id: 10690
2016-01-14 18:04:05 +00:00
Ole Laursen 22e2a6a2b8 Delete the DocumentChangeDates model from CommunityList, it's being
used as a cache, but won't be necessary once the display code is
rewritten since it will be able to calculate the data on the fly
 - Legacy-Id: 10682
2016-01-13 18:11:03 +00:00
Ole Laursen 1b8e9eb7e4 Get rid of ExpectedChange model in community lists, it's not used
- Legacy-Id: 10681
2016-01-13 17:43:05 +00:00
Ole Laursen cd5c60ccf1 Clean up permission checking in community lists, fix split in
track/untrack between personal/group lists, get rid of remove_document
 - Legacy-Id: 10680
2016-01-13 17:37:22 +00:00
Ole Laursen 4696dad536 Delete some unused code
- Legacy-Id: 10669
2016-01-13 10:53:28 +00:00
Ole Laursen 1e75ee3d11 Do not create CommunityLists when rendering the side bar, only render
the links
 - Legacy-Id: 10668
2016-01-13 10:47:36 +00:00
Ole Laursen e807115e81 Fix community list track/untrack to use POST rather than GET
- Legacy-Id: 10660
2016-01-13 10:15:38 +00:00
Henrik Levkowetz bce152b2b9 Rewrote crawl_history() to be easier to read (renaming multiple 'retval' variables and other naming tweaks) and made it return distinct revisions without the added uniqueness filtering round from /personal/lars/6.11.1.dev0@10604.
- Legacy-Id: 10639
2016-01-11 23:33:50 +00:00
Henrik Levkowetz 8b12a0fa03 Merged in [10591] from housley@vigilsec.com:
Added a negative test to ensure the RFC Editor is not included on notifications of manual posts by the Secretariat unless the document is in the RFC Editor Queue.

Also added a directory for staging of manually submitted drafts, instead of using hardcoded /tmp/, and added creation and removal of a test directory for this.
 - Legacy-Id: 10638
Note: SVN reference [10591] has been migrated to Git commit 4a2868cef5
2016-01-11 22:44:01 +00:00
Henrik Levkowetz 363b451d28 Merged in [10586] from housley@vigilsec.com:
Added automated tests for the fix for ticket #1751.
 - Legacy-Id: 10613
Note: SVN reference [10586] has been migrated to Git commit 014e79f716
2015-12-20 17:49:36 +00:00
Henrik Levkowetz 8b0e6d1311 Merged in [10569] from housley@vigilsec.com:
For manual posting of an I-D by the Secretariat, include the RFC Editor on the email message if the I-D is in the RFC Editor Queue. Fixes #1751.
 - Legacy-Id: 10612
Note: SVN reference [10569] has been migrated to Git commit a380a7ff27
2015-12-20 17:38:21 +00:00
Henrik Levkowetz d8413d5d28 Changed a helper function meeting_updated() to a method on Meeting, and provided it as a synthetic attribute on the /api/v1/meeting/meeting/ endpoints of the JSON API.
- Legacy-Id: 10611
2015-12-19 01:52:13 +00:00
Henrik Levkowetz d1e245f042 Merged in [10567] from housley@vigilsec.com:
For Charters, display the Responsible AD as well as the Charter Edit AD. Fixes #1829.
 - Legacy-Id: 10601
Note: SVN reference [10567] has been migrated to Git commit 0052a4f733
2015-12-15 20:37:22 +00:00
Henrik Levkowetz 668e88a3aa Moved the timeline colouring css to ietf.less, to pick up the brand colours directly.
- Legacy-Id: 10598
2015-12-15 19:41:12 +00:00
Henrik Levkowetz 213ae4921b Merged in /personal/lars/6.11.1.dev0@10590 from lars@netapp.com, which brings in a timeline view at the top of document pages.
- Legacy-Id: 10597
2015-12-15 19:17:36 +00:00
Russ Housley 4a2868cef5 Added a negative test to ensure the RFC Editor is not included on notifications of manual posts by the Secretariat unless the document is in the RFC Editor Queue.
- Legacy-Id: 10591
2015-12-14 21:05:49 +00:00
Lars Eggert cf4964059f Fix some issues Henrik found, and implement some of his suggestions:
* Fix ancestor stacking
* Suppress x-axis labels that overlap with others
* Make bars clickable links
 - Legacy-Id: 10590
2015-12-14 13:04:34 +00:00
Russ Housley 014e79f716 Added automated tests for the fix for ticket #1751.
- Legacy-Id: 10586
2015-12-11 22:56:34 +00:00
Henrik Levkowetz 937fd705e2 Changed the style for 'recuse' from 'default' to 'primary' colour.
- Legacy-Id: 10583
2015-12-11 20:04:56 +00:00
Henrik Levkowetz 2bab09b6f4 Added a coloured bar at the right-hand side of the ADs' view of iesg/agenda/documents/, in order to make it easier to distinguish between the 'yes' and 'no-objection' colour codes.
- Legacy-Id: 10578
2015-12-11 11:34:23 +00:00
Henrik Levkowetz de7c79092e Moved definitions for the AD ballot position's background colours (which shows each AD his own positions by colour coding) from ietf.css to ietf.less, to make it easier to adjust the colours while keeping to the hues of the colour palette.
- Legacy-Id: 10577
2015-12-11 11:30:50 +00:00
Russ Housley a380a7ff27 For manual posting of an I-D by the Secretariat, include the RFC Editor on the email message if the I-D is in the RFC Editor Queue. Fixes #1751.
- Legacy-Id: 10569
2015-12-10 22:55:04 +00:00
Russ Housley 0052a4f733 For Charters, display the Responsible AD as well as the Charter Edit AD. Fixes #1829.
- Legacy-Id: 10567
2015-12-10 16:56:06 +00:00
Lars Eggert bdf8089688 Add an ESLint config for use with datatracker javascript and apply it to
document_timeline.js. Also, I consider the graphical timeline stuff stable,
so I'll use this commit to say: Branch ready for merge.
 - Legacy-Id: 10566
2015-12-10 09:02:58 +00:00
Henrik Levkowetz d0b99b03b5 Merged in [10540] from lars@netapp.com:
Update vnu HTML5 validator, and fix an HTML nit it found.
 - Legacy-Id: 10563
Note: SVN reference [10540] has been migrated to Git commit 5866129176
2015-12-09 22:43:37 +00:00
Henrik Levkowetz 3e4c10bf00 Merged in [10539] from lars@netapp.com:
Fix CSS/js inclusion of select2 from new static location. (Looks like this file
was forgotten when we began to use bower.)
 - Legacy-Id: 10562
Note: SVN reference [10539] has been migrated to Git commit 51dba4c5e5
2015-12-09 22:17:51 +00:00
Henrik Levkowetz e6c418a672 Merged in [10538] from lars@netapp.com:
Fixes for displaying IRTF RGs (call them RGs, and don't show IESG state.)
 - Legacy-Id: 10561
Note: SVN reference [10538] has been migrated to Git commit 495ae645ed
2015-12-09 22:00:43 +00:00
Henrik Levkowetz de94e7a991 Merged in [10536] from lars@netapp.com:
Manage html5shiv and respond.js locally via bower, rather than relying on the
CDN.
 - Legacy-Id: 10560
Note: SVN reference [10536] has been migrated to Git commit 73ad12560a
2015-12-09 21:51:39 +00:00
Henrik Levkowetz f987407529 Merged in [10533] from lars@netapp.com:
Missed an update to select2.
 - Legacy-Id: 10559
Note: SVN reference [10533] has been migrated to Git commit d3088faafe
2015-12-09 21:43:27 +00:00
Lars Eggert 0f1c823a6e Now that the timeline stuff seems stable, show it for all document types.
- Legacy-Id: 10555
2015-12-09 16:54:53 +00:00
Lars Eggert b6e02b1c1f More tweaks to the graphical timeline. This is getting there.
- Legacy-Id: 10554
2015-12-09 15:38:33 +00:00
Henrik Levkowetz 063d92bfe7 Merged in [10530] from lars@netapp.com:
Update a number of web assets to their latest versions.
 - Legacy-Id: 10552
Note: SVN reference [10530] has been migrated to Git commit 808196bc0c
2015-12-08 21:43:46 +00:00
Lars Eggert d4d09a2f75 Refactor graphical timeline, by making the data available via doc.json. Also
refactor associated js/css/html. Finally, a lot of display tweaks.
 - Legacy-Id: 10550
2015-12-08 14:29:35 +00:00
Lars Eggert e1ff3a5782 Beginnings of graphical document timelines using d3.js
- Legacy-Id: 10546
2015-12-07 16:10:57 +00:00
Henrik Levkowetz 363630f389 Fixed a problem with wrapping of double-spaced text in author lists for 1id-abstracts.
- Legacy-Id: 10545
2015-12-05 14:33:35 +00:00
Henrik Levkowetz d3c5609cde Added some tests for the group role email utility functions used by the alias generation scripts. Tempted to start using factory boy, but will wait till Robert's work in the nomcom branch comes in.
- Legacy-Id: 10544
2015-12-04 23:10:01 +00:00
Henrik Levkowetz 9b274111eb Added group secretaries to the alias lists. Refactored related utility functions to less code with fewer branches with greater generality.
- Legacy-Id: 10543
2015-12-04 20:30:43 +00:00
Lars Eggert 9728186ec4 Make revision history (via crawl_history) available in document templates. This
lays the foundation for graphical timelines.
 - Legacy-Id: 10542
2015-12-03 13:25:51 +00:00
Lars Eggert 30f2e87f55 Fix bug in r10540. (I should really remember to run the test suite before
committing.) Commit ready for merge.
 - Legacy-Id: 10541
2015-12-03 12:15:55 +00:00
Lars Eggert 5866129176 Update vnu HTML5 validator, and fix an HTML nit it found.
Commit ready for merge.
 - Legacy-Id: 10540
2015-12-03 11:54:08 +00:00
Lars Eggert 51dba4c5e5 Fix CSS/js inclusion of select2 from new static location. (Looks like this file
was forgotten when we began to use bower.) Commit ready for merge.
 - Legacy-Id: 10539
2015-12-03 11:53:06 +00:00
Lars Eggert 495ae645ed Fixes for displaying IRTF RGs (call them RGs, and don't show IESG state.)
Commit ready for merge.
 - Legacy-Id: 10538
2015-12-03 10:59:05 +00:00
Lars Eggert 49ebd8e756 Manage the PT font family with bower, instead of relying on a static version.
Commit ready for merge.
 - Legacy-Id: 10537
2015-12-03 09:28:18 +00:00
Lars Eggert 73ad12560a Manage html5shiv and respond.js locally via bower, rather than relying on the
CDN. Commit ready for merge.
 - Legacy-Id: 10536
2015-12-03 08:57:52 +00:00