Commit graph

171 commits

Author SHA1 Message Date
Ole Laursen c760b48b38 Make streams_menu tag more robust in the face of "request" missing
from context, this would normally be an error but it can happen if a
404 is returned
 - Legacy-Id: 6268
2013-09-26 13:00:25 +00:00
Ole Laursen 525259a84f Remove unused ietfworkflows imports
- Legacy-Id: 6258
2013-09-24 17:34:20 +00:00
Ole Laursen 2e152bbc9c Fix naming bug in streams_menu template tag
- Legacy-Id: 6257
2013-09-24 17:32:41 +00:00
Ole Laursen 2d902e28d1 Add stream edit page for setting delegates instead of page in
ietfworkflows, add streams_menu template tag for outputting the
streams menu instead of the one in ietfworkflows, move
base_wgmenu.html and base_leftmenu.html templates to base/ (together
with base/streams_menu.html), get rid of "first" madness in
base/left_menu.html which is now obsolete anyway because we have a
Settings headline which is always first
 - Legacy-Id: 6255
2013-09-24 17:25:10 +00:00
Ole Laursen 019ca2ae03 Merge changes from attic/shimfree into new branch to complete rebasing shimfree on trunk
- Legacy-Id: 6215
2013-09-20 09:48:58 +00:00
Henrik Levkowetz 44a8eb207b Removed the old ad documents page, and it's view function, and put in a redirect from the temporary /ad2/ url to the /ad/ url.
- Legacy-Id: 6204
2013-09-19 18:24:23 +00:00
Henrik Levkowetz e09667122a Added the ability to search for documents from a certain stream to the main document search form.
- Legacy-Id: 6201
2013-09-19 18:16:10 +00:00
Ole Laursen a871d6e19e Remove wgchairs app, all of its functionality is now superceded by wginfo/ and other recent developments in doc/
- Legacy-Id: 6198
2013-09-19 15:22:59 +00:00
Henrik Levkowetz 11c1b0738a Cleaned up the ipr count code in doc/views_search.py a bit more.
- Legacy-Id: 6162
2013-09-18 17:43:09 +00:00
Henrik Levkowetz 11e56aa5b2 Modified the code which accumulates ipr disclosures associated with a document, shown as an IPR count in search results. The previous code had two deficiencies: it could count some IPR disclosures twice, and it also included withdrawn and pending disclosures. The current count matches the IPR search results better.
- Legacy-Id: 6158
2013-09-16 20:55:24 +00:00
Henrik Levkowetz 71f85f96c7 Merged in a fix from rjsparks@nostrum.com for incorrect IANA notification email addresses.
- Legacy-Id: 6152
2013-09-13 22:23:55 +00:00
Ole Laursen 95fdfb5d8a Add tags for streams to state help
- Legacy-Id: 6134
2013-09-10 16:15:18 +00:00
Ole Laursen 026ed3f8df Add statehelp template filter for outputting a little help icon for a
state with a tooltip and link to the description
 - Legacy-Id: 6133
2013-09-10 16:13:59 +00:00
Henrik Levkowetz 9dc13aa8f2 Merged in personal/rjs/r6117-pubreq:
- Made Publication Request (for documents from IETF working groups) an
  explicit action rather than a side-effect.

- Simplified the working group state edit form.

- Added hints to the WG state edit form to use the document's main page to
  request publication.

- If a document is moved into IESG processing directly by the secretariat or
  an AD (old processing path), set working group state accordingly.
 - Legacy-Id: 6120
2013-09-09 19:29:56 +00:00
Henrik Levkowetz 2a2389d17f Merged in branch/iola/shimfree@6083. This cleans up and moves relevant code from idrfc/ to doc/. There should now only be a bit of old wrapper code left in idrfc; that will go away when the remaining models which use it are cleaned up.
- Legacy-Id: 6117
2013-09-09 17:45:36 +00:00
Henrik Levkowetz 38b0a59ba3 Merged personal/rjs/v4.70@6042:
* Made reporting IPR consistant across document searches, IPR searches, AD document queues, last calls, and agendas. All these points now report on the document(s) being directly queried, and the documents those transitively replace or obsolete.

  * Brought search results against WGs and document titles into consistency with results from searching for individual documents

  * Added the IPR count to the link on the documents main page (when not zero)

  * Built on Henrik's reimplementation of all_related_*, making the *_related_* functions return DocAlias? lists consistently, and added corresponding _relations_ functions to get lists of actual RelatedDocument? objects.

  * Added getting the DocAlias? with the same name to Document

  * Added getting related IPR disclosures (as described in the first bullet) to Document

  * Simplified ipr/related.py

  * Removed the use of DraftLikeDocAlias? and IETFWG from ipr/search.py. Retooled the various search functions and templates to use DocAlias? and IprDocAlias? directly.

  * Removed dead code from ipr/search.py

  * Removed the special handling of WG 2000 from ipr/search.py 

  This fixes bug #1071
 - Legacy-Id: 6083
2013-09-02 18:34:54 +00:00
Henrik Levkowetz d6471397ef Fixed bug in previous commit, for case where iesg_state is None.
- Legacy-Id: 6082
2013-08-30 12:32:11 +00:00
Henrik Levkowetz ffb4581008 Fixed regression in display of IESG state; added back substate information. Fixes issue #1117.
- Legacy-Id: 6081
2013-08-30 12:21:36 +00:00
Henrik Levkowetz 37e69a02c6 Changed the order of the files diffed in the draft diff links on the history page. Fixes issue #1114.
- Legacy-Id: 6077
2013-08-28 10:36:32 +00:00
Ole Laursen 2a85572777 Add status-change to state_help framework, remove last traces of former framework
- Legacy-Id: 6057
2013-08-14 16:16:52 +00:00
Ole Laursen d2b9adf3cb Move ietf_filters templatetag from idtracker/ to doc/
- Legacy-Id: 6053
2013-08-14 15:11:24 +00:00
Ole Laursen 6ac0920af0 Move idrfc/ templates to doc/ and subdirectories in doc/, move ported ballot_icon template tag, delete dead code
- Legacy-Id: 6052
2013-08-14 14:10:46 +00:00
Ole Laursen 742dbace24 Move views and templatetags from idrfc/ to doc, the I-D specific views
go into views_draft.py and tests in tests_draft.py; what's left in
idrfc is wrapper code, templates and the ballot_icon templatetag
 - Legacy-Id: 6051
2013-08-14 10:32:25 +00:00
Ole Laursen 2cf79bb04c Move update_telechat from idrfc.utils to doc.utils, port remaining
code to using log_state_changed from doc.utils, remove idrfc/utils.py
 - Legacy-Id: 6050
2013-08-13 16:44:07 +00:00
Ole Laursen de7ae60985 Move markup_txt.py from idrfc/ to utils/
- Legacy-Id: 6046
2013-08-13 14:33:22 +00:00
Robert Sparks a593fec06e * Made reporting IPR consistant across document searches, IPR searches, AD document queues, last calls, and agendas. All these points now report on the document(s) being directly queried, and the documents those transitively replace or obsolete.
* Brought search results against WGs and document titles into consistency with results from searching for individual documents
* Added the IPR count to the link on the documents main page (when not zero)
* Built on Henrik's reimplementation of all_related_*, making the *_related_* functions return DocAlias lists consistently, and added corresponding _relations_ functions to get lists of actual RelatedDocument objects.
* Added getting the DocAlias with the same name to Document
* Added getting related IPR disclosures (as described in the first bullet) to Document
* Simplified ipr/related.py
* Removed the use of DraftLikeDocAlias and IETFWG from ipr/search.py. Retooled the various search functions and templates to use DocAlias and IprDocAlias directly.
* Removed dead code from ipr/search.py
* Removed the special handling of WG 2000 from ipr/search.py

Fixes bug 1071
 - Legacy-Id: 6042
2013-08-12 21:41:57 +00:00
Henrik Levkowetz 9f998e5bbc Tweaked code to correct access to document metadata and actions, adding RGs to the groups and group secretaries to the roles which are given access.
- Legacy-Id: 5935
2013-07-31 17:11:19 +00:00
Henrik Levkowetz 8b1b38d57e Added group secretaries to those authorise to edit group document meta-information.
- Legacy-Id: 5933
2013-07-31 16:07:16 +00:00
Henrik Levkowetz b090f1e92c Merged [5903] from adam@nostrum.com:
Added tooltip capability to document tabs, and tooltips for disabled IESG Evaluation/Review tab.  Fixes bug #448.
 - Legacy-Id: 5931
Note: SVN reference [5903] has been migrated to Git commit d87379c177
2013-07-31 14:16:37 +00:00
Henrik Levkowetz 3decaf3300 Added back the 'Request Publication' action (regression loss) on draft pages for the non-ietf streams.
- Legacy-Id: 5921
2013-07-30 14:56:25 +00:00
Henrik Levkowetz 12bd97c7cf Added convenience methods to the Document class to recursively retrieve all forward / reverse relationship of a kind or set of kinds.
- Legacy-Id: 5912
2013-07-29 13:31:18 +00:00
Henrik Levkowetz 7a131cd777 Fixed the handling of help pages for doc states.
- Legacy-Id: 5911
2013-07-29 13:25:10 +00:00
Adam Roach d87379c177 Fixed bug #448 -- added tooltip capability to document tabs
- Legacy-Id: 5903
2013-07-27 14:25:01 +00:00
Henrik Levkowetz 9d2db7c6e4 Additional fix for diff regression: make the RFC part of the version list.
- Legacy-Id: 5884
2013-07-25 19:44:44 +00:00
Henrik Levkowetz a055370da1 Removed debug statement.
- Legacy-Id: 5883
2013-07-25 19:29:05 +00:00
Henrik Levkowetz 75fa9bb0e4 Additional fix for diff regression: make the RFC part of the version list.
- Legacy-Id: 5882
2013-07-25 19:26:14 +00:00
Henrik Levkowetz 5eac4a86ce Additional fix for diff regression: make the RFC part of the version list.
- Legacy-Id: 5881
2013-07-25 19:24:47 +00:00
Henrik Levkowetz 6a2ae39913 Fixed a regression: restore diff pane in history page for RFCs.
- Legacy-Id: 5880
2013-07-25 18:52:24 +00:00
Henrik Levkowetz 3c4bee32e5 Fixed a regression: display of full draft/rfc text now again obeys the full_draft cookie setting.
- Legacy-Id: 5879
2013-07-25 18:29:37 +00:00
Henrik Levkowetz cbfe489ff5 Merged in more shim-layer removals from olau@iola.dk
(-r5465:HEAD from branch/iola/shimfree).  Copying relevant
commit messages here:

 - Deleted dead code in many places.

 - Renamed id-something to draft-something, make the "is
   this eligible for expiration" logic clearer

 - Added a name for IPR search URL

 - Revamped the ballot popup view

 - URL reversed the IPR search link instead of hardcoding it

 - Cleaned up search views and remove dead code, port them to the new DB
   schema, hack related views in iesg/ and wginfo/ to use the new search
   interfaces, avoid camelCase in search GET parameters (with
   backwards-compat fallback), add some simple search unit tests, remove
   caching from views_search.py index pages as they're now pretty fast to
   generate, rewrite ballot popup JS, regularize some CSS classes to use
   hyphen-notation rather than camelCase, move some of the search
   templates to doc/.

   idrfc/ now mostly contains some wrapper code still in use by other
   subdirs, some ported code not yet moved, and dead code.

 - Fixed output bug in test crawler and print referrer upon errors so it's
   easier to figure out where a link came from

 - Added /doc/in-last-call/ to crawler, report original page as referrer in
   a redirect chain rather than intermediate URL

 - Ported idindex to new schema, speed them up, add tests, refactor index
   page in views_search to share code with the text index file, get rid
   of some special-case idindex filters from ietf_filters, move
   "/drafts/" redirects to a file in /doc/

 - Ported /idtracker/status/ and /idtracker/status/last-call/ overview of
   drafts in IESG process to new schema in /doc/iesg/ and
   /doc/iesg/last-call/

 - Added redirects for all of /idtracker/*, removed all view code and other
   dead code from idtracker/

 - Removed the idtracker sitemap indexing drafts - in its current form,
   it adds nothing of value to the HTML-based /doc/all/ view, and it's
   pretty slow

 - Ported idtracker feeds to new schema, move them to doc/, cleaned up
   idtracker/ - only templatetags/ietf_filters and proxy code is left
 - Legacy-Id: 5836
2013-07-17 20:52:39 +00:00
Henrik Levkowetz 68b05b609a Various fixes due to clear up tree conflicts and other bugs resulting from
the [5830] merge.
 - Legacy-Id: 5834
Note: SVN reference [5830] has been migrated to Git commit e678659b56
2013-07-16 14:02:43 +00:00
Henrik Levkowetz e678659b56 Merged in a lot of shim-layer removals from olau@iola.dk
(-r5194:5465 from branch/iola/shimfree).  Copying relevant
commit messages here:

  - Removed .related many to many relationship, it's not really useful
    since we always have to restrict on the relationship type anyway,
    instead add two helpers for doing the necessary queries (in both
    directions)

  - Added migration for transforming the .desc on the new_revision events
    into something more akin to what is actually shown in the history page

  - Added migration for blanking IESG notes that just consist of "RFC
    XXXX", these have been superfluous for some time

  - Grant stream chairs access to changing the stream on a draft

  - Hacked the format_history_text filter to be less weird, using the same
    formatting for snippets and full text, also link up legacy ballot set
    events

  - Moved the decoraters + utilities to new ietfauth/utils.py file

  - Added simple helper to Email to identify invalid email addresses (from
    legacy author entries)

  - Used new new_revision .desc format for when drafts are submitted

  - Improved the looks of the button class by adding extra contrast and a
    linear gradient. Currently the gradient is only visible in fairly
    recent browsers.

  - Rewrote draft and RFC tabs in terms of the new schema, porting
    write-up and history tabs as well

  - Fixed two bugs in RFC Editor syncing: make sure documents we don't know
    beforehand get a "draft" type and make sure individually submitted
    drafts get the type="individ" group instead of NULL

  - Made the CSS-styled button feel a bit nicer to use by flattening the
    active state, also introduce some temporary styles until browsers
    catch up with the standard syntax

  - Added migrations for fixing 1) a dummy RFC entry, 2) three stand-alone
    RFCs that didn't get their doc.type set, 3) a big bunch of historic
    stand-alone RFCs that have doc.group=None - set these to the
    individual submission "none" group for the time being so the view code
    doesn't have to deal with a special case.

    In some cases this is wrong since there actually was a WG associated
    but unfortunately fixing them properly requires detective work
    (probably parsing the RFCs) and in at least some cases recreating
    historic WGs. In case someone ends up doing this, the documents to
    check can still be found with

    Document.objects.filter(name__startswith="rfc", group__type="individ")
    since there are almost no new RFCs that didn't went through the I-D
    process.

  - Merged the I-D and RFC views by showing I-D information on RFCs too.
    I-Ds that have been published as RFCs redirect to the RFC URL. Also
    support alias URLs so e.g. /doc/bcpXXXX redirects to /doc/rfcXXXX.

  - Fixed revision augmentation so events after RFC publication gets a "RFC"
    designation

  - Fixed a bug with tabs not using provided name but rather doc.name

  - Displaying draft-iesg state rather than doc.friendly_state as IESG state,
    also show a notice that the IESG state refers to post-RFC processing
    if it does, like the old separate RFC page did

  - Fixed the RFC number doc.note migration to catch combined "RFC XXX; BCP
    XXX" notes too, use the opportunity to remove inserted HTML tags from
    notes and rely on linebreaksbr filter instead (the other thing was a
    left-over from the Perl days), update the various uses of the note to
    reflect that

  - Refactored slightly to make views_doc.py independent of other idrfc code

  - Moveed idrfc/views_doc.py to doc/ with associated templates, replace the
    somewhat fragile simple URL tests for views_doc.py with ordinary unit
    tests. The new tests are still fairly basic but at least test more
    than the URL tests did.

  - Made sure RFC's (and BCP/STD/FYI) are stored as RFC123 instead of
    RFC0123 in the alias table with a new migration and a change to the
    RFC Editor sync, this in turn makes /doc/std1/ do the right thing

  - Now /doc/std1/ works, we can actually do a local link in
    urlize_ietf_docs rather than linking to the tools.ietf.org server

  - Fixed history text formatter: sanitize HTML before adding linebreaks and
    non-breaking spaces, this cuts the time to render a history page with
    long comments in half

  - Added a test crawler that walks through the crawlable part of the site,
    reporting errors and slow pages

  - Got rid of initial "No record" positions when showing old positions,
    it's just noise

  - Added a .select_related() to the document main tab to reduce the number
    of DB queries, unfortunately it seems it doesn't really help with
    Django 1.2.x due to a bug (Document inherits from DocumentInfo which
    makes things a bit more complicated)

  - Introduced a simple cache in doc.get_state so repeated reads don't
    cause a DB query

  - Cleaned up the search code in preparation for removal of the shim-layer;
    use a static button and don't send extraneous GET parameters

  - Removed dead code in several places
 - Legacy-Id: 5830
2013-07-15 20:55:24 +00:00
Henrik Levkowetz 1aacb9fa45 Save document before set_state, to maintain database consistency.
- Legacy-Id: 5820
2013-07-14 14:52:00 +00:00
Henrik Levkowetz 1d7218df94 Save document before set_state, to maintain database consistency.
- Legacy-Id: 5819
2013-07-14 14:41:01 +00:00
Robert Sparks a741642717 Added editing last call messages, requesting, issuing and tracking IETF LCs to status-change documents
Added a Cancel button to the form that allows editing the relations for status-change documents
Added instructions to the agenda section 3.3

This adds states to status-change- documents and has a migration that must be applied.

This fixes bug #1039
 - Legacy-Id: 5770
2013-06-01 21:01:45 +00:00
Henrik Levkowetz bd0c07290a Merged in branch/iola/milestones, which provides datatracker support for management of WG milestones.
- Legacy-Id: 5739
2013-05-15 22:07:23 +00:00
Ole Laursen 7892e29036 Port idtracker feeds to new schema, move them to doc/, clean up
idtracker/ - only templatetags/ietf_filters and proxy code is left
 - Legacy-Id: 5643
2013-04-11 14:20:42 +00:00
Ole Laursen ec920d5a83 Add redirects for all of /idtracker/*, remove all view code and other
dead code from idtracker/
 - Legacy-Id: 5640
2013-04-11 11:54:35 +00:00
Ole Laursen 4db36b0fbc Add a generic state help page, make provisions for displaying
IESG I-D states in it
 - Legacy-Id: 5635
2013-04-10 16:11:27 +00:00
Ole Laursen 3d1eb07afe Port idindex to new schema, speed them up, add tests, refactor index
page in views_search to share code with the text index file, get rid
of some special-case idindex filters from ietf_filters, move
"/drafts/" redirects to a file in /doc/
 - Legacy-Id: 5634
2013-04-10 11:48:07 +00:00