altf4arnold/datatracker
1
0
Fork 0
Code Issues Pull requests Actions 3 Packages Projects Releases Wiki Activity
8376 commits 1 branch 0 tags 2.6 GiB
Commit graph

910 commits

Author SHA1 Message Date
Henrik Levkowetz c58c51f919 Added a migration which captures the added validator for title fields. 
- Legacy-Id: 12907
 2017-02-24 10:24:34 +00:00
Henrik Levkowetz 27351c4349 Fixed url lookups for doc.views_doc.document_main() to only use dotted-path, and removed the doc_view explicit url name. Fixes a 500 error in /submit/status/NNNN/. 
- Legacy-Id: 12897
 2017-02-22 11:40:55 +00:00
Henrik Levkowetz 988a2b808f Added explicit charset setting and consistent encoding to several email paths through the datatracker. After introducing support for non-ascii names in email addresses, using role.formatted_email() to insert names into email content doesn't work any more, since uncode names will now be rfc2047-encoded in formatted_email(). Added another method role.name_and_email() for this case. Replaced another case of '%s <%s>' name-and-email formatting with formataddr(). Fixed some tests which did not send unicode email bodies to the email functions. Fixes issue #2017. 
- Legacy-Id: 12896
 2017-02-21 19:17:10 +00:00
Henrik Levkowetz c889856dfa Added a validator to Document.title to prevent control chars in the title (complementing a recent cleanup of more than 120 instances of document titles containing vertical tabs) 
- Legacy-Id: 12893
 2017-02-20 20:47:37 +00:00
Henrik Levkowetz 8930d29a8e Merged in Django-1.10 upgrade work from ^/personal/henrik/6.43.1-django-1.10 
- Legacy-Id: 12881
 2017-02-19 18:18:00 +00:00
Henrik Levkowetz b8815b00c5 Don't use person.plain_name() when constructing email addresses, as it can contain unicode characters which the current email pipeline can't handle correctly. Use person.plain_ascii() instead (or person.formatted_email()). 
- Legacy-Id: 12865
 2017-02-16 22:59:53 +00:00
Henrik Levkowetz 74af0f5658 Replaced another bunch of explicit url names with dotted-path to the view function. 
- Legacy-Id: 12849
 2017-02-15 22:11:20 +00:00
Henrik Levkowetz 29567adf34 Merged in [12835] from rcross@amsl.com: 
Fixes #2202.  Interim sessions appear unordered.  Switch templates to use ordered assignments() related object manager.  Also removed now unused template filters.
 - Legacy-Id: 12839
Note: SVN reference [12835] has been migrated to Git commit 8607be0e21
 2017-02-14 16:22:54 +00:00
Ryan Cross 8607be0e21 Fixes #2202. Interim sessions appear unordered. Switch templates to use ordered assignments() related object manager. Also removed now unused template filters. Commit ready for merge. 
- Legacy-Id: 12835
 2017-02-13 22:30:21 +00:00
Henrik Levkowetz aa5e61d958 Updated all urlpatterns to use ietf.utils.urls.url() instead of django's, 
in order to autogenerate dotted path url pattern names.  Updated a number
of url reverses to use dotted path, and removed explicit url pattern names
as needed.

Changed some imports to prevent import of ietf.urls before django
initialization was complete.


Changed 3 cases of form classes being curried to functions; django 1.10
didn't accept that.

Started converting old-style middleware classes to new-style middleware
functions (incomplete).

Tweaked a nomcom decorator to preserve function names and attributes, like
a good decorator should.

Replaced the removed django templatetag 'removetags' with our own version
which uses bleach, and does sanitizing in addition to removing explicitly
mentionied html tags.

Rewrote the filename argument handling in a management command which had
broken with the upgrade.
 - Legacy-Id: 12818
 2017-02-11 14:43:01 +00:00
Henrik Levkowetz 19d585255a Django 1.10 does not permit the view argument to url() to be a string any more. Changed all cases view arguments to url() which were strings to instead reference the actual imported function. 
- Legacy-Id: 12815
 2017-02-10 14:49:16 +00:00
Henrik Levkowetz 088e2ca7f4 Removed dead code which used to work around a now fixed bug (and also used a now removed django function) 
- Legacy-Id: 12813
 2017-02-10 14:43:37 +00:00
Henrik Levkowetz ffb029300f Added a guard to prevent trying to get a document path for a meeting document when the document is not associated with a meeting session. 
- Legacy-Id: 12790
 2017-02-08 17:00:12 +00:00
Henrik Levkowetz 8a8283f537 Fixed a pyflakes issue. 
- Legacy-Id: 12788
 2017-02-07 17:50:06 +00:00
Henrik Levkowetz 0948c4a0f3 Applying format_html() in simple_tag-registered tags as per the suggestions for Django-1.9 upgrade wasn't straightforward. Reverting to earlier code for ballot-icond link. 
- Legacy-Id: 12782
 2017-02-02 14:24:36 +00:00
Henrik Levkowetz e94129641d @register.simple_tag now (in Django 1.9) needs explicit mark_safe() (or format_html() which invokes mark_safe()). Fixed one case which needed this. 
- Legacy-Id: 12779
 2017-02-01 20:46:51 +00:00
Henrik Levkowetz de3976bec0 Merged in Django 1.9 upgrade work from ^/personal/henrik/6.41.1-django-1.9 
- Legacy-Id: 12764
 2017-01-31 15:13:01 +00:00
Henrik Levkowetz 40e8380751 Merged django 1.9 work forward to copy of trunk @6.41.0 
- Legacy-Id: 12756
 2017-01-30 23:13:02 +00:00
Henrik Levkowetz ccfbde8d33 Fixed an issue with building links from URLs which are already part of a link. Fixes issue #2175. 
- Legacy-Id: 12742
 2017-01-26 20:11:46 +00:00
Henrik Levkowetz 0481d97650 Fixed a place where missing queryargument data could cause a 500 error. 
- Legacy-Id: 12741
 2017-01-26 19:24:34 +00:00
Henrik Levkowetz 2ab4caa90f Merged in [12722] from rjsparks@nostrum.com: 
Added programs to the datatracker. Added use of restructuredtext for group about pages. Generalized several places where code handles different group types. Improved testing of group about.
 - Legacy-Id: 12725
Note: SVN reference [12722] has been migrated to Git commit e0ea8b0f57
 2017-01-24 21:30:10 +00:00
Robert Sparks e0ea8b0f57 Added programs to the datatracker. Added use of restructuredtext for group about pages. Generalized several places where code handles different group types. Improved testing of group about. Commit ready for merge. 
- Legacy-Id: 12722
 2017-01-24 19:55:49 +00:00
Henrik Levkowetz e2640f358b Changed semantics for can_manage_group() to include chairs etc, and changed calls with the old semantics to use can_manage_group_type(). Rewrote can_manage_group() in terms of can_manage_group_type() and additional checks. Fixes issue #2155. 
- Legacy-Id: 12719
 2017-01-23 22:54:36 +00:00
Henrik Levkowetz 5a5bb1f03f Removed useless code. 
- Legacy-Id: 12718
 2017-01-23 21:29:36 +00:00
Henrik Levkowetz 613f0c8233 Pyflakes fixes. 
- Legacy-Id: 12714
 2017-01-23 18:35:58 +00:00
Henrik Levkowetz ef1b404fe3 Removed an extraneous request parameter. 
- Legacy-Id: 12712
 2017-01-23 18:21:15 +00:00
Henrik Levkowetz 6de7be6953 Specified strip=False for another bunch of CharField form fields with Textarea widgets. 
- Legacy-Id: 12711
 2017-01-23 17:38:56 +00:00
Henrik Levkowetz fa60671148 Fixed another instance of '=' being used for comparison in a template. 
- Legacy-Id: 12708
 2017-01-19 21:21:10 +00:00
Henrik Levkowetz 1dba613197 Merged in [12675] from rjsparks@nostrum.com: 
Removed some unnecessary randomness in tests introduced in last commit.
 - Legacy-Id: 12678
Note: SVN reference [12675] has been migrated to Git commit 4f2f691de6
 2017-01-19 17:24:08 +00:00
Henrik Levkowetz fd2304e446 In Django 1.9, CharField form fields will be whitespace-stripped by default. Added strip=False for the status change review form content. Also removed a superfluous f.close(). 
- Legacy-Id: 12677
 2017-01-19 17:15:28 +00:00
Henrik Levkowetz 7c2a161a5f Removed some remaining instances of render using context_instance. Fixed a case of tuple length of list of tuples passed to a template to be the same for all tuples. 
- Legacy-Id: 12676
 2017-01-19 17:08:27 +00:00
Robert Sparks 4f2f691de6 Removed some unnecessary randomness in tests introduced in last commit. Commit ready for merge. 
- Legacy-Id: 12675
 2017-01-19 16:37:00 +00:00
Henrik Levkowetz b4480a1625 Merged in [12670] from rjsparks@nostrum.com: 
Make changing skip_next on a review assignment an explicit decision of the assigner.  Fixes #2148.
 - Legacy-Id: 12671
Note: SVN reference [12670] has been migrated to Git commit 8e007ce50b
 2017-01-19 15:25:22 +00:00
Robert Sparks 8e007ce50b Make changing skip_next on a review assignment an explicit decision of the assigner. Commit ready for merge. Fixes #2148. 
- Legacy-Id: 12670
 2017-01-19 14:23:09 +00:00
Henrik Levkowetz 79dc639f46 Merged in [12665] from rjsparks@nostrum.com: 
Make it easier to see who's really next in reviewer rotation.
 - Legacy-Id: 12668
Note: SVN reference [12665] has been migrated to Git commit 49dcf67fd5
 2017-01-18 16:30:29 +00:00
Henrik Levkowetz dd82df50a1 Merged in [12627] from rjsparks@nostrum.com: 
Added some convenience navigation for review team secretaries to the menu. Restructured the menu lightly around Documents and Role-related links. Added navigation from a reviewers \'My Reviews\' page back to the review team pages. Fixes #2079.
 - Legacy-Id: 12667
Note: SVN reference [12627] has been migrated to Git commit 41d3bb61b4
 2017-01-18 15:55:11 +00:00
Henrik Levkowetz 7a8555599f Added a link to the group datatracker page to the new group announcement (and review) emails. Fixes issue #2140. 
- Legacy-Id: 12666
 2017-01-17 22:22:46 +00:00
Robert Sparks 0dd2e460f3 Make it easier to see what reviews need to be closed as "No Response". Fixes #2128. Commit ready for merge. 
- Legacy-Id: 12664
 2017-01-17 21:04:42 +00:00
Henrik Levkowetz 7b95411f58 The context_instance parameter to render_to_response() and render_to_string() is now deprecated. Fixed this, and generally changed the idiom render_to_response('template.html', {}, RequestContext(request)) to the newer and simpler render(request, 'template.html', {}). About 200 instances. 
- Legacy-Id: 12637
 2017-01-09 21:26:30 +00:00
Henrik Levkowetz a21812633d Removed unnecessary leading slash in url pattern, silencing a system check warning. 
- Legacy-Id: 12632
 2017-01-09 16:28:59 +00:00
Robert Sparks 41d3bb61b4 Added some convenience navigation for review team secretaries to the menu. Restructured the menu lightly around Documents and Role-related links. Added navigation from a reviewers "My Reviews" page back to the review team pages. Fixes #2079. Commit ready for merge. 
- Legacy-Id: 12627
 2016-12-23 21:20:55 +00:00
Henrik Levkowetz 5cc3b6448e Django 1.9: Removed additional instances of deprecated django.conf.urls.patterns() 
- Legacy-Id: 12623
 2016-12-22 18:14:57 +00:00
Henrik Levkowetz d5460b8f7f Django 1.9: Merged work forward to copy of latest release. 
- Legacy-Id: 12621
 2016-12-22 17:30:50 +00:00
Henrik Levkowetz c2541ec04b Django 1.9: Removed deprecated use of django.conf.urls.patterns() from all urls*.py files. 
- Legacy-Id: 12618
 2016-12-22 17:21:57 +00:00
Robert Sparks 6091d3c6a3 Tweak the docevent description for the event noting that a chartering effort has been abandoned. Fixes #2099. Commit ready for merge. 
- Legacy-Id: 12606
 2016-12-21 22:14:58 +00:00
Robert Sparks 6ca953ae24 Improve the team review content templates. Related to #2075. Commit ready for merge. 
- Legacy-Id: 12595
 2016-12-20 05:38:02 +00:00
Robert Sparks fbd2cd493d Provide templates for directly entered review contents for those teams/review-types that have them. Fixes #2075. Commit ready for merge. 
- Legacy-Id: 12594
 2016-12-19 23:21:11 +00:00
Robert Sparks 10f4892eae Send mail to team secretaries when a review is explicitly requested. Change the From and Subject for assignment emails to reviewers to make it clearer what the review is for and who assigned it. Fixes #2053 and #2114. Commit ready for merge. 
- Legacy-Id: 12593
 2016-12-19 22:32:03 +00:00
Robert Sparks 7c182375af Change how we display review text to follow the tecnique used with other large blocks of pasted or imported text (shepherds writeups for instance). Fixes #2104. Commit ready for merge. 
- Legacy-Id: 12588
 2016-12-19 20:38:51 +00:00
Henrik Levkowetz ff3638e365 Merged in [12549] from rjsparks@nostrum.com: 
allow ads and secretaries to edit the review request comment. Fixes #2096. (Again).
 - Legacy-Id: 12550
Note: SVN reference [12549] has been migrated to Git commit 32b431cf24
 2016-12-15 23:10:28 +00:00