altf4arnold/datatracker
1
0
Fork 0
Code Issues Pull requests Actions 3 Packages Projects Releases Wiki Activity
16512 commits 1 branch 0 tags 2.6 GiB
Commit graph

150 commits

Author SHA1 Message Date
Ole Laursen 7f277a8fbb Replace user.get_profile() with user.person, the profile stuff is deprecated since Django 1.5 
- Legacy-Id: 6968
 2013-12-18 10:13:40 +00:00
Ole Laursen d66ac15fc2 Rewrite a bunch of HttpResponseRedirect + url reverse calls to instead 
take advantage of the redirect shortcut (introduced in Django 1.1)
 - Legacy-Id: 6960
 2013-12-17 10:23:42 +00:00
Ole Laursen 9457669310 Merge in changes from the old shimfree branch 
- Legacy-Id: 6764
 2013-11-27 12:55:50 +00:00
Ole Laursen 650d8316eb Make the submit tool use the access token framework with a bit of backwards compatibility glue 
- Legacy-Id: 6717
 2013-11-15 16:09:05 +00:00
Ole Laursen ecf68dbb05 Revamp and clean up submit models: 
- Rename IdSubmissionDetail to Submission
- Rename various submission fields to correspond to the conventions in
  the new schema
- Use a name model for the states instead of IdSubmissionStatus
- Drop the TempIdAuthor model which is based on splitting up author
  names
- Add a simple textual SubmissionEvent for tracking events in the
  lifetime of a submission
- Delete a bunch of obsolete fields
- Make sure all submission have an access key so we can depend on it
- Add state for when approval is needed from previous authors

A couple of migrations take care of transforming the
IdSubmissionDetail and moving data over/cleaning it up.

Also revamp the submit view code:

- Make form code do validation/cleaning only so there's a clear
  separation of concerns
- Reduce uses of inheritance that made the code hard to follow -
  forms now don't inherit from each other, views don't call each other
  but instead reuse common utilities, templates share CSS/utilities
  instead of relying on inheritance
- Move email rendering/sending to separate file
- Drop the in-grown terminology use (auto post vs. manual posts)
- Make the status page explain who is emailed for what purpose
- Add history table with recorded events
- Make the status page handle its post actions by itself instead of
  duplicating most of the setup logic in a number of simple views
- Fix a couple of minor bugs and handle some edge cases better
- Expand tests with a couple of more cases

Possibly the submit tool could still use more help text added to
explain the process, ideally what's explained in the tool instructions
page should be inlined or self-evident.
 - Legacy-Id: 6714
 2013-11-15 13:30:32 +00:00
Henrik Levkowetz 71d797bcb8 Refines Joel's fix to show clearly who receives draft submission confirmation emails, to show a more detailed warning text when the submitter isn't in the addressee list. Fixes issue #1097. 
- Legacy-Id: 6659
 2013-11-06 15:29:02 +00:00
Ole Laursen 2daff23f02 Remove shim layer from submit code 
- Legacy-Id: 6654
 2013-11-05 16:59:13 +00:00
Joel M. Halpern 72885f4524 Include confirmation addresses in ID-Submission success notice. 
Fixes issue #1097.
 - Legacy-Id: 6638
 2013-11-02 23:29:21 +00:00
Henrik Levkowetz 1dae75ee59 The exception string for submission upload read errors seems to have changed after we switched to wsgi, from "Client read error" to "request data read error". Now looking for just "read error". 
- Legacy-Id: 6264
 2013-09-26 06:29:28 +00:00
Henrik Levkowetz 08f5d1dc08 Preparatory work for adding a 'Replaces' field to the draft submission tool. 
- Legacy-Id: 5719
 2013-05-09 20:08:40 +00:00
Henrik Levkowetz 1fbcd783f3 Merged branch/iola/statesync up to @5118 to trunk. 
- Legacy-Id: 5147
 2012-12-20 20:32:03 +00:00
Ole Laursen c20a5f6bf0 Convert the submit tool to associate RGs and IAB with drafts instead 
of assigning them to individual submission, this is not a complete
overhaul but at least basic support so submission works and doesn't
say WG when it means RG.
 - Legacy-Id: 4910
 2012-10-10 16:15:09 +00:00
Henrik Levkowetz 40081edc27 Don't try to add a ballot's AD email addresses to a new version notification email if there's no ballot. Also did some linguistic fixes, and got rid of a wildcard import. 
- Legacy-Id: 4809
 2012-08-24 08:49:32 +00:00
Ole Laursen ed96cee2e4 Add listing of recently approved drafts to approval page by request 
from Barry Leiba.
 - Legacy-Id: 4420
 2012-05-14 18:21:34 +00:00
Ole Laursen c2b8c653fd Fix bug in submit, had forgotten I had replaced filename with name in 
Preapproval model.
 - Legacy-Id: 4413
 2012-05-10 18:22:03 +00:00
Ole Laursen 188c0846d0 Add approval/pre-approval page for Secretariat and WG Chairs, with 
subpages for adding and canceling pre-approvals and a set of
migrations for replacing the old IdApprovedDetail with a slightly less
confusing Preapproval model.
 - Legacy-Id: 4411
 2012-05-10 18:07:59 +00:00
Ole Laursen 8153a1c130 Patch up to pass request object to send mail in the instances where 
it's possible (i.e. when not run in cron) in preparation for better
mail test handling
 - Legacy-Id: 3711
 2011-11-25 18:24:14 +00:00
Ole Laursen 5a4c23ea92 Merge with trunk 
- Legacy-Id: 3676
 2011-11-21 16:41:21 +00:00
Henrik Levkowetz 35f89e0288 Improved handling of a particular IO Error that sometimes occur during draft submission. 
- Legacy-Id: 3552
 2011-10-28 08:47:28 +00:00
Henrik Levkowetz eae680f3ac Revert part of the change to this view -- there was a reason for catching the IOException, but it caught much more than was good... 
- Legacy-Id: 3517
 2011-10-25 16:12:48 +00:00
Henrik Levkowetz f3d31f0e97 Don't hide exceptions by returning a blank form when something goes wrong -- there's been temporary upload failures for some time, which have been difficult to trace and debug because the error condition has been hidden. 
- Legacy-Id: 3514
 2011-10-25 14:57:35 +00:00
Ole Laursen 6f10d2f3f7 Port submit to new schema, adding a set of tests and fixing some bugs 
- Legacy-Id: 3436
 2011-09-21 19:29:50 +00:00
Henrik Levkowetz f598e4b265 Make the cancel button available to the secretariat also when not coming in through the submission-hash URL. 
- Legacy-Id: 3196
 2011-07-23 11:58:33 +00:00
Henrik Levkowetz cf10bc0fd0 Catch exceptions from cancelled uploads. 
- Legacy-Id: 3110
 2011-05-10 12:11:32 +00:00
Henrik Levkowetz 8b1138b447 Merged in changes from esanchez@yaco.es, changesets [3063],[3064],[3065],[3075],[3076],[3078] and [3085]. Fixes submission tool issues with wrong expected version for recently expired drafts, lacking announcement emails, too narrow date tolerance, and server state changes being possible through http GET, and more; with minor tweaks to setting names in settings.py. 
- Legacy-Id: 3086
Note: SVN reference [3063] has been migrated to Git commit af039fba02

Note: SVN reference [3064] has been migrated to Git commit fe466900e1

Note: SVN reference [3065] has been migrated to Git commit be0f5e4962

Note: SVN reference [3075] has been migrated to Git commit e0f4185c54

Note: SVN reference [3076] has been migrated to Git commit ccfd8b5eed

Note: SVN reference [3078] has been migrated to Git commit fe699f7062

Note: SVN reference [3085] has been migrated to Git commit 7fb27754f7
 2011-05-03 21:41:53 +00:00
Emilio A. Sánchez López fe466900e1 Insert a button to perform the last step of autopost via POST request. Fixes #650 
- Legacy-Id: 3064
 2011-04-26 14:54:16 +00:00
Emilio A. Sánchez López 23d0ddf7e4 Ensure that 'get full url', 'approve' and 'force' views are called via POST request. See #650 
- Legacy-Id: 3062
 2011-04-26 14:35:07 +00:00
Emilio A. Sánchez López 8239d6bb80 Do not allow cancel submissions with GET requests. See #650 
- Legacy-Id: 3061
 2011-04-26 14:28:10 +00:00
Henrik Levkowetz fe10dfd20c Tweaked a number of setting value names and adjusted one value. 
- Legacy-Id: 3037
 2011-04-09 22:13:45 +00:00
Emilio A. Sánchez López 6f6d720daa Get author information from the tuple of draft.py. Do not mark as error if some author has no email. Fixes #626 
- Legacy-Id: 2900
 2011-03-23 09:53:25 +00:00
Emilio A. Sánchez López 883ec1d1d1 Do not require approval for individual submissions. Fixes #623 
- Legacy-Id: 2895
 2011-03-17 17:26:29 +00:00
Emilio A. Sánchez López 8db45b0bb9 Fixed grammar nit. Fixes #620 
- Legacy-Id: 2894
 2011-03-17 17:13:35 +00:00
Emilio A. Sánchez López 917d287182 Button to request the full access url of a submission. Fixes #618 
- Legacy-Id: 2890
 2011-03-17 12:14:53 +00:00
Emilio A. Sánchez López cc6af53359 Require submission hash in the url to perfom edit/post/cancel actions as a non secretariat user. See #618 
- Legacy-Id: 2889
 2011-03-17 10:38:32 +00:00
Emilio A. Sánchez López e20afe45e8 Do not allow to cancel already posted submissions. See #614 
- Legacy-Id: 2884
 2011-03-12 16:35:05 +00:00
Emilio A. Sánchez López d08c515e78 Fixed 'post first-click' bug. 
Added domain into email with authorization key.
Extend the type of submission that secretariat can cancel or autopost. Fixes #614
 - Legacy-Id: 2882
 2011-03-12 16:22:44 +00:00
Emilio A. Sánchez López cf455f5be2 Add a warning when submitting a draft that belongs to a non active WG. Fixes #607 
- Legacy-Id: 2877
 2011-03-03 18:03:47 +00:00
Emilio A. Sánchez López 3bd2097171 Customize mail sent to WG chairs requesting submission approval. 
Added the domain of the tool to the url.
Save the submitter info.
Fixes #606
 - Legacy-Id: 2876
 2011-03-03 17:27:06 +00:00
Emilio A. Sánchez López cd03c2109a Remove docs when canceling submission. Fixes #598 
- Legacy-Id: 2857
 2011-02-14 18:51:36 +00:00
Emilio A. Sánchez López cfaed84ba5 Authenticated post actions. Fixes #597 
- Legacy-Id: 2850
 2011-02-11 13:12:37 +00:00
Jacobo Tarragón 512f179a45 Check for WG approval before posting. Closes #596. 
- Legacy-Id: 2848
 2011-02-11 11:21:42 +00:00
Emilio A. Sánchez López 3942d63733 Recover confirmation url and fix draft_status template. Fixes #591 
- Legacy-Id: 2847
 2011-02-10 20:01:49 +00:00
Jacobo Tarragón 04c4043e25 allowing submissions to be canceled. Closes #591. 
- Legacy-Id: 2846
 2011-02-10 19:08:29 +00:00
Emilio A. Sánchez López 7c79a4d707 Edit of metadata and request manual post. See #595 
- Legacy-Id: 2845
 2011-02-10 18:29:37 +00:00
Emilio A. Sánchez López 63d78edc0d DoS Tresholds. Retrieve WG in a previous stage. Fixes #592 
- Legacy-Id: 2837
 2011-02-09 20:12:12 +00:00
Emilio A. Sánchez López 6aa16f2762 Show state of a previous submission. Fixes #590 
- Legacy-Id: 2836
 2011-02-09 17:14:50 +00:00
Emilio A. Sánchez López 86229aa478 Saving files in staging area. 
Saving information of upload in database.
Executing idnits.
Fixes #589
 - Legacy-Id: 2835
 2011-02-09 10:42:37 +00:00
Emilio A. Sánchez López c0f0d2c237 Two levels of parsing. Fixes #584 
- Legacy-Id: 2819
 2011-02-08 08:26:12 +00:00
Emilio A. Sánchez López 4bc95f6436 Cutoff dates and basic checkings over the plain file. See #580 
- Legacy-Id: 2806
 2011-02-03 11:46:04 +00:00
Emilio A. Sánchez López 8c5ffce3eb Submit application skel, some direct templates and a very basic form. Fixes #575 
- Legacy-Id: 2766
 2011-01-27 19:35:59 +00:00