Commit graph

125 commits

Author SHA1 Message Date
Henrik Levkowetz 68b05b609a Various fixes due to clear up tree conflicts and other bugs resulting from
the [5830] merge.
 - Legacy-Id: 5834
Note: SVN reference [5830] has been migrated to Git commit e678659b56
2013-07-16 14:02:43 +00:00
Henrik Levkowetz e678659b56 Merged in a lot of shim-layer removals from olau@iola.dk
(-r5194:5465 from branch/iola/shimfree).  Copying relevant
commit messages here:

  - Removed .related many to many relationship, it's not really useful
    since we always have to restrict on the relationship type anyway,
    instead add two helpers for doing the necessary queries (in both
    directions)

  - Added migration for transforming the .desc on the new_revision events
    into something more akin to what is actually shown in the history page

  - Added migration for blanking IESG notes that just consist of "RFC
    XXXX", these have been superfluous for some time

  - Grant stream chairs access to changing the stream on a draft

  - Hacked the format_history_text filter to be less weird, using the same
    formatting for snippets and full text, also link up legacy ballot set
    events

  - Moved the decoraters + utilities to new ietfauth/utils.py file

  - Added simple helper to Email to identify invalid email addresses (from
    legacy author entries)

  - Used new new_revision .desc format for when drafts are submitted

  - Improved the looks of the button class by adding extra contrast and a
    linear gradient. Currently the gradient is only visible in fairly
    recent browsers.

  - Rewrote draft and RFC tabs in terms of the new schema, porting
    write-up and history tabs as well

  - Fixed two bugs in RFC Editor syncing: make sure documents we don't know
    beforehand get a "draft" type and make sure individually submitted
    drafts get the type="individ" group instead of NULL

  - Made the CSS-styled button feel a bit nicer to use by flattening the
    active state, also introduce some temporary styles until browsers
    catch up with the standard syntax

  - Added migrations for fixing 1) a dummy RFC entry, 2) three stand-alone
    RFCs that didn't get their doc.type set, 3) a big bunch of historic
    stand-alone RFCs that have doc.group=None - set these to the
    individual submission "none" group for the time being so the view code
    doesn't have to deal with a special case.

    In some cases this is wrong since there actually was a WG associated
    but unfortunately fixing them properly requires detective work
    (probably parsing the RFCs) and in at least some cases recreating
    historic WGs. In case someone ends up doing this, the documents to
    check can still be found with

    Document.objects.filter(name__startswith="rfc", group__type="individ")
    since there are almost no new RFCs that didn't went through the I-D
    process.

  - Merged the I-D and RFC views by showing I-D information on RFCs too.
    I-Ds that have been published as RFCs redirect to the RFC URL. Also
    support alias URLs so e.g. /doc/bcpXXXX redirects to /doc/rfcXXXX.

  - Fixed revision augmentation so events after RFC publication gets a "RFC"
    designation

  - Fixed a bug with tabs not using provided name but rather doc.name

  - Displaying draft-iesg state rather than doc.friendly_state as IESG state,
    also show a notice that the IESG state refers to post-RFC processing
    if it does, like the old separate RFC page did

  - Fixed the RFC number doc.note migration to catch combined "RFC XXX; BCP
    XXX" notes too, use the opportunity to remove inserted HTML tags from
    notes and rely on linebreaksbr filter instead (the other thing was a
    left-over from the Perl days), update the various uses of the note to
    reflect that

  - Refactored slightly to make views_doc.py independent of other idrfc code

  - Moveed idrfc/views_doc.py to doc/ with associated templates, replace the
    somewhat fragile simple URL tests for views_doc.py with ordinary unit
    tests. The new tests are still fairly basic but at least test more
    than the URL tests did.

  - Made sure RFC's (and BCP/STD/FYI) are stored as RFC123 instead of
    RFC0123 in the alias table with a new migration and a change to the
    RFC Editor sync, this in turn makes /doc/std1/ do the right thing

  - Now /doc/std1/ works, we can actually do a local link in
    urlize_ietf_docs rather than linking to the tools.ietf.org server

  - Fixed history text formatter: sanitize HTML before adding linebreaks and
    non-breaking spaces, this cuts the time to render a history page with
    long comments in half

  - Added a test crawler that walks through the crawlable part of the site,
    reporting errors and slow pages

  - Got rid of initial "No record" positions when showing old positions,
    it's just noise

  - Added a .select_related() to the document main tab to reduce the number
    of DB queries, unfortunately it seems it doesn't really help with
    Django 1.2.x due to a bug (Document inherits from DocumentInfo which
    makes things a bit more complicated)

  - Introduced a simple cache in doc.get_state so repeated reads don't
    cause a DB query

  - Cleaned up the search code in preparation for removal of the shim-layer;
    use a static button and don't send extraneous GET parameters

  - Removed dead code in several places
 - Legacy-Id: 5830
2013-07-15 20:55:24 +00:00
Henrik Levkowetz 1aacb9fa45 Save document before set_state, to maintain database consistency.
- Legacy-Id: 5820
2013-07-14 14:52:00 +00:00
Henrik Levkowetz 1d7218df94 Save document before set_state, to maintain database consistency.
- Legacy-Id: 5819
2013-07-14 14:41:01 +00:00
Robert Sparks a741642717 Added editing last call messages, requesting, issuing and tracking IETF LCs to status-change documents
Added a Cancel button to the form that allows editing the relations for status-change documents
Added instructions to the agenda section 3.3

This adds states to status-change- documents and has a migration that must be applied.

This fixes bug #1039
 - Legacy-Id: 5770
2013-06-01 21:01:45 +00:00
Henrik Levkowetz bd0c07290a Merged in branch/iola/milestones, which provides datatracker support for management of WG milestones.
- Legacy-Id: 5739
2013-05-15 22:07:23 +00:00
Henrik Levkowetz 0a76a26ed7 Fixed the additional nit mentioned in issue #974 better. Together with earlier commits, this fixes #974.
- Legacy-Id: 5632
2013-04-08 20:21:09 +00:00
Henrik Levkowetz 7a98fff79c Merged [5476] from rjsparks@nostrum.com:
* Added a document type for changing the publication status of other documents, and the UI for manipulating them.
* Added charters, conflict reviews, and status changes to the AD's \'My Documents\' page
* Improved the presentation of all document types on the Agenda, Future Telechats, Scribe and Moderator package pages
* Made the reverse name for document relationships explicit rather than deriving them from forward names
* Added a way to get to the underlying Document (when it exists) from an RfcWrapper
* Unified several common forms used by different document types
 - Legacy-Id: 5629
Note: SVN reference [5476] has been migrated to Git commit 10b4f7a4dc
2013-04-07 19:11:18 +00:00
Henrik Levkowetz 7ac4113751 Import math as needed. Related to [5626] and issue #974.
- Legacy-Id: 5628
Note: SVN reference [5626] has been migrated to Git commit fb1df9e2eb
2013-04-07 17:10:19 +00:00
Henrik Levkowetz f3833e1d17 Fixed another issue with the ballot counts (unreachable code). See issue #974.
- Legacy-Id: 5627
2013-04-05 14:07:59 +00:00
Henrik Levkowetz fb1df9e2eb Fixed the ballots needed count error in two more places. See issue #974.
- Legacy-Id: 5626
2013-04-05 14:06:13 +00:00
Henrik Levkowetz b183273c72 Add new tag 'rev-wg' to the list of valid annotation tags for the ietf stream. Note: This list and those on nearby lines needs to be refactored into a table, instead of sitting in the code.
- Legacy-Id: 5623
2013-04-05 11:19:35 +00:00
Joel M. Halpern fe13ee8dfa Repair the ballot requirements string
- Legacy-Id: 5516
2013-03-09 18:30:29 +00:00
Henrik Levkowetz 2f3476690f In order that document states (which may be used by old documents) should not need to be removed when state machines change and states go out of use, all document states have a 'used' field. The code which accesses the state fields have not been requiring that used=True for the states returned, which is an error. Fixed this by adding 'used=True' to all State.objects.get() and State.objects.filter() call where it's relevant.
- Legacy-Id: 5486
2013-03-05 23:24:41 +00:00
Robert Sparks 10b4f7a4dc * Added a document type for changing the publication status of other documents, and the UI for manipulating them.
* Added charters, conflict reviews, and status changes to the AD's "My Documents" page
* Improved the presentation of all document types on the Agenda, Future Telechats, Scribe and Moderator package pages
* Made the reverse name for document relationships explicit rather than deriving them from forward names
* Added a way to get to the underlying Document (when it exists) from an RfcWrapper
* Unified several common forms used by different document types
 - Legacy-Id: 5476
2013-03-01 15:47:51 +00:00
Robert Sparks 33e2a0766e Repairing migration merge conflict
- Legacy-Id: 5423
2013-02-04 02:34:01 +00:00
Robert Sparks 8a7c5ac977 All documents show on the AD status page now
- Legacy-Id: 5422
2013-02-04 02:24:14 +00:00
Robert Sparks c67661311f Improved validaiton of status change document name
added the ability to start a status change when looking at an RFC (populating the start from accordingly)
Made changes and proposed changes show on the RFC pages
 - Legacy-Id: 5330
2013-01-28 16:25:42 +00:00
Robert Sparks 589ff698ee Merge forward complete
- Legacy-Id: 5328
2013-01-24 21:28:27 +00:00
Ole Laursen 4b312de464 Introduce a simple cache in doc.get_state so repeated reads don't
cause a DB query
 - Legacy-Id: 5314
2013-01-21 14:01:33 +00:00
Ole Laursen 06f4ed4cf3 Add a .select_related() to the document main tab to reduce the number
of DB queries, unfortunately it seems it doesn't really help with
Django 1.2.x due to a bug (Document inherits from DocumentInfo which
makes things a bit more complicated)
 - Legacy-Id: 5313
2013-01-21 12:27:26 +00:00
Ole Laursen ab6a7f85c0 Get rid of initial "No record" positions when showing old positions,
it's just noise
 - Legacy-Id: 5312
2013-01-21 11:54:56 +00:00
Ole Laursen 9bcc4a9f3d Remove ballot.tsv view and comment out the ballot.json view in urls.py
- Legacy-Id: 5299
2013-01-18 13:54:33 +00:00
Ole Laursen 7998371ace Make sure RFC's (and BCP/STD/FYI) are stored as RFC123 instead of
RFC0123 in the alias table with a new migration and a change to the
RFC Editor sync, this in turn makes /doc/std1/ do the right thing
 - Legacy-Id: 5296
2013-01-18 13:47:31 +00:00
Ole Laursen accf6d4470 Move idrfc/views_doc.py to doc/ with associated templates, replace the
somewhat fragile simple URL tests for views_doc.py with ordinary unit
tests. The new tests are still fairly basic but at least test more
than the URL tests did.
 - Legacy-Id: 5295
2013-01-18 13:17:00 +00:00
Ole Laursen 1a3aa3b443 Refactor slightly to make views_doc.py independent of other idrfc code
- Legacy-Id: 5294
2013-01-18 10:32:05 +00:00
Ole Laursen ce081cb31d Fix the RFC number doc.note migration to catch combined "RFC XXX; BCP
XXX" notes too, use the opportunity to remove inserted HTML tags from
notes and rely on linebreaksbr filter instead (the other thing was a
left-over from the Perl days), update the various uses of the note to
reflect that
 - Legacy-Id: 5289
2013-01-17 17:10:19 +00:00
Ole Laursen 188c619635 Display draft-iesg state rather than doc.friendly_state as IESG state,
also show a notice that the IESG state refers to post-RFC processing
if it does, like the old separate RFC page did
 - Legacy-Id: 5288
2013-01-17 16:02:50 +00:00
Ole Laursen 5efcc5fbef Fix revision augmentation so events after RFC publication gets a "RFC"
designation
 - Legacy-Id: 5286
2013-01-17 15:39:57 +00:00
Ole Laursen c0ecb78761 Merge the I-D and RFC views by showing I-D information on RFCs too.
I-Ds that have been published as RFCs redirect to the RFC URL. Also
support alias URLs so e.g. /doc/bcpXXXX redirects to /doc/rfcXXXX.
 - Legacy-Id: 5285
2013-01-17 13:28:42 +00:00
Ole Laursen a6a0596be6 Add migration for fixing 1) a dummy RFC entry, 2) three stand-alone
RFCs that didn't get their doc.type set, 3) a big bunch of historic
stand-alone RFCs that have doc.group=None - set these to the
individual submission "none" group for the time being so the view code
doesn't have to deal with a special case.

In some cases this is wrong since there actually was a WG associated
but unfortunately fixing them properly requires detective work
(probably parsing the RFCs) and in at least some cases recreating
historic WGs. In case someone ends up doing this, the documents to
check can still be found with

Document.objects.filter(name__startswith="rfc", group__type="individ")

since there are almost no new RFCs that didn't went through the I-D
process.
 - Legacy-Id: 5284
2013-01-17 13:00:36 +00:00
Ole Laursen aa70cffe73 Rewrite draft and RFC tabs in terms of the new schema, porting
write-up and history tabs as well
 - Legacy-Id: 5214
2013-01-16 14:57:01 +00:00
Ole Laursen 4624f4a31c Add migration for blanking IESG notes that just consist of "RFC
XXXX", these have been superfluous for some time
 - Legacy-Id: 5207
2013-01-16 14:20:20 +00:00
Ole Laursen e8daf2fbdf Add migration for transforming the .desc on the new_revision events
into something more akin to what is actually shown in the history page
 - Legacy-Id: 5206
2013-01-16 14:17:07 +00:00
Ole Laursen 6e45e5e17b Remove .related many to many relationship, it's not really useful
since we always have to restrict on the relationship type anyway,
instead add two helpers for doing the necessary queries (in both
directions)
 - Legacy-Id: 5205
2013-01-16 14:15:18 +00:00
Ole Laursen 6e89f3b606 Merge changes from old milestones branch
- Legacy-Id: 5198
2013-01-15 16:45:19 +00:00
Henrik Levkowetz 1fbcd783f3 Merged branch/iola/statesync up to @5118 to trunk.
- Legacy-Id: 5147
2012-12-20 20:32:03 +00:00
Ole Laursen b19f6d8060 Merge in milestones branch
- Legacy-Id: 5091
2012-12-03 14:36:30 +00:00
Ole Laursen 6c91e93886 Allow State.next_states to be blank so the admin doesn't barf
- Legacy-Id: 5023
2012-11-07 14:57:04 +00:00
Ole Laursen 9b73aa30b9 Add migration for DeletedEvent
- Legacy-Id: 5022
2012-11-07 14:55:58 +00:00
Ole Laursen 730cd6056e Add DeletedEvent for storing redacted events
- Legacy-Id: 5021
2012-11-07 14:55:39 +00:00
Ole Laursen a77b2ae0ab Add missing admin entries for StateDocEvent and ConsensusDocEvent
- Legacy-Id: 5006
2012-11-05 13:32:31 +00:00
Henrik Levkowetz 5eeb670b28 Merged [4909] from rjsparks@nostrum.com:
Reimplemented clear_ballot to close the existing ballot and create a new one. Changed the all_positions code to only return synthetic no-positions for current ADs when a ballot is actually open
 - Legacy-Id: 4962
Note: SVN reference [4909] has been migrated to Git commit 2e6caa21b1
2012-10-30 12:07:10 +00:00
Henrik Levkowetz 8493ce7e38 Merged [4885] from rjsparks@nostrum.com:
refactored close_open_ballots, creating a way to close one abllot at a time. rewrote the clear ballot code to close each open ballot and open a new one
 - Legacy-Id: 4960
Note: SVN reference [4885] has been migrated to Git commit b3bdbc9506
2012-10-30 12:06:15 +00:00
Henrik Levkowetz 6e4d27ca5b Added a management command to generate bibxml files for drafts. It's not fully cooked yet, as it needs to differentiate between documents which are currently drafts, and those that have been published as RFCs, but the basics are there.
- Legacy-Id: 4953
2012-10-25 21:18:06 +00:00
Henrik Levkowetz 0efc882252 Merged [4873] from rjsparks@nostrum.com:
Includes the conflict-review document contents in the email sent with the results of the conflict review.
Fixes bug #883
 - Legacy-Id: 4944
Note: SVN reference [4873] has been migrated to Git commit d6579c63e6
2012-10-21 21:02:03 +00:00
Ole Laursen e87b8483e5 Add migration script for setting the group on IAB stream documents to
IAB and IRTF stream documents to the corresponding RG (if it exists),
instead of keeping it as individual submission
 - Legacy-Id: 4911
2012-10-11 15:26:21 +00:00
Robert Sparks 2e6caa21b1 Reimplemented clear_ballot to close the existing ballot and create a new one. Changed the all_positions code to only return synthetic no-positions for current ADs when a ballot is actually open
- Legacy-Id: 4909
2012-10-10 15:48:34 +00:00
Ole Laursen a8671798fd Return None explicitly rather than implicitly
- Legacy-Id: 4886
2012-09-28 14:49:37 +00:00
Robert Sparks b3bdbc9506 refactored close_open_ballots, creating a way to close one abllot at a time. rewrote the clear ballot code to close each open ballot and open a new one
- Legacy-Id: 4885
2012-09-27 21:41:11 +00:00